Re: [PATCH rdma-next 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-08 Thread Jason Gunthorpe
On Tue, Sep 08, 2020 at 05:54:09PM +0200, Christoph Hellwig wrote: > Given that ARCH_NO_SG_CHAIN is only true for alpha, parisc and a few > arm subarchitectures I think just not supporting umem is probably > cleared. And eventually we'll need to drop ARCH_NO_SG_CHAIN entirely. It would be fine to

Re: [PATCH] PCI: tegra: Convert to MSI domains

2020-09-04 Thread Jason Gunthorpe
On Fri, Sep 04, 2020 at 02:28:27PM +0200, Thierry Reding wrote: > On Fri, Sep 04, 2020 at 08:45:01AM -0300, Jason Gunthorpe wrote: > > On Fri, Sep 04, 2020 at 12:56:13PM +0200, Thierry Reding wrote: > > > +static void tegra_msi_irq_mask(struct irq_data *d) > > > +{ &g

Re: [PATCH] PCI: tegra: Convert to MSI domains

2020-09-04 Thread Jason Gunthorpe
On Fri, Sep 04, 2020 at 12:56:13PM +0200, Thierry Reding wrote: > +static void tegra_msi_irq_mask(struct irq_data *d) > +{ > + struct tegra_msi *msi = irq_data_get_irq_chip_data(d); > + struct tegra_pcie *pcie = msi_to_pcie(msi); > + unsigned int index = d->hwirq / 32; > + u32 value

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-03 Thread Jason Gunthorpe
On Thu, Sep 03, 2020 at 06:01:57PM +0100, Matthew Wilcox wrote: > On Thu, Sep 03, 2020 at 01:50:51PM -0300, Jason Gunthorpe wrote: > > At least from a RDMA NIC perspective I've heard from a lot of users > > that higher order pages at the DMA level is giving big speed ups

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-03 Thread Jason Gunthorpe
On Thu, Sep 03, 2020 at 05:55:59PM +0100, Matthew Wilcox wrote: > On Thu, Sep 03, 2020 at 01:40:32PM -0300, Jason Gunthorpe wrote: > > However if the sizeof(*pXX) is 8 on a 32 bit platform then load > > tearing is a problem. At lest the various pXX_*() test functions > > opera

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-03 Thread Jason Gunthorpe
On Thu, Sep 03, 2020 at 09:25:27AM -0700, Roman Gushchin wrote: > On Thu, Sep 03, 2020 at 09:32:54AM +0200, Michal Hocko wrote: > > On Wed 02-09-20 14:06:12, Zi Yan wrote: > > > From: Zi Yan > > > > > > Hi all, > > > > > > This patchset adds support for 1GB THP on x86_64. It is on top of > > > v

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-03 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 04:29:46PM -0400, Zi Yan wrote: > On 2 Sep 2020, at 15:57, Jason Gunthorpe wrote: > > > On Wed, Sep 02, 2020 at 03:05:39PM -0400, Zi Yan wrote: > >> On 2 Sep 2020, at 14:48, Jason Gunthorpe wrote: > >> > >>> On Wed, Sep

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 07:34:26PM -0500, Gustavo A. R. Silva wrote: > Hi Alex, > > On 9/2/20 11:24, Alex Dewar wrote: > > In ucma_process_join(), if the call to xa_alloc() fails, the function > > will return without freeing mc. Fix this by jumping to the correct line. > > > > In the process I re

Re: [PATCH][next] RDMA/ucma: fix memory leak of mc on an xa_alloc failure

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 05:28:05PM +0100, Colin King wrote: > From: Colin Ian King > > Currently when an xa_alloc failure occurs the error exit path leaks > the allocated object mc. Fix this by adding an error return path > that frees mc and rename error exit paths err3 to err4 and err2 to err3.

Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 05:09:58PM +0200, Gerald Schaefer wrote: > I guess we *could* assume that all the extra pXd_offset() calls and > also the de-referencing would be optimized out by the compiler for other > archs, but it is one example where my gut tells me that this might not > be so trivial

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 05:24:51PM +0100, Alex Dewar wrote: > In ucma_process_join(), if the call to xa_alloc() fails, the function > will return without freeing mc. Fix this by jumping to the correct line. > > In the process I renamed the jump labels to something more memorable for > extra clarit

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 03:05:39PM -0400, Zi Yan wrote: > On 2 Sep 2020, at 14:48, Jason Gunthorpe wrote: > > > On Wed, Sep 02, 2020 at 02:45:37PM -0400, Zi Yan wrote: > > > >>> Surprised this doesn't touch mm/pagewalk.c ? > >> > >> 1GB PUD pa

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 02:45:37PM -0400, Zi Yan wrote: > > Surprised this doesn't touch mm/pagewalk.c ? > > 1GB PUD page support is present for DAX purpose, so the code is there > in mm/pagewalk.c already. I only needed to supply ops->pud_entry when using > the functions in mm/pagewalk.c. :) Ye

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 02:06:12PM -0400, Zi Yan wrote: > From: Zi Yan > > Hi all, > > This patchset adds support for 1GB THP on x86_64. It is on top of > v5.9-rc2-mmots-2020-08-25-21-13. > > 1GB THP is more flexible for reducing translation overhead and increasing the > performance of applicat

Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding

2020-09-01 Thread Jason Gunthorpe
On Tue, Sep 01, 2020 at 07:40:20PM +0200, Gerald Schaefer wrote: > +/* > + * With dynamic page table levels on s390, the static pXd_addr_end() > functions > + * will not return corresponding dynamic boundaries. This is no problem as > long > + * as only pXd pointers are passed down during page ta

Re: [PATCH] mm/mmu_notifier: Fix mmget() assert in __mmu_interval_notifier_insert

2020-08-31 Thread Jason Gunthorpe
a mmget, this function must not race with __mmu_notifier_release() and the mmget is what prevents that. Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH] nouveau: fix the start/end range for migration

2020-08-31 Thread Jason Gunthorpe
On Mon, Aug 31, 2020 at 10:21:41AM -0700, Ralph Campbell wrote: > > On 8/31/20 4:51 AM, Jason Gunthorpe wrote: > > On Thu, Aug 27, 2020 at 02:37:44PM -0700, Ralph Campbell wrote: > > > The user level OpenCL code shouldn't have to align start and end > > > ad

Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements

2020-08-31 Thread Jason Gunthorpe
On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote: > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > were later converted to fallthrough statements by commit df561f6688fe > ("treewide: U

Re: [PATCH] infiniband: remove unnecessary fallthrough usage

2020-08-31 Thread Jason Gunthorpe
On Mon, Aug 31, 2020 at 06:30:34PM +0300, Cengiz Can wrote: > Since /* fallthrough */ comments are deprecated[1], they are being replaced > by new 'fallthrough' pseudo-keyword. > > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\ > highlight=fallthrough#implicit-switch-ca

[PATCH] log2: add missing () around n in roundup_pow_of_two()

2020-08-31 Thread Jason Gunthorpe
Otherwise gcc generates warnings if the expression is complicated. Fixes: 312a0c170945 ("[PATCH] LOG2: Alter roundup_pow_of_two() so that it can use a ilog2() on a constant") Signed-off-by: Jason Gunthorpe --- include/linux/log2.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [patch V2 46/46] irqchip: Add IMS (Interrupt Message Storm) driver - NOT FOR MERGING

2020-08-31 Thread Jason Gunthorpe
On Wed, Aug 26, 2020 at 01:17:14PM +0200, Thomas Gleixner wrote: > + * ims_queue_info - Information to create an IMS queue domain > + * @queue_lock: Callback which informs the device driver that > + * an interrupt management operation starts. > + * @queue_sync_unlock:

Re: [patch V2 24/46] PCI: vmd: Mark VMD irqdomain with DOMAIN_BUS_VMD_MSI

2020-08-31 Thread Jason Gunthorpe
On Wed, Aug 26, 2020 at 01:16:52PM +0200, Thomas Gleixner wrote: > From: Thomas Gleixner > > Devices on the VMD bus use their own MSI irq domain, but it is not > distinguishable from regular PCI/MSI irq domains. This is required > to exclude VMD devices from getting the irq domain pointer set by

Re: [PATCH] nouveau: fix the start/end range for migration

2020-08-31 Thread Jason Gunthorpe
On Thu, Aug 27, 2020 at 02:37:44PM -0700, Ralph Campbell wrote: > The user level OpenCL code shouldn't have to align start and end > addresses to a page boundary. That is better handled in the nouveau > driver. The npages field is also redundant since it can be computed > from the start and end add

Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding

2020-08-28 Thread Jason Gunthorpe
On Fri, Aug 28, 2020 at 05:01:03PM +0200, Gerald Schaefer wrote: > Just to make sure, you are referring to some future / planned > changes to mm/pagewalk.c, and not some currently existing > pagetable walkers already using the READ_ONCE logic w/o > spinlocks? Yes no current code, just something

Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding

2020-08-28 Thread Jason Gunthorpe
On Fri, Aug 28, 2020 at 04:03:12PM +0200, Gerald Schaefer wrote: > Commit 1a42010cdc26 ("s390/mm: convert to the generic get_user_pages_fast > code") introduced a subtle but severe bug on s390 with gup_fast, due to > dynamic page table folding. I think the page walk code in mm/pagewalk.c has simil

Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable

2020-08-28 Thread Jason Gunthorpe
On Fri, Aug 28, 2020 at 01:47:59PM +0100, Marc Zyngier wrote: > > So the arch_setup_msi_irq/etc is not really an arch hook, but some > > infrastructure to support those 4 PCI root port drivers. > > I happen to have a *really old* patch addressing Tegra [1], which > I was never able to test (no HW

Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable

2020-08-28 Thread Jason Gunthorpe
On Fri, Aug 28, 2020 at 12:21:42PM +0100, Lorenzo Pieralisi wrote: > On Thu, Aug 27, 2020 at 01:20:40PM -0500, Bjorn Helgaas wrote: > > [...] > > > And I can't figure out what's special about tegra, rcar, and xilinx > > that makes them need it as well. Is there something I could grep for > > to

Re: [PATCH] mm/test: use the new SKIP() macro

2020-08-28 Thread Jason Gunthorpe
o linux-mm and is for Andrew Morton's tree. > > tools/testing/selftests/vm/hmm-tests.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH] mm/migrate: remove obsolete comment about device public

2020-08-28 Thread Jason Gunthorpe
gt; --- > > This applies to linux-mm and is for Andrew Morton's tree. Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH rdma-next 00/14] Cleanup locking and events in ucma

2020-08-27 Thread Jason Gunthorpe
available to ULPs. The handler_mutex > directly prevents handlers from running without creating any ABBA locking > problems. > > Fix various error cases and data races caused by missing locking. > > Thanks > > Jason Gunthorpe (14): > RDMA/ucma: Fix refcount 0 incr in

Re: [PATCH] RDMA/rxe: Fix memleak in rxe_mem_init_user

2020-08-27 Thread Jason Gunthorpe
On Wed, Aug 19, 2020 at 03:56:32PM +0800, Dinghao Liu wrote: > When page_address() fails, umem should be freed just > like when rxe_mem_alloc() fails. > > Signed-off-by: Dinghao Liu > --- > drivers/infiniband/sw/rxe/rxe_mr.c | 1 + > 1 file changed, 1 insertion(+) Applied to for-rc, I added a f

Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements

2020-08-26 Thread Jason Gunthorpe
On Wed, Aug 26, 2020 at 02:18:59PM -0500, Gustavo A. R. Silva wrote: > Hi, > > On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote: > > On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote: > > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent > > > implementation

Re: [PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-24 Thread Jason Gunthorpe
On Sun, Aug 09, 2020 at 12:54:28PM +0530, Suraj Upadhyay wrote: > Hii Developers, > > This patch series will replace all the legacy pci-dma-compat wrappers > with the dma-mapping APIs directly in the INFINIBAND Subsystem. > > This task is done through a coccinelle script which is described

Re: [IB/srpt] c804af2c1d: last_state.test.blktests.exit_code.143

2020-08-24 Thread Jason Gunthorpe
On Sun, Aug 23, 2020 at 02:18:41PM -0700, Bart Van Assche wrote: > The patch below is sufficient to unbreak blktests. I think that the > deadlock while unloading rdma_rxe happens because the RDMA core waits for > all ib_dev references to be dropped before dealloc_driver is called. Which is requi

Re: [patch RFC 38/38] irqchip: Add IMS array driver - NOT FOR MERGING

2020-08-22 Thread Jason Gunthorpe
On Sat, Aug 22, 2020 at 03:34:45AM +0200, Thomas Gleixner wrote: > >> One question is whether the device can see partial updates to that > >> memory due to the async 'swap' of context from the device CPU. > > > > It is worse than just partial updates.. The device operation is much > > more like you

Re: [patch RFC 38/38] irqchip: Add IMS array driver - NOT FOR MERGING

2020-08-21 Thread Jason Gunthorpe
On Sat, Aug 22, 2020 at 01:47:12AM +0200, Thomas Gleixner wrote: > On Fri, Aug 21 2020 at 17:17, Jason Gunthorpe wrote: > > On Fri, Aug 21, 2020 at 09:47:43PM +0200, Thomas Gleixner wrote: > >> So if I understand correctly then the queue memory where the MSI > >>

Re: [PATCH AUTOSEL 5.8 55/62] RDMA/efa: Add EFA 0xefa1 PCI ID

2020-08-21 Thread Jason Gunthorpe
On Fri, Aug 21, 2020 at 03:53:22PM -0400, Sasha Levin wrote: > On Fri, Aug 21, 2020 at 04:40:36PM -0300, Jason Gunthorpe wrote: > > On Fri, Aug 21, 2020 at 12:14:16PM -0400, Sasha Levin wrote: > > > From: Gal Pressman > > > > > > [ Upstream commit d4f9

Re: [patch RFC 38/38] irqchip: Add IMS array driver - NOT FOR MERGING

2020-08-21 Thread Jason Gunthorpe
On Fri, Aug 21, 2020 at 09:47:43PM +0200, Thomas Gleixner wrote: > On Fri, Aug 21 2020 at 09:45, Jason Gunthorpe wrote: > > On Fri, Aug 21, 2020 at 02:25:02AM +0200, Thomas Gleixner wrote: > >> +static void ims_mask_irq(struct irq_data *data) > >> +{ &g

Re: [PATCH AUTOSEL 5.8 55/62] RDMA/efa: Add EFA 0xefa1 PCI ID

2020-08-21 Thread Jason Gunthorpe
viewed-by: Shadi Ammouri > Reviewed-by: Yossi Leybovich > Signed-off-by: Gal Pressman > Signed-off-by: Jason Gunthorpe > Signed-off-by: Sasha Levin > --- > drivers/infiniband/hw/efa/efa_main.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Wait, what? Why is thi

[GIT PULL] Please pull RDMA subsystem changes

2020-08-21 Thread Jason Gunthorpe
Hi Linus, First rc pull request Nothing exciting, just a few bug fixes and a MAINTAINERS file update. There is a small merge conflict in the .mailmap, it has been sorted in your tree and Leon's entry was moved. It should be resolved by adding the new line at the new sorted position: Leon Rom

Re: [PATCH rdma-next] MAINTAINERS: Update Mellanox and Cumulus Network addresses to new domain

2020-08-21 Thread Jason Gunthorpe
On Mon, Aug 10, 2020 at 12:10:59PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Mellanox and Cumulus Network were acquired by Nvidia, so change the > maintainers emails to new domain name. > > Signed-off-by: Leon Romanovsky > --- > .mailmap| 2 ++ > MAINTAINERS | 58 +

Re: [PATCH] IB/uverbs: Fix memleak in ib_uverbs_add_one

2020-08-21 Thread Jason Gunthorpe
On Fri, Aug 21, 2020 at 11:47:32AM +0200, Håkon Bugge wrote: > > > > On 21 Aug 2020, at 10:10, Dinghao Liu wrote: > > > > When ida_alloc_max() fails, uverbs_dev should be freed > > just like when init_srcu_struct() fails. It's the same > > for the error paths after this call. > > > > Signed-of

Re: [patch RFC 38/38] irqchip: Add IMS array driver - NOT FOR MERGING

2020-08-21 Thread Jason Gunthorpe
On Fri, Aug 21, 2020 at 02:25:02AM +0200, Thomas Gleixner wrote: > +static void ims_mask_irq(struct irq_data *data) > +{ > + struct msi_desc *desc = irq_data_get_msi_desc(data); > + struct ims_array_slot __iomem *slot = desc->device_msi.priv_iomem; > + u32 __iomem *ctrl = &slot->ctrl; >

Re: [PATCH] RDMA/core: fix spelling mistake "Could't" -> "Couldn't"

2020-08-19 Thread Jason Gunthorpe
On Mon, Aug 10, 2020 at 08:58:24AM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pr_warn message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/infiniband/core/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-ne

Re: [PATCH rdma-next 0/3] Cleanups to flow creation paths

2020-08-18 Thread Jason Gunthorpe
On Thu, Jul 30, 2020 at 11:12:32AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Very straightforward cleanup. > > Thanks > > Leon Romanovsky (3): > RDMA/mlx5: Simplify multiple else-if cases with switch keyword > RDMA/mlx5: Replace open-coded offsetofend() macro > RDMA: Remov

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-18 Thread Jason Gunthorpe
On Tue, Aug 18, 2020 at 07:05:16PM +0200, Paolo Bonzini wrote: > On 18/08/20 18:49, Jason Gunthorpe wrote: > > On Tue, Aug 18, 2020 at 06:27:21PM +0200, Paolo Bonzini wrote: > >> On 18/08/20 13:50, Jason Gunthorpe wrote: > >>> For instance, what about suspend/r

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-18 Thread Jason Gunthorpe
On Tue, Aug 18, 2020 at 06:27:21PM +0200, Paolo Bonzini wrote: > On 18/08/20 13:50, Jason Gunthorpe wrote: > > For instance, what about suspend/resume of containers using idxd? > > Wouldn't you want to have the same basic approach of controlling the > > wq from userspac

Re: [PATCH] RDMA/hns: fix spelling mistake "epmty" -> "empty"

2020-08-18 Thread Jason Gunthorpe
On Wed, Aug 05, 2020 at 03:11:11PM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a dev_dbg message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied

Re: [PATCH] RDMA/usnic: fix spelling mistake "transistion" -> "transition"

2020-08-18 Thread Jason Gunthorpe
On Wed, Aug 05, 2020 at 03:14:59PM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a usnic_err error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/usnic/usnic_ib_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-18 Thread Jason Gunthorpe
On Tue, Aug 18, 2020 at 01:09:01AM +, Tian, Kevin wrote: > The difference in my reply is not just about the implementation gap > of growing a userspace DMA framework to a passthrough framework. > My real point is about the different goals that each wants to achieve. > Userspace DMA is purely ab

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-17 Thread Jason Gunthorpe
On Mon, Aug 17, 2020 at 02:12:44AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Friday, August 14, 2020 9:35 PM > > > > On Mon, Aug 10, 2020 at 07:32:24AM +, Tian, Kevin wrote: > > > > > > I would prefer to see that the existing

Re: [PATCH 1/5] infiniband: bnxt_re: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Jason Gunthorpe
On Mon, Aug 17, 2020 at 01:58:40PM +0530, Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Pe

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-08-14 Thread Jason Gunthorpe
On Sat, Aug 08, 2020 at 03:57:33PM -0700, Jack Leadford wrote: > Hello! > > Thanks to Jason for getting this conversation back on track. > > Yes: in general, {} or a partial initializer /will/ zero padding bits. > > However, there is a bug in some versions of GCC where {} will /not/ zero > paddi

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-14 Thread Jason Gunthorpe
On Mon, Aug 10, 2020 at 07:32:24AM +, Tian, Kevin wrote: > > I would prefer to see that the existing userspace interface have the > > extra needed bits for virtualization (eg by having appropriate > > internal kernel APIs to make this easy) and all the emulation to build > > the synthetic PCI

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-14 Thread Jason Gunthorpe
On Thu, Aug 13, 2020 at 02:01:58PM +0800, Jason Wang wrote: > > On 2020/8/13 下午1:26, Tian, Kevin wrote: > > > From: Jason Wang > > > Sent: Thursday, August 13, 2020 12:34 PM > > > > > > > > > On 2020/8/12 下午12:05, Tian, Kevin wrote: > > > > > The problem is that if we tie all controls via VFIO

Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain

2020-08-07 Thread Jason Gunthorpe
On Fri, Aug 07, 2020 at 10:54:51AM -0700, Dey, Megha wrote: > So from the hierarchical domain standpoint, we will have: > - For DSA device: vector->intel-IR->IDXD > - For Jason's device: root domain-> domain A-> Jason's device's IRQ domain > - For any other intel IMS device in the future which >  

Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain

2020-08-07 Thread Jason Gunthorpe
On Fri, Aug 07, 2020 at 02:38:31PM +0200, gre...@linuxfoundation.org wrote: > On Fri, Aug 07, 2020 at 09:06:50AM -0300, Jason Gunthorpe wrote: > > On Thu, Aug 06, 2020 at 10:21:11PM +0200, Thomas Gleixner wrote: > > > > > Optionally? Please tell the hardware folks to

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-07 Thread Jason Gunthorpe
On Wed, Aug 05, 2020 at 07:22:58PM -0600, Alex Williamson wrote: > If you see this as an abuse of the framework, then let's identify those > specific issues and come up with a better approach. As we've discussed > before, things like basic PCI config space emulation are acceptable > overhead and

Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain

2020-08-07 Thread Jason Gunthorpe
On Thu, Aug 06, 2020 at 10:21:11PM +0200, Thomas Gleixner wrote: > Optionally? Please tell the hardware folks to make this mandatory. We > have enough pain with non maskable MSI interrupts already so introducing > yet another non maskable interrupt trainwreck is not an option. Can you elaborate o

Re: [PATCH] mm/migrate: fix migrate_pgmap_owner w/o CONFIG_MMU_NOTIFIER

2020-08-06 Thread Jason Gunthorpe
n invalidation type") > > Signed-off-by: Ralph Campbell > > Reported-by: Randy Dunlap > > Acked-by: Randy Dunlap # build-tested Reviewed-by: Jason Gunthorpe I thought it spent enough time in linux-next and for 0-day to catch things like this, but I guess I was wrong. Linus has already merged the hmm pull request. Andrew Morton: Can you pick this fix up to forward to Linus? Thanks, Jason

[GIT PULL] Please pull RDMA subsystem changes

2020-08-06 Thread Jason Gunthorpe
User/kernel compatibility handshake mechanism RDMA/efa: Add EFA 0xefa1 PCI ID Gustavo A. R. Silva (2): IB/hfi1: Remove unnecessary fall-through markings IB/hfi1: Use fallthrough pseudo-keyword Jack Wang (1): RDMA/rtrs: remove WQ_MEM_RECLAIM for rtrs_wq Jason Gunthorpe (9):

Re: [PATCH] IB/core: Fix wrong return value in _ib_modify_qp()

2020-08-06 Thread Jason Gunthorpe
On Sun, Aug 02, 2020 at 07:15:42PM +0800, Tianjia Zhang wrote: > On an error exit path, a negative error code should be returned > instead of a positive return value. > > Fixes: 7a5c938b9ed09 ("IB/core: Check for rdma_protocol_ib only after > validating port_num") > C

Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain

2020-08-05 Thread Jason Gunthorpe
On Thu, Aug 06, 2020 at 12:32:31AM +, Dey, Megha wrote: > > Oops, I was thinking of platform_msi_domain_alloc_irqs() not > > create_device_domain() > > > > ie call it in the device driver that wishes to consume the extra MSIs. > > > > Is there a harm if each device driver creates a new irq_do

Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain

2020-08-05 Thread Jason Gunthorpe
On Thu, Aug 06, 2020 at 12:13:24AM +, Dey, Megha wrote: > > Well, I had suggested to pass in the parent struct device, but it could > > certainly > > use an irq_domain instead: > > > > platform_msi_assign_domain(dev, device_to_iommu(p_dev)->ir_domain); > > > > Or > > > > platform_msi_as

Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain

2020-08-05 Thread Jason Gunthorpe
On Wed, Aug 05, 2020 at 10:36:23PM +, Dey, Megha wrote: > Hi Jason, > > > From: Jason Gunthorpe > > Sent: Wednesday, August 5, 2020 3:16 PM > > To: Dey, Megha > > Cc: Marc Zyngier ; Jiang, Dave ; > > vk...@kernel.org; bhelg...@google.com; raf...@kernel.or

Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain

2020-08-05 Thread Jason Gunthorpe
On Wed, Aug 05, 2020 at 07:18:39PM +, Dey, Megha wrote: > Hence we will only have one create_dev_msi_domain which can be > called by any device driver that wants to use the dev-msi IRQ domain > to alloc/free IRQs. It would be the responsibility of the device > driver to provide the correct dev

Re: [PATCH V4 linux-next 00/12] VDPA support for Mellanox ConnectX devices

2020-08-05 Thread Jason Gunthorpe
On Wed, Aug 05, 2020 at 07:01:52PM +, Saeed Mahameed wrote: > On Wed, 2020-08-05 at 09:12 -0400, Michael S. Tsirkin wrote: > > On Wed, Aug 05, 2020 at 04:01:58PM +0300, Eli Cohen wrote: > > > On Wed, Aug 05, 2020 at 08:48:52AM -0400, Michael S. Tsirkin wrote: > > > > > Did you merge this?: > >

Re: KASAN: use-after-free Read in netdevice_event_work_handler

2020-08-05 Thread Jason Gunthorpe
On Tue, Aug 04, 2020 at 01:00:13PM -0700, Rustam Kovhaev wrote: > On Sun, Aug 02, 2020 at 07:22:26PM -0300, Jason Gunthorpe wrote: > > On Fri, Jul 31, 2020 at 02:11:22PM -0700, Rustam Kovhaev wrote: > > > > > IB roce driver receives NETDEV_UNREGISTER event, calls dev_ho

Re: [PATCH v3 00/23] device-dax: Support sub-dividing soft-reserved ranges

2020-08-04 Thread Jason Gunthorpe
On Fri, Jul 31, 2020 at 08:24:58PM -0700, Dan Williams wrote: > - Fix test_hmm and other compilation fixups (Ralph) The hmm parts look OK Acked-by: Jason Gunthorpe Jason

[GIT PULL] Please pull hmm changes

2020-08-04 Thread Jason Gunthorpe
Hi Linus, Ralph has been working on nouveau's use of hmm_range_fault() and migrate_vma() which resulted in this small series of improvements. There are two expected conflicts. Conflict with the kvm-ppc tree: https://lore.kernel.org/linux-next/20200730191610.204ed...@canb.auug.org.au/ This is be

Re: linux-next: manual merge of the hmm tree with the drm tree

2020-08-03 Thread Jason Gunthorpe
On Tue, Aug 04, 2020 at 09:29:30AM +1000, Ben Skeggs wrote: > On Tue, Aug 4, 2020 at 9:19 AM Jason Gunthorpe wrote: > > > > On Thu, Jul 30, 2020 at 10:31:45AM -0700, Ralph Campbell wrote: > > > > > > On 7/30/20 5:03 AM, Jason Gunthorpe wrote: > > >

Re: linux-next: manual merge of the hmm tree with the drm tree

2020-08-03 Thread Jason Gunthorpe
On Thu, Jul 30, 2020 at 10:31:45AM -0700, Ralph Campbell wrote: > > On 7/30/20 5:03 AM, Jason Gunthorpe wrote: > > On Thu, Jul 30, 2020 at 07:21:10PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > Today's linux-next merge of the hmm tree go

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-08-03 Thread Jason Gunthorpe
On Sun, Aug 02, 2020 at 03:45:40PM -0700, Joe Perches wrote: > On Sun, 2020-08-02 at 19:28 -0300, Jason Gunthorpe wrote: > > On Sun, Aug 02, 2020 at 03:23:58PM -0700, Joe Perches wrote: > > > On Sun, 2020-08-02 at 19:10 -0300, Jason Gunthorpe wrote: > > > > On Sat, Au

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-08-02 Thread Jason Gunthorpe
On Sun, Aug 02, 2020 at 03:23:58PM -0700, Joe Perches wrote: > On Sun, 2020-08-02 at 19:10 -0300, Jason Gunthorpe wrote: > > On Sat, Aug 01, 2020 at 08:38:33AM +0300, Leon Romanovsky wrote: > > > > > I'm using {} instead of {0} because of this GCC bug. >

Re: KASAN: use-after-free Read in netdevice_event_work_handler

2020-08-02 Thread Jason Gunthorpe
On Fri, Jul 31, 2020 at 02:11:22PM -0700, Rustam Kovhaev wrote: > IB roce driver receives NETDEV_UNREGISTER event, calls dev_hold() and > schedules work item to execute, and before wq gets a chance to complete > it, we return to ip_tunnel.c:274 and call free_netdev(), and then later > we get UAF w

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-08-02 Thread Jason Gunthorpe
On Sat, Aug 01, 2020 at 08:38:33AM +0300, Leon Romanovsky wrote: > I'm using {} instead of {0} because of this GCC bug. > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 This is why the {} extension exists.. Jason

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-08-01 Thread Jason Gunthorpe
On Sat, Aug 01, 2020 at 11:00:26AM +0300, Dan Carpenter wrote: > > Without an actual example where this doesn't work right it is hard to > > say anything more.. > > Here is the example that set off the recent patches: > > https://lkml.org/lkml/2020/7/27/199 Oh, that is something completely diffe

Re: [PATCH v4 6/6] mm/migrate: remove range invalidation in migrate_vma_pages()

2020-07-31 Thread Jason Gunthorpe
On Tue, Jul 28, 2020 at 03:04:07PM -0700, Ralph Campbell wrote: > > On 7/28/20 12:19 PM, Jason Gunthorpe wrote: > > On Thu, Jul 23, 2020 at 03:30:04PM -0700, Ralph Campbell wrote: > > > When migrating the special zero page, migrate_vma_pages() calls > > > mmu_n

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2020 at 07:19:24PM +0200, Greg Kroah-Hartman wrote: > > I tried for a bit and didn't find a way to get even old gcc 4.4 to not > > initialize the holes. > > Odd, so it is just the "= {0};" that does not zero out the holes? Nope, it seems to work fine too. I tried a number of situ

Re: [RFC PATCH 0/5] madvise MADV_DOEXEC

2020-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2020 at 01:15:34PM -0400, Steven Sistare wrote: > On 7/31/2020 12:56 PM, Jason Gunthorpe wrote: > > On Fri, Jul 31, 2020 at 12:11:52PM -0400, Steven Sistare wrote: > >>> Your preservation-across-exec use-case might or might not need the > >>> VMA

Re: [PATCH net] RDMA/umem: add a schedule point in ib_umem_get()

2020-07-31 Thread Jason Gunthorpe
xactly this, the motivation is to reduce the memory consumption if a lot of pages are combined. > Signed-off-by: Eric Dumazet > Cc: Doug Ledford > Cc: Jason Gunthorpe > Cc: linux-r...@vger.kernel.org > --- > drivers/infiniband/core/umem.c | 1 + > 1 file changed, 1 insert

Re: [RFC PATCH 0/5] madvise MADV_DOEXEC

2020-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2020 at 12:11:52PM -0400, Steven Sistare wrote: > > Your preservation-across-exec use-case might or might not need the > > VMA to be mapped at the same address. > > It does. qemu registers memory with vfio which remembers the va's in kernel > metadata for the device. Once the m

[GIT PULL] Please pull RDMA subsystem changes

2020-07-31 Thread Jason Gunthorpe
buffer logic - Missed mutex initialization crash in mlx5 - Two small defects with RDMA DIM Jason Gunthorpe (2): RDMA/cm: Add min length checks to user structure copies RDMA/mlx5: Fix prefetch memory leak if

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2020 at 04:21:48PM +0200, Greg Kroah-Hartman wrote: > > The spec was updated in C11 to require zero'ing padding when doing > > partial initialization of aggregates (eg = {}) > > > > """if it is an aggregate, every member is initialized (recursively) > > according to these rules, a

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2020 at 07:33:33AM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 31, 2020 at 07:33:06AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jul 31, 2020 at 07:53:01AM +0300, Leon Romanovsky wrote: > > > On Thu, Jul 30, 2020 at 03:20:26PM -0400, Peilin Ye wrote: > > > > rds_notify_queue_ge

Re: [PATCH rdma-rc 0/3] Simple fixes to DIM and mlx5

2020-07-30 Thread Jason Gunthorpe
On Thu, Jul 30, 2020 at 11:27:16AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > First patch fixes an issue observed after auto-PID series was merged, > but because the bug that not-initialized mutex existed before, the > patch is sent to -rc. > > Other two patches are fixin

Re: linux-next: manual merge of the hmm tree with the drm tree

2020-07-30 Thread Jason Gunthorpe
On Thu, Jul 30, 2020 at 07:21:10PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the hmm tree got a conflict in: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c > > between commit: > > 7763d24f3ba0 ("drm/nouveau/vmm/gp100-: fix mapping 2MB sysmem pages") >

Re: [PATCH rdma-next 0/4] Fix bugs around RDMA CM destroying state

2020-07-29 Thread Jason Gunthorpe
On Thu, Jul 23, 2020 at 10:07:03AM +0300, Leon Romanovsky wrote: > This small series simplifies some of the RDMA CM state transitions > connected with DESTROYING states and in the process resolves a bug > discovered by syzkaller. > > Thanks > > Jason Gunthorpe (4): &

Re: [PATCH 4/4] mm: mmu_notifier: Fix and extend kerneldoc

2020-07-28 Thread Jason Gunthorpe
Function parameter or member 'ops' not > described in 'mmu_interval_notifier_insert' > > Signed-off-by: Krzysztof Kozlowski > --- > mm/mmu_notifier.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Jason Gunthorpe Thanks, Jason

Re: [PATCH v4 0/6] mm/migrate: avoid device private invalidations

2020-07-28 Thread Jason Gunthorpe
issue in nouveau for the migration invalidation. > Added a HMM selftest test case to exercise the HMM test driver > invalidation changes. > Removed reviewed-by Bharata B Rao since this version is moderately > changed. > > Changes in v2: > Rebase to Jason Gunthorpe's HMM tree.

Re: [PATCH v4 6/6] mm/migrate: remove range invalidation in migrate_vma_pages()

2020-07-28 Thread Jason Gunthorpe
On Thu, Jul 23, 2020 at 03:30:04PM -0700, Ralph Campbell wrote: > When migrating the special zero page, migrate_vma_pages() calls > mmu_notifier_invalidate_range_start() before replacing the zero page > PFN in the CPU page tables. This is unnecessary since the range was > invalidated in migrate_vma

Re: [PATCH v4 3/6] mm/notifier: add migration invalidation type

2020-07-28 Thread Jason Gunthorpe
On Thu, Jul 23, 2020 at 03:30:01PM -0700, Ralph Campbell wrote: > static inline int mm_has_notifiers(struct mm_struct *mm) > @@ -513,6 +519,7 @@ static inline void mmu_notifier_range_init(struct > mmu_notifier_range *range, > range->start = start; > range->end = end; > range->fl

Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params field

2020-07-27 Thread Jason Gunthorpe
On Mon, Jul 27, 2020 at 03:17:12PM +0100, Colin King wrote: > From: Colin Ian King > > Currently n_rq_elems is being assigned to params.elem_size instead of the > field params.num_elems. Coverity is detecting this as a double assingment > to params.elem_size and reporting this as an usused value

Re: [PATCH] RDMA/core: fix return error value to negative

2020-07-27 Thread Jason Gunthorpe
On Sat, Jul 25, 2020 at 10:56:27AM +0800, Li Heng wrote: > Fixes: 8d9ec9addd6c (IB/core: Add a sgid_attr pointer to struct rdma_ah_attr) > Reported-by: Hulk Robot > Signed-off-by: Li Heng > Reviewed-by: Parav Pandit > --- > drivers/infiniband/core/verbs.c | 2 +- > 1 file changed, 1 insertion(+

Re: [Linux-kernel-mentees] [PATCH v2] infiniband: Prevent uninit-value in ucma_accept()

2020-07-27 Thread Jason Gunthorpe
On Sat, Jul 25, 2020 at 10:27:16PM -0400, Peilin Ye wrote: > ucma_accept() is reading uninitialized memory when `in_len` is > less than `offsetof(struct rdma_ucm_accept, ece)`. Fix it. > > Reported-and-tested-by: syzbot+086ab5ca9eafd2379...@syzkaller.appspotmail.com > Link: > https://syzkaller.ap

Re: [PATCH] RDMA/mlx5: fix typo in structure name

2020-07-24 Thread Jason Gunthorpe
On Fri, Jul 24, 2020 at 10:41:12AM +0200, Pavel Machek wrote: > This is user API, but likely noone uses it...? Fix it before it > becomes problem. > > Signed-off-by: Pavel Machek (CIP) Applied to for-next, thanks Jason

Re: [PATCH v2][next] IB/hfi1: Use fallthrough pseudo-keyword

2020-07-24 Thread Jason Gunthorpe
On Tue, Jul 21, 2020 at 08:34:55AM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/h

Re: [PATCH rdma-next v1 0/2] Fix warnings reported by kbuild

2020-07-24 Thread Jason Gunthorpe
On Mon, Jul 20, 2020 at 08:56:25PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog > v1: > * Delete "pd" cleanup line > * Moved all cleaned feilds to be last in declaration list to improve > readability. > v0: > https://lore.kernel.org/lkml/20200719060319.77603-1-l...@kern

[GIT PULL] Please pull RDMA subsystem changes

2020-07-24 Thread Jason Gunthorpe
Jason Gunthorpe (1): RDMA/mlx5: Prevent prefetch from racing with implicit destruction Leon Romanovsky (1): RDMA/core: Fix race in rdma_alloc_commit_uobject() Maor Gottlieb (2): RDMA/mlx5: Use xa_lock_irq when access to SRQ table RDMA/cm

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-07-23 Thread Jason Gunthorpe
On Tue, Jul 21, 2020 at 11:54:49PM +, Tian, Kevin wrote: > In a nutshell, applications don't require raw WQ controllability as guest > kernel drivers may expect. Extending DSA user space interface to be another > passthrough interface just for virtualization needs is less compelling than > leve

<    5   6   7   8   9   10   11   12   13   14   >