Re: [PATH v5 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-23 Thread Jason Wang
On Tue, Jul 23, 2024 at 1:41 PM Cindy Lu wrote: > > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device > > Signed-off-by: Cindy Lu Acked-by: Jason Wang Thanks

Re: [PATH v5 2/3] vdpa_sim_net: Add the support of set mac address

2024-07-23 Thread Jason Wang
-by: Cindy Lu Acked-by: Jason Wang Thanks

Re: [PATH v5 1/3] vdpa: support set mac address from vdpa tool

2024-07-23 Thread Jason Wang
On Tue, Jul 23, 2024 at 1:41 PM Cindy Lu wrote: > > Add new UAPI to support the mac address from vdpa tool > Function vdpa_nl_cmd_dev_attr_set_doit() will get the > new MAC address from the vdpa tool and then set it to the device. > > The usage is: vdpa dev set name vdpa_name mac

Re: [PATH v4 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-22 Thread Jason Wang
On Mon, Jul 22, 2024 at 5:45 PM Dragos Tatulea wrote: > > On Mon, 2024-07-22 at 15:48 +0800, Jason Wang wrote: > > On Mon, Jul 22, 2024 at 9:06 AM Cindy Lu wrote: > > > > > > Add the function to support setting the MAC address. > > > For vdpa/mlx5,

Re: [PATH v4 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-22 Thread Jason Wang
On Mon, Jul 22, 2024 at 10:48 PM Cindy Lu wrote: > > On Mon, 22 Jul 2024 at 20:55, Cindy Lu wrote: > > > > On Mon, 22 Jul 2024 at 17:45, Dragos Tatulea wrote: > > > > > > On Mon, 2024-07-22 at 15:48 +0800, Jason Wang wrote: > > > >

Re: [PATH v4 2/3] vdpa_sim_net: Add the support of set mac address

2024-07-22 Thread Jason Wang
On Mon, Jul 22, 2024 at 3:57 PM Cindy Lu wrote: > > On Mon, 22 Jul 2024 at 15:48, Jason Wang wrote: > > > > On Mon, Jul 22, 2024 at 9:06 AM Cindy Lu wrote: > > > > > > Add the function to support setting the MAC address. > > > For vdpa_s

Re: [PATH v4 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-22 Thread Jason Wang
On Mon, Jul 22, 2024 at 9:06 AM Cindy Lu wrote: > > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device > > Signed-off-by: Cindy Lu > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c |

Re: [PATH v4 2/3] vdpa_sim_net: Add the support of set mac address

2024-07-22 Thread Jason Wang
On Mon, Jul 22, 2024 at 9:06 AM Cindy Lu wrote: > > Add the function to support setting the MAC address. > For vdpa_sim_net, the driver will write the MAC address > to the config space, and other devices can implement > their own functions to support this. > > Signed-off-by: Cindy Lu > --- >

Re: [PATCH V2 3/7] vhost-vdpa: VHOST_NEW_OWNER

2024-07-22 Thread Jason Wang
On Thu, Jul 18, 2024 at 2:28 AM Steven Sistare wrote: > > On 7/16/2024 1:16 AM, Jason Wang wrote: > > On Mon, Jul 15, 2024 at 10:27 PM Steven Sistare > > wrote: > >> > >> On 7/14/2024 10:26 PM, Jason Wang wrote: > >>> On Fri, Jul 12, 2024 at 9:19 P

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-22 Thread Jason Wang
On Fri, Jul 19, 2024 at 9:19 AM Michael S. Tsirkin wrote: > > On Fri, Jul 19, 2024 at 09:02:29AM +0800, Jason Wang wrote: > > On Wed, Jul 17, 2024 at 2:53 PM Jason Wang wrote: > > > > > > On Wed, Jul 17, 2024 at 2:00 PM Michael S. Tsirkin > > > wrote: >

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-18 Thread Jason Wang
On Wed, Jul 17, 2024 at 2:53 PM Jason Wang wrote: > > On Wed, Jul 17, 2024 at 2:00 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 17, 2024 at 09:19:02AM +0800, Jason Wang wrote: > > > On Wed, Jul 10, 2024 at 11:03 AM Jason Wang wrote: > > > > > >

Re: [GIT PULL] virtio: features, fixes, cleanups

2024-07-18 Thread Jason Wang
On Fri, Jul 19, 2024 at 3:28 AM Michael S. Tsirkin wrote: > > On Thu, Jul 18, 2024 at 08:52:28AM +0800, Jason Wang wrote: > > On Wed, Jul 17, 2024 at 5:30 PM Michael S. Tsirkin wrote: > > > > > > This is relatively small. > > > I had to drop a bu

Re: [PATCH V2 5/7] vhost-vdpa: VHOST_IOTLB_REMAP

2024-07-18 Thread Jason Wang
On Fri, Jul 19, 2024 at 4:19 AM Steven Sistare wrote: > > On 7/18/2024 3:39 PM, Michael S. Tsirkin wrote: > > On Thu, Jul 18, 2024 at 08:45:31AM +0800, Jason Wang wrote: > >>>> For example: > >>>> > >>>> 1) old owner pass fd to new

Re: [PATCH V2 5/7] vhost-vdpa: VHOST_IOTLB_REMAP

2024-07-17 Thread Jason Wang
On Thu, Jul 18, 2024 at 2:29 AM Steven Sistare wrote: > > On 7/16/2024 1:28 AM, Jason Wang wrote: > > On Mon, Jul 15, 2024 at 10:28 PM Steven Sistare > > wrote: > >> > >> On 7/14/2024 10:34 PM, Jason Wang wrote: > >>> On Fri, Jul

Re: [GIT PULL] virtio: features, fixes, cleanups

2024-07-17 Thread Jason Wang
On Wed, Jul 17, 2024 at 5:30 PM Michael S. Tsirkin wrote: > > This is relatively small. > I had to drop a buggy commit in the middle so some hashes > changed from what was in linux-next. > Deferred admin vq scalability fix to after rc2 as a minor issue was > found with it recently, but the

Re: [PATCH V2 0/7] vdpa live update

2024-07-17 Thread Jason Wang
On Thu, Jul 18, 2024 at 2:29 AM Steven Sistare wrote: > > On 7/16/2024 1:30 AM, Jason Wang wrote: > > On Mon, Jul 15, 2024 at 10:29 PM Steven Sistare > > wrote: > >> > >> On 7/14/2024 10:14 PM, Jason Wang wrote: > >>> On Fri, Jul

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-17 Thread Jason Wang
On Wed, Jul 17, 2024 at 2:00 PM Michael S. Tsirkin wrote: > > On Wed, Jul 17, 2024 at 09:19:02AM +0800, Jason Wang wrote: > > On Wed, Jul 10, 2024 at 11:03 AM Jason Wang wrote: > > > > > > On Tue, Jul 9, 2024 at 9:28 PM Michael S. Tsirkin wrote: > > >

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-16 Thread Jason Wang
On Wed, Jul 10, 2024 at 11:03 AM Jason Wang wrote: > > On Tue, Jul 9, 2024 at 9:28 PM Michael S. Tsirkin wrote: > > > > On Tue, Jul 09, 2024 at 04:02:14PM +0800, Jason Wang wrote: > > > This patch synchronize operstate with admin state per RFC2863. > > > &g

Re: [PATCH V2 0/7] vdpa live update

2024-07-15 Thread Jason Wang
On Mon, Jul 15, 2024 at 10:29 PM Steven Sistare wrote: > > On 7/14/2024 10:14 PM, Jason Wang wrote: > > On Fri, Jul 12, 2024 at 9:19 PM Steve Sistare > > wrote: > >> > >> Live update is a technique wherein an application saves its state, exec's > >>

Re: [PATCH V2 5/7] vhost-vdpa: VHOST_IOTLB_REMAP

2024-07-15 Thread Jason Wang
On Mon, Jul 15, 2024 at 10:28 PM Steven Sistare wrote: > > On 7/14/2024 10:34 PM, Jason Wang wrote: > > On Fri, Jul 12, 2024 at 9:19 PM Steve Sistare > > wrote: > >> > >> When device ownership is passed to a new process via VHOST_NEW_OWNER, > >&g

Re: [PATCH V2 3/7] vhost-vdpa: VHOST_NEW_OWNER

2024-07-15 Thread Jason Wang
On Mon, Jul 15, 2024 at 10:27 PM Steven Sistare wrote: > > On 7/14/2024 10:26 PM, Jason Wang wrote: > > On Fri, Jul 12, 2024 at 9:19 PM Steve Sistare > > wrote: > >> > >> Add an ioctl to transfer file descriptor ownership and pinned memory > &g

Re: [PATCH V2 5/7] vhost-vdpa: VHOST_IOTLB_REMAP

2024-07-14 Thread Jason Wang
On Fri, Jul 12, 2024 at 9:19 PM Steve Sistare wrote: > > When device ownership is passed to a new process via VHOST_NEW_OWNER, > some devices need to know the new userland addresses of the dma mappings. > Define the new iotlb message type VHOST_IOTLB_REMAP to update the uaddr > of a mapping. The

Re: [PATCH V2 4/7] vhost-vdpa: VHOST_BACKEND_F_NEW_OWNER

2024-07-14 Thread Jason Wang
On Fri, Jul 12, 2024 at 9:19 PM Steve Sistare wrote: > > Add the VHOST_BACKEND_F_NEW_OWNER backend capability, which indicates that > VHOST_NEW_OWNER is supported. > > Signed-off-by: Steve Sistare Doesn't harm but should this be part of the previous patch? Thanks

Re: [PATCH V2 3/7] vhost-vdpa: VHOST_NEW_OWNER

2024-07-14 Thread Jason Wang
On Fri, Jul 12, 2024 at 9:19 PM Steve Sistare wrote: > > Add an ioctl to transfer file descriptor ownership and pinned memory > accounting from one process to another. > > This is more efficient than VHOST_RESET_OWNER followed by VHOST_SET_OWNER, > as that would unpin all physical pages,

Re: [PATCH V2 0/7] vdpa live update

2024-07-14 Thread Jason Wang
On Fri, Jul 12, 2024 at 9:19 PM Steve Sistare wrote: > > Live update is a technique wherein an application saves its state, exec's > to an updated version of itself, and restores its state. Clients of the > application experience a brief suspension of service, on the order of > 100's of

Re: [PATCH] vdpa/octeon_ep: Fix error code in octep_process_mbox()

2024-07-14 Thread Jason Wang
int octep_process_mbox(struct octep_hw *oct_hw, > u16 id, u16 qid, void *bu > val = octep_read_sig(mbox); > if ((val & 0x) != MBOX_RSP_SIG) { > dev_warn(>dev, "Invalid Signature from mbox : %d > response\n", id); > - return r

Re: [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning

2024-07-14 Thread Jason Wang
et: bulk free tx skbs") > Suggested-by: Jakub Kicinski > Signed-off-by: Breno Leitao > --- Acked-by: Jason Wang Thanks

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Jason Wang
On Wed, Jul 10, 2024 at 2:16 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > > > QEMU implemented the configuration > >

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-10 Thread Jason Wang
On Wed, Jul 10, 2024 at 3:19 PM Stefano Garzarella wrote: > > On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote: > >On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella > >wrote: > >> > >> On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: > >

Re: [PATCH 2/2] virtio: fix vq # when vq skipped

2024-07-09 Thread Jason Wang
Result is that driver is out of spec. > > Implement what the API was supposed to do > in the 1st place. Compatibility with buggy hypervisors > is handled inside virtio-balloon, which is the only driver > making use of this facility, so far. > > Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang Thanks

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-09 Thread Jason Wang
err = virtio_find_vqs(vb->vdev, > + VIRTIO_BALLOON_VQ_REPORTING, > vqs, callbacks, names, NULL); > + } > + > + if (err) > + return err; > + } > > vb->inflate_vq = vqs[VIRTIO_BALLOON_VQ_INFLATE]; &

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-09 Thread Jason Wang
On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella wrote: > > On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: > >On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella > >wrote: > >> > >> Hi Cindy, Jason, > >> > >> On Mon, Jul 08, 2024

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-09 Thread Jason Wang
On Tue, Jul 9, 2024 at 8:42 PM Michael S. Tsirkin wrote: > > On Tue, Jul 09, 2024 at 02:19:19PM +0800, Cindy Lu wrote: > > On Tue, 9 Jul 2024 at 11:59, Parav Pandit wrote: > > > > > > Hi Cindy, > > > > > > > From: Cindy Lu > > > > Sent: Monday, July 8, 2024 12:17 PM > > > > > > > > Add support

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Jason Wang
On Tue, Jul 9, 2024 at 9:28 PM Michael S. Tsirkin wrote: > > On Tue, Jul 09, 2024 at 04:02:14PM +0800, Jason Wang wrote: > > This patch synchronize operstate with admin state per RFC2863. > > > > This is done by trying to toggle the carrier upon open/close and > &g

[PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Jason Wang
qlen 1000 link/ether b2:a9:c5:04:da:53 brd ff:ff:ff:ff:ff:ff Cc: Venkat Venkatsubra Cc: Gia-Khanh Nguyen Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 64 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/drivers/net

[PATCH net-next v3 2/3] virtio: allow driver to disable the configure change notification

2024-07-09 Thread Jason Wang
and the driver. It is set to false by default to hold the current semantic so we don't need to change any drivers. The first user for this would be virtio-net. Cc: Venkat Venkatsubra Cc: Gia-Khanh Nguyen Signed-off-by: Jason Wang --- drivers/virtio/virtio.c | 39

[PATCH net-next v3 1/3] virtio: rename virtio_config_enabled to virtio_config_core_enabled

2024-07-09 Thread Jason Wang
Following patch will allow the config interrupt to be disabled by a specific driver via another boolean. So this patch renames virtio_config_enabled and relevant helpers to virtio_config_core_enabled. Cc: Venkat Venkatsubra Cc: Gia-Khanh Nguyen Signed-off-by: Jason Wang --- drivers/virtio

[PATCH net-next v3 0/3] virtio-net: synchronize op/admin state

2024-07-09 Thread Jason Wang
- schedule config change work unconditionally Jason Wang (3): virtio: rename virtio_config_enabled to virtio_config_core_enabled virtio: allow driver to disable the configure change notification virtio-net: synchronize operstate with admin state on up/down drivers/net/virtio_net.c | 64

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-08 Thread Jason Wang
On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella wrote: > > Hi Cindy, Jason, > > On Mon, Jul 08, 2024 at 03:59:34PM GMT, Jason Wang wrote: > >On Mon, Jul 8, 2024 at 3:06 PM Cindy Lu wrote: > >> > >> On Fri, 5 Jul 2024 at 20:42, Stefano Garzarella > >&

Re: [PATCH v3 2/2] vdpa_sim_net: Add the support of set mac address

2024-07-08 Thread Jason Wang
On Mon, Jul 8, 2024 at 3:19 PM Cindy Lu wrote: > > On Mon, 8 Jul 2024 at 15:06, Jason Wang wrote: > > > > On Mon, Jul 8, 2024 at 2:48 PM Cindy Lu wrote: > > > > > > Add the function to support setting the MAC address. > > > For vdpa_s

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-08 Thread Jason Wang
On Mon, Jul 8, 2024 at 3:06 PM Cindy Lu wrote: > > On Fri, 5 Jul 2024 at 20:42, Stefano Garzarella wrote: > > > > On Fri, Jul 05, 2024 at 07:30:51AM GMT, Michael S. Tsirkin wrote: > > >On Fri, Jul 05, 2024 at 01:28:21PM +0200, Stefano Garzarella wrote: > > >> The vDPA block simulator always

Re: [PATCH v3 2/2] vdpa_sim_net: Add the support of set mac address

2024-07-08 Thread Jason Wang
On Mon, Jul 8, 2024 at 2:48 PM Cindy Lu wrote: > > Add the function to support setting the MAC address. > For vdpa_sim_net, the driver will write the MAC address > to the config space, and other devices can implement > their own functions to support this. > > Signed-off-by: Cindy Lu > --- >

Re: [PATCH v3 1/2] vdpa: support set mac address from vdpa tool

2024-07-08 Thread Jason Wang
"mac": "00:11:22:33:44:55", > "link ": "up", > "link_announce ": false, > "mtu": 1500 > } > } > } > > Signed-off-by: Cindy Lu Acked-by: Jason Wang Thanks

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Jason Wang
On Mon, Jul 8, 2024 at 2:56 PM Cindy Lu wrote: > > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device Great. > > Signed-off-by: Cindy Lu I guess this should be part of the

[PATCH] vhost-vdpa: switch to use vmf_insert_pfn() in the fault handler

2024-06-30 Thread Jason Wang
rt_pfn() instead. Reported-by: Dragos Tatulea Tested-by: Dragos Tatulea Fixes: ddd89d0a059d ("vhost_vdpa: support doorbell mapping via mmap") Cc: sta...@vger.kernel.org Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 4:32 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 04:11:05PM +0800, Jason Wang wrote: > > On Tue, Jun 25, 2024 at 3:57 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 25, 2024 at 03:46:44PM +0800, Jason Wang wrote: > >

Re: [PATCH] virtio-pci: PCI extended capabilities for virtio

2024-06-25 Thread Jason Wang
On Wed, Jun 26, 2024 at 6:50 AM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 02:39:37PM -0400, sahanlb wrote: > > PCI legacy configuration space does not have sufficient space for a device > > that supports all kinds of virtio structures via PCI capabilities. This is > > especially true

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 4:04 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 03:50:30PM +0800, Jason Wang wrote: > > On Tue, Jun 25, 2024 at 3:11 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > >

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 3:57 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 03:46:44PM +0800, Jason Wang wrote: > > Workqueue is used to serialize those so we won't lose any change. > > So we don't need to re-read then? > We might have to re-read but I don't ge

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 3:11 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > > On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 24, 2024 at 10:45:21AM +0800, Jason Wang wrote: &

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 3:16 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 09:27:38AM +0800, Jason Wang wrote: > > On Mon, Jun 24, 2024 at 6:07 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 24, 2024 at 10:45:23AM +0800, Jason Wang wrote: > >

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-24 Thread Jason Wang
On Mon, Jun 24, 2024 at 6:07 PM Michael S. Tsirkin wrote: > > On Mon, Jun 24, 2024 at 10:45:23AM +0800, Jason Wang wrote: > > This patch synchronize operstate with admin state per RFC2863. > > > > This is done by trying to toggle the carrier upon open/close and > &g

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-24 Thread Jason Wang
On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin wrote: > > On Mon, Jun 24, 2024 at 10:45:21AM +0800, Jason Wang wrote: > > Somtime driver may want to enable or disable the config callback. This > > requires a synchronization with the core. So this patch change the

[PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-23 Thread Jason Wang
qlen 1000 link/ether b2:a9:c5:04:da:53 brd ff:ff:ff:ff:ff:ff Cc: Venkat Venkatsubra Cc: Gia-Khanh Nguyen Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 72 +++- 1 file changed, 42 insertions(+), 30 deletions(-) diff --git a/drivers/net

[PATCH V2 2/3] virtio: export virtio_config_{enable|disable}()

2024-06-23 Thread Jason Wang
This patch exports virtio_config_enable() and virtio_config_disable() for drivers to disable config callbacks. Signed-off-by: Jason Wang --- drivers/virtio/virtio.c | 6 -- include/linux/virtio.h | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/virtio

[PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-23 Thread Jason Wang
. The counter is not allowed to be increased greater than one, this simplifies the logic where the interrupt could be disabled immediately without extra synchronization between driver and core. Signed-off-by: Jason Wang --- drivers/virtio/virtio.c | 20 +--- include/linux/virtio.h | 2

[PATCH V2 0/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-23 Thread Jason Wang
the configure interrupt Jason Wang (3): virtio: allow nested disabling of the configure interrupt virtio: export virtio_config_{enable|disable}() virtio-net: synchronize operstate with admin state on up/down drivers/net/virtio_net.c | 72 +++- drivers/virtio

Re: [PATCH net-next V2] virtio-net: synchronize operstate with admin state on up/down

2024-06-20 Thread Jason Wang
On Thu, Jun 20, 2024 at 1:58 PM Michael S. Tsirkin wrote: > > On Thu, Jun 06, 2024 at 08:22:13AM +0800, Jason Wang wrote: > > On Fri, May 31, 2024 at 8:18 AM Jason Wang wrote: > > > > > > On Thu, May 30, 2024 at 9:09 PM Michael S. Tsirkin > > > wrote: >

Re: [PATCH] vringh: add MODULE_DESCRIPTION()

2024-06-16 Thread Jason Wang
On Fri, May 17, 2024 at 9:57 AM Jeff Johnson wrote: > > Fix the allmodconfig 'make w=1' issue: > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/vhost/vringh.o > > Signed-off-by: Jeff Johnson Acked-by: Jason Wang Thanks >

Re: [PATCH] virtio_net: Eliminate OOO packets during switching

2024-06-16 Thread Jason Wang
On Sat, Jun 15, 2024 at 6:05 AM Abhinav Jain wrote: > > Disable the network device & turn off carrier before modifying the > number of queue pairs. > Process all the in-flight packets and then turn on carrier, followed > by waking up all the queues on the network device. > > Signed-off-by:

Re: [PATCH net-next V2] virtio-net: synchronize operstate with admin state on up/down

2024-06-16 Thread Jason Wang
On Thu, Jun 6, 2024 at 8:22 AM Jason Wang wrote: > > On Fri, May 31, 2024 at 8:18 AM Jason Wang wrote: > > > > On Thu, May 30, 2024 at 9:09 PM Michael S. Tsirkin wrote: > > > > > > On Thu, May 30, 2024 at 06:29:51PM +0800, Jason Wang wrote: > > >

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-16 Thread Jason Wang
On Wed, Jun 12, 2024 at 2:30 PM Jiri Pirko wrote: > > Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: > >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: > >> Add new UAPI to support the mac address from vdpa tool > >> Function vdpa_nl_cmd_dev_config_set_doit() will get the > >>

Re: [PATCH] tools/virtio: Use the __GFP_ZERO flag of kmalloc to complete the memory initialization.

2024-06-05 Thread Jason Wang
On Wed, Jun 5, 2024 at 9:56 PM cuitao wrote: > > Use the __GFP_ZERO flag of kmalloc to initialize memory while allocating it, > without the need for an additional memset call. > > Signed-off-by: cuitao > --- > tools/virtio/linux/kernel.h | 5 + > 1 file changed, 1 insertion(+), 4

Re: [PATCH net-next V2] virtio-net: synchronize operstate with admin state on up/down

2024-06-05 Thread Jason Wang
On Fri, May 31, 2024 at 8:18 AM Jason Wang wrote: > > On Thu, May 30, 2024 at 9:09 PM Michael S. Tsirkin wrote: > > > > On Thu, May 30, 2024 at 06:29:51PM +0800, Jason Wang wrote: > > > On Thu, May 30, 2024 at 2:10 PM Michael S. Tsirkin > > > wrote: > &

Re: [PATCH net-next V2] virtio-net: synchronize operstate with admin state on up/down

2024-05-30 Thread Jason Wang
On Thu, May 30, 2024 at 9:09 PM Michael S. Tsirkin wrote: > > On Thu, May 30, 2024 at 06:29:51PM +0800, Jason Wang wrote: > > On Thu, May 30, 2024 at 2:10 PM Michael S. Tsirkin wrote: > > > > > > On Thu, May 30, 2024 at 11:20:55AM +0800, Jason Wang wrote: > >

Re: [PATCH net-next V2] virtio-net: synchronize operstate with admin state on up/down

2024-05-30 Thread Jason Wang
On Thu, May 30, 2024 at 6:29 PM Jason Wang wrote: > > On Thu, May 30, 2024 at 2:10 PM Michael S. Tsirkin wrote: > > > > On Thu, May 30, 2024 at 11:20:55AM +0800, Jason Wang wrote: > > > This patch synchronize operstate with admin state per RFC2863. > > > &g

Re: [PATCH net-next V2] virtio-net: synchronize operstate with admin state on up/down

2024-05-30 Thread Jason Wang
On Thu, May 30, 2024 at 2:10 PM Michael S. Tsirkin wrote: > > On Thu, May 30, 2024 at 11:20:55AM +0800, Jason Wang wrote: > > This patch synchronize operstate with admin state per RFC2863. > > > > This is done by trying to toggle the carrier upon open/close and > &g

[PATCH net-next V2] virtio-net: synchronize operstate with admin state on up/down

2024-05-29 Thread Jason Wang
qlen 1000 link/ether b2:a9:c5:04:da:53 brd ff:ff:ff:ff:ff:ff Cc: Venkat Venkatsubra Cc: Gia-Khanh Nguyen Reviewed-by: Xuan Zhuo Acked-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- Changes since V1: - rebase - add ack/review tags --- drivers/net/virtio_net.c | 94

Re: [PATCH V3 1/3] vhost-vdpa: flush workers on suspend

2024-05-21 Thread Jason Wang
On Tue, May 21, 2024 at 9:39 PM Steven Sistare wrote: > > On 5/20/2024 10:28 PM, Jason Wang wrote: > > On Mon, May 20, 2024 at 11:21 PM Steve Sistare > > wrote: > >> > >> Flush to guarantee no workers are running when suspend returns. > >> > >

Re: [PATCH V3 2/3] vduse: suspend

2024-05-21 Thread Jason Wang
On Tue, May 21, 2024 at 9:39 PM Steven Sistare wrote: > > On 5/20/2024 10:30 PM, Jason Wang wrote: > > On Mon, May 20, 2024 at 11:21 PM Steve Sistare > > wrote: > >> > >> Support the suspend operation. There is little to do, except flush to > >>

Re: [PATCH V3 3/3] vdpa_sim: flush workers on suspend

2024-05-21 Thread Jason Wang
On Tue, May 21, 2024 at 9:39 PM Steven Sistare wrote: > > On 5/20/2024 10:32 PM, Jason Wang wrote: > > On Mon, May 20, 2024 at 11:21 PM Steve Sistare > > wrote: > >> > >> Flush to guarantee no workers are running when suspend returns. > >> Add a lock

Re: [PATCH V3 3/3] vdpa_sim: flush workers on suspend

2024-05-20 Thread Jason Wang
On Mon, May 20, 2024 at 11:21 PM Steve Sistare wrote: > > Flush to guarantee no workers are running when suspend returns. > Add a lock to enforce ordering between clearing running, flushing, > and posting new work in vdpasim_kick_vq. It must be a spin lock > because vdpasim_kick_vq may be

Re: [PATCH V3 2/3] vduse: suspend

2024-05-20 Thread Jason Wang
On Mon, May 20, 2024 at 11:21 PM Steve Sistare wrote: > > Support the suspend operation. There is little to do, except flush to > guarantee no workers are running when suspend returns. > > Signed-off-by: Steve Sistare > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 24 >

Re: [PATCH V3 1/3] vhost-vdpa: flush workers on suspend

2024-05-20 Thread Jason Wang
On Mon, May 20, 2024 at 11:21 PM Steve Sistare wrote: > > Flush to guarantee no workers are running when suspend returns. > > Fixes: f345a0143b4d ("vhost-vdpa: uAPI to suspend the device") > Signed-off-by: Steve Sistare > Acked-by: Eugenio Pérez > --- > drivers/vhost/vdpa.c | 3 +++ > 1 file

Re: [REGRESSION][v6.8-rc1] virtio-pci: Introduce admin virtqueue

2024-05-16 Thread Jason Wang
el: random: crng reseeded on system resumption >> > May 08 11:08:42 kernel-test-202405080702.c.ubuntu-catred.internal >> > kernel: PM: suspend exit >> > May 08 11:08:42 kernel-test-202405080702.c.ubuntu-catred.internal >> > kernel: PM: suspend entry (s2idle) >> > -- Boot 6182

Re: [PATCH] vhost/vsock: always initialize seqpacket_allow

2024-05-15 Thread Jason Wang
S. Miller > Cc: Stefan Hajnoczi > Signed-off-by: Michael S. Tsirkin > Acked-by: Arseniy Krasnov > Tested-by: Arseniy Krasnov > Acked-by: Jason Wang Thanks

Re: [REGRESSION][v6.8-rc1] virtio-pci: Introduce admin virtqueue

2024-05-07 Thread Jason Wang
On Sat, May 4, 2024 at 2:10 AM Joseph Salisbury wrote: > > Hi Feng, > > During testing, a kernel bug was identified with the suspend/resume > functionality on instances running in a public cloud [0]. This bug is a > regression introduced in v6.8-rc1. After a kernel bisect, the following >

Re: [PATCH] virtio_net: Warn if insufficient queue length for transmitting

2024-05-05 Thread Jason Wang
On Wed, May 1, 2024 at 4:07 AM Michael S. Tsirkin wrote: > > On Tue, Apr 30, 2024 at 03:35:09PM -0400, Darius Rad wrote: > > The transmit queue is stopped when the number of free queue entries is less > > than 2+MAX_SKB_FRAGS, in start_xmit(). If the queue length (QUEUE_NUM_MAX) > > is less than

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-24 Thread Jason Wang
On Wed, Apr 24, 2024 at 5:51 PM Michael S. Tsirkin wrote: > > On Wed, Apr 24, 2024 at 08:44:10AM +0800, Jason Wang wrote: > > On Tue, Apr 23, 2024 at 4:42 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Apr 23, 2024 at 11:09:59AM +0800, Jason Wang wrote: > >

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-23 Thread Jason Wang
On Wed, Apr 24, 2024 at 11:15 AM Cindy Lu wrote: > > On Wed, Apr 24, 2024 at 8:44 AM Jason Wang wrote: > > > > On Tue, Apr 23, 2024 at 4:42 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Apr 23, 2024 at 11:09:59AM +0800, Jason Wang wrote: > > >

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-23 Thread Jason Wang
On Tue, Apr 23, 2024 at 4:42 PM Michael S. Tsirkin wrote: > > On Tue, Apr 23, 2024 at 11:09:59AM +0800, Jason Wang wrote: > > On Tue, Apr 23, 2024 at 4:05 AM Michael S. Tsirkin wrote: > > > > > > On Thu, Apr 18, 2024 at 08:57:51AM +0800, Jason Wang wrote: > >

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-22 Thread Jason Wang
On Tue, Apr 23, 2024 at 4:05 AM Michael S. Tsirkin wrote: > > On Thu, Apr 18, 2024 at 08:57:51AM +0800, Jason Wang wrote: > > On Wed, Apr 17, 2024 at 5:29 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Apr 12, 2024 at 09:28:23PM +0800, Cindy Lu w

Re: [PATCH v5 3/5] vduse: Add function to get/free the pages for reconnection

2024-04-17 Thread Jason Wang
On Wed, Apr 17, 2024 at 5:29 PM Michael S. Tsirkin wrote: > > On Fri, Apr 12, 2024 at 09:28:23PM +0800, Cindy Lu wrote: > > Add the function vduse_alloc_reconnnect_info_mem > > and vduse_alloc_reconnnect_info_mem > > These functions allow vduse to allocate and free memory for reconnection > >

Re: [PATCH net-next v9] virtio_net: Support RX hash XDP hint

2024-04-17 Thread Jason Wang
.@daynix.com/#r > > Signed-off-by: Liang Chen > --- Acked-by: Jason Wang Thanks

Re: [PATCH net-next v8] virtio_net: Support RX hash XDP hint

2024-04-16 Thread Jason Wang
On Tue, Apr 16, 2024 at 2:20 PM Liang Chen wrote: > > The RSS hash report is a feature that's part of the virtio specification. > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost > (still a work in progress as per [1]) support this feature. While the > capability to obtain

Re: [PATCH v5 5/5] Documentation: Add reconnect process for VDUSE

2024-04-15 Thread Jason Wang
On Fri, Apr 12, 2024 at 9:31 PM Cindy Lu wrote: > > Add a document explaining the reconnect process, including what the > Userspace App needs to do and how it works with the kernel. > > Signed-off-by: Cindy Lu > --- > Documentation/userspace-api/vduse.rst | 41 +++ > 1

Re: [PATCH v2] vhost-vdpa: Remove usage of the deprecated ida_simple_xx() API

2024-04-15 Thread Jason Wang
usive. So a -1 has been added when needed. > > Signed-off-by: Christophe JAILLET > Reviewed-by: Simon Horman Acked-by: Jason Wang Thanks

Re: [PATCH] drivers/virtio: delayed configuration descriptor flags

2024-04-08 Thread Jason Wang
On Tue, Apr 9, 2024 at 1:27 AM ni.liqiang wrote: > > In our testing of the virtio hardware accelerator, we found that > configuring the flags of the descriptor after addr and len, > as implemented in DPDK, seems to be more friendly to the hardware. > > In our Virtio hardware implementation tests,

Re: [PATCH v3] vp_vdpa: fix the method of calculating vectors

2024-04-08 Thread Jason Wang
vp_vdpa->msix_name, vp_vdpa); > if (ret) { > dev_err(>dev, > - "vp_vdpa: fail to request irq for vq %d\n", i); > + "vp_vdpa: fail to request irq for config\n"); > goto err; > } > - vp_modern_config_vector(mdev, queues); > + vp_modern_config_vector(mdev, msix_vec); > vp_vdpa->config_irq = irq; > - Unnecessary changes. Others look good. Acked-by: Jason Wang Thanks > return 0; > err: > vp_vdpa_free_irq(vp_vdpa); > -- > 2.43.0 >

Re: [PATCH net-next v5] virtio_net: Support RX hash XDP hint

2024-04-08 Thread Jason Wang
On Mon, Apr 1, 2024 at 11:38 AM Liang Chen wrote: > > On Thu, Feb 29, 2024 at 4:37 PM Liang Chen wrote: > > > > On Tue, Feb 27, 2024 at 4:42 AM John Fastabend > > wrote: > > > > > > Jason Wang wrote: > > > > On Fri, Feb 23, 2024 at 9:42 AM

Re: Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-04-08 Thread Jason Wang
On Wed, Apr 3, 2024 at 10:47 AM tab wrote: > > > > > > > On Fri, Mar 29, 2024 at 11:55:50AM +0800, Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 5:08 PM Jason Wang wrote: > > > > > > > > > > On Thu, Mar 21, 2024 at 3:00 PM Micha

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-04-06 Thread Jason Wang
On Fri, Mar 29, 2024 at 6:42 PM Michael S. Tsirkin wrote: > > On Fri, Mar 29, 2024 at 06:39:33PM +0800, Jason Wang wrote: > > On Fri, Mar 29, 2024 at 5:13 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Mar 27, 2024 at 05:08:57PM +0800, Jason Wang wrote: > >

Re: [PATCH] vhost-vdpa: change ioctl # for VDPA_GET_VRING_SIZE

2024-04-06 Thread Jason Wang
vhost-vdpa: uapi to support reporting per vq size") > Cc: "Zhu Lingshan" > Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang Thanks > --- > > Build tested only - userspace patches using this will have to adjust. > I will merge this in a week or so unless

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-29 Thread Jason Wang
On Fri, Mar 29, 2024 at 5:13 PM Michael S. Tsirkin wrote: > > On Fri, Mar 29, 2024 at 11:55:50AM +0800, Jason Wang wrote: > > On Wed, Mar 27, 2024 at 5:08 PM Jason Wang wrote: > > > > > > On Thu, Mar 21, 2024 at 3:00 PM Michael S. Tsirkin > > > wrote: >

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-29 Thread Jason Wang
On Fri, Mar 29, 2024 at 5:13 PM Michael S. Tsirkin wrote: > > On Wed, Mar 27, 2024 at 05:08:57PM +0800, Jason Wang wrote: > > On Thu, Mar 21, 2024 at 3:00 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Mar 20, 2024 at 06:19:12PM +0800, Wang Rong

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-28 Thread Jason Wang
On Wed, Mar 27, 2024 at 5:08 PM Jason Wang wrote: > > On Thu, Mar 21, 2024 at 3:00 PM Michael S. Tsirkin wrote: > > > > On Wed, Mar 20, 2024 at 06:19:12PM +0800, Wang Rong wrote: > > > From: Rong Wang > > > > > > Once enable iommu domain for one

Re: [PATCH v2 1/1] vhost: Added pad cleanup if vnet_hdr is not present.

2024-03-27 Thread Jason Wang
d to set up qemu with > vhost=on,vnet_hdr=off, or do not configure vhost in the custom program. > > Signed-off-by: Andrew Melnychenko Acked-by: Jason Wang It seems it has been merged by Michael. Thanks > --- > drivers/vhost/net.c | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [PATCH v3 3/3] vhost: Improve vhost_get_avail_idx() with smp_rmb()

2024-03-27 Thread Jason Wang
_rmb() is executed when > the avail_idx is advanced. With it, the callers needn't to worry > about the memory barrier. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Gavin Shan Acked-by: Jason Wang Thanks

Re: [PATCH v3] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2024-03-27 Thread Jason Wang
On Thu, Mar 21, 2024 at 3:00 PM Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2024 at 06:19:12PM +0800, Wang Rong wrote: > > From: Rong Wang > > > > Once enable iommu domain for one device, the MSI > > translation tables have to be there for software-managed MSI. > > Otherwise, platform with

Re: [PATCH v2 1/2] vhost: Add smp_rmb() in vhost_vq_avail_empty()

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 3:35 PM Gavin Shan wrote: > > On 3/27/24 14:08, Gavin Shan wrote: > > On 3/27/24 12:44, Jason Wang wrote: > >> On Wed, Mar 27, 2024 at 10:34 AM Jason Wang wrote: > >>> On Wed, Mar 27, 2024 at 7:39 AM Gavin Shan wrote: > >

  1   2   3   4   5   6   7   8   9   10   >