Re: [PATCH v4 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-11-04 Thread Jassi Brar
On Fri, Nov 3, 2017 at 8:17 PM, Sudeep Holla wrote: . > +int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > +{ > + int ret; > + int timeout; > + struct scmi_info *info = handle_to_scmi_info(handle); > + struct device

Re: [PATCH v4 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-11-04 Thread Jassi Brar
On Fri, Nov 3, 2017 at 8:17 PM, Sudeep Holla wrote: . > +int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > +{ > + int ret; > + int timeout; > + struct scmi_info *info = handle_to_scmi_info(handle); > + struct device *dev = info->dev; > + >

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 6:07 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > On 02/11/17 12:21, Jassi Brar wrote: >> On Thu, Nov 2, 2017 at 5:19 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >>> On 02/11/17 11:26, Jassi Brar wrote: >> >>>>>>

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 6:07 PM, Sudeep Holla wrote: > On 02/11/17 12:21, Jassi Brar wrote: >> On Thu, Nov 2, 2017 at 5:19 PM, Sudeep Holla wrote: >>> On 02/11/17 11:26, Jassi Brar wrote: >> >>>>>> 1) Where does the "whatever_value_to_trigger_sign

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 5:19 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > On 02/11/17 11:26, Jassi Brar wrote: >>>> 1) Where does the "whatever_value_to_trigger_signal" come from? >>> >>> Controller specific. >>> >>>> Th

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 5:19 PM, Sudeep Holla wrote: > On 02/11/17 11:26, Jassi Brar wrote: >>>> 1) Where does the "whatever_value_to_trigger_signal" come from? >>> >>> Controller specific. >>> >>>> That has to come from client

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 4:17 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > On 02/11/17 02:39, Jassi Brar wrote: >>>>> >>>>> Such controllers don't need to transmit any data, they just transmit >>>>> the signal. In such controllers the da

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-02 Thread Jassi Brar
On Thu, Nov 2, 2017 at 4:17 PM, Sudeep Holla wrote: > On 02/11/17 02:39, Jassi Brar wrote: >>>>> >>>>> Such controllers don't need to transmit any data, they just transmit >>>>> the signal. In such controllers the data pointer passed to >

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 8:57 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Wed 01 Nov 20:02 PDT 2017, Jassi Brar wrote: > >> On Thu, Nov 2, 2017 at 3:47 AM, Bjorn Andersson >> <bjorn.anders...@linaro.org> wrote: >> > On Wed 01 Nov 11:15 PDT 20

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 8:57 AM, Bjorn Andersson wrote: > On Wed 01 Nov 20:02 PDT 2017, Jassi Brar wrote: > >> On Thu, Nov 2, 2017 at 3:47 AM, Bjorn Andersson >> wrote: >> > On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: >> >> >> >>

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 3:47 AM, Bjorn Andersson wrote: > On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: >> >> 80 writel_relaxed(msg->cmd, mb->mbox_base + >> MAILBOX_A2B_CMD(chans->idx)); >> 81 writel_relaxed(msg->rx_size, mb->mbox_base + >> >> 82

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 3:47 AM, Bjorn Andersson wrote: > On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: >> >> 80 writel_relaxed(msg->cmd, mb->mbox_base + >> MAILBOX_A2B_CMD(chans->idx)); >> 81 writel_relaxed(msg->rx_size, mb->mbox_base + >> >> 82

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 3:42 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Wed 01 Nov 11:03 PDT 2017, Jassi Brar wrote: >> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > [..] >> > >> > This is rough idea I have

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Thu, Nov 2, 2017 at 3:42 AM, Bjorn Andersson wrote: > On Wed 01 Nov 11:03 PDT 2017, Jassi Brar wrote: >> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: > [..] >> > >> > This is rough idea I have on extending mailbox interface to support >> >

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Wed, Nov 1, 2017 at 11:45 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 01/11/17 18:03, Jassi Brar wrote: >> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >> >>> >>> Such controllers don't need to t

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Wed, Nov 1, 2017 at 11:45 PM, Sudeep Holla wrote: > > > On 01/11/17 18:03, Jassi Brar wrote: >> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: >> >>> >>> Such controllers don't need to transmit any data, they just transmit >>> the sig

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: > > Such controllers don't need to transmit any data, they just transmit > the signal. In such controllers the data pointer passed to > mbox_send_message is passed to client via it's tx_prepare callback. > Controller

Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

2017-11-01 Thread Jassi Brar
On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla wrote: > > Such controllers don't need to transmit any data, they just transmit > the signal. In such controllers the data pointer passed to > mbox_send_message is passed to client via it's tx_prepare callback. > Controller doesn't need any data to

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

2017-10-24 Thread Jassi Brar
On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > From: Kaihua Zhong > > Add mailbox driver for Hi3660. > > Signed-off-by: Leo Yan > Signed-off-by: Ruyi Wang > Tested-by: Kaihua Zhong

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

2017-10-24 Thread Jassi Brar
On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > From: Kaihua Zhong > > Add mailbox driver for Hi3660. > > Signed-off-by: Leo Yan > Signed-off-by: Ruyi Wang > Tested-by: Kaihua Zhong > > --- > drivers/mailbox/Kconfig | 6 + > drivers/mailbox/Makefile | 2 + >

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-13 Thread Jassi Brar
On Fri, Oct 13, 2017 at 8:17 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > On 13/10/17 15:12, Jassi Brar wrote: > >> In MHU the 32bits are tied together and all go to one target >> processor. Whereas on QCom, each bit corresponds to independent signal >> going t

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-13 Thread Jassi Brar
On Fri, Oct 13, 2017 at 8:17 PM, Sudeep Holla wrote: > On 13/10/17 15:12, Jassi Brar wrote: > >> In MHU the 32bits are tied together and all go to one target >> processor. Whereas on QCom, each bit corresponds to independent signal >> going to a different target processor

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-13 Thread Jassi Brar
t; wrote: >>> >>> >>> On 06/10/17 14:47, Jassi Brar wrote: >>>> On Fri, Oct 6, 2017 at 7:02 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >> [..] >>>>> Again that's not the point, doorbell is more common feature and that can &g

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-13 Thread Jassi Brar
On Fri, Oct 13, 2017 at 7:12 PM, Sudeep Holla wrote: > > Hi Bjorn, > > Thanks for taking a look at this. Much appreciated. > > On 12/10/17 22:03, Bjorn Andersson wrote: >> On Fri, Oct 6, 2017 at 6:51 AM, Sudeep Holla wrote: >>> >>> >>> On 0

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-09 Thread Jassi Brar
On Tue, Oct 10, 2017 at 4:27 AM, Rob Herring <r...@kernel.org> wrote: > On Mon, Oct 9, 2017 at 9:46 AM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Mon, Oct 9, 2017 at 7:22 PM, Rob Herring <r...@kernel.org> wrote: >>> On Fri, Oct 6, 2017 at 9:26 PM,

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-09 Thread Jassi Brar
On Tue, Oct 10, 2017 at 4:27 AM, Rob Herring wrote: > On Mon, Oct 9, 2017 at 9:46 AM, Jassi Brar wrote: >> On Mon, Oct 9, 2017 at 7:22 PM, Rob Herring wrote: >>> On Fri, Oct 6, 2017 at 9:26 PM, Jassi Brar wrote: >>>> On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring wr

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-09 Thread Jassi Brar
On Mon, Oct 9, 2017 at 7:22 PM, Rob Herring <r...@kernel.org> wrote: > On Fri, Oct 6, 2017 at 9:26 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring <r...@kernel.org> wrote: >>> On Fri, Oct 6, 2017 at 6:01 AM,

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-09 Thread Jassi Brar
On Mon, Oct 9, 2017 at 7:22 PM, Rob Herring wrote: > On Fri, Oct 6, 2017 at 9:26 PM, Jassi Brar wrote: >> On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring wrote: >>> On Fri, Oct 6, 2017 at 6:01 AM, Jassi Brar wrote: >>>> On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring wro

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring <r...@kernel.org> wrote: > On Fri, Oct 6, 2017 at 6:01 AM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring <r...@kernel.org> wrote: >>> On Thu, Sep 28, 2017 at

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring wrote: > On Fri, Oct 6, 2017 at 6:01 AM, Jassi Brar wrote: >> On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring wrote: >>> On Thu, Sep 28, 2017 at 02:11:27PM +0100, Sudeep Holla wrote: >>> >>>> +- mbox-data : For

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 7:02 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 06/10/17 12:26, Jassi Brar wrote: >> On Wed, Oct 4, 2017 at 5:06 PM, Arnd Bergmann <a...@arndb.de> wrote: >>> On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla <sudeep.ho...@arm.c

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 7:02 PM, Sudeep Holla wrote: > > > On 06/10/17 12:26, Jassi Brar wrote: >> On Wed, Oct 4, 2017 at 5:06 PM, Arnd Bergmann wrote: >>> On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: >>>> This patch adds ARM MHU specific mailbox in

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 6:57 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 06/10/17 12:34, Jassi Brar wrote: >> On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >> >>> Also, I have added shim only for specific controllers

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 6:57 PM, Sudeep Holla wrote: > > > On 06/10/17 12:34, Jassi Brar wrote: >> On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: >> >>> Also, I have added shim only for specific controllers that need them. >>> E.g. ARM MHU as Ja

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: > Also, I have added shim only for specific controllers that need them. > E.g. ARM MHU as Jassi disagreed to add doorbell mechanism to that. > mbox_if provides default implementation that just calls direct mailbox > APIs.

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: > Also, I have added shim only for specific controllers that need them. > E.g. ARM MHU as Jassi disagreed to add doorbell mechanism to that. > mbox_if provides default implementation that just calls direct mailbox > APIs. > Yeah you could hack

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-06 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:06 PM, Arnd Bergmann wrote: > On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: >> This patch adds ARM MHU specific mailbox interface for SCMI. >> >> Cc: Arnd Bergmann >> Signed-off-by: Sudeep Holla

Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface

2017-10-06 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:06 PM, Arnd Bergmann wrote: > On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: >> This patch adds ARM MHU specific mailbox interface for SCMI. >> >> Cc: Arnd Bergmann >> Signed-off-by: Sudeep Holla > > This clearly needs an explanation why we need another driver. >

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring wrote: > On Thu, Sep 28, 2017 at 02:11:27PM +0100, Sudeep Holla wrote: >> This patch adds ARM MHU specific mailbox client bindings to support >> SCMI. Since SCMI specification just requires doorbell mechanism from >> mailbox

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring wrote: > On Thu, Sep 28, 2017 at 02:11:27PM +0100, Sudeep Holla wrote: >> This patch adds ARM MHU specific mailbox client bindings to support >> SCMI. Since SCMI specification just requires doorbell mechanism from >> mailbox controllers, we add mailbox

Re: [PATCH v3 02/22] dt-bindings: arm: add support for ARM System Control and Management Interface(SCMI) protocol

2017-10-05 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:35 AM, Arnd Bergmann wrote: > On Wed, Oct 4, 2017 at 1:07 PM, Sudeep Holla wrote: >> On 04/10/17 11:50, Arnd Bergmann wrote: >>> On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: > +- shmem : List of

Re: [PATCH v3 02/22] dt-bindings: arm: add support for ARM System Control and Management Interface(SCMI) protocol

2017-10-05 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:35 AM, Arnd Bergmann wrote: > On Wed, Oct 4, 2017 at 1:07 PM, Sudeep Holla wrote: >> On 04/10/17 11:50, Arnd Bergmann wrote: >>> On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: > +- shmem : List of phandle pointing to the shared memory(SHM) area as per +

Re: [PATCH net-next 3/3] net: phy: realtek: add RTL8201F phy-id and functions

2017-09-08 Thread Jassi Brar
On 9 September 2017 at 00:21, Florian Fainelli <f.faine...@gmail.com> wrote: > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: >> From: Jassi Brar <jaswinder.si...@linaro.org> >> >> Add RTL8201F phy-id and the related functions to the driver. >> >&g

Re: [PATCH net-next 3/3] net: phy: realtek: add RTL8201F phy-id and functions

2017-09-08 Thread Jassi Brar
On 9 September 2017 at 00:21, Florian Fainelli wrote: > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: >> From: Jassi Brar >> >> Add RTL8201F phy-id and the related functions to the driver. >> >> The original patch is as follows: >> https://patchwork.ker

[GIT PULL] Mailbox changes for v4.14

2017-09-06 Thread Jassi Brar
Hi Linus, The following changes since commit 14ccee78fc82f5512908f4424f541549a5705b89: Linux 4.13-rc6 (2017-08-20 14:13:52 -0700) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v4.14 for you to fetch changes up to

[GIT PULL] Mailbox changes for v4.14

2017-09-06 Thread Jassi Brar
Hi Linus, The following changes since commit 14ccee78fc82f5512908f4424f541549a5705b89: Linux 4.13-rc6 (2017-08-20 14:13:52 -0700) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v4.14 for you to fetch changes up to

Re: [PATCH v2] drivers/mailbox: Add Aspeed mailbox driver

2017-09-04 Thread Jassi Brar
On Mon, Sep 4, 2017 at 12:47 PM, Cyril Bur wrote: > Hi, > > I haven't heard anything about this driver. I'm trying to interpret if > the silence is because there is something fundamentally wrong with the > driver or is it because it doesn't use any of the mailbox >

Re: [PATCH v2] drivers/mailbox: Add Aspeed mailbox driver

2017-09-04 Thread Jassi Brar
On Mon, Sep 4, 2017 at 12:47 PM, Cyril Bur wrote: > Hi, > > I haven't heard anything about this driver. I'm trying to interpret if > the silence is because there is something fundamentally wrong with the > driver or is it because it doesn't use any of the mailbox > infrastructure it is being

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

2017-09-02 Thread Jassi Brar
On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > From: Kaihua Zhong > > Add mailbox driver for Hi3660. > > Signed-off-by: Leo Yan > Signed-off-by: Ruyi Wang > Tested-by: Kaihua Zhong

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

2017-09-02 Thread Jassi Brar
On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > From: Kaihua Zhong > > Add mailbox driver for Hi3660. > > Signed-off-by: Leo Yan > Signed-off-by: Ruyi Wang > Tested-by: Kaihua Zhong > > --- > drivers/mailbox/Kconfig | 6 + > drivers/mailbox/Makefile | 2 + >

Re: linux-next: Signed-off-by missing for commits in the mailbox tree

2017-08-30 Thread Jassi Brar
On 30 August 2017 at 22:45, Stephen Rothwell wrote: > Hi Jassi, > > Commits > > da91001cab90 ("mailbox: bcm-flexrm-mailbox: Set IRQ affinity hint for FlexRM > ring IRQs") > 6bee3ba26d4d ("mailbox: bcm-flexrm-mailbox: Add debugfs support") > 73c28265c82b ("mailbox:

Re: linux-next: Signed-off-by missing for commits in the mailbox tree

2017-08-30 Thread Jassi Brar
On 30 August 2017 at 22:45, Stephen Rothwell wrote: > Hi Jassi, > > Commits > > da91001cab90 ("mailbox: bcm-flexrm-mailbox: Set IRQ affinity hint for FlexRM > ring IRQs") > 6bee3ba26d4d ("mailbox: bcm-flexrm-mailbox: Add debugfs support") > 73c28265c82b ("mailbox: bcm-flexrm-mailbox: Fix mask

Re: [PATCH v2 03/18] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-08-08 Thread Jassi Brar
On Tue, Aug 8, 2017 at 2:59 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 08/08/17 03:46, Jassi Brar wrote: >> On Fri, Aug 4, 2017 at 8:01 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >> >> >>> +int scmi_do_xfer(const st

Re: [PATCH v2 03/18] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-08-08 Thread Jassi Brar
On Tue, Aug 8, 2017 at 2:59 PM, Sudeep Holla wrote: > > > On 08/08/17 03:46, Jassi Brar wrote: >> On Fri, Aug 4, 2017 at 8:01 PM, Sudeep Holla wrote: >> >> >>> +int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) >>> +{

Re: [PATCH v2 03/18] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-08-07 Thread Jassi Brar
On Fri, Aug 4, 2017 at 8:01 PM, Sudeep Holla wrote: > +int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > +{ > + int ret; > + int timeout; > + struct scmi_info *info = handle_to_scmi_info(handle); > + struct device *dev

Re: [PATCH v2 03/18] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-08-07 Thread Jassi Brar
On Fri, Aug 4, 2017 at 8:01 PM, Sudeep Holla wrote: > +int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > +{ > + int ret; > + int timeout; > + struct scmi_info *info = handle_to_scmi_info(handle); > + struct device *dev = info->dev; > + > +

Re: [PATCH v2 2/3] mailbox: introduce ARM SMC based mailbox

2017-08-01 Thread Jassi Brar
On Mon, Jul 24, 2017 at 4:53 AM, Andre Przywara wrote: > +static int arm_smc_send_data(struct mbox_chan *link, void *data) > +{ > + struct arm_smc_chan_data *chan_data = link->con_priv; > + u32 function_id = chan_data->function_id; > + struct

Re: [PATCH v2 2/3] mailbox: introduce ARM SMC based mailbox

2017-08-01 Thread Jassi Brar
On Mon, Jul 24, 2017 at 4:53 AM, Andre Przywara wrote: > +static int arm_smc_send_data(struct mbox_chan *link, void *data) > +{ > + struct arm_smc_chan_data *chan_data = link->con_priv; > + u32 function_id = chan_data->function_id; > + struct arm_smccc_res res; > + u32

Re: [PATCH v2 0/3] mailbox: arm: introduce smc triggered mailbox

2017-08-01 Thread Jassi Brar
On Tue, Aug 1, 2017 at 4:20 PM, Alexander Graf wrote: > Hi Andre, > > On 24.07.17 01:23, Andre Przywara wrote: >> >> This is a reworked version of my previous post. It addresses Jassi's >> comments on the driver and also tries to cover Rob's and Mark's comments >> on the binding

Re: [PATCH v2 0/3] mailbox: arm: introduce smc triggered mailbox

2017-08-01 Thread Jassi Brar
On Tue, Aug 1, 2017 at 4:20 PM, Alexander Graf wrote: > Hi Andre, > > On 24.07.17 01:23, Andre Przywara wrote: >> >> This is a reworked version of my previous post. It addresses Jassi's >> comments on the driver and also tries to cover Rob's and Mark's comments >> on the binding documentation. >>

Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

2017-07-31 Thread Jassi Brar
this message. >> >> Signed-off-by: Punit Agrawal <punit.agra...@arm.com> >> Cc: Jassi Brar <jassisinghb...@gmail.com> >> --- >> drivers/mailbox/pcc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/mail

Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

2017-07-31 Thread Jassi Brar
x driver >> prints - >> >> [0.484261] PCCT header not found. >> >> during probe before returning -ENODEV. >> >> This message clutters the bootlog and doesn't provide any useful >> information. Drop this message. >> >> Signed-off-by: Punit Ag

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-28 Thread Jassi Brar
On Fri, Jul 28, 2017 at 3:18 PM, Anup Patel <anup.pa...@broadcom.com> wrote: > On Fri, Jul 28, 2017 at 2:34 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Fri, Jul 28, 2017 at 2:19 PM, Anup Patel <anup.pa...@broadcom.com> wrote: >>> On Thu, Jul 27, 2017

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-28 Thread Jassi Brar
On Fri, Jul 28, 2017 at 3:18 PM, Anup Patel wrote: > On Fri, Jul 28, 2017 at 2:34 PM, Jassi Brar wrote: >> On Fri, Jul 28, 2017 at 2:19 PM, Anup Patel wrote: >>> On Thu, Jul 27, 2017 at 5:23 PM, Jassi Brar >>> wrote: >>>> On Thu, Jul 27, 2017 at 11:20 AM

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-28 Thread Jassi Brar
On Fri, Jul 28, 2017 at 2:19 PM, Anup Patel <anup.pa...@broadcom.com> wrote: > On Thu, Jul 27, 2017 at 5:23 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Thu, Jul 27, 2017 at 11:20 AM, Anup Patel <anup.pa...@broadcom.com> wrote: >>> On Thu,

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-28 Thread Jassi Brar
On Fri, Jul 28, 2017 at 2:19 PM, Anup Patel wrote: > On Thu, Jul 27, 2017 at 5:23 PM, Jassi Brar wrote: >> On Thu, Jul 27, 2017 at 11:20 AM, Anup Patel wrote: >>> On Thu, Jul 27, 2017 at 10:29 AM, Jassi Brar >>> wrote: >> >>>>>>>>>

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-27 Thread Jassi Brar
On Thu, Jul 27, 2017 at 11:20 AM, Anup Patel <anup.pa...@broadcom.com> wrote: > On Thu, Jul 27, 2017 at 10:29 AM, Jassi Brar <jassisinghb...@gmail.com> wrote: >>>>>>> Sorry for the delayed response... >>>>>>> >>>>>

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-27 Thread Jassi Brar
On Thu, Jul 27, 2017 at 11:20 AM, Anup Patel wrote: > On Thu, Jul 27, 2017 at 10:29 AM, Jassi Brar wrote: >>>>>>> Sorry for the delayed response... >>>>>>> >>>>>>> On Fri, Jul 21, 2017 at 9:16 PM, Jassi Brar >>>>&

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-26 Thread Jassi Brar
On Thu, Jul 27, 2017 at 9:25 AM, Anup Patel <anup.pa...@broadcom.com> wrote: > On Tue, Jul 25, 2017 at 9:37 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Tue, Jul 25, 2017 at 11:11 AM, Anup Patel <anup.pa...@broadcom.com> wrote: >>> On Mon,

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-26 Thread Jassi Brar
On Thu, Jul 27, 2017 at 9:25 AM, Anup Patel wrote: > On Tue, Jul 25, 2017 at 9:37 PM, Jassi Brar wrote: >> On Tue, Jul 25, 2017 at 11:11 AM, Anup Patel wrote: >>> On Mon, Jul 24, 2017 at 10:06 PM, Jassi Brar >>> wrote: >>>> On Mon, Jul 24, 2017 at 9:2

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-25 Thread Jassi Brar
On Tue, Jul 25, 2017 at 11:11 AM, Anup Patel <anup.pa...@broadcom.com> wrote: > On Mon, Jul 24, 2017 at 10:06 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Mon, Jul 24, 2017 at 9:26 AM, Anup Patel <anup.pa...@broadcom.com> wrote: >>> Hi Jassi, &g

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-25 Thread Jassi Brar
On Tue, Jul 25, 2017 at 11:11 AM, Anup Patel wrote: > On Mon, Jul 24, 2017 at 10:06 PM, Jassi Brar wrote: >> On Mon, Jul 24, 2017 at 9:26 AM, Anup Patel wrote: >>> Hi Jassi, >>> >>> Sorry for the delayed response... >>> >>> On Fri, Jul 21,

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 11:08 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > On 24/07/17 18:20, Jassi Brar wrote: >> >>> I see that the SCPI firmware driver (as the user of the mailbox API) is >>> expecting the return value from a0 as returned above, transla

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 11:08 PM, Sudeep Holla wrote: > On 24/07/17 18:20, Jassi Brar wrote: >> >>> I see that the SCPI firmware driver (as the user of the mailbox API) is >>> expecting the return value from a0 as returned above, translating the >>> f

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 4:50 AM, André Przywara <andre.przyw...@arm.com> wrote: > On 02/07/17 06:55, Jassi Brar wrote: > >>> + mbox_chan_received_data(link, (void *)res.a0); >>> + >> Or you can update the 'data' with value from 'a0' ? > >

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 4:50 AM, André Przywara wrote: > On 02/07/17 06:55, Jassi Brar wrote: > >>> + mbox_chan_received_data(link, (void *)res.a0); >>> + >> Or you can update the 'data' with value from 'a0' ? > > Mmh, I am a bit puzzled by this. Why

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 9:51 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > On 24/07/17 16:41, Jassi Brar wrote: >> SCMI calls >> mbox_send_message(struct mbox_chan *chan, struct scmi_xfer *xfer); >> >> whereas the API expects >> mbox_send

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 9:51 PM, Sudeep Holla wrote: > On 24/07/17 16:41, Jassi Brar wrote: >> SCMI calls >> mbox_send_message(struct mbox_chan *chan, struct scmi_xfer *xfer); >> >> whereas the API expects >> mbox_send_message(struct mbox_chan *chan, str

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 9:26 AM, Anup Patel <anup.pa...@broadcom.com> wrote: > Hi Jassi, > > Sorry for the delayed response... > > On Fri, Jul 21, 2017 at 9:16 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> Hi Anup, >> >> On Fri, Jul 21, 2017 at

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 9:26 AM, Anup Patel wrote: > Hi Jassi, > > Sorry for the delayed response... > > On Fri, Jul 21, 2017 at 9:16 PM, Jassi Brar wrote: >> Hi Anup, >> >> On Fri, Jul 21, 2017 at 12:25 PM, Anup Patel wrote: >>> The Broadcom Fle

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 3:20 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 08/07/17 06:32, Jassi Brar wrote: >> Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc, >> >> I have a gut feeling you guys were part of the SCMI spec committee. If >> so, c

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-24 Thread Jassi Brar
On Mon, Jul 24, 2017 at 3:20 PM, Sudeep Holla wrote: > > > On 08/07/17 06:32, Jassi Brar wrote: >> Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc, >> >> I have a gut feeling you guys were part of the SCMI spec committee. If >> so, could you please chime i

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-21 Thread Jassi Brar
Hi Anup, On Fri, Jul 21, 2017 at 12:25 PM, Anup Patel wrote: > The Broadcom FlexRM ring (i.e. mailbox channel) can handle > larger number of messages queued in one FlexRM ring hence > this patch sets msg_queue_len for each mailbox channel to > be same as

Re: [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel

2017-07-21 Thread Jassi Brar
Hi Anup, On Fri, Jul 21, 2017 at 12:25 PM, Anup Patel wrote: > The Broadcom FlexRM ring (i.e. mailbox channel) can handle > larger number of messages queued in one FlexRM ring hence > this patch sets msg_queue_len for each mailbox channel to > be same as RING_MAX_REQ_COUNT. > > Signed-off-by:

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-07 Thread Jassi Brar
Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc, I have a gut feeling you guys were part of the SCMI spec committee. If so, could you please chime in? On Fri, Jul 7, 2017 at 11:09 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 07/07/17 17:52, Jassi Brar wrote: >> Hi

Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-07 Thread Jassi Brar
Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc, I have a gut feeling you guys were part of the SCMI spec committee. If so, could you please chime in? On Fri, Jul 7, 2017 at 11:09 PM, Sudeep Holla wrote: > > > On 07/07/17 17:52, Jassi Brar wrote: >> Hi Arnd, Hi Rob, Hi Mark, >

[PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-07 Thread Jassi Brar
Hi Arnd, Hi Rob, Hi Mark, [CC'ing only those who I have the email id of] >+/** >+ * scmi_do_xfer() - Do one transfer >+ * >+ * @info: Pointer to SCMI entity information >+ * @xfer: Transfer to initiate and wait for response >+ * >+ * Return: -ETIMEDOUT in case of no response, if transmit error,

[PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-07-07 Thread Jassi Brar
Hi Arnd, Hi Rob, Hi Mark, [CC'ing only those who I have the email id of] >+/** >+ * scmi_do_xfer() - Do one transfer >+ * >+ * @info: Pointer to SCMI entity information >+ * @xfer: Transfer to initiate and wait for response >+ * >+ * Return: -ETIMEDOUT in case of no response, if transmit error,

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-07 Thread Jassi Brar
On Fri, Jul 7, 2017 at 5:02 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 06/07/17 19:37, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 10:14 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >>> >>> On 06/07/17 15:37, Jassi Brar wrote: >

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-07 Thread Jassi Brar
On Fri, Jul 7, 2017 at 5:02 PM, Sudeep Holla wrote: > > > On 06/07/17 19:37, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 10:14 PM, Sudeep Holla wrote: >>> >>> On 06/07/17 15:37, Jassi Brar wrote: >>>> On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla wr

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 10:14 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > On 06/07/17 15:37, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > >> I see no reason why you must have SCPI and SCMI both ru

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 10:14 PM, Sudeep Holla wrote: > > On 06/07/17 15:37, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla wrote: > >> I see no reason why you must have SCPI and SCMI both running. >> > > We can still have 2 different

[GIT PULL] Mailbox changes for v4.13

2017-07-06 Thread Jassi Brar
Hi Linus, The following changes since commit 63f700aab4c11d46626de3cd051dae56cf7e9056: Merge tag 'xtensa-20170612' of git://github.com/jcmvbkbc/linux-xtensa (2017-06-13 15:09:10 +0900) are available in the git repository at:

[GIT PULL] Mailbox changes for v4.13

2017-07-06 Thread Jassi Brar
Hi Linus, The following changes since commit 63f700aab4c11d46626de3cd051dae56cf7e9056: Merge tag 'xtensa-20170612' of git://github.com/jcmvbkbc/linux-xtensa (2017-06-13 15:09:10 +0900) are available in the git repository at:

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 06/07/17 10:27, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 2:48 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >>> Hi Jassi, >>> >>> On 06/07/17 07:28,

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla wrote: > > > On 06/07/17 10:27, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 2:48 PM, Sudeep Holla wrote: >>> Hi Jassi, >>> >>> On 06/07/17 07:28, Jassi Brar wrote: >>>> On Wed, Jul 5, 2017 at

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 2:48 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > Hi Jassi, > > On 06/07/17 07:28, Jassi Brar wrote: >> On Wed, Jul 5, 2017 at 11:32 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >> >>> >>> I have posted the SCMI pat

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 2:48 PM, Sudeep Holla wrote: > Hi Jassi, > > On 06/07/17 07:28, Jassi Brar wrote: >> On Wed, Jul 5, 2017 at 11:32 PM, Sudeep Holla wrote: >> >>> >>> I have posted the SCMI patches now[1], >>> >> I wish I was CC'ed on t

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Wed, Jul 5, 2017 at 11:32 PM, Sudeep Holla wrote: > > I have posted the SCMI patches now[1], > I wish I was CC'ed on that. Now LKML seems too busy to forward it. > please let me know how to get > both SCPI and SCMI working together with different doorbell bits on the >

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Wed, Jul 5, 2017 at 11:32 PM, Sudeep Holla wrote: > > I have posted the SCMI patches now[1], > I wish I was CC'ed on that. Now LKML seems too busy to forward it. > please let me know how to get > both SCPI and SCMI working together with different doorbell bits on the > same channel. > You

<    1   2   3   4   5   6   7   8   9   10   >