Re: [PATCH 1/2] mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone

2017-07-03 Thread Jassi Brar
On 3 July 2017 at 15:05, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 03/07/17 09:57, Sudeep Holla wrote: >> >> >> On 01/07/17 12:25, Jassi Brar wrote: >>> On Fri, Jun 30, 2017 at 8:44 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >>

Re: [PATCH 1/2] mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone

2017-07-03 Thread Jassi Brar
On 3 July 2017 at 15:05, Sudeep Holla wrote: > > > On 03/07/17 09:57, Sudeep Holla wrote: >> >> >> On 01/07/17 12:25, Jassi Brar wrote: >>> On Fri, Jun 30, 2017 at 8:44 PM, Sudeep Holla wrote: >>>> Currently the mailbox framework sets txdone_meth

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-02 Thread Jassi Brar
On Fri, Jun 30, 2017 at 3:26 PM, Andre Przywara wrote: > This mailbox driver implements a mailbox which signals transmitted data > via an ARM smc (secure monitor call) instruction. The mailbox receiver > is implemented in firmware and can synchronously return data when it

Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox

2017-07-02 Thread Jassi Brar
On Fri, Jun 30, 2017 at 3:26 PM, Andre Przywara wrote: > This mailbox driver implements a mailbox which signals transmitted data > via an ARM smc (secure monitor call) instruction. The mailbox receiver > is implemented in firmware and can synchronously return data when it > returns execution to

Re: [PATCH 1/2] mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone

2017-07-01 Thread Jassi Brar
the issue by resetting TXDONE_BY_POLL if client has set > knows_txdone. > > Cc: Alexey Klimov <alexey.kli...@arm.com> > Cc: Jassi Brar <jaswinder.si...@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com> > --- > drivers/mailbox/mailbox.c | 2 +- &g

Re: [PATCH 1/2] mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone

2017-07-01 Thread Jassi Brar
NE_BY_POLL if client has set > knows_txdone. > > Cc: Alexey Klimov > Cc: Jassi Brar > Signed-off-by: Sudeep Holla > --- > drivers/mailbox/mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox

Re: [PATCH 1/5] clk: mb86s7x: Suppress build

2017-06-28 Thread Jassi Brar
On 28 June 2017 at 21:43, Stephen Boyd wrote: > On 06/25, Andreas Färber wrote: >> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol: >> >> drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No >> such file or directory >>#include

Re: [PATCH 1/5] clk: mb86s7x: Suppress build

2017-06-28 Thread Jassi Brar
On 28 June 2017 at 21:43, Stephen Boyd wrote: > On 06/25, Andreas Färber wrote: >> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol: >> >> drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No >> such file or directory >>#include >>

Re: [PATCH v5 0/4] USB Audio Gadget refactoring

2017-06-25 Thread Jassi Brar
; drivers/usb/gadget/legacy/audio.c | 55 +- > 15 files changed, 2494 insertions(+), 1348 deletions(-) > create mode 100644 Documentation/ABI/testing/configfs-usb-gadget-uac1_legacy > create mode 100644 drivers/usb/gadget/function/f_uac1_legacy.c > create mode 100644 drivers/usb/gadget/function/u_audio.c > create mode 100644 drivers/usb/gadget/function/u_audio.h > rename drivers/usb/gadget/function/{u_uac1.c => u_uac1_legacy.c} (98%) > create mode 100644 drivers/usb/gadget/function/u_uac1_legacy.h > Acked-by: Jassi Brar <jassisinghb...@gmail.com> Thanks.

Re: [PATCH v5 0/4] USB Audio Gadget refactoring

2017-06-25 Thread Jassi Brar
.c | 55 +- > 15 files changed, 2494 insertions(+), 1348 deletions(-) > create mode 100644 Documentation/ABI/testing/configfs-usb-gadget-uac1_legacy > create mode 100644 drivers/usb/gadget/function/f_uac1_legacy.c > create mode 100644 drivers/usb/gadget/function/u_audio.c > create mode 100644 drivers/usb/gadget/function/u_audio.h > rename drivers/usb/gadget/function/{u_uac1.c => u_uac1_legacy.c} (98%) > create mode 100644 drivers/usb/gadget/function/u_uac1_legacy.h > Acked-by: Jassi Brar Thanks.

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-06-02 Thread Jassi Brar
On Tue, May 30, 2017 at 5:13 AM, Ruslan Bilovol <ruslan.bilo...@gmail.com> wrote: > On Mon, May 22, 2017 at 6:58 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Thu, May 18, 2017 at 4:07 AM, Ruslan Bilovol >> <ruslan.bilo...@gmail.com> wrote: >>> Ab

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-06-02 Thread Jassi Brar
On Tue, May 30, 2017 at 5:13 AM, Ruslan Bilovol wrote: > On Mon, May 22, 2017 at 6:58 PM, Jassi Brar wrote: >> On Thu, May 18, 2017 at 4:07 AM, Ruslan Bilovol >> wrote: >>> Abstract the peripheral side ALSA sound card code from >>> the f_uac2 function in

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-06-01 Thread Jassi Brar
Hi Rob, On Wed, May 31, 2017 at 10:38 PM, Rob Herring wrote: > On Thu, May 25, 2017 at 02:23:44PM +0100, Sudeep Holla wrote: >> >> >> .../devicetree/bindings/mailbox/arm-mhu.txt| 46 >> >> -- >> >> 1 file changed, 43 insertions(+), 3 deletions(-) >>

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-06-01 Thread Jassi Brar
Hi Rob, On Wed, May 31, 2017 at 10:38 PM, Rob Herring wrote: > On Thu, May 25, 2017 at 02:23:44PM +0100, Sudeep Holla wrote: >> >> >> .../devicetree/bindings/mailbox/arm-mhu.txt| 46 >> >> -- >> >> 1 file changed, 43 insertions(+), 3 deletions(-) >> >> >> >> diff

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-05-31 Thread Jassi Brar
On Tue, May 30, 2017 at 9:59 PM, Alexey Klimov wrote: > > I was able to come up with new version with only HR-timer spinlock in timer > callback. That one seems a little bit better. > Yes, this is what I meant by simply using a lock. However the lock around the

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-05-31 Thread Jassi Brar
On Tue, May 30, 2017 at 9:59 PM, Alexey Klimov wrote: > > I was able to come up with new version with only HR-timer spinlock in timer > callback. That one seems a little bit better. > Yes, this is what I meant by simply using a lock. However the lock around the last_tx_done() for all channels

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 10:10 PM, Alexey Klimov <alexey.kli...@arm.com> wrote: > On Sun, Apr 23, 2017 at 03:33:39PM +0530, Jassi Brar wrote: > > Sorry for delay -- this is not my main activity so please be patient. > No problem. >> > >> > Along with this pat

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 10:10 PM, Alexey Klimov wrote: > On Sun, Apr 23, 2017 at 03:33:39PM +0530, Jassi Brar wrote: > > Sorry for delay -- this is not my main activity so please be patient. > No problem. >> > >> > Along with this patch you still need

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 7:23 PM, Sudeep Holla wrote: > Just propose the binding yourself. > My proposed binding is what already exists. Zero change. I offer to adapt your driver for you, if you are too busy to do it yourself.

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 7:23 PM, Sudeep Holla wrote: > Just propose the binding yourself. > My proposed binding is what already exists. Zero change. I offer to adapt your driver for you, if you are too busy to do it yourself.

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 7:05 PM, Sudeep Holla wrote: >>> 1. The client driver is generic and expects it to be doorbell like >>>mailbox controller. I am referring to SCMI which will be released >>>soon. We can't embed ARM MHU or any other mailbox controller info >>>

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 7:05 PM, Sudeep Holla wrote: >>> 1. The client driver is generic and expects it to be doorbell like >>>mailbox controller. I am referring to SCMI which will be released >>>soon. We can't embed ARM MHU or any other mailbox controller info >>>into that. >>> >> If

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-05-25 Thread Jassi Brar
> > Since the first version of this binding can't support doorbells, > this patch extends the existing binding to support them. > > Cc: Alexey Klimov <alexey.kli...@arm.com> > Cc: Jassi Brar <jaswinder.si...@linaro.org> > Cc: Rob Herring <robh...@kernel.org&

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-05-25 Thread Jassi Brar
rsion of this binding can't support doorbells, > this patch extends the existing binding to support them. > > Cc: Alexey Klimov > Cc: Jassi Brar > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed-off-by: Sudeep Holla > --- > .../devicetree/bindings/mailbox/

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 5:00 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 24/05/17 11:56, Jassi Brar wrote: >> On Wed, May 24, 2017 at 3:46 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >>> >>> Hi, >>> >>> This se

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-25 Thread Jassi Brar
On Thu, May 25, 2017 at 5:00 PM, Sudeep Holla wrote: > > > On 24/05/17 11:56, Jassi Brar wrote: >> On Wed, May 24, 2017 at 3:46 PM, Sudeep Holla wrote: >>> >>> Hi, >>> >>> This series adds doorbell support to ARM MHU mailbox controller driver.

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-24 Thread Jassi Brar
On Wed, May 24, 2017 at 3:46 PM, Sudeep Holla wrote: > > Hi, > > This series adds doorbell support to ARM MHU mailbox controller driver. > Since we need to callback the different client based on the doorbel bits > triggered from the remote, we can manage with single channel

Re: [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode

2017-05-24 Thread Jassi Brar
On Wed, May 24, 2017 at 3:46 PM, Sudeep Holla wrote: > > Hi, > > This series adds doorbell support to ARM MHU mailbox controller driver. > Since we need to callback the different client based on the doorbel bits > triggered from the remote, we can manage with single channel for the set > of 32

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-05-22 Thread Jassi Brar
On Thu, May 18, 2017 at 4:07 AM, Ruslan Bilovol wrote: > Abstract the peripheral side ALSA sound card code from > the f_uac2 function into a component that can be called > by various functions, so the various flavors can be split > apart and selectively reused. > >

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-05-22 Thread Jassi Brar
On Thu, May 18, 2017 at 4:07 AM, Ruslan Bilovol wrote: > Abstract the peripheral side ALSA sound card code from > the f_uac2 function into a component that can be called > by various functions, so the various flavors can be split > apart and selectively reused. > > Visible changes: > - add

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-16 Thread Jassi Brar
On Sat, May 13, 2017 at 4:18 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Wed 10 May 19:07 PDT 2017, Jassi Brar wrote: > >> On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson >> <bjorn.anders...@linaro.org> wrote: >> > On Tue 09 May 19:33 PDT

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-16 Thread Jassi Brar
On Sat, May 13, 2017 at 4:18 AM, Bjorn Andersson wrote: > On Wed 10 May 19:07 PDT 2017, Jassi Brar wrote: > >> On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson >> wrote: >> > On Tue 09 May 19:33 PDT 2017, Jassi Brar wrote: > [..] >> > So please let me know

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-10 Thread Jassi Brar
On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Tue 09 May 19:33 PDT 2017, Jassi Brar wrote: > >> On Wed, May 10, 2017 at 12:41 AM, Bjorn Andersson >> <bjorn.anders...@linaro.org> wrote: >> > On Tue

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-10 Thread Jassi Brar
On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson wrote: > On Tue 09 May 19:33 PDT 2017, Jassi Brar wrote: > >> On Wed, May 10, 2017 at 12:41 AM, Bjorn Andersson >> wrote: >> > On Tue 09 May 09:41 PDT 2017, Jassi Brar wrote: > [..] >> > The part wh

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-09 Thread Jassi Brar
On Wed, May 10, 2017 at 12:41 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Tue 09 May 09:41 PDT 2017, Jassi Brar wrote: >> >> >> >> The client should call mbox_client_txdone() after >> >> >> mbox_send_message(). >> >&g

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-09 Thread Jassi Brar
On Wed, May 10, 2017 at 12:41 AM, Bjorn Andersson wrote: > On Tue 09 May 09:41 PDT 2017, Jassi Brar wrote: >> >> >> >> The client should call mbox_client_txdone() after >> >> >> mbox_send_message(). >> >> > >> >> &g

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 12:41 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Sun 07 May 23:47 PDT 2017, Jassi Brar wrote: > >> On Mon, May 8, 2017 at 11:24 AM, Bjorn Andersson >> <bjorn.anders...@linaro.org> wrote: >> > On Fri

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 12:41 AM, Bjorn Andersson wrote: > On Sun 07 May 23:47 PDT 2017, Jassi Brar wrote: > >> On Mon, May 8, 2017 at 11:24 AM, Bjorn Andersson >> wrote: >> > On Fri 05 May 21:48 PDT 2017, Jassi Brar wrote: >> > >> > The APCS IPC regi

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 6:11 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > On 09/05/17 12:55, Jassi Brar wrote: >>>>>> >>>>>> If it is still not clear, please share your client driver. I >>>>>> will adapt that to work with exist

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 6:11 PM, Sudeep Holla wrote: > On 09/05/17 12:55, Jassi Brar wrote: >>>>>> >>>>>> If it is still not clear, please share your client driver. I >>>>>> will adapt that to work with existing MHU driver & bindings.

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 4:23 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 09/05/17 11:31, Jassi Brar wrote: >> On Tue, May 9, 2017 at 3:28 PM, Sudeep Holla <sudeep.ho...@arm.com> >> wrote: >> >>>> >>>> If it is stil

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 4:23 PM, Sudeep Holla wrote: > > > On 09/05/17 11:31, Jassi Brar wrote: >> On Tue, May 9, 2017 at 3:28 PM, Sudeep Holla >> wrote: >> >>>> >>>> If it is still not clear, please share your client driver. I >>>&

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 3:28 PM, Sudeep Holla wrote: >> >> If it is still not clear, please share your client driver. I will >> adapt that to work with existing MHU driver & bindings. >> > > Just take example of SCPI in the mainline. Assume there's another > protocol SCMI

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-09 Thread Jassi Brar
On Tue, May 9, 2017 at 3:28 PM, Sudeep Holla wrote: >> >> If it is still not clear, please share your client driver. I will >> adapt that to work with existing MHU driver & bindings. >> > > Just take example of SCPI in the mainline. Assume there's another > protocol SCMI which uses few more bits

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-08 Thread Jassi Brar
On Mon, May 8, 2017 at 10:37 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 08/05/17 17:46, Jassi Brar wrote: >> On Mon, May 8, 2017 at 9:40 PM, Rob Herring <r...@kernel.org> wrote: >>> +Bjorn >>> >>> On Tue, May 02, 2017 at 02:5

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-08 Thread Jassi Brar
On Mon, May 8, 2017 at 10:37 PM, Sudeep Holla wrote: > > > On 08/05/17 17:46, Jassi Brar wrote: >> On Mon, May 8, 2017 at 9:40 PM, Rob Herring wrote: >>> +Bjorn >>> >>> On Tue, May 02, 2017 at 02:55:49PM +0100, Sudeep Holla wrote: >>>>

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-08 Thread Jassi Brar
can contribute to raising the >> interrupt thereby allowing it to be used as independent subchannels. >> >> Since the first version of this binding can't support sub-channels, >> this patch extends the existing binding to support them. >> >> Cc: Alexey Klimov &l

Re: [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels

2017-05-08 Thread Jassi Brar
to raising the >> interrupt thereby allowing it to be used as independent subchannels. >> >> Since the first version of this binding can't support sub-channels, >> this patch extends the existing binding to support them. >> >> Cc: Alexey Klimov >> Cc: Jassi Bra

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-08 Thread Jassi Brar
On Mon, May 8, 2017 at 11:24 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Fri 05 May 21:48 PDT 2017, Jassi Brar wrote: > > The APCS IPC register serves the basis for all inter-processor > communication in a Qualcomm platform, so it's not only the RPM driver &

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-08 Thread Jassi Brar
On Mon, May 8, 2017 at 11:24 AM, Bjorn Andersson wrote: > On Fri 05 May 21:48 PDT 2017, Jassi Brar wrote: > > The APCS IPC register serves the basis for all inter-processor > communication in a Qualcomm platform, so it's not only the RPM driver > discussed earlier that uses this.

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 6:49 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Fri 05 May 13:22 PDT 2017, Jassi Brar wrote: >> How is it supposed to work if a client queues more than one request? > > One such example is found in patch 5 in this series. There are

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 6:49 AM, Bjorn Andersson wrote: > On Fri 05 May 13:22 PDT 2017, Jassi Brar wrote: >> How is it supposed to work if a client queues more than one request? > > One such example is found in patch 5 in this series. There are two FIFOs > in shared memory, one

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 1:23 AM, Jeffrey Hugo <jh...@codeaurora.org> wrote: > On 5/5/2017 1:22 PM, Jassi Brar wrote: >> >> On Sat, May 6, 2017 at 12:07 AM, Bjorn Andersson >> <bjorn.anders...@linaro.org> wrote: >>> > > There is no way to determin

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 1:23 AM, Jeffrey Hugo wrote: > On 5/5/2017 1:22 PM, Jassi Brar wrote: >> >> On Sat, May 6, 2017 at 12:07 AM, Bjorn Andersson >> wrote: >>> > > There is no way to determine if the remote processor has observed a message, > th

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 12:07 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Fri 05 May 03:26 PDT 2017, Jassi Brar wrote: > >> On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson >> <bjorn.anders...@linaro.org> wrote: >> >> > + >> >

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Sat, May 6, 2017 at 12:07 AM, Bjorn Andersson wrote: > On Fri 05 May 03:26 PDT 2017, Jassi Brar wrote: > >> On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson >> wrote: >> >> > + >> > +static int qcom_apcs_ipc_send_data(struct mbox_chan *cha

Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels

2017-05-05 Thread Jassi Brar
On Wed, May 3, 2017 at 2:51 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > > On 03/05/17 04:17, Jassi Brar wrote: >> Hi Sudeep, >> >> On Tue, May 2, 2017 at 7:25 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >>> Hi Jassi, >>> &

Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels

2017-05-05 Thread Jassi Brar
On Wed, May 3, 2017 at 2:51 PM, Sudeep Holla wrote: > > > On 03/05/17 04:17, Jassi Brar wrote: >> Hi Sudeep, >> >> On Tue, May 2, 2017 at 7:25 PM, Sudeep Holla wrote: >>> Hi Jassi, >>> >>> This series adds subchannel support to ARM MHU mailb

Re: [PATCH v4 1/5] mailbox: Make startup and shutdown ops optional

2017-05-05 Thread Jassi Brar
On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson wrote: > Some mailbox hardware doesn't have to perform any additional operations > on startup of shutdown, so make these optional. > Thanks, makes sense. > diff --git a/drivers/mailbox/mailbox.c

Re: [PATCH v4 1/5] mailbox: Make startup and shutdown ops optional

2017-05-05 Thread Jassi Brar
On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson wrote: > Some mailbox hardware doesn't have to perform any additional operations > on startup of shutdown, so make these optional. > Thanks, makes sense. > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c > index

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson wrote: > + > +static int qcom_apcs_ipc_send_data(struct mbox_chan *chan, void *data) > +{ > + struct qcom_apcs_ipc *apcs = container_of(chan->mbox, > + struct

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-05 Thread Jassi Brar
On Fri, May 5, 2017 at 1:35 AM, Bjorn Andersson wrote: > + > +static int qcom_apcs_ipc_send_data(struct mbox_chan *chan, void *data) > +{ > + struct qcom_apcs_ipc *apcs = container_of(chan->mbox, > + struct qcom_apcs_ipc, mbox); > +

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-04 Thread Jassi Brar
On Thu, May 4, 2017 at 9:40 PM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Thu 04 May 00:54 PDT 2017, Jassi Brar wrote: > >> On Thu, May 4, 2017 at 11:15 AM, Bjorn Andersson >> <bjorn.anders...@linaro.org> wrote: >> > On Wed 03 May 02:55 PDT

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-04 Thread Jassi Brar
On Thu, May 4, 2017 at 9:40 PM, Bjorn Andersson wrote: > On Thu 04 May 00:54 PDT 2017, Jassi Brar wrote: > >> On Thu, May 4, 2017 at 11:15 AM, Bjorn Andersson >> wrote: >> > On Wed 03 May 02:55 PDT 2017, Jassi Brar wrote: >> > >> >> Loic, thank

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-04 Thread Jassi Brar
On Thu, May 4, 2017 at 11:15 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Wed 03 May 02:55 PDT 2017, Jassi Brar wrote: > >> Loic, thanks for adding me. >> >> On Wed, May 3, 2017 at 2:58 PM, Loic PALLARDY <loic.palla...@st.com> wrote: &

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-04 Thread Jassi Brar
On Thu, May 4, 2017 at 11:15 AM, Bjorn Andersson wrote: > On Wed 03 May 02:55 PDT 2017, Jassi Brar wrote: > >> Loic, thanks for adding me. >> >> On Wed, May 3, 2017 at 2:58 PM, Loic PALLARDY wrote: >> > >> > >> >> -Original Message--

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-03 Thread Jassi Brar
Loic, thanks for adding me. On Wed, May 3, 2017 at 2:58 PM, Loic PALLARDY wrote: > > >> -Original Message- >> From: linux-remoteproc-ow...@vger.kernel.org [mailto:linux-remoteproc- >> ow...@vger.kernel.org] On Behalf Of Bjorn Andersson >> Sent: Wednesday, May 03,

Re: [PATCH v3 2/4] soc: qcom: Introduce APCS IPC driver

2017-05-03 Thread Jassi Brar
Loic, thanks for adding me. On Wed, May 3, 2017 at 2:58 PM, Loic PALLARDY wrote: > > >> -Original Message- >> From: linux-remoteproc-ow...@vger.kernel.org [mailto:linux-remoteproc- >> ow...@vger.kernel.org] On Behalf Of Bjorn Andersson >> Sent: Wednesday, May 03, 2017 7:29 AM >> To: Andy

Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels

2017-05-02 Thread Jassi Brar
Hi Sudeep, On Tue, May 2, 2017 at 7:25 PM, Sudeep Holla wrote: > Hi Jassi, > > This series adds subchannel support to ARM MHU mailbox controller > driver. Since SCPI never used second slot, we were able to use the > existing driver as is. However, that's changing soon and

Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels

2017-05-02 Thread Jassi Brar
Hi Sudeep, On Tue, May 2, 2017 at 7:25 PM, Sudeep Holla wrote: > Hi Jassi, > > This series adds subchannel support to ARM MHU mailbox controller > driver. Since SCPI never used second slot, we were able to use the > existing driver as is. However, that's changing soon and the new > SCMI protocol

[GIT PULL] Mailbox changes for v4.12

2017-05-01 Thread Jassi Brar
Hi Linus, The following changes since commit ad0376eb1483bd9880770b346f6592aece669e4c: Merge tag 'edac_for_4.11_2' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp (2017-03-27 11:09:00 -0700) are available in the git repository at:

[GIT PULL] Mailbox changes for v4.12

2017-05-01 Thread Jassi Brar
Hi Linus, The following changes since commit ad0376eb1483bd9880770b346f6592aece669e4c: Merge tag 'edac_for_4.11_2' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp (2017-03-27 11:09:00 -0700) are available in the git repository at:

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-23 Thread Jassi Brar
On Tue, Apr 11, 2017 at 6:15 PM, Alexey Klimov <alexey.kli...@arm.com> wrote: > On Thu, Apr 06, 2017 at 10:45:26PM +0530, Jassi Brar wrote: >> On 6 April 2017 at 22:28, Alexey Klimov <alexey.kli...@arm.com> wrote: >> > Hi Jassi/Sudeep, >> > >> >

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-23 Thread Jassi Brar
On Tue, Apr 11, 2017 at 6:15 PM, Alexey Klimov wrote: > On Thu, Apr 06, 2017 at 10:45:26PM +0530, Jassi Brar wrote: >> On 6 April 2017 at 22:28, Alexey Klimov wrote: >> > Hi Jassi/Sudeep, >> > >> > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep Holla wrote:

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-04-11 Thread Jassi Brar
On 11 April 2017 at 18:04, Alexey Klimov <alexey.kli...@arm.com> wrote: > On Fri, Apr 07, 2017 at 08:39:35PM +0530, Jassi Brar wrote: >> On Thu, Apr 6, 2017 at 11:01 PM, Alexey Klimov <alexey.kli...@arm.com> wrote: >> > When mailbox controller

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-04-11 Thread Jassi Brar
On 11 April 2017 at 18:04, Alexey Klimov wrote: > On Fri, Apr 07, 2017 at 08:39:35PM +0530, Jassi Brar wrote: >> On Thu, Apr 6, 2017 at 11:01 PM, Alexey Klimov wrote: >> > When mailbox controller provides two or more channels and >> > they are actively used by mailb

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-04-07 Thread Jassi Brar
On Thu, Apr 6, 2017 at 11:01 PM, Alexey Klimov wrote: > When mailbox controller provides two or more channels and > they are actively used by mailbox client(s) it's very easy > to trigger the warning in hrtimer_forward(): > > [ 247.853060] WARNING: CPU: 6 PID: 0 at

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-04-07 Thread Jassi Brar
On Thu, Apr 6, 2017 at 11:01 PM, Alexey Klimov wrote: > When mailbox controller provides two or more channels and > they are actively used by mailbox client(s) it's very easy > to trigger the warning in hrtimer_forward(): > > [ 247.853060] WARNING: CPU: 6 PID: 0 at kernel/time/hrtimer.c:805 >

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-06 Thread Jassi Brar
On 6 April 2017 at 22:28, Alexey Klimov <alexey.kli...@arm.com> wrote: > Hi Jassi/Sudeep, > > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep Holla wrote: >> >> >> On 29/03/17 18:43, Jassi Brar wrote: ... >> > diff --git a/drivers/mailbox/mailbox.c b/dr

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-06 Thread Jassi Brar
On 6 April 2017 at 22:28, Alexey Klimov wrote: > Hi Jassi/Sudeep, > > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep Holla wrote: >> >> >> On 29/03/17 18:43, Jassi Brar wrote: ... >> > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode

2017-03-29 Thread Jassi Brar
On Wed, Mar 29, 2017 at 5:04 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: > > On 28/03/17 19:20, Jassi Brar wrote: >> Hi Sudeep, >> >> On Tue, Mar 21, 2017 at 5:00 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote: >>> There exists a race when msg_submit

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode

2017-03-29 Thread Jassi Brar
On Wed, Mar 29, 2017 at 5:04 PM, Sudeep Holla wrote: > > On 28/03/17 19:20, Jassi Brar wrote: >> Hi Sudeep, >> >> On Tue, Mar 21, 2017 at 5:00 PM, Sudeep Holla wrote: >>> There exists a race when msg_submit return immediately as there was an >>> act

[PATCH] mailbox: fix completion order for blocking requests

2017-03-29 Thread Jassi Brar
res to each queued request, so that the threads could wait on their own completions. Reported-by: Alexey Klimov <alexey.kli...@arm.com> Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org> --- drivers/mailbox/mailbox.c | 15 +++ drivers/mailbox/omap-mai

[PATCH] mailbox: fix completion order for blocking requests

2017-03-29 Thread Jassi Brar
res to each queued request, so that the threads could wait on their own completions. Reported-by: Alexey Klimov Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 15 +++ drivers/mailbox/omap-mailbox.c | 2 +- drivers/mailbox/pcc.c | 2 +- include/li

Re: [PATCH v7 0/3] Broadcom FlexRM ring manager support

2017-03-28 Thread Jassi Brar
On Wed, Mar 29, 2017 at 11:00 AM, Anup Patel wrote: > The Broadcom FlexRM ring manager provides producer-consumer style > ring interface for offload engines on Broadcom iProc SoCs. We can > have one or more instances of Broadcom FlexRM ring manager in a SoC. > > This

Re: [PATCH v7 0/3] Broadcom FlexRM ring manager support

2017-03-28 Thread Jassi Brar
On Wed, Mar 29, 2017 at 11:00 AM, Anup Patel wrote: > The Broadcom FlexRM ring manager provides producer-consumer style > ring interface for offload engines on Broadcom iProc SoCs. We can > have one or more instances of Broadcom FlexRM ring manager in a SoC. > > This patchset adds a mailbox

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode

2017-03-28 Thread Jassi Brar
his will result in return to the > caller without waiting in mbox_send_message even when it's blocking Tx. > > This patch fixes the issue by waiting for the completion always if Tx > is in blocking mode. > > Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode

2017-03-28 Thread Jassi Brar
> caller without waiting in mbox_send_message even when it's blocking Tx. > > This patch fixes the issue by waiting for the completion always if Tx > is in blocking mode. > > Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") > Cc: Jassi Brar > Reported

Re: [PATCH v5 1/2] mailbox: Add driver for Broadcom FlexRM ring manager

2017-03-14 Thread Jassi Brar
On Mon, Mar 6, 2017 at 10:40 AM, Anup Patel wrote: > Some of the Broadcom iProc SoCs have FlexRM ring manager > which provides a ring-based programming interface to various > offload engines (e.g. RAID, Crypto, etc). > > This patch adds a common mailbox driver for

Re: [PATCH v5 1/2] mailbox: Add driver for Broadcom FlexRM ring manager

2017-03-14 Thread Jassi Brar
On Mon, Mar 6, 2017 at 10:40 AM, Anup Patel wrote: > Some of the Broadcom iProc SoCs have FlexRM ring manager > which provides a ring-based programming interface to various > offload engines (e.g. RAID, Crypto, etc). > > This patch adds a common mailbox driver for Broadcom FlexRM > ring manager

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-02-22 Thread Jassi Brar
On Wed, Feb 22, 2017 at 8:42 AM, Horng-Shyang Liao <hs.l...@mediatek.com> wrote: > On Thu, 2017-02-16 at 21:02 +0530, Jassi Brar wrote: >> On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao <hs.l...@mediatek.com> >> wrote: >> > Hi Jassi, >> > >&

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-02-22 Thread Jassi Brar
On Wed, Feb 22, 2017 at 8:42 AM, Horng-Shyang Liao wrote: > On Thu, 2017-02-16 at 21:02 +0530, Jassi Brar wrote: >> On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao >> wrote: >> > Hi Jassi, >> > >> > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wr

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-02-16 Thread Jassi Brar
On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao <hs.l...@mediatek.com> wrote: > Hi Jassi, > > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: >> On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao <hs.l...@mediatek.com> >> wrote: >> > Hi Jassi, &

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-02-16 Thread Jassi Brar
On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao wrote: > Hi Jassi, > > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: >> On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao >> wrote: >> > Hi Jassi, >> > >> > On Thu, 2017-01-26 at 10:08 +0

Re: [PATCH 1/6] mailbox: Add new API mbox_channel_device() for clients

2017-02-03 Thread Jassi Brar
On Thu, Feb 2, 2017 at 10:17 AM, Anup Patel wrote: > The remote processor can have DMAENGINE capabilities and client > can pass data to be processed via main memory. In such cases, > the client will require DMAble memory for remote processor. > > This patch adds new API

Re: [PATCH 1/6] mailbox: Add new API mbox_channel_device() for clients

2017-02-03 Thread Jassi Brar
On Thu, Feb 2, 2017 at 10:17 AM, Anup Patel wrote: > The remote processor can have DMAENGINE capabilities and client > can pass data to be processed via main memory. In such cases, > the client will require DMAble memory for remote processor. > > This patch adds new API mbox_channel_device()

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-01-31 Thread Jassi Brar
On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao <hs.l...@mediatek.com> wrote: > Hi Jassi, > > On Thu, 2017-01-26 at 10:08 +0530, Jassi Brar wrote: >> On Wed, Jan 4, 2017 at 8:36 AM, HS Liao <hs.l...@mediatek.com> wrote: >> >> > diff --git a/drivers/

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-01-31 Thread Jassi Brar
On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao wrote: > Hi Jassi, > > On Thu, 2017-01-26 at 10:08 +0530, Jassi Brar wrote: >> On Wed, Jan 4, 2017 at 8:36 AM, HS Liao wrote: >> >> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c >> > b/drivers/mailbo

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-01-25 Thread Jassi Brar
On Wed, Jan 4, 2017 at 8:36 AM, HS Liao wrote: > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > b/drivers/mailbox/mtk-cmdq-mailbox.c > new file mode 100644 > index 000..747bcd3 > --- /dev/null > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c ... > +static void

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2017-01-25 Thread Jassi Brar
On Wed, Jan 4, 2017 at 8:36 AM, HS Liao wrote: > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > b/drivers/mailbox/mtk-cmdq-mailbox.c > new file mode 100644 > index 000..747bcd3 > --- /dev/null > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c ... > +static void cmdq_task_exec(struct cmdq_pkt

<    1   2   3   4   5   6   7   8   9   10   >