Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
Signed-off-by: Je Yen Tam
---
v6 -> v7
- Fix sender full name.
v5 -> v6
- Fix author full name.
v4 -> v5
- Remove blank lines between variable definitions.
- Remove trace_printk().
v3 -> v4:
- Add changes
> Subject: [EXTERNAL] Re: [PATCH v6] serial/8250: Add support for NI-Serial
> PXI/PXIe+485 devices
>
> On Fri, Jul 26, 2019 at 03:22:26PM +0800, jeyentam wrote:
> > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
> >
> > Signed-off-by: Je Y
> Subject: [EXTERNAL] Re: [PATCH v5] serial/8250: Add support for NI-Serial
> PXI/PXIe+485 devices
>
> On Fri, Jul 26, 2019 at 10:40:46AM +0800, jeyentam wrote:
> > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
> >
> > Signed-off-by: jeyentam
>
> You messed up the
> Subject: [EXTERNAL] Re: [PATCH v4] serial/8250: Add support for NI-Serial
> PXI/PXIe+485 devices
>
> On Fri, Jul 05, 2019 at 06:15:28AM -0700, jeyentam wrote:
> > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
> >
> > Signed-off-by: Je
> On Fri, Jul 05, 2019 at 01:33:49AM -0700, jeyentam wrote:
> > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
> >
> > Signed-off-by: Je Yen Tam
> > ---
> > drivers/tty/serial/8250/8250_pci.c | 298 -
> >
> -Original Message-
> From: Greg KH
> Sent: Thursday, July 4, 2019 4:15 PM
> To: Je Yen Tam
> Cc: linux-ser...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXTERNAL] Re: Re: [PATCH V2 1/2] serial/8250: Add support for
> NI-Serial
> PXI/PXIe+485
> -Original Message-
> From: Greg KH
> Sent: Thursday, July 4, 2019 4:16 PM
> To: Je Yen Tam
> Cc: linux-ser...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXTERNAL] Re: Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485
> device
> IDs
>
>
> On Mon, Jul 01, 2019 at 08:23:23PM -0700, jeyentam wrote:
> > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
> >
> > Signed-off-by: jeyentam
> > ---
> > drivers/tty/serial/8250/8250_pci.c | 879 +++--
> > 1 file changed, 582 insertions(+), 297
/* No Echo */
> > + dev_vdbg(port->dev, "2-wire DTR no echo\n");
> > + pcr |= NI16550_PCR_DTR_RS485;
> > + acr |= NI16550_ACR_DTR_MANUAL_DTR;
> > + }
> > + }
> > + } else {
> > + /* RS-422 */
> > + dev_vdbg(port->dev, "4-wire\n");
> > + pcr |= NI16550_PCR_RS422;
> > + acr |= NI16550_ACR_DTR_MANUAL_DTR;
> > + }
> > +
> > + dev_dbg(port->dev, "write pcr: 0x%08x\n", pcr);
> > + port->serial_out(port, NI16550_PCR_OFFSET, pcr);
> > +
> > + up->acr = acr;
> > + port->serial_out(port, UART_SCR, UART_ACR);
> > + port->serial_out(port, UART_ICR, up->acr);
> > +
> > + /* Update the cache. */
> > + port->rs485 = *rs485;
> > +
> > + dev_dbg(port->dev, "ni16550_config_rs485\n");
>
> Again, use ftrace, not dev_dbg() for stuff like this.
Will do so.
>
> thanks,
>
> greg k-h
Thank you.
Regards,
Je Yen Tam
Staff Software Engineer
National Instruments
o 604-3776397
e je.yen@ni.com
> Subject: [EXTERNAL] [priv] Re: [PATCH 1/2] serial/8250: Add support for
> NI-Serial
> PXI/PXIe+485 devices.
>
> On 02.07.19 05:23, jeyentam wrote:
>
> Hi,
>
> better writing to you personally, off-list.
>
> > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices.
> >
> >
ci_ids.h
> > @@ -1027,7 +1027,9 @@
> > #define PCI_DEVICE_ID_SUN_TOMATILLO0xa801
> > #define PCI_DEVICE_ID_SUN_CASSINI 0xabba
> >
> > +/* NI-Serial Device IDs */
> > #define PCI_VENDOR_ID_NI 0x1093
>
> That's a vendor id, not a serial devi
11 matches
Mail list logo
