Re: [PATCH] w1: ds2408: Fix typo after 49695ac46861 (reset on output_write retry with readback)

Yikes! Human after all... > On May 16, 2019, at 08:01, Mariusz Bialonczyk wrote: > > Fix a typo in commit: > 49695ac46861 w1: ds2408: reset on output_write retry with readback > > Reported-by: Phil Elwell > Cc: Jean-Francois Dagenais > Signed-off-by: Mariusz Bialon

[PATCH v4] w1: ds2408: reset on output_write retry with readback

(runtime and compile-time) noise. Reported-by: Mariusz Bialonczyk Tested-by: Mariusz Bialonczyk Signed-off-by: Jean-Francois Dagenais --- Changes in v1: - Original Mariusz series submission called [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output_write

[PATCH v3] w1: ds2408: reset on output_write retry with readback

(runtime and compile-time) noise. Reported-by: Mariusz Bialonczyk Tested-by: Mariusz Bialonczyk Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/w1_ds2408.c | 76 ++- 1 file changed, 39 insertions(+), 37 deletions(-) diff --git a/drivers/w1/slaves

Re: [PATCH v2] w1: ds2408: reset on output_write retry with readback

** resending to list only because of bounce ** Hi Greg, > On Mar 27, 2019, at 12:53, Greg Kroah-Hartman wrote: > > On Thu, Mar 21, 2019 at 11:18:27AM -0400, Jean-Francois Dagenais wrote: >> Originally >> Reported-by: Mariusz Bialonczyk > > That needs to go dow

[PATCH v2] w1: ds2408: reset on output_write retry with readback

, we vastly reduce the visual and branching(runtime and compile-time) noise. Tested-by: Mariusz Bialonczyk Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/w1_ds2408.c | 76 ++- 1 file changed, 39 insertions(+), 37 deletions(-) diff --git

Re: [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output_write()

> On Mar 19, 2019, at 10:21, Jean-Francois Dagenais > wrote: > > I can do a proper patch submission if you guys provide positive response on > this > early RFC. Or better yet, you can take it and own it yourself as your v2 > Mariusz. ;) Just FYI, here's what the retry

Re: [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output_write()

f-by: Mariusz Bialonczyk > Cc: Jean-Francois Dagenais > --- > drivers/w1/slaves/w1_ds2408.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c > index b535d5ec35b6..562ee2d861e8 100

Re: [PATCH 2/2] w1: fix the resume command API

y and the > device is responding with failing results after the Resume Command. > > This commit is fixing this by using a Skip ROM instead in those cases. > The bandwidth / performance advantage is exactly the same. > > Refs: > [1] https://datasheets.maximintegrated.com/en/ds

Re: [PATCH 1/3] spi: spi-xilinx: Remove ISR race condition

> On Jun 4, 2013, at 1:32 PM, Mark Brown wrote: > > Applied but this is a bit sad, having to defer the refill to process > context means that we're adding extra latency which takes us further > away from being able to saturate the bus. There ought to be a way to > avoid the issue though I

Re: [PATCH 1/3] spi: spi-xilinx: Remove ISR race condition

> On Jun 4, 2013, at 1:32 PM, Mark Brown wrote: > > Applied but this is a bit sad, having to defer the refill to process > context means that we're adding extra latency which takes us further > away from being able to saturate the bus. There ought to be a way to > avoid the

at24 eeprom bind doesn't stimulate udev

Hi all, Here's a shot in the dark, since I don't know where to start digging In a yocto (1.4, kernel 3.4.52), I designed a bunch of udev rules to set some permissions for some sysfs attributes, namely /sys/class/gpio/*/value and /sys/bus/i2c/devices/0-00xx/eeprom. I match the sysfs attributes

at24 eeprom bind doesn't stimulate udev

Hi all, Here's a shot in the dark, since I don't know where to start digging In a yocto (1.4, kernel 3.4.52), I designed a bunch of udev rules to set some permissions for some sysfs attributes, namely /sys/class/gpio/*/value and /sys/bus/i2c/devices/0-00xx/eeprom. I match the sysfs attributes

[PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

. This precaution is recommended in parasite power mode (VCC pin connected to GND) as well as with VCC power. Disable Test Mode: RST,PD,96h,<64-bit DS2408 ROM Code>,3Ch,RST,PD Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/w1_ds2408.c | 29 + 1 file chang

[PATCH] w1: ds2408: add magic sequence to disable P0 test mode

in parasite power mode (VCC pin connected to GND) as well as with VCC power. Disable Test Mode: RST,PD,96h,<64-bit DS2408 ROM Code>,3Ch,RST,PD Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/w1_ds2408.c | 34 +- 1 file changed, 33 insertions

Fix ds2408 P0 output not working after power-on

This issue is described in the v2 datasheet of ds2408 (see commit message). On our board (9 ds2408 and 2 ds2433 on a ds1wm mastered bus), the problem affects only 2 out of 9 chips 2408 and only after a long power off. Adding the magic sequence described in the datasheet fixes the issue as

[PATCH] w1: ds2408: add magic sequence to disable P0 test mode

in parasite power mode (VCC pin connected to GND) as well as with VCC power. Disable Test Mode: RST,PD,96h,64-bit DS2408 ROM Code,3Ch,RST,PD Signed-off-by: Jean-Francois Dagenais jeff.dagen...@gmail.com --- drivers/w1/slaves/w1_ds2408.c | 34 +- 1 file changed, 33

[PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

. This precaution is recommended in parasite power mode (VCC pin connected to GND) as well as with VCC power. Disable Test Mode: RST,PD,96h,64-bit DS2408 ROM Code,3Ch,RST,PD Signed-off-by: Jean-Francois Dagenais jeff.dagen...@gmail.com --- drivers/w1/slaves/w1_ds2408.c | 29

[PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

De-activating this reading back will effectively half the time required for a write to the output register. Acked-by: Evgeniy Polyakov Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/Kconfig | 10 ++ drivers/w1/slaves/w1_ds2408.c | 18 -- 2 files changed

[PATCH 2/2] w1: ds2408: use ARRAY_SIZE instead of hard-coded number

Acked-by: Evgeniy Polyakov Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/w1_ds2408.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c index 25a5168..e45eca1 100644 --- a/drivers/w1/slaves

[PATCH 2/2] w1: ds2408: use ARRAY_SIZE instead of hard-coded number

Acked-by: Evgeniy Polyakov z...@ioremap.net Signed-off-by: Jean-Francois Dagenais jeff.dagen...@gmail.com --- drivers/w1/slaves/w1_ds2408.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c index 25a5168

[PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

De-activating this reading back will effectively half the time required for a write to the output register. Acked-by: Evgeniy Polyakov z...@ioremap.net Signed-off-by: Jean-Francois Dagenais jeff.dagen...@gmail.com --- drivers/w1/slaves/Kconfig | 10 ++ drivers/w1/slaves/w1_ds2408.c

[PATCH 2/2] w1: ds2408: use ARRAY_SIZE instead of hard-coded number

Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/w1_ds2408.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c index 25a5168..e45eca1 100644 --- a/drivers/w1/slaves/w1_ds2408.c +++ b/drivers/w1

[PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

De-activating this reading back will effectively half the time required for a write to the output register. Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/Kconfig | 10 ++ drivers/w1/slaves/w1_ds2408.c | 18 -- 2 files changed, 22 insertions(+), 6

Re: w1_ds2408 linux driver

On 2013-02-19, at 9:44 AM, Olivier KSIKES wrote: > Dear Mr Dagenais, > > I have just tried your w1-ds2408 linux driver on a TP link mini router > running openwrt with w1-gpio. I was able to successfully update a 2408 > outputs by writing a byte to the /output file. > However, I would like to

Re: w1_ds2408 linux driver

On 2013-02-19, at 9:44 AM, Olivier KSIKES wrote: Dear Mr Dagenais, I have just tried your w1-ds2408 linux driver on a TP link mini router running openwrt with w1-gpio. I was able to successfully update a 2408 outputs by writing a byte to the /output file. However, I would like to drive

[PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

De-activating this reading back will effectively half the time required for a write to the output register. Signed-off-by: Jean-Francois Dagenais jeff.dagen...@gmail.com --- drivers/w1/slaves/Kconfig | 10 ++ drivers/w1/slaves/w1_ds2408.c | 18 -- 2 files changed, 22

[PATCH 2/2] w1: ds2408: use ARRAY_SIZE instead of hard-coded number

Signed-off-by: Jean-Francois Dagenais jeff.dagen...@gmail.com --- drivers/w1/slaves/w1_ds2408.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c index 25a5168..e45eca1 100644 --- a/drivers/w1/slaves/w1_ds2408

Re: w1_ds2408 linux driver

Hi Olivier, I'm forwarding this to Evgeniy and the linux-kernel mailing list as this thread may have historical value. On 2013-02-19, at 9:44 AM, Olivier KSIKES wrote: > Dear Mr Dagenais, > > I have just tried your w1-ds2408 linux driver on a TP link mini router > running openwrt with

Re: w1_ds2408 linux driver

Hi Olivier, I'm forwarding this to Evgeniy and the linux-kernel mailing list as this thread may have historical value. On 2013-02-19, at 9:44 AM, Olivier KSIKES wrote: Dear Mr Dagenais, I have just tried your w1-ds2408 linux driver on a TP link mini router running openwrt with w1-gpio. I