Re: [PATCH] i2c: taos-evm: replace simple_strtoul by kstrtou8

2015-11-05 Thread Jean Delvare
return err; While in general I am in favor of passing error values down the stack, here I'm not sure. kstrtou8 could return -ERANGE or -EINVAL which makes no sense as an i2c adapter fault code. According to Documentation/i2c/fault-codes, -EPROTO or -EIO would be more appropriate. >

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-21 Thread Jean Delvare
ophy, I guess. > > Err, sorry. Could you please point out the other possibility? Both possibilities came from you. First one is to use "depends", second one is to use "select". As pointed out bu Gunter, other drivers (EDAC_DECODE_MCE, MICROCODE, AMD_NB) use "d

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-21 Thread Jean Delvare
ophy, I guess. > > Err, sorry. Could you please point out the other possibility? Both possibilities came from you. First one is to use "depends", second one is to use "select". As pointed out bu Gunter, other drivers (EDAC_DECODE_MCE, MICROCODE, AMD_NB) use "d

Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST

2015-10-13 Thread Jean Delvare
ends on GOLDFISH > + depends on GOLDFISH || COMPILE_TEST > help > This selects the Goldfish Multimedia card Interface emulation > found on the Goldfish Android virtual device emulation. Looks good. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support -- To unsubscr

Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST

2015-10-13 Thread Jean Delvare
uot; > - depends on GOLDFISH > + depends on GOLDFISH || COMPILE_TEST > help > This selects the Goldfish Multimedia card Interface emulation > found on the Goldfish Android virtual device emulation. Looks good. Reviewed-by: Jean Delvare <jdelv

Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-28 Thread Jean Delvare
On Sun, 27 Sep 2015 19:58:11 +0200, Denys Vlasenko wrote: > On 09/27/2015 06:10 PM, Jean Delvare wrote: > > Looks good, however I think you should #include to > > avoid build failures in the future or on certain architectures. > > already includes > on any arch. Toda

Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-28 Thread Jean Delvare
On Sun, 27 Sep 2015 19:58:11 +0200, Denys Vlasenko wrote: > On 09/27/2015 06:10 PM, Jean Delvare wrote: > > Looks good, however I think you should #include to > > avoid build failures in the future or on certain architectures. > > already includes > on any arch. Toda

Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-27 Thread Jean Delvare
s Vlasenko > CC: Viresh Kumar > CC: Rafael J. Wysocki > CC: Ingo Molnar > CC: Bartosz Golaszewski > CC: H. Peter Anvin > CC: Benoit Cousson > CC: Fenghua Yu > CC: Guenter Roeck > CC: Jean Delvare > CC: Jonathan Corbet > CC: Peter Zijlstra > C

Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-27 Thread Jean Delvare
> > CC: Benoit Cousson <bcous...@baylibre.com> > CC: Fenghua Yu <fenghua...@intel.com> > CC: Guenter Roeck <li...@roeck-us.net> > CC: Jean Delvare <jdelv...@suse.de> > CC: Jonathan Corbet <cor...@lwn.net> > CC: Peter Zijlstra <pet...@infradead.org>

Re: randconfig build error with next-20150812, in drivers/i2c/busses/i2c-i801.c

2015-09-25 Thread Jean Delvare
Le Friday 25 September 2015 à 14:37 +0100, Matt Fleming a écrit : > On Fri, 25 Sep, at 09:36:10AM, Jean Delvare wrote: > > On Wed, 12 Aug 2015 08:42:18 -0700, Jim Davis wrote: > > > Building with the attached random configuration file, > > > > >

Re: randconfig build error with next-20150812, in drivers/i2c/busses/i2c-i801.c

2015-09-25 Thread Jean Delvare
r the late reply. The error is caused by the following combination of options: CONFIG_I2C=m CONFIG_I2C_I801=y I can reproduce it even with mainline now. This is caused by CONFIG_ITCO_WDT=y, which selects CONFIG_I2C_I801=y without selecting its dependencies (CONFIG_I2C.) Thanks for reporting, I'll po

Re: randconfig build error with next-20150812, in drivers/i2c/busses/i2c-i801.c

2015-09-25 Thread Jean Delvare
r the late reply. The error is caused by the following combination of options: CONFIG_I2C=m CONFIG_I2C_I801=y I can reproduce it even with mainline now. This is caused by CONFIG_ITCO_WDT=y, which selects CONFIG_I2C_I801=y without selecting its dependencies (CONFIG_I2C.) Thanks for reporting, I'll po

Re: randconfig build error with next-20150812, in drivers/i2c/busses/i2c-i801.c

2015-09-25 Thread Jean Delvare
Le Friday 25 September 2015 à 14:37 +0100, Matt Fleming a écrit : > On Fri, 25 Sep, at 09:36:10AM, Jean Delvare wrote: > > On Wed, 12 Aug 2015 08:42:18 -0700, Jim Davis wrote: > > > Building with the attached random configuration file, > > > > >

Re: [PATCH v4 0/3] I2C/SMBus: add support for Host Notify (in i2c_i801)

2015-09-23 Thread Jean Delvare
On Tue, 22 Sep 2015 13:41:27 -0400, Benjamin Tissoires wrote: > Hi All, > > any estimate when anybody will be able to review this series? It's on my to-do list, hopefully this week or early next week. For the core part it's probably better if Wolfram can do the review. -- Jean Delvar

Re: [PATCH v4 0/3] I2C/SMBus: add support for Host Notify (in i2c_i801)

2015-09-23 Thread Jean Delvare
On Tue, 22 Sep 2015 13:41:27 -0400, Benjamin Tissoires wrote: > Hi All, > > any estimate when anybody will be able to review this series? It's on my to-do list, hopefully this week or early next week. For the core part it's probably better if Wolfram can do the review. -- Jean Delvar

Re: [PATCH 06/27] misc: eeprom: Export I2C module alias information in missing drivers

2015-08-04 Thread Jean Delvare
On Mon, 3 Aug 2015 21:12:39 +0200, Javier Martinez Canillas wrote: > On 08/03/2015 06:50 PM, Jean Delvare wrote: > > Yes, the long-term plan is to get rid of the legacy eeprom driver. But > > we need a transition path for users. Either the at24 driver should be > > able to ins

Re: [PATCH 06/27] misc: eeprom: Export I2C module alias information in missing drivers

2015-08-04 Thread Jean Delvare
On Mon, 3 Aug 2015 21:12:39 +0200, Javier Martinez Canillas wrote: On 08/03/2015 06:50 PM, Jean Delvare wrote: Yes, the long-term plan is to get rid of the legacy eeprom driver. But we need a transition path for users. Either the at24 driver should be able to instantiate SPD and EDID

Re: [PATCH 06/27] misc: eeprom: Export I2C module alias information in missing drivers

2015-08-03 Thread Jean Delvare
Le Monday 03 August 2015 à 16:07 +0200, Javier Martinez Canillas a écrit : > Hello Jean, > > On 08/03/2015 01:05 PM, Jean Delvare wrote: > > Hi Javier, > > > > On Thu, 30 Jul 2015 18:18:31 +0200, Javier Martinez Canillas wrote: > >> The I2C core always

Re: [lm-sensors] MAINTAINERS/s5p: Kamil Debski no longer with Samsung?

2015-08-03 Thread Jean Delvare
on should be clarified soon > (I've added Kamil to Cc). Already clarified behind the scenes ;-) The patch should be discarded. Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ker

Re: [PATCH 06/27] misc: eeprom: Export I2C module alias information in missing drivers

2015-08-03 Thread Jean Delvare
_id[] = { > { "max6875", 0 }, > { } > }; > +MODULE_DEVICE_TABLE(i2c, max6875_id); > > static struct i2c_driver max6875_driver = { > .driver = { That one is needed, I agree. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support -- To unsub

Re: [PATCH 06/27] misc: eeprom: Export I2C module alias information in missing drivers

2015-08-03 Thread Jean Delvare
i2c_driver max6875_driver = { .driver = { That one is needed, I agree. Reviewed-by: Jean Delvare jdelv...@suse.de -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 06/27] misc: eeprom: Export I2C module alias information in missing drivers

2015-08-03 Thread Jean Delvare
Le Monday 03 August 2015 à 16:07 +0200, Javier Martinez Canillas a écrit : Hello Jean, On 08/03/2015 01:05 PM, Jean Delvare wrote: Hi Javier, On Thu, 30 Jul 2015 18:18:31 +0200, Javier Martinez Canillas wrote: The I2C core always reports the MODALIAS uevent as i2c:client name

Re: [lm-sensors] MAINTAINERS/s5p: Kamil Debski no longer with Samsung?

2015-08-03 Thread Jean Delvare
;-) The patch should be discarded. Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH v2 3/3] i2c: i801: add support of Host Notify

2015-07-29 Thread Jean Delvare
On Wed, 29 Jul 2015 10:58:13 -0400, Benjamin Tissoires wrote: > On Sat, Jul 25, 2015 at 5:38 PM, Jean Delvare wrote: > > On Sat, 25 Jul 2015 12:22:02 -0400, Benjamin Tissoires wrote: > >> On Sat, Jul 25, 2015 at 12:11 PM, Jean Delvare wrote: > >> > Hi Benjamin, >

Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

2015-07-29 Thread Jean Delvare
g future backports to that driver more difficult. And if nothing else, the time you (or others) spend on this, is time you won't spend somewhere else where it may be more useful. Or fun. So in the end there's always a balance between the costs and the benefits. Which may explain why sometimes some

Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

2015-07-29 Thread Jean Delvare
good enough in practice and avoids cluttering Kconfig with even more options. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/8] misc: eeprom: clean up eeprom_read()

2015-07-29 Thread Jean Delvare
On Mon, 27 Jul 2015 00:18:49 +0300, Vladimir Zapolskiy wrote: > The change removes redundant sysfs binary file boundary check, since > this task is already done on caller side in fs/sysfs/file.c > > Signed-off-by: Vladimir Zapolskiy > Cc: Jean Delvare > --- > drivers/mis

Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

2015-07-29 Thread Jean Delvare
Le Tuesday 28 July 2015 à 10:46 +0100, Lee Jones a écrit : > On Mon, 27 Jul 2015, Matt Fleming wrote: > > + strcpy(pdata->name, info->name); > > strncpy() is safer. And strlcpy() is even better. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send

Re: [PATCH 3/5] iTCO_wdt: Add support for TCO on Intel Sunrisepoint

2015-07-29 Thread Jean Delvare
could merge both with a conditional. If you prefer not to, then it probably makes sense to change the whole block to a switch/case construct. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 3/3] i2c: i801: add support of Host Notify

2015-07-29 Thread Jean Delvare
On Wed, 29 Jul 2015 10:58:13 -0400, Benjamin Tissoires wrote: On Sat, Jul 25, 2015 at 5:38 PM, Jean Delvare jdelv...@suse.de wrote: On Sat, 25 Jul 2015 12:22:02 -0400, Benjamin Tissoires wrote: On Sat, Jul 25, 2015 at 12:11 PM, Jean Delvare jdelv...@suse.de wrote: Hi Benjamin, On Tue

Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

2015-07-29 Thread Jean Delvare
there's always a balance between the costs and the benefits. Which may explain why sometimes some maintainers aren't so interested in certain clean-up patches. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

2015-07-29 Thread Jean Delvare
select I2C_I801 I did not test that, some care might be needed due to tristate vs. boolean. I personally prefer the first approach. It may not be as clean as the second approach but it should be good enough in practice and avoids cluttering Kconfig with even more options. -- Jean Delvare SUSE L3

Re: [PATCH 4/8] misc: eeprom: clean up eeprom_read()

2015-07-29 Thread Jean Delvare
On Mon, 27 Jul 2015 00:18:49 +0300, Vladimir Zapolskiy wrote: The change removes redundant sysfs binary file boundary check, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy v...@mleia.com Cc: Jean Delvare jdelv...@suse.com --- drivers

Re: [PATCH 3/5] iTCO_wdt: Add support for TCO on Intel Sunrisepoint

2015-07-29 Thread Jean Delvare
block to a switch/case construct. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

2015-07-29 Thread Jean Delvare
Le Tuesday 28 July 2015 à 10:46 +0100, Lee Jones a écrit : On Mon, 27 Jul 2015, Matt Fleming wrote: + strcpy(pdata-name, info-name); strncpy() is safer. And strlcpy() is even better. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v2 3/3] i2c: i801: add support of Host Notify

2015-07-25 Thread Jean Delvare
On Sat, 25 Jul 2015 12:22:02 -0400, Benjamin Tissoires wrote: > On Sat, Jul 25, 2015 at 12:11 PM, Jean Delvare wrote: > > Hi Benjamin, > > > > On Tue, 21 Jul 2015 17:24:55 -0400, Benjamin Tissoires wrote: > >> So please disregard this series, I will send a v4 hope

Re: [PATCH v2 3/3] i2c: i801: add support of Host Notify

2015-07-25 Thread Jean Delvare
Hi Benjamin, On Tue, 21 Jul 2015 17:24:55 -0400, Benjamin Tissoires wrote: > So please disregard this series, I will send a v4 hopefully soonish. >From v2 directly to v4? Did I miss something? -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH v2 3/3] i2c: i801: add support of Host Notify

2015-07-25 Thread Jean Delvare
Hi Benjamin, On Tue, 21 Jul 2015 17:24:55 -0400, Benjamin Tissoires wrote: So please disregard this series, I will send a v4 hopefully soonish. From v2 directly to v4? Did I miss something? -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v2 3/3] i2c: i801: add support of Host Notify

2015-07-25 Thread Jean Delvare
On Sat, 25 Jul 2015 12:22:02 -0400, Benjamin Tissoires wrote: On Sat, Jul 25, 2015 at 12:11 PM, Jean Delvare jdelv...@suse.de wrote: Hi Benjamin, On Tue, 21 Jul 2015 17:24:55 -0400, Benjamin Tissoires wrote: So please disregard this series, I will send a v4 hopefully soonish. From v2

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

2015-07-17 Thread Jean Delvare
rms of the most common cases is a key to make the right decision. Thinking about servers with a lots of CPU cores versus embedded devices with few cores and tight memory constraints, that is useful. Making up corner cases is not. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send th

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

2015-07-17 Thread Jean Delvare
On Fri, 17 Jul 2015 12:36:34 -0700, Guenter Roeck wrote: > Hi Jean, > > On 07/17/2015 12:11 PM, Jean Delvare wrote: > > > > > We could just drop NUM_REAL_CORES and use CONFIG_NR_CPUS instead, I > > would be fine with that. This lets people worried about

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

2015-07-17 Thread Jean Delvare
y instead of list. I'm not so worried about memory. Did you actually check how many bytes of memory were used per supported logical CPU? We could just drop NUM_REAL_CORES and use CONFIG_NR_CPUS instead, I would be fine with that. This lets people worried about memory consumption control it. -- Jean

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

2015-07-17 Thread Jean Delvare
NUM_REAL_CORES and use CONFIG_NR_CPUS instead, I would be fine with that. This lets people worried about memory consumption control it. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

2015-07-17 Thread Jean Delvare
. Thinking about servers with a lots of CPU cores versus embedded devices with few cores and tight memory constraints, that is useful. Making up corner cases is not. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

2015-07-17 Thread Jean Delvare
On Fri, 17 Jul 2015 12:36:34 -0700, Guenter Roeck wrote: Hi Jean, On 07/17/2015 12:11 PM, Jean Delvare wrote: We could just drop NUM_REAL_CORES and use CONFIG_NR_CPUS instead, I would be fine with that. This lets people worried about memory consumption control it. Unfortunately

Re: [PATCH] i2c-parport: Add VCT-jig adapter

2015-07-16 Thread Jean Delvare
tscl = { 0x80, PORT_STAT, 1 }, > + }, > }; > > static int type = -1; > @@ -103,4 +110,5 @@ MODULE_PARM_DESC(type, > " 5 = ADM1025, ADM1030 and ADM1031 evaluation boards\n" > " 6 = Barco LPT->DVI (K5800236) adapter\n" > " 7

Re: [PATCH] i2c-parport: Add VCT-jig adapter

2015-07-16 Thread Jean Delvare
= ADM1025, ADM1030 and ADM1031 evaluation boards\n 6 = Barco LPT-DVI (K5800236) adapter\n 7 = One For All JP1 parallel port adapter\n + 8 = VCT-jig\n ); Looks good. Reviewed-by: Jean Delvare jdelv...@suse.de -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send

Re: [PATCH] Lindent: Handle missing indent gracefully

2015-07-15 Thread Jean Delvare
as of November 2007) have a "--linux-style" option which serves the same purpose as Lindent. The result is almost the same in my case, but --linux-style translates to a much longer list of options. Also some options seem better than what Lindent uses (e.g. -il1 instead of -il0.) In

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

2015-07-15 Thread Jean Delvare
why this is needed and why this is the right way to do it. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htm

RE: megaraid_sas: "FW in FAULT state!!", how to get more debug output? [BKO63661]

2015-07-15 Thread Jean Delvare
which send via email will be send to upstream > very soon along with other patch set. OK, thanks for the clarification. The patched SLES 11 SP3 kernel is currently under testing by the customer, apparently it doesn't work but I don't have all the details yet. Maybe some more patches need to be

RE: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-07-15 Thread Jean Delvare
is currently under testing by the customer, apparently it doesn't work but I don't have all the details yet. Maybe some more patches need to be backported because that kernel is older. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] Lindent: Handle missing indent gracefully

2015-07-15 Thread Jean Delvare
that Lindent could go away and references to it be replaced with indent --linux-style. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

2015-07-15 Thread Jean Delvare
this is needed and why this is the right way to do it. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] Add support for reading SMBIOS Slot number for PCI devices

2015-07-13 Thread Jean Delvare
se dmidecode or libsmbios to retrieve the same information? -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [PATCH] Add support for reading SMBIOS Slot number for PCI devices

2015-07-13 Thread Jean Delvare
you use dmidecode or libsmbios to retrieve the same information? -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

RE: megaraid_sas: "FW in FAULT state!!", how to get more debug output? [BKO63661]

2015-07-10 Thread Jean Delvare
Hi Kashyap, Le Tuesday 07 July 2015 à 14:48 +0530, Kashyap Desai a écrit : > > -Original Message- > > From: Jean Delvare [mailto:jdelv...@suse.de] > > Sent: Tuesday, July 07, 2015 2:14 PM > > To: Kashyap Desai > > Cc: Bjorn Helgaas; Robin H. Johnson;

Re: [PATCH] Lindent: Handle missing indent gracefully

2015-07-10 Thread Jean Delvare
Hi Joe, Le Friday 10 July 2015 à 04:51 -0700, Joe Perches a écrit : > On Fri, 2015-07-10 at 13:47 +0200, Jean Delvare wrote: > > If indent is not found, bail out immediately instead of spitting > > random shell script error messages. > > OK, but can't we just delete Lind

[PATCH] Lindent: Handle missing indent gracefully

2015-07-10 Thread Jean Delvare
If indent is not found, bail out immediately instead of spitting random shell script error messages. Signed-off-by: Jean Delvare --- scripts/Lindent |3 +++ 1 file changed, 3 insertions(+) --- linux-4.2-rc0.orig/scripts/Lindent 2015-06-22 07:05:43.0 +0200 +++ linux-4.2-rc0/scripts

[PATCH] Lindent: Handle missing indent gracefully

2015-07-10 Thread Jean Delvare
If indent is not found, bail out immediately instead of spitting random shell script error messages. Signed-off-by: Jean Delvare jdelv...@suse.de --- scripts/Lindent |3 +++ 1 file changed, 3 insertions(+) --- linux-4.2-rc0.orig/scripts/Lindent 2015-06-22 07:05:43.0 +0200 +++ linux

RE: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-07-10 Thread Jean Delvare
Hi Kashyap, Le Tuesday 07 July 2015 à 14:48 +0530, Kashyap Desai a écrit : -Original Message- From: Jean Delvare [mailto:jdelv...@suse.de] Sent: Tuesday, July 07, 2015 2:14 PM To: Kashyap Desai Cc: Bjorn Helgaas; Robin H. Johnson; Adam Radford; Neela Syam Kolli; linux- s

Re: [PATCH] Lindent: Handle missing indent gracefully

2015-07-10 Thread Jean Delvare
Hi Joe, Le Friday 10 July 2015 à 04:51 -0700, Joe Perches a écrit : On Fri, 2015-07-10 at 13:47 +0200, Jean Delvare wrote: If indent is not found, bail out immediately instead of spitting random shell script error messages. OK, but can't we just delete Lindent instead? Because

Re: config PROC_CHILDREN

2015-07-08 Thread Jean Delvare
Le Wednesday 08 July 2015 à 16:18 +0200, Iago López Galeiras a écrit : > On 07/04/2015 07:07 PM, Jean Delvare wrote: > > On Fri, 3 Jul 2015 11:10:45 +0200, Iago López Galeiras wrote: > >> The purpose of this option is enabling /proc//task//children > >> wi

Re: config PROC_CHILDREN

2015-07-08 Thread Jean Delvare
Le Wednesday 08 July 2015 à 15:50 +0100, Djalal Harouni a écrit : > On Wed, Jul 08, 2015 at 04:18:28PM +0200, Iago López Galeiras wrote: > > On 07/04/2015 07:07 PM, Jean Delvare wrote: > > > That being said, I am curious... Is this interface so expensive that it > > >

Re: config PROC_CHILDREN

2015-07-08 Thread Jean Delvare
Le Wednesday 08 July 2015 à 15:50 +0100, Djalal Harouni a écrit : On Wed, Jul 08, 2015 at 04:18:28PM +0200, Iago López Galeiras wrote: On 07/04/2015 07:07 PM, Jean Delvare wrote: That being said, I am curious... Is this interface so expensive that it really deserves a separate option

Re: config PROC_CHILDREN

2015-07-08 Thread Jean Delvare
Le Wednesday 08 July 2015 à 16:18 +0200, Iago López Galeiras a écrit : On 07/04/2015 07:07 PM, Jean Delvare wrote: On Fri, 3 Jul 2015 11:10:45 +0200, Iago López Galeiras wrote: The purpose of this option is enabling /proc/pid/task/tid/children without having to enable CHECKPOINT_RESTORE

Re: [PATCH 2/2] i2c: i801: add support of Host Notify

2015-07-07 Thread Jean Delvare
On Tue, 7 Jul 2015 16:16:38 -0400, Benjamin Tissoires wrote: > On Jul 07 2015 or thereabouts, Jean Delvare wrote: > > So you use the same driver callback for SMBus Alert and SMBus Host > > Notify. This makes some sense, but if a given driver supports both, how > > does it know

Re: [PATCH 2/2] i2c: i801: add support of Host Notify

2015-07-07 Thread Jean Delvare
t; - dev_dbg(>dev, "alert with no driver\n"); > - device_unlock(dev); > + if (i2c_alert(client, data->flag)) > + return 0; > > /* Stop iterating after we find the device */ > return -EBUSY; > diff --git a/include/linux

Re: [PATCH 1/2] i2c: add SMBus Host Notify support

2015-07-07 Thread Jean Delvare
On Tue, 7 Jul 2015 10:23:33 -0400, Benjamin Tissoires wrote: > Hi Jean, > > On Jun 29 2015 or thereabouts, Jean Delvare wrote: > > Hi Benjamin, > > > > On Tue, 23 Jun 2015 14:58:18 -0400, Benjamin Tissoires wrote: > > > SMBus Host Notify allows a slav

Re: megaraid_sas: "FW in FAULT state!!", how to get more debug output? [BKO63661]

2015-07-07 Thread Jean Delvare
sts/linux-scsi/msg67288.html > > Please post the result with attached patch. Good news! Customer tested your patch and said it fixed the problem :-) I am now in the process of backporting the patch to the SLES 11 SP3 kernel for further testing. I'll let you know how it goes. Thank you very

Re: [PATCH 1/2] i2c: add SMBus Host Notify support

2015-07-07 Thread Jean Delvare
On Tue, 7 Jul 2015 10:23:33 -0400, Benjamin Tissoires wrote: Hi Jean, On Jun 29 2015 or thereabouts, Jean Delvare wrote: Hi Benjamin, On Tue, 23 Jun 2015 14:58:18 -0400, Benjamin Tissoires wrote: SMBus Host Notify allows a slave device to act as a master on a bus to notify

Re: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-07-07 Thread Jean Delvare
with attached patch. Good news! Customer tested your patch and said it fixed the problem :-) I am now in the process of backporting the patch to the SLES 11 SP3 kernel for further testing. I'll let you know how it goes. Thank you very much for your assistance. -- Jean Delvare SUSE L3 Support

Re: [PATCH 2/2] i2c: i801: add support of Host Notify

2015-07-07 Thread Jean Delvare
*client, unsigned int data); + /* This is the very generalized SMBus access routine. You probably do not want to use this, though; one of the functions below may be much easier, and probably just as fast. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] i2c: i801: add support of Host Notify

2015-07-07 Thread Jean Delvare
On Tue, 7 Jul 2015 16:16:38 -0400, Benjamin Tissoires wrote: On Jul 07 2015 or thereabouts, Jean Delvare wrote: So you use the same driver callback for SMBus Alert and SMBus Host Notify. This makes some sense, but if a given driver supports both, how does it know which event happened

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Jean Delvare
. > > Signed-off-by: Sascha Hauer > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Jean Delvare > Cc: Peter Feuerer > Cc: Heiko Stuebner > Cc: Lukasz Majewski > Cc: Stephen Warren > Cc: Thi

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Jean Delvare
Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Jean Delvare jdelv...@suse.de Cc: Peter Feuerer pe...@piie.net Cc: Heiko Stuebner he...@sntech.de Cc: Lukasz Majewski l.majew...@samsung.com Cc: Stephen Warren

Re: [PATCH v3] hwmon: (nct7802) Add pwm control

2015-07-05 Thread Jean Delvare
mention DC vs. pwm mode, have you > considered adding pwm[123]_mode attributes to report the > selected mode ? If you do, please make sure these attributes are read-only. Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: config PROC_CHILDREN

2015-07-05 Thread Jean Delvare
ption, instead of always enabling it? This seems to be a fairly generic feature that a lot of scripts and tools could benefit from (starting with pstree I suppose.) -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: config RCU_EQS_DEBUG

2015-07-05 Thread Jean Delvare
Hi Paul, On Fri, 3 Jul 2015 09:00:37 -0700, Paul E. McKenney wrote: > On Fri, Jul 03, 2015 at 10:07:45AM +0200, Jean Delvare wrote: > > You just introduced a Linux kernel configuration option named > > RCU_EQS_DEBUG. Its short description is "Use this when adding any sort

Re: config RCU_EQS_DEBUG

2015-07-05 Thread Jean Delvare
Hi Paul, On Fri, 3 Jul 2015 09:00:37 -0700, Paul E. McKenney wrote: On Fri, Jul 03, 2015 at 10:07:45AM +0200, Jean Delvare wrote: You just introduced a Linux kernel configuration option named RCU_EQS_DEBUG. Its short description is Use this when adding any sort of NO_HZ support to your

Re: [PATCH v3] hwmon: (nct7802) Add pwm control

2015-07-05 Thread Jean Delvare
pwm[123]_mode attributes to report the selected mode ? If you do, please make sure these attributes are read-only. Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: config PROC_CHILDREN

2015-07-05 Thread Jean Delvare
enabling it? This seems to be a fairly generic feature that a lot of scripts and tools could benefit from (starting with pstree I suppose.) -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

config RCU_EQS_DEBUG

2015-07-03 Thread Jean Delvare
nally I see some inconsistency in the fact that this option defaults to n but the help text says "Say Y if you are unsure". BTW, option RCU_CPU_STALL_INFO is equally inconsistent with a default y and "say N if you are unsure" in the help text. -- Jean Delvare SUSE L3 Support -- To unsu

config PROC_CHILDREN

2015-07-03 Thread Jean Delvare
the user make a sane decision. Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FA

config RCU_EQS_DEBUG

2015-07-03 Thread Jean Delvare
that this option defaults to n but the help text says Say Y if you are unsure. BTW, option RCU_CPU_STALL_INFO is equally inconsistent with a default y and say N if you are unsure in the help text. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel

config PROC_CHILDREN

2015-07-03 Thread Jean Delvare
the user make a sane decision. Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

RE: megaraid_sas: "FW in FAULT state!!", how to get more debug output? [BKO63661]

2015-07-01 Thread Jean Delvare
I can provide patch for > you. > > ` Kashyap > > > -Original Message- > > From: Jean Delvare [mailto:jdelv...@suse.de] > > Sent: Monday, June 29, 2015 6:55 PM > > To: Kashyap Desai > > Cc: Bjorn Helgaas; Robin H. Johnson; Adam Radford; Neela Syam

RE: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-07-01 Thread Jean Delvare
-Original Message- From: Jean Delvare [mailto:jdelv...@suse.de] Sent: Monday, June 29, 2015 6:55 PM To: Kashyap Desai Cc: Bjorn Helgaas; Robin H. Johnson; Adam Radford; Neela Syam Kolli; linux- s...@vger.kernel.org; arkadiusz.bub...@open-e.com; Matthew Garrett; Sumit Saxena

RE: megaraid_sas: "FW in FAULT state!!", how to get more debug output? [BKO63661]

2015-06-29 Thread Jean Delvare
Hi Kashyap, Thanks for the patch. May I ask what tree it was based on? Linus' latest? I am trying to apply it to the SLES 11 SP3 and SLES 12 kernel trees (based on kernel v3.0 + a bunch of backports and v3.12 respectively) but your patch fails to apply in both cases. I'll try harder but I don't

Re: [PATCH 1/2] i2c: add SMBus Host Notify support

2015-06-29 Thread Jean Delvare
ude/uapi/linux/i2c.h > +++ b/include/uapi/linux/i2c.h > @@ -100,6 +100,7 @@ struct i2c_msg { > #define I2C_FUNC_SMBUS_WRITE_BLOCK_DATA 0x0200 > #define I2C_FUNC_SMBUS_READ_I2C_BLOCK0x0400 /* I2C-like block > xfer */ > #define I2C_FUNC_SMBUS_WRITE_I2C_BLOCK 0x0800 /* w/

Re: [PATCH 1/2] i2c: add SMBus Host Notify support

2015-06-29 Thread Jean Delvare
) -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-06-29 Thread Jean Delvare
Hi Kashyap, Thanks for the patch. May I ask what tree it was based on? Linus' latest? I am trying to apply it to the SLES 11 SP3 and SLES 12 kernel trees (based on kernel v3.0 + a bunch of backports and v3.12 respectively) but your patch fails to apply in both cases. I'll try harder but I don't

[GIT PULL] dmi update for v4.2

2015-06-25 Thread Jean Delvare
esting/sysfs-firmware-dmi-tables --- Ivan Khoronzhuk (3): firmware: dmi_scan: Rename dmi_table to dmi_decode_table firmware: dmi_scan: add SBMIOS entry and DMI tables Documentation: ABI: sysfs-firmware-dmi: add -entries suffix to file name Jean Delvare (5): fi

[GIT PULL] dmi update for v4.2

2015-06-25 Thread Jean Delvare
/sysfs-firmware-dmi-tables --- Ivan Khoronzhuk (3): firmware: dmi_scan: Rename dmi_table to dmi_decode_table firmware: dmi_scan: add SBMIOS entry and DMI tables Documentation: ABI: sysfs-firmware-dmi: add -entries suffix to file name Jean Delvare (5): firmware

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

2015-06-22 Thread Jean Delvare
http://patchwork.linux-mips.org/patch/7540/ then: http://marc.info/?t=14095865642=1=2 The idea was great IMHO but it did not work out, and I can't remember why. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

2015-06-22 Thread Jean Delvare
=14095865642r=1w=2 The idea was great IMHO but it did not work out, and I can't remember why. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

2015-06-17 Thread Jean Delvare
N))) > + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && > !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE)) > depends on VIRT_TO_BUS > help > This enables HiSax support for the Netspider U interface

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

2015-06-17 Thread Jean Delvare
!CPU_LITTLE_ENDIAN))) + depends on PCI (BROKEN || !(PPC || PARISC || M68K || (MIPS !CPU_LITTLE_ENDIAN) || FRV || (XTENSA !CPU_LITTLE_ENDIAN) || MICROBLAZE)) depends on VIRT_TO_BUS help This enables HiSax support for the Netspider U interface ISDN card Acked-by: Jean Delvare jdelv

Re: [PATCH V2 2/3] i2c-piix4: Use Macro for AMD CZ SMBus device ID

2015-06-15 Thread Jean Delvare
R_ID_SERVERWORKS, > PCI_DEVICE_ID_SERVERWORKS_OSB4) }, > { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, Probably too late but anyway: Acked-by: Jean Delvare -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH V2 2/3] i2c-piix4: Use Macro for AMD CZ SMBus device ID

2015-06-15 Thread Jean Delvare
Delvare jdelv...@suse.de -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/1 linux-next] hwmon: (w83627ehf) use swap() in w82627ehf_swap_tempreg()

2015-06-11 Thread Jean Delvare
ata->reg_temp_config[r2]; > - data->reg_temp_config[r2] = tmp; > + swap(data->temp_src[r1], data->temp_src[r2]); > + swap(data->reg_temp[r1], data->reg_temp[r2]); > + swap(data->reg_temp_over[r1], data->reg_temp_over[r2]); > + swap

<    3   4   5   6   7   8   9   10   11   12   >