[PATCH 0/4] UML - Code cleanups for 2.6.21

2007-03-28 Thread Jeff Dike
These are tidying patches from Blaisorblade - 2.6.21 material. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 1/4] UML - hostfs variable renaming

2007-03-28 Thread Jeff Dike
From: Paolo 'Blaisorblade' Giarrusso [EMAIL PROTECTED] * rename name to host_root_path * rename data to req_root. Signed-off-by: Paolo 'Blaisorblade' Giarrusso [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- fs/hostfs/hostfs_kern.c | 26 +- 1 files

[PATCH 3/4] UML - Eliminate temporary buffer in eth_configure

2007-03-28 Thread Jeff Dike
-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/net_kern.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) Index: linux-2.6.21-mm/arch/um/drivers/net_kern.c === --- linux-2.6.21-mm.orig/arch

Re: [uml-devel] [PATCH 0/6] UML - small fixes for 2.6.22

2007-03-27 Thread Jeff Dike
On Tue, Mar 27, 2007 at 02:27:45PM -0400, Jeff Dike wrote: > These are all 2.6.22 material. err, I meant 2.6.21... Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[PATCH] UML - fix I/O hang when multiple devices are in use

2007-03-27 Thread Jeff Dike
to the host. This should have been made per-device as well, since it causes I/O hangs when multiple block devices are in use. This patch fixes that by replacing the global with an activity flag in the device structure in order to tell whether the queue is currently being run. Signed-off-by: Jeff Dike

[PATCH 1/6] i386 - fix cmpxchg warning

2007-03-27 Thread Jeff Dike
I started getting warnings from atomic.h about cmpxchg not having a prototype. It's declared in system.h, so including that fixes the UML build warnings and has no noticable ill effects on the i386 build. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- include/asm-i386/atomic.h |1 +

[PATCH 0/6] UML - small fixes for 2.6.22

2007-03-27 Thread Jeff Dike
These are all 2.6.22 material. Patch 1 fixes what appears to be a i386 compilation bug, so we'll want Andi's ack on that, probably. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[PATCH 6/6] UML - Fix LVM crash

2007-03-27 Thread Jeff Dike
ax_pfn. This ensures init_emergency_isa_pool() doesn't crash uml in this situation by setting max_low_pfn == max_pfn in mem_init(). Signed-off-by: Jason Lunz <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/kernel/mem.c |3 +-- 1 file changed, 1 insertion

[PATCH 4/6] UML - Fix pte bit collision

2007-03-27 Thread Jeff Dike
From: Miklos Szeredi <[EMAIL PROTECTED]> _PAGE_PROTNONE conflicts with the lowest bit of pgoff. This causes all sorts of weirdness when nonlinear mappings are used. Took me a good half day to track this down. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> Signed-off-by: Jeff

[PATCH 2/6] UML - fix compilation problems

2007-03-27 Thread Jeff Dike
of user_util.h in hostfs Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/mconsole.h |2 ++ arch/um/kernel/ptrace.c| 14 +++--- arch/um/sys-i386/ldt.c |3 ++- fs/hostfs/hostfs_kern.c|1 - 4 files changed, 11 insertions(+), 9 deletions(-)

[PATCH 3/6] UML - Fix device unplug crash

2007-03-27 Thread Jeff Dike
Fix a NULL dereference when unplugging a device. The default value of err_msg wants to be "" in case the driver doesn't modify it. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/mconsole_kern.c |3 +++ 1 file changed, 3 insertions(+) Index: linux-2.6.21-mm

[PATCH 5/6] UML - irq locking fixes

2007-03-27 Thread Jeff Dike
, in the sense that it blocked and unblocked interrupts, but it still should have saved and restored them. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/chan_kern.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Index: linux-2.6.21-mm/arch/um/drivers/chan_

[PATCH 2/6] UML - fix compilation problems

2007-03-27 Thread Jeff Dike
of user_util.h in hostfs Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/mconsole.h |2 ++ arch/um/kernel/ptrace.c| 14 +++--- arch/um/sys-i386/ldt.c |3 ++- fs/hostfs/hostfs_kern.c|1 - 4 files changed, 11 insertions(+), 9 deletions(-) Index

[PATCH 3/6] UML - Fix device unplug crash

2007-03-27 Thread Jeff Dike
Fix a NULL dereference when unplugging a device. The default value of err_msg wants to be in case the driver doesn't modify it. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/mconsole_kern.c |3 +++ 1 file changed, 3 insertions(+) Index: linux-2.6.21-mm/arch/um/drivers

[PATCH 5/6] UML - irq locking fixes

2007-03-27 Thread Jeff Dike
, in the sense that it blocked and unblocked interrupts, but it still should have saved and restored them. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/chan_kern.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Index: linux-2.6.21-mm/arch/um/drivers/chan_kern.c

[PATCH 0/6] UML - small fixes for 2.6.22

2007-03-27 Thread Jeff Dike
These are all 2.6.22 material. Patch 1 fixes what appears to be a i386 compilation bug, so we'll want Andi's ack on that, probably. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line unsubscribe linux-kernel in

[PATCH 6/6] UML - Fix LVM crash

2007-03-27 Thread Jeff Dike
init_emergency_isa_pool() doesn't crash uml in this situation by setting max_low_pfn == max_pfn in mem_init(). Signed-off-by: Jason Lunz [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/kernel/mem.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.21-mm/arch

[PATCH 4/6] UML - Fix pte bit collision

2007-03-27 Thread Jeff Dike
From: Miklos Szeredi [EMAIL PROTECTED] _PAGE_PROTNONE conflicts with the lowest bit of pgoff. This causes all sorts of weirdness when nonlinear mappings are used. Took me a good half day to track this down. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL

[PATCH 1/6] i386 - fix cmpxchg warning

2007-03-27 Thread Jeff Dike
I started getting warnings from atomic.h about cmpxchg not having a prototype. It's declared in system.h, so including that fixes the UML build warnings and has no noticable ill effects on the i386 build. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- include/asm-i386/atomic.h |1 + 1 file

[PATCH] UML - fix I/O hang when multiple devices are in use

2007-03-27 Thread Jeff Dike
to the host. This should have been made per-device as well, since it causes I/O hangs when multiple block devices are in use. This patch fixes that by replacing the global with an activity flag in the device structure in order to tell whether the queue is currently being run. Signed-off-by: Jeff Dike

Re: [uml-devel] [PATCH 0/6] UML - small fixes for 2.6.22

2007-03-27 Thread Jeff Dike
On Tue, Mar 27, 2007 at 02:27:45PM -0400, Jeff Dike wrote: These are all 2.6.22 material. err, I meant 2.6.21... Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH] UML - use correct register file size everywhere

2007-03-25 Thread Jeff Dike
be. When this causes a problem, it makes PTRACE_SETREGS fail on x86_64 because of a corrupted segment register value in the known-good register file. The patch also adds a register dump at that point in case there are any future problems here. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- a

[PATCH] UML - Fix static linking

2007-03-25 Thread Jeff Dike
for ld to drop this stuff into. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- include/asm-um/common.lds.S |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.21-mm/include/asm-um/common.lds.S === --- linux-2.6.21-mm.orig/i

[PATCH] UML - Fix static linking

2007-03-25 Thread Jeff Dike
for ld to drop this stuff into. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- include/asm-um/common.lds.S |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.21-mm/include/asm-um/common.lds.S === --- linux-2.6.21-mm.orig/include/asm

[PATCH] UML - use correct register file size everywhere

2007-03-25 Thread Jeff Dike
be. When this causes a problem, it makes PTRACE_SETREGS fail on x86_64 because of a corrupted segment register value in the known-good register file. The patch also adds a register dump at that point in case there are any future problems here. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include

[PATCH] UML - host VDSO fix

2007-03-23 Thread Jeff Dike
to use the host's VDSO. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/elf_aux.c |3 +++ 1 file changed, 3 insertions(+) Index: linux-2.6.17/arch/um/os-Linux/elf_aux.c === --- linux-2.6.17.orig/arch/um/os

[PATCH] UML - fix epoll

2007-03-23 Thread Jeff Dike
[ This is both 2.6.21 and -stable material ] UML/x86_64 needs the same packing of struct epoll_event as x86_64. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- include/linux/eventpoll.h |7 +++ 1 file changed, 7 insertions(+) Index: linux-2.6.21-mm/include/linux/event

Re: [uml-devel] [ PATCH 4/7 ] UML - create as-layout.h

2007-03-23 Thread Jeff Dike
On Fri, Mar 23, 2007 at 07:47:50AM +0100, Blaisorblade wrote: > Hey, I do like _these_ patches! A nice picture in that header could then be > added (in the very future ;-) ), but at least one knows there are so much of > them. And user_util.h is no more! Heh :-) user_util.h has disgusted me

Re: [uml-devel] [ PATCH 4/7 ] UML - create as-layout.h

2007-03-23 Thread Jeff Dike
On Fri, Mar 23, 2007 at 07:47:50AM +0100, Blaisorblade wrote: Hey, I do like _these_ patches! A nice picture in that header could then be added (in the very future ;-) ), but at least one knows there are so much of them. And user_util.h is no more! Heh :-) user_util.h has disgusted me for a

[PATCH] UML - fix epoll

2007-03-23 Thread Jeff Dike
[ This is both 2.6.21 and -stable material ] UML/x86_64 needs the same packing of struct epoll_event as x86_64. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- include/linux/eventpoll.h |7 +++ 1 file changed, 7 insertions(+) Index: linux-2.6.21-mm/include/linux/eventpoll.h

[PATCH] UML - host VDSO fix

2007-03-23 Thread Jeff Dike
to use the host's VDSO. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/os-Linux/elf_aux.c |3 +++ 1 file changed, 3 insertions(+) Index: linux-2.6.17/arch/um/os-Linux/elf_aux.c === --- linux-2.6.17.orig/arch/um/os-Linux

Re: [ PATCH 0/7 ] UML - Header cleanup

2007-03-22 Thread Jeff Dike
On Thu, Mar 22, 2007 at 09:50:34AM -0800, Andrew Morton wrote: > I have the ARRAY_SIZE change queued for 2.6.22. > > It looks like the UML change needs to be folded into the same changeset to > avoid build breaks? Yes, that would be great. Jeff -- Work email - jdike at

[ PATCH 7/7 ] UML - Add missing __init declarations

2007-03-22 Thread Jeff Dike
The build started finding calls from non-init to init functions. These are just cases of init functions not being properly marked, so this patch fixes that. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/mem.c|2 +- arch/um/os-Linux/main.c |2 +- arch

[ PATCH 2/7 ] UML - Move SIGIO testing to sigio.c

2007-03-22 Thread Jeff Dike
because it only does the SIGIO checking. If it does more, it'll probably move back to start_up.c. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/user_util.h |3 arch/um/os-Linux/sigio.c| 145 arch/um/os-Linux/start_up.c

[ PATCH 6/7 ] UML - Remove user_util.h

2007-03-22 Thread Jeff Dike
user_util.h isn't needed any more, so delete it and remove all includes of it. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/chan_kern.c |1 arch/um/drivers/chan_user.c |1 arch/um/drivers/cow_sys.h|1 arch/um/d

[ PATCH 5/7 ] UML - Move remaining useful contents of user_util.h

2007-03-22 Thread Jeff Dike
of ARRAY_SIZE in user.h. This file is included only in userspace files, so there will be no conflict with the kernel's new ARRAY_SIZE. The copy of the kernel's ARRAY_SIZE and associated infrastructure is now gone. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers

[ PATCH 1/7 ] UML - Update UML definition of ARRAY_SIZE

2007-03-22 Thread Jeff Dike
lag between this patch and the more extensive patches which tidy this mess. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/user_util.h | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) Index: linux-2.6.21-mm/arch/um/include/user_

[ PATCH 3/7 ] UML - Create arch.h

2007-03-22 Thread Jeff Dike
This patch moves the declarations of the architecture hooks from user_util.h to a new header, arch.c, and adds the necessary includes to files which need those declarations. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/arch.h | 15 +++ arch/um/i

[ PATCH 4/7 ] UML - create as-layout.h

2007-03-22 Thread Jeff Dike
place to go. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/as-layout.h | 35 +++ arch/um/include/user_util.h | 23 --- arch/um/kernel/exec.c |1 + arch/um/kernel/ksyms.c|1 + arch/um/kernel

[ PATCH 0/7 ] UML - Header cleanup

2007-03-22 Thread Jeff Dike
These are post-2.6.21 material, except that if the new definition of ARRAY_SIZE goes to Linus, patch 1 in this series should go as well. These patches are a response to the new ARRAY_SIZE. UML had a duplicate definition for the use of the userspace side of things, which can't directly use

[ PATCH 3/7 ] UML - Create arch.h

2007-03-22 Thread Jeff Dike
This patch moves the declarations of the architecture hooks from user_util.h to a new header, arch.c, and adds the necessary includes to files which need those declarations. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/arch.h | 15 +++ arch/um/include

[ PATCH 4/7 ] UML - create as-layout.h

2007-03-22 Thread Jeff Dike
place to go. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/as-layout.h | 35 +++ arch/um/include/user_util.h | 23 --- arch/um/kernel/exec.c |1 + arch/um/kernel/ksyms.c|1 + arch/um/kernel/mem.c

[ PATCH 0/7 ] UML - Header cleanup

2007-03-22 Thread Jeff Dike
These are post-2.6.21 material, except that if the new definition of ARRAY_SIZE goes to Linus, patch 1 in this series should go as well. These patches are a response to the new ARRAY_SIZE. UML had a duplicate definition for the use of the userspace side of things, which can't directly use

[ PATCH 2/7 ] UML - Move SIGIO testing to sigio.c

2007-03-22 Thread Jeff Dike
because it only does the SIGIO checking. If it does more, it'll probably move back to start_up.c. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/user_util.h |3 arch/um/os-Linux/sigio.c| 145 arch/um/os-Linux/start_up.c | 145

[ PATCH 6/7 ] UML - Remove user_util.h

2007-03-22 Thread Jeff Dike
user_util.h isn't needed any more, so delete it and remove all includes of it. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/chan_kern.c |1 arch/um/drivers/chan_user.c |1 arch/um/drivers/cow_sys.h|1 arch/um/drivers

[ PATCH 5/7 ] UML - Move remaining useful contents of user_util.h

2007-03-22 Thread Jeff Dike
of ARRAY_SIZE in user.h. This file is included only in userspace files, so there will be no conflict with the kernel's new ARRAY_SIZE. The copy of the kernel's ARRAY_SIZE and associated infrastructure is now gone. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/pty.c |1

[ PATCH 1/7 ] UML - Update UML definition of ARRAY_SIZE

2007-03-22 Thread Jeff Dike
lag between this patch and the more extensive patches which tidy this mess. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/user_util.h | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) Index: linux-2.6.21-mm/arch/um/include/user_util.h

[ PATCH 7/7 ] UML - Add missing __init declarations

2007-03-22 Thread Jeff Dike
The build started finding calls from non-init to init functions. These are just cases of init functions not being properly marked, so this patch fixes that. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/kernel/mem.c|2 +- arch/um/os-Linux/main.c |2 +- arch/um/os

Re: [ PATCH 0/7 ] UML - Header cleanup

2007-03-22 Thread Jeff Dike
On Thu, Mar 22, 2007 at 09:50:34AM -0800, Andrew Morton wrote: I have the ARRAY_SIZE change queued for 2.6.22. It looks like the UML change needs to be folded into the same changeset to avoid build breaks? Yes, that would be great. Jeff -- Work email - jdike at

Re: [stable] [PATCH] UML - arch_prctl should set thread fs

2007-03-19 Thread Jeff Dike
r file. arch_prctl_skas was fixed to call PTRACE_ARCH_PRCTL appropriately. There is some saving and restoring of registers in the ARCH_SET_* cases so that the correct set of registers are changed on the host and restored to the process when it runs again. Signed-off-by: Jeff Dike <[EMAIL

Re: [stable] [PATCH] UML - arch_prctl should set thread fs

2007-03-19 Thread Jeff Dike
. arch_prctl_skas was fixed to call PTRACE_ARCH_PRCTL appropriately. There is some saving and restoring of registers in the ARCH_SET_* cases so that the correct set of registers are changed on the host and restored to the process when it runs again. Signed-off-by: Jeff Dike [EMAIL PROTECTED

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-18 Thread Jeff Dike
On Sun, Mar 18, 2007 at 03:50:10AM +0100, Nick Piggin wrote: > Yes, that should be the case. So would this mean that nonlinear protections > don't work on regular files? I guess that's OK if Oracle and UML both use > tmpfs/shm? It's OK for UML. Jeff -- Work email - jdike at

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-18 Thread Jeff Dike
On Sun, Mar 18, 2007 at 03:50:10AM +0100, Nick Piggin wrote: Yes, that should be the case. So would this mean that nonlinear protections don't work on regular files? I guess that's OK if Oracle and UML both use tmpfs/shm? It's OK for UML. Jeff -- Work email - jdike at linux

Re: [PATCH] UML utrace support, step 1

2007-03-16 Thread Jeff Dike
ced with test_thread_flag(TIF_SINGLESTEP, or removed, in the case of execve. Most of arch/um/kernel/ptrace.c is gone, to be reinstated in future utrace work. Similarly, calls to syscall_trace and ptrace notifications in the signal delivery code are gone. Signed-off-by: Jeff Dike <[

[PATCH] UML - arch_prctl should set thread fs

2007-03-16 Thread Jeff Dike
is in the process of exiting and which has lost its mm. In this case, it's worse than useless to try to call arch_prctl on the host process. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/sys-x86_64/syscalls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Index: linux-

Re: [PATCH] USER-MODE LINUX: Delete unused header file.

2007-03-16 Thread Jeff Dike
On Sat, Mar 10, 2007 at 04:27:30PM -0500, Robert P. J. Day wrote: > > Delete the apparently unused header file > arch/um/kernel/tt/include/mode_kern-tt.h. > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> ACK > this one i'm not so sure about as there is a header file named >

Re: [PATCH] USER-MODE LINUX: Delete unused header file.

2007-03-16 Thread Jeff Dike
On Sat, Mar 10, 2007 at 04:27:30PM -0500, Robert P. J. Day wrote: Delete the apparently unused header file arch/um/kernel/tt/include/mode_kern-tt.h. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] ACK this one i'm not so sure about as there is a header file named mode_kern_tt.h,

Re: [PATCH] UML utrace support, step 1

2007-03-16 Thread Jeff Dike
, in the case of execve. Most of arch/um/kernel/ptrace.c is gone, to be reinstated in future utrace work. Similarly, calls to syscall_trace and ptrace notifications in the signal delivery code are gone. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/kernel/exec.c |1 arch

[PATCH] UML - arch_prctl should set thread fs

2007-03-16 Thread Jeff Dike
is in the process of exiting and which has lost its mm. In this case, it's worse than useless to try to call arch_prctl on the host process. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/sys-x86_64/syscalls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Index: linux-2.6.17

[PATCH] UML - arch_prctl should set thread fs

2007-03-07 Thread Jeff Dike
of exiting and which has lost its mm. In this case, it's worse than useless to try to call arch_prctl on the host process. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/sys-x86_64/syscalls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Index: linux-2.6.18-mm/arch/

Re: [uml-devel] [PATCH 4/5] UML - driver formatting fixes

2007-03-07 Thread Jeff Dike
ntk. Thanks to Blaisorblade for the close look. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/chan_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: test/arch/um/drivers/ch

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-07 Thread Jeff Dike
On Wed, Mar 07, 2007 at 02:52:12PM +0100, Peter Zijlstra wrote: > > Well I don't think UML uses nonlinear yet anyway, does it? Can they > > make do with restricting nonlinear to mlocked vmas, I wonder? Probably > > not. > > I think it does, but lets ask, Jeff? Nope, UML needs to be able to

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-07 Thread Jeff Dike
On Wed, Mar 07, 2007 at 02:52:12PM +0100, Peter Zijlstra wrote: Well I don't think UML uses nonlinear yet anyway, does it? Can they make do with restricting nonlinear to mlocked vmas, I wonder? Probably not. I think it does, but lets ask, Jeff? Nope, UML needs to be able to change

[PATCH] UML - arch_prctl should set thread fs

2007-03-07 Thread Jeff Dike
of exiting and which has lost its mm. In this case, it's worse than useless to try to call arch_prctl on the host process. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/sys-x86_64/syscalls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Index: linux-2.6.18-mm/arch/um/sys

Re: [uml-devel] [PATCH 4/5] UML - driver formatting fixes

2007-03-07 Thread Jeff Dike
. Thanks to Blaisorblade for the close look. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/chan_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: test/arch/um/drivers/chan_user.c === --- test.orig

[PATCH 4/5] UML - driver formatting fixes

2007-03-06 Thread Jeff Dike
put errno into a local variable saving errno after a printk, which can change it Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/chan_user.c |2 - arch/um/drivers/daemon_user.c| 25 +-- arch/um/drivers/mca

[PATCH 3/5] UML - handle block device hotplug errors

2007-03-06 Thread Jeff Dike
disk. This is fixed by freeing the gendisk if it's there, but not letting that affect the removal. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/ubd_kern.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) Index: test/arch/um/drivers/ubd_

[PATCH 0/5] UML - hotplug fixes and cleanup

2007-03-06 Thread Jeff Dike
These patches can wait till after 2.6.21. Three of them are tidying patches of various sorts. The other two fix network interface and block device hotplug bugs. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH 2/5] UML - print coredump limits

2007-03-06 Thread Jeff Dike
Print out core dump limits at boot time. This is to allow core dumps to be collected if something goes very wrong and to tell if a core dump isn't going to happen because of a resource limit. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/start_up.c

[PATCH 1/5] UML - Mark tt-mode code for future removal

2007-03-06 Thread Jeff Dike
Mark some tt-mode-only code as such. Also cleaned up some formatting. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/sys-i386/ptrace_user.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) Index: linux-2.6.18-mm/arch/um/sys-i386/ptrace_

[PATCH 5/5] UML - network interface hotplug error handling

2007-03-06 Thread Jeff Dike
initialized and non-working device could result. It now checks everything that can fail, and bails out, undoing whatever had been done. The return value of eth_configure was always ignored, so it is now just void. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/daemon_

[PATCH 0/5] UML - hotplug fixes and cleanup

2007-03-06 Thread Jeff Dike
These patches can wait till after 2.6.21. Three of them are tidying patches of various sorts. The other two fix network interface and block device hotplug bugs. Jeff - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH 2/5] UML - print coredump limits

2007-03-06 Thread Jeff Dike
Print out core dump limits at boot time. This is to allow core dumps to be collected if something goes very wrong and to tell if a core dump isn't going to happen because of a resource limit. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/os-Linux/start_up.c | 25

[PATCH 1/5] UML - Mark tt-mode code for future removal

2007-03-06 Thread Jeff Dike
Mark some tt-mode-only code as such. Also cleaned up some formatting. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/sys-i386/ptrace_user.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) Index: linux-2.6.18-mm/arch/um/sys-i386/ptrace_user.c

[PATCH 5/5] UML - network interface hotplug error handling

2007-03-06 Thread Jeff Dike
initialized and non-working device could result. It now checks everything that can fail, and bails out, undoing whatever had been done. The return value of eth_configure was always ignored, so it is now just void. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/daemon_user.c

[PATCH 3/5] UML - handle block device hotplug errors

2007-03-06 Thread Jeff Dike
disk. This is fixed by freeing the gendisk if it's there, but not letting that affect the removal. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/ubd_kern.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) Index: test/arch/um/drivers/ubd_kern.c

[PATCH 4/5] UML - driver formatting fixes

2007-03-06 Thread Jeff Dike
errno into a local variable saving errno after a printk, which can change it Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/chan_user.c |2 - arch/um/drivers/daemon_user.c| 25 +-- arch/um/drivers/mcast_user.c

Re: BUG: problems compiling UML

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 12:40:32PM +0100, mrkiko wrote: > Problem: > make all ARCH=um fails always on linking: it seems that a -llibname is > missing. If this report is too stupid, sorry! It's not too stupid - it's too short on details. Show us the relevant portion of the build output.

Re: [uml-devel] [PATCH 04/11] uml - hostfs: avoid possible escapes from hostfs=.

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 11:59:13PM +0100, Blaisorblade wrote: > I gave a look, and it's nice. Except that maybe "escapes_jail" would be a > clearer name (there's confusion about the subject of "escaping"). Feel free to change the name. > Also, what about concurrent UML threads caring about

[PATCH 4/4] UML - Comment the initialization of a global

2007-03-05 Thread Jeff Dike
Comment the fact that sig_info is initialized early in boot, and thus doesn't need any locking. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/trap.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.18-mm/arch/um/os-Linux/

[PATCH 2/4] UML - Fix formatting violations in signal delivery code

2007-03-05 Thread Jeff Dike
Fix a few formatting bugs in the signal code. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/signal.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: test/arch/um/kernel/si

[PATCH 3/4] UML - Add a debugging message

2007-03-05 Thread Jeff Dike
Add a debugging message in the case that mapping a stub fails. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/skas/process.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: test/arch/um/os-Linux/skas/pro

[PATCH 1/4] linux/audit.h needs linux/types.h

2007-03-05 Thread Jeff Dike
Include linux/types.h here because we need a definition of __u32. This file appears not be exported verbatim by libc, so I think this doesn't have any userspace consequences. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- include/linux/audit.h |1 + 1 file changed, 1 insertion(+)

[PATCH 0/4] Small UML and audit.h cleanups

2007-03-05 Thread Jeff Dike
These are for 2.6.21. Three are UML cleanups, and one is adding an include to linux/audit.h. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 00/11] Uml simple fixes

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 09:42:29PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > Some tested UML fixes - should be applied for 2.6.21. ACK on all of these except for 1, which won't apply to current -mm, and 4, which might need some more work. Jeff -- Work email

Re: [PATCH 04/11] uml - hostfs: avoid possible escapes from hostfs=.

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 09:49:02PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> > > Avoid accepting things like -o .., -o dir/../../dir2, -o dir/../.. . > This may be considered useless, but YMMV. I consider that this has a limited >

Re: [PATCH 01/11] uml: code convention cleanup of a file

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 09:48:59PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> > > Fix coding conventions violations is arch/um/os-Linux/helper.c. The code which you're changing here is gone in current -mm.

Re: nonlinear vma problem in uml

2007-03-05 Thread Jeff Dike
On Sat, Mar 03, 2007 at 12:06:20AM +0100, Miklos Szeredi wrote: > _PAGE_PROTNONE conflicts with the lowest bit of pgoff. This causes > all sorts of weirdness when nonlinear mappings are used. > > Took me a good half day to track this down. Thanks, I'll send this in.

Re: [PATCH] UML utrace support, step 1

2007-03-05 Thread Jeff Dike
tions in the signal delivery code are gone. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/exec.c |1 arch/um/kernel/process.c|6 arch/um/kernel/ptrace.c | 333 +--- arch/um/kernel/signal.c |

Re: nonlinear vma problem in uml

2007-03-05 Thread Jeff Dike
On Sat, Mar 03, 2007 at 12:06:20AM +0100, Miklos Szeredi wrote: _PAGE_PROTNONE conflicts with the lowest bit of pgoff. This causes all sorts of weirdness when nonlinear mappings are used. Took me a good half day to track this down. Thanks, I'll send this in.

Re: BUG: problems compiling UML

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 12:40:32PM +0100, mrkiko wrote: Problem: make all ARCH=um fails always on linking: it seems that a -llibname is missing. If this report is too stupid, sorry! It's not too stupid - it's too short on details. Show us the relevant portion of the build output.

Re: [PATCH] UML utrace support, step 1

2007-03-05 Thread Jeff Dike
code are gone. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/kernel/exec.c |1 arch/um/kernel/process.c|6 arch/um/kernel/ptrace.c | 333 +--- arch/um/kernel/signal.c |5 arch/um/kernel/skas/syscall.c

Re: [PATCH 01/11] uml: code convention cleanup of a file

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 09:48:59PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: From: Paolo 'Blaisorblade' Giarrusso [EMAIL PROTECTED] Fix coding conventions violations is arch/um/os-Linux/helper.c. The code which you're changing here is gone in current -mm.

Re: [PATCH 04/11] uml - hostfs: avoid possible escapes from hostfs=.

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 09:49:02PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: From: Paolo 'Blaisorblade' Giarrusso [EMAIL PROTECTED] Avoid accepting things like -o .., -o dir/../../dir2, -o dir/../.. . This may be considered useless, but YMMV. I consider that this has a limited security

Re: [PATCH 00/11] Uml simple fixes

2007-03-05 Thread Jeff Dike
On Mon, Mar 05, 2007 at 09:42:29PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: Some tested UML fixes - should be applied for 2.6.21. ACK on all of these except for 1, which won't apply to current -mm, and 4, which might need some more work. Jeff -- Work email

[PATCH 0/4] Small UML and audit.h cleanups

2007-03-05 Thread Jeff Dike
These are for 2.6.21. Three are UML cleanups, and one is adding an include to linux/audit.h. Jeff - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 1/4] linux/audit.h needs linux/types.h

2007-03-05 Thread Jeff Dike
Include linux/types.h here because we need a definition of __u32. This file appears not be exported verbatim by libc, so I think this doesn't have any userspace consequences. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- include/linux/audit.h |1 + 1 file changed, 1 insertion(+) Index

[PATCH 2/4] UML - Fix formatting violations in signal delivery code

2007-03-05 Thread Jeff Dike
Fix a few formatting bugs in the signal code. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/kernel/signal.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: test/arch/um/kernel/signal.c

[PATCH 3/4] UML - Add a debugging message

2007-03-05 Thread Jeff Dike
Add a debugging message in the case that mapping a stub fails. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/os-Linux/skas/process.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: test/arch/um/os-Linux/skas/process.c

[PATCH 4/4] UML - Comment the initialization of a global

2007-03-05 Thread Jeff Dike
Comment the fact that sig_info is initialized early in boot, and thus doesn't need any locking. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/os-Linux/trap.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.18-mm/arch/um/os-Linux/trap.c

<    7   8   9   10   11   12   13   14   15   16   >