[PATCH 3/4] UML - Fix build for !CONFIG_TCP

2007-10-31 Thread Jeff Dike
Make UML build in the absence of CONFIG_INET by making the inetaddr_notifier registration depend on it. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/net_kern.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Index: linux-2.6.22/arch/um/d

[PATCH 0/4] UML - Four fixes for 2.6.24

2007-10-31 Thread Jeff Dike
These four patches are bug and build fixes that should go into 2.6.24. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

[PATCH 4/4] UML - Fix build for !CONFIG_PRINTK

2007-10-31 Thread Jeff Dike
Handle the case of CONFIG_PRINTK being disabled. This requires a do-nothing stub to be present in arch/um/include/user.h so that we don't get references to printk from libc code. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/include/user.h | 13 - 1 file chang

[PATCH 2/4] UML - Remove last include of libc asm/page.h

2007-10-31 Thread Jeff Dike
asm/page.h is disappearing from the libc headers and we don't need it anyway. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/kernel/skas/clone.c |1 - 1 file changed, 1 deletion(-) Index: linux-2.6.22/arch/um/kernel/skas/c

[PATCH 0/4] UML - Four fixes for 2.6.24

2007-10-31 Thread Jeff Dike
These four patches are bug and build fixes that should go into 2.6.24. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 4/4] UML - Fix build for !CONFIG_PRINTK

2007-10-31 Thread Jeff Dike
Handle the case of CONFIG_PRINTK being disabled. This requires a do-nothing stub to be present in arch/um/include/user.h so that we don't get references to printk from libc code. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/include/user.h | 13 - 1 file changed, 12

[PATCH 2/4] UML - Remove last include of libc asm/page.h

2007-10-31 Thread Jeff Dike
asm/page.h is disappearing from the libc headers and we don't need it anyway. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/kernel/skas/clone.c |1 - 1 file changed, 1 deletion(-) Index: linux-2.6.22/arch/um/kernel/skas/clone.c

[PATCH 1/4] UML - Fix spurious IRQ testing

2007-10-31 Thread Jeff Dike
and the request_irq call. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/kernel/irq.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) Index: linux-2.6.22/arch/um/kernel/irq.c === --- linux-2.6.22.orig/arch/um

[PATCH 3/4] UML - Fix build for !CONFIG_TCP

2007-10-31 Thread Jeff Dike
Make UML build in the absence of CONFIG_INET by making the inetaddr_notifier registration depend on it. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/net_kern.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Index: linux-2.6.22/arch/um/drivers

Re: [PATCH 3/4] UML - Implement get_wchan

2007-10-30 Thread Jeff Dike
On Tue, Oct 30, 2007 at 10:40:46AM -0700, Joe Perches wrote: > Perhaps instead of unsigned long? > > bool skipped_ip; //delayed initialization Ooh, I forgot we had bool. I'll fix that in a later patch. Jeff -- Work email - jdike at linux dot intel dot com - To

[PATCH 0/4] UML - Four tidying patches for 2.6.25

2007-10-30 Thread Jeff Dike
These four patches are non-urgent and should wait for 2.6.25. Three of them are code cleanup and the other is an implementation of get_wchan, which no one has been complaining about. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from

[PATCH 1/4] UML - Remove xmm checking on x86

2007-10-30 Thread Jeff Dike
From: Karol Swietlicki <[EMAIL PROTECTED]> This patch removes some code which ran at every boot, but does not seem to do anything anymore. Please test. It works for me but mistakes can happen. Signed-off-by: Karol Swietlicki <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[

[PATCH 2/4] UML - Code tidying under arch/um/os-Linux

2007-10-30 Thread Jeff Dike
-errno instead of -1 ] Signed-off-by: WANG Cong <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/include/os.h| 12 ++-- arch/um/os-Linux/file.c | 14 +++--- arch/um/os-Linux/main.c | 12 arch/um/os-Linux

[PATCH 4/4] UML - get rid of asmlinkage

2007-10-30 Thread Jeff Dike
Get rid of asmlinkage and remove some old cruft from asm/linkage.h. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/sys-i386/tls.c |9 + include/asm-um/linkage.h |7 --- 2 files changed, 5 insertions(+), 11 deletions(-) Index: linux-2.6.22/arch/um/sys-i386

[PATCH 3/4] UML - Implement get_wchan

2007-10-30 Thread Jeff Dike
own context switching routine. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/kernel/process.c | 37 + include/asm-um/processor-generic.h |2 +- 2 files changed, 38 insertions(+), 1 deletion(-) Index: linux-2.6.22/arch/um/

[PATCH 4/4] UML - get rid of asmlinkage

2007-10-30 Thread Jeff Dike
Get rid of asmlinkage and remove some old cruft from asm/linkage.h. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/sys-i386/tls.c |9 + include/asm-um/linkage.h |7 --- 2 files changed, 5 insertions(+), 11 deletions(-) Index: linux-2.6.22/arch/um/sys-i386/tls.c

[PATCH 3/4] UML - Implement get_wchan

2007-10-30 Thread Jeff Dike
own context switching routine. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/kernel/process.c | 37 + include/asm-um/processor-generic.h |2 +- 2 files changed, 38 insertions(+), 1 deletion(-) Index: linux-2.6.22/arch/um/kernel

[PATCH 1/4] UML - Remove xmm checking on x86

2007-10-30 Thread Jeff Dike
From: Karol Swietlicki [EMAIL PROTECTED] This patch removes some code which ran at every boot, but does not seem to do anything anymore. Please test. It works for me but mistakes can happen. Signed-off-by: Karol Swietlicki [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um

[PATCH 2/4] UML - Code tidying under arch/um/os-Linux

2007-10-30 Thread Jeff Dike
instead of -1 ] Signed-off-by: WANG Cong [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/include/os.h| 12 ++-- arch/um/os-Linux/file.c | 14 +++--- arch/um/os-Linux/main.c | 12 arch/um/os-Linux/mem.c |5 - arch

[PATCH 0/4] UML - Four tidying patches for 2.6.25

2007-10-30 Thread Jeff Dike
These four patches are non-urgent and should wait for 2.6.25. Three of them are code cleanup and the other is an implementation of get_wchan, which no one has been complaining about. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from

Re: [PATCH 3/4] UML - Implement get_wchan

2007-10-30 Thread Jeff Dike
On Tue, Oct 30, 2007 at 10:40:46AM -0700, Joe Perches wrote: Perhaps instead of unsigned long? bool skipped_ip; //delayed initialization Ooh, I forgot we had bool. I'll fix that in a later patch. Jeff -- Work email - jdike at linux dot intel dot com - To

Re: [Git Patch] arch/um/os-Linux/: varied improvements and fixes

2007-10-29 Thread Jeff Dike
On Sun, Oct 28, 2007 at 03:38:43PM +0800, WANG Cong wrote: > This patch contains varied fixes and improvements for some files under > arch/um/os-Linux/, such as a typo fix in a perror message, a missing > argument fix for a printf, some constifying for pointers and so on. Generally looks good,

[PATCH] UML - Fix incompatible types warning in previous SG fix

2007-10-29 Thread Jeff Dike
From: WANG Cong <[EMAIL PROTECTED]> Fix an incompatible-pointer warning. Signed-off-by: WANG Cong <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/ubd_kern.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/arch/um/

[PATCH] Correctly strip kernel defines from userspace CFLAGS

2007-10-29 Thread Jeff Dike
KERNEL_DEFINES needs whitespace trimmed, otherwise the whitespace crunching done by make fools the patsubst which is used to remove KERNEL_DEFINES from USER_CFLAGS. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/Makefile |7 +-- 1 file changed, 5 insertions(+), 2 del

Re: [PATCH] x86 merge fallout: uml

2007-10-29 Thread Jeff Dike
On Mon, Oct 29, 2007 at 04:31:16AM +, Al Viro wrote: > Don't undef __i386__/__x86_64__ in uml anymore, make sure that (few) places > that required adjusting the ifdefs got those. > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Jeff Dike <[EMAIL PROTECTED]&g

Re: [PATCH] more x86 merge fallout (uml, again)

2007-10-29 Thread Jeff Dike
On Mon, Oct 29, 2007 at 04:34:31AM +, Al Viro wrote: > arch/i386/{Kconfig,Makefile}.cpu got moved > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Jeff Dike <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH] misc uml annotation and section fixes

2007-10-29 Thread Jeff Dike
On Mon, Oct 29, 2007 at 04:36:10AM +, Al Viro wrote: > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Jeff Dike <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: build failure, missing libvdeplug.h?

2007-10-29 Thread Jeff Dike
On Mon, Oct 29, 2007 at 04:24:54PM +0100, Roel Kluin wrote: > CC arch/um/drivers/vde_user.o > /home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c:8:24: > error: libvdeplug.h: No such file or directory > /home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c: In

Re: build failure, missing libvdeplug.h?

2007-10-29 Thread Jeff Dike
On Mon, Oct 29, 2007 at 04:24:54PM +0100, Roel Kluin wrote: CC arch/um/drivers/vde_user.o /home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c:8:24: error: libvdeplug.h: No such file or directory /home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c: In

Re: [PATCH] misc uml annotation and section fixes

2007-10-29 Thread Jeff Dike
On Mon, Oct 29, 2007 at 04:36:10AM +, Al Viro wrote: Signed-off-by: Al Viro [EMAIL PROTECTED] Acked-by: Jeff Dike [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] more x86 merge fallout (uml, again)

2007-10-29 Thread Jeff Dike
On Mon, Oct 29, 2007 at 04:34:31AM +, Al Viro wrote: arch/i386/{Kconfig,Makefile}.cpu got moved Signed-off-by: Al Viro [EMAIL PROTECTED] Acked-by: Jeff Dike [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH] x86 merge fallout: uml

2007-10-29 Thread Jeff Dike
On Mon, Oct 29, 2007 at 04:31:16AM +, Al Viro wrote: Don't undef __i386__/__x86_64__ in uml anymore, make sure that (few) places that required adjusting the ifdefs got those. Signed-off-by: Al Viro [EMAIL PROTECTED] Acked-by: Jeff Dike [EMAIL PROTECTED] - To unsubscribe from this list

[PATCH] UML - Fix incompatible types warning in previous SG fix

2007-10-29 Thread Jeff Dike
From: WANG Cong [EMAIL PROTECTED] Fix an incompatible-pointer warning. Signed-off-by: WANG Cong [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/ubd_kern.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/arch/um/drivers/ubd_kern.c

[PATCH] Correctly strip kernel defines from userspace CFLAGS

2007-10-29 Thread Jeff Dike
KERNEL_DEFINES needs whitespace trimmed, otherwise the whitespace crunching done by make fools the patsubst which is used to remove KERNEL_DEFINES from USER_CFLAGS. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/Makefile |7 +-- 1 file changed, 5 insertions(+), 2 deletions

Re: [Git Patch] arch/um/os-Linux/: varied improvements and fixes

2007-10-29 Thread Jeff Dike
On Sun, Oct 28, 2007 at 03:38:43PM +0800, WANG Cong wrote: This patch contains varied fixes and improvements for some files under arch/um/os-Linux/, such as a typo fix in a perror message, a missing argument fix for a printf, some constifying for pointers and so on. Generally looks good,

Re: [RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Jeff Dike
On Fri, Oct 26, 2007 at 01:38:12PM -0700, Luck, Tony wrote: > Not fundamental reasons, but these patches break the ia64 build for most > configs with: > > In file included from kernel/futex.c:59: > include/asm/futex.h: In function `futex_atomic_op_inuser': > include/asm/futex.h:62: error:

[RFC PATCH 1/2] Remove highmem.h include from pagemap.h

2007-10-26 Thread Jeff Dike
There has been a long-standing wart in linux/swap.h where it uses page_cache_release and release_pages without declaring them by including linux/pagemap.h. There is this scary comment to warn off anyone foolish enough to try to fix this: /* only sparc can not include linux/pagemap.h in

[RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Jeff Dike
For some time, there has been a problem of linux/swap.h using page_cache_release and release_pages without declaring them by including linux/pagemap.h. pagemap.h isn't included because that breaks the sparc build. The full details are in the next post, but the short story is that sparc's

[RFC PATCH 2/2] Add pagemap.h include to swap.h

2007-10-26 Thread Jeff Dike
Include linux/pagemap.h in linux/swap.h and remove the comment saying that it's not possible. --- include/linux/swap.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.17/include/linux/swap.h === ---

Re: [PROBLEM] UM does not compile on i386

2007-10-26 Thread Jeff Dike
On Fri, Oct 26, 2007 at 03:58:04PM +0300, Pekka Enberg wrote: > The current Linus' git does not compile on i386 for UM defconfig: You need this patch: http://marc.info/?l=linux-kernel=11933249601=raw Jeff -- Work email - jdike at linux dot intel dot

Re: [PROBLEM] UM does not compile on i386

2007-10-26 Thread Jeff Dike
On Fri, Oct 26, 2007 at 03:58:04PM +0300, Pekka Enberg wrote: The current Linus' git does not compile on i386 for UM defconfig: You need this patch: http://marc.info/?l=linux-kernelm=11933249601q=raw Jeff -- Work email - jdike at linux dot intel

[RFC PATCH 2/2] Add pagemap.h include to swap.h

2007-10-26 Thread Jeff Dike
Include linux/pagemap.h in linux/swap.h and remove the comment saying that it's not possible. --- include/linux/swap.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.17/include/linux/swap.h === ---

[RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Jeff Dike
For some time, there has been a problem of linux/swap.h using page_cache_release and release_pages without declaring them by including linux/pagemap.h. pagemap.h isn't included because that breaks the sparc build. The full details are in the next post, but the short story is that sparc's

[RFC PATCH 1/2] Remove highmem.h include from pagemap.h

2007-10-26 Thread Jeff Dike
There has been a long-standing wart in linux/swap.h where it uses page_cache_release and release_pages without declaring them by including linux/pagemap.h. There is this scary comment to warn off anyone foolish enough to try to fix this: /* only sparc can not include linux/pagemap.h in

Re: [RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Jeff Dike
On Fri, Oct 26, 2007 at 01:38:12PM -0700, Luck, Tony wrote: Not fundamental reasons, but these patches break the ia64 build for most configs with: In file included from kernel/futex.c:59: include/asm/futex.h: In function `futex_atomic_op_inuser': include/asm/futex.h:62: error: implicit

Re: [x86 patch] Fix UML signal.h build errors

2007-10-25 Thread Jeff Dike
On Thu, Oct 25, 2007 at 06:30:22PM +0530, Balbir Singh wrote: > Fix build errors seen in UML. Al fixed these already. FWIW, below is a rolled-up combo patch which make 2.6.24-rc1 UML build. It includes Al's build fixes, Wang Cong's driver fix, and a declaration mismatch in sched.c.

Re: [x86 patch] Fix UML signal.h build errors

2007-10-25 Thread Jeff Dike
On Thu, Oct 25, 2007 at 06:30:22PM +0530, Balbir Singh wrote: Fix build errors seen in UML. Al fixed these already. FWIW, below is a rolled-up combo patch which make 2.6.24-rc1 UML build. It includes Al's build fixes, Wang Cong's driver fix, and a declaration mismatch in sched.c.

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-24 Thread Jeff Dike
On Wed, Oct 24, 2007 at 04:46:54PM -0500, Rob Landley wrote: > Prebuilt for Ubuntu 7.04: > http://landley.net/code/firmware/downloads/cross-compiler/host-i686/cross-compiler-sparc.tar.bz2 > > Source code: > Or http://landley.net/code/firmware/downloads/firmware-0.2.2.tar.bz2 Thanks - I already

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-24 Thread Jeff Dike
On Thu, Oct 11, 2007 at 05:54:46PM -0500, Rob Landley wrote: > Guess what? I still need this patch to build the final 2.6.23, months later. > > I know it may not be the right fix, but the build breaks for me without this > patch. The .config that breaks is attached. ARCH=um. Can I get a

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-24 Thread Jeff Dike
On Wed, Oct 24, 2007 at 04:46:54PM -0500, Rob Landley wrote: Prebuilt for Ubuntu 7.04: http://landley.net/code/firmware/downloads/cross-compiler/host-i686/cross-compiler-sparc.tar.bz2 Source code: Or http://landley.net/code/firmware/downloads/firmware-0.2.2.tar.bz2 Thanks - I already got

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-24 Thread Jeff Dike
On Thu, Oct 11, 2007 at 05:54:46PM -0500, Rob Landley wrote: Guess what? I still need this patch to build the final 2.6.23, months later. I know it may not be the right fix, but the build breaks for me without this patch. The .config that breaks is attached. ARCH=um. Can I get a

Re: futex strangeness in 2.6.23-mm1/UML

2007-10-22 Thread Jeff Dike
On Mon, Oct 22, 2007 at 09:38:12PM -0400, Rik van Riel wrote: > Wrt. the UML failures that Miklos is seeing, I imagine UML needs > to do some similar tricks. UML is just an architecture - it has no need of such tricks (although it does need to keep track of host pids, but these are in

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread Jeff Dike
o fold it into this. Jeff -- Work email - jdike at linux dot intel dot com KERNEL_DEFINES needs whitespace trimmed, otherwise this whitespace crunching done by make fools the patsubst which is used to remove KERNEL_DEFINES from USER_CFLAGS. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread Jeff Dike
On Mon, Oct 22, 2007 at 01:43:22PM +0100, Al Viro wrote: > FWIW, I would simply kill the damn fastcall thing - right now the only > user is uml/i386; everything else either has it #defined to nothing or > (as i386 does) passes -mregparm=3 while having fastcall expand to >

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread Jeff Dike
On Mon, Oct 22, 2007 at 01:43:22PM +0100, Al Viro wrote: FWIW, I would simply kill the damn fastcall thing - right now the only user is uml/i386; everything else either has it #defined to nothing or (as i386 does) passes -mregparm=3 while having fastcall expand to __attribute__((regparm(3))) -

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-22 Thread Jeff Dike
it into this. Jeff -- Work email - jdike at linux dot intel dot com KERNEL_DEFINES needs whitespace trimmed, otherwise this whitespace crunching done by make fools the patsubst which is used to remove KERNEL_DEFINES from USER_CFLAGS. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/Makefile

Re: futex strangeness in 2.6.23-mm1/UML

2007-10-22 Thread Jeff Dike
On Mon, Oct 22, 2007 at 09:38:12PM -0400, Rik van Riel wrote: Wrt. the UML failures that Miklos is seeing, I imagine UML needs to do some similar tricks. UML is just an architecture - it has no need of such tricks (although it does need to keep track of host pids, but these are in architecture

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-21 Thread Jeff Dike
On Sun, Oct 21, 2007 at 07:48:54PM +0800, WANG Cong wrote: > UML still doesn't build on 2.6.23-git16. > > Gcc threw out many errors, I put them in the web: > http://wangcong.org/down/errors.txt Looks like either you need to run mrproper and try again, or maybe fallout from the x86 merge,

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-21 Thread Jeff Dike
On Sun, Oct 21, 2007 at 07:48:54PM +0800, WANG Cong wrote: UML still doesn't build on 2.6.23-git16. Gcc threw out many errors, I put them in the web: http://wangcong.org/down/errors.txt Looks like either you need to run mrproper and try again, or maybe fallout from the x86 merge, with

[PATCH] Fix wait_for_completion_interruptible declaration mismatch

2007-10-12 Thread Jeff Dike
Without the fastcall, I get a declaration mismatch between the definition here and the declaration in completion.h. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- kernel/sched.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.22/kernel/s

[PATCH] UML - header_ops conversion needed for non-ethernet drivers

2007-10-12 Thread Jeff Dike
UML's two non-ethernet drivers need some header_ops conversion. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/slip_kern.c |4 +--- arch/um/drivers/slirp_kern.c |4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) Index: linux-2.6.22/arch/um/drivers/slip_

[PATCH] Fix wait_for_completion_interruptible declaration mismatch

2007-10-12 Thread Jeff Dike
Without the fastcall, I get a declaration mismatch between the definition here and the declaration in completion.h. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- kernel/sched.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.22/kernel/sched.c

[PATCH] UML - header_ops conversion needed for non-ethernet drivers

2007-10-12 Thread Jeff Dike
UML's two non-ethernet drivers need some header_ops conversion. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/slip_kern.c |4 +--- arch/um/drivers/slirp_kern.c |4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) Index: linux-2.6.22/arch/um/drivers/slip_kern.c

Re: [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE

2007-10-09 Thread Jeff Dike
On Tue, Oct 09, 2007 at 06:34:35PM +0200, Sam Ravnborg wrote: > I actually used um as testing ground for this patch so > it works for um in my way of building um. Great, thanks. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line

Re: [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE

2007-10-09 Thread Jeff Dike
On Tue, Oct 09, 2007 at 12:00:30PM +0200, Sam Ravnborg wrote: > If it is OK to drop the $(SUBARCH) assingment like this then yes. > ARCH ?= > CROSS_COMPILE ?= Does the UML build still work when you do that? Jeff -- Work email - jdike at linux dot intel

Re: [RFC/RFT] kbuild: save ARCH CROSS_COMPILE

2007-10-09 Thread Jeff Dike
On Tue, Oct 09, 2007 at 12:00:30PM +0200, Sam Ravnborg wrote: If it is OK to drop the $(SUBARCH) assingment like this then yes. ARCH ?= CROSS_COMPILE ?= Does the UML build still work when you do that? Jeff -- Work email - jdike at linux dot intel dot

Re: [RFC/RFT] kbuild: save ARCH CROSS_COMPILE

2007-10-09 Thread Jeff Dike
On Tue, Oct 09, 2007 at 06:34:35PM +0200, Sam Ravnborg wrote: I actually used um as testing ground for this patch so it works for um in my way of building um. Great, thanks. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line

Re: [uml-devel] [PATCH 1/3] UML - Fix stub address calculations

2007-10-08 Thread Jeff Dike
On Tue, Oct 02, 2007 at 08:43:00AM +0200, Geert Uytterhoeven wrote: > Hmm, perhaps you can use _AC() (from ) to defined the original > constants instead, so you don't need the #ifdefs? Ah, neat. Those are exactly what I need. Jeff -- Work email - jdike at linux

Re: [uml-devel] [PATCH 1/3] UML - Fix stub address calculations

2007-10-08 Thread Jeff Dike
On Tue, Oct 02, 2007 at 08:43:00AM +0200, Geert Uytterhoeven wrote: Hmm, perhaps you can use _AC() (from linux/const.h) to defined the original constants instead, so you don't need the #ifdefs? Ah, neat. Those are exactly what I need. Jeff -- Work email -

[PATCH 1/3] UML - Fix stub address calculations

2007-10-01 Thread Jeff Dike
. The two stub.S files had some trailing whitespace, so that is cleaned up here. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/Kconfig.i386 | 14 -- arch/um/Kconfig.x86_64 | 14 +- arch/um/defconfig

[PATCH 3/3] UML - Definitively kill subprocesses on panic

2007-10-01 Thread Jeff Dike
e dead before the kernel exits ] Signed-off-by: Lepton Wu <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/os-Linux/skas/process.c |2 +- arch/um/os-Linux/util.c | 38 ++ 2 files changed, 39 insertions(+), 1

[PATCH 2/3] UML - arch/um/drivers formatting

2007-10-01 Thread Jeff Dike
Style fixes for the rest of the drivers. arch/um/drivers should be pretty CodingStyle-compliant now. Except for the ubd driver, which will have to be treated separately. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/chan_user.c | 18 +++-- arch/um/drivers/cow_

[PATCH 3/3] UML - Definitively kill subprocesses on panic

2007-10-01 Thread Jeff Dike
before the kernel exits ] Signed-off-by: Lepton Wu [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/os-Linux/skas/process.c |2 +- arch/um/os-Linux/util.c | 38 ++ 2 files changed, 39 insertions(+), 1 deletion(-) Index

[PATCH 2/3] UML - arch/um/drivers formatting

2007-10-01 Thread Jeff Dike
Style fixes for the rest of the drivers. arch/um/drivers should be pretty CodingStyle-compliant now. Except for the ubd driver, which will have to be treated separately. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/chan_user.c | 18 +++-- arch/um/drivers/cow_user.c

[PATCH 1/3] UML - Fix stub address calculations

2007-10-01 Thread Jeff Dike
. The two stub.S files had some trailing whitespace, so that is cleaned up here. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/Kconfig.i386 | 14 -- arch/um/Kconfig.x86_64 | 14 +- arch/um/defconfig|3

Re: [PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 11:26:34AM -0700, Andrew Morton wrote: > Doesn't this assume that the arch is only ever uniprocessor, which I > don't think is true on i386 UML?? It is for now, and when that changes, I haven't decided if and when interrupts will be received on multiple CPUs.

Re: [PATCH] use array_size macro

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 04:45:06PM +0200, Roel Kluin wrote: > Thanks for noting me. I usually pull the masters branch, so my > previously submitted patches are against that. Apparently I have to > apply the -mm patchset before sending patches. Is there a git branch > to pull from for that? I

[PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
Add _irqsave/_irqrestore to the locking in update_drop_skb to keep uml_net_rx out while the drop skb is being messed with. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/net_kern.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: linux-2.6.22/a

Re: [PATCH] use array_size macro

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 12:56:31PM +0200, Roel Kluin wrote: > arch/um/kernel/tt/ptproxy/ptrace.c | 12 ++-- I don't know what you're diffing against, but this file is history in -mm, and will be gone in mainline after 2.6.23. Jeff -- Work email -

Re: [PATCH] use array_size macro

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 12:56:31PM +0200, Roel Kluin wrote: arch/um/kernel/tt/ptproxy/ptrace.c | 12 ++-- I don't know what you're diffing against, but this file is history in -mm, and will be gone in mainline after 2.6.23. Jeff -- Work email -

Re: [PATCH] use array_size macro

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 04:45:06PM +0200, Roel Kluin wrote: Thanks for noting me. I usually pull the masters branch, so my previously submitted patches are against that. Apparently I have to apply the -mm patchset before sending patches. Is there a git branch to pull from for that? I have a

[PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
Add _irqsave/_irqrestore to the locking in update_drop_skb to keep uml_net_rx out while the drop skb is being messed with. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/net_kern.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: linux-2.6.22/arch/um/drivers

Re: [PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 11:26:34AM -0700, Andrew Morton wrote: Doesn't this assume that the arch is only ever uniprocessor, which I don't think is true on i386 UML?? It is for now, and when that changes, I haven't decided if and when interrupts will be received on multiple CPUs.

Re: [PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Jeff Dike
On Thu, Sep 27, 2007 at 04:53:40PM -0700, Andrew Morton wrote: > Still wanna know why it is safe for uml_net_rx to be playing with > drop_skb when update_drop_skb() could be concurrently reallocating > and freeing it. Ah, yes, I missed that point in the horror of my botch last night. I'll add

[PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Jeff Dike
an MTU is seen which is larger than any seen earlier. This is used to read packets if there is a memory allocation failure. The large MTU check is done from eth_configure, which is called when a interface is added to the system. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/d

[PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Jeff Dike
an MTU is seen which is larger than any seen earlier. This is used to read packets if there is a memory allocation failure. The large MTU check is done from eth_configure, which is called when a interface is added to the system. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers

Re: [PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Jeff Dike
On Thu, Sep 27, 2007 at 04:53:40PM -0700, Andrew Morton wrote: Still wanna know why it is safe for uml_net_rx to be playing with drop_skb when update_drop_skb() could be concurrently reallocating and freeing it. Ah, yes, I missed that point in the horror of my botch last night. I'll add

[PATCH 3/3] UML - Correctly handle skb allocation failures

2007-09-26 Thread Jeff Dike
interface has its MTU changed. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/net_kern.c | 60 + 1 file changed, 60 insertions(+) Index: linux-2.6.20/arch/um/drivers/net_

[PATCH 2/3] UML - Network driver MTU cleanups

2007-09-26 Thread Jeff Dike
, causing a zero-byte kmalloc and crash when the invalid pointer returned from kmalloc was dereferenced. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/daemon_kern.c| 15 +++ arch/um/drivers/daemon_user.c| 11 +--- arch/um/drivers/mcast_

[PATCH 3/3] UML - Correctly handle skb allocation failures

2007-09-26 Thread Jeff Dike
interface has its MTU changed. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/net_kern.c | 60 + 1 file changed, 60 insertions(+) Index: linux-2.6.20/arch/um/drivers/net_kern.c

[PATCH 2/3] UML - Network driver MTU cleanups

2007-09-26 Thread Jeff Dike
, causing a zero-byte kmalloc and crash when the invalid pointer returned from kmalloc was dereferenced. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/daemon_kern.c| 15 +++ arch/um/drivers/daemon_user.c| 11 +--- arch/um/drivers/mcast_kern.c

Re: [PATCH] UML - time build fix

2007-09-25 Thread Jeff Dike
On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote: > On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote: > > Put back an implementation of timeval_to_ns in > > arch/um/os-Linux/time.c. tglx pointed out in his review of tickless > > support that there

Re: [RFC PATCH] 2.6.22.6 user-mode linux: before abort, we make it sure all children quit

2007-09-25 Thread Jeff Dike
ter to make sure all of our children process to quit when user mode linux kernel abort. [ jdike - the kernel process needs to ignore SIGTERM, plus the waitpid/kill loop is needed to make sure that all of our children are dead before the kernel exits ] Signed-off-by: Lepton Wu <[EMAIL PROTEC

[PATCH] UML - time build fix

2007-09-25 Thread Jeff Dike
to be a libc version. So, I'm copying the version from linux/time.h rather than resurrecting my version. This causes some declaration changes as it now returns a signed value rather than an unsigned value. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/include/os.h|4 ++--

[PATCH] UML - time build fix

2007-09-25 Thread Jeff Dike
to be a libc version. So, I'm copying the version from linux/time.h rather than resurrecting my version. This causes some declaration changes as it now returns a signed value rather than an unsigned value. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/include/os.h|4 ++-- arch/um

Re: [RFC PATCH] 2.6.22.6 user-mode linux: before abort, we make it sure all children quit

2007-09-25 Thread Jeff Dike
process to quit when user mode linux kernel abort. [ jdike - the kernel process needs to ignore SIGTERM, plus the waitpid/kill loop is needed to make sure that all of our children are dead before the kernel exits ] Signed-off-by: Lepton Wu [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL

Re: [PATCH] UML - time build fix

2007-09-25 Thread Jeff Dike
On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote: On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote: Put back an implementation of timeval_to_ns in arch/um/os-Linux/time.c. tglx pointed out in his review of tickless support that there was a perfectly good implementation

Re: [uml-devel] [PATCH] UML - Fix irqstack crash

2007-09-24 Thread Jeff Dike
On Thu, Sep 20, 2007 at 05:57:49PM +0200, Paolo Giarrusso wrote: > Yes, indeed - or sign extension on 64bit machines would set to 1 the whole > high-word. > > But using long for that mask makes no difference; either int or long > long (or better, either u32 or u64) should be used, given that

Re: [PATCH] 2.6.22.6 user-mode linux: use address instead of value as argument in os_free_irq_by_cb

2007-09-24 Thread Jeff Dike
On Sat, Sep 22, 2007 at 12:39:55PM +0800, lepton wrote: > There is a bug in os_free_irq_by_cb, when the first element > of active_fds list is free, the value of active_fds is not > updated, just value in stack is updated. Man, that sucks. Nice spotting. > > The intresting thing is

Re: [RFC PATCH] 2.6.22.6 user-mode linux: No need to new a stack for clone without CLONE_VM

2007-09-24 Thread Jeff Dike
On Sat, Sep 22, 2007 at 11:39:32PM +0800, lepton wrote: > Since we just call clone without CLONE_VM, it is no need to > use anoymous mmap to get a new stack frame. This section of code has been converted to use fork() for this exact reason. Jeff -- Work email -

<    1   2   3   4   5   6   7   8   9   10   >