Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-24 Thread Jeff Dike
On Fri, Aug 24, 2007 at 05:20:27PM -0700, Andrew Morton wrote: This is worrisome. If you look at pagemap.h, it includes a pile of things which could easily themsleves try to include tlb.h via some path or another. I fear that this patch will cause explosions with some config and/or

Re: [PATCH 03/30] um: Don't unnecessarily cast allocation return value in ubd_kern.c

2007-08-23 Thread Jeff Dike
On Fri, Aug 24, 2007 at 01:43:49AM +0200, Jesper Juhl wrote: > vmalloc() returns a void pointer, so casting to (void *) is pretty pointless. Righto, I'll take care of this. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the

[PATCH 6/7] UML - Style fixes in FP code

2007-08-23 Thread Jeff Dike
include cleanups adding severities to printks Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/sysdep-i386/sigcontext.h | 13 --- arch/um/include/sysdep-x86_64/sigcontext.h | 28 arch/um/kernel/ptrace.c|2 arch/um/os-Linux/sy

[PATCH 1/7] UML - Don't use glibc asm/user.h

2007-08-23 Thread Jeff Dike
were needed in order to get asm/user.h to compile. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/sys-i386/user-offsets.c |6 +++--- arch/um/sys-x86_64/user-offsets.c |9 + 2 files changed, 4 insertions(+), 11 deletions(-) Index: linux-2.6.22/arch/um/sys-i38

[PATCH 5/7] UML - Sysrq and mconsole fixes

2007-08-23 Thread Jeff Dike
by adding the include back, under CONFIG_MAGIC_SYSRQ. CONFIG_MAGIC_SYSRQ is also defaulted to on in defconfig. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/defconfig |2 +- arch/um/drivers/mconsole_kern.c | 23 +-- 2 files changed, 10 inse

[PATCH 0/7] UML - Fixes for 2.6.24

2007-08-23 Thread Jeff Dike
These are for 2.6.24. They are all fixes and cleanups - signal handling, ptrace, and core dump floating point fixes mconsole and sysrq fixes build fixes code cleanup Jeff -- Work email - jdike at linux dot intel dot com - To

[PATCH 4/7] UML - coredumping floating point fixes

2007-08-23 Thread Jeff Dike
Fix core dumping of floating point state. ELF_CORE_COPY_FPREGS gets a definitions, and as a result, dump_fpu no longer needs to exist. Also, elf_fpregset_t needed a real definition. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/sys-i386/ptrace.c

[PATCH 3/7] UML - ptrace floating point fixes

2007-08-23 Thread Jeff Dike
implementations. Something here exposed a missing include in asm/page.h, which needed linux/types.h in order to get gfp_t, so that's fixed here. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/ptrace.c | 18 +++-- arch/um/sys-i386/ptrace.c

[PATCH 7/7] UML - Eliminate floating point state from register file

2007-08-23 Thread Jeff Dike
The floating point fields in the pt_regs register file aren't used, so they are deleted. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/sysdep-i386/ptrace.h |2 -- arch/um/include/sysdep-x86_64/ptrace.h |1 - 2 files changed, 3 deletions(-) Index: linux-2.6.22/a

[PATCH 2/7] UML - Floating point signal delivery fixes

2007-08-23 Thread Jeff Dike
point state around. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/registers.h|2 arch/um/include/sysdep-i386/ptrace.h |2 arch/um/include/sysdep-x86_64/ptrace.h |4 arch/um/os-Linux/registers.c |2 arch/um/os-Linux/sys-i386/regis

[PATCH 7/7] UML - Eliminate floating point state from register file

2007-08-23 Thread Jeff Dike
The floating point fields in the pt_regs register file aren't used, so they are deleted. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/sysdep-i386/ptrace.h |2 -- arch/um/include/sysdep-x86_64/ptrace.h |1 - 2 files changed, 3 deletions(-) Index: linux-2.6.22/arch/um

[PATCH 2/7] UML - Floating point signal delivery fixes

2007-08-23 Thread Jeff Dike
point state around. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/registers.h|2 arch/um/include/sysdep-i386/ptrace.h |2 arch/um/include/sysdep-x86_64/ptrace.h |4 arch/um/os-Linux/registers.c |2 arch/um/os-Linux/sys-i386/registers.c

[PATCH 4/7] UML - coredumping floating point fixes

2007-08-23 Thread Jeff Dike
Fix core dumping of floating point state. ELF_CORE_COPY_FPREGS gets a definitions, and as a result, dump_fpu no longer needs to exist. Also, elf_fpregset_t needed a real definition. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/sys-i386/ptrace.c | 22 -- include

[PATCH 3/7] UML - ptrace floating point fixes

2007-08-23 Thread Jeff Dike
implementations. Something here exposed a missing include in asm/page.h, which needed linux/types.h in order to get gfp_t, so that's fixed here. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/kernel/ptrace.c | 18 +++-- arch/um/sys-i386/ptrace.c | 73

[PATCH 0/7] UML - Fixes for 2.6.24

2007-08-23 Thread Jeff Dike
These are for 2.6.24. They are all fixes and cleanups - signal handling, ptrace, and core dump floating point fixes mconsole and sysrq fixes build fixes code cleanup Jeff -- Work email - jdike at linux dot intel dot com - To

[PATCH 6/7] UML - Style fixes in FP code

2007-08-23 Thread Jeff Dike
include cleanups adding severities to printks Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/sysdep-i386/sigcontext.h | 13 --- arch/um/include/sysdep-x86_64/sigcontext.h | 28 arch/um/kernel/ptrace.c|2 arch/um/os-Linux/sys-i386

[PATCH 1/7] UML - Don't use glibc asm/user.h

2007-08-23 Thread Jeff Dike
were needed in order to get asm/user.h to compile. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/sys-i386/user-offsets.c |6 +++--- arch/um/sys-x86_64/user-offsets.c |9 + 2 files changed, 4 insertions(+), 11 deletions(-) Index: linux-2.6.22/arch/um/sys-i386/user

[PATCH 5/7] UML - Sysrq and mconsole fixes

2007-08-23 Thread Jeff Dike
by adding the include back, under CONFIG_MAGIC_SYSRQ. CONFIG_MAGIC_SYSRQ is also defaulted to on in defconfig. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/defconfig |2 +- arch/um/drivers/mconsole_kern.c | 23 +-- 2 files changed, 10 insertions

Re: [PATCH 03/30] um: Don't unnecessarily cast allocation return value in ubd_kern.c

2007-08-23 Thread Jeff Dike
On Fri, Aug 24, 2007 at 01:43:49AM +0200, Jesper Juhl wrote: vmalloc() returns a void pointer, so casting to (void *) is pretty pointless. Righto, I'll take care of this. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the

Re: [PATCH 2/2] UML - Fix x86_64 core dump crash

2007-08-22 Thread Jeff Dike
On Wed, Aug 22, 2007 at 02:49:21PM -0700, Andrew Morton wrote: > This doesn't apply to current mainline in ways which I'm not entirely > comfortable fixing. (it assumes the presence of queued-for-2.6.24 things). Hmmm, yeah. > Does the below still work? Yup, it looks fine.

[PATCH 1/2] UML - Fix linker script alignment bugs

2007-08-22 Thread Jeff Dike
Fix a class of bugs in the UML linker scripts which caused section boundary variables to sometimes not line up with their sections. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/dyn.lds.S| 12 ++-- arch/um/kernel/uml.lds.S| 11 ++- include/asm-um/common.lds.S

[PATCH 2/2] UML - Fix x86_64 core dump crash

2007-08-22 Thread Jeff Dike
to go away. It is defined in terms of save_fp_registers, so that needs to be added. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/sys-x86_64/registers.c | 16 arch/um/sys-x86_64/ptrace.c |6 include/asm-um/elf-x86_64.h

[PATCH 0/2] UML - Fixes for 2.6.23

2007-08-22 Thread Jeff Dike
These two patches fix serious bugs, and should go into 2.6.23. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: group ownership of tun devices -- nonfunctional?

2007-08-22 Thread Jeff Dike
> I can create devices that are owned by my user account (tunctl -u > `whoami` -t tap0) and it works fine. However, if I use group > permissions with -g it stops working. In all cases, if I pass -g > , the interface is created correctly but it is unusable as a > non-root user. I can't reproduce

Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-22 Thread Jeff Dike
On Tue, Aug 21, 2007 at 07:05:53PM +0200, Blaisorblade wrote: > It's not the first time we hit effects of such bugs, is it? I don't remember seeing this before. > The .note.ABI-tag fix, time ago, may be about the same problem. Are you referring to

Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-22 Thread Jeff Dike
On Tue, Aug 21, 2007 at 07:05:53PM +0200, Blaisorblade wrote: It's not the first time we hit effects of such bugs, is it? I don't remember seeing this before. The .note.ABI-tag fix, time ago, may be about the same problem. Are you referring to

Re: group ownership of tun devices -- nonfunctional?

2007-08-22 Thread Jeff Dike
I can create devices that are owned by my user account (tunctl -u `whoami` -t tap0) and it works fine. However, if I use group permissions with -g it stops working. In all cases, if I pass -g group, the interface is created correctly but it is unusable as a non-root user. I can't reproduce

[PATCH 0/2] UML - Fixes for 2.6.23

2007-08-22 Thread Jeff Dike
These two patches fix serious bugs, and should go into 2.6.23. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2/2] UML - Fix x86_64 core dump crash

2007-08-22 Thread Jeff Dike
to go away. It is defined in terms of save_fp_registers, so that needs to be added. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/os-Linux/sys-x86_64/registers.c | 16 arch/um/sys-x86_64/ptrace.c |6 include/asm-um/elf-x86_64.h | 40

[PATCH 1/2] UML - Fix linker script alignment bugs

2007-08-22 Thread Jeff Dike
Fix a class of bugs in the UML linker scripts which caused section boundary variables to sometimes not line up with their sections. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/kernel/dyn.lds.S| 12 ++-- arch/um/kernel/uml.lds.S| 11 ++- include/asm-um/common.lds.S | 128

Re: [PATCH 2/2] UML - Fix x86_64 core dump crash

2007-08-22 Thread Jeff Dike
On Wed, Aug 22, 2007 at 02:49:21PM -0700, Andrew Morton wrote: This doesn't apply to current mainline in ways which I'm not entirely comfortable fixing. (it assumes the presence of queued-for-2.6.24 things). Hmmm, yeah. Does the below still work? Yup, it looks fine.

[PATCH 5/6] UML - Remove unneeded if from hostfs

2007-08-17 Thread Jeff Dike
Get rid of an empty if statement which might look like a bug to a casual reader. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- fs/hostfs/hostfs_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.22/fs/hostfs/hostfs_

[PATCH 6/6] UML - Fix hostfs style

2007-08-17 Thread Jeff Dike
Style fixes in hostfs. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- fs/hostfs/hostfs.h |9 + fs/hostfs/hostfs_kern.c | 226 fs/hostfs/hostfs_user.c | 139 + 3 files changed, 202 insertions(+

[PATCH 2/6] UML - Use 64-bits for block size on x86_64

2007-08-17 Thread Jeff Dike
The BLKGETSIZE ioctl expects a pointer to a long, os_file_size was providing an int. Therefore, ubd access to host block devices caused a segmentation fault on 64 bits systems. Signed-off-by: Nicolas George <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch

[PATCH 1/6] UML - Fix inlines

2007-08-17 Thread Jeff Dike
"extern inline" will have different semantics with gcc 4.3. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- include/asm-um/pgalloc.h |2 +- include/asm-um/pgtable-3level.h |2 +- include/asm-um/pro

[PATCH 3/6] UML - Userspace files should call libc directly

2007-08-17 Thread Jeff Dike
. os_print_error has no remaining callers, so it is deleted. There is a interface change to os_set_exec_close, eliminating a parameter which was always the same. The callers are fixed as well. os_process_pc got its error path cleaned up. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- a

[PATCH 4/6] UML - Clean up tlb flush path

2007-08-17 Thread Jeff Dike
, tlb.h contained a couple of declarations which had no users outside of tlb.c, so they could be moved or deleted. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/tlb.h | 27 - arch/um/kernel/tlb.c | 258 -- 2 files change

[PATCH 0/6] UML - Code cleanups for 2.6.24

2007-08-17 Thread Jeff Dike
These patches are 2.6.24 material. They are code cleanup, plus a minor bug fix. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] hostfs: Remove pointless if statement

2007-08-17 Thread Jeff Dike
On Fri, Aug 17, 2007 at 12:24:23PM +0530, Satyam Sharma wrote: > We normally use "comments" for that, not dead code that a compiler > then elids ;-) I'd argue that comments are for when you can't make the code self-explanatory. > [PATCH] hostfs: Remove pointless if statement > > And replace

Re: [PATCH] hostfs: Remove pointless if statement

2007-08-17 Thread Jeff Dike
On Fri, Aug 17, 2007 at 12:24:23PM +0530, Satyam Sharma wrote: We normally use comments for that, not dead code that a compiler then elids ;-) I'd argue that comments are for when you can't make the code self-explanatory. [PATCH] hostfs: Remove pointless if statement And replace with

[PATCH 0/6] UML - Code cleanups for 2.6.24

2007-08-17 Thread Jeff Dike
These patches are 2.6.24 material. They are code cleanup, plus a minor bug fix. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[PATCH 4/6] UML - Clean up tlb flush path

2007-08-17 Thread Jeff Dike
, tlb.h contained a couple of declarations which had no users outside of tlb.c, so they could be moved or deleted. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/tlb.h | 27 - arch/um/kernel/tlb.c | 258 -- 2 files changed, 127

[PATCH 3/6] UML - Userspace files should call libc directly

2007-08-17 Thread Jeff Dike
. os_print_error has no remaining callers, so it is deleted. There is a interface change to os_set_exec_close, eliminating a parameter which was always the same. The callers are fixed as well. os_process_pc got its error path cleaned up. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um

[PATCH 1/6] UML - Fix inlines

2007-08-17 Thread Jeff Dike
extern inline will have different semantics with gcc 4.3. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- include/asm-um/pgalloc.h |2 +- include/asm-um/pgtable-3level.h |2 +- include/asm-um/processor-x86_64.h |2 +- include/asm

[PATCH 2/6] UML - Use 64-bits for block size on x86_64

2007-08-17 Thread Jeff Dike
The BLKGETSIZE ioctl expects a pointer to a long, os_file_size was providing an int. Therefore, ubd access to host block devices caused a segmentation fault on 64 bits systems. Signed-off-by: Nicolas George [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/os-Linux/file.c

[PATCH 5/6] UML - Remove unneeded if from hostfs

2007-08-17 Thread Jeff Dike
Get rid of an empty if statement which might look like a bug to a casual reader. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- fs/hostfs/hostfs_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.22/fs/hostfs/hostfs_user.c

[PATCH 6/6] UML - Fix hostfs style

2007-08-17 Thread Jeff Dike
Style fixes in hostfs. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- fs/hostfs/hostfs.h |9 + fs/hostfs/hostfs_kern.c | 226 fs/hostfs/hostfs_user.c | 139 + 3 files changed, 202 insertions(+), 172 deletions

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
On Thu, Aug 16, 2007 at 10:04:55PM +0200, Sam Ravnborg wrote: > On Thu, Aug 16, 2007 at 03:26:39PM -0400, Jeff Dike wrote: > > > > The crash is in this section: > > > > __uml_setup_start = .; > > .uml.setup.init : { *(.uml.setup.init) } > > __

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
On Thu, Aug 16, 2007 at 09:30:56AM -0700, Arjan van de Ven wrote: > this sounds like something really stupid and bad... why would the kernel > need to have a per-distro note section??? On Thu, Aug 16, 2007 at 09:39:06AM -0700, Chris Wright wrote: > Huh!? Why do we need a SuSE section? On Thu,

[PATCH] UML - Fix previous request size limit fix

2007-08-16 Thread Jeff Dike
on the command line. However, when the command line only has the COW file specified, the fact that it's a COW file isn't known until it's opened, so the limit is missed in these cases. This patch moves the sector limit from ubd_add to ubd_open_dev. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --

[PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
[ This is both 2.6.24 and -stable material ] SuSE seems to require that binaries have a .note.SuSE section. Without it, UML segfaults if any parameters are passed on the command line. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/dyn.lds.S |1 + 1 file changed, 1 ins

Re: drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Jeff Dike
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > fs/hostfs/hostfs_user.c:if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; This one can be deleted, but I think I did it for documentation reasons, to make it clear that ctime handling wasn't left out by mistake.

Re: [PATCH] UML: BLKGETSIZE takes a long, not an int

2007-08-16 Thread Jeff Dike
On Wed, Aug 15, 2007 at 11:38:25PM +0200, Nicolas George wrote: > Here is the hopefully correct patch, against current git. Thanks, I'll forward it upstream. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line

Re: [PATCH] UML: BLKGETSIZE takes a long, not an int

2007-08-16 Thread Jeff Dike
On Wed, Aug 15, 2007 at 11:38:25PM +0200, Nicolas George wrote: Here is the hopefully correct patch, against current git. Thanks, I'll forward it upstream. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line

Re: drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Jeff Dike
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: fs/hostfs/hostfs_user.c:if(attrs-ia_valid HOSTFS_ATTR_CTIME) ; This one can be deleted, but I think I did it for documentation reasons, to make it clear that ctime handling wasn't left out by mistake.

[PATCH] UML - Fix previous request size limit fix

2007-08-16 Thread Jeff Dike
on the command line. However, when the command line only has the COW file specified, the fact that it's a COW file isn't known until it's opened, so the limit is missed in these cases. This patch moves the sector limit from ubd_add to ubd_open_dev. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um

[PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
[ This is both 2.6.24 and -stable material ] SuSE seems to require that binaries have a .note.SuSE section. Without it, UML segfaults if any parameters are passed on the command line. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/kernel/dyn.lds.S |1 + 1 file changed, 1 insertion

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
On Thu, Aug 16, 2007 at 09:30:56AM -0700, Arjan van de Ven wrote: this sounds like something really stupid and bad... why would the kernel need to have a per-distro note section??? On Thu, Aug 16, 2007 at 09:39:06AM -0700, Chris Wright wrote: Huh!? Why do we need a SuSE section? On Thu, Aug

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
On Thu, Aug 16, 2007 at 10:04:55PM +0200, Sam Ravnborg wrote: On Thu, Aug 16, 2007 at 03:26:39PM -0400, Jeff Dike wrote: The crash is in this section: __uml_setup_start = .; .uml.setup.init : { *(.uml.setup.init) } __uml_setup_end = .; This looks like a classic bug. You

Re: UML/man: BLKGETSIZE takes a long, not an int

2007-08-15 Thread Jeff Dike
On Mon, Aug 13, 2007 at 02:42:47PM +0200, Nicolas George wrote: > I found a type mismatch in UML that makes host block devices unusable as ubd > devices on x86_64 and other 64 bits systems (segfault of the mm subsystem): Looks sane, can I have a properly Signed-off-by: version of the patch?

Re: [2.6 patch] UML: "extern inline" -> "static inline"

2007-08-15 Thread Jeff Dike
On Tue, Aug 14, 2007 at 11:25:33PM +0200, Adrian Bunk wrote: > "extern inline" will have different semantics with gcc 4.3. Thanks, I'll send this in. BTW, I killed off CONFIG_MODE_TT yesterday. Jeff -- Work email - jdike at linux dot intel dot com - To

Re: [2.6 patch] UML: extern inline - static inline

2007-08-15 Thread Jeff Dike
On Tue, Aug 14, 2007 at 11:25:33PM +0200, Adrian Bunk wrote: extern inline will have different semantics with gcc 4.3. Thanks, I'll send this in. BTW, I killed off CONFIG_MODE_TT yesterday. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe

Re: UML/man: BLKGETSIZE takes a long, not an int

2007-08-15 Thread Jeff Dike
On Mon, Aug 13, 2007 at 02:42:47PM +0200, Nicolas George wrote: I found a type mismatch in UML that makes host block devices unusable as ubd devices on x86_64 and other 64 bits systems (segfault of the mm subsystem): Looks sane, can I have a properly Signed-off-by: version of the patch?

[PATCH 3/14] UML - Style fixes pass 1

2007-08-14 Thread Jeff Dike
These changes should be entirely non-functional. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/Kconfig | 199 +++ arch/um/Kconfig.char | 139 ++--- arch/um/Kconfig.debug

[PATCH 11/14] UML - Rename pt_regs general-purpose register file

2007-08-14 Thread Jeff Dike
, the last field is renamed to "gp". Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/sysdep-i386/ptrace.h | 36 +- arch/um/include/sysdep-x86_64/ptrace.h | 60 +++--- arch/um/kernel/process.c |4 +- arc

[PATCH 10/14] UML - Fold mmu_context_skas into mm_context

2007-08-14 Thread Jeff Dike
This patch folds mmu_context_skas into struct mm_context, changing all users of these structures as needed. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/skas/mmu-skas.h | 23 - arch/um/include/tlb.h |2 - arch/um/include/um

[PATCH 4/14] UML - Throw out CHOOSE_MODE

2007-08-14 Thread Jeff Dike
invocations with the skas branch. This leaves a number of trivial functions which will be dealt with in a later patch. There are some changes in the uaccess and tls support which go somewhat beyond this and eliminate some of the now-redundant functions. Signed-off-by: Jeff Dike <[EMAIL PROTEC

[PATCH 14/14] UML - Replace clone with fork

2007-08-14 Thread Jeff Dike
Convert the boot-time host ptrace testing from clone to fork. They were essentially doing fork anyway. This cleans up the code a bit, and makes valgrind a bit happier about grinding it. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/start_up.c

[PATCH 5/14] UML - Style fixes pass 2

2007-08-14 Thread Jeff Dike
Formatting changes in the files which have been changed in the course of removing CHOOSE_MODE. These include: copyright updates header file trimming style fixes adding severity to printks These changes should be entirely non-functional. Signed-off-by: Jeff Dike

[PATCH 13/14] UML - Remove os_* usage from userspace files

2007-08-14 Thread Jeff Dike
This patch fixes some userspace files which were calling libc through the os_* wrappers. It turns out that there was only one user of os_new_tty_pgrp, so it can be deleted. There are also some style and whitespace fixes in here. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/d

[PATCH 2/14] UML - Remove sysdep/thread.h

2007-08-14 Thread Jeff Dike
This patch removes thread.h, which turns out not to be needed any more. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/sysdep-i386/kernel-offsets.h |1 - arch/um/include/sysdep-i386/sigcontext.h |3 ++- arch/um/include/sysdep-i386/thread.h

[PATCH 8/14] UML - Remove __u64 usage from physical memory subsystem

2007-08-14 Thread Jeff Dike
-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/mem.h | 21 ++--- arch/um/kernel/physmem.c|2 +- arch/um/os-Linux/skas/process.c |6 +++--- 3 files changed, 6 insertions(+), 23 deletions(-) Index: linux-2.6.22/arch/um/include

[PATCH 0/14] UML - Get rid of tt mode

2007-08-14 Thread Jeff Dike
This set of patches is 2.6.24 material. It throws out tt mode, which has been non-functional for a while. This is done in phases, interspersed with code cleanups on the affected files. The removal is done as follows: remove all code, config options, and files which depend on

[PATCH 9/14] UML - Get rid of do_longjmp

2007-08-14 Thread Jeff Dike
to kernel code. This is gone, and a number of void * pointers can now be jmp_buf *. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/os.h |5 ++--- arch/um/include/um_uaccess.h |4 arch/um/include/uml_uaccess.h | 24

[PATCH 12/14] UML - Free LDT state on process exit

2007-08-14 Thread Jeff Dike
The space allocated for a process LDT wasn't being freed when the process exited. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/skas/mmu.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.22/arch/um/kernel/skas

[PATCH 12/14] UML - Free LDT state on process exit

2007-08-14 Thread Jeff Dike
The space allocated for a process LDT wasn't being freed when the process exited. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/kernel/skas/mmu.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.22/arch/um/kernel/skas/mmu.c

[PATCH 0/14] UML - Get rid of tt mode

2007-08-14 Thread Jeff Dike
This set of patches is 2.6.24 material. It throws out tt mode, which has been non-functional for a while. This is done in phases, interspersed with code cleanups on the affected files. The removal is done as follows: remove all code, config options, and files which depend on

[PATCH 2/14] UML - Remove sysdep/thread.h

2007-08-14 Thread Jeff Dike
This patch removes thread.h, which turns out not to be needed any more. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/sysdep-i386/kernel-offsets.h |1 - arch/um/include/sysdep-i386/sigcontext.h |3 ++- arch/um/include/sysdep-i386/thread.h |8 arch

[PATCH 8/14] UML - Remove __u64 usage from physical memory subsystem

2007-08-14 Thread Jeff Dike
-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/mem.h | 21 ++--- arch/um/kernel/physmem.c|2 +- arch/um/os-Linux/skas/process.c |6 +++--- 3 files changed, 6 insertions(+), 23 deletions(-) Index: linux-2.6.22/arch/um/include/mem.h

[PATCH 13/14] UML - Remove os_* usage from userspace files

2007-08-14 Thread Jeff Dike
This patch fixes some userspace files which were calling libc through the os_* wrappers. It turns out that there was only one user of os_new_tty_pgrp, so it can be deleted. There are also some style and whitespace fixes in here. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers

[PATCH 5/14] UML - Style fixes pass 2

2007-08-14 Thread Jeff Dike
Formatting changes in the files which have been changed in the course of removing CHOOSE_MODE. These include: copyright updates header file trimming style fixes adding severity to printks These changes should be entirely non-functional. Signed-off-by: Jeff Dike

[PATCH 9/14] UML - Get rid of do_longjmp

2007-08-14 Thread Jeff Dike
to kernel code. This is gone, and a number of void * pointers can now be jmp_buf *. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/os.h |5 ++--- arch/um/include/um_uaccess.h |4 arch/um/include/uml_uaccess.h | 24 arch/um

[PATCH 14/14] UML - Replace clone with fork

2007-08-14 Thread Jeff Dike
Convert the boot-time host ptrace testing from clone to fork. They were essentially doing fork anyway. This cleans up the code a bit, and makes valgrind a bit happier about grinding it. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/os-Linux/start_up.c | 55

[PATCH 4/14] UML - Throw out CHOOSE_MODE

2007-08-14 Thread Jeff Dike
invocations with the skas branch. This leaves a number of trivial functions which will be dealt with in a later patch. There are some changes in the uaccess and tls support which go somewhat beyond this and eliminate some of the now-redundant functions. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch

[PATCH 10/14] UML - Fold mmu_context_skas into mm_context

2007-08-14 Thread Jeff Dike
This patch folds mmu_context_skas into struct mm_context, changing all users of these structures as needed. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/skas/mmu-skas.h | 23 - arch/um/include/tlb.h |2 - arch/um/include/um_mmu.h| 18

[PATCH 11/14] UML - Rename pt_regs general-purpose register file

2007-08-14 Thread Jeff Dike
field is renamed to gp. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/include/sysdep-i386/ptrace.h | 36 +- arch/um/include/sysdep-x86_64/ptrace.h | 60 +++--- arch/um/kernel/process.c |4 +- arch/um/kernel/skas/syscall.c

[PATCH 3/14] UML - Style fixes pass 1

2007-08-14 Thread Jeff Dike
These changes should be entirely non-functional. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/Kconfig | 199 +++ arch/um/Kconfig.char | 139 ++--- arch/um/Kconfig.debug| 24 +-- arch

[PATCH] UML - Add VDE networking support

2007-08-08 Thread Jeff Dike
[ This is 2.6.24 material ] Added vde network backend in uml to introduce native Virtual Distributed Ethernet support (using libvdeplug). [ jdike - minor cleanups ] Signed-Off-By: Luca Bigliardi <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um

[PATCH] UML - Add VDE networking support

2007-08-08 Thread Jeff Dike
[ This is 2.6.24 material ] Added vde network backend in uml to introduce native Virtual Distributed Ethernet support (using libvdeplug). [ jdike - minor cleanups ] Signed-Off-By: Luca Bigliardi [EMAIL PROTECTED] Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/Kconfig.net| 22

Re: RFC: UML: remove MODE_TT?

2007-08-03 Thread Jeff Dike
On Sat, Jul 28, 2007 at 05:47:05PM +0200, Adrian Bunk wrote: > MODE_TT is still marked as broken and still not compiling... > > Will anyone fix it or can it finally be removed? I guess it should finally be removed... I have a patch which does that - I'll see how easily it moves to the bottom of

[PATCH 2/2] UML - Console tidying

2007-08-03 Thread Jeff Dike
Tidy line.c: The includes are more minimal Lots of style fixes All the printks have severities Removed some commented-out code Deleted a useless printk when ioctl is called Fixed some whitespace damage Signed-off-by: Jeff Dike <[EMAIL PROTEC

[PATCH 1/2] UML - Fix console writing bugs

2007-08-03 Thread Jeff Dike
for zero-length writes. Calling libc write with a length of zero conflated write not being able to write anything with asking it not to write anything. Better to just cut it off as soon as possible. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/chan_kern.c |3 +++ a

[PATCH 0/2] UML - Console fixes and cleanups for 2.6.24

2007-08-03 Thread Jeff Dike
These two patches fix the console write error that Miklos reported and tidy up the code while I was in there. They should hold off for 2.6.24 - the code with the bug that's being fixed is also being held for 2.6.24. Jeff -- Work email - jdike at linux dot intel

Re: UML: write errors on terminal

2007-08-03 Thread Jeff Dike
On Fri, Aug 03, 2007 at 01:45:29PM +0200, Miklos Szeredi wrote: > I get errors in uml when writing to the xterm console. For example if I do > > $ cat bigfile > [some output] > cat: write error: Operation not permitted > > This is 2.6.23-rc1-mm2, I haven't yet checked other versions. Rats, I

Re: UML: write errors on terminal

2007-08-03 Thread Jeff Dike
On Fri, Aug 03, 2007 at 01:45:29PM +0200, Miklos Szeredi wrote: I get errors in uml when writing to the xterm console. For example if I do $ cat bigfile [some output] cat: write error: Operation not permitted This is 2.6.23-rc1-mm2, I haven't yet checked other versions. Rats, I fixed

[PATCH 0/2] UML - Console fixes and cleanups for 2.6.24

2007-08-03 Thread Jeff Dike
These two patches fix the console write error that Miklos reported and tidy up the code while I was in there. They should hold off for 2.6.24 - the code with the bug that's being fixed is also being held for 2.6.24. Jeff -- Work email - jdike at linux dot intel

[PATCH 2/2] UML - Console tidying

2007-08-03 Thread Jeff Dike
Tidy line.c: The includes are more minimal Lots of style fixes All the printks have severities Removed some commented-out code Deleted a useless printk when ioctl is called Fixed some whitespace damage Signed-off-by: Jeff Dike [EMAIL PROTECTED

[PATCH 1/2] UML - Fix console writing bugs

2007-08-03 Thread Jeff Dike
for zero-length writes. Calling libc write with a length of zero conflated write not being able to write anything with asking it not to write anything. Better to just cut it off as soon as possible. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- arch/um/drivers/chan_kern.c |3 +++ arch/um

Re: RFC: UML: remove MODE_TT?

2007-08-03 Thread Jeff Dike
On Sat, Jul 28, 2007 at 05:47:05PM +0200, Adrian Bunk wrote: MODE_TT is still marked as broken and still not compiling... Will anyone fix it or can it finally be removed? I guess it should finally be removed... I have a patch which does that - I'll see how easily it moves to the bottom of my

[PATCH 2/6] UML - Fix an IPV6 libc vs kernel symbol clash

2007-08-02 Thread Jeff Dike
On some systems, with IPV6 configured, there is a clash between the kernel's in6addr_any and the one in libc. This is handled in the usual (gross) way of defining the kernel symbol out of the way on the gcc command line. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/Makefile

<    2   3   4   5   6   7   8   9   10   11   >