. If that's removed, this header
can be deleted.
This uncovered a bug in user.h, which wasn't correctly making sure
that a size_t definition was available to both userspace and
kernelspace files.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/include/os.h|2
a
Tidying of the UML physical memory system. These are mostly style
fixes, however the includes were cleaned as well. This uncovered a
need for mem_user.h to be included in mode_kern_skas.h.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/include/skas/mode_kern_skas.h |3 +-
a
The UML watchdog driver was using the wrong config variable to control
whether it can be unloaded once active.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/drivers/harddog_kern.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.21-mm/arch/um/d
Map all of physical memory as executable to avoid having to change
stack protections during fork and exit.
unprotect_stack is now called only from MODE_TT code, so it is marked
as such.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/include/kern_util.h |2 ++
arch/um/
These are more cleanups and small fixes. They should wait for 2.6.24.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Remove includes of asm/page.h from libc code. This header seems to be
disappearing, and UML doesn't make much use of it anyway.
The one use, PAGE_SHIFT in stub.h, is handled by copying the constant
from the kernel side of the house in common_offsets.h.
Signed-off-by: Jeff Dike <[EMAIL PROTEC
Remove includes of asm/page.h from libc code. This header seems to be
disappearing, and UML doesn't make much use of it anyway.
The one use, PAGE_SHIFT in stub.h, is handled by copying the constant
from the kernel side of the house in common_offsets.h.
Signed-off-by: Jeff Dike [EMAIL PROTECTED
Map all of physical memory as executable to avoid having to change
stack protections during fork and exit.
unprotect_stack is now called only from MODE_TT code, so it is marked
as such.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/include/kern_util.h |2 ++
arch/um/kernel
These are more cleanups and small fixes. They should wait for 2.6.24.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info
The UML watchdog driver was using the wrong config variable to control
whether it can be unloaded once active.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/drivers/harddog_kern.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.21-mm/arch/um/drivers
Tidying of the UML physical memory system. These are mostly style
fixes, however the includes were cleaned as well. This uncovered a
need for mem_user.h to be included in mode_kern_skas.h.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/include/skas/mode_kern_skas.h |3 +-
arch/um
. If that's removed, this header
can be deleted.
This uncovered a bug in user.h, which wasn't correctly making sure
that a size_t definition was available to both userspace and
kernelspace files.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/include/os.h|2
arch/um
On some systems, with IPV6 configured, there is a clash between the
kernel's in6addr_any and the one in libc.
This is handled in the usual (gross) way of defining the kernel symbol
out of the way on the gcc command line.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/Makefile |3
On Sun, Jul 29, 2007 at 03:50:59AM +0300, Eduard-Gabriel Munteanu wrote:
> Jeff Dike wrote:
> >The previous DEBUG_SHIRQ patch missed one case. The console doesn't
> >set its host descriptors non-blocking.
>
> Sorry, things looked okay when I tested on my UML environment (
Move some code from a kernelspace file to a userspace file where it
fits better. This enables some tidying which is the subject of a
later patch.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/drivers/chan_kern.c | 48 ---
arch/um/d
xterm_free is gone, as it was identical to generic_free
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/drivers/chan_kern.c | 160 ++--
arch/um/drivers/chan_user.c | 113 ---
arch/um/drivers/fd.c
I messed up the error cleanup ordering in the console port driver.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/drivers/port_kern.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.21-mm/arch/um/drivers/port_
These patches resulting from noticing a lot of cleanups needed in the
UML console system while fixing the previous spurious interrupt
testing.
There is one minor bug fix - a misordering of the error cleanups in
one of the drivers.
These are for 2.6.24.
Jeff
--
Now that the generic console operations are in a userspace file, we
can do the following:
directly call into libc instead of through the os_* wrappers
eliminate os_window_size since it has only one user
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/drivers/chan_
These patches resulting from noticing a lot of cleanups needed in the
UML console system while fixing the previous spurious interrupt
testing.
There is one minor bug fix - a misordering of the error cleanups in
one of the drivers.
These are for 2.6.24.
Jeff
--
Now that the generic console operations are in a userspace file, we
can do the following:
directly call into libc instead of through the os_* wrappers
eliminate os_window_size since it has only one user
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/drivers/chan_user.c
I messed up the error cleanup ordering in the console port driver.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/drivers/port_kern.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.21-mm/arch/um/drivers/port_kern.c
xterm_free is gone, as it was identical to generic_free
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/drivers/chan_kern.c | 160 ++--
arch/um/drivers/chan_user.c | 113 ---
arch/um/drivers/fd.c| 74
Move some code from a kernelspace file to a userspace file where it
fits better. This enables some tidying which is the subject of a
later patch.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/drivers/chan_kern.c | 48 ---
arch/um/drivers
On Sun, Jul 29, 2007 at 03:50:59AM +0300, Eduard-Gabriel Munteanu wrote:
Jeff Dike wrote:
The previous DEBUG_SHIRQ patch missed one case. The console doesn't
set its host descriptors non-blocking.
Sorry, things looked okay when I tested on my UML environment (Puppy
Linux). Some xterms
On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote:
> When comparing a pointer, it's clearer to compare it to NULL than to 0.
ACK
> sys-i386/fault.c |2 +-
> sys-x86_64/fault.c |2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Except you should probably diff from
The previous DEBUG_SHIRQ patch missed one case. The console doesn't
set its host descriptors non-blocking.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/drivers/chan_kern.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
Index: linux-2.6.21-mm/arch/um/d
On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote:
When comparing a pointer, it's clearer to compare it to NULL than to 0.
ACK
sys-i386/fault.c |2 +-
sys-x86_64/fault.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Except you should probably diff from the
The previous DEBUG_SHIRQ patch missed one case. The console doesn't
set its host descriptors non-blocking.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/drivers/chan_kern.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
Index: linux-2.6.21-mm/arch/um/drivers
On Tue, Jul 24, 2007 at 08:22:53AM +0300, Avi Kivity wrote:
> Even in the current model, guest physical memory is mmap()ed into host
> userspace.
I want it to be identity-mapped, which a single address space would
guarantee. For things which change mappings, like vmalloc, I need to
be in the
On Tue, Jul 24, 2007 at 08:22:53AM +0300, Avi Kivity wrote:
Even in the current model, guest physical memory is mmap()ed into host
userspace.
I want it to be identity-mapped, which a single address space would
guarantee. For things which change mappings, like vmalloc, I need to
be in the same
On Mon, Jul 23, 2007 at 01:27:40PM +0300, Avi Kivity wrote:
> Having an address_space (like your patch does) is remarkably simple, and
> requires few hooks from the current vm. However using existing vmas
> mapped by the user has many advantages:
It's also needed for a SKAS-like UML client,
by which it allocated memory, checking whether it was OK
to use kmalloc (at this point in the boot, it definitely isn't) and
using either alloc_bootmem_low_pages or kmalloc/vmalloc. So, the
kmalloc/vmalloc code is removed.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/d
.
hoisting a duplicated line out of the switch.
simplifying the error checking at the end.
I added a severity to the printk.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/os-Linux/aio.c | 47 +--
1 file changed, 17 inse
case, so this logic is not needed.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/os-Linux/user_syms.c |5 +
arch/um/sys-i386/Makefile|2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
Index: linux-2.6.17/arch/um/sys-i386/Ma
These fix various build problems that cropped up in -rc1, and they
should go into 2.6.23.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
case, so this logic is not needed.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/os-Linux/user_syms.c |5 +
arch/um/sys-i386/Makefile|2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
Index: linux-2.6.17/arch/um/sys-i386/Makefile
These fix various build problems that cropped up in -rc1, and they
should go into 2.6.23.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
by which it allocated memory, checking whether it was OK
to use kmalloc (at this point in the boot, it definitely isn't) and
using either alloc_bootmem_low_pages or kmalloc/vmalloc. So, the
kmalloc/vmalloc code is removed.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/drivers/mconsole_kern.c
.
hoisting a duplicated line out of the switch.
simplifying the error checking at the end.
I added a severity to the printk.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/os-Linux/aio.c | 47 +--
1 file changed, 17 insertions
On Mon, Jul 23, 2007 at 01:27:40PM +0300, Avi Kivity wrote:
Having an address_space (like your patch does) is remarkably simple, and
requires few hooks from the current vm. However using existing vmas
mapped by the user has many advantages:
It's also needed for a SKAS-like UML client, where
On Fri, Jul 20, 2007 at 02:01:16AM +0100, Al Viro wrote:
> Change in 'kbuild: do section mismatch check on full vmlinux'
> should've been replicated in arch/um/Makefile.
ACK
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line
On Thu, Jul 19, 2007 at 11:10:54PM -0700, Zachary Amsden wrote:
> I'm rather indifferent on the matter, but I think a virtualization menu
> under UML would be very confusing.
Yeah, that would be interesting. Trying to get one menu, with
switches that the arch can turn on and off, seems to make
On Thu, Jul 19, 2007 at 11:10:54PM -0700, Zachary Amsden wrote:
I'm rather indifferent on the matter, but I think a virtualization menu
under UML would be very confusing.
Yeah, that would be interesting. Trying to get one menu, with
switches that the arch can turn on and off, seems to make
On Fri, Jul 20, 2007 at 02:01:16AM +0100, Al Viro wrote:
Change in 'kbuild: do section mismatch check on full vmlinux'
should've been replicated in arch/um/Makefile.
ACK
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line
On Wed, Jul 18, 2007 at 11:28:18AM -0500, Anthony Liguori wrote:
> Within the kernel right (VMCALL is only usable in ring 1).
Yup.
> Is it
> terribly important to be able to pass through the syscall arguments in
> registers verses packing them in a data structure and passing a pointer
> to
On Wed, Jul 18, 2007 at 11:28:18AM -0500, Anthony Liguori wrote:
Within the kernel right (VMCALL is only usable in ring 1).
Yup.
Is it
terribly important to be able to pass through the syscall arguments in
registers verses packing them in a data structure and passing a pointer
to that
On Tue, Jul 17, 2007 at 03:22:16PM +0200, Geert Uytterhoeven wrote:
> I saw this patch went in.
>
> iomap_copy.o ues the raw I/O memory accessors, so it truly depends on
> CONFIG_HAS_IOMEM.
This works for UML.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To
On Tue, Jul 17, 2007 at 08:49:35AM +0100, Al Viro wrote:
>
> Signed-off-by: Al Viro <[EMAIL PROTECTED]>
ACK.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
On Tue, Jul 17, 2007 at 11:12:53AM +0300, Avi Kivity wrote:
> I believe that emulate_instruction will set run->mmio if it returns
> EMULATE_DO_MMIO.
Righto, forgot to check that. How about this patch instead?
Set exit_reason to KVM_EXIT_MMIO where run->mmio is initialized.
Signed-
On Tue, Jul 17, 2007 at 09:15:51AM -0500, Anthony Liguori wrote:
> I'm planning on breaking this interface again since the new hypercall
> API only takes 4 arguments instead of 6.
Is anything written anywhere about this hypercall interface?
The thing which would make me happy (which the current
On Tue, Jul 17, 2007 at 09:15:51AM -0500, Anthony Liguori wrote:
I'm planning on breaking this interface again since the new hypercall
API only takes 4 arguments instead of 6.
Is anything written anywhere about this hypercall interface?
The thing which would make me happy (which the current
On Tue, Jul 17, 2007 at 11:12:53AM +0300, Avi Kivity wrote:
I believe that emulate_instruction will set run-mmio if it returns
EMULATE_DO_MMIO.
Righto, forgot to check that. How about this patch instead?
Set exit_reason to KVM_EXIT_MMIO where run-mmio is initialized.
Signed-off-by: Jeff
On Tue, Jul 17, 2007 at 08:49:35AM +0100, Al Viro wrote:
Signed-off-by: Al Viro [EMAIL PROTECTED]
ACK.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
On Tue, Jul 17, 2007 at 03:22:16PM +0200, Geert Uytterhoeven wrote:
I saw this patch went in.
iomap_copy.o ues the raw I/O memory accessors, so it truly depends on
CONFIG_HAS_IOMEM.
This works for UML.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe
Add the hypercall number to kvm_run and initialize it. This might be
considered API-changing, so I kept it separate.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
drivers/kvm/kvm_main.c |1 +
include/linux/kvm.h|1 +
2 files changed, 2 insertions(+)
Index: kvm/drive
ing initializations of hardware_exit_reason with
KVM_EXIT_UNKNOWN, so I added those. One case had exit_reason = 0,
which I changed to KVM_EXIT_UNKNOWN.
I did a pass over all of the return 0 paths in the exit handler
callbacks, so this should cover everything.
Signed-off-by: Jeff Dike <[EMAIL PRO
It looks like kvm_hypercall is trying to match the system call
convention and mixed up the call number and first argument in the
32-bit case.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
drivers/kvm/kvm_main.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: kvm/d
It looks like kvm_hypercall is trying to match the system call
convention and mixed up the call number and first argument in the
32-bit case.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
drivers/kvm/kvm_main.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: kvm/drivers/kvm
initializations of hardware_exit_reason with
KVM_EXIT_UNKNOWN, so I added those. One case had exit_reason = 0,
which I changed to KVM_EXIT_UNKNOWN.
I did a pass over all of the return 0 paths in the exit handler
callbacks, so this should cover everything.
Signed-off-by: Jeff Dike [EMAIL PROTECTED
Add the hypercall number to kvm_run and initialize it. This might be
considered API-changing, so I kept it separate.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
drivers/kvm/kvm_main.c |1 +
include/linux/kvm.h|1 +
2 files changed, 2 insertions(+)
Index: kvm/drivers/kvm
On Fri, Jul 13, 2007 at 08:00:13PM +0100, Nix wrote:
> This feels like a -stable candidate to me.
Right you are - that's the first place I sent it.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe
COWed devices can't handle more than 32 (64 on x86_64) sectors in one
request due to the size of the bitmap being carried around in the
io_thread_req.
Enforce that by telling the block layer not to put too many sectors in
requests to COWed devices.
Signed-off-by: Jeff Dike <[EMAIL PROTEC
Add some exports for hostfs that are required after Alberto Bertogli's
fixes for accessing unlinked host files.
Also did some style cleanups while I was here.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/os-Linux/user_syms.c | 20
1 file changed, 8 inse
I forgot this file was here. It hasn't been used since UML has been
in mainline.
Thanks to Jesper for finding something that needed doing to it, thus
reminding me of its existence.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/config.release
I forgot this file was here. It hasn't been used since UML has been
in mainline.
Thanks to Jesper for finding something that needed doing to it, thus
reminding me of its existence.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/config.release | 333
COWed devices can't handle more than 32 (64 on x86_64) sectors in one
request due to the size of the bitmap being carried around in the
io_thread_req.
Enforce that by telling the block layer not to put too many sectors in
requests to COWed devices.
Signed-off-by: Jeff Dike [EMAIL PROTECTED
Add some exports for hostfs that are required after Alberto Bertogli's
fixes for accessing unlinked host files.
Also did some style cleanups while I was here.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/os-Linux/user_syms.c | 20
1 file changed, 8 insertions
On Fri, Jul 13, 2007 at 08:00:13PM +0100, Nix wrote:
This feels like a -stable candidate to me.
Right you are - that's the first place I sent it.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line unsubscribe
COWed devices can't handle more than 32 (64 on x86_64) sectors in one
request due to the size of the bitmap being carried around in the
io_thread_req.
Enforce that by telling the block layer not to put too many sectors in
requests to COWed devices.
Signed-off-by: Jeff Dike <[EMAIL PROTEC
Add some exports for hostfs that are required after Alberto Bertogli's
fixes for accessing unlinked host files.
Also did some style cleanups while I was here.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/os-Linux/user_syms.c | 20
1 file changed, 8 inse
COWed devices can't handle more than 32 (64 on x86_64) sectors in one
request due to the size of the bitmap being carried around in the
io_thread_req.
Enforce that by telling the block layer not to put too many sectors in
requests to COWed devices.
Signed-off-by: Jeff Dike [EMAIL PROTECTED
Add some exports for hostfs that are required after Alberto Bertogli's
fixes for accessing unlinked host files.
Also did some style cleanups while I was here.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/os-Linux/user_syms.c | 20
1 file changed, 8 insertions
On Fri, Jul 06, 2007 at 12:51:27PM -0700, Jeremy Fitzhardinge wrote:
> The virtual CPU code has been competely rewritten since then. If its a
> non-gcc generated instruction, its possible the new code
> parser/generator hasn't been taught to deal with it.
It's not from gcc - it's from the i386
On Fri, Jul 06, 2007 at 10:30:19AM -0700, Dan Kegel wrote:
> Could you give it a shot?
OK, after ripping out the code that broke valgrind last time (patch
below), I get this:
==27590== Warning: set address range perms: large range 516194304, a 0, v 0
vex x86->IR: unhandled instruction bytes:
On Fri, Jul 06, 2007 at 11:00:46AM -0700, Jeremy Fitzhardinge wrote:
> >UML is cloning a thread in order to test the host's ptrace. However,
> >it looks like valgrind is branching to 0x9 for some reason.
> >
>
> How far into the run does this happen? Immediately, or after a while?
This is
On Thu, Jul 05, 2007 at 10:44:05PM -0700, Jeremy Fitzhardinge wrote:
> Dan Kegel wrote:
> >It'd be nice to see if Valgrind could catch uninitialized
> >references in the kernel, if only to see if Coverity is
> >missing anything that happens in practice.
> >
> >Back in December 2002, Valgrind
On Thu, Jul 05, 2007 at 10:44:05PM -0700, Jeremy Fitzhardinge wrote:
Dan Kegel wrote:
It'd be nice to see if Valgrind could catch uninitialized
references in the kernel, if only to see if Coverity is
missing anything that happens in practice.
Back in December 2002, Valgrind started to run
On Fri, Jul 06, 2007 at 11:00:46AM -0700, Jeremy Fitzhardinge wrote:
UML is cloning a thread in order to test the host's ptrace. However,
it looks like valgrind is branching to 0x9 for some reason.
How far into the run does this happen? Immediately, or after a while?
This is pretty
On Fri, Jul 06, 2007 at 10:30:19AM -0700, Dan Kegel wrote:
Could you give it a shot?
OK, after ripping out the code that broke valgrind last time (patch
below), I get this:
==27590== Warning: set address range perms: large range 516194304, a 0, v 0
vex x86-IR: unhandled instruction bytes: 0xF3
On Fri, Jul 06, 2007 at 12:51:27PM -0700, Jeremy Fitzhardinge wrote:
The virtual CPU code has been competely rewritten since then. If its a
non-gcc generated instruction, its possible the new code
parser/generator hasn't been taught to deal with it.
It's not from gcc - it's from the i386
On Tue, Jul 03, 2007 at 05:28:30PM +0200, Blaisorblade wrote:
> > fchown01 used greatest stack depth: 4892 bytes left
>
> > That's the sum of process stack and interrupt stack, but I doubt if this
> > little box is using much interrupt stack space.
> >
> > No wonder people are still getting stack
On Tue, Jul 03, 2007 at 05:28:30PM +0200, Blaisorblade wrote:
fchown01 used greatest stack depth: 4892 bytes left
That's the sum of process stack and interrupt stack, but I doubt if this
little box is using much interrupt stack space.
No wonder people are still getting stack overflows
On Thu, Jun 28, 2007 at 11:25:37PM +0100, Alan Cox wrote:
> This completely bogus. readb() should be present on M68K, fix the
> platform to implement readb() for MMIO, even if your MMIO readb is a
> moveb instruction.
>
> check_signature is relevant for anything with MMIO space (for example you
>
On Thu, Jun 28, 2007 at 11:25:37PM +0100, Alan Cox wrote:
This completely bogus. readb() should be present on M68K, fix the
platform to implement readb() for MMIO, even if your MMIO readb is a
moveb instruction.
check_signature is relevant for anything with MMIO space (for example you
can
On Tue, Jun 26, 2007 at 01:35:50PM -0700, Andrew Morton wrote:
> > sprintf(title, data->title, data->device);
> > - pid = run_helper(NULL, NULL, argv, NULL);
> > + pid = run_helper(NULL, NULL, argv);
> > if (pid < 0) {
> > err = pid;
> > printk(UM_KERN_ERR
On Tue, Jun 26, 2007 at 01:35:50PM -0700, Andrew Morton wrote:
sprintf(title, data-title, data-device);
- pid = run_helper(NULL, NULL, argv, NULL);
+ pid = run_helper(NULL, NULL, argv);
if (pid 0) {
err = pid;
printk(UM_KERN_ERR xterm_open :
ack-depth checking to CONFIG_DEBUG_STACK_USAGE.
This also adds UML support.
Tested on UML and i386.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/Kconfig.debug|9 +
arch/um/defconfig|1 +
include/asm-um/thread_info.h |9 +
kernel/exit
On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote:
> Kconfig help text is indented 2 more spaces (by convention or
> CodingStyle).
OK, will fix.
> > + if(*p != 0)
>
> if (*p != NULL)
p is int *, so that's a int version pointer comparision.
> or
>
On Wed, Jun 20, 2007 at 04:18:56PM +0200, Blaisorblade wrote:
> In Italy we say "habits are hard to die"...
"Old habits are hard to kill"
I'm working on it.
> In the end: are you interested in this stuff? I'm busy right now but
> can work to apply these changes after this thursday
> (i.e.
On Wed, Jun 20, 2007 at 04:06:58PM +0200, Blaisorblade wrote:
> Oh, it's exactly what CONFIG_DEBUG_STACK_USAGE does for i386... (not sure if
> you were still wondering...).
Where? The only usage in i386 that I see is thread_info.h zeroing stacks
as they are allocated.
On Wed, Jun 20, 2007 at 04:06:58PM +0200, Blaisorblade wrote:
Oh, it's exactly what CONFIG_DEBUG_STACK_USAGE does for i386... (not sure if
you were still wondering...).
Where? The only usage in i386 that I see is thread_info.h zeroing stacks
as they are allocated.
On Wed, Jun 20, 2007 at 04:18:56PM +0200, Blaisorblade wrote:
In Italy we say habits are hard to die...
Old habits are hard to kill
I'm working on it.
In the end: are you interested in this stuff? I'm busy right now but
can work to apply these changes after this thursday
(i.e. tomorrow).
On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote:
Kconfig help text is indented 2 more spaces (by convention or
CodingStyle).
OK, will fix.
+ if(*p != 0)
if (*p != NULL)
p is int *, so that's a int version pointer comparision.
or
if
.
This also adds UML support.
Tested on UML and i386.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
--
arch/um/Kconfig.debug|9 +
arch/um/defconfig|1 +
include/asm-um/thread_info.h |9 +
kernel/exit.c| 24
4
On Tue, Jun 19, 2007 at 11:54:22AM -0700, Andrew Morton wrote:
> On Tue, 19 Jun 2007 14:42:45 -0400
> Jeff Dike <[EMAIL PROTECTED]> wrote:
>
> > Add a machanism to see how much of a kernel stack is used. This
> > allocates zeroed stacks and sees where the lowest non-
Add a machanism to see how much of a kernel stack is used. This
allocates zeroed stacks and sees where the lowest non-zero byte is on
process exit. It keeps track of the lowest value and logs values as
they get lower.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
arch/um/Kconfig
For some reason, I was using kmalloc instead of get_free_pages for
kernel stacks.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
include/asm-um/thread_info.h |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Index: linux-2.6.21-mm/include/asm-um/thread_
These can wait till 2.6.23.
They use get_free_page instead of kmalloc to allocate kernel stacks
and add some stack usage monitoring under CONFIG_DEBUG_STACK_USAGE.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the
These can wait till 2.6.23.
They use get_free_page instead of kmalloc to allocate kernel stacks
and add some stack usage monitoring under CONFIG_DEBUG_STACK_USAGE.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the
701 - 800 of 1742 matches
Mail list logo
