Re: state of the osdblk driver?

2014-10-21 Thread Jeff Garzik
On Tue, Oct 21, 2014 at 8:47 AM, Boaz Harrosh wrote: > [Just that I thought we don't do that. I can show you a dozen > ISA scsi LLD controllers which are a complete pain in the neck > with a all subsection core support. There is not a single system > on the planet that has this even possible, y

Re: state of the osdblk driver?

2014-10-21 Thread Jeff Garzik
Drop it, if there are no users. It was simulating an OSD, but there did not seem to be much beyond academic interest, and some interest in the use of aforementioned block functions as a useful exercise in block driver writing. On Tue, Oct 21, 2014 at 8:06 AM, Christoph Hellwig wrote: > The osdb

Re: TPMs and random numbers

2013-09-12 Thread Jeff Garzik
On Thu, Sep 12, 2013 at 5:57 PM, Jörn Engel wrote: > On Wed, 11 September 2013 14:47:04 -0400, David Safford wrote: >> But I also think that the existing (certified) TPMs are good enough >> for direct use. > That is equivalent to trusting the TPM chip not to be malicious. It Indeed. While it n

Re: TPMs and random numbers

2013-09-11 Thread Jeff Garzik
On Wed, Sep 11, 2013 at 2:45 PM, Theodore Ts'o wrote: > We should definitely do this. If the TPM driver could fetch some > randomness and then call add_device_randomness() to feed this into the > random driver's entropy pool when it initializes itself, that would be > ***really*** cool. rngd al

Re: [PATCH libata/for-3.10-fixes] libata: update "Maintained by:" tags

2013-05-14 Thread Jeff Garzik
On Tue, May 14, 2013 at 2:15 PM, Tejun Heo wrote: > (Removed Linus from cc) > > The following patch has been applied to libata/for-3.10-fixes. Will > push out to Linus with the next batch of updates. > > Thanks! > > From 8c3d3d4b12bf8de8c59fe1eb1bf866a8676ca309 Mon Sep 17 00:00:00 2001 > From: Te

Re: [GIT PULL] libata maintainership update

2013-05-07 Thread Jeff Garzik
lude/uapi/linux/phantom.h SERIAL ATA (SATA) SUBSYSTEM -M: Jeff Garzik +M: Tejun Heo L:linux-...@vger.kernel.org T:git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git S:Supported You probably also want to change * the git tree URL quoted above *

libata maintainership change

2013-05-03 Thread Jeff Garzik
Linux has really found its groove. When I first got involved in Linux, there was no PCI API (now called the hotplug or device API), and patch submission was a moderately painful process of throwing spaghetti at a wall: sending and resending, with both Linus and maintainers having to manually

Re: [PATCH] sata_highbank: Rename proc_name to the module name

2013-04-30 Thread Jeff Garzik
On 04/30/2013 12:57 PM, Robert Richter wrote: From: Robert Richter mkinitrd looks at /sys/class/scsi_host/host$hostnum/proc_name to find the module name of a disk driver. Current name is "highbank-ahci" but the module is "sata_highbank". Rename it to match the module name. Cc: Rob Herring Cc:

[git patches] libata updates

2013-04-30 Thread Jeff Garzik
Summary: 1) More ACPI fixes, cleanups 2) Minor cleanups for sata_highbank, pata_at32, pata_octeon_cf, sata_rcar 3) pata_legacy: small bug found in opti chipset code (untested fix, due to ancient h/w) 4) sata_fsl: RX water mark config knob, some h/w needs it 5) pata_imx: cleanups, Device

Re: [PATCH] AHCI: Make distinct names for ports in /proc/interrupts

2013-04-30 Thread Jeff Garzik
On 04/29/2013 06:12 AM, Alexander Gordeev wrote: Currently all interrupts assigned to AHCI ports show up in '/proc/interrupts' as 'ahci'. This fix adds port numbers as suffixes and hence makes the descriptions distinct. Reported-by: Jan Beulich Signed-off-by: Alexander Gordeev --- drivers/at

Re: [PATCH] drivers: ata: rcar: use devm_ioremap_resource()

2013-04-12 Thread Jeff Garzik
On 04/12/2013 02:51 AM, Silviu-Mihai Popescu wrote: Convert use of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. This was found with coccinelle. Signed-off-by: Silviu-Mihai Popescu --- drivers/ata/sata_rcar.c |6

[git patches] libata fixes

2013-04-08 Thread Jeff Garzik
The HDIO_DRIVE_* fix is really the biggie. Please pull 6d3bfc7be6f80d0c6ee6800d58d573343bf6e260 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ata_piix.c| 14 +- drivers/ata/libata-co

Re: [PATCH v0] Add SHA-3 hash algorithm

2013-04-03 Thread Jeff Garzik
On 10/03/2012 01:45 AM, Jeff Garzik wrote: Whee -- SHA-3 is out! I wanted to explore the new toy a bit, and so, here is a blatantly untested rough draft of SHA-3 kernel support. Why rough draft? Because answers to the questions below will inform a more polished version. Just to update

Re: [PATCH RFC 1/1] AHCI: Optimize interrupt processing

2013-04-03 Thread Jeff Garzik
On 03/06/2013 06:26 AM, Alexander Gordeev wrote: Split interrupt service routine into hardware context handler and threaded context handler. That allows to protect ports with individual locks rather than with a single host-wide lock, which results in better parallelism. Signed-off-by: Alexander

Re: [PATCH] drivers: ata: Use resource_size function

2013-04-03 Thread Jeff Garzik
On 03/16/2013 10:32 AM, Alexandru Gheorghiu wrote: Use resource_size function instead of explicit computation. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu --- drivers/ata/pata_octeon_cf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied -- To unsubsc

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-04-03 Thread Jeff Garzik
On 03/29/2013 01:56 AM, Gwendal Grignou wrote: commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO. Signe

Re: ata: HDIO_DRIVE_* ioctl() Linux 3.9 regression

2013-04-03 Thread Jeff Garzik
On 03/27/2013 08:51 AM, Krzysztof Mazur wrote: On Mon, Mar 25, 2013 at 06:26:50PM +0100, Ronald wrote: In reply to [1]: I have the same issue. Git bisect took 50+ rebuilds xD Smartd does not work anymore since 84a9a8cd9 ([libata] Set proper SK when CK_COND is set.). I hope I'm not stepping on

Re: [PATCH v3] ata: Fix DVD not dectected at some Haswell platforms

2013-04-03 Thread Jeff Garzik
On 03/06/2013 10:49 AM, Youquan Song wrote: There is a quirk patch 5e5a4f5d5a08c9c504fe956391ac3dae2c66556d "ata_piix: make DVD Drive recognisable on systems with Intel Sandybridge chipsets(v2)" fixing the 4 ports IDE controller 32bit PIO mode. We've hit a problem with DVD not recognized on Ha

[git patches] libata minor updates

2013-03-22 Thread Jeff Garzik
Please pull b186affe0c9d39e4d3152cd34bffea8fe1fa17f4 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/Kconfig | 13 +++-- drivers/ata/ahci.c| 2 ++ drivers/ata/ata_piix.c

Re: [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig

2013-03-04 Thread Jeff Garzik
On 03/02/2013 12:00 AM, Aaron Lu wrote: ODD is not a common TLA for non-ATA people so they will get confused by its meaning when they are configuring the kernel. This patch fixed this problem by using ODD only after stating what it is. Signed-off-by: Aaron Lu --- v2: Add a space before open par

Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv

2013-03-04 Thread Jeff Garzik
On 02/21/2013 02:01 PM, Rado Vrbovsky wrote: From: Andrew Brownfield In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c "ata_piix: defer disks to the Hyper-V drivers by default", this trivial patch adds a description to prefer_ms_hyperv. [rvrbo...@redhat.com: MODULE_PARM_DESC(

Re: [PATCH 1/1] ahci: Add Device IDs for Intel Wellsburg PCH

2013-03-04 Thread Jeff Garzik
On 02/21/2013 02:08 PM, James Ralston wrote: This patch adds the RAID-mode SATA Device IDs for the Intel Wellsburg PCH Signed-off-by: James Ralston --- drivers/ata/ahci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) applied [manually] -- To unsubscribe from this list: sen

Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource

2013-03-04 Thread Jeff Garzik
On 03/01/2013 06:16 AM, Sander Eikelenboom wrote: Fix a copy and paste mistake introduced in: commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 "ACPI / PM: Rework the handling of devices depending on power resources" Signed-off-by: Sander Eikelenboom --- drivers/ata/libata-acpi.c |2 +- 1

Re: [PATCH 2/2] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type

2013-02-28 Thread Jeff Garzik
cpi.c |6 -- include/acpi/acpi_bus.h |3 --- 3 files changed, 1 insertion(+), 34 deletions(-) patches 1-2 Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordom

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

2013-02-26 Thread Jeff Garzik
On 02/26/2013 11:58 AM, Tejun Heo wrote: On Tue, Feb 26, 2013 at 08:47:30AM -0800, Linus Torvalds wrote: Anyway, in the US it is definitely not a common term for normal people. Googling "odd" doesn't give anything on optical drives on the first page. On the other hand, >70% is about optical d

Re: Reproduceable SATA lockup on 3.7.8 with SSD

2013-02-26 Thread Jeff Garzik
On 02/25/2013 07:27 PM, Marc MERLIN wrote: Howdy, I seem to have the same problem (or similar) as Mathieu Desnoyers in https://lkml.org/lkml/2013/2/22/437 I can reliably get my SSD to drop from the SATA bus given the right workload on linux. How can I tell if it's linux's fault of the drive's

Re: [PATCH 2/3] ahci: AHCI-mode SATA patch for Intel Avoton DeviceIDs

2013-01-25 Thread Jeff Garzik
On 01/25/2013 03:01 PM, Seth Heasley wrote: This patch adds the AHCI and RAID-mode SATA DeviceIDs for the Intel Avoton SOC. Signed-off-by: Seth Heasley --- drivers/ata/ahci.c | 16 1 file changed, 16 insertions(+) applied 1-2 -- To unsubscribe from this list: send the l

[git patches] libata fixes

2013-01-21 Thread Jeff Garzik
Please pull 803739d25c2343da6d2f95eebdcbc08bf67097d4 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ahci.c| 8 +++- drivers/ata/libahci.c | 6 +++--- drivers/ata/libata-core.c | 22 ++

Re: [3.8-{rc1,rc2}] ata1.00: failed to get Identify Device Data, Emask 0x1

2013-01-16 Thread Jeff Garzik
On 01/16/2013 05:10 AM, Sedat Dilek wrote: On Sat, Jan 5, 2013 at 3:20 AM, Huang, Shane wrote: OK, I see the patch I mentioned to fix the problem was later reverted [1]. The real fix is "libata: replace sata_settings with devslp_timing" [2]. Yes, please use [2] which can also be found in kern

Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-09 Thread Jeff Garzik
On 01/08/2013 01:16 PM, Joshua Coombs wrote: Add a call to the IDE LED Trigger within the Marvell SATA driver to allow Marvell SoC devices to show SATA activity via GPIO connected LEDs. Signed-off-by: Joshua Coombs --- drivers/ata/sata_mv.c | 3 +++ drivers/leds/Kconfig | 3 +-- 2 files ch

[git patches] libata updates for 3.8

2012-12-14 Thread Jeff Garzik
use pci_get_drvdata() helper pata_of_platform: fix compile error ahci_platform: make structs static Christian Gmeiner (1): pata_cs5536: add quirk for broken udma Jeff Garzik (3): Revert "libata: check SATA_SETTINGS log with HW Feature Ctrl" Revert "pata_octeo

Re: [PATCH] [libata] scsi: fix Null pointer dereference on disk error

2012-12-14 Thread Jeff Garzik
: Xiaotian Feng Cc: Jeff Garzik Cc: James Bottomley Cc: sta...@kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ata/libata-scsi.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) applied -- To unsubscribe from this list: send the line

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Jeff Garzik
th nvidia MCP61 chipset, sata hdd and ide dvd-rom. Signed-off-by: Konstantin Khlebnikov Signed-off-by: Borislav Petkov Signed-off-by: Jeff Garzik --- Sep 27 13:48:23 buzz kernel: [ 63.815060] ACPI: PCI Interrupt Link [APSI] enabled at IRQ 20 Sep 27 13:48:23 buzz kernel: [ 63.987035] sc

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Jeff Garzik
On 12/03/2012 02:29 PM, Sergei Shtylyov wrote: Hello. On 11/30/2012 01:56 PM, Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ata_piix: re-oder code and remove prototypes You meant "re-order", I think. Signed-off-by: Bartlomiej Zolnierkiewicz Signed-

Re: [PATCH v4 -tip 3/3] AHCI: Support multiple MSIs

2012-12-03 Thread Jeff Garzik
|6 +++ drivers/ata/libahci.c | 118 ++--- 3 files changed, 207 insertions(+), 10 deletions(-) Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Jeff Garzik
On 11/30/2012 05:56 AM, Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ata_piix: re-oder code and remove prototypes Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- Jeff, please apply. Thanks! drivers/ata/ata_piix.c | 419 +

Re: [PATCH] ata_piix: reenable MS Virtual PC guests

2012-11-28 Thread Jeff Garzik
On 09/18/2012 11:48 AM, Olaf Hering wrote: An earlier commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c ("ata_piix: defer disks to the Hyper-V drivers by default") broke MS Virtual PC guests. Hyper-V guests and Virtual PC guests have nearly identical DMI info. As a result the driver does currently

Re: [PATCH 02/16] ata: Convert dev_printk(KERN_ to dev_(

2012-11-28 Thread Jeff Garzik
On 10/28/2012 04:05 AM, Joe Perches wrote: dev_ calls take less code than dev_printk(KERN_ and reducing object size is good. Coalesce formats for easier grep. Signed-off-by: Joe Perches --- drivers/ata/pata_cmd64x.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) applied

[git patches] libata fixes

2012-11-16 Thread Jeff Garzik
If you were going to shoot me for not sending these earlier, you would be right. -rc6 beat me by ~2 hours it seems, and they really should have gone out to libata-dev.git and you long before that. These have been in libata-dev.git for a day or so (unfortunately linux-next is on vacation). The m

Re: ata4.00: failed to get Identify Device Data, Emask 0x1

2012-11-16 Thread Jeff Garzik
On 11/16/2012 11:02 AM, Huang, Shane wrote: I tried word 78 bit 5(Hardware Feature Control) which does not work, it is 0 on my HDD sample with log 30h page 08h and DevSlp supported. Seems that word 78 bit 5 is only the sufficient condition, not the essential condition. Do you guys have suggestio

Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-11-15 Thread Jeff Garzik
d-function] Because SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM). Cc: Jeff Garzik Cc: Viresh Kumar Cc: linux-...@vger.kernel.org Signed-off-by: Yuanhan Liu Signed-off-by: Fengguang Wu --- drivers/ata/ahci_platform.c |2 +- drivers/

Re: [PATCH 7/8] ata: highbank: mark ahci_highbank_probe as __devinit

2012-11-15 Thread Jeff Garzik
valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console Signed-off-by: Arnd Bergmann Cc: Mark Langsdorf Cc: Rob Herring Cc: Jeff Garzik --- drivers/ata/sata_highbank.c |2 +- 1

Re: [PATCH] ata: pata_arasan: Initialize cf clock to 166MHz

2012-11-15 Thread Jeff Garzik
On 11/08/2012 10:09 AM, Viresh Kumar wrote: From: Vipul Kumar Samar PATA arasan driver expects the clock to be set to 166 MHz for proper functioning. This patch sets clk to 166 MHz in probe. Signed-off-by: Vipul Kumar Samar Signed-off-by: Viresh Kumar --- drivers/ata/pata_arasan_cf.c | 6

Re: [patch,v3 06/10] ata: use scsi_host_alloc_node

2012-11-15 Thread Jeff Garzik
On 11/09/2012 02:18 PM, Jeff Moyer wrote: Signed-off-by: Jeff Moyer --- drivers/ata/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] pata_cs5536: add quirk for broken udma

2012-11-15 Thread Jeff Garzik
On 11/15/2012 05:03 PM, Christian Gmeiner wrote: I am working on a device which uses the cs5536 pata driver. There are some broken hardware revisions out in the field, which can be detected via DMI. On older versions with an embedded BIOS I used libata.dma=0 to disable dma completely. Now we are

Re: [PATCH 2/8] aoe: provide ATA identify device content to user on request

2012-11-08 Thread Jeff Garzik
On 11/08/2012 11:32 AM, Ed Cashin wrote: This patch makes the aoe driver follow expected behavior when the user uses ioctl to get the ATA device identify information. Signed-off-by: Ed Cashin --- drivers/block/aoe/aoe.h|1 + drivers/block/aoe/aoeblk.c | 30 +

Re: [PATCH v0] Add SHA-3 hash algorithm

2012-10-03 Thread Jeff Garzik
On 10/03/2012 03:11 AM, Herbert Xu wrote: On Wed, Oct 03, 2012 at 02:53:27AM -0400, Jeff Garzik wrote: Maybe my patch is the best we can do in the current kernel, if dynamic digest size is not currently possible. Register "sha3_224", "sha3_256", ... as you describe, and w

Re: [PATCH v0] Add SHA-3 hash algorithm

2012-10-02 Thread Jeff Garzik
On 10/03/2012 02:06 AM, David Miller wrote: From: Jeff Garzik Date: Wed, 3 Oct 2012 01:45:42 -0400 1) tcrypt setup blatantly wrong. What is the best setup here? Define a separate entry for each digest length? Is there some special string descriptor format that is desired, like "sha

[PATCH v0] Add SHA-3 hash algorithm

2012-10-02 Thread Jeff Garzik
es appear. Commit e52113b7b4ace50ab586b426098c6d69d75c263a Branch sha3 Repo git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/linux.git References: http://keccak.noekeon.org/ http://www.mjos.fi/dist/readable_keccak.tgz http://www.nist.gov/itl/csd/sha-100212.cfm Not-signed-off-by: Jeff Garzik crypto/K

Re: [git patches] libata fixes for 3.7

2012-10-02 Thread Jeff Garzik
On 10/02/2012 03:44 PM, Michael Tokarev wrote: On 02.10.2012 23:40, Jeff Garzik wrote: Minor libata updates, nothing notable. 1) Apply -- and then revert -- the FUA feature. Caused disk corruption in linux-next, proving it cannot be turned on by default. Any details on that? Disk

[git patches] libata fixes for 3.7

2012-10-02 Thread Jeff Garzik
se + HCONTROL); + iowrite32(hcontrol | CLEAR_ERROR, + hcr_base + HCONTROL); + + /* Clear HControl[27] */ + iowrite32(hcontrol & ~CLEAR_ERROR, +

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-02 Thread Jeff Garzik
On 10/02/2012 12:42 PM, Alexander Gordeev wrote: On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote: +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance) +{ + struct ata_port *ap_this = dev_instance; + struct ahci_port_priv *pp = ap_this->private_data; + struct

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Jeff Garzik
On 10/02/2012 12:21 AM, Bjorn Helgaas wrote: On Mon, Oct 1, 2012 at 9:04 PM, Jeff Garzik wrote: On 10/01/2012 04:13 AM, Alexander Gordeev wrote: Take advantage of multiple MSIs implementation on x86 - on systems with IRQ remapping AHCI ports not only get assigned separate MSI vectors - but

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Jeff Garzik
|6 +++ drivers/ata/libahci.c | 118 ++--- 3 files changed, 205 insertions(+), 10 deletions(-) Acked-by: Jeff Garzik Normally, this amount of changes would -really- need to go through the libata tree. However, given the amount of dependencies, it

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread Jeff Garzik
On 09/25/2012 06:38 AM, James Bottomley wrote: On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: Can you be more specific about sysfs location? A runtime-writable (via sysfs!) module parameter for a module-wide default seemed appropriate. Well, if it's really important, the same

Re: [PATCH v2 -tip 5/5] AHCI: Support multiple MSIs

2012-09-26 Thread Jeff Garzik
On 09/03/2012 05:20 AM, Alexander Gordeev wrote: Take advantage of multiple MSIs implementation on x86 - on systems with IRQ remapping AHCI ports not only get assigned separate MSI vectors - but also separate IRQs. As result, interrupts generated by different ports could be serviced on different

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
On 09/25/2012 12:06 AM, James Bottomley wrote: On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed in principle to doing this (except that it should be a

Re: [PATCH] ahci: add a boot option to enable promise ahci

2012-09-24 Thread Jeff Garzik
On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote: > linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback': > > Use min_t(size_t, ...) to fix. > > Signed-off-by: Tony Hung > --- > > diff --git a/linux-3.2.0/drivers/ata/ahci.c b/linux-3.2.0/drivers/ata/ahci.c > --- a/linux-3

[SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..d15074b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -92,6 +92,10 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK); M

Re: linux-next: Tree for Sept 14 (sata_highhbank)

2012-09-14 Thread Jeff Garzik
On Fri, Sep 14, 2012 at 11:02 PM, Mark Langsdorf wrote: > Fix patch follows. Do I need to submit it as a separate patch or is this > sufficient? You appear to have submitted it as a separate patch just now ;p Will queue and push to libata-dev.git#upstream (and thus linux-next) Jeff -- To

[git patches] libata new PCI IDs

2012-09-12 Thread Jeff Garzik
Please pull 7b4f6ecacb14f384adc1a5a67ad95eb082c02bd1 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ahci.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) Alan Cox (2): ahci

Re: [PATCH 2/2] [trivial] Documentation: broken URL in libata

2012-09-12 Thread Jeff Garzik
On 02/13/2012 12:22 PM, Randy Dunlap wrote: On 02/13/2012 01:09 AM, Michael Opdenacker wrote: Fix broken link to license text: http://www.opensource.org/licenses/osl-1.1.txt The text for version 1.1 of the Open Sofware license doesn't seem to be available anywhere on http://www.opensource.org/ a

Re: [PATCH 15/16] ARM: samsung: move platform_data definitions

2012-09-11 Thread Jeff Garzik
Kim Cc: Kyungmin Park Cc: Ben Dooks Cc: Mark Brown Cc: Jeff Garzik Cc: Guenter Roeck Cc: "Wolfram Sang (embedded platforms)" Cc: Dmitry Torokhov Cc: Bryan Wu Cc: Richard Purdie Cc: Sylwester Nawrocki Cc: Mauro Carvalho Chehab Cc: Chris Ball Cc: David Woodhouse Cc: Grant

Re: Storage related regression in linux-next 20120824

2012-09-09 Thread Jeff Garzik
On 09/09/2012 04:36 PM, Hugh Dickins wrote: On Sun, Sep 9, 2012 at 1:28 PM, Jeff Garzik wrote: I'll send Linus a patch to disable. Thanks, but no, the change in question hasn't reached Linus yet, it's just a linux-next or mmotm thing - isn't it? Yep, libata-dev#upstream

Re: [RFC][PATCH] libata: enable SATA disk fua detection on default

2012-09-09 Thread Jeff Garzik
On 09/09/2012 04:34 PM, Arvydas Sidorenko wrote: Meanwhile there already has a number of SATA disks that have supported this feature. So I think maybe we can enable it. Regards, Zheng Blindly enabling FUA by default in my opinion is not a good idea at all. I believe the focus should be on det

Re: Storage related regression in linux-next 20120824

2012-09-09 Thread Jeff Garzik
starts up. That needs to modify initrd file. So it is inconvenient for administrator who needs to manage a huge number of servers. Signed-off-by: Zheng Liu Signed-off-by: Jeff Garzik diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 5eee1c1..c3fbdca 1

Re: Drop support for x86-32

2012-08-29 Thread Jeff Garzik
On Wed, Aug 29, 2012 at 7:03 PM, Mark Lord wrote: > On 12-08-26 10:15 AM, wbrana wrote: >> On 8/26/12, Mark Lord wrote: >>> Here are a couple of real scenarios you don't seem to have thought about. >>> A 32-bit kernel on a legacy (or even new) system in 2017 will still need >>> regular kernel upd

Re: [PATCH] Remove CONFIG_EXPERIMENTAL

2012-08-28 Thread Jeff Garzik
On Mon, Aug 27, 2012 at 5:53 PM, Kees Cook wrote: > This config item has not carried much meaning for a while now and is > almost always enabled by default. Remove it and adjust various config > logic and documentation. It does have meaning... !CONFIG_EXPERIMENTAL means more stable. In the past

Re: Storage related regression in linux-next 20120824

2012-08-27 Thread Jeff Garzik
On Mon, Aug 27, 2012 at 4:59 AM, Arvydas Sidorenko wrote: > linux-next 20120824 introduced regression on Mac mini 2011 - /root partition > gets mounted as read-only and it stays so even when trying to reboot into > previously working kernel. In order to make it work on older kernel again > `fsck`

[git patches] libata fixes

2012-08-25 Thread Jeff Garzik
Arnd Hannemann (1): pata_atiixp: override cable detection on MSI E350DM-E33 James Ralston (2): ahci: Add Device IDs for Intel Lynx Point-LP PCH ata_piix: Add Device IDs for Intel Lynx Point-LP PCH Jeff Garzik (1): [libata] new quirk, lift bridge limits for Buffalo

Re: [GIT PULL] tpmdd: TPM drivers, tpm-rng and fixes

2012-08-22 Thread Jeff Garzik
On 08/22/2012 05:52 PM, Kent Yoder wrote: Hi James, The following changes since commit 51b743fe87d7fb3dba7a2ff4a1fe23bb65dc2245: Merge tag 'v3.6-rc2' into next (2012-08-17 20:42:30 +1000) are available in the git repository at: git://github.com/shpedoikal/linux.git v3.6-rc2-tpmdd Ne

Re: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-22 Thread Jeff Garzik
bio_clone_kmalloc() as wrappers around it, making use of the functionality the last patch adedd. This will also help in a later patch changing how bio cloning works. Signed-off-by: Kent Overstreet CC: Jens Axboe CC: NeilBrown CC: Alasdair Kergon CC: Boaz Harrosh CC: Jeff Garzik --- block/blk-core.c

Re: [PATCH 0/2] ata: Updates for pata_octeon_cf driver.

2012-08-17 Thread Jeff Garzik
(-) patches 1 and 2 are Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/2] ata: implement MODE SELECT command

2012-08-17 Thread Jeff Garzik
MODE SELECT (for the caching page only) to the ATA SET FEATURES command. The set of changeable parameters answered by MODE SENSE is also adjusted accordingly. Cc: Sergei Shtylyov Cc: Jeff Garzik Signed-off-by: Paolo Bonzini --- v2->v3: ensure that only the first page of the sg list

Enabling FUA for SATA drives (was Re: [RFC][PATCH] libata: enable SATA disk fua detection on default)

2012-08-17 Thread Jeff Garzik
. CC: Jeff Garzik Signed-off-by: Zheng Liu --- drivers/ata/libata-core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 23763a1..3627251 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-c

Re: [PATCH] libata: acpi: call ata_acpi_gtm during ata port init time

2012-08-17 Thread Jeff Garzik
On 08/15/2012 05:08 AM, Aaron Lu wrote: Commit 30dcf76acc695cbd2fa919e294670fe9552e16e7 mistakenly dropped the code to get an initial gtm for the IDE channel. This caused the following problem for Sergei: http://marc.info/?l=linux-kernel&m=134484963618457&w=2 Fix this by adding the call back in

Re: [PATCH 2/5] ata_piix: Add Device IDs for Intel Lynx Point-LP PCH

2012-08-17 Thread Jeff Garzik
On 08/09/2012 12:34 PM, james.d.rals...@intel.com wrote: From: James Ralston This patch adds the IDE-mode SATA Device IDs for the Intel Lynx Point-LP PCH Signed-off-by: James Ralston --- drivers/ata/ata_piix.c |8 1 files changed, 8 insertions(+), 0 deletions(-) applied -

Re: [PATCH] pata_atiixp: override cable detection on MSI E350DM-E33

2012-08-17 Thread Jeff Garzik
On 08/17/2012 04:11 AM, Arnd Hannemann wrote: The mainboard MSI E350DM-E33 is advertised with 6 SATA ports. As it turns out, two of them seem to be driven by on-board SATA<->PATA converters. If a disk drive is connected to one of them kernel uses UDMA/33 mode due to cable detection: [ 34.55082

Re: [PATCH 1/5] ahci: Add Device IDs for Intel Lynx Point-LP PCH

2012-08-17 Thread Jeff Garzik
On 08/09/2012 12:02 PM, james.d.rals...@intel.com wrote: From: James Ralston This patch adds the AHCI-mode SATA Device IDs for the Intel Lynx Point-LP PCH Signed-off-by: James Ralston --- drivers/ata/ahci.c |8 1 files changed, 8 insertions(+), 0 deletions(-) applied -- T

Re: [GIT PULL] Update LZO compression

2012-08-16 Thread Jeff Garzik
On 08/16/2012 12:20 PM, Andi Kleen wrote: If you think a little bit, I bet you could come up with a solution that operates at cacheline-aligned granularity, something that would be _even faster_ than simply fixing the code to do aligned accesses. Cache aligned compression is unlikely to compres

Re: [PATCH 0/5] x86, MSI, AHCI: Support multiple MSIs

2012-08-16 Thread Jeff Garzik
On 08/16/2012 10:45 AM, Alexander Gordeev wrote: Currently multiple MSI mode is limited to a single vector per device (at least on x86 and PPC). This series breathes life into pci_enable_msi_block() and makes it possible to set interrupt affinity for multiple IRQs, similarly to MSI-X. Yet, only f

Re: [patch] [SCSI] mvsas: fix a && vs & bug

2012-08-16 Thread Jeff Garzik
On 08/16/2012 07:04 AM, Dan Carpenter wrote: The "1 << (slot_idx % 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter Acked-by: Jeff

Re: [GIT PULL] Update LZO compression

2012-08-16 Thread Jeff Garzik
On 08/16/2012 02:27 AM, Markus F.X.J. Oberhumer wrote: On 2012-08-15 16:45, Johannes Stezenbach wrote: On Wed, Aug 15, 2012 at 02:02:43PM +0200, Markus F.X.J. Oberhumer wrote: On 2012-08-14 14:39, Johannes Stezenbach wrote: On Tue, Aug 14, 2012 at 01:44:02AM +0200, Markus F.X.J. Oberhumer wrot

Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

2012-08-03 Thread Jeff Garzik
On 08/03/2012 05:50 AM, Aaron Lu wrote: Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Typically you follow the pattern of similar exports in the file (or in the API, if no others are in the file). Jeff -- To unsubscribe from this list: send t

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 04:26 PM, Matthew Wilcox wrote: Maybe we should design such a mechanism, but maybe we shouldn't ... as we find common things to do, we tend to move those to sysfs, not ioctls, and the kinds of commands that are being sent here are essentially vendor-specific NVMe commands; it's not

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 02:12 PM, Matthew Wilcox wrote: On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: Registers a character device for the nvme module and creates character files as /dev/nvmeN for each nvme device probed, where N is the device instance. The character devices support nvme ad

An Andre To Remember

2012-07-27 Thread Jeff Garzik
Visit a dairy. Climb a rock. Seek life. Life is so much more than code. Rest in peace Andre, Jeff Garzik friend and libata author PS. Remembering Andre website: http://hedrick4419.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

Re: Andre Hedrick (anhedric) has died

2012-07-26 Thread Jeff Garzik
On 07/20/2012 12:39 AM, Nate Lawson wrote: Dear Linux hackers, Sorry for the intrusion on this technical list. I wanted to let Andre's fellow Linux developers know that he died this past weekend. For those that don't know him, Andre was an active developer for the ATA driver a while back. I h

Re: [PATCH v3 0/7] ZPODD patches for scsi tree

2012-07-26 Thread Jeff Garzik
On 07/26/2012 10:41 AM, Aaron Lu wrote: On Thu, Jul 26, 2012 at 09:43:37AM -0400, Jeff Garzik wrote: On 07/26/2012 06:05 AM, Aaron Lu wrote: I can't set a flag in libata-acpi.c since a related function is missing in scsi-misc tree. Will fix this when 3.6-rc1 released. What does this

Re: [PATCH v2 0/2] ata: MODE SELECT implementation

2012-07-26 Thread Jeff Garzik
On 07/26/2012 03:25 AM, Paolo Bonzini wrote: Il 05/07/2012 11:40, Paolo Bonzini ha scritto: This is a revised version of the MODE SELECT implementation from yesterday, augmented with support for changeable parameter requests in MODE SENSE. Paolo Bonzini (2): ata: support MODE SENSE request f

Re: [PATCH v3 0/7] ZPODD patches for scsi tree

2012-07-26 Thread Jeff Garzik
On 07/26/2012 06:05 AM, Aaron Lu wrote: v3: Rebase on top of scsi-misc tree; Add the sr related patches previously in Jeff's libata tree; Re-organize the sr patches. A problem for now: for patch scsi: sr: support zero power ODD(ZPODD) I can't set a flag in libata-acpi.c since a related function i

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 07:30 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 3:58 PM, Jeff Garzik wrote: What is the right course in when a post-merge change is needed? Just describe the issue and the required change. Than I can just do it as part of the merge, and now the whole series is

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 06:31 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 3:26 PM, Jeff Garzik wrote: Even so, separately, it still needed that post-merge compile fix. And that's yet another example of how *NOT* to do things. If the merge has errors like that, then they should be fixed

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 06:06 PM, Linus Torvalds wrote: On Wed, Jul 25, 2012 at 1:43 PM, Jeff Garzik wrote: On Wed, Jul 25, 2012 at 04:35:51PM -0400, Jeff Garzik wrote: Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On 07/25/2012 04:35 PM, Jeff Garzik wrote: Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream (text copied from the upstream-linus tag) Notable changes: * Updating libata to directly bind with ACPI

Re: [git patches] libata updates

2012-07-25 Thread Jeff Garzik
On Wed, Jul 25, 2012 at 04:35:51PM -0400, Jeff Garzik wrote: > Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git > tags/upstream > Oh, I forgot to point out the merge commit, making my HEAD more recent t

Re: [PATCH 1/1] Drivers: hv: Change the hex constant to a decimal constant

2012-07-18 Thread Jeff Garzik
On 07/18/2012 06:57 PM, K. Y. Srinivasan wrote: The hex constant chosen for HV_LINUX_GUEST_ID_HI was offensive, update to use the decimal equivalent instead. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line

Re: [PATCH] Rewrite Documentation/SubmittingPatches.

2012-07-13 Thread Jeff Garzik
On Fri, Jul 13, 2012 at 7:51 AM, Stefan Beller wrote: > This updates the documentation on how to create patches and send > these to the kernel mailing list. > > The documentation before was written in times before git was there, > so the crafting of the patch needed to be done manually by diff -up

Re: Proposal for "proper" durable fsync() and fdatasync()

2008-02-26 Thread Jeff Garzik
Jamie Lokier wrote: Jeff Garzik wrote: Nick Piggin wrote: Anyway, the idea of making fsync/fdatasync etc. safe by default is a good idea IMO, and is a bad bug that we don't do that :( Agreed... it's also disappointing that [unless I'm mistaken] you have to hack each filesy

Re: Proposal for "proper" durable fsync() and fdatasync()

2008-02-26 Thread Jeff Garzik
Nick Piggin wrote: Anyway, the idea of making fsync/fdatasync etc. safe by default is a good idea IMO, and is a bad bug that we don't do that :( Agreed... it's also disappointing that [unless I'm mistaken] you have to hack each filesystem to support barriers. It seems far easier to make syn

  1   2   3   4   5   6   7   8   9   10   >