Re: [PATCH net-next v2 0/4] bonding: initial support for hardware crypto offload

2020-06-19 Thread Jeff Kirsher
On Wed, Jun 10, 2020 at 1:18 PM Jarod Wilson wrote: > > This is an initial functional implementation for doing pass-through of > hardware encryption from bonding device to capable slaves, in active-backup > bond setups. This was developed and tested using ixgbe-driven Intel x520 > interfaces with

Re: linux-next: manual merge of the net-next tree with the net tree

2019-09-12 Thread Jeff Kirsher
as linux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your > tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any > particularly >

Re: [PATCH] net: intel: Cleanup e1000 - add space between }}

2019-08-27 Thread Jeff Kirsher
On Mon, 2019-08-26 at 20:41 -0700, Joe Perches wrote: > On Mon, 2019-08-26 at 01:03 -0700, Jeff Kirsher wrote: > > On Fri, 2019-08-23 at 19:14 +, Forrest Fleming wrote: > > > suggested by checkpatch > > > > > > Signed-off-by: Forrest Fleming > >

Re: [PATCH] net: intel: Cleanup e1000 - add space between }}

2019-08-27 Thread Jeff Kirsher
On Tue, 2019-08-27 at 12:45 -0700, Forrest Fleming wrote: > On Tue, Aug 27, 2019 at 12:07 PM Joe Perches wrote: > > On Tue, 2019-08-27 at 12:02 -0700, Jeff Kirsher wrote: > > > On Mon, 2019-08-26 at 20:41 -0700, Joe Perches wrote: > > > > On Mon, 2019-08-26 at 0

Re: [PATCH] net: intel: Cleanup e1000 - add space between }}

2019-08-27 Thread Jeff Kirsher
On Mon, 2019-08-26 at 20:41 -0700, Joe Perches wrote: > On Mon, 2019-08-26 at 01:03 -0700, Jeff Kirsher wrote: > > On Fri, 2019-08-23 at 19:14 +, Forrest Fleming wrote: > > > suggested by checkpatch > > > > > > Signed-off-by: Forrest Fleming > >

Re: [PATCH] net: intel: Cleanup e1000 - add space between }}

2019-08-26 Thread Jeff Kirsher
On Fri, 2019-08-23 at 19:14 +, Forrest Fleming wrote: > suggested by checkpatch > > Signed-off-by: Forrest Fleming > --- > .../net/ethernet/intel/e1000/e1000_param.c| 28 +-- > 1 file changed, 14 insertions(+), 14 deletions(-) While I do not see an issue with this change

Re: drivers/net/ethernet/intel/i40e/i40e_main.c:7089:35-37: ERROR: invalid reference to the index variable of the iterator on line 7056 (fwd)

2019-08-08 Thread Jeff Kirsher
the iterator on line 7056 > > CC: kbuild-...@01.org > CC: linux-kernel@vger.kernel.org > TO: Harshitha Ramamurthy > CC: Jeff Kirsher > > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: ecb095bff5d4b8711a81968

Re: [PATCH -next] net/ixgbevf: fix a compilation error of skb_frag_t

2019-07-24 Thread Jeff Kirsher
i/linux/kernel.h:13:40: note: in definition of macro > '__KERNEL_DIV_ROUND_UP' > #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) > ^ > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4138:12: note: in > expansion of macro 

Re: [PATCH -next v2] net/ixgbevf: fix a compilation error of skb_frag_t

2019-07-24 Thread Jeff Kirsher
On Wed, 2019-07-24 at 14:41 -0700, David Miller wrote: > From: Jeff Kirsher > Date: Wed, 24 Jul 2019 09:39:26 -0700 > > > Dave I will pick this up and add it to my queue. > > How soon will you get that to me? The sooner this build fix is cured > the > better. Go

Re: [PATCH -next v2] net/ixgbevf: fix a compilation error of skb_frag_t

2019-07-24 Thread Jeff Kirsher
On Wed, 2019-07-24 at 12:17 -0400, Qian Cai wrote: > The linux-next commit "net: Rename skb_frag_t size to bv_len" [1] > introduced a compilation error on powerpc as it forgot to deal with > the > renaming from "size" to "bv_len" for ixgbevf. > > [1] > https://lore.kernel.org/netdev/2019072303083

Re: [PATCH net-next] intel: Mark expected switch fall-throughs

2019-01-23 Thread Jeff Kirsher
On Wed, 2019-01-23 at 11:11 -0600, Gustavo A. R. Silva wrote: > Hi Jeffrey, > > On 1/23/19 11:04 AM, Jeff Kirsher wrote: > > On Wed, 2019-01-23 at 01:48 -0600, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > c

Re: [PATCH net-next] intel: Mark expected switch fall-throughs

2019-01-23 Thread Jeff Kirsher
On Wed, 2019-01-23 at 01:48 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/net/ethernet/intel/igb/e1000_82575.c:636:6: warning: this > state

Re: [Intel-wired-lan] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Jeff Kirsher
gs like this: > > fs/fcntl.c: In function ‘send_sigio_to_task’: > fs/fcntl.c:738:13: warning: statement will never be executed [- > Wswitch-unreachable] >siginfo_t si; > ^~ > > Signed-off-by: Kees Cook Acked-by: Jeff Kirsher For the e1000 changes.

Re: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:908

2019-01-18 Thread Jeff Kirsher
On Fri, 2019-01-18 at 18:31 +0900, Tetsuo Handa wrote: > This is not a MM bug. ;-) > And this change is made by below commit. > > commit 59361316afcb08569af21e1af83e89c7051c055a > Author: Jeff Kirsher > Date: Thu Aug 2 10:13:10 2018 -0700 > > igb: reduce CP

Re: [Intel-wired-lan] [BUG] igb: reconnecting of cable not always detected

2019-01-17 Thread Jeff Kirsher
On Fri, May 18, 2018 at 12:36 AM Holger Schurig wrote: > > Alexander Duyck writes: > > Thanks for the data. It is actually useful. There are a few things > > that I see that seem to point to an obvious issue. > > Any news on this? > > A collegue of mine states (I have not checked this) that a ker

Re: [PATCH 3/8] i40e: increase indentation

2019-01-03 Thread Jeff Kirsher
On Thu, 2019-01-03 at 16:37 -0800, David Miller wrote: > From: Jeff Kirsher > Date: Thu, 03 Jan 2019 15:58:10 -0800 > > > On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote: > > > Convert spaces to tabs to get correct alignment. > > > > &

Re: [PATCH 3/8] i40e: increase indentation

2019-01-03 Thread Jeff Kirsher
1 insertion(+), 1 deletion(-) Acked-by: Jeff Kirsher Dave, since this is apart of a series, please feel free to commit this patch with the series. signature.asc Description: This is a digitally signed message part

Re: [PATCH] net: 80003es2lan: fix a missing check of read failure

2018-12-21 Thread Jeff Kirsher
On Thu, 2018-12-20 at 15:23 -0600, Kangjie Lu wrote: > When e1000_read_kmrn_reg_80003es2lan() fails, "kum_reg_data" is > uninitialized and may contain random value. However, it is further > used in the following execution, which will lead to undefined > behaviors. > The fix checks the failure of e1

Re: [PATCH net-next] ixgbe: fix XFRM_ALGO dependency

2018-10-17 Thread Jeff Kirsher
On Tue, 2018-10-16 at 09:35 -0700, Shannon Nelson wrote: > On 10/16/2018 3:03 AM, Arnd Bergmann wrote: > > When XFRM_ALGO is not enabled, the new igxge ipsec code produces a > > link error: > > s/igxge/ixgbe/ > > > > > drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.o: In function > > `ixgbe_ipsec_

Re: [PATCH v1 1/4] igb: Remove unnecessary include of

2018-07-25 Thread Jeff Kirsher
On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The igb driver doesn't need anything provided by pci-aspm.h, so > remove > the unnecessary include of it. > > Signed-off-by: Bjorn Helgaas Acked-by: Jeff Kirsher I am fine with

Re: [PATCH v6 4/5] ixgbe: Report PCIe link properties with pcie_print_link_status()

2018-05-10 Thread Jeff Kirsher
k_status() uses dev_info() because > if the > platform has no faster slot available, the user can't do anything > about the > warning and may not want to be bothered with it. > > Signed-off-by: Bjorn Helgaas Acked-by: Jeff Kirsher Since this is apart of a series,

Re: [PATCH v6 5/5] PCI: Remove unused pcie_get_minimum_link()

2018-05-10 Thread Jeff Kirsher
On Thu, 2018-05-10 at 11:33 -0500, Bjorn Helgaas wrote: > On Thu, May 03, 2018 at 03:00:43PM -0500, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > In some cases pcie_get_minimum_link() returned misleading > > information > > because it found the slowest link and the narrowest link without >

Re: [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb()

2018-03-21 Thread Jeff Kirsher
On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote: > Remove ixgbevf_write_tail() in favor of moving writel() close to > wmb(). > > Signed-off-by: Sinan Kaya > Reviewed-by: Alexander Duyck > --- > drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 - > drivers/net/ethernet/intel/ixgbevf

Re: [PATCH] e1000e: Fix link status in case of error.

2018-02-28 Thread Jeff Kirsher
On Wed, 2018-02-28 at 14:20 +0900, Benjamin Poirier wrote: > Before commit 19110cfbb34d ("e1000e: Separate signaling for link > check/link > up"), errors which happen after "get_link_status = false" in the > copper > check_for_link callbacks would be ignored and the link considered up. > After > th

Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower

2018-02-15 Thread Jeff Kirsher
> > Addresses-Coverity-ID: 1465282 ("Copy-paste error") > > Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters") > > Signed-off-by: Gustavo A. R. Silva > > Thanks for the patch! > > Acked-by:Harshitha Ramamurthy Acked-by: Jeff Kirshe

Re: [Intel-wired-lan] [PATCH] Documentation: networking: Update ixgb kconfig select documentation

2018-02-06 Thread Jeff Kirsher
On Tue, 2018-02-06 at 13:01 -0800, Alexander Duyck wrote: > On Tue, Feb 6, 2018 at 12:42 PM, Corentin Labbe > wrote: > > Update documentation on how to enable ixgb and ixgb DCB. > > Simply remove NETDEV_1 and replace it with the new used kconfig > > names. > > Minor typo in the patch descript

Re: [PATCH][next] ixgbe: fix comparison of offset with zero or NVM_INVALID_PTR

2018-01-12 Thread Jeff Kirsher
On Fri, 2018-01-12 at 17:13 +, Colin King wrote: > From: Colin Ian King > > The incorrect operator && is being used and will always return false > as offset can never be two different values at the same time. Fix > this > by using the || operator instead. > > Detected by CoverityScan, CID#14

[PATCH v2] Enable SR-IOV instantiation through /sys file

2017-12-08 Thread Jeff Kirsher
From: Liang-Min Wang When a SR-IOV capable device is bound with vfio-pci, the device loses capability of creating SR-IOV instances through /sy/bus/ pci/devices/.../sriov_numvfs. This patch re-activates this capability for a PCIe device that is SR-IOV capable and is bound with vfio-pci.ko. This pa

Re: [Intel-wired-lan] [PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

2017-12-06 Thread Jeff Kirsher
radead.org > Cc: net...@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org > Cc: linux-r...@vger.kernel.org > Cc: alsa-de...@alsa-project.org > Cc: kvm...@lists.cs.columbia.edu Acked-by: Jeff Kirsher For the changes to the Intel drivers. > --- > arch/microblaze/ker

[PATCH] sched/deadline: fix one-bit signed bitfields to be unsigned

2017-11-28 Thread Jeff Kirsher
quot;, 2017-10-10) Signed-off-by: Jacob Keller Cc: luca abeni Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- include/linux/sched.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index a5dc7c98b0a2..21991d668

[PATCH] Enable SR-IOV instantiation through /sys file

2017-10-24 Thread Jeff Kirsher
From: Liang-Min Wang When a SR-IOV supported device is bound with vfio-pci, the driver could not create SR-IOV instance through /sys/bus/pci/devices/... /sriov_numvfs. This patch re-activates this capability for a PCIe device that supports SR-IOV and is bound with vfio-pci.ko. Signed-off-by: L

Re: [PATCH, net-next] i40e: avoid 64-bit division where possible

2017-10-17 Thread Jeff Kirsher
On Tue, 2017-10-17 at 12:23 +0200, Arnd Bergmann wrote: > The new bandwidth calculation causes a link error on 32-bit > architectures, like > > ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/intel/i40e/i40e.ko] > undefined! > > The problem is the max_tx_rate calculation that uses 64-bit integers

Re: [PATCH] i40e/i40evf: actually use u32 for feature flags

2017-10-11 Thread Jeff Kirsher
On Wed, 2017-10-11 at 16:02 +0200, Arnd Bergmann wrote: > A previous cleanup intended to change the flags variable to 32 > bit instead of 64, but accidentally left out the important > part of that change, leading to a build error: > > drivers/net/ethernet/intel/i40e/i40e_ethtool.o: In function > `

[net 3/5] Revert commit 1a8b6d76dc5b ("net:add one common config...")

2017-10-09 Thread Jeff Kirsher
ommit 1a8b6d76dc5b ("net:add one common config...") did, so revert this commit. Signed-off-by: Ding Tianhong Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- arch/Kconfig| 3 --- arch/sparc/Kconfig | 1 - drive

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-09-01 Thread Jeff Kirsher
: Pavel Machek > Cc: Len Brown > Cc: Greg Kroah-Hartman > Cc: Mike Marciniszyn > Cc: Dennis Dalessandro > Cc: Doug Ledford > Cc: Sean Hefty > Cc: Hal Rosenstock > Cc: Dmitry Torokhov > Cc: Jeff Kirsher > Cc: linux...@vger.kernel.org > Cc: linux-r...@vge

Re: [PATCH] e1000: changed some expensive calls of udelay to usleep_range

2017-08-22 Thread Jeff Kirsher
On Tue, 2017-08-22 at 16:02 -0500, nxf23276 wrote: > Calls to udelay are not preemtable by userspace so userspace > applications experience a large (~200us) latency when running on > core > 0. Instead usleep_range can be used to be more friendly to > userspace > since it is preemtab

Re: [PATCH v2] i40e/i40evf: use cpumask_copy() for assigning cpumask

2017-08-16 Thread Jeff Kirsher
On Wed, 2017-08-16 at 19:52 +0200, Juergen Gross wrote: > Using direct assignment for a cpumask is wrong, cpumask_copy() should > be used instead. > > Otherwise crashes like the following might happen: > > [62792.326374] BUG: unable to handle kernel paging request at > 8800049ff000 > [62792.3

Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n

2017-07-13 Thread Jeff Kirsher
single time within the #ifdef in > > igb_resume(). Fix it by moving igb_deliver_wake_packet() next to > > igb_resume() inside the #ifdef. > > > > The diff ends up looking a bit funky here. It *looks* like > > igb_suspend() is getting moved, but that's

Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-27 Thread Jeff Kirsher
On Wed, 2017-06-28 at 05:28 +1000, Dave Airlie wrote: > On 20 June 2017 at 18:49, Daniel Vetter wrote: > > On Wed, Jun 07, 2017 at 01:07:33AM +, Brown, Aaron F wrote: > > > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] > > > >

Re: [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver

2017-06-26 Thread Jeff Kirsher
On Thu, 2017-06-22 at 15:23 +0200, Michael Moese wrote: > From: Andreas Werner > > Signed-off-by: Andreas Werner > --- >  drivers/net/ethernet/intel/igb/igb_main.c | 4 >  1 file changed, 4 insertions(+) NACK Why? Your lack of patch description does not provide a reasoning on why we need

Re: [net-intel-i40e] question about assignment overwrite

2017-06-07 Thread Jeff Kirsher
On Wed, 2017-06-07 at 16:55 -0300, Mauro Rodrigues wrote: > On Wed, May 17, 2017 at 10:49:11PM -0700, Jeff Kirsher wrote: > > On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > > > While looking into Coverity ID 1408956 I ran into the following > > > piece

Re: [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-06 Thread Jeff Kirsher
... > > The unwind failures stems from commit 2800209994f8 ("e1000e: > > Refactor PM > > flows"), but it may be a later patch that introduced the non- > > recoverable > > behaviour. > > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows") &g

Re: [net-intel-i40e] question about assignment overwrite

2017-05-17 Thread Jeff Kirsher
On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > While looking into Coverity ID 1408956 I ran into the following > piece   > of code at drivers/net/ethernet/intel/i40e/i40e_main.c:8807: > > 8807    if (pf->hw.mac.type == I40E_MAC_X722) { > 8808    pf->flags |= I40E_F

Re: [PATCH 5/7] IB/hfi1: use pcie_flr instead of duplicating it

2017-04-26 Thread Jeff Kirsher
On Tue, 2017-04-25 at 14:39 -0500, Bjorn Helgaas wrote: > On Mon, Apr 24, 2017 at 04:35:07PM +0200, Christoph Hellwig wrote: > > On Mon, Apr 24, 2017 at 02:16:31PM +, Byczkowski, Jakub wrote: > > > Tested-by: Jakub Byczkowski > > > > Are you (and Doug) ok with queueing this up in the PCI tree

Re: [PATCH 4/7] ixgbe: use pcie_flr instead of duplicating it

2017-04-26 Thread Jeff Kirsher
On Thu, 2017-04-13 at 16:53 +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++-- >  1 file changed, 2 insertions(+), 14 deletions(-) Acked-by: Jeff Kirsher Sorry for the late ACK. s

Re: [Intel-wired-lan] [BUG] 4.11.0-rc1 panic on shutdown X61s

2017-03-23 Thread Jeff Kirsher
On Wed, Mar 22, 2017 at 12:00 PM, Borislav Petkov wrote: > (Readding Jeff Kirsher who got dropped from the CC-list at some point.) > > On Tue, Mar 21, 2017 at 07:13:43PM -0700, l...@pengaru.com wrote: >> > This is still broken as of 4.11.0-rc3 FYI. >> > >>

Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

2017-03-08 Thread Jeff Kirsher
ter Senna Tschudin > --- >  drivers/net/ethernet/intel/e100.c | 12 ++-- >  1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Jeff Kirsher My only concern is: - what hardware did this get tested with? Since this affects all e100 parts, it would be hard to believe that all the af

Re: [PATCH 1/1] ixgbe: fcoe: return value of skb_linearize should be handled

2016-12-07 Thread Jeff Kirsher
On Wed, 2016-12-07 at 15:43 +0800, Zhouyi Zhou wrote: > Signed-off-by: Zhouyi Zhou > Reviewed-by: Cong Wang > Reviewed-by: Yuval Shaia   > Reviewed-by: Eric Dumazet > --- >  drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +- >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +-- >  2 fil

Re: [PATCH] checkpatch: Fix warnings when --no-tree is used

2016-11-08 Thread Jeff Kirsher
On Fri, 2016-10-21 at 13:27 -0700, Jeff Kirsher wrote: > When users run checkpatch.pl with --no-tree option, $root is not > defined, which causes an ugly warning that it is not initialized at > line 764.  The test for whether or not a file is maintained should > only be run when a ke

Re: [PATCH] add one parameter wro_enable to enable relaxed ordering for IXGBE

2016-10-29 Thread Jeff Kirsher
On Sat, 2016-10-29 at 15:08 +0800, Mao Wenan wrote: > This patch provides a way to enable relaxed ordering, where it helps with > performance in some architecture. > The default value of wro_enable is 0, if you want to enable relaxed > ordering, please set wro_enable=1. > > Mao Wenan (1): >   add

Re: [Intel-wired-lan] [net-next PATCH 27/27] igb: Revert "igb: Revert support for build_skb in igb"

2016-10-26 Thread Jeff Kirsher
ort > full jumbo frames when using build_skb.  Instead we can only support up > to > 2K minus the skb overhead and padding offset. > > Signed-off-by: Alexander Duyck Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part

Re: [Intel-wired-lan] [net-next PATCH 25/27] igb: Update driver to make use of DMA_ATTR_SKIP_CPU_SYNC

2016-10-26 Thread Jeff Kirsher
e lines we were prefetching and then > invalidating the first 128 bytes of the packet.  To avoid that I have > moved > the sync up to before we perform the prefetch and allocate the skbuff so > that we can actually make use of it. > > Signed-off-by: Alexander Duyck >  Acked-by: Jeff

Re: [Intel-wired-lan] [net-next PATCH 26/27] igb: Update code to better handle incrementing page count

2016-10-26 Thread Jeff Kirsher
nd > this in turn should give us a slight improvement in cycles per packet.  > In > addition if we eventually move this over to using build_skb the gains > will > be more noticeable. > > Signed-off-by: Alexander Duyck Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part

[PATCH] checkpatch: Fix warnings when --no-tree is used

2016-10-21 Thread Jeff Kirsher
-off-by: Jeff Kirsher --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a8368d1..7a54978 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2352,7 +2352,7 @@ sub process

Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

2016-09-25 Thread Jeff Kirsher
On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in th

Re: [PATCH] ixgbe: mark symbols static where possible

2016-09-25 Thread Jeff Kirsher
On Sun, 2016-09-25 at 14:03 +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no > previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5:

Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

2016-09-19 Thread Jeff Kirsher
On Sun, 2016-09-18 at 16:50 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in th

Re: [PATCH V2] git-send-email: Add ability to cc: any "bylines" in the commit message

2016-08-31 Thread Jeff Kirsher
be suppressed with --suppress-cc=bylines. > > Signed-off-by: Joe Perches > --- >  Documentation/git-send-email.txt | 11 +++ >  git-send-email.perl  | 16 +++- >  2 files changed, 18 insertions(+), 9 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/1 v2] net: i10e: use matching format indentifiers

2016-08-10 Thread Jeff Kirsher
On Tue, 2016-08-02 at 20:15 +0200, Heinrich Schuchardt wrote: > i is defined as int but output as %u several times. > Adjust the format identifiers. > > v2: > Keep definition of i as int. > David indicated that this is the preferable way to define > loop variables. > > Sig

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-27 Thread Jeff Kirsher
On Tue, 2016-07-26 at 11:14 +0200, Eric Dumazet wrote: > Could you try this ? > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > b/drivers/net/ethernet/intel/e1000/e1000_main.c > index > f42129d09e2c23ba9fdb5cde890d50ecb7166a42..a53c41c4c4f7d1fe52f95a2cab8784a > 938b3820b 100644 > --

Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jeff Kirsher
irely, if so desired. > > Suggested-by: Jesse Brandeburg > CC: Jesse Brandeburg > CC: Jeff Kirsher > CC: intel-wired-...@lists.osuosl.org > CC: net...@vger.kernel.org > Signed-off-by: Jarod Wilson > --- >  drivers/net/ethernet/intel/e1000e/82571.c   |  6 -- &g

Re: [PATCH v3 0/6] Introduce pci_(request|release)_(mem|io)_regions

2016-06-08 Thread Jeff Kirsher
On Wed, 2016-06-08 at 09:28 +0200, Johannes Thumshirn wrote: > On Tue, Jun 07, 2016 at 09:44:00AM +0200, Johannes Thumshirn wrote: > > The first patch in this series introduces the following 4 helper > functions to > > the PCI core: > >  > > * pci_request_mem_regions() > > * pci_request_io_regions(

Re: [PATCH v2 5/6] ethernet/intel: Use pci_(request|release)_mem_regions

2016-06-02 Thread Jeff Kirsher
On Thu, 2016-06-02 at 09:30 +0200, Johannes Thumshirn wrote: > Now that we do have pci_request_mem_regions() and > pci_release_mem_regions() at > hand, use it in the Intel ethernet drivers. > > Suggested-by: Christoph Hellwig > Signed-off-by: Johannes Thumshirn > Cc: Jeff K

Re: [PATCH 5/5] ethernet: Use pci_(request|release)_mem_regions

2016-06-01 Thread Jeff Kirsher
On Wed, 2016-06-01 at 10:51 +0200, Johannes Thumshirn wrote: > On Wed, Jun 01, 2016 at 12:59:56AM -0700, Christoph Hellwig wrote: > > On Tue, May 31, 2016 at 02:05:13PM +0200, Johannes Thumshirn wrote: > > > Now that we do have pci_request_mem_regions() and > pci_release_mem_regions() at > > > hand

Re: [RFC PATCH net] e1000e: keep vlan interfaces functional after rxvlan off

2016-05-18 Thread Jeff Kirsher
1000 driver here) on the > interface. > > Also slipped a related-ish fix to the kerneldoc text for > e1000e_vlan_strip_disable here... > > CC: Jeff Kirsher > CC: intel-wired-...@lists.osuosl.org > CC: net...@vger.kernel.org > Signed-off-by: Jarod Wilson > --- >

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-16 Thread Jeff Kirsher
On Fri, 2016-05-13 at 14:56 +0900, Ethan Zhao wrote: > Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less > CPUs were assigned. especially when DCB is enabled, so we should take > num_online_cpus() as top limit, and aslo to make sure every TC has > at least one queue, take the MAX

Re: [PATCH] i40e: constify i40e_client_ops structure

2016-05-13 Thread Jeff Kirsher
On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote: > On 05/01/2016 08:07 AM, Julia Lawall wrote: > > The i40e_client_ops structure is never modified, so declare it as > const. > >  > > Done with the help of Coccinelle. > >  > > Signed-off-by: Julia Lawall > > Thanks, applied. I already have

Re: linux-next: build failure after merge of the net-next tree

2016-04-22 Thread Jeff Kirsher
On Fri, 2016-04-22 at 10:20 +0100, Mark Brown wrote: > On Wed, Apr 13, 2016 at 11:15:13AM -0400, David Miller wrote: > > From: Stephen Rothwell > > > > After merging the net-next tree, today's linux-next build (arm > > > allmodconfig) failed like thisi (this has actually been failing > for a > >

Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

2016-04-19 Thread Jeff Kirsher
On Tue, 2016-04-19 at 19:17 -0700, K. Y. Srinivasan wrote: > On Hyper-V, the VF/PF communication is a via software mediated path > as opposed to the hardware mailbox. Make the necessary > adjustments to support Hyper-V. > > Signed-off-by: K. Y. Srinivasan > --- > V2: Addressed most of the

Re: [PATCH net-next 0/2] ethernet: intel: Support Hyper-V hosts

2016-04-14 Thread Jeff Kirsher
On Thu, Apr 14, 2016 at 4:55 PM, K. Y. Srinivasan wrote: > Make adjustments to the Intel 10G VF driver to support > running on Hyper-V hosts. > > K. Y. Srinivasan (2): > ethernet: intel: Add the device ID's presented while running on > Hyper-V > intel: ixgbevf: Support Windows hosts (Hyper

Re: [PATCH 8/8] net: e1000e: Adds hardware supported cross timestamp on e1000e nic

2016-03-03 Thread Jeff Kirsher
tstamp(). > > Cc: Prarit Bhargava > Cc: Richard Cochran > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Andy Lutomirski > Cc: Jeff Kirsher > Cc: kevin.b.stan...@intel.com > Cc: kevin.j.cla...@intel.com > Cc: h...@zytor.com > Cc: jeffrey.t.kirs...@intel.com > Cc: n

Re: [PATCH v8 8/8] net: e1000e: Adds hardware supported cross timestamp on e1000e nic

2016-02-24 Thread Jeff Kirsher
+++ >  drivers/net/ethernet/intel/e1000e/regs.h    |  4 ++ >  4 files changed, 103 insertions(+) Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part

Re: [PATCH v7 8/8] net: e1000e: Adds hardware supported cross timestamp on e1000e nic

2016-02-18 Thread Jeff Kirsher
+++ >  drivers/net/ethernet/intel/e1000e/regs.h    |  4 ++ >  4 files changed, 103 insertions(+) Acked-by: Jeff Kirsher I am fine with Christopher's changes, so when the issues with the other patches in the series gets ironed out, your good to apply this patch

Re: [PATCH 1/3] i40e: fix build warning

2016-01-25 Thread Jeff Kirsher
On Mon, 2016-01-25 at 11:40 +0530, Sudip Mukherjee wrote: > While building we are getting warning about: > i40e_main.c:8604:13: warning: 'i40e_add_geneve_port' defined but not > used > and > i40e_main.c:8651:13: warning: 'i40e_del_geneve_port' defined but not > used > > The contents of these funct

Re: [PATCH] net: i40e: avoid unused function warnings

2016-01-20 Thread Jeff Kirsher
On Wed, 2016-01-20 at 23:54 +0100, Arnd Bergmann wrote: > On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote: > > Yeah, I have a fix for that as well. > >  > > You can confirm by pulling my next-queue tree (dev-queue branch). > > git://git.kernel.org/pub/scm/lin

Re: [PATCH] net: i40e: avoid unused function warnings

2016-01-20 Thread Jeff Kirsher
On Wed, 2016-01-20 at 23:28 +0100, Arnd Bergmann wrote: > On Wednesday 20 January 2016 14:17:25 Jeff Kirsher wrote: > > On Wed, 2016-01-20 at 11:42 +0100, Arnd Bergmann wrote: > > > The addition of the geneve tunnel offload code left a couple > > > of functions uncond

Re: [PATCH] net: i40e: avoid unused function warnings

2016-01-20 Thread Jeff Kirsher
On Wed, 2016-01-20 at 11:42 +0100, Arnd Bergmann wrote: > The addition of the geneve tunnel offload code left a couple > of functions unconditionally defined but empty whenever CONFIG_VXLAN > and CONFIG_GENEVE are disabled. gcc warns about this: > > i40e_main.c:7049:13: warning: 'i40e_sync_udp_fil

Re: Stupid git question...

2015-12-12 Thread Jeff Kirsher
On Fri, Dec 11, 2015 at 5:27 PM, Valdis Kletnieks wrote: > OK.. Here's the situation - I've got several sets of patches I'll probably > be cooking over the holidays, and I'm planning to base on linux-next (though > any other moving-target base has the same issues). > > What I *want* to accomplish:

Re: [PATCH RESEND] fm10k:Fix error handling in the function fm10k_resume

2015-12-05 Thread Jeff Kirsher
On Sat, 2015-12-05 at 21:36 -0500, Nicholas Krause wrote: > This fixes error handling to proper check if the call to the function > fm10k_mbx_request_irq has failed by returning a error code and if > so return immediately to the caller of fm10k_resume to properly > signal a failure has occurred whe

Re: [PATCH] fm10k:Fix error handling in the function fm10k_setup_tc

2015-10-20 Thread Jeff Kirsher
On Tue, 2015-10-20 at 17:05 -0400, Nicholas Krause wrote: > This fixes error handling in the function fm10k_setup_tc to properly > check if the call to the function fm10k_open has failed by returning > a error and if so return immediately to the caller of the function > fm10k_setup_tc to properly s

Re: [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe

2015-10-14 Thread Jeff Kirsher
On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote: > This removes the reducant error path and now no longer used goto > label err_sw_init after the call to ixgb_probe in the function > ixgb_sw_init after calling this function due to it always returning > zero as it is guarantee to run succe

Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks.

2015-10-13 Thread Jeff Kirsher
On Tue, 2015-10-13 at 15:23 -0700, Alexander Duyck wrote: > On 10/13/2015 02:39 PM, Janusz Wolak wrote: > > From: Janusz Wolak > > > > Signed-off-by: Janusz Wolak > > --- > > drivers/net/ethernet/intel/e1000/e1000_param.c | 114 > ++--- > > 1 file changed, 82 insertions(+),

Re: [PATCH v3] igb: improve handling of disconnected adapters

2015-10-12 Thread Jeff Kirsher
15:00.0: eth0: (PCIe:2.5Gb/s:Width x1) > e8:ea:6a:00:1b:2a > [ 8010.597543] igb :15:00.0: eth0: PBA No: 000200-000 > [ 8010.597545] igb :15:00.0: Using MSI-X interrupts. 4 rx > queue(s), 4 tx queue(s) > [ 8010.600468] igb :15:00.0 enp21s0: renamed from eth0 > [ 8010.6193

Re: [Intel-wired-lan] [Patch V3 6/9] i40evf: Use numa_mem_id() to better support memoryless node

2015-08-18 Thread Jeff Kirsher
On Mon, 2015-08-17 at 12:03 -0700, Patil, Kiran wrote: > ACK. > Just an FYI, top posting is frowned upon in the Linux public mailing lists. Also, if you really want your ACK to be added to the patch, you need to reply with: Acked-by: Kiran Patil > -Original Message- > From: Intel-wire

Re: [PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open

2015-08-05 Thread Jeff Kirsher
On Wed, 2015-08-05 at 18:16 +0800, Jia-Ju Bai wrote: > When e1000e_setup_rx_resources is failed in e1000_open, > e1000e_free_tx_resources in "err_setup_rx" segment is executed. > "writel(0, tx_ring->head)" statement in e1000_clean_tx_ring > in e1000e_free_tx_resources will cause a null poonter > de

Re: [PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-08-03 Thread Jeff Kirsher
On Wed, 2015-07-29 at 14:31 -0700, David Miller wrote: > From: Alex Williamson > Date: Wed, 29 Jul 2015 13:33:07 -0600 > > > I expect that's because of this patch that's in Jeff's dev-queue branch: > > > > http://git.kernel.org/cgit/linux/kernel/git/jkirsher/next-queue.git/commit/?h=dev-queue&id

Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

2015-07-23 Thread Jeff Kirsher
On Wed, 2015-07-22 at 11:41 +1000, Michael Ellerman wrote: > On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote: > > On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: > > > e1000e_disable_aspm_locked() is only used in __e1000_resume() > which is > >

Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

2015-07-15 Thread Jeff Kirsher
On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: > e1000e_disable_aspm_locked() is only used in __e1000_resume() which is > inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used" > warning for e1000e_disable_aspm_locked(). > > Move it inside the existing CONFIG_PM block to

Re: e1000e driver - hang after 4 hours of uptime - finally bisected!

2015-06-18 Thread Jeff Kirsher
On Thu, 2015-06-18 at 12:46 -0400, Valdis Kletnieks wrote: > (follow up to a report from last week - bisecting took a while as I could > only do 1 or 2 tests an evening) > > My Dell Latitude E6530 crashes with a specific kernel lockup almost > exactly 4 hours after boot if there isn't a cable conn

Re: [PATCH v4 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

2015-04-10 Thread Jeff Kirsher
On Fri, 2015-04-10 at 01:04 +, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > The limitation of the number of multicast address for VF is not enough > for the large scale server with SR-IOV feature. > IPv6 requires the multicast MAC address for each IP address to handle > the Neighbor

Re: [E1000-devel] [PATCH v3 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode

2015-04-08 Thread Jeff Kirsher
On Wed, 2015-04-08 at 15:15 -0700, Alexander Duyck wrote: > On 04/07/2015 10:38 PM, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto > > > > Implements the new netdev op to allow VF multicast promiscuous mode. > > > > The multicast promiscuous mode is not allowed for all VFs by default. > > >

Re: [PATCH v3 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

2015-04-08 Thread Jeff Kirsher
On Wed, 2015-04-08 at 05:36 +, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > The limitation of the number of multicast address for VF is not enough > for the large scale server with SR-IOV feature. > IPv6 requires the multicast MAC address for each IP address to handle > the Neighbor

Re: [PATCH v3 2/3] if_link: Add VF multicast promiscuous control

2015-04-08 Thread Jeff Kirsher
On Wed, 2015-04-08 at 05:37 +, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > Add netlink directives and ndo entry to allow VF multicast promiscuous > mode. > > This controls the permission to enter VF multicast promiscuous mode. > The administrator will dedicatedly allow multicast p

Re: [PATCH v3 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode

2015-04-08 Thread Jeff Kirsher
On Wed, 2015-04-08 at 05:38 +, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > Implements the new netdev op to allow VF multicast promiscuous mode. > > The multicast promiscuous mode is not allowed for all VFs by default. > > The administrator can allow to VF multicast promiscuous mo

Re: [PATCH] ethernet: e1000e: define lat_ns as u64 instead of s64

2015-04-08 Thread Jeff Kirsher
On Wed, 2015-04-08 at 09:40 +, David Laight wrote: > From: yanjiang@windriver.com > > Sent: 03 April 2015 10:18 > > From: Yanjiang Jin > > > > do_div() expects the type of "n" to be uint64_t, define "lat_ns" as u64 to > > avoid the below warning, also update its correlative operations and

Re: [net][resubmit] MAINTAINERS: Update Intel Wired Ethernet Driver info

2015-03-31 Thread Jeff Kirsher
On Tue, 2015-03-31 at 21:42 -0700, Jeff Kirsher wrote: > Update the git tree info with a recent change in tree names. Also > add our new mailing list created solely for Linux kernel patches > and kernel development, as well as the new patchwork project for > tracking patches. Lastl

[net][resubmit] MAINTAINERS: Update Intel Wired Ethernet Driver info

2015-03-31 Thread Jeff Kirsher
e moved on to different projects. Made an update to the section header so that it is more manageable going forward as we add new drivers. Signed-off-by: Jeff Kirsher --- MAINTAINERS | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/MAINTAINERS b/M

Re: [E1000-devel] [net] Intel Wired LAN Driver Updates

2015-03-31 Thread Jeff Kirsher
On Tue, 2015-03-31 at 19:19 -0700, Jeff Kirsher wrote: > On Tue, 2015-03-31 at 13:22 -0400, David Miller wrote: > > From: Jeff Kirsher > > Date: Fri, 27 Mar 2015 16:04:10 -0700 > > > > > The following are changes since commit > > dde93dfea53c72b07907d9e44a6e4b

Re: [net] Intel Wired LAN Driver Updates

2015-03-31 Thread Jeff Kirsher
On Tue, 2015-03-31 at 13:22 -0400, David Miller wrote: > From: Jeff Kirsher > Date: Fri, 27 Mar 2015 16:04:10 -0700 > > > The following are changes since commit > dde93dfea53c72b07907d9e44a6e4b1545f6bdc4: > > cxgb4: Fix frame size warning for 32 bit arch > >

Re: [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0

2015-03-30 Thread Jeff Kirsher
On Sun, 2015-03-29 at 18:25 -0700, Joe Perches wrote: > Use bool constants as the return values instead of 1 and 0. > > Signed-off-by: Joe Perches Acked-by: Jeff Kirsher For the ixgbe changes... > --- > > To be honest I'd might rather get bunches of these, there has to

  1   2   3   4   >