rent
devices later with similar part numbers. Therefore, some subsystems (e.g.
iio) tend to frown upon wildcards for that reason.
You should try and make the driver cover as many devices as possible. But
if the driver is only known to work for one device then I don't think you
can use a wildcard in the name unl
a(client);
> - int error, error_bl;
> + int error, error_bl = 0;
> u8 *pmap;
>
> if (iqs5xx->bl_status == IQS5XX_BL_STATUS_NONE)
> --
> 2.29.2
>
Kind regards,
Jeff LaBundy
Hi Alexander,
Thanks again for your work on this.
On Fri, Jan 15, 2021 at 10:42:39AM +0100, Alexander Dahl wrote:
> Hello Jeff,
>
> On Thu, Jan 14, 2021 at 09:50:50PM -0600, Jeff LaBundy wrote:
> > On Thu, Jan 14, 2021 at 10:03:12AM +, Lee Jones wrote:
> > > On Mon
-off-by: Jeff LaBundy
Acked-for-MFD-by: Lee Jones
---
Changes in v2:
- Added Acked-for-MFD-by trailer
drivers/mfd/iqs62x.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/mfd/iqs62x.c b/drivers/mfd/iqs62x.c
index 9b5c389..d1fc38a 100644
--- a/drivers/mfd/iqs62x.c
+++ b
registered until this happens.
The former logic that scaled ATI timeout and filter settling delay
is not carried forward with the new implementation, as it produces
overly conservative delays at lower clock rates. Instead, a single
pair of delays that covers all cases is used.
Signed-off-by: Jeff
The register write that performed a mandatory soft reset during
probe was removed during development of the driver, however the
IQS62X_SYS_SETTINGS_SOFT_RESET bit mask was left behind. Remove
it to keep stray macros out of the driver.
Signed-off-by: Jeff LaBundy
Acked-for-MFD-by: Lee Jones
us) plus margin.
Signed-off-by: Jeff LaBundy
Acked-for-MFD-by: Lee Jones
---
Changes in v2:
- Added Acked-for-MFD-by trailer
drivers/mfd/iqs62x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/iqs62x.c b/drivers/mfd/iqs62x.c
index 7a1ff7c..07c9725 100644
The regmap member of the driver's private data is called 'regmap',
but the regmap_config struct is called 'iqs62x_map_config'. Rename
the latter to 'iqs62x_regmap_config' for consistency.
Signed-off-by: Jeff LaBundy
Acked-for-MFD-by: Lee Jones
---
Changes in v2:
- Added Acked-for-MFD
("treewide: Use fallthrough pseudo-keyword")
Signed-off-by: Jeff LaBundy
Acked-for-MFD-by: Lee Jones
---
Changes in v2:
- Added Acked-for-MFD-by trailer
drivers/mfd/iqs62x.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mfd/iqs62x.c b/drivers/mfd/iqs62x.c
index 761b4e
with other Azoteq
devices that have similar functions.
Jeff LaBundy (6):
mfd: iqs62x: Remove superfluous whitespace above fallthroughs
mfd: iqs62x: Remove unused bit mask
mfd: iqs62x: Rename regmap_config struct
mfd: iqs62x: Increase interrupt handler return delay
mfd: iqs62x: Do not poll
Hi Lee,
Thank you for taking a look at the series.
On Thu, Jan 14, 2021 at 10:17:11AM +, Lee Jones wrote:
> On Sun, 03 Jan 2021, Jeff LaBundy wrote:
>
> > After loading firmware, the driver triggers ATI (calibration) with
> > the newly loaded register configurat
leds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$',
> > 'pinctrl-[0-9]+'
> > From schema:
> > /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> >
> > Signed-off-by: Alexander Dahl
> > A
Hi Dmitry,
On Sun, Jan 03, 2021 at 05:58:41PM -0800, Dmitry Torokhov wrote:
> Hi Jeff,
>
> On Sat, Dec 19, 2020 at 08:01:09PM -0600, Jeff LaBundy wrote:
> > Hi Dmitry,
> >
> > On Fri, Dec 18, 2020 at 04:49:48PM +, Roy Im wrote:
> > > On Friday, Decemb
The register write that performed a mandatory soft reset during
probe was removed during development of the driver, however the
IQS62X_SYS_SETTINGS_SOFT_RESET bit mask was left behind. Remove
it to keep stray macros out of the driver.
Signed-off-by: Jeff LaBundy
---
drivers/mfd/iqs62x.c | 1
us) plus margin.
Signed-off-by: Jeff LaBundy
---
drivers/mfd/iqs62x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/iqs62x.c b/drivers/mfd/iqs62x.c
index 7a1ff7c..07c9725 100644
--- a/drivers/mfd/iqs62x.c
+++ b/drivers/mfd/iqs62x.c
@@ -533,7 +533,7 @@ static
The regmap member of the driver's private data is called 'regmap',
but the regmap_config struct is called 'iqs62x_map_config'. Rename
the latter to 'iqs62x_regmap_config' for consistency.
Signed-off-by: Jeff LaBundy
---
drivers/mfd/iqs62x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
-off-by: Jeff LaBundy
---
drivers/mfd/iqs62x.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/mfd/iqs62x.c b/drivers/mfd/iqs62x.c
index 9fdf32f..3b32542 100644
--- a/drivers/mfd/iqs62x.c
+++ b/drivers/mfd/iqs62x.c
@@ -81,6 +81,7 @@
#define IQS62X_FW_REC_TYPE_MASK
registered until this happens.
The former logic that scaled ATI timeout and filter settling delay
is not carried forward with the new implementation, as it produces
overly conservative delays at lower clock rates. Instead, a single
pair of delays that covers all cases is used.
Signed-off-by: Jeff
with other Azoteq
devices that have similar functions.
Jeff LaBundy (6):
mfd: iqs62x: Remove superfluous whitespace above fallthroughs
mfd: iqs62x: Remove unused bit mask
mfd: iqs62x: Rename regmap_config struct
mfd: iqs62x: Increase interrupt handler return delay
mfd: iqs62x: Do not poll
("treewide: Use fallthrough pseudo-keyword")
Signed-off-by: Jeff LaBundy
---
drivers/mfd/iqs62x.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mfd/iqs62x.c b/drivers/mfd/iqs62x.c
index 761b4ef..ec4c790 100644
--- a/drivers/mfd/iqs62x.c
+++ b/drivers/mfd/iqs62x.c
@@ -13
vice.h? This includes mod_devicetable.h which
in turn defines the of_device_id struct (even if CONFIG_OF is
not set).
The reason for asking is because it seems many drivers do not
include these guards.
> >
> > static const struct i2c_device_id da7280_i2c_id[] = {
> > { "da7280", },
> > --
> > 2.29.2.729.g45daf8777d-goog
> >
> >
> > --
> > Dmitry
>
> Thanks!
>
> Acked-by: Roy Im
>
Kind regards,
Jeff LaBundy
-
> 2.20.1
>
I like the consistency this brings. My only feedback is that in the other
examples I found (common.yaml and leds-gpio.yaml), the children count off
from 0 (e.g. led-0) instead of 1 as your series appears to.
That's not a huge deal; it simply seems more consistent to count from the
first index allowed by the regex (0). The patch is still fine, and so:
Acked-by: Jeff LaBundy
Kind regards,
Jeff LaBundy
of the
> iio_priv_to_dev() altogether.
>
> For this driver, removing iio_priv_to_dev() means keeping a reference
> on the state struct.
>
> Signed-off-by: Alexandru Ardelean
> ---
> drivers/iio/light/iqs621-als.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
deletions(-)
As a customer of iio, I find it handy that there is an "inverse" to iio_priv.
In this particular case it saves the container iio_dev from storing a pointer
to itself.
That being said, this patch is perfectly fine and I have no objection if this
is the route you and Jonathan o
lecting I2C for me. Valuable lesson learned :)
The kbuild test robot set off the alarm bells earlier today and I've
sent a patch [1] already. Many apologies for all of the noise.
>
> --
> ~Randy
> Reported-by: Randy Dunlap
[1] https://patchwork.kernel.org/patch/11555469/
Kind regards,
Jeff LaBundy
25 matches
Mail list logo
