Re: [PATCH V2 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

On 2018-03-19 5:32 AM, Vijay Viswanath wrote: On 3/7/2018 9:42 PM, Doug Anderson wrote: Hi, On Tue, Mar 6, 2018 at 11:13 PM, Vijay Viswanath <vvisw...@codeaurora.org> wrote: Hi Dough, Jeremy, On 3/3/2018 4:38 AM, Jeremy McNicoll wrote: On 2018-03-02 10:23 AM, Doug Anderson wrote

Re: [PATCH V2 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

On 2018-03-19 5:32 AM, Vijay Viswanath wrote: On 3/7/2018 9:42 PM, Doug Anderson wrote: Hi, On Tue, Mar 6, 2018 at 11:13 PM, Vijay Viswanath wrote: Hi Dough, Jeremy, On 3/3/2018 4:38 AM, Jeremy McNicoll wrote: On 2018-03-02 10:23 AM, Doug Anderson wrote: Hi, On Sun, Feb 11, 2018

Re: [PATCH V2 2/2] mmc: sdhci-msm: support voltage pad switching

On 2018-03-02 10:25 AM, Doug Anderson wrote: Hi, On Sun, Feb 11, 2018 at 10:01 PM, Vijay Viswanath wrote: From: Krishna Konda The PADs for SD card are dual-voltage that support 3v/1.8v. Those PADs have a control signal

Re: [PATCH V2 2/2] mmc: sdhci-msm: support voltage pad switching

On 2018-03-02 10:25 AM, Doug Anderson wrote: Hi, On Sun, Feb 11, 2018 at 10:01 PM, Vijay Viswanath wrote: From: Krishna Konda The PADs for SD card are dual-voltage that support 3v/1.8v. Those PADs have a control signal (io_pad_pwr_switch/mode18 ) that indicates whether the PAD works in 3v

Re: [PATCH V2 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

On 2018-03-02 10:23 AM, Doug Anderson wrote: Hi, On Sun, Feb 11, 2018 at 10:01 PM, Vijay Viswanath wrote: During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device.

Re: [PATCH V2 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

On 2018-03-02 10:23 AM, Doug Anderson wrote: Hi, On Sun, Feb 11, 2018 at 10:01 PM, Vijay Viswanath wrote: During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device. Signed-off-by: Vijay

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

On 2018-02-27 1:26 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 12:15:28PM -0800, Jeremy McNicoll wrote: On 2018-02-26 11:46 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 11:28:16AM -0800, Jeremy McNicoll wrote: On 2018-02-26 5:38 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

On 2018-02-27 1:26 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 12:15:28PM -0800, Jeremy McNicoll wrote: On 2018-02-26 11:46 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 11:28:16AM -0800, Jeremy McNicoll wrote: On 2018-02-26 5:38 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

On 2018-02-26 11:46 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 11:28:16AM -0800, Jeremy McNicoll wrote: On 2018-02-26 5:38 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 12:20:29PM +0200, Mika Westerberg wrote: On Thu, Feb 22, 2018 at 03:17:38PM -0800, Jeremy McNicoll wrote

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

On 2018-02-26 11:46 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 11:28:16AM -0800, Jeremy McNicoll wrote: On 2018-02-26 5:38 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 12:20:29PM +0200, Mika Westerberg wrote: On Thu, Feb 22, 2018 at 03:17:38PM -0800, Jeremy McNicoll wrote

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

On 2018-02-26 5:38 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 12:20:29PM +0200, Mika Westerberg wrote: On Thu, Feb 22, 2018 at 03:17:38PM -0800, Jeremy McNicoll wrote: + if (pkg->link_info & ICM_LINK_INFO_REJECTED) { + tb_info(tb, "switch at %u.%u

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

On 2018-02-26 5:38 AM, Mika Westerberg wrote: On Mon, Feb 26, 2018 at 12:20:29PM +0200, Mika Westerberg wrote: On Thu, Feb 22, 2018 at 03:17:38PM -0800, Jeremy McNicoll wrote: + if (pkg->link_info & ICM_LINK_INFO_REJECTED) { + tb_info(tb, "switch at %u.%u

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

On Tue, Feb 13, 2018 at 08:00:07PM +0300, Mika Westerberg wrote: > The ICM firmware may reject devices for different reasons, even if we > have asked it to accept anything. If we notice a device is rejected, we > just log the event and bail out. > > Signed-off-by: Mika Westerberg

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

On Tue, Feb 13, 2018 at 08:00:07PM +0300, Mika Westerberg wrote: > The ICM firmware may reject devices for different reasons, even if we > have asked it to accept anything. If we notice a device is rejected, we > just log the event and bail out. > > Signed-off-by: Mika Westerberg > --- >

Re: [PATCH 0/5] Qualcomm SMD updates

On Tue, Dec 12, 2017 at 03:58:52PM -0800, Bjorn Andersson wrote: > A series of fixes for a few issues reported or seen with SMD. > > The first two fixes changes the trigger for creating devices for channels > found, which should cause the rpm-smd driver to probe on 8909 and 8994 > devices. >

Re: [PATCH 0/5] Qualcomm SMD updates

On Tue, Dec 12, 2017 at 03:58:52PM -0800, Bjorn Andersson wrote: > A series of fixes for a few issues reported or seen with SMD. > > The first two fixes changes the trigger for creating devices for channels > found, which should cause the rpm-smd driver to probe on 8909 and 8994 > devices. >

Re: [PATCH 1/5] rpmsg: smd: Perform handshake during open

On Tue, Dec 12, 2017 at 03:58:53PM -0800, Bjorn Andersson wrote: > Validate the the remote side is opening the channel that we've found by > performing a handshake when opening the channel. > > Signed-off-by: Bjorn Andersson > --- > drivers/rpmsg/qcom_smd.c | 30

Re: [PATCH 1/5] rpmsg: smd: Perform handshake during open

On Tue, Dec 12, 2017 at 03:58:53PM -0800, Bjorn Andersson wrote: > Validate the the remote side is opening the channel that we've found by > performing a handshake when opening the channel. > > Signed-off-by: Bjorn Andersson > --- > drivers/rpmsg/qcom_smd.c | 30 ++ >

Re: [PATCH 2/5] rpmsg: smd: Create device for all channels

in a state other than "opening" after the boot > loader's closing of the channel. > Its been a while since I looked at this closely but, isn't the result of this patch that we now will create a channel / register a platform device if the state of the channel is left in any state. &g

Re: [PATCH 2/5] rpmsg: smd: Create device for all channels

in a state other than "opening" after the boot > loader's closing of the channel. > Its been a while since I looked at this closely but, isn't the result of this patch that we now will create a channel / register a platform device if the state of the channel is left in any state. >

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

000>; > + ftrace-size = <0x1>; > + pmsg-size = <0x8>; We could pad this with leading 0's but I find this much easier to read. > + }; > + }; > }; Thank you very much for taking the time to send this. Acked-by: Jeremy McNicoll <jerem...@redhat.com>

Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

trace-size = <0x1>; > + pmsg-size = <0x8>; We could pad this with leading 0's but I find this much easier to read. > + }; > + }; > }; Thank you very much for taking the time to send this. Acked-by: Jeremy McNicoll

Re: [PATCH v2 0/2] Support SDHCI on 8974pro devices

rtition 1 4.00 MiB mmcblk0boot1: mmc0:0001 016G72 partition 2 4.00 MiB mmcblk0rpmb: mmc0:0001 016G72 partition 3 4.00 MiB mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 p13 p14 p15 are appearing in my boot messages / debug spew. Tested-by: Jeremy McNicoll <jerem...@redhat.com> -jeremy

Re: [PATCH v2 0/2] Support SDHCI on 8974pro devices

rtition 1 4.00 MiB mmcblk0boot1: mmc0:0001 016G72 partition 2 4.00 MiB mmcblk0rpmb: mmc0:0001 016G72 partition 3 4.00 MiB mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 p13 p14 p15 are appearing in my boot messages / debug spew. Tested-by: Jeremy McNicoll -jeremy

Re: [PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd

> On Jan 27, 2017, at 10:23 AM, Florian Fainelli wrote: > > On 01/27/2017 12:04 AM, Gerd Hoffmann wrote: >> On Do, 2017-01-26 at 15:51 -0800, Florian Fainelli wrote: >>> On 01/26/2017 03:37 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann >>>

Re: [PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd

> On Jan 27, 2017, at 10:23 AM, Florian Fainelli wrote: > > On 01/27/2017 12:04 AM, Gerd Hoffmann wrote: >> On Do, 2017-01-26 at 15:51 -0800, Florian Fainelli wrote: >>> On 01/26/2017 03:37 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann >>> >>> Few things with your submission: >>>

Re: [RFC PATCH 0/3] mmc: sdhci: sdhci-msm: Add more debug logs

vers/mmc/host/sdhci.h | 1 + > 3 files changed, 57 insertions(+), 2 deletions(-) > This series was part of my SDHCI enablement on my Nexus 5X and everything still seems to work ok. Tested-by: Jeremy McNicoll <jerem...@redhat.com> > -- > The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project. >

Re: [RFC PATCH 0/3] mmc: sdhci: sdhci-msm: Add more debug logs

vers/mmc/host/sdhci.h | 1 + > 3 files changed, 57 insertions(+), 2 deletions(-) > This series was part of my SDHCI enablement on my Nexus 5X and everything still seems to work ok. Tested-by: Jeremy McNicoll > -- > The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project. >

Re: [RESEND PATCHv1 0/8] mmc: sdhci-msm: Provide support for enhanced strobe

24900.mmc: TCXO clk not present (-2) " Is that something I am missing on my side? In anycase, Tested-by: Jeremy McNicoll <jerem...@redhat.com> -jeremy > Ritesh Harjani (6): > mmc: sdhci-msm: Factor out sdhci_msm_hc_select_mode > mmc: sdhci-msm: Factor out fu

Re: [RESEND PATCHv1 0/8] mmc: sdhci-msm: Provide support for enhanced strobe

24900.mmc: TCXO clk not present (-2) " Is that something I am missing on my side? In anycase, Tested-by: Jeremy McNicoll -jeremy > Ritesh Harjani (6): > mmc: sdhci-msm: Factor out sdhci_msm_hc_select_mode > mmc: sdhci-msm: Factor out function to set/get msm clock rate >

Re: [RFC PATCH 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.

On Mon, Jan 16, 2017 at 07:45:48AM +0530, Ritesh Harjani wrote: > Hi Jeremy, > > Thanks for the review. > > On 1/14/2017 3:51 AM, Jeremy McNicoll wrote: > >On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote: > >>From: Sahitya Tummala <stumm...@code

Re: [RFC PATCH 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.

On Mon, Jan 16, 2017 at 07:45:48AM +0530, Ritesh Harjani wrote: > Hi Jeremy, > > Thanks for the review. > > On 1/14/2017 3:51 AM, Jeremy McNicoll wrote: > >On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote: > >>From: Sahitya Tummala &

Re: [RFC PATCH 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm

On Mon, Jan 16, 2017 at 07:51:40AM +0530, Ritesh Harjani wrote: > Hi Jeremy, > > On 1/14/2017 4:01 AM, Jeremy McNicoll wrote: > >On Fri, Dec 30, 2016 at 05:02:10PM +0530, Ritesh Harjani wrote: > >>From: Sahitya Tummala <stumm...@codeaurora.org> > >>

Re: [RFC PATCH 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm

On Mon, Jan 16, 2017 at 07:51:40AM +0530, Ritesh Harjani wrote: > Hi Jeremy, > > On 1/14/2017 4:01 AM, Jeremy McNicoll wrote: > >On Fri, Dec 30, 2016 at 05:02:10PM +0530, Ritesh Harjani wrote: > >>From: Sahitya Tummala > >> > >>Implement -

Re: [RFC PATCH 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm

On Fri, Dec 30, 2016 at 05:02:10PM +0530, Ritesh Harjani wrote: > From: Sahitya Tummala > > Implement ->platform_dumpregs host operation to print the > platform specific registers in addition to standard SDHC > register during error conditions. > > Signed-off-by:

Re: [RFC PATCH 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm

On Fri, Dec 30, 2016 at 05:02:10PM +0530, Ritesh Harjani wrote: > From: Sahitya Tummala > > Implement ->platform_dumpregs host operation to print the > platform specific registers in addition to standard SDHC > register during error conditions. > > Signed-off-by: Sahitya Tummala >

Re: [RFC PATCH 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.

On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote: > From: Sahitya Tummala > > Add new host operation ->platform_dumpregs to provide a > mechanism through which host drivers can dump platform > specific registers in addition to SDHC registers > during error

Re: [RFC PATCH 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.

On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote: > From: Sahitya Tummala > > Add new host operation ->platform_dumpregs to provide a > mechanism through which host drivers can dump platform > specific registers in addition to SDHC registers > during error conditions. > >

Re: [PATCH v2] rpmsg: qcom_smd: Add support for "label" property

On 2016-12-02 2:06 PM, Bjorn Andersson wrote: Add support for the "label" property, used to give the edge a name other than the one of the DT node. This allows the implementor to provide consistently named edges when using the rpmsg character device. Signed-off-by: Bjorn Andersson

Re: [PATCH v2] rpmsg: qcom_smd: Add support for "label" property

On 2016-12-02 2:06 PM, Bjorn Andersson wrote: Add support for the "label" property, used to give the edge a name other than the one of the DT node. This allows the implementor to provide consistently named edges when using the rpmsg character device. Signed-off-by: Bjorn Andersson --- Changes

Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver

On 2016-11-02 11:36 AM, Stephen Boyd wrote: On 11/01, Michael Scott wrote: On 11/01/2016 04:53 PM, Stephen Boyd wrote: On 10/31, Michael Scott wrote: + +static const struct msm_pingroup msm8994_groups[] = { + PINGROUP(0, blsp_spi1, blsp_uart1, blsp_uim1, NA, NA, NA, NA, NA, NA, +

Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver

On 2016-11-02 11:36 AM, Stephen Boyd wrote: On 11/01, Michael Scott wrote: On 11/01/2016 04:53 PM, Stephen Boyd wrote: On 10/31, Michael Scott wrote: + +static const struct msm_pingroup msm8994_groups[] = { + PINGROUP(0, blsp_spi1, blsp_uart1, blsp_uim1, NA, NA, NA, NA, NA, NA, +

Re: [PATCH V2] pinctrl: qcom: Add msm8994 pinctrl driver

On 2016-10-26 4:32 PM, Michael Scott wrote: Initial pinctrl driver for QCOM msm8994 platforms. In order to continue the initial board support for QCOM msm8994/msm8992 presented in patches from Jeremy McNicoll <jerem...@redhat.com>, let's put a proper pinctrl driver in place. Currently,

Re: [PATCH V2] pinctrl: qcom: Add msm8994 pinctrl driver

On 2016-10-26 4:32 PM, Michael Scott wrote: Initial pinctrl driver for QCOM msm8994 platforms. In order to continue the initial board support for QCOM msm8994/msm8992 presented in patches from Jeremy McNicoll , let's put a proper pinctrl driver in place. Currently, the DT for these platforms

Re: [PATCH] pinctrl: qcom: Add msm8994 pinctrl driver

On Fri, Oct 21, 2016 at 03:42:50PM -0700, Michael Scott wrote: > Initial pinctrl driver for QCOM msm8994 platforms. > > In order to continue the initial board support for QCOM msm8994/msm8992 > presented in patches from Jeremy McNicoll <jerem...@redhat.com>, let's put > a

Re: [PATCH] pinctrl: qcom: Add msm8994 pinctrl driver

On Fri, Oct 21, 2016 at 03:42:50PM -0700, Michael Scott wrote: > Initial pinctrl driver for QCOM msm8994 platforms. > > In order to continue the initial board support for QCOM msm8994/msm8992 > presented in patches from Jeremy McNicoll , let's put > a proper pinctrl