Re: [PATCH] net: key: af_key: Fix possible null-pointer dereferences in pfkey_send_policy_notify()

2019-07-26 Thread Jeremy Sowden
On 2019-07-26, at 11:45:14 +0200, Steffen Klassert wrote: > On Wed, Jul 24, 2019 at 05:35:09PM +0800, Jia-Ju Bai wrote: > > In pfkey_send_policy_notify(), there is an if statement on line 3081 > > to check whether xp is NULL: > > if (xp && xp->type != XFRM_POLICY_TYPE_MAIN) > > > > When xp is N

Re: [PATCH] af_key: Fix memory leak in key_notify_policy.

2019-06-14 Thread Jeremy Sowden
On 2019-06-14, at 10:53:46 +0200, Steffen Klassert wrote: > On Fri, Jun 14, 2019 at 04:26:26PM +0800, Young Xiao wrote: > > We leak the allocated out_skb in case pfkey_xfrm_policy2msg() fails. > > Fix this by freeing it on error. > > > > Signed-off-by: Young Xiao <92siuy...@gmail.com> > > --- > >

Re: memory leak in vhost_net_ioctl

2019-06-14 Thread Jeremy Sowden
On 2019-06-13, at 20:04:01 -0700, syzbot wrote: > syzbot has tested the proposed patch but the reproducer still > triggered crash: memory leak in batadv_tvlv_handler_register There's already a fix for this batman leak: https://lore.kernel.org/netdev/17d64c058965f...@google.com/ ht

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Jeremy Sowden
On 2019-05-23, at 13:51:18 +0530, Nishka Dasgupta wrote: > On 23/05/19 12:52 PM, Greg KH wrote: > > On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > > > In the functions export_reset_0 and export_reset_1 in > > > arcx-anybus.c, the only operation performed before return is > > > p

Re: [PATCH] staging: rtl8723bs: Add missing blank lines

2019-05-22 Thread Jeremy Sowden
On 2019-05-21, at 21:46:55 -0300, Fabio Lima wrote: > This patch resolves the following warning from checkpatch.pl > WARNING: Missing a blank line after declarations > > Signed-off-by: Fabio Lima > --- > drivers/staging/rtl8723bs/core/rtw_debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH] staging: ks7010: remove redundant auth_type check

2019-03-18 Thread Jeremy Sowden
iv->rx_size, > + 0, mic); > + if (ret < 0) > + return ret; > if (memcmp(mic, recv_mic, sizeof(mic)) != 0) { > now = jiffies; > mic_failure = &priv->wpa.mic_failure; Acked-by: Jeremy Sowden

[PATCH] vti4: ipip tunnel deregistration fixes.

2019-03-14 Thread Jeremy Sowden
x27;IPCOMP' virtual tunnel") Signed-off-by: Jeremy Sowden --- net/ipv4/ip_vti.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c index 68a21bf75dd0..b6235ca09fa5 100644 --- a/net/ipv4/ip_vti.c +++ b/net/ipv4/ip_vti.c @@ -659,9

Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

2019-03-11 Thread Jeremy Sowden
On 2019-03-11, at 11:31:59 +0300, Dan Carpenter wrote: > On Mon, Mar 11, 2019 at 10:12:48AM +0200, Alexandru Ardelean wrote: > > On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio > > wrote: > > > > > > Add spaces around minus operator to fix readibility. > > > > > > Signed-off-by: Karen Palacio > >

Re: [PATCH] checkpatch: fix for stripping brackets from macros.

2017-12-18 Thread Jeremy Sowden
On 2017-12-18, at 07:12:50 -0800, Joe Perches wrote: > On Mon, 2017-12-18 at 14:17 +0000, Jeremy Sowden wrote: > > When checking macros, checkpatch.pl strips parentheses, square > > brackets and braces. However, the search-and-replace expression was > > not correct, and ins

[PATCH] checkpatch: fix for stripping brackets from macros.

2017-12-18 Thread Jeremy Sowden
When checking macros, checkpatch.pl strips parentheses, square brackets and braces. However, the search-and-replace expression was not correct, and instead of replacing the brackets and their contents with just the contents, it was replacing them with literal 1's. Signed-off-by: Jeremy S