[PATCH] tpm: remove unneeded include of actbl2.h

tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h -> acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c is not needed. Signed-off-by: Jerry Snitselaar --- Jarrko, this is a trivial thing I noticed while doing some work. Not sure if you guys care, but th

[PATCH] tpm: remove unneeded include of actbl2.h

tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h -> acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c is not needed. Signed-off-by: Jerry Snitselaar <jsnit...@redhat.com> --- Jarrko, this is a trivial thing I noticed while doing some work. Not sure i

Re: [tpmdd-devel] [PATCH] tpm: remove unneeded include of actbl2.h

On Mon Jan 04 16, Jerry Snitselaar wrote: tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h -> acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c is not needed. Signed-off-by: Jerry Snitselaar <jsnit...@redhat.com> --- Jarrko, this is a trivial

[PATCH] tracing: use seq_buf_used() in seq_buf_to_user() instead of len

len. Cleaned up the code a bit as well per suggestion of Steve Rostedt. Cc: "Steven Rostedt (Red Hat)" Signed-off-by: Jerry Snitselaar --- lib/seq_buf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/seq_buf.c b/lib/seq_buf.c index 5c94e10..cb18469 100

[PATCH] tracing: use seq_buf_used() in seq_buf_to_user() instead of len

len. Cleaned up the code a bit as well per suggestion of Steve Rostedt. Cc: "Steven Rostedt (Red Hat)" <rost...@goodmis.org> Signed-off-by: Jerry Snitselaar <jsnit...@redhat.com> --- lib/seq_buf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/

[PATCH] hv_netvsc: remove unused variable in netvsc_send()

With commit b56fc3c53654 ("hv_netvsc: Fix a bug in netvsc_start_xmit()"), skb variable is no longer used in netvsc_send. Remove variable and dead code that depended on it. Cc: Haiyang Zhang Cc: K. Y. Srinivasan Signed-off-by: Jerry Snitselaar --- drivers/net/hyperv/netvsc.c | 9 ++

[PATCH] hv_netvsc: remove unused variable in netvsc_send()

With commit b56fc3c53654 (hv_netvsc: Fix a bug in netvsc_start_xmit()), skb variable is no longer used in netvsc_send. Remove variable and dead code that depended on it. Cc: Haiyang Zhang haiya...@microsoft.com Cc: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Jerry Snitselaar jsnit

[PATCH v2] tracing: Export tracing clock functions

a tracepoint hook to sched_wakeup. They were using ktime_get() for a time source, but it grabs a seq lock and caused a deadlock to occur. v2: added background info and fixed typo Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Jerry Snitselaar --- kernel/trace/trace_clock.c | 3 +++ 1 file changed

[PATCH] tracing: Export tracing clock functions

Critical tracepoint hooks shoud never call anything that takes a lock, so they are unable to call getrawmonotonic() or ktime_get(). Export the rest of the tracing clock functions so can be used in tracepoint hooks. Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Jerry Snitselaar --- kernel

[PATCH v2] tracing: Export tracing clock functions

a tracepoint hook to sched_wakeup. They were using ktime_get() for a time source, but it grabs a seq lock and caused a deadlock to occur. v2: added background info and fixed typo Cc: Steven Rostedt rost...@goodmis.org Cc: Ingo Molnar mi...@redhat.com Signed-off-by: Jerry Snitselaar jsnit...@redhat.com

[PATCH] tracing: Export tracing clock functions

-off-by: Jerry Snitselaar jsnit...@redhat.com --- kernel/trace/trace_clock.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/trace/trace_clock.c b/kernel/trace/trace_clock.c index 57b67b1..0f06532 100644 --- a/kernel/trace/trace_clock.c +++ b/kernel/trace/trace_clock.c @@ -56,6 +56,7

Re: [PATCHv2] staging: Check against NULL in fw_download_code

On Mon Aug 11 14, Nicholas Krause wrote: > I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461. > This entry states that we are not checking the skb allocated in > fw_download_code > and after checking I fixed it to check for the NULL value before using the > allocate >

Re: [PATCHv2] staging: Check against NULL in fw_download_code

On Mon Aug 11 14, Nicholas Krause wrote: I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461. This entry states that we are not checking the skb allocated in fw_download_code and after checking I fixed it to check for the NULL value before using the allocate skb.

[PATCH] staging: binder: cleanup dereference of noderef expressions

Clean up sparse warnings for cred struct dereference. Signed-off-by: Jerry Snitselaar --- drivers/staging/android/binder.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index fc59281..6279d82

[PATCH] staging: binder: cleanup dereference of noderef expressions

Clean up sparse warnings for cred struct dereference. Signed-off-by: Jerry Snitselaar d...@snitselaar.org --- drivers/staging/android/binder.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index

[PATCH 2/2] virtio_scsi: space required before open parenthesis

Fix coding style warnings from checkpatch Signed-off-by: Jerry Snitselaar --- drivers/scsi/virtio_scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 9f2fccc..9248a1e 100644 --- a/drivers/scsi/virtio_scsi.c

[PATCH 1/2] virtio_scsi: blank line after declaration cleanup

Clean up of coding style warnings from checkpatch Signed-off-by: Jerry Snitselaar --- drivers/scsi/virtio_scsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 16bfd50..fa0b25f 100644 --- a/drivers/scsi

[PATCH 1/2] virtio_scsi: blank line after declaration cleanup

Clean up of coding style warnings from checkpatch Signed-off-by: Jerry Snitselaar d...@snitselaar.org --- drivers/scsi/virtio_scsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 16bfd50..fa0b25f 100644

[PATCH 2/2] virtio_scsi: space required before open parenthesis

Fix coding style warnings from checkpatch Signed-off-by: Jerry Snitselaar d...@snitselaar.org --- drivers/scsi/virtio_scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 9f2fccc..9248a1e 100644 --- a/drivers

[PATCH] staging/line6: blank line after declaration cleanup

Fix coding style warnings reported by checkpath. Signed-off-by: Jerry Snitselaar --- drivers/staging/line6/capture.c | 3 +++ drivers/staging/line6/midi.c | 2 ++ drivers/staging/line6/playback.c | 6 +- drivers/staging/line6/pod.c | 5 + drivers/staging/line6/toneport.c | 2

[PATCH] staging/line6: blank line after declaration cleanup

Fix coding style warnings reported by checkpath. Signed-off-by: Jerry Snitselaar d...@snitselaar.org --- drivers/staging/line6/capture.c | 3 +++ drivers/staging/line6/midi.c | 2 ++ drivers/staging/line6/playback.c | 6 +- drivers/staging/line6/pod.c | 5 + drivers/staging

suspicious RCU usage with unlazy_walk()

Running 3.11.0-07547-g44598f9 I hit the following last night. I have not had it reproduce since then. Should there be some lock cleanup in the error path prior to the dput() call like unlock_rcu_walk()? [ 1705.083706] === [ 1705.083709] [ INFO: suspicious RCU usage. ]

suspicious RCU usage with unlazy_walk()

Running 3.11.0-07547-g44598f9 I hit the following last night. I have not had it reproduce since then. Should there be some lock cleanup in the error path prior to the dput() call like unlock_rcu_walk()? [ 1705.083706] === [ 1705.083709] [ INFO: suspicious RCU usage. ]

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

On Tue Aug 20 13, Mika Westerberg wrote: > On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote: > > On Tue Aug 20 13, Rafael J. Wysocki wrote: > > > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: > > > > On Tue Aug 20 13, Rafael J. Wyso

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

On Tue Aug 20 13, Mika Westerberg wrote: On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote: On Tue Aug 20 13, Rafael J. Wysocki wrote: On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: On Tue Aug 20 13, Rafael J. Wysocki wrote: On Monday, August 19, 2013

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

On Tue Aug 20 13, Rafael J. Wysocki wrote: > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: > > On Tue Aug 20 13, Rafael J. Wysocki wrote: > > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > > > On Fri, Aug 16, 2013 at 06:26:35PM

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

On Tue Aug 20 13, Rafael J. Wysocki wrote: > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > > > Without MODULE_LICENSE set, I get the following with modprobe: > > > > > > a

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

On Tue Aug 20 13, Rafael J. Wysocki wrote: On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: Without MODULE_LICENSE set, I get the following with modprobe: acpi_i2c: module license 'unspecified' taints

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

On Tue Aug 20 13, Rafael J. Wysocki wrote: On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: On Tue Aug 20 13, Rafael J. Wysocki wrote: On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

Sorry for the double send. This one was apparently blocked by the greylisting on vger.kernel.org and it was hours before I received notification of that. I forgot to bcc myself and had no record of the git send-email successfully completing. Just ignore this patch. Jerry -- To unsubscribe from

[PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

: Unknown symbol acpi_dev_free_resource_list (err 0) Signed-off-by: Jerry Snitselaar --- drivers/acpi/acpi_i2c.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c index 82045e3..2c5c65d 100644 --- a/drivers/acpi/acpi_i2c.c +++ b/drivers/acpi

[PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

: Unknown symbol acpi_dev_free_resource_list (err 0) Signed-off-by: Jerry Snitselaar --- drivers/acpi/acpi_i2c.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c index 82045e3..2c5c65d 100644 --- a/drivers/acpi/acpi_i2c.c +++ b/drivers/acpi

[PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

: Unknown symbol acpi_dev_free_resource_list (err 0) Signed-off-by: Jerry Snitselaar jerry.snitsel...@oracle.com --- drivers/acpi/acpi_i2c.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c index 82045e3..2c5c65d 100644 --- a/drivers/acpi

[PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

: Unknown symbol acpi_dev_free_resource_list (err 0) Signed-off-by: Jerry Snitselaar jerry.snitsel...@oracle.com --- drivers/acpi/acpi_i2c.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c index 82045e3..2c5c65d 100644 --- a/drivers/acpi

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

Sorry for the double send. This one was apparently blocked by the greylisting on vger.kernel.org and it was hours before I received notification of that. I forgot to bcc myself and had no record of the git send-email successfully completing. Just ignore this patch. Jerry -- To unsubscribe from

[PATCH] fib_trie: potential out of bounds access in trie_show_stats()

With the <= max condition in the for loop, it will be always go 1 element further than needed. If the condition for the while loop is never met, then max is MAX_STAT_DEPTH, and for loop will walk off the end of nodesizes[]. Signed-off-by: Jerry Snitselaar --- net/ipv4/fib_trie.c | 2 +- 1 f

[PATCH] fib_trie: potential out of bounds access in trie_show_stats()

With the = max condition in the for loop, it will be always go 1 element further than needed. If the condition for the while loop is never met, then max is MAX_STAT_DEPTH, and for loop will walk off the end of nodesizes[]. Signed-off-by: Jerry Snitselaar jerry.snitsel...@oracle.com --- net/ipv4

[PATCH] btrfs: return EPERM in btrfs_rm_device()

Currently there are error paths in btrfs_rm_device() where EINVAL is returned telling the user they passed an invalid argument even though they passed a valid device. Change to return EPERM instead as the operation is not permitted. Signed-off-by: Jerry Snitselaar --- fs/btrfs/volumes.c | 8

[PATCH] btrfs: return EPERM in btrfs_rm_device()

Currently there are error paths in btrfs_rm_device() where EINVAL is returned telling the user they passed an invalid argument even though they passed a valid device. Change to return EPERM instead as the operation is not permitted. Signed-off-by: Jerry Snitselaar jerry.snitsel...@oracle.com

[PATCH] device_cgroup: don't grab mutex in rcu callback

st cleanup in devcgroup_css_free(). Signed-off-by: Jerry Snitselaar Acked-by: Tejun Heo Acked-by: Aristeu Rozanski --- security/device_cgroup.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/security/device_cgroup.c b/security/device_cgroup.c index d794abc..1c69

[PATCH] device_cgroup: don't grab mutex in rcu callback

in devcgroup_css_free(). Signed-off-by: Jerry Snitselaar jerry.snitsel...@oracle.com Acked-by: Tejun Heo t...@kernel.org Acked-by: Aristeu Rozanski a...@redhat.com --- security/device_cgroup.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/security/device_cgroup.c b

Re: [ 11/15] ahci: Add identifiers for ASM106x devices

On Thu Jan 24 13, Greg Kroah-Hartman wrote: > 3.0-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Alan Cox > > commit 7b4f6ecacb14f384adc1a5a67ad95eb082c02bd1 upstream. > > They don't always appear as AHCI class devices but instead as

Re: [ 11/15] ahci: Add identifiers for ASM106x devices

On Thu Jan 24 13, Greg Kroah-Hartman wrote: 3.0-stable review patch. If anyone has any objections, please let me know. -- From: Alan Cox a...@linux.intel.com commit 7b4f6ecacb14f384adc1a5a67ad95eb082c02bd1 upstream. They don't always appear as AHCI class devices but

[PATCH] device_cgroup: don't grab mutex in rcu callback

st cleanup in devcgroup_css_free(). Signed-off-by: Jerry Snitselaar Acked-by: Tejun Heo --- security/device_cgroup.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/security/device_cgroup.c b/security/device_cgroup.c index d794abc..1c69e38 100644 --- a/security/devic

[PATCH] device_cgroup: don't grab mutex in rcu callback

in devcgroup_css_free(). Signed-off-by: Jerry Snitselaar jerry.snitsel...@oracle.com Acked-by: Tejun Heo t...@kernel.org --- security/device_cgroup.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/security/device_cgroup.c b/security/device_cgroup.c index d794abc..1c69e38

section mismatch for acpi_unmap_lsapic()

Commit 13ad20c1 "x86 cpu_hotplug: unmap cpu2node when the cpu is hotremoved" in linux-next added code to acpi_unmap_lsapic() that causes section mismatch warnings: WARNING: vmlinux.o(.text+0x694f2): Section mismatch in reference from the function acpi_unmap_lsapic() to the function

section mismatch for acpi_unmap_lsapic()

Commit 13ad20c1 x86 cpu_hotplug: unmap cpu2node when the cpu is hotremoved in linux-next added code to acpi_unmap_lsapic() that causes section mismatch warnings: WARNING: vmlinux.o(.text+0x694f2): Section mismatch in reference from the function acpi_unmap_lsapic() to the function

Re: [PATCH] x86: revert "x86: Fix S4 regression"

On Sat Aug 11 12, Jerry Snitselaar wrote: > On Wed Jul 25 12, Takao Indoh wrote: > > >Thanks for tracking this, Takao! > > > > > >I bet you are using x86_64 not x86 PAE? If so, could you try this patch > > >https://patchwork.kernel.org/patch/1195751/ > >

Re: [PATCH] x86: revert "x86: Fix S4 regression"

On Wed Jul 25 12, Takao Indoh wrote: > >Thanks for tracking this, Takao! > > > >I bet you are using x86_64 not x86 PAE? If so, could you try this patch > >https://patchwork.kernel.org/patch/1195751/ > >? I already reviewed it. > > Great, I applied it and now kdump works. Thanks! > > Thanks, >

Re: [PATCH] x86: revert x86: Fix S4 regression

On Wed Jul 25 12, Takao Indoh wrote: Thanks for tracking this, Takao! I bet you are using x86_64 not x86 PAE? If so, could you try this patch https://patchwork.kernel.org/patch/1195751/ ? I already reviewed it. Great, I applied it and now kdump works. Thanks! Thanks, Takao Indoh

Re: [PATCH] x86: revert x86: Fix S4 regression

On Sat Aug 11 12, Jerry Snitselaar wrote: On Wed Jul 25 12, Takao Indoh wrote: Thanks for tracking this, Takao! I bet you are using x86_64 not x86 PAE? If so, could you try this patch https://patchwork.kernel.org/patch/1195751/ ? I already reviewed it. Great, I applied it and now

[PATCH] ASoC: core: remove unused variable in soc_probe() in linux-next

With commit 28d528c8 "ASoC: core: Remove pointless error on card registration failure", the variable ret is no longer used in soc_probe() and generates an unused variable warning during a build. Signed-off-by: Jerry Snitselaar --- sound/soc/soc-core.c | 1 - 1 file changed, 1 deletio

[PATCH] ASoC: core: remove unused variable in soc_probe() in linux-next

With commit 28d528c8 ASoC: core: Remove pointless error on card registration failure, the variable ret is no longer used in soc_probe() and generates an unused variable warning during a build. Signed-off-by: Jerry Snitselaar d...@snitselaar.org --- sound/soc/soc-core.c | 1 - 1 file changed, 1

Re: [PATCH] watchdog: watchdog-test: make term() static

On Thu, Jul 26, 2012 at 8:52 PM, Jerry Snitselaar wrote: > In 3.5 warning during build 'no previous prototype for term'. Since it > is only used in watchdog-test.c make term() static. > > Signed-off-by: Jerry Snitselaar > --- > Documentation/watchdog/src/watchdog-test.c | 2 +-

[PATCH] watchdog: watchdog-test: make term() static

In 3.5 warning during build 'no previous prototype for term'. Since it is only used in watchdog-test.c make term() static. Signed-off-by: Jerry Snitselaar --- Documentation/watchdog/src/watchdog-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/watchdog

[PATCH] watchdog: watchdog-test: make term() static

In 3.5 warning during build 'no previous prototype for term'. Since it is only used in watchdog-test.c make term() static. Signed-off-by: Jerry Snitselaar d...@snitselaar.org --- Documentation/watchdog/src/watchdog-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] watchdog: watchdog-test: make term() static

On Thu, Jul 26, 2012 at 8:52 PM, Jerry Snitselaar d...@snitselaar.org wrote: In 3.5 warning during build 'no previous prototype for term'. Since it is only used in watchdog-test.c make term() static. Signed-off-by: Jerry Snitselaar d...@snitselaar.org --- Documentation/watchdog/src/watchdog

<    1   2   3