On 4/17/21 3:24 PM, Gustavo A. R. Silva wrote:
>
>
> On 4/17/21 13:29, Jes Sorensen wrote:
>> On 3/10/21 3:59 PM, Kees Cook wrote:
>>> On Wed, Mar 10, 2021 at 02:51:24PM -0500, Jes Sorensen wrote:
>>>> On 3/10/21 2:45 PM, Kees Cook wrote:
>>>>
On 4/17/21 8:09 PM, Joe Perches wrote:
> On Sat, 2021-04-17 at 14:30 -0400, Jes Sorensen wrote:
>> On 4/17/21 1:52 PM, Kalle Valo wrote:
>>> "Gustavo A. R. Silva" wrote:
>>>
>>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix
&g
On 3/23/21 3:36 PM, Pascal Terjan wrote:
> Based on 2001:3319 and 2357:0109 which I used to test the fix and
> 0bda:818b and 2357:0108 for which I found efuse dumps online.
>
> == 2357:0109 ==
> === Before ===
> Vendor: Realtek
> Product: \x03802.11n NI
> Serial:
> === After ===
> Vendor: Realtek
On 4/17/21 1:52 PM, Kalle Valo wrote:
> "Gustavo A. R. Silva" wrote:
>
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix
>> multiple warnings by replacing /* fall through */ comments with
>> the new pseudo-keyword macro fallthrough; instead of letting the
>> code fall through to t
On 3/10/21 3:59 PM, Kees Cook wrote:
> On Wed, Mar 10, 2021 at 02:51:24PM -0500, Jes Sorensen wrote:
>> On 3/10/21 2:45 PM, Kees Cook wrote:
>>> On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote:
>>>> On 3/10/21 2:14 PM, Kees Cook wrote:
>>&g
On 3/10/21 2:45 PM, Kees Cook wrote:
> On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote:
>> On 3/10/21 2:14 PM, Kees Cook wrote:
>>> Hm, this conversation looks like a miscommunication, mainly? I see
>>> Gustavo, as requested by many others[1], replacing t
On 3/10/21 2:14 PM, Kees Cook wrote:
> On Fri, Mar 05, 2021 at 03:40:33PM +0200, Kalle Valo wrote:
>> "Gustavo A. R. Silva" writes:
>>
>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix
>>> multiple warnings by replacing /* fall through */ comments with
>>> the new pseudo-keyword m
On 11/20/20 1:38 PM, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> multiple warnings by replacing /* fall through */ comments with
> the new pseudo-keyword macro fallthrough; instead of letting the
> code fall through to the next case.
>
> Notice tha
On 11/13/20 4:50 AM, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> The value of variable timeout is overwritten by the following statement in
> rtl8xxxu_gen1_init_aggregation(), so here the value assignment is useless.
> Remove it.
>
> Reported-by: Tosk Robot
> Signed-off-by: Kaixu Xia
>
ou can, and
>>> let's see if anyone notices...
>>
>> That's what I would suggest as well.
>>
>> These drivers for ancient hardware are tricky. Even if there doesn't
>> seem to be any users on the driver sometimes people pop up reporting
>> t
nput/misc/Makefile |1 +
> drivers/input/misc/da7280.c | 1840
> +++
> 3 files changed, 1854 insertions(+)
> create mode 100644 drivers/input/misc/da7280.c
Hi Roy,
Overall the driver looks pretty good now. I did find one issue, see
below. If you
On 6/29/20 9:01 AM, Roy Im wrote:
> Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with
> multiple mode and integrated waveform memory and wideband support.
> It communicates via an I2C bus to the device.
>
> Signed-off-by: Roy Im
> ---
> v15:
> - Removed some defines and updated
eless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +++
3 files changed, 5 insertions(+)
Looks good to me! If this takes care of the warm boot problem, that's
pretty awesome.
Signed-off-by: Jes Sorensen
Jes
On 10/7/19 9:53 AM, Colin King wrote:
From: Colin Ian King
Don't populate const arrays on the stack but instead make them
static. Makes the object code smaller by 60 bytes.
Before:
text data bss dec hex filename
15133 8768 0 239015d5d
realtek
ch of tdma settings
- Reformat some lines to meet kernel coding style
v3:
- Add comment for rtl8723bu_set_coex_with_type()
Looks good to me!
Signed-off-by: Jes Sorensen
Jes
On 10/2/19 9:19 PM, Chris Chiu wrote:
On Wed, Oct 2, 2019 at 11:04 PM Jes Sorensen wrote:
In general I think it looks good! One nit below:
Sorry I have been traveling for the last three weeks, so just catching up.
+void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type
On 9/10/19 10:50 PM, Chris Chiu wrote:
The RTL8723BU suffers the wifi disconnection problem while bluetooth
device connected. While wifi is doing tx/rx, the bluetooth will scan
without results. This is due to the wifi and bluetooth share the same
single antenna for RF communication and they need
OFDM rate,
> and MCS rate. However, with Realtek's driver, the tx rate observed from
> wireshark under the same condition is almost 65Mbps or 72Mbps, which
> indicating that rtl8xxxu could still be further improved.
>
> Signed-off-by: Chris Chiu
> Reviewed-by: Daniel Drake
I
On 9/14/19 9:08 PM, Corey Minyard wrote:
>>
>>>
>>> {disable,enable}_si_irq() themselves are racy:
>>>
>>> static inline bool disable_si_irq(struct smi_info *smi_info)
>>> {
>>> if ((smi_info->io.irq) && (!smi_info->interrupt_disabled)) {
>>> smi_info->interrupt_disabled = t
On 9/3/19 1:37 AM, Chris Chiu wrote:
> The RTL8723BU suffers the wifi disconnection problem while bluetooth
> device connected. While wifi is doing tx/rx, the bluetooth will scan
> without results. This is due to the wifi and bluetooth share the same
> single antenna for RF communication and they n
On 8/28/19 6:32 PM, Corey Minyard wrote:
> On Wed, Aug 28, 2019 at 04:36:24PM -0400, Jes Sorensen wrote:
>> From: Jes Sorensen
>>
>> I came across this in 4.16, but I believe the bug is still present
>> in current 5.x, even if it is less likely to trigger.
>>
From: Jes Sorensen
smi_mod_timer() enables the timer before setting timer_running. This
means the timer can be running when we get to stop_timer_and_thread()
without timer_running having been set, resulting in del_timer_sync()
not being called and the timer being left to cause havoc during
From: Jes Sorensen
I came across this in 4.16, but I believe the bug is still present
in current 5.x, even if it is less likely to trigger.
Basially stop_timer_and_thread() only calls del_timer_sync() if
timer_running == true. However smi_mod_timer enables the timer before
setting timer_running
On 8/12/19 10:32 AM, Kalle Valo wrote:
> Jes Sorensen writes:
>> Looks good to me! Nice work! I am actually very curious if this will
>> improve performance 8192eu as well.
>>
>> Ideally I'd like to figure out how to make host controlled rates work,
>> but in
---
Looks good to me! Nice work! I am actually very curious if this will
improve performance 8192eu as well.
Ideally I'd like to figure out how to make host controlled rates work,
but in all my experiments with that, I never really got it to work well.
Signed-off-by: Jes Sorensen
Jes
On 7/4/19 11:44 PM, Daniel Drake wrote:
> On Wed, Jul 3, 2019 at 8:59 PM Jes Sorensen wrote:
>> My point is this seems to be very dongle dependent :( We have to be
>> careful not breaking it for some users while fixing it for others.
>
> Do you still have your device?
&g
On 7/4/19 10:27 PM, Chris Chiu wrote:
> On Fri, Jul 5, 2019 at 12:43 AM Jes Sorensen wrote:
>>
>> On 7/4/19 6:55 AM, Chris Chiu wrote:
>>> The WiFi tx power of RTL8723BU is extremely low after booting. So
>>> the WiFi scan gives very limited AP list and it a
On 7/4/19 6:55 AM, Chris Chiu wrote:
> The WiFi tx power of RTL8723BU is extremely low after booting. So
> the WiFi scan gives very limited AP list and it always fails to
> connect to the selected AP. This module only supports 1x1 antenna
> and the antenna is switched to bluetooth due to some incor
On 7/2/19 11:25 PM, Chris Chiu wrote:
> On Tue, Jul 2, 2019 at 8:44 PM Jes Sorensen wrote:
>>
>> On 6/27/19 5:52 AM, Chris Chiu wrote:
>>> The WiFi tx power of RTL8723BU is extremely low after booting. So
>>> the WiFi scan gives very limited AP list and it a
On 7/3/19 3:42 AM, Daniel Drake wrote:
> On Tue, Jul 2, 2019 at 8:42 PM Jes Sorensen wrote:
>> We definitely don't want to bring over the vendor code, since it's a
>> pile of spaghetti, but we probably need to get something sorted. This
>> went down the drain when
On 6/27/19 5:52 AM, Chris Chiu wrote:
> The WiFi tx power of RTL8723BU is extremely low after booting. So
> the WiFi scan gives very limited AP list and it always fails to
> connect to the selected AP. This module only supports 1x1 antenna
> and the antenna is switched to bluetooth due to some inco
On 7/1/19 4:27 AM, Daniel Drake wrote:
> Hi Chris,
>
> On Thu, Jun 27, 2019 at 5:53 PM Chris Chiu wrote:
>> The WiFi tx power of RTL8723BU is extremely low after booting. So
>> the WiFi scan gives very limited AP list and it always fails to
>> connect to the selected AP. This module only supports
e memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang
> ---
> drivers/net/hippi/rrunner.c | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Jes Sorensen
> diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
> index 7b9350dbebdd..2a6ec5394966 100
On 5/31/19 5:12 AM, Chris Chiu wrote:
> We have 3 laptops which connect the wifi by the same RTL8723BU.
> The PCI VID/PID of the wifi chip is 10EC:B720 which is supported.
> They have the same problem with the in-kernel rtl8xxxu driver, the
> iperf (as a client to an ethernet-connected server) gets
On 09/04/2018 04:16 AM, Kalle Valo wrote:
> Aleksei Mamlin wrote:
>
>> The Realtek rtl8188ctv (0x0bda:0x018a) is a highly integrated single-chip
>> WLAN USB2.0 network interface controller.
>>
>> Currently rtl8188ctv is supported by rtlwifi driver.
>> It is similar to the rtl8188cus(0x0bda:0x818a
On 05/23/2018 10:26 AM, Matthew Wilcox wrote:
> On Wed, May 23, 2018 at 10:20:10AM -0400, Jes Sorensen wrote:
>>> +++ b/drivers/pci/pcie/aer/aerdrv_stats.c
>>> @@ -0,0 +1,64 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>
>> Fix the formatting please - th
On 05/23/2018 10:26 AM, Alex G. wrote:
> On 05/23/2018 09:20 AM, Jes Sorensen wrote:
>> On 05/22/2018 06:28 PM, Rajat Jain wrote:
>>> new file mode 100644
>>> index ..b9f251992209
>>> --- /dev/null
>>> +++ b/drivers/pci/pcie/aer/aerdrv_stat
On 05/22/2018 06:28 PM, Rajat Jain wrote:
> Define a structure to hold the AER statistics. There are 2 groups
> of statistics: dev_* counters that are to be collected for all AER
> capable devices and rootport_* counters that are collected for all
> (AER capable) rootports only. Allocate and free t
On 05/18/2018 06:09 AM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in printk message text
>
> Signed-off-by: Colin Ian King
> ---
> drivers/net/hippi/rrunner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hippi/rrunner.
rdev-devel/2018-January/115390.html
>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Jes Sorensen
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
> b/drivers/net/wireless/realtek/rtl8xxxu/r
On 10/25/2017 06:51 AM, Kees Cook wrote:
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Jes Sorensen
Cc: linux-hi...@sunsite.dk
Cc: net
On 10/11/2017 04:41 AM, Kalle Valo wrote:
Jes Sorensen writes:
On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
While this isn't harmful, to me this looks like pointless
On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
While this isn't harmful, to me this looks like pointless patch churn
for zero gain and it's just ugly.
Jes
Cc: Jes So
tate across all the register access functions.
Arnd
Nice work! This is a textbook example of how to do this the right way!
Reviewed-by: Jes Sorensen
Jes
On 05/16/2017 10:19 AM, Arnd Bergmann wrote:
On Tue, May 16, 2017 at 3:44 PM, Jes Sorensen wrote:
On 05/16/2017 07:55 AM, Stanislaw Gruszka wrote:
On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote:
Passing return values by reference is and always has been a really
poor way to
On 05/16/2017 07:55 AM, Stanislaw Gruszka wrote:
On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote:
Passing return values by reference is and always has been a really
poor way to achieve what these functions are doing.
And frankly, whilst the tool could see what's going on here bette
On 04/05/2017 05:47 PM, Kees Cook wrote:
While examining output from trial builds with -Wformat-security enabled,
many strings were found that should be defined as "const", or as a char
array instead of char pointer. This makes some static analysis easier,
by producing fewer false positives.
As
On 03/30/2017 12:58 PM, Gioh Kim wrote:
Remove a boolean expression in switch condition
to prevent compile error of some compilers,
for example, gcc version 5.2.1 20151010 (Ubuntu 5.2.1-22ubuntu2).
Signed-off-by: Gioh Kim
---
mdadm.c | 14 ++
1 file changed, 6 insertions(+), 8 dele
On 03/30/2017 03:52 AM, Gioh Kim wrote:
On Thu, Mar 30, 2017 at 08:38:35AM +1100, NeilBrown wrote:
On Thu, Mar 30 2017, jes.soren...@gmail.com wrote:
Gioh Kim writes:
Remove a boolean expression in switch condition
to prevent compile error of some compilers.
Please be specific, which compi
Gioh Kim writes:
> Remove a boolean expression in switch condition
> to prevent compile error of some compilers.
Please be specific, which compile is unable to handle this?
> Signed-off-by: Gioh Kim
> ---
> mdadm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/
Gioh Kim writes:
> Some hard-coded values for disk status are replaced
> with bit definitions.
>
> Signed-off-by: Gioh Kim
> ---
> super1.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Applied!
Please use --cover-letter when you send out multi-commit patch sets,
which include
Gioh Kim writes:
> There is corner case for setting device role,
> if new device has failfast flag.
> The failfast flag should be ignored.
>
> Signed-off-by: Gioh Kim
> Signed-off-by: Jack Wang
> ---
> super1.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Applied!
Ideally I
The conversion of notify from using a spinlock to a mutex missed
adding the call mutex_destroy().
Fixes: 986ab09 ("fsnotify: use a mutex instead of a spinlock to protect a
groups mark list")
Signed-off-by: Jes Sorensen
Reviewed-by: Josef Bacik
---
fs/notify/group.c | 1 +
1 file
Splice off the notification list while processing read events, which allows
it to be processed without taking and releasing the spinlock for each
event.
Signed-off-by: Jes Sorensen
Reviewed-by: Josef Bacik
---
fs/notify/inotify/inotify_user.c | 28
1 file changed
Preparing to switch inotify to code not taking the spinlock for each
event in read()
Signed-off-by: Jes Sorensen
Reviewed-by: Josef Bacik
---
fs/notify/inotify/inotify_user.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/notify/inotify/inotify_user.c b/fs
This splits up fsnotify_remove_first_event() and fsnotify_peek_first_event()
into a helper function with a wrapper, and introduces two new versions that
takes a list instead of the group as argument.
Signed-off-by: Jes Sorensen
Reviewed-by: Josef Bacik
---
fs/notify/notification.c | 38
Introduces mutex in the read() path to prevent a threaded client reading
from the same fd consuming events out of order.
This will matter when avoiding taking the spinlock when consuming each
event in the read() path.
Signed-off-by: Jes Sorensen
Reviewed-by: Josef Bacik
---
fs/notify/inotify
k, it does increase the overhead for the case where the
users tries to read one event at a time.
Last, the first patch of the series adds the missing mutex_destoy()
for mark_mutex.
Thoughts?
Jes
Jes Sorensen (5):
notify: Call mutex_destroy() before freeing mutex memory
inotify: Use mut
Gioh Kim writes:
> There is corner case for setting device role,
> if new device has failfast flag.
> The failfast flag should be ignored.
>
> Signed-off-by: Gioh Kim
> Signed-off-by: Jack Wang
> ---
> super1.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/sup
On 02/13/2017 12:54 AM, zhilong wrote:
On 02/13/2017 01:08 PM, zhilong wrote:
Hi, Jes;
On 01/13/2017 12:41 AM, Jes Sorensen wrote:
On 01/11/17 23:24, Guoqing Jiang wrote:
On 01/12/2017 12:59 AM, Jes Sorensen wrote:
On 01/11/17 11:52, Shaohua Li wrote:
On Tue, Jan 10, 2017 at 11:49:04AM
On 01/11/17 23:24, Guoqing Jiang wrote:
>
>
> On 01/12/2017 12:59 AM, Jes Sorensen wrote:
>> On 01/11/17 11:52, Shaohua Li wrote:
>>> On Tue, Jan 10, 2017 at 11:49:04AM -0600, Bruce Dubbs wrote:
>>>> Jes Sorensen wrote:
>>>>> I am pleased to an
On 01/11/17 11:52, Shaohua Li wrote:
> On Tue, Jan 10, 2017 at 11:49:04AM -0600, Bruce Dubbs wrote:
>> Jes Sorensen wrote:
>>> I am pleased to announce the availability of
>>> mdadm version 4.0
>>>
>>> It is available at the usual places:
>&
RAID.
This is my first release of mdadm. Please thank Neil Brown for his
previous work as maintainer and blame me for all the bugs I caused
since taking over.
Jes Sorensen, 2017-01-09
MasterPrenium writes:
> Hello Guys,
>
> I've having some trouble on a new system I'm setting up. I'm getting a
> kernel BUG message, seems to be related with the use of Xen (when I
> boot the system _without_ Xen, I don't get any crash).
> Here is configuration :
> - 3x Hard Drives running on RAID
Larry Finger writes:
> On 12/02/2016 03:50 AM, Bhumika Goyal wrote:
>> The structures rate_control_ops are only passed as an argument to the
>> functions ieee80211_rate_control_{register/unregister}. This argument is
>> of type const, so rate_control_ops having this property can also be
>> declare
Arnd Bergmann writes:
> We accidentally print the rate before we know it for txdesc_v2:
Hi Arnd,
Thanks for the patch - Barry Day already posted a patch for this which
Kalle has applied to the wireless tree.
Cheers,
Jes
>
> wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function
> 'rtl8xxxu_f
NeilBrown writes:
> Allow per-device "failfast" flag to be set when creating an
> array or adding devices to an array.
>
> When re-adding a device which had the failfast flag, it can be removed
> using --nofailfast.
>
> failfast status is printed in --detail and --examine output.
>
> Signed-off-by
t;>> >
>>> > This is a correct diagnosis.
>>>
>>> Thanks for the report. Jes, can you send a patch to fix this? (Unless
>>> someone else beats to it.)
>>>
>>> --
>>> Kalle Valo
>>
>> I posted a patch on the 26th that fixes this
>
> Thanks, I see it:
>
> https://patchwork.kernel.org/patch/9448225/
>
> The commit log doesn't mention anything about the compilation warning,
> I'll add that. Also a Fixes line is nice to have.
I'm happy with this fix
Acked-by: Jes Sorensen
John Heenan writes:
> Barry Day has submitted real world reports for the 8192eu and 8192cu.
> This needs to be acknowledged. I have submitted real world reports for
> the 8723bu.
Lets get this a little more clear - first of all, I have asked you to
investigate which part resolves the problem. Rat
> 1 files changed, 35 insertions(+), 30 deletions(-)
Nothing that sticks out to me
Acked-by: Jes Sorensen
Jes
> diff --git a/drivers/net/ethernet/alteon/acenic.c
> b/drivers/net/ethernet/alteon/acenic.c
> index a5c1e29..16f0c70 100644
> --- a/drivers/net/ethernet/alteon/acen
Joe Perches writes:
> On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote:
>> Code is 80 characters wide, and comments are /* */ never the ugly C++
>> crap.
>
> You might look at the recent Linus Torvalds authored commit
> 5e467652ffef (?printk: re-organize log_out
John Heenan writes:
> The rtl8723bu wireless IC shows evidence of a more agressive approach to
> power saving, powering down its RF side when there is no wireless
> interfacing but leaving USB interfacing intact. This makes the wireless
> IC more suitable for use in devices which need to keep thei
John Heenan writes:
> Thanks for your reply.
>
> The code was tested on a Cube i9 which has an internal rtl8723bu.
>
> No other devices were tested.
>
> I am happy to accept in an ideal context hard coding macpower is
> undesirable, the comment is undesirable and it is wrong to assume the
> issue
John Heenan writes:
> Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set
> macpower, is never 0xea. It is only ever 0x01 (first time after modprobe)
> using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results
> occurs with 'Fix for authentication failure'
Dan Carpenter writes:
> Compare:
>
> foo = kmalloc(sizeof(*foo), GFP_KERNEL);
>
> This says you are allocating enough space for foo. It can be reviewed
> by looking at one line. If you change the type of foo it will still
> work.
>
> foo = kmalloc(sizeof(struct whatever), GFP_KERNEL)
SF Markus Elfring writes:
>>> How do you value compliance with coding styles?
>>
>> The Linux Coding Style is not a law,
>
> How serious can such guidelines become for software developers?
>
>> nor is it at all perfect.
>
> I got a similar impression. But are there enough items where a mostly clea
SF Markus Elfring writes:
but patches that just fix coding style are a bad thing
>>>
>>> When you find such a change opportunity so "bad", are there any
>>> circumstances left over where you would dare to touch the corresponding
>>> source code line.
>>
>> If you actually rewrite the code
Dan Carpenter writes:
> On Thu, Oct 06, 2016 at 11:29:20AM +0200, Richard Weinberger wrote:
>> On Thu, Oct 6, 2016 at 11:22 AM, SF Markus Elfring
>> wrote:
>> > From: Markus Elfring
>> > Date: Tue, 4 Oct 2016 21:46:18 +0200
>> >
>> > Replace the specification of a data structure by a pointer der
SF Markus Elfring writes:
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer.
>>>
>>> Isn't this pure matter of taste?
>>> Some developers prefer sizeof(*ptr) beca
Joe Perches writes:
> On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote:
>> Your output shows it moving to the text segment - if it's in a different
>> segment, eg. rodata, you should use output demonstrating that to justify
>> the change.
>
> For size, rodat
Joe Perches writes:
> On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote:
>> Joe Perches writes:
>> > Make the init arrays const to reduce data.
>> > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o*
>> > (allyesconfig: x86-32)
>> > tex
Joe Perches writes:
> Make the init arrays const to reduce data.
>
> $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig:
> x86-32)
>text data bss dec hex filename
> 80107 13651 58 93816 16e78
> drivers/net/wireless/realtek/rtl8xxxu/
SF Markus Elfring writes:
> From: Markus Elfring
> Date: Tue, 27 Sep 2016 15:46:22 +0200
>
> Adjust jump labels according to the current Linux coding style convention.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/md/bitmap.c | 18 +-
> 1 file changed, 9 insertions(+), 9 del
SF Markus Elfring writes:
> From: Markus Elfring
> Date: Tue, 27 Sep 2016 13:01:07 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
>
> This iss
Joe Perches writes:
> On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote:
>> On 09/24/2016 12:32 PM, Joe Perches wrote:
> []
>> o Reindent all the switch/case blocks to a more normal
>> kernel style (git diff -w would show no changes here)
>> That sounds like busy work to me, but if you want
Larry Finger writes:
> On 09/24/2016 12:32 PM, Joe Perches wrote:
>> Is there any value in that or is Jes' work going to make
>> doing any or all of this unnecessary and futile?
>
> That is not yet determined. The only driver that is to be replaced at
> this point is rtl8192cu. Jes only has USB I/
Masahiro Yamada writes:
> Remove unneeded variables and assignments.
>
> While we are here, clean up the following as well:
> - refactor rtl8723a_get_bcn_valid() a bit
> - remove unneeded casts in sii164Get{Vendor,Device}ID()
>
> Signed-off-by: Masahiro Yamada
> ---
>
> drivers/staging/andro
On 09/12/16 09:58, Bhumika Goyal wrote:
> Relational and logical operators evaluate to either true or false.
> Explicit conversion is not needed so remove the ternary operator.
> Done using coccinelle:
>
> @r@
> expression A,B;
> symbol true,false;
> binary operator b = {==,!=,&&,||,>=,<=,>,<};
>
Kalle Valo writes:
> Colin Ian King wrote:
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistakes in dev_dbg message.
>>
>> Signed-off-by: Colin Ian King
>> Reviewed-by: Julian Calaby
>
> I assume Jes will take this.
It's on my list, sorry been swamped in LPC stuff and other work th
Joe Perches writes:
> On Tue, 2016-09-06 at 12:00 -0400, Jes Sorensen wrote:
>
>> Nothing wrong with these patches, however I intend to post a patch to
>> remove this driver soon, so it's kind of a waste of your time to spend
>> too many cycles on it.
>
> It
Matthias Beyer writes:
> This patchset fixes some errors and warnings reported by checkpatch.pl.
>
> Matthias Beyer (5):
> drivers: staging: rtl8723au: core: Fix checkpatch.pl errors
> drivers: staging: rtl8723au: core: simplify if-break-else
> drivers: staging: rtl8723au: core: Refactor poi
Kalle Valo writes:
> Baoyou Xie wrote:
>> We get 1 warning about global functions without a declaration
>> in the rtl8xxxu rtl8xxxu_core.c when building with W=1:
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1:
>> warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd'
>> [-Wmi
sunbing writes:
> On Aug 11, 2016, at 23:25, Jes Sorensen wrote:
>
>> Bing Sun writes:
>>> Fixed sparse parse error:
>>> Expected constant expression in case statement.
>>>
>>> Signed-off-by: Bing Sun
>>> ---
>>> drivers/stagi
Bing Sun writes:
> Fixed sparse parse error:
> Expected constant expression in case statement.
>
> Signed-off-by: Bing Sun
> ---
> drivers/staging/rtl8723au/os_dep/os_intfs.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/os_dep/os_
Shiva Kerdel writes:
> Fixed some coding style issues that were detected as errors.
>
> Signed-off-by: Shiva Kerdel
You have already been told this once by Greg. Describe what you are
fixing in the commit message, and don't fix more than one type of bug
per commit.
Jes
> ---
> drivers/staging
Baole Ni writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the ro
Stefan Lippers-Hollmann writes:
> Hi
>
> On 2016-07-20, Arnd Bergmann wrote:
>> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote:
>> > Arnd Bergmann writes:
>> > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote:
>> >
ion to clarify the types and simplify
> the check while removing the warning.
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/staging/rtl8192e/rtl819x_Qos.h| 3 ---
> drivers/staging/rtl8192e/rtl819x_TSProc.c | 5 +
> 2 files changed, 5 insertions(+), 3 deletions(-)
Lo
Arnd Bergmann writes:
> On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote:
>> Arnd Bergmann writes:
>> Well it really all depends on how much time I have and how much others
>> step up and help contribute to the code. For rtl8xxxu my plans are as
>> f
Colin King writes:
> From: Colin Ian King
>
> BT_Active and BT_State are being masked with 0x00ff so it the subsequent
> comparisons with 0x are therefore a buggy check. Instead, check them
> against 0x00ff.
>
> Unfortunately I couldn't find a datasheet or hardware to see if 0xff
1 - 100 of 418 matches
Mail list logo
