On Sun, 8 Jul 2012, Joe Perches wrote:
On Mon, 2012-07-09 at 00:59 +0200, Jesper Juhl wrote:
I missed a few redundant newlines the first time.
[]
diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
[]
@@ -964,7 +964,6 @@ int iwctl_giwrts(struct net_device *dev
On Sun, 8 Jul 2012, Joe Perches wrote:
On Mon, 2012-07-09 at 00:58 +0200, Jesper Juhl wrote:
A few cases were missed in my previous cleanup, this takes care of the
last cases of missing space (or too much space (as in a newline))
around operators ('=', '==', ',', '').
Trivia:
diff
On Fri, 6 Jul 2012, Greg Kroah-Hartman wrote:
> On Wed, Jun 27, 2012 at 09:19:15PM +0200, Jesper Juhl wrote:
> > My previous 14 patch series to vt6656 missed a few bits and
> > pieces. This mops up the last few obvious style issues.
> > It is quite short and completely tri
On Fri, 6 Jul 2012, Greg Kroah-Hartman wrote:
On Wed, Jun 27, 2012 at 09:19:15PM +0200, Jesper Juhl wrote:
My previous 14 patch series to vt6656 missed a few bits and
pieces. This mops up the last few obvious style issues.
It is quite short and completely trivial - simply deletes a few
get_marker() may return NULL, so test for it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/kernel/marker.c b/kernel/marker.c
index 50effc0..f211f08 100644
--- a/kernel/marker.c
+++ b/kernel/marker.c
@@ -698,12 +698,11 @@ int marker_probe_unregister(const char
get_marker() may return NULL, so test for it.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/kernel/marker.c b/kernel/marker.c
index 50effc0..f211f08 100644
--- a/kernel/marker.c
+++ b/kernel/marker.c
@@ -698,12 +698,11 @@ int marker_probe_unregister(const char *name
afe in case bar() is a macro.
if (foo) {
bar();
}
is always safe and is more robust when the code gets changed later
since you don't accidentally end up with someone mistakenly turning it
into
if (foo)
bar();
baz();
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.cat
accidentally end up with someone mistakenly turning it
into
if (foo)
bar();
baz();
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list
the Trivial tree and push it during the
2.6.26 merge window if it doesn't get merged elsewhere before that.
It looks reasonably trivial.
At least that way it doesn't get lost :)
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain t
it doesn't get lost :)
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Pavel
>
>
> Signed-off-by: Pavel Machek <[EMAIL PROTECTED]>
> Acked-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
>
I've put this on my watch list for the trivial tree.
So, if it doesn't get merged
PROTECTED]
I've put this on my watch list for the trivial tree.
So, if it doesn't get merged elsewhere I'll take care of pushing it
again during the 2.6.26 merge window (and beyond).
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text
On 22/01/2008, Anton Salikhmetov <[EMAIL PROTECTED]> wrote:
> 2008/1/22, Jesper Juhl <[EMAIL PROTECTED]>:
> > On 22/01/2008, Anton Salikhmetov <[EMAIL PROTECTED]> wrote:
> > > 2008/1/22, Jesper Juhl <[EMAIL PROTECTED]>:
> > > > Some very pe
On 22/01/2008, Anton Salikhmetov <[EMAIL PROTECTED]> wrote:
> 2008/1/22, Anton Salikhmetov <[EMAIL PROTECTED]>:
> > 2008/1/22, Jesper Juhl <[EMAIL PROTECTED]>:
> > > Some very pedantic nitpicking below;
> > >
...
>
> By the way, if we're talking
On 22/01/2008, Anton Salikhmetov <[EMAIL PROTECTED]> wrote:
> 2008/1/22, Jesper Juhl <[EMAIL PROTECTED]>:
> > Some very pedantic nitpicking below;
> >
> > On 22/01/2008, Anton Salikhmetov <[EMAIL PROTECTED]> wrote:
...
> > > +
(flags & MS_SYNC) {
"else if" ??
> + get_file(file);
> + up_read(>mmap_sem);
> + error = do_fsync(file, 0);
> + fput(file);
> + if (error || start >= end)
s, including numbers, are available here:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=2645#c43
>
Hi Anton,
I applied your patches here and as far as my own test programs go,
these patches solve the previously observed problems I saw with mtime
not getting updated.
Thank you very much fo
Anton,
I applied your patches here and as far as my own test programs go,
these patches solve the previously observed problems I saw with mtime
not getting updated.
Thank you very much for so persistently working on these long standing issues.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http
;
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
On 22/01/2008, Anton Salikhmetov [EMAIL PROTECTED] wrote:
2008/1/22, Jesper Juhl [EMAIL PROTECTED]:
Some very pedantic nitpicking below;
On 22/01/2008, Anton Salikhmetov [EMAIL PROTECTED] wrote:
...
+ if (file (vma-vm_flags VM_SHARED
On 22/01/2008, Anton Salikhmetov [EMAIL PROTECTED] wrote:
2008/1/22, Anton Salikhmetov [EMAIL PROTECTED]:
2008/1/22, Jesper Juhl [EMAIL PROTECTED]:
Some very pedantic nitpicking below;
...
By the way, if we're talking pedantic, then:
debian:/tmp$ cat c.c
void f
On 22/01/2008, Anton Salikhmetov [EMAIL PROTECTED] wrote:
2008/1/22, Jesper Juhl [EMAIL PROTECTED]:
On 22/01/2008, Anton Salikhmetov [EMAIL PROTECTED] wrote:
2008/1/22, Jesper Juhl [EMAIL PROTECTED]:
Some very pedantic nitpicking below;
On 22/01/2008, Anton Salikhmetov [EMAIL
On 14/01/2008, Ed L. Cashin <[EMAIL PROTECTED]> wrote:
> On Sun, Jan 13, 2008 at 02:44:48AM +0100, Jesper Juhl wrote:
> > Documentation/aoe/ is missing a 00-INDEX file. Add one.
>
> Thanks. I think that it would help to clarify that using udev is the
> norm, and that the m
On 14/01/2008, Ed L. Cashin [EMAIL PROTECTED] wrote:
On Sun, Jan 13, 2008 at 02:44:48AM +0100, Jesper Juhl wrote:
Documentation/aoe/ is missing a 00-INDEX file. Add one.
Thanks. I think that it would help to clarify that using udev is the
norm, and that the mkdev and mkshelf scripts
Documentation/aoe/ is missing a 00-INDEX file. Add one.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
00-INDEX | 18 ++
1 file changed, 18 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ linux-2.6/Documentation/aoe/00-INDEX2008-01-13
NOMEM upon failure to allocate new ias_obj
The Coverity checker gets credit for pointing its finger towards this.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
af_irda.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/irda/af_irda.c b/net/irda/af_irda.
think
it's a lot nicer to simply return -ENOMEM to the caller here where we know
a memory allocation failed, rather than hitting an assertion later.
note: I don't have any means of actually testing this, so it has been
compile tested only.
Signed-off-by: Jesper Juhl <[EMAIL PROTEC
think
it's a lot nicer to simply return -ENOMEM to the caller here where we know
a memory allocation failed, rather than hitting an assertion later.
note: I don't have any means of actually testing this, so it has been
compile tested only.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED
new ias_obj
The Coverity checker gets credit for pointing its finger towards this.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
af_irda.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c
index e33f0a5..352e8a7 100644
Documentation/aoe/ is missing a 00-INDEX file. Add one.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
00-INDEX | 18 ++
1 file changed, 18 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ linux-2.6/Documentation/aoe/00-INDEX2008-01-13 02:37
nd does it have over 4GB of RAM ?
> >
> >
>
> There are 2GB of RAM and the motherboard is DFI and it has a duel core
> intel cpu. If you need to specifics I could look them up.
cat /proc/cpuinfo
cat /proc/scsi/scsi
cat /proc/interrupts
lspci -vvx
should give you most of the details :)
-
f a write reference, then these fields shall be marked for update at some
> > time after the write reference.
> >
> > The above citation was taken from the following link:
> >
> > http://www.opengroup.org/onlinepubs/009695399/functions/mmap.html
> >
...
/onlinepubs/009695399/functions/mmap.html
...
I agree that our current behaviour is certainly not what the standard
(sensibly) requires.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com
the Oops that way. See
Documentation/serial-console.txt and
Documentation/networking/netconsole.txt for details.
That should do it for a few starting points. :-)
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please
/netconsole.txt for details.
That should do it for a few starting points. :-)
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send
wise I think it looks sane enough as a small style cleanup.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send the line "unsubs
On 04/01/2008, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
> Before:
> total: 25 errors, 13 warnings, 602 lines checked
>
> After:
> total: 3 errors, 13 warnings, 602 lines checked
>
>
> Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
Looks sane to m
On 04/01/2008, Paolo Ciarrocchi [EMAIL PROTECTED] wrote:
Before:
total: 25 errors, 13 warnings, 602 lines checked
After:
total: 3 errors, 13 warnings, 602 lines checked
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
Looks sane to me.
Reviewed-by: Jesper Juhl [EMAIL PROTECTED
cleanup.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED
From: Jesper Juhl <[EMAIL PROTECTED]>
Don't include linux/security.h twice in kernel/sysctl.c
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
sysctl.c |1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index c68f68d..01b12c3 100644
--- a/ker
From: Jesper Juhl <[EMAIL PROTECTED]>
Remove duplicate inclusion of linux/profile.h from kernel/profile.c
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
profile.c |1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/profile.c b/kernel/profile.c
index 5e95330..ff
From: Jesper Juhl <[EMAIL PROTECTED]>
Remove the duplicate inclusion of linux/jiffies.h from kernel/printk.c
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
printk.c |1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/printk.c b/kernel/printk.c
index 89011bf..b4
Including the same header twice (or more) in a .c file, outside any #ifdef's
and whatnot, serves no purpose except generating more work for the
compiler, so here are 3 patches that get rid of some pointless duplicate
includes.
Kind regards,
Jesper Juhl <[EMAIL PROTEC
s some trailing whitespace, does some CodingStyle cleanups, is
nicely confined to one file, doesn't (as far as I can tell) change the
way the code works, makes checkpatch less noisy. All good.
Feel free to add
Reviewed-by: Jesper Juhl <[EMAIL PROTECTED]>
if you like.
--
Jesper Juhl <
, doesn't (as far as I can tell) change the
way the code works, makes checkpatch less noisy. All good.
Feel free to add
Reviewed-by: Jesper Juhl [EMAIL PROTECTED]
if you like.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails
Including the same header twice (or more) in a .c file, outside any #ifdef's
and whatnot, serves no purpose except generating more work for the
compiler, so here are 3 patches that get rid of some pointless duplicate
includes.
Kind regards,
Jesper Juhl [EMAIL PROTECTED]
--
To unsubscribe
From: Jesper Juhl [EMAIL PROTECTED]
Remove the duplicate inclusion of linux/jiffies.h from kernel/printk.c
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
printk.c |1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/printk.c b/kernel/printk.c
index 89011bf..b4bca0d 100644
From: Jesper Juhl [EMAIL PROTECTED]
Remove duplicate inclusion of linux/profile.h from kernel/profile.c
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
profile.c |1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/profile.c b/kernel/profile.c
index 5e95330..ffaebea 100644
From: Jesper Juhl [EMAIL PROTECTED]
Don't include linux/security.h twice in kernel/sysctl.c
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
sysctl.c |1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index c68f68d..01b12c3 100644
--- a/kernel/sysctl.c
From: Jesper Juhl <[EMAIL PROTECTED]>
This patch silences the following warning :
drivers/mtd/ubi/vmt.c:73: warning: 'ret' may be used uninitialized in this
function
gcc can't see that we always initialize ret in all situations where it is
actually used. The one case wher
elcome.
>
Don't know if you saw mine (at least it's not on your list), but it's
archived here: http://lkml.org/lkml/2007/12/12/399
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/
here: http://lkml.org/lkml/2007/12/12/399
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
From: Jesper Juhl [EMAIL PROTECTED]
This patch silences the following warning :
drivers/mtd/ubi/vmt.c:73: warning: 'ret' may be used uninitialized in this
function
gcc can't see that we always initialize ret in all situations where it is
actually used. The one case where it's
rting other, more commonly used
> APIs. That was the principle we followed in previous schedulers too. And
> if anyone has a patch to make sched_yield() better than it is today, i'm
> of course interested in it.
>
Just for the record; for our use, sched_yield() seems to work j
764, in 1723
cycles: out 1762, in 1712
cycles: out 1761, in 1723
cycles: out 1771, in 1715
cycles: out 1770, in 1709
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
, in 1712
cycles: out 1761, in 1723
cycles: out 1771, in 1715
cycles: out 1770, in 1709
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send
the
new scheduler is doing fine in this regard.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
nterrupt gone?
>
Just to rule out the trivial causes. Could it be that you've simply
not configured your system to log messages at the loglevel that your
printk() is using?
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain tex
the trivial causes. Could it be that you've simply
not configured your system to log messages at the loglevel that your
printk() is using?
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com
On 13/11/2007, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
> Jesper Juhl wrote:
> > In kernel/exit.c we have this code :
> >
> > static void exit_mm(struct task_struct * tsk)
> > {
> > struct mm_struct *mm = tsk->mm;
> >
>
On 13/11/2007, Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
In kernel/exit.c we have this code :
static void exit_mm(struct task_struct * tsk)
{
struct mm_struct *mm = tsk-mm;
mm_release(tsk, mm);
if (!mm)
return
On 14/11/2007, WANG Cong <[EMAIL PROTECTED]> wrote:
> On Mon, Nov 12, 2007 at 12:56:35AM +0100, Jesper Juhl wrote:
> >From: Jesper Juhl <[EMAIL PROTECTED]>
> >
> >'make includecheck' is useful and we want people to run it, so
> >let 'make help'
On 14/11/2007, WANG Cong [EMAIL PROTECTED] wrote:
On Mon, Nov 12, 2007 at 12:56:35AM +0100, Jesper Juhl wrote:
From: Jesper Juhl [EMAIL PROTECTED]
'make includecheck' is useful and we want people to run it, so
let 'make help' output information about its existence.
Signed-off-by: Jesper
On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote:
> > On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote:
> > > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote:
> > >
On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote:
> > From: Jesper Juhl <[EMAIL PROTECTED]>
> >
> > in sas_get_phy_change_count(), the line
> > disc_resp = alloc_smp_resp(DISCOVER_RES
From: Jesper Juhl <[EMAIL PROTECTED]>
'make includecheck' is useful and we want people to run it, so
let 'make help' output information about its existence.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
Makefile |1 +
1 file changed, 1 insertion(+)
diff --git a/Makefil
In any case, what's currently there looks
a little shaky..
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "
From: Jesper Juhl <[EMAIL PROTECTED]>
in sas_get_phy_change_count(), the line
disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE);
will allocate 56 bytes due to this define:
#define DISCOVER_RESP_SIZE 56
But, the struct is actually 60 bytes in size.
So change the
From: Jesper Juhl <[EMAIL PROTECTED]>
In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
the storage allocated for 'abort' by returning from the function
without using or freeing it. This happens in case
"sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" is
From: Jesper Juhl [EMAIL PROTECTED]
In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
the storage allocated for 'abort' by returning from the function
without using or freeing it. This happens in case
sctp_auth_recv_cid(SCTP_CID_ABORT, asoc) is true and we jump to
the 'discard
From: Jesper Juhl [EMAIL PROTECTED]
in sas_get_phy_change_count(), the line
disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE);
will allocate 56 bytes due to this define:
#define DISCOVER_RESP_SIZE 56
But, the struct is actually 60 bytes in size.
So change the define
currently there looks
a little shaky..
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
From: Jesper Juhl [EMAIL PROTECTED]
'make includecheck' is useful and we want people to run it, so
let 'make help' output information about its existence.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
Makefile |1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote:
On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote:
From: Jesper Juhl [EMAIL PROTECTED]
in sas_get_phy_change_count(), the line
disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE);
will allocate 56 bytes due to this define
On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote:
On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote:
On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote:
On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote:
From: Jesper Juhl [EMAIL PROTECTED
On 15/10/2007, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
> This patch cleans up duplicate includes in
> arch/i386/xen/
>
Just for the record; this patch is
From: Jesper Juhl <[EMAIL PROTECTED]>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
> S
On 15/10/2007, Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
This patch cleans up duplicate includes in
arch/i386/xen/
Just for the record; this patch is
From: Jesper Juhl [EMAIL PROTECTED]
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
Signed-off-by: Jeremy Fitzhardinge [EMAIL
ed. And
IMHO, as long as the driver is in the tree it makes sense to apply
fixes to it.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send
is in the tree it makes sense to apply
fixes to it.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
-by: Jesper Juhl <[EMAIL PROTECTED]>
---
ioatdma.c |1 -
1 file changed, 1 deletion(-)
--- linux-2.6/drivers/dma/ioatdma.c~2007-09-16 23:24:20.0 +0200
+++ linux-2.6/drivers/dma/ioatdma.c 2007-09-16 23:24:20.0 +0200
@@ -244,7 +244,6 @@ stati
nfo'.
This patch adds a kfree() call to free the storage just before
jumping to the label, thus getting rid of the leak.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
inode.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6/fs/cifs/inode.c~ 2007-09-16 23:01:52.
'.
This patch adds a kfree() call to free the storage just before
jumping to the label, thus getting rid of the leak.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
inode.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6/fs/cifs/inode.c~ 2007-09-16 23:01:52.0
-by: Jesper Juhl [EMAIL PROTECTED]
---
ioatdma.c |1 -
1 file changed, 1 deletion(-)
--- linux-2.6/drivers/dma/ioatdma.c~2007-09-16 23:24:20.0 +0200
+++ linux-2.6/drivers/dma/ioatdma.c 2007-09-16 23:24:20.0 +0200
@@ -244,7 +244,6 @@ static void ioat_dma_free_chan_resources
applying-patches.txt btw.
http://lxr.linux.no/source/Documentation/applying-patches.txt
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
In drivers/usb/gadget/amd5536udc.c::udc_pci_probe() -
We allocate storage for 'dev' with kzalloc(), so it is already zero,
no need for an extra memset().
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/usb/gadget/amd5536udc.c |1 -
1 files changed, 0 insertions
In drivers/usb/gadget/amd5536udc.c::udc_pci_probe() -
We allocate storage for 'dev' with kzalloc(), so it is already zero,
no need for an extra memset().
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/usb/gadget/amd5536udc.c |1 -
1 files changed, 0 insertions(+), 1 deletions
l Newbies list may be what you are looking for -
http://kernelnewbies.org/MailingList
--
Jesper Juhl
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-i
be what you are looking for -
http://kernelnewbies.org/MailingList
--
Jesper Juhl
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
ten
help by producing extra valuable debug output (you need to be able
to capture it though, so getting net/serial console setup as well
is usually a good idea if the box hangs completely and you can't
just get info by running dmesg).
Kind regards,
Jesper Juhl
-
To unsubscribe from this
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
>
>
> On Sun, 2 Sep 2007, Jesper Juhl wrote:
> >
> > Thank you for doing this, I hope some of your patches get merged.
> >
> > Btw; it would be easier to see if one has got all the patches if you
> &
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> Hi Jesper,
>
>
> On Sun, 2 Sep 2007, Jesper Juhl wrote:
> >
> > > - if (!(interface = usb_find_interface(_driver, subminor))) {
> > > - dev_err(>sisusb_dev->dev, "
40,10 +2440,8 @@ sisusb_open(struct inode *inode, struct
> struct usb_interface *interface;
> int subminor = iminor(inode);
>
> - if (!(interface = usb_find_interface(_driver, subminor))) {
> - dev_err(>sisusb_dev->dev, "Failed to find
&g
On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote:
>
> drivers/scsi/ips.c: In function ‘ips_register_scsi’:
> drivers/scsi/ips.c:6869:
> warning: ignoring return value of ‘scsi_add_host’, declared with attribute
> warn_unused_result
>
> scsi_add_host() is __must_check, so let's check
et merged.
Btw; it would be easier to see if one has got all the patches if you
numbered your patch series with the usual "[PATCH XX/YY]".
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please htt
Hi,
A little trivial thing...
When sleeping for multiple seconds the function to use is
ssleep() not msleep() - especially when there's a comment
above reading "... wait at least 45 seconds ...", then
ssleep() best describes what is wanted.
Signed-off-by: Jesper Juhl <[EM
re is no master any more, instead. That's the trade-off.
>
Shouldn't the goal be to have both? Multiple individual controls as
well as a Master that adjusts them all. That would also solve Thomas'
problem.
As I see it you broke Thomas' setup and that in my book is a regression.
--
Jesper Juhl <
more, instead. That's the trade-off.
Shouldn't the goal be to have both? Multiple individual controls as
well as a Master that adjusts them all. That would also solve Thomas'
problem.
As I see it you broke Thomas' setup and that in my book is a regression.
--
Jesper Juhl [EMAIL PROTECTED]
Don't
Hi,
A little trivial thing...
When sleeping for multiple seconds the function to use is
ssleep() not msleep() - especially when there's a comment
above reading ... wait at least 45 seconds ..., then
ssleep() best describes what is wanted.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
fs
numbered your patch series with the usual [PATCH XX/YY].
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux
201 - 300 of 2260 matches
Mail list logo
