On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote:
drivers/scsi/ips.c: In function ‘ips_register_scsi’:
drivers/scsi/ips.c:6869:
warning: ignoring return value of ‘scsi_add_host’, declared with attribute
warn_unused_result
scsi_add_host() is __must_check, so let's check it's
);
- if (!(interface = usb_find_interface(sisusb_driver, subminor))) {
- dev_err(sisusb-sisusb_dev-dev, Failed to find
interface\n);
Odd how in your patch the line ends with \n but if I look in my
local copy of the source tree I see \n.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post
On 02/09/07, Satyam Sharma [EMAIL PROTECTED] wrote:
Hi Jesper,
On Sun, 2 Sep 2007, Jesper Juhl wrote:
- if (!(interface = usb_find_interface(sisusb_driver, subminor))) {
- dev_err(sisusb-sisusb_dev-dev, Failed to find
interface¥n);
Odd how in your patch
On 02/09/07, Satyam Sharma [EMAIL PROTECTED] wrote:
On Sun, 2 Sep 2007, Jesper Juhl wrote:
Thank you for doing this, I hope some of your patches get merged.
Btw; it would be easier to see if one has got all the patches if you
numbered your patch series with the usual [PATCH XX/YY
).
Kind regards,
Jesper Juhl
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
own_regressions and/or in a bugzilla
(http://bugzilla.kernel.org/) bugreport so it doesn't get lost.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe
An update to Documentation/fb/00-INDEX is long overdue.
This patch adds entries for new files in the directory
and removes entries for files that no longer exist. The
files are now also sorted alphabetically.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
Documentation/fb/00-INDEX
Add a 00-INDEX file to Documentation/sysctl/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
00-INDEX | 16
1 file changed, 16 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ linux-2.6/Documentation/sysctl/00-INDEX 2007-08-11 23:52:50.000
Add a 00-INDEX file to Documentation/telephony/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
00-INDEX |4
1 file changed, 4 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ linux-2.6/Documentation/telephony/00-INDEX 2007-08-11 23:55:54.0
This patch adds a 00-INDEX file to Documentation/vm/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
00-INDEX | 20
1 file changed, 20 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ Documentation/vm/00-INDEX 2007-08-31 23:16:00.000
Add a 00-INDEX file to Documentation/mips/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
00-INDEX |8
1 file changed, 8 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ linux-2.6/Documentation/mips/00-INDEX 2007-08-11 22:56:26.0
This patch adds a 00-INDEX file to Documentation/vm/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
00-INDEX | 20
1 file changed, 20 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ Documentation/vm/00-INDEX 2007-08-31 23:16:00.0 +0200
Add a 00-INDEX file to Documentation/mips/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
00-INDEX |8
1 file changed, 8 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ linux-2.6/Documentation/mips/00-INDEX 2007-08-11 22:56:26.0
+0200
Add a 00-INDEX file to Documentation/sysctl/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
00-INDEX | 16
1 file changed, 16 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ linux-2.6/Documentation/sysctl/00-INDEX 2007-08-11 23:52:50.0
Add a 00-INDEX file to Documentation/telephony/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
00-INDEX |4
1 file changed, 4 insertions(+)
--- /dev/null 2005-11-21 04:22:37.0 +0100
+++ linux-2.6/Documentation/telephony/00-INDEX 2007-08-11 23:55:54.0
+0200
An update to Documentation/fb/00-INDEX is long overdue.
This patch adds entries for new files in the directory
and removes entries for files that no longer exist. The
files are now also sorted alphabetically.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
Documentation/fb/00-INDEX | 46
://bugzilla.kernel.org/) bugreport so it doesn't get lost.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
L PROTECTED]>
> Cc: Rob Landley <[EMAIL PROTECTED]>
> Cc: Werner Almesberger <[EMAIL PROTECTED]>
> Cc: H. Peter Anvin <[EMAIL PROTECTED]>
>
> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
...
Hi Randy,
I read through your changes and they seem reasonable to me
ou'll get this mail twice ;)
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
-packets.c: In function
'iforce_get_id_packet':
drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable
'status'
if CONFIG_JOYSTICK_IFORCE_USB is not defined.
The warning is easy to avoid by simply moving the variable inside
the only case in the switch that actuall
On Friday 31 August 2007 00:19:53 Joe Perches wrote:
> On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote:
> > Ok, I must admit I didn't check with sparse since it seemed pointless
> > - we usually never cast void pointers to other pointer types,
> > specifically because
to avoid by simply moving the variable inside
the only case in the switch that actually use it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/drivers/input/joystick/iforce/iforce-packets.c
b/drivers/input/joystick/iforce/iforce-packets.c
index 3154ccd..48d4a86 100644
--- a/d
On 30/08/2007, Daniel Drake <[EMAIL PROTECTED]> wrote:
> Jesper Juhl wrote:
> > Since kmalloc() returns a void pointer there is no reason to cast
> > its return value.
> > This patch also removes a pointless initialization of a variable.
>
> NAK: adds a sparse wa
On 30/08/2007, Mohamed Bamakhrama <[EMAIL PROTECTED]> wrote:
> On 8/30/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > On 30/08/2007, Mohamed Bamakhrama <[EMAIL PROTECTED]> wrote:
> > > Hi all,
> > > I have a question regarding the average number of a
but couldn't find any useful papers/resources.
>
Why don't you simply count the number of non-blank non-comment lines
in the source files that you are building, build the kernel and then
count the number of instructions in the resulting binary ?
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top
.
Why don't you simply count the number of non-blank non-comment lines
in the source files that you are building, build the kernel and then
count the number of instructions in the resulting binary ?
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
On 30/08/2007, Mohamed Bamakhrama [EMAIL PROTECTED] wrote:
On 8/30/07, Jesper Juhl [EMAIL PROTECTED] wrote:
On 30/08/2007, Mohamed Bamakhrama [EMAIL PROTECTED] wrote:
Hi all,
I have a question regarding the average number of assembly
instructions per line of kernel code. I know
On 30/08/2007, Daniel Drake [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
Since kmalloc() returns a void pointer there is no reason to cast
its return value.
This patch also removes a pointless initialization of a variable.
NAK: adds a sparse warning
zd_chip.c:116:15: warning: implicit
to avoid by simply moving the variable inside
the only case in the switch that actually use it.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/drivers/input/joystick/iforce/iforce-packets.c
b/drivers/input/joystick/iforce/iforce-packets.c
index 3154ccd..48d4a86 100644
--- a/drivers
On Friday 31 August 2007 00:19:53 Joe Perches wrote:
On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote:
Ok, I must admit I didn't check with sparse since it seemed pointless
- we usually never cast void pointers to other pointer types,
specifically because the C language nicely
/input/joystick/iforce/iforce-packets.c:249: warning: unused variable
'status'
if CONFIG_JOYSTICK_IFORCE_USB is not defined.
The warning is easy to avoid by simply moving the variable inside
the only case in the switch that actually use it.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff
;)
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
: Werner Almesberger [EMAIL PROTECTED]
Cc: H. Peter Anvin [EMAIL PROTECTED]
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
...
Hi Randy,
I read through your changes and they seem reasonable to me, so for
what it's worth;
Acked-by: Jesper Juhl [EMAIL PROTECTED]
--
Jesper Juhl [EMAIL PROTECTED]
Don't
ck
> whether the *current* %esp at oops time has gone too far? But if we
> blew the stack, returned, and *then* oops, I think it'd be hard to know
> without the DEBUG_STACK_USAGE option that we ran out of room.
>
We could also simply have it warn at a higher limit, like 1024 bytes
instead
to know
without the DEBUG_STACK_USAGE option that we ran out of room.
We could also simply have it warn at a higher limit, like 1024 bytes
instead of 512. But I guess then we would get too many false positives
and make it less useful.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http
string.h
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
Documentation/sharedsubtree.txt |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Documentation/sharedsubtree.txt b/Documentation/sharedsubtree.txt
index ccf1ceb..7365400 100644
--- a/Documen
string.h
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
Documentation/sharedsubtree.txt |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Documentation/sharedsubtree.txt b/Documentation/sharedsubtree.txt
index ccf1ceb..7365400 100644
--- a/Documentation/sharedsubtree.txt
want to report this (as pointed out in the error message)
to the GCC folks.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the lin
t
stable kernel - could be that yours is amongst the ones fixed :-)
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line &quo
1, 1000) => easy to detect
> >malloc(-1 * 1000) => malloc(-1000) => not so trivial
>
Ok, that makes a bit of sense. Thank you.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please
.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo
be that yours is amongst the ones fixed :-)
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
in the error message)
to the GCC folks.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On 26/08/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> On Sun, 26 Aug 2007, Jesper Juhl wrote:
>
> > On 26/08/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
>
> > > i was thinking more along the lines of
> > >
> > > msp_parts[i] =
On 26/08/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> On Sun, 26 Aug 2007, Jesper Juhl wrote:
>
> > On 24/08/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
>
> > > actually, i would think kcalloc would be more appropriate here, no?
> > >
>
On 24/08/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> On Fri, 24 Aug 2007, Denys Vlasenko wrote:
>
> > On Friday 24 August 2007 00:52, Jesper Juhl wrote:
> > > kmalloc() returns a void pointer.
> > > No need to cast it.
> >
> &g
On 24/08/07, Robert P. J. Day [EMAIL PROTECTED] wrote:
On Fri, 24 Aug 2007, Denys Vlasenko wrote:
On Friday 24 August 2007 00:52, Jesper Juhl wrote:
kmalloc() returns a void pointer.
No need to cast it.
- msp_flash = (struct mtd_info **)kmalloc(
- fcnt
On 26/08/07, Robert P. J. Day [EMAIL PROTECTED] wrote:
On Sun, 26 Aug 2007, Jesper Juhl wrote:
On 24/08/07, Robert P. J. Day [EMAIL PROTECTED] wrote:
actually, i would think kcalloc would be more appropriate here, no?
Why?
msp_parts[i] = kzalloc(pcnt * sizeof(struct
On 26/08/07, Robert P. J. Day [EMAIL PROTECTED] wrote:
On Sun, 26 Aug 2007, Jesper Juhl wrote:
On 26/08/07, Robert P. J. Day [EMAIL PROTECTED] wrote:
i was thinking more along the lines of
msp_parts[i] = kcalloc(pcnt, sizeof(struct mtd_partition), GFP_KERNEL);
which was kind
d out, the 80 col line length defined in CodingStyle
is not a hard limit in real life. Let the document reflect reality.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
--- Documentation/CodingStyle~ 2007-08-24 13:04:20.0 +0200
+++ Documentation/CodingStyle 2007-08-24 13:04:20.00
On 24/08/07, Denys Vlasenko <[EMAIL PROTECTED]> wrote:
> On Friday 24 August 2007 00:52, Jesper Juhl wrote:
> > kmalloc() returns a void pointer.
> > No need to cast it.
>
> > - msp_flash = (struct mtd_info **)kmalloc(
> > - fcnt * s
On 24/08/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Fri, Aug 24, 2007 at 02:16:12AM +0200, Jesper Juhl wrote:
> > There's no reason to cast void pointers returned by the generic
> > memory allocation functions.
>
> I think I fixed all these already; please check
On 24/08/07, Dave Kleikamp <[EMAIL PROTECTED]> wrote:
> Thanks, but Jack Stone submitted the same patch a few weeks ago. It's
> already in the jfs git tree and the -mm kernel.
>
Ok, I wasn't aware of that, but that's perfect.
Sorry for the noise.
--
Jesper Juhl <[EMAIL PRO
On 24/08/07, Rolf Eike Beer <[EMAIL PROTECTED]> wrote:
> Jesper Juhl wrote:
> > [kv]alloc() return void *. No need to cast the return value.
>
> > @@ -5756,7 +5756,7 @@ static int osst_probe(struct device *dev)
> > write_lock(_scsi_tapes_lock);
>
On 24/08/07, Hans Verkuil <[EMAIL PROTECTED]> wrote:
> On Friday 24 August 2007 02:20:04 Jesper Juhl wrote:
> > Since kzalloc() returns a void pointer, we don't need to cast the
> > return value in drivers/media/video/ivtv/ivtv-queue.c
> >
> > Signed-off-
On 24/08/07, Dave Kleikamp [EMAIL PROTECTED] wrote:
Thanks, but Jack Stone submitted the same patch a few weeks ago. It's
already in the jfs git tree and the -mm kernel.
Ok, I wasn't aware of that, but that's perfect.
Sorry for the noise.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post
On 24/08/07, Rolf Eike Beer [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
[kv]alloc() return void *. No need to cast the return value.
@@ -5756,7 +5756,7 @@ static int osst_probe(struct device *dev)
write_lock(os_scsi_tapes_lock);
if (os_scsi_tapes == NULL
On 24/08/07, Hans Verkuil [EMAIL PROTECTED] wrote:
On Friday 24 August 2007 02:20:04 Jesper Juhl wrote:
Since kzalloc() returns a void pointer, we don't need to cast the
return value in drivers/media/video/ivtv/ivtv-queue.c
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
Jesper,
Thanks
On 24/08/07, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 02:16:12AM +0200, Jesper Juhl wrote:
There's no reason to cast void pointers returned by the generic
memory allocation functions.
I think I fixed all these already; please check scsi-misc.
I just checked out
On 24/08/07, Denys Vlasenko [EMAIL PROTECTED] wrote:
On Friday 24 August 2007 00:52, Jesper Juhl wrote:
kmalloc() returns a void pointer.
No need to cast it.
- msp_flash = (struct mtd_info **)kmalloc(
- fcnt * sizeof(struct map_info *), GFP_KERNEL
in real life. Let the document reflect reality.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
--- Documentation/CodingStyle~ 2007-08-24 13:04:20.0 +0200
+++ Documentation/CodingStyle 2007-08-24 13:04:20.0 +0200
@@ -77,7 +77,8 @@
Coding style is all about readability
On 24/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
[snip]
> The patches in this series are
>
Damn, I managed to mess up that list. Here's how it should have looked :
[PATCH 01/30] ia64: Remove unnecessary cast of allocation return value in
sn_hwperf_enum_objects()
[PATCH 02/30]
vmalloc() returns void *. no need to cast.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
sound/pci/emu10k1/emu10k1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
index 404ae1b..9
vmalloc() returns a void pointer, so there's no need to cast its
return value in mm/page_alloc.c::zone_wait_table_init().
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
mm/page_alloc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_a
There's no need to cast the, void *, return value of kmalloc() when
assigning to a pointer variable.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
fs/jfs/jfs_dtree.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c
In drivers/usb/serial/oti6858.c::pl2303_buf_alloc() the return value
of kmalloc() is being cast to "struct pl2303_buf *", but that need
not be done here since kmalloc() returns "void *".
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/usb/serial/oti6858.c |
In drivers/md/dm-ioctl.c::copy_params() there's a call to vmalloc()
where we currently cast the return value, but that's pretty pointles
given that vmalloc() returns "void *".
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/md/dm-ioctl.c |2 +-
1 files changed, 1
kmalloc() hands us a void pointer, we don't need to cast it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/char/tty_io.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index 51ea93c..9c867cf
vmalloc() returns void * - no need to cast it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/media/dvb/ttpci/av7110.c|2 +-
drivers/media/dvb/ttpci/av7110_ir.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb/ttpci/av71
No need to cast the void pointer returned by kmalloc() in
drivers/media/video/zoran_driver.c::v4l_fbuffer_alloc().
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/media/video/zoran_driver.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers
Since kzalloc() returns a void pointer, we don't need to cast the
return value in drivers/media/video/ivtv/ivtv-queue.c
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/media/video/ivtv/ivtv-queue.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
There's no reason to cast void pointers returned by the generic
memory allocation functions.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/advansys.c b/driver
vmalloc() returns a void pointer that we don't need to cast.
This patch should clean this up in sound/oss/.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
sound/oss/midibuf.c |4 ++--
sound/oss/pss.c |6 +++---
sound/oss/sequencer.c |4 ++--
sound/oss/sscape.c
[kv]alloc() return void *. No need to cast the return value.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/osst.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index 08060fb..3ad9d49
vmalloc() returns void*.
No need to cast in drivers/isdn/hardware/eicon/platform.h::diva_os_malloc()
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/isdn/hardware/eicon/platform.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hardware
vmalloc() returns a void pointer - no need to cast the return value.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/isdn/i4l/isdn_bsdcomp.c |5 ++---
drivers/isdn/i4l/isdn_common.c |2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/is
The general kernel memory allocation functions return void pointers
and there is no need to cast their return values.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/bsd_comp.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bsd_co
kmalloc() and friends return void*, no need to cast it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/wireless/libertas/debugfs.c |2 +-
drivers/net/wireless/libertas/ethtool.c |3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wi
kmalloc() returns a void pointer.
No need to cast it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/mtd/maps/pmcmsp-flash.c | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/maps/pmcmsp-flash.c b/drivers/mtd/maps/pmcmsp-flash.c
kmalloc() returns a void pointer, so there is no need to cast it in
drivers/net/irda/kingsun-sir.c::kingsun_probe().
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/irda/kingsun-sir.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ne
In drivers/mtd/maps/tqm8xxl.c::init_tqm_mtd() it is pointless casting
the return value of kmalloc() since it returns void*.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/mtd/maps/tqm8xxl.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/mt
kzalloc() returns a void pointer - no need to cast it in
drivers/mtd/devices/at91_dataflash26.c::add_dataflash()
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/mtd/devices/at91_dataflash26.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drive
In drivers/message/i2o/i2o_config.c::cfg_open() there's a completely
pointless cast of kmalloc()'s return value. This patch removes it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/message/i2o/i2o_config.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff
vmalloc() returns void*, no need to cast it in drivers/atm/lanai.c
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/atm/lanai.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index 144a49f..59e7dde
kmalloc() returns a void pointer so there is absolutely no need to
cast it in ibmebus_chomp().
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/p
vmalloc() returns a void pointer, so casting to (void *) is pretty pointless.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/um/drivers/ubd_kern.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
kmalloc() returns a void pointer so there's no need to cast the
return value.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/cris/arch-v32/mm/intmem.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/cris/arch-v32/mm/intmem.c b/arch/cris/arch-
vmalloc() returns a void pointer - no need to cast it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/ia64/sn/kernel/sn2/sn_hwperf.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/ia64/sn/kernel/sn2/sn_hwperf.c
b/arch/ia64/sn/kernel/sn2/sn_hw
Hi,
The [kv][mzc]alloc() functions return a void pointer, so when
assigning to a pointer type variable there is no need to cast
the return value.
This is something that is already commonly being cleaned up when
people change nearby code and it's also something people are
usually asked not to
emember
to use their read/insert file functionality instead of cut'n'paste)
then there is no problem.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from
of cut'n'paste)
then there is no problem.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi,
The [kv][mzc]alloc() functions return a void pointer, so when
assigning to a pointer type variable there is no need to cast
the return value.
This is something that is already commonly being cleaned up when
people change nearby code and it's also something people are
usually asked not to
vmalloc() returns a void pointer - no need to cast it.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/ia64/sn/kernel/sn2/sn_hwperf.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/ia64/sn/kernel/sn2/sn_hwperf.c
b/arch/ia64/sn/kernel/sn2/sn_hwperf.c
index
kmalloc() returns a void pointer so there's no need to cast the
return value.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/cris/arch-v32/mm/intmem.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/cris/arch-v32/mm/intmem.c b/arch/cris/arch-v32/mm
vmalloc() returns a void pointer, so casting to (void *) is pretty pointless.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/um/drivers/ubd_kern.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index
kmalloc() returns a void pointer so there is absolutely no need to
cast it in ibmebus_chomp().
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/powerpc/kernel/ibmebus.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc
vmalloc() returns void*, no need to cast it in drivers/atm/lanai.c
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/atm/lanai.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index 144a49f..59e7dde 100644
--- a/drivers
In drivers/message/i2o/i2o_config.c::cfg_open() there's a completely
pointless cast of kmalloc()'s return value. This patch removes it.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/message/i2o/i2o_config.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git
kzalloc() returns a void pointer - no need to cast it in
drivers/mtd/devices/at91_dataflash26.c::add_dataflash()
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/mtd/devices/at91_dataflash26.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/devices
In drivers/mtd/maps/tqm8xxl.c::init_tqm_mtd() it is pointless casting
the return value of kmalloc() since it returns void*.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/mtd/maps/tqm8xxl.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/maps
301 - 400 of 2260 matches
Mail list logo
