Re: [PATCH] clk: imx: reference preceded by free

On Tue, 30 Mar 2021 19:16:48 -0700 Stephen Boyd wrote: > Quoting Jian Dong (2021-03-22 20:10:34) > > From: Jian Dong > > > > when register failed, clk will be freed, it will generate dangling > > pointer problem in later reference. it should return directly. > &

Re: [PATCH] regulator: Use IRQF_ONESHOT

On Thu, 25 Mar 2021 14:29:02 +0200 Felipe Balbi wrote: > Hi, > > Krzysztof Kozlowski writes: > > On 23/03/2021 13:12, Jian Dong wrote: > >> From: Jian Dong > >> > >> Fixes coccicheck error: > >> > >> drivers/regulator/mt6360

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

On Thu, 25 Mar 2021 11:29:06 +0100 Greg KH wrote: > On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > > From: Jian Dong > > > > fixes coccicheck Error: > > > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > > fw is NULL but derefere

[PATCH] staging: greybus: fix fw is NULL but dereferenced

From: Jian Dong fixes coccicheck Error: drivers/staging/greybus/bootrom.c:301:41-45: ERROR: fw is NULL but dereferenced. if procedure goto label directly, ret will be nefative, so the fw is NULL and the if(condition) end with dereferenced fw. let's fix it. Signed-off-by: Jian

[RESEND] regulator: mt6360: remove redundant error print

From: Jian Dong fixes coccicheck warning: drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is redundant because platform_get_irq() already prints an error in fact it is not platform_get_irq but platform_get_irq_byname print error Signed-off-by: Jian Dong --- drivers/regulator/mt6360

Re: [PATCH] regulator: mt6360: remove redundant error print

On Tue, 23 Mar 2021 17:16:28 + Mark Brown wrote: > On Tue, Mar 23, 2021 at 08:22:41PM +0800, Jian Dong wrote: > > From: Jian Dong > > > > fixes coccicheck warning: > > > > drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is > > redundant becau

[PATCH] regulator: mt6360: remove redundant error print

From: Jian Dong fixes coccicheck warning: drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is redundant because platform_get_irq() already prints an error in fact, it is not platform_get_irq but platform_get_irq_byname print error Signed-off-by: Jian Dong --- drivers/regulator/mt6360

[PATCH] regulator: Use IRQF_ONESHOT

From: Jian Dong Fixes coccicheck error: drivers/regulator/mt6360-regulator.c:388:8-33: ERROR: drivers/regulator/pca9450-regulator.c:781:7-32: ERROR: drivers/regulator/slg51000-regulator.c:480:8-33: ERROR: drivers/regulator/qcom-labibb-regulator.c:364:8-33: ERROR: Threaded IRQ with no primary

[PATCH] clk: imx: reference preceded by free

From: Jian Dong when register failed, clk will be freed, it will generate dangling pointer problem in later reference. it should return directly. Signed-off-by: Jian Dong --- drivers/clk/imx/clk-lpcg-scu.c | 1 + drivers/clk/imx/clk-scu.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH] power-supply: Use IRQF_ONESHOT

From: dongjian Fixes coccicheck error: drivers/power/supply/pm2301_charger.c:1089:7-27: ERROR: drivers/power/supply/lp8788-charger.c:502:8-28: ERROR: drivers/power/supply/tps65217_charger.c:239:8-33: ERROR: drivers/power/supply/tps65090-charger.c:303:8-33: ERROR: Threaded IRQ with no primary ha

[PATCH] w1: Use kobj_to_dev()[RESEND]

From: dongjian Use kobj_to_dev() instead of open-coding it Signed-off-by: dongjian --- drivers/w1/slaves/w1_ds2780.c | 2 +- drivers/w1/slaves/w1_ds2781.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2780.c b/drivers/w1/slaves/w1_ds2780.c index

[PATCH] power-supply: use kobj_to_dev()

From: dongjian Use kobj_to_dev() instead of open-coding it Signed-off-by: dongjian --- drivers/power/supply/ds2781_battery.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/ds2781_battery.c b/drivers/power/supply/ds2781_battery.c index 3df3c82.