Re: [PATCH v11 1/2] usb: Add devaddr in struct usb_device

2019-06-05 Thread Jim Lin
On 2019年06月03日 18:53, Jim Lin wrote: The Clear_TT_Buffer request sent to the hub includes the address of the LS/FS child device in wValue field. usb_hub_clear_tt_buffer() uses udev->devnum to set the address wValue. This won't work for devices connected to xHC. For other host controllers u

Re: [PATCH v11 0/2] usb: xhci: Add Clear_TT_Buffer

2019-06-04 Thread Jim Lin
On 2019年06月03日 20:23, Greg KH wrote: On Mon, Jun 03, 2019 at 06:53:42PM +0800, Jim Lin wrote: USB 2.0 specification chapter 11.17.5 says "as part of endpoint halt processing for full-/low-speed endpoints connected via a TT, the host software must use the Clear_TT_Buffer request to t

[PATCH v11 1/2] usb: Add devaddr in struct usb_device

2019-06-03 Thread Jim Lin
ddress of the usb device, chosen and set by usb core. With xHC the controller hardware assigns the address, and won't be the same as devnum. Here we add devaddr in "struct usb_device" for usb_hub_clear_tt_buffer() to use. Signed-off-by: Jim Lin --- v2: xhci_clear_tt_buffer_complete: add

[PATCH v11 2/2] usb: xhci: Add Clear_TT_Buffer

2019-06-03 Thread Jim Lin
following Set_Interface requests to the device to get ACK successfully. Signed-off-by: Jim Lin --- v2: xhci_clear_tt_buffer_complete: add static, shorter indentation , remove its claiming in xhci.h v3: Add description for clearing_tt (xhci.h) v4: Remove clearing_tt flag because hub_tt_work has hu

[PATCH v11 0/2] usb: xhci: Add Clear_TT_Buffer

2019-06-03 Thread Jim Lin
_buffer() to use. Another is to invoke usb_hub_clear_tt_buffer() for halt processing. Signed-off-by: Jim Lin Jim Lin (2): usb: Add devaddr in struct usb_device usb: xhci: Add Clear_TT_Buffer drivers/usb/core/hub.c | 4 +++- drivers/usb/host/xhci-ring.c | 27 ++-

[PATCH v11 1/2] usb: Add devaddr in struct usb_device

2019-05-29 Thread Jim Lin
ddress of the usb device, chosen and set by usb core. With xHC the controller hardware assigns the address, and won't be the same as devnum. Here we add devaddr in "struct usb_device" for usb_hub_clear_tt_buffer() to use. Signed-off-by: Jim Lin --- v2: xhci_clear_tt_buffer_complete: add

[PATCH v11 2/2] usb: xhci: Add Clear_TT_Buffer

2019-05-29 Thread Jim Lin
following Set_Interface requests to the device to get ACK successfully. Signed-off-by: Jim Lin --- v2: xhci_clear_tt_buffer_complete: add static, shorter indentation , remove its claiming in xhci.h v3: Add description for clearing_tt (xhci.h) v4: Remove clearing_tt flag because hub_tt_work has hu

[PATCH v11 0/2] usb: xhci: Add Clear_TT_Buffer

2019-05-29 Thread Jim Lin
_buffer() to use. Another is to invoke usb_hub_clear_tt_buffer() for halt processing. Signed-off-by: Jim Lin Jim Lin (2): usb: Add devaddr in struct usb_device usb: xhci: Add Clear_TT_Buffer drivers/usb/core/hub.c | 4 +++- drivers/usb/host/xhci-ring.c | 27 ++-

Re: [PATCH v10 1/2] usb: xhci : Add devaddr in struct usb_device

2019-05-17 Thread Jim Lin
Sorry, something went wrong. The result is not as expected in one of the tests. Abandon this series of patches. Will debug and resubmit later. Jim On 2019年05月16日 22:56, Alan Stern wrote: On Thu, 16 May 2019, Jim Lin wrote: The Clear_TT_Buffer request sent to the hub includes the address

[PATCH v9 0/2] usb: xhci: Add Clear_TT_Buffer

2019-05-10 Thread Jim Lin
_buffer() to use. Another is to update devaddr in XHCI address_device callback function and invoke usb_hub_clear_tt_buffer() for halt processing. Signed-off-by: Jim Lin Jim Lin (2): usb: hub : Add devaddr in struct usb_device usb: xhci: Add Clear_TT_Buffer drivers/usb/core/hub.c | 4 +

[PATCH v9 1/2] usb: hub : Add devaddr in struct usb_device

2019-05-10 Thread Jim Lin
ddress of the usb device, chosen and set by usb core. With xHC the controller hardware assigns the address, and won't be the same as devnum. Here we add devaddr in "struct usb_device" for usb_hub_clear_tt_buffer() to use. Signed-off-by: Jim Lin --- v2: xhci_clear_tt_buffer_complete: add

[PATCH v9 2/2] usb: xhci: Add Clear_TT_Buffer

2019-05-10 Thread Jim Lin
CI controller) and invoke usb_hub_clear_tt_buffer() to send Clear_TT_Buffer request to the hub of the device for the following Set_Interface requests to the device to get ACK successfully. Signed-off-by: Jim Lin --- v2: xhci_clear_tt_buffer_complete: add static, shorter indentation , remove

[PATCH v4 1/1] usb: xhci: Add Clear_TT_Buffer

2019-05-06 Thread Jim Lin
Originally usb_hub_clear_tt_buffer uses urb->dev->devnum as device address while sending Clear_TT_Buffer command, but this doesn't work for XHCI. We have to extend usb_hub_clear_tt_buffer parameter to specify device number that will have the TT state of its hub cleared. Signed-off-by:

Re: [PATCH 1/1 V2] media: usb: uvc: Fix incorrect timeout for Get Request

2017-07-13 Thread Jim Lin
On 2017年07月11日 03:47, Laurent Pinchart wrote: Hi Jim, Thank you for the patch. On Monday 10 Jul 2017 14:43:49 Jim Lin wrote: Section 9.2.6.4 of USB 2.0/3.x specification describes that "device must be able to return the first data packet to host within 500 ms of receipt of the re

Re: [PATCH 1/1 V2] media: usb: uvc: Fix incorrect timeout for Get Request

2017-07-13 Thread Jim Lin
On 2017年07月11日 03:47, Laurent Pinchart wrote: Hi Jim, Thank you for the patch. On Monday 10 Jul 2017 14:43:49 Jim Lin wrote: Section 9.2.6.4 of USB 2.0/3.x specification describes that "device must be able to return the first data packet to host within 500 ms of receipt of the re

[PATCH 1/1 V2] media: usb: uvc: Fix incorrect timeout for Get Request

2017-07-10 Thread Jim Lin
and change it from 300 ms to 500 ms to meet the timing specified by specification for Get Request. Signed-off-by: Jim Lin <ji...@nvidia.com> --- V2: Change patch description drivers/media/usb/uvc/uvcvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/us

[PATCH 1/1 V2] media: usb: uvc: Fix incorrect timeout for Get Request

2017-07-10 Thread Jim Lin
and change it from 300 ms to 500 ms to meet the timing specified by specification for Get Request. Signed-off-by: Jim Lin --- V2: Change patch description drivers/media/usb/uvc/uvcvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvcvideo.h b/dri

[PATCH 1/1] media: usb: uvc: Fix incorrect timeout for Get Request

2017-06-30 Thread Jim Lin
meout from 300 to 500 ms for Get Request. Signed-off-by: Jim Lin <ji...@nvidia.com> --- drivers/media/usb/uvc/uvcvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h index 15e415e..296b69b 100644 --- a/d

[PATCH 1/1] media: usb: uvc: Fix incorrect timeout for Get Request

2017-06-30 Thread Jim Lin
meout from 300 to 500 ms for Get Request. Signed-off-by: Jim Lin --- drivers/media/usb/uvc/uvcvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h index 15e415e..296b69b 100644 --- a/drivers/media/usb/uvc/

[PATCH v3] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Jim Lin
b_string_copy kfree but configfs_composite_bind hasn't been run in time to assign new allocated "cn->configuration" pointer to "cn->strings.s". When "strlen(s->s) of usb_gadget_get_string is being executed, the dangling memory is accessed, "BUG: KASAN: use-after-fre

[PATCH v3] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Jim Lin
b_string_copy kfree but configfs_composite_bind hasn't been run in time to assign new allocated "cn->configuration" pointer to "cn->strings.s". When "strlen(s->s) of usb_gadget_get_string is being executed, the dangling memory is accessed, "BUG: KASAN: use-after-free" er

[PATCH v2] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Jim Lin
y has been released by usb_string_copy kfree but configfs_composite_bind hasn't been run in time to assign new allocated "cn->configuration" pointer to "cn->strings.s". When "strlen(s->s) of usb_gadget_get_string is being executed, the dangling memory is accessed, "BUG: KA

[PATCH v2] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Jim Lin
y has been released by usb_string_copy kfree but configfs_composite_bind hasn't been run in time to assign new allocated "cn->configuration" pointer to "cn->strings.s". When "strlen(s->s) of usb_gadget_get_string is being executed, the dangling memory is accessed, "BUG: KA

Re: [PATCH] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Jim Lin
On 2017年01月17日 16:07, Felipe Balbi wrote: Hi, Jim Lin <ji...@nvidia.com> writes: When gadget is disconnected, running sequence is like this. . android_work: sent uevent USB_STATE=DISCONNECTED I'm gonna have to ask you to try with actual mainline where there are no Android changes.

Re: [PATCH] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Jim Lin
On 2017年01月17日 16:07, Felipe Balbi wrote: Hi, Jim Lin writes: When gadget is disconnected, running sequence is like this. . android_work: sent uevent USB_STATE=DISCONNECTED I'm gonna have to ask you to try with actual mainline where there are no Android changes. Let me rephrase and resend

[PATCH] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Jim Lin
s accessed, "BUG: KASAN: use-after-free" error occurs. Signed-off-by: Jim Lin <ji...@nvidia.com> --- drivers/usb/gadget/configfs.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c in

[PATCH] usb: gadget: configfs: Fix KASAN use-after-free

2017-01-17 Thread Jim Lin
s accessed, "BUG: KASAN: use-after-free" error occurs. Signed-off-by: Jim Lin --- drivers/usb/gadget/configfs.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c index 78c4497..39fea62 1006

[PATCH 1/1] usb: xhci: Fix panic if disconnect

2016-07-20 Thread Jim Lin
m: kworker/0:1 Tainted: G U [] Workqueue: pm pm_runtime_work [] task: ffc0bc0e0bc0 ti: ffc0bc0ec000 task.ti: ffc0bc0ec000 [] PC is at xhci_stop_device.constprop.11+0xb4/0x1a4 This issue is found when running with realtek ethernet device (0bda:8153). Signed-off-by: Jim Lin <ji...@nvid

[PATCH 1/1] usb: xhci: Fix panic if disconnect

2016-07-20 Thread Jim Lin
m: kworker/0:1 Tainted: G U [] Workqueue: pm pm_runtime_work [] task: ffc0bc0e0bc0 ti: ffc0bc0ec000 task.ti: ffc0bc0ec000 [] PC is at xhci_stop_device.constprop.11+0xb4/0x1a4 This issue is found when running with realtek ethernet device (0bda:8153). Signed-off-by: Jim Lin --- driver

[PATCH 1/1] usb: xhci: Fix panic if disconnect

2016-07-20 Thread Jim Lin
m: kworker/0:1 Tainted: G U [] Workqueue: pm pm_runtime_work [] task: ffc0bc0e0bc0 ti: ffc0bc0ec000 task.ti: ffc0bc0ec000 [] PC is at xhci_stop_device.constprop.11+0xb4/0x1a4 This issue is found when running with realtek ethernet device (0bda:8153). Signed-off-by: Jim Lin <ji...@nvid

[PATCH 1/1] usb: xhci: Fix panic if disconnect

2016-07-20 Thread Jim Lin
m: kworker/0:1 Tainted: G U [] Workqueue: pm pm_runtime_work [] task: ffc0bc0e0bc0 ti: ffc0bc0ec000 task.ti: ffc0bc0ec000 [] PC is at xhci_stop_device.constprop.11+0xb4/0x1a4 This issue is found when running with realtek ethernet device (0bda:8153). Signed-off-by: Jim Lin --- driver

[PATCH v2 1/1] usb: gadget: f_fs: Fix wrong check on reserved1 of OS_DESC_EXT_COMPAT

2016-05-20 Thread Jim Lin
Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 field of OS_DESC_EXT_COMPAT and return -EINVAL if it's 1. But MS OS 1.0 Descriptors http://msdn.microsoft.com/en-us/library/windows/hardware/gg463179.aspx defines that field to be 1. Signed-off-by: Jim Lin <ji...@nvidia.com>

[PATCH v2 1/1] usb: gadget: f_fs: Fix wrong check on reserved1 of OS_DESC_EXT_COMPAT

2016-05-20 Thread Jim Lin
Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 field of OS_DESC_EXT_COMPAT and return -EINVAL if it's 1. But MS OS 1.0 Descriptors http://msdn.microsoft.com/en-us/library/windows/hardware/gg463179.aspx defines that field to be 1. Signed-off-by: Jim Lin --- v2: Rewording on commit

[PATCH 1/1] usb: gadget: f_fs: Fix kernel panic if use_os_string not set

2016-05-13 Thread Jim Lin
If c->cdev->use_os_string flag is not set, don't need to invoke ffs_do_os_descs() in _ffs_func_bind. So uninitialized ext_compat_id pointer won't be accessed by __ffs_func_bind_do_os_desc to cause kernel panic. Signed-off-by: Jim Lin <ji...@nvidia.com> --- drivers/usb/gadget/function

[PATCH 1/1] usb: gadget: f_fs: Fix kernel panic if use_os_string not set

2016-05-13 Thread Jim Lin
If c->cdev->use_os_string flag is not set, don't need to invoke ffs_do_os_descs() in _ffs_func_bind. So uninitialized ext_compat_id pointer won't be accessed by __ffs_func_bind_do_os_desc to cause kernel panic. Signed-off-by: Jim Lin --- drivers/usb/gadget/function/f_fs.

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-05 Thread Jim Lin
On 2016年05月04日 18:37, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin <ji...@nvidia.com> writes: In f_fs.c " static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, struct usb_os_desc_header *h, void *data, unsigne

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-05 Thread Jim Lin
On 2016年05月04日 18:37, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin writes: In f_fs.c " static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, struct usb_os_desc_header *h, void *data, unsigned len, void

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-05 Thread Jim Lin
On 2016年05月04日 18:37, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin <ji...@nvidia.com> writes: In f_fs.c " static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, struct usb_os_desc_header *h, void *data, unsigne

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-05 Thread Jim Lin
On 2016年05月04日 18:37, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin writes: In f_fs.c " static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, struct usb_os_desc_header *h, void *data, unsigned len, void

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-04 Thread Jim Lin
On 2016年04月29日 19:57, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin <ji...@nvidia.com> writes: On 2016年04月28日 20:21, Felipe Balbi wrote: I also attach git log of system/core/adb/usb_linux_client.cpp of Android N for your reference. " Author: Badhri Jagan Sri

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-05-04 Thread Jim Lin
On 2016年04月29日 19:57, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, Jim Lin writes: On 2016年04月28日 20:21, Felipe Balbi wrote: I also attach git log of system/core/adb/usb_linux_client.cpp of Android N for your reference. " Author: Badhri Jagan Sridharan Date: Mon Oct 5 13:

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-29 Thread Jim Lin
On 2016年04月28日 20:21, Felipe Balbi wrote: I also attach git log of system/core/adb/usb_linux_client.cpp of Android N for your reference. " Author: Badhri Jagan Sridharan Date: Mon Oct 5 13:04:03 2015 -0700 adbd: Add os descriptor support for adb. Eventhough

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-29 Thread Jim Lin
On 2016年04月28日 20:21, Felipe Balbi wrote: I also attach git log of system/core/adb/usb_linux_client.cpp of Android N for your reference. " Author: Badhri Jagan Sridharan Date: Mon Oct 5 13:04:03 2015 -0700 adbd: Add os descriptor support for adb. Eventhough windows does not

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-28 Thread Jim Lin
On 2016年04月26日 16:49, Jim Lin wrote: On 2016年04月25日 20:01, Felipe Balbi wrote: * PGP Signed by an unknown key Is this happening on set_config() ? If that's the case, why is gadget->speed set to USB_SPEED_SUPER to start with ? Your controller should already have negotiated highspeed wh

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-28 Thread Jim Lin
On 2016年04月26日 16:49, Jim Lin wrote: On 2016年04月25日 20:01, Felipe Balbi wrote: * PGP Signed by an unknown key Is this happening on set_config() ? If that's the case, why is gadget->speed set to USB_SPEED_SUPER to start with ? Your controller should already have negotiated highspeed wh

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-26 Thread Jim Lin
On 2016年04月25日 20:01, Felipe Balbi wrote: * PGP Signed by an unknown key Is this happening on set_config() ? If that's the case, why is gadget->speed set to USB_SPEED_SUPER to start with ? Your controller should already have negotiated highspeed which means function_descriptors() should

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-26 Thread Jim Lin
On 2016年04月25日 20:01, Felipe Balbi wrote: * PGP Signed by an unknown key Is this happening on set_config() ? If that's the case, why is gadget->speed set to USB_SPEED_SUPER to start with ? Your controller should already have negotiated highspeed which means function_descriptors() should

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-25 Thread Jim Lin
On 2016年04月22日 19:52, Felipe Balbi wrote: * PGP Signed by an unknown key Hi Jim, Jim Lin <ji...@nvidia.com> writes: Android N adds os_desc_compat in v2_descriptor by init_functionfs() (system/core/adb/usb_linux_client.cpp) to support automatic install of MTP driver on Windows for USB

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-25 Thread Jim Lin
On 2016年04月22日 19:52, Felipe Balbi wrote: * PGP Signed by an unknown key Hi Jim, Jim Lin writes: Android N adds os_desc_compat in v2_descriptor by init_functionfs() (system/core/adb/usb_linux_client.cpp) to support automatic install of MTP driver on Windows for USB device mode. Current

[PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-22 Thread Jim Lin
with v2_descriptor which has ss_descriptors filled. Signed-off-by: Jim Lin <ji...@nvidia.com> --- drivers/usb/gadget/function/f_fs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 73515d5..f5ea3df

[PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

2016-04-22 Thread Jim Lin
with v2_descriptor which has ss_descriptors filled. Signed-off-by: Jim Lin --- drivers/usb/gadget/function/f_fs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 73515d5..f5ea3df 100644 --- a/drivers/usb

Re: [PATCH v5 20/21] clk: tegra210: add support for Tegra210 clocks

2015-05-20 Thread Jim Lin
On 05/13/2015 01:24 AM, Rhyland Klein wrote: diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c new file mode 100644 index ..7f25e60e4d48 --- /dev/null +++ b/drivers/clk/tegra/clk-tegra210.c + +static struct tegra_clk_init_table common_init_table[]

Re: [PATCH v5 20/21] clk: tegra210: add support for Tegra210 clocks

2015-05-20 Thread Jim Lin
On 05/13/2015 01:24 AM, Rhyland Klein wrote: diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c new file mode 100644 index ..7f25e60e4d48 --- /dev/null +++ b/drivers/clk/tegra/clk-tegra210.c + +static struct tegra_clk_init_table common_init_table[]

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Jim Lin
On 05/05/2015 12:37 AM, Rhyland Klein wrote: diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c new file mode 100644 index ..07382a473e22 --- /dev/null +++ b/drivers/clk/tegra/clk-tegra210.c @@ -0,0 +1,2761 @@ +/* + * Copyright (c) 2012-2014 NVIDIA

Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks

2015-05-07 Thread Jim Lin
On 05/05/2015 12:37 AM, Rhyland Klein wrote: diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c new file mode 100644 index ..07382a473e22 --- /dev/null +++ b/drivers/clk/tegra/clk-tegra210.c @@ -0,0 +1,2761 @@ +/* + * Copyright (c) 2012-2014 NVIDIA

Re: [PATCH v4 02/20] clk: tegra: periph: add new periph clks and muxes for Tegra210

2015-05-06 Thread Jim Lin
On 05/05/2015 12:37 AM, Rhyland Klein wrote: Tegra210 has significant differences in muxes for peripheral clocks. One of the most important changes is that pll_m isn't to be used as a source for peripherals. Therefore, we need to define the new muxes and new clocks to use those muxes for

Re: [PATCH v4 02/20] clk: tegra: periph: add new periph clks and muxes for Tegra210

2015-05-06 Thread Jim Lin
On 05/05/2015 12:37 AM, Rhyland Klein wrote: Tegra210 has significant differences in muxes for peripheral clocks. One of the most important changes is that pll_m isn't to be used as a source for peripherals. Therefore, we need to define the new muxes and new clocks to use those muxes for

RE: [PATCH v3 12/20] clk: tegra: pll: Add specialized logic for T210

2015-05-01 Thread Jim Lin
> +static void clk_plle_tegra210_is_enabled(struct struct clk_hw *hw) { Returned type is "int" instead of "void". Also one "struct" only for "clk_hw *hw"? > + struct tegra_clk_pll *pll = to_clk_pll(hw); > + u32 val; > + > + val = pll_readl_base(pll); > + > + return val &

RE: [PATCH v3 12/20] clk: tegra: pll: Add specialized logic for T210

2015-05-01 Thread Jim Lin
+static void clk_plle_tegra210_is_enabled(struct struct clk_hw *hw) { Returned type is int instead of void. Also one struct only for clk_hw *hw? + struct tegra_clk_pll *pll = to_clk_pll(hw); + u32 val; + + val = pll_readl_base(pll); + + return val PLLE_BASE_ENABLE ? 1 :

[PATCH 1/1] pinctrl: Fix two deadlocks

2015-01-08 Thread Jim Lin
ing lock B and trying to acquire lock A, CPU#0 is holding lock D and trying to acquire lock B. Signed-off-by: Jim Lin --- drivers/pinctrl/core.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index e4f65510c87e..89dca

[PATCH 1/1] pinctrl: Fix two deadlocks

2015-01-08 Thread Jim Lin
to acquire lock B. Signed-off-by: Jim Lin ji...@nvidia.com --- drivers/pinctrl/core.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index e4f65510c87e..89dca77ca038 100644 --- a/drivers/pinctrl/core.c +++ b/drivers

RE: [PATCH v3 3/6] misc: fuse: Add efuse driver for Tegra

2014-02-05 Thread Jim Lin
Please ignore my comment. I will try to use exported tegra_fuse_readl(). -Original Message- From: Peter De Schrijver [mailto:pdeschrij...@nvidia.com] Sent: Monday, February 03, 2014 10:15 PM To: Jim Lin Cc: linux-arm-ker...@lists.infradead.org; linux-te...@vger.kernel.org; linux-kernel

RE: [PATCH v3 3/6] misc: fuse: Add efuse driver for Tegra

2014-02-05 Thread Jim Lin
Please ignore my comment. I will try to use exported tegra_fuse_readl(). -Original Message- From: Peter De Schrijver [mailto:pdeschrij...@nvidia.com] Sent: Monday, February 03, 2014 10:15 PM To: Jim Lin Cc: linux-arm-ker...@lists.infradead.org; linux-te...@vger.kernel.org; linux-kernel

Re: [PATCH v3 3/6] misc: fuse: Add efuse driver for Tegra

2014-01-28 Thread Jim Lin
On Wed, 2014-01-29 at 07:36 +0800, Peter De Schrijver wrote: > Implement fuse driver for Tegra20, Tegra30, Tegra114 and Tegra124. > > Signed-off-by: Peter De Schrijver > --- > Documentation/ABI/testing/sysfs-driver-tegra-fuse |8 + > drivers/misc/fuse/Makefile|1

Re: [PATCH v3 3/6] misc: fuse: Add efuse driver for Tegra

2014-01-28 Thread Jim Lin
On Wed, 2014-01-29 at 07:36 +0800, Peter De Schrijver wrote: Implement fuse driver for Tegra20, Tegra30, Tegra114 and Tegra124. Signed-off-by: Peter De Schrijver pdeschrij...@nvidia.com --- Documentation/ABI/testing/sysfs-driver-tegra-fuse |8 + drivers/misc/fuse/Makefile

RE: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
>-Original Message- >From: Greg KH [mailto:gre...@linuxfoundation.org] >Sent: Wednesday, September 19, 2012 4:04 PM >To: Jim Lin >Cc: swar...@wwwdotorg.org; linux-...@vger.kernel.org; >linux-kernel@vger.kernel.org >Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegr

RE: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
>-Original Message- >From: Greg KH [mailto:gre...@linuxfoundation.org] >Sent: Wednesday, September 19, 2012 2:29 PM >To: Jim Lin >Cc: swar...@wwwdotorg.org; linux-...@vger.kernel.org; >linux-kernel@vger.kernel.org >Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegr

Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
On Wed, 2012-09-19 at 14:29 +0800, Greg KH wrote: > On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote: > > Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, > > are not correctly accessed on Tegra3 platform. > > > > Signed-off-by: Jim Lin > > --

Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
On Wed, 2012-09-19 at 14:29 +0800, Greg KH wrote: On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote: Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, are not correctly accessed on Tegra3 platform. Signed-off-by: Jim Lin ji...@nvidia.com --- Changes in v2: - Modify

RE: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Wednesday, September 19, 2012 2:29 PM To: Jim Lin Cc: swar...@wwwdotorg.org; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

RE: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Wednesday, September 19, 2012 4:04 PM To: Jim Lin Cc: swar...@wwwdotorg.org; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

[PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-18 Thread Jim Lin
Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, are not correctly accessed on Tegra3 platform. Signed-off-by: Jim Lin --- Changes in v2: - Modify array size for reserved4[] only. - Note that defining hostpc[0] is for a variable-length object. include/linux/usb/ehci_def.h |2

[PATCH 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-18 Thread Jim Lin
Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, are not correctly accessed on Tegra3 platform. Signed-off-by: Jim Lin --- include/linux/usb/ehci_def.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/usb/ehci_def.h b/include/linux/usb

[PATCH 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-18 Thread Jim Lin
Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, are not correctly accessed on Tegra3 platform. Signed-off-by: Jim Lin ji...@nvidia.com --- include/linux/usb/ehci_def.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/usb/ehci_def.h b

[PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-18 Thread Jim Lin
Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, are not correctly accessed on Tegra3 platform. Signed-off-by: Jim Lin ji...@nvidia.com --- Changes in v2: - Modify array size for reserved4[] only. - Note that defining hostpc[0] is for a variable-length object. include/linux/usb