[PATCH] gpiolib: fix freeing of descriptors on error

2018-09-13 Thread Jim Paris
b: do not free unrequested descriptors") Signed-off-by: Jim Paris --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index e8f8a1999393..a57300c1d649 100644 --- a/drivers/gpio/gpiolib.c +++ b/dr

[PATCH] gpiolib: fix freeing of descriptors on error

2018-09-13 Thread Jim Paris
b: do not free unrequested descriptors") Signed-off-by: Jim Paris --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index e8f8a1999393..a57300c1d649 100644 --- a/drivers/gpio/gpiolib.c +++ b/dr

Re: [PATCH 0/3] block/ps3vram: Minor updates and fixes

2015-06-10 Thread Jim Paris
nquiries regarding it. Thanks Geoff. Acked-by: Jim Paris Jim > > Please apply, thanks. > > -Geoff > > The following changes since commit d4a4f75cd8f29cd9464a5a32e9224a91571d6649: > > Linux 4.1-rc7 (2015-06-07 20:23:50 -0700) > > are available in the git reposito

Re: [PATCH 0/3] block/ps3vram: Minor updates and fixes

2015-06-10 Thread Jim Paris
it. Thanks Geoff. Acked-by: Jim Paris j...@jtan.com Jim Please apply, thanks. -Geoff The following changes since commit d4a4f75cd8f29cd9464a5a32e9224a91571d6649: Linux 4.1-rc7 (2015-06-07 20:23:50 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux

[PATCH v4-real] cdc-acm: ensure that termios get set when the port is activated

2014-10-30 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris --- Johan Hovold wrote: > On Thu, Oct 30, 2014 at 10:45:38AM -0400, Jim Paris wr

[PATCH v4] cdc-acm: ensure that termios get set when the port is activated

2014-10-30 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris --- Moved prototype. Thanks, Jim --- drivers/usb/class/cdc-acm.c | 5 + 1 file

[PATCH v4] cdc-acm: ensure that termios get set when the port is activated

2014-10-30 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris j...@jtan.com --- Moved prototype. Thanks, Jim --- drivers/usb/class/cdc-acm.c | 5

[PATCH v4-real] cdc-acm: ensure that termios get set when the port is activated

2014-10-30 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris j...@jtan.com --- Johan Hovold wrote: On Thu, Oct 30, 2014 at 10:45:38AM -0400, Jim

[PATCH v3] cdc-acm: ensure that termios get set when the port is activated

2014-10-29 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris --- Switched to Johan's suggestion of using a prototype rather than moving

[PATCH v2] cdc-acm: ensure that termios get set when the port is activated

2014-10-29 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris --- Peter Hurley wrote: > Yeah, you're right that the cdc-acm driver isn't prope

[PATCH v2] cdc-acm: ensure that termios get set when the port is activated

2014-10-29 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris j...@jtan.com --- Peter Hurley wrote: Yeah, you're right that the cdc-acm driver isn't

[PATCH v3] cdc-acm: ensure that termios get set when the port is activated

2014-10-29 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris j...@jtan.com --- Switched to Johan's suggestion of using a prototype rather than moving

[PATCH] cdc-acm: ensure that termios get set when the port is opened

2014-10-28 Thread Jim Paris
Do what other drivers like ftdi_sio do, and ensure that termios are written to the device when the port is first opened. Signed-off-by: Jim Paris --- Tested on v3.16.5. I've seen a problem on two CDC-ACM systems based on a Segger J-Link where the port does not get initialized at the correct

[PATCH] cdc-acm: ensure that termios get set when the port is opened

2014-10-28 Thread Jim Paris
Do what other drivers like ftdi_sio do, and ensure that termios are written to the device when the port is first opened. Signed-off-by: Jim Paris j...@jtan.com --- Tested on v3.16.5. I've seen a problem on two CDC-ACM systems based on a Segger J-Link where the port does not get initialized

Re: [PATCH v3 07/26] block: Use bio_sectors() more consistently

2012-09-24 Thread Jim Paris
" > CC: Nick Piggin > CC: Jiri Kosina > CC: Jim Paris > CC: Geoff Levand > CC: Alasdair Kergon > CC: dm-de...@redhat.com > CC: Neil Brown > CC: Steven Rostedt > --- > drivers/block/aoe/aoecmd.c | 2 +- > drivers/block/brd.c | 3 +-- > driver

Re: [PATCH v3 07/26] block: Use bio_sectors() more consistently

2012-09-24 Thread Jim Paris
ecas...@coraid.com CC: Nick Piggin npig...@kernel.dk CC: Jiri Kosina jkos...@suse.cz CC: Jim Paris j...@jtan.com CC: Geoff Levand ge...@infradead.org CC: Alasdair Kergon a...@redhat.com CC: dm-de...@redhat.com CC: Neil Brown ne...@suse.de CC: Steven Rostedt rost...@goodmis.org --- drivers

Re: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen

2007-10-25 Thread Jim Paris
Tejun Heo wrote: > [please don't drop cc. restored] > > Steen Eugen Poulsen wrote: > >Tejun Heo skrev: > >>All these are caused by smartd. Updating should fix the problem. > > > >Okay, but there is no newer smartd than what I'm using. (5.37) > > Bruce? Original thread can be read from... > >

Re: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen

2007-10-25 Thread Jim Paris
Tejun Heo wrote: [please don't drop cc. restored] Steen Eugen Poulsen wrote: Tejun Heo skrev: All these are caused by smartd. Updating should fix the problem. Okay, but there is no newer smartd than what I'm using. (5.37) Bruce? Original thread can be read from...

Re: NMI error and Intel S5000PSL Motherboards

2007-09-26 Thread Jim Paris
Hello, > We have about 100 servers based on Intel S5000PSL-SATA motherboards. > They have been running for anywhere between 1 and 10 months. For the > past few months, after updating them all to the 2.6.20.15 kernel > (because of a bug in the 2.6.18 kernel), we are seeing some strange NMI >

Re: NMI error and Intel S5000PSL Motherboards

2007-09-26 Thread Jim Paris
Hello, We have about 100 servers based on Intel S5000PSL-SATA motherboards. They have been running for anywhere between 1 and 10 months. For the past few months, after updating them all to the 2.6.20.15 kernel (because of a bug in the 2.6.18 kernel), we are seeing some strange NMI

Re: sata_nv + ADMA + Samsung disk problem

2007-08-16 Thread Jim Paris
Gabor Gombas wrote: > On Tue, Aug 14, 2007 at 06:30:28PM +0900, Tejun Heo wrote: > > Hmmm... That's timeout on cache flush, indicative of failing disk. > > Please post the result of 'smartctl -a /dev/sdc'. > > Ok, so something is fishy in 2.6.22 wrt. SMART. See http://lkml.org/lkml/2007/7/8/198

Re: sata_nv + ADMA + Samsung disk problem

2007-08-16 Thread Jim Paris
Gabor Gombas wrote: On Tue, Aug 14, 2007 at 06:30:28PM +0900, Tejun Heo wrote: Hmmm... That's timeout on cache flush, indicative of failing disk. Please post the result of 'smartctl -a /dev/sdc'. Ok, so something is fishy in 2.6.22 wrt. SMART. See http://lkml.org/lkml/2007/7/8/198 -jim -

Re: [2.6.22-rc6] NForce4 soft and hard resetting ports and exceptions

2007-06-26 Thread Jim Paris
Frederik Himpe wrote: > On Tue, 26 Jun 2007 17:45:22 +, Frederik Himpe wrote: > > > I tried Linux 2.6.22-rc6 on my machine with an Asus A8N-SlI Deluxe > > motherboard (NForce 4 chipset). > > > > When booting, the system hangs for a long time, but it continues after a > > long wait. I found

Re: [2.6.22-rc6] NForce4 soft and hard resetting ports and exceptions

2007-06-26 Thread Jim Paris
Frederik Himpe wrote: On Tue, 26 Jun 2007 17:45:22 +, Frederik Himpe wrote: I tried Linux 2.6.22-rc6 on my machine with an Asus A8N-SlI Deluxe motherboard (NForce 4 chipset). When booting, the system hangs for a long time, but it continues after a long wait. I found these kind of

Re: [2.6.21.1] SATA freeze

2007-05-13 Thread Jim Paris
> > This appears to be a different problem. Something is issuing SMART-related > > commands (smartd or smartctl perhaps) which the drive seems to be reacting > > strangely to. .. > Specifically, I could trigger it by running 'smartctl -d ata -S on > /dev/sda' OR (s-S/o/). This sounds like a

Re: [2.6.21.1] SATA freeze

2007-05-13 Thread Jim Paris
This appears to be a different problem. Something is issuing SMART-related commands (smartd or smartctl perhaps) which the drive seems to be reacting strangely to. .. Specifically, I could trigger it by running 'smartctl -d ata -S on /dev/sda' OR (s-S/o/). This sounds like a known

Re: Silent corruption on AMD64

2007-03-31 Thread Jim Paris
Aaron Lehmann wrote: > I discovered a reproducible way of causing silent file corruption. ... > 1. Heavy Ethernet load (nc remotehost < /dev/zero) > 2. Heavy disk write load on any non-sata_sil drive (cat /dev/zero > /path) > 3. Heavy disk read load on any other drive (tar c /path | cat >

Re: Silent corruption on AMD64

2007-03-31 Thread Jim Paris
Aaron Lehmann wrote: I discovered a reproducible way of causing silent file corruption. ... 1. Heavy Ethernet load (nc remotehost /dev/zero) 2. Heavy disk write load on any non-sata_sil drive (cat /dev/zero /path) 3. Heavy disk read load on any other drive (tar c /path | cat /dev/null)

Digiboard EPCA driver for 2.4

2001-03-11 Thread Jim Paris
drv/epca.c Sun Mar 11 14:57:16 2001 @@ -461,6 +461,9 @@ were using it wrong in a few instances, and it was causing problems in newer redhat versions. -- Changed version number to 1.4.5-1 +March 11, 2001: [EMAIL PROTECTED] + -- Support for 2.4 and devfs adde

Digiboard EPCA driver for 2.4

2001-03-11 Thread Jim Paris
epca-1.4.5-1/drv/epca.c Wed Jun 28 16:01:43 2000 +++ epca-1.4.5.1-jim/drv/epca.c Sun Mar 11 14:57:16 2001 @@ -461,6 +461,9 @@ were using it wrong in a few instances, and it was causing problems in newer redhat versions.