Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal

2020-05-15 Thread Jiri Kosina
ly it on top. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal

2020-05-14 Thread Jiri Kosina
files to the list: > > arch/s390/include/asm/livepatch.h > arch/powerpc/include/asm/livepatch.h Good point, thanks for spotting it Kamalesh. I've queued the patch below on top. From: Jiri Kosina Subject: [PATCH] livepatch: add arch-specific headers to MAINTAINERS Add arch-specific l

Re: [PATCH -next v2] livepatch: Make klp_apply_object_relocs static

2020-05-10 Thread Jiri Kosina
; > Fixes: 7c8e2bdd5f0d ("livepatch: Apply vmlinux-specific KLP relocations > early") > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou Merged in for-5.8/klp-module-fixups branch now. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal

2020-05-10 Thread Jiri Kosina
: > > warning: no file matches F: arch/x86/kernel/livepatch.c > > So, drop that obsolete file entry in MAINTAINERS. > > Signed-off-by: Lukas Bulwahn I've added Fixes: 1d05334d2899 ("livepatch: Remove .klp.arch") and applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH v4 00/11] livepatch,module: Remove .klp.arch and module_disable_ro()

2020-05-07 Thread Jiri Kosina
This has been tested with kpatch-build integration tests and klp-convert > selftests. I have now queued this whole set (with all the gathered Acks) in livepatching.git#for-5.8/klp-module-fixups -- Jiri Kosina SUSE Labs

Re: linux-next: Tree for May 7 (hid/hid-asus)

2020-05-07 Thread Jiri Kosina
_probe': > hid-asus.c:(.text+0x60f): undefined reference to `usb_hid_driver' > ld: hid-asus.c:(.text+0x689): undefined reference to `usb_hid_driver' This has been fixed in hid.git earlier today. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4 05/11] s390: Change s390_kernel_write() return type to match memcpy()

2020-05-07 Thread Jiri Kosina
dst += copied; > + copied = s390_kernel_write_odd(tmp, src, size); > + tmp += copied; > src += copied; > size -= copied; > } > spin_unlock_irqrestore(_kernel_write_lock, flags); > + > + return dst; > } > > static int __no_sanitize_address __memcpy_real(void *dest, void *src, size_t > count) > -- > 2.21.1 > -- Jiri Kosina SUSE Labs

Re: [PATCH v4 06/11] s390/module: Use s390_kernel_write() for late relocations

2020-05-07 Thread Jiri Kosina
> Cc: Christian Borntraeger > Suggested-by: Josh Poimboeuf > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Josh Poimboeuf > Acked-by: Peter Zijlstra (Intel) > Acked-by: Joe Lawrence > Acked-by: Miroslav Benes Could we please get an Ack / Reviewed-by: for this patch from s390 folks? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: i2c-hid: add Schneider SCL142ALM to descriptor override

2020-05-05 Thread Jiri Kosina
On Tue, 5 May 2020, Julian Sax wrote: > This device uses the SIPODEV SP1064 touchpad, which does not > supply descriptors, so it has to be added to the override list. Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] hid: intel-ish-hid: avoid bogus uninitialized-variable warning

2020-05-05 Thread Jiri Kosina
g an error from > ish_query_loader_prop(). > > Fixes: 91b228107da3 ("HID: intel-ish-hid: ISH firmware loader client driver") > Signed-off-by: Arnd Bergmann Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH v4 00/11] livepatch,module: Remove .klp.arch and module_disable_ro()

2020-05-04 Thread Jiri Kosina
gt; This has been tested with kpatch-build integration tests and klp-convert > selftests. So I think this should best go through livepatching.git for 5.8. Unless anyone has a better idea or objects heavily, I'll queue it tomorrow. Thanks, -- Jiri Kosina SUSE Labs

[GIT PULL] HID subsystem fixes

2020-05-04 Thread Jiri Kosina
): HID: wacom: Read HID_DG_CONTACTMAX directly for non-generic devices Revert "HID: wacom: generic: read the number of expected touches on a per collection basis" HID: wacom: Report 2nd-gen Intuos Pro S center button status over BT Jiri Kosina (1): HID: alps: ALPS_1

Re: [PATCH] HID: mcp2221: add gpiolib dependency

2020-04-29 Thread Jiri Kosina
hid/hid-mcp2221.o: in function `mcp_gpio_get': > hid-mcp2221.c:(.text+0x30c): undefined reference to `gpiochip_get_data' > > Fixes: 328de1c519c5 ("HID: mcp2221: add GPIO functionality support") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd. -- Jiri Kosina SUSE Labs

Re: [PATCH v8 0/5] arm64: ftrace with regs

2019-10-16 Thread Jiri Kosina
re, that would be great. When I last looked, it was simple to rework > things so that arch code doesn't have to define MCOUNT_ADDR, but I > hadn't figured out exactly how to split the core mcount assumptions from > the important state machine bits. > > I'll take another look and see if I can provide more detail. :) Hi Mark, has any progress been made on any front? Feels like this got stuck a bit. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] hid: intel-ish-hid: fix wrong error handling in ishtp_cl_alloc_tx_ring()

2019-10-16 Thread Jiri Kosina
id/ishtp/client-buffers.c > @@ -84,7 +84,7 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl) > return 0; > out: > dev_err(>device->dev, "error in allocating Tx pool\n"); > - ishtp_cl_free_rx_ring(cl); > + ishtp_cl_free_tx_ring(cl); Applied to for-5.4/upstream-fixes, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH 2/2] HID: google: Detect base folded usage instead of hard-coding whiskers

2019-10-10 Thread Jiri Kosina
On Thu, 3 Oct 2019, Nicolas Boichat wrote: > Some other hammer-like device will emit a similar code, let's look for > the folded event in HID usage table, instead of hard-coding whiskers > in many places. Applied to for-5.5/whiskers. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 1/2] HID: google: add magnemite/masterball USB ids

2019-10-10 Thread Jiri Kosina
On Thu, 3 Oct 2019, Nicolas Boichat wrote: > Add 2 additional hammer-like devices. Applied to for-5.4/upstream-fixes. -- Jiri Kosina SUSE Labs

Re: IOMMU vs Ryzen embedded EMMC controller

2019-10-09 Thread Jiri Kosina
hanks for looking into this! > > > > I have added Suravee from AMD in the mail loop. He works on IOMMU part. > As per my understanding, it needs a patch in IOMMU driver for adding > support of EMMC. Note that on Ryzen platform we have EMMC 5.0 as ACPI > device. Friendly ping ... any news here? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-09 Thread Jiri Kosina
would ask for putting it somewhere into hid.h as static inline. And even if it's for some reason insisted on this staying macro, please at least put it as close to the place(s) it's being used as possible, in order to maintain some code sanity. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] panic: Ensure preemption is disabled during panic()

2019-10-07 Thread Jiri Kosina
e (e.g. by issuing led_set_software_blink() during panic). But I am afraid this still won't solve the issue completely, as USB keyboards need workqueues for blinking the LEDs in for URB management. -- Jiri Kosina SUSE Labs

Re: [PATCH 5.4-rc1 BUILD FIX] s390: mark __cpacf_query() as __always_inline

2019-10-01 Thread Jiri Kosina
On Tue, 1 Oct 2019, Jiri Kosina wrote: > arch/s390/kvm/kvm-s390.c calls on several places __cpacf_query() directly, > which makes it impossible to meet the "i" constraint for the asm operands > (opcode in this case). > > As we are now force-enabling CONFIG

[PATCH 5.4-rc1 BUILD FIX] s390: mark __cpacf_query() as __always_inline

2019-10-01 Thread Jiri Kosina
cf_check_opcode() and cpacf_query_func() as __always_inline") Fixes: e60fb8bf68d4 ("s390/cpacf: mark scpacf_query() as __always_inline") Fixes: ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING forcibly") Fixes: 9012d011660e ("compiler: allow all arches to enable C

Re: [PATCH v3] HID: hidraw: replace printk() with corresponding pr_xx() variant

2019-10-01 Thread Jiri Kosina
On Fri, 20 Sep 2019, Rishi Gupta wrote: > This commit replaces direct invocations of printk with > their appropriate pr_info/warn() variant. > > Signed-off-by: Rishi Gupta > --- > Changes in v3: > * Use hid_warn() subsystem specific variant instead of pr_warn() Appli

Re: [PATCH] HID: prodikeys: make array keys static const, makes object smaller

2019-10-01 Thread Jiri Kosina
KEY_FN, > KEY_MESSENGER, KEY_CALENDAR, > KEY_ADDRESSBOOK, KEY_DOCUMENTS, > @@ -532,7 +532,7 @@ static void pcmidi_setup_extra_keys( > 0 > }; > > - unsigned int *pkeys = [0]; > + const unsigned int *pkeys = [0]; > unsigned short i; Applied, thanks for the fix. -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: fix error message in hid_open_report()

2019-10-01 Thread Jiri Kosina
: Michał Mirosław > > --- > v2: fixed printf() warning spotted by Jiri Kosina Applied, thank you. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: add support for 0079:1846 Mayflash/Dragonrise USB Gamecube Adapter

2019-10-01 Thread Jiri Kosina
he fix; however your mail client seems to have damaged it badly with respect to whitespace and line-wrapping. Could you please fix that up and resend? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 1/3] HID: google: whiskers: more robust tablet mode detection

2019-10-01 Thread Jiri Kosina
On Mon, 23 Sep 2019, Jiri Kosina wrote: > > > > The USB interface may get detected before the platform/EC one, so let's > > > > note the state of the base (if we receive event) and use it to correctly > > > > initialize the tablet mode switch state. >

RE: [PATCH] HID: hyperv: Add the support of hibernation

2019-09-26 Thread Jiri Kosina
On Thu, 26 Sep 2019, Jiri Kosina wrote: > > > We need mousevsc_pm_notify() to make sure the pm_wakeup_hard_event() > > > call does not prevent the system from entering hibernation: the > > > hibernation is a relatively long process, which can be aborted by the >

RE: [PATCH] HID: hyperv: Add the support of hibernation

2019-09-26 Thread Jiri Kosina
gt; > Hi Jiri, Benjamin, can you please Ack? > > Hi Jiri, Benjamin, > Can you please take a look at the patch? Hi Dexuan, I am planning to process it once 5.4 merge window is over and thus hid.git is open again for 5.5 material. Thanks, -- Jiri Kosina SUSE Labs

Re: IOMMU vs Ryzen embedded EMMC controller

2019-09-25 Thread Jiri Kosina
cro Devices, Inc. [AMD] > Raven/Raven2/Renoir Non-Sensor Fusion Hub KMDF driver > 06:00.0 SATA controller: Advanced Micro Devices, Inc. [AMD] FCH SATA > Controller [AHCI mode] (rev 61) > > Looks like we'd need some quirks to actually create a pci_device handle for > the embedded AMD eMMC controller? > Thoughts? > > PS: Please copy me on responses, I'm off LKML for half a decade now :-O > > -- > Kurt Garloff > Cologne, Germany > -- Jiri Kosina SUSE Labs

Re: [GIT PULL][SECURITY] Kernel lockdown patches for v5.4

2019-09-25 Thread Jiri Kosina
On Tue, 10 Sep 2019, James Morris wrote: > Hi Linus, > > This is the latest iteration of the kernel lockdown patchset, from Matthew > Garrett, David Howells and others. Seems like this didn't happen (yet) ... are there any plans to either drop it for good, or merge it? Thank

Re: [PATCH] HID: core: clean up indentation issue

2019-09-23 Thread Jiri Kosina
-EINVAL; > - } > + } Let's not pollute git blame and wait for an ocasion when we need to touch the code for some more valid reason. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 1/3] HID: google: whiskers: more robust tablet mode detection

2019-09-23 Thread Jiri Kosina
? > > You are right. I'll fix that up when I am applying it (once 5.4 merge window is over). Thanks, -- Jiri Kosina SUSE Labs

[GIT PULL] livepatching for 5.4

2019-09-22 Thread Jiri Kosina
. Miroslav Benes (1): livepatch: Nullify obj->mod in klp_module_coming()'s error path kernel/livepatch/core.c | 1 + 1 file changed, 1 insertion(+) -- Jiri Kosina SUSE Labs

[GIT PULL] HID for 5.4

2019-09-22 Thread Jiri Kosina
++- drivers/hid/wacom_wac.c | 76 - include/linux/hid.h | 43 ++--- 28 files changed, 561 insertions(+), 151 deletions(-) create mode 100644 drivers/hid/hid-creative-sb0540.c -- Jiri Kosina SUSE Labs

Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe

2019-09-20 Thread Jiri Kosina
On Wed, 11 Sep 2019, Jiri Kosina wrote: > > From: Jiri Kosina > > Subject: [PATCH] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe > > Hm, scratch that, that might actually spuriously enable BHs if called from > contexts that already did disabled BHs. > > So wha

Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe

2019-09-11 Thread Jiri Kosina
On Wed, 11 Sep 2019, Jiri Kosina wrote: > From: Jiri Kosina > Subject: [PATCH] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe Hm, scratch that, that might actually spuriously enable BHs if called from contexts that already did disabled BHs. So what solution would you prefer here

Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe

2019-09-11 Thread Jiri Kosina
really, if you look at how much code is covered by the lock) > and avoid doing it all the time when we know it to be not needed. So this now popped up on me with current Linus' tree from a different codepath, see below. Therefore I'd like to propose bringing my previous patch back to life.

Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message

2019-09-06 Thread Jiri Kosina
uetooth mode. > > As pointed out by Dan Carpenter, hid-microsoft directly relied on that > assumption as well. > > Fixes: 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return number of > queued bytes") > > Signed-off-by: Dan Elkouby Reviewed-by: Jiri Kos

Re: [RFC PATCH 2/2] livepatch: Clear relocation targets on a module removal

2019-09-05 Thread Jiri Kosina
ection via JMP_NOSPEC / CALL_NOSPEC, which has alternative in it. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: hid-prodikeys: Fix general protection fault during probe

2019-09-05 Thread Jiri Kosina
@syzkaller.appspotmail.com > Signed-off-by: Alan Stern > CC: Applied, thanks a lot Alan. -- Jiri Kosina SUSE Labs

Re: [RFC PATCH 2/2] livepatch: Clear relocation targets on a module removal

2019-09-05 Thread Jiri Kosina
m mostly in core code > that is always loaded. > > Alternatives are often used in assembly that we are not able > to livepatch anyway. > > Or are they spread widely via some macros or inlined functions? All the indirect jumps are turned into alternatives when retpolines are in place. -- Jiri Kosina SUSE Labs

RE: [PATCH] HID: hyperv: Use in-place iterator API in the channel callback

2019-09-04 Thread Jiri Kosina
OK if this patch for the Hyper-V HID driver goes through the Hyper-V > tree maintained by Sasha Levin? It's a purely Hyper-V change, and I have > been using the patch for several months and there is no regression. No problem with that. Feel free to add Acked-by: Jiri Kosina in th

Re: [PATCH] HID: modify quirks of i2c-hid driver for weida's devices

2019-09-04 Thread Jiri Kosina
make all of weida's devices can be > fixed on the power on issue. This modification should be safe since devices > without power on issue will send the power on command only once. Applied, thanks. -- Jiri Kosina SUSE Labs

RE: [PATCH v4 4/5] HID: hv: Remove dependencies on PAGE_SIZE for ring buffer

2019-09-02 Thread Jiri Kosina
ge size might be 16K or 64K. Yeah; FWIW feel free to add Acked-by: Jiri Kosina Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH RESEND] HID: fix error message in hid_open_report()

2019-08-20 Thread Jiri Kosina
signed int’ [-Wformat=] hid_err(device, "item fetching failed at offset %zu/%zu\n", ^ could you please fix that up and resubmit? Thanks, -- Jiri Kosina SUSE Labs

[GIT PULL] HID fixes

2019-08-20 Thread Jiri Kosina
insertions(+), 26 deletions(-) -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: cp2112: prevent sleeping function called from invalid context

2019-08-19 Thread Jiri Kosina
; > Move the call to cp2112_gpio_direction_input() earlier to have a working > driver. > > Signed-off-by: Benjamin Tissoires Pushed out to for-5.3/upstream-fixes. -- Jiri Kosina SUSE Labs

Re: [PATCH v2 0/3] HID: intel-ish-hid: support s2idle and s3 in ish_suspend()

2019-08-19 Thread Jiri Kosina
t; * Split the PATCH v1 to three changes, and try to minimize the lines change Applied to for-5.4/ish. Thanks, -- Jiri Kosina SUSE Labs

[GIT PULL] HID fixes

2019-08-06 Thread Jiri Kosina
mff.c | 12 drivers/hid/usbhid/hiddev.c | 12 drivers/hid/wacom_wac.c | 12 ++-- 10 files changed, 120 insertions(+), 19 deletions(-) -- Jiri Kosina SUSE Labs

Re: [PATCH resend 1/2] HID: hiddev: avoid opening a disconnected device

2019-08-06 Thread Jiri Kosina
Both patches applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH 1/2] HID: hiddev: avoid opening a disconnected device

2019-08-06 Thread Jiri Kosina
d-by: reference to syzbot? (in 2/2 as well). Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: input: fix a4tech horizontal wheel custom usage

2019-08-05 Thread Jiri Kosina
g for "Toggle Display" key") > > Signed-off-by: Nicolas Saenz Julienne > > --- > > It would be nice for this patch not to get lost. It fixes issues both repoted > on opensuse and fedora. Sorry for the delay. I've now queued the patch. Thanks for fixing this, -- Jiri Kosina SUSE Labs

Re: [PATCH 1/2] HID: Add Saitek X52 to the HID IDs

2019-08-05 Thread Jiri Kosina
dition. I've squashed the two patches into one, and applied to for-5.3/upstream-fixes. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices()

2019-08-05 Thread Jiri Kosina
ery_paired_devices error: 7 > > Please test my patch titled: "HID: logitech-dj: Really fix return value of > logi_dj_recv_query_hidpp_devices" > which should fix this. Hans, have I been CCed on that patch? I don't seem to see it in in inbox. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] hid-logitech-hidpp: add USB PID for some mice

2019-07-17 Thread Jiri Kosina
On Tue, 16 Jul 2019, Filipe Laíns wrote: > Signed-off-by: Filipe Laíns We generally don't accept empty changelogs for the kernel. I've added at least a few words, and comitted. This applies also to your second patch to logitech-dj. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] hid-logitech-dj: rename "gaming" receiver to "lightspeed"

2019-07-17 Thread Jiri Kosina
Applied, thans. -- Jiri Kosina SUSE Labs

Re: [GIT PULL] x86/topology changes for v5.3

2019-07-10 Thread Jiri Kosina
FALSE_RO(cr_pinning); > +DEFINE_STATIC_KEY_FALSE(cr_pinning); Good catch, I guess that is going to fix it. At the same time though, it sort of destroys the original intent of Kees' patch, right? The exploits will just have to call static_key_disable() prior to calling native_write_cr4() again, and the protection is gone. -- Jiri Kosina SUSE Labs

Re: [GIT PULL] x86/topology changes for v5.3

2019-07-10 Thread Jiri Kosina
On Wed, 10 Jul 2019, Jiri Kosina wrote: > On Wed, 10 Jul 2019, Peter Zijlstra wrote: > > > > > BUG: unable to handle page fault for address: 9edc1598 > > > > #PF: supervisor write access in kernel mode > > > > #PF: error_code(0x0003) - perm

Re: [GIT PULL] x86/topology changes for v5.3

2019-07-10 Thread Jiri Kosina
o the key. Such > that we can find all instances from a given key. > > I don't think anything here has changed in a while. Hm, and it seems to explode on dereferencing the static_key* in %rsi 21: 48 8b 37mov(%rdi),%rsi 24: 83 e6 03and$0x3,%esi 27: 48 09 c6or %rax,%rsi 2a:* 48 89 37mov%rsi,(%rdi) <-- trapping instruction which looks odd, as it derefenced it successfully just 3 instructions ago. -- Jiri Kosina SUSE Labs

Re: [GIT PULL] x86/topology changes for v5.3

2019-07-10 Thread Jiri Kosina
ce30a0 > R10: R11: 00028b56 R12: c06f8880 > R13: 9981ddce3080 R14: c06f4008 R15: c06f6dc0 > FS: 7f992dd9a680() GS:9981e708() knlGS: > CS: 0010 DS: ES: CR0: 80050033 > CR2: 9edc1598 CR3: 0002233aa001 CR4: 001606e0 > -- Jiri Kosina SUSE Labs

[GIT PULL] HID for 5.3

2019-07-09 Thread Jiri Kosina
cumentation/hid/intel-ish-hid.rst delete mode 100644 Documentation/hid/intel-ish-hid.txt rename Documentation/hid/{uhid.txt => uhid.rst} (94%) -- Jiri Kosina SUSE Labs

[GIT PULL] livepatching for 5.3

2019-07-09 Thread Jiri Kosina
acktrace.c | 8 3 files changed, 8 insertions(+), 14 deletions(-) -- Jiri Kosina SUSE Labs

[PATCH] ftrace/x86: anotate text_mutex split between ftrace_arch_code_modify_post_process() and ftrace_arch_code_modify_prepare()

2019-06-29 Thread Jiri Kosina
From: Jiri Kosina ftrace_arch_code_modify_prepare() is acquiring text_mutex, while the corresponding release is happening in ftrace_arch_code_modify_post_process(). This has already been documented in the code, but let's also make the fact that this is intentional clear to the semantic analysis

Re: [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code()

2019-06-29 Thread Jiri Kosina
> > > I'd actually prefer (perhaps in parallel to the comment) using the > > __acquires() and __releases() anotations, so that sparse and friends don't > > get confused by that either. > > > > Care to send a patch? :-) From: Jiri Kosina Subject: [PATCH] ft

Re: [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code()

2019-06-28 Thread Jiri Kosina
You are right of course. My brain has apparently already shut off for > the day. > > Maybe a comment or two would help though. I'd actually prefer (perhaps in parallel to the comment) using the __acquires() and __releases() anotations, so that sparse and friends don't get confused by that either. -- Jiri Kosina SUSE Labs

[GIT PULL] HID fixes

2019-06-27 Thread Jiri Kosina
/hid/intel-ish-hid/ishtp/bus.c| 15 ++- include/linux/intel-ish-client-if.h | 1 + 10 files changed, 33 insertions(+), 5 deletions(-) -- Jiri Kosina SUSE Labs

Re: [UPDATE][PATCH v4] HID: intel-ish-hid: fix wrong driver_data usage

2019-06-26 Thread Jiri Kosina
drier and instead of > using driver_data to get "struct ishtp_cl_device", since "struct device" > is embedded in "struct ishtp_cl_device", we introduce a helper function > that returns "struct ishtp_cl_device" from "struct device". >

Re: [PATCH] HID: multitouch: Add pointstick support for ALPS Touchpad

2019-06-26 Thread Jiri Kosina
On Fri, 14 Jun 2019, Kai-Heng Feng wrote: > There's a new ALPS touchpad/pointstick combo device that requires > MT_CLS_WIN_8_DUAL to make its pointsitck work as a mouse. > > The device can be found on HP ZBook 17 G5. > > Signed-off-by: Kai-Heng Feng Applied to for-5.2/fixes.

Re: [PATCH] HID: uclogic: Add support for Huion HS64 tablet

2019-06-26 Thread Jiri Kosina
On Sat, 15 Jun 2019, Kyle Godbey wrote: > Add support for Huion HS64 drawing tablet to hid-uclogic Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] hid: add another quirk for Chicony PixArt mouse

2019-06-26 Thread Jiri Kosina
ther models before, so lets add > this mouse too. > > Link: > https://github.com/sriemer/fix-linux-mouse#usb-mouse-disconnectsreconnects-every-minute-on-linux > Signed-off-by: Oleksandr Natalenko Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH V34 10/29] hibernate: Disable when the kernel is locked down

2019-06-24 Thread Jiri Kosina
t; kernel is locked down. > > I keep getting these... > > IIRC suse has patches to verify the images. Yeah, Joey Lee is taking care of those. CCing. -- Jiri Kosina SUSE Labs

[GIT PULL] HID fixes for 5.2-rc

2019-06-13 Thread Jiri Kosina
mi-quirks.c | 8 drivers/hid/wacom_wac.c | 71 ++-- 10 files changed, 136 insertions(+), 54 deletions(-) -- Jiri Kosina SUSE Labs

Re: [PATCH v5 2/3] HID: quirks: Refactor ELAN 400 and 401 handling

2019-06-12 Thread Jiri Kosina
put/elan-i2c-ids.h and consume from > hid-quirks.c? Let's just not duplicate it in both objects. Why not properly export it from hid_quirks? Thanks, -- Jiri Kosina SUSE Labs

Re: Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4)

2019-06-12 Thread Jiri Kosina
=for-5.2/fixes=f9482dabfd1686987cc6044e06ae0e4c05915518 > > Yes, with the two reverts applied in addition to the fix, it all works as > expected. Rafael, thanks a lot for testing. I am sending the pile to Linus today or tomorrow latest. -- Jiri Kosina SUSE Labs

Re: Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4)

2019-06-12 Thread Jiri Kosina
it.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.2/fixes=e0b7f9bc0246bc642d1de2ff3ff133730584c956 [2] https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.2/fixes=f9482dabfd1686987cc6044e06ae0e4c05915518 -- Jiri Kosina SUSE Labs

Re: Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4)

2019-06-11 Thread Jiri Kosina
t'd be helpful. Thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.2/fixes=3ed224e273ac5880eeab4c3043a6b06b0478dd56 -- Jiri Kosina SUSE Labs

Re: [PATCH 0/4] few reverts and fixes for 5.2

2019-06-05 Thread Jiri Kosina
port size allowed by > hid_field_extract()" > Revert "HID: core: Do not call request_module() in async context" > Revert "HID: core: Call request_module before doing device_add" > > Hans de Goede (1): > HID: logitech-dj: Fix 064d:c52f receiver support For the set: Acked-by: Jiri Kosina Thanks, -- Jiri Kosina SUSE Labs

Re: hid-related 5.2-rc1 boot hang

2019-06-04 Thread Jiri Kosina
hopefully with the C52F. If the > receiver is correct and the tests are successful, I'd prefer to take > this one over the revert :) Agreed at this release phase. And if it doesn't work, immediate revert for now and proper fix for 5.3-rc1. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-06-03 Thread Jiri Kosina
tation and we've just overlooked it, or whether it's rather an information that's being carried over from generation to generation by whispering through grapevine? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v3] HID: fix A4Tech horizontal scrolling

2019-05-31 Thread Jiri Kosina
9e2357e ("HID: input: use the > Resolution Multiplier for high-resolution scrolling") > > Signed-off-by: Błażej Szczygieł Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] drivers: hid: Add a module description line to the hid_hyperv driver

2019-05-31 Thread Jiri Kosina
d/hid-hyperv.c > @@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void) > } > > MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver"); > + Is there a reason why you didn't CC Joseph on this submission? CCing Joseph and applying. Thanks, -- Jiri Kosina SUSE Labs

Re: hid-related 5.2-rc1 boot hang

2019-05-31 Thread Jiri Kosina
should start reverting (at least the request_module() changes, not sure about the rest of logitech issues yet) next week. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
roperly via INIT INIT START). I'd still like to do that for 5.3 though, as that'd be slightly bigger surgery, and conservatively put things basically back to state they have been up to now for 5.2. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
same set of events, but has the auto-restarting semantics on some of them (especially SMM). So the wakeup frequency itself shouldn't really contribute to power consumption difference; it's the C-state that mwait allows CPU to enter. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
ntered if SMM interrupted it, while MWAIT is not. So as a short-term fix for 5.2, I still believe in v4 of my patch that does the mwait->hlt->mwait transition across hibernate/resume, and for 5.3 I can look into forcing it to wait-for-SIPI proper. -- Jiri Kosina SUSE Labs

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
oot.c > index 73e69117..9804fbe25d03 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -108,6 +108,8 @@ int __read_mostly __max_smt_threads = 1; > /* Flag to indicate if a complete sched domain rebuild is required */ > bool x86_topology_update; >

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
On Fri, 31 May 2019, Jiri Kosina wrote: > On Fri, 31 May 2019, Andy Lutomirski wrote: > > > 2. Put the CPU all the way to sleep by sending it an INIT IPI. > > > > Version 2 seems very simple and robust. Is there a reason we can't do > > it? We obviously don't wa

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
91230130.1...@cbobk.fhfr.pm/ Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
er be FIXADDR_TOP - VSYSCALL_ADDR + 1 instead? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-31 Thread Jiri Kosina
e drivers might be potentially doing in their ->enter_dead() callbacks. Rafael? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-30 Thread Jiri Kosina
ow. I disagree with that from the backwards compatibility point of view. I personally am quite frequently using differnet combinations of resumer/resumee kernels, and I've never been biten by it so far. I'd guess I am not the only one. Fixmap sort of breaks that invariant. Thanks, -- Jiri Kosina SUSE Labs

[PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
From: Jiri Kosina As explained in 0cc3cd21657b ("cpu/hotplug: Boot HT siblings at least once") we always, no matter what, have to bring up x86 HT siblings during boot at least once in order to avoid first MCE bringing the system to its knees. That means that whene

Re: [PATCH v3] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
to avoid first MCE bringing the system to its > > knees. > > > > Cc: sta...@vger.kernel.org # v4.19+ > > Debugged-by: Thomas Gleixner > > Fixes: 0cc3cd21657b ("cpu/hotplug: Boot HT siblings at least once") > > Signed-off-by: Jiri Kosina &

[PATCH v3] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
From: Jiri Kosina As explained in 0cc3cd21657b ("cpu/hotplug: Boot HT siblings at least once") we always, no matter what, have to bring up x86 HT siblings during boot at least once in order to avoid first MCE bringing the system to its knees. That means that whene

Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
On Wed, 29 May 2019, Jiri Kosina wrote: > The target kernel only onlines the CPUs which were online at the time of > hibernation (and are therefore in frozen_cpus mask). Hm, there is a catch though. After resume, the SMT siblings are now in hlt instead of mwait. Which means that the r

Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
see how SMT would get disabled again. The target kernel only onlines the CPUs which were online at the time of hibernation (and are therefore in frozen_cpus mask). -- Jiri Kosina SUSE Labs

Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
adcasted to that core at all in the first place. But this needs to be confirmed by Intel. -- Jiri Kosina SUSE Labs

Re: Oops caused by race between livepatch and ftrace

2019-05-29 Thread Jiri Kosina
ed). It wasn't until we introduced > text_poke that we decided to create the text_mutex locking as well. > > > > > > > From: Josh Poimboeuf > > Subject: [PATCH] livepatch: Fix ftrace module text permissions race > > Thanks, > > I'll try to find some time to test this as well. Steve, Jessica, any final word on this? Thanks, -- Jiri Kosina SUSE Labs

[PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
From: Jiri Kosina As explained in 0cc3cd21657b ("cpu/hotplug: Boot HT siblings at least once") we always, no matter what, have to bring up x86 HT siblings during boot at least once in order to avoid first MCE bringing the system to its knees. That means that whene

<    1   2   3   4   5   6   7   8   9   10   >