Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes

2017-03-20 Thread Jiri Pirko
wrong order") > >Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower >offload statistics") >Signed-off-by: Colin Ian King Acked-by: Jiri Pirko

Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Jiri Pirko
Wed, Mar 08, 2017 at 01:03:42PM CET, ji...@kernel.org wrote: >From: Jiri Kosina > >The original reason [1] for having hidden qdiscs (potential scalability >issues in qdisc_match_from_root() with single linked list in case of large >amount of qdiscs) has been invalidated by

Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Jiri Pirko
Wed, Mar 08, 2017 at 01:03:42PM CET, ji...@kernel.org wrote: >From: Jiri Kosina > >The original reason [1] for having hidden qdiscs (potential scalability >issues in qdisc_match_from_root() with single linked list in case of large >amount of qdiscs) has been invalidated by 59cc1f61f0 ("net:

Re: [PATCH net] team: use ETH_MAX_MTU as max mtu

2017-03-06 Thread Jiri Pirko
: Cong Wang <xiyou.wangc...@gmail.com> >CC: Jiri Pirko <j...@resnulli.us> >CC: net...@vger.kernel.org >Signed-off-by: Jarod Wilson <ja...@redhat.com> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH net] team: use ETH_MAX_MTU as max mtu

2017-03-06 Thread Jiri Pirko
ing hardware can handle something much larger. Just set it to >ETH_MAX_MTU to support all possible values, and the limitations of the >underlying devices will prevent setting anything too large. > >Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") &g

Re: [PATCH] lib: fix spelling mistake: "actualy" -> "actually"

2017-02-26 Thread Jiri Pirko
Sun, Feb 26, 2017 at 01:10:12PM CET, colin.k...@canonical.com wrote: >From: Colin Ian King <colin.k...@canonical.com> > >trivial fix to spelling mistake in pr_err message > >Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Jiri Pirko <j

Re: [PATCH] lib: fix spelling mistake: "actualy" -> "actually"

2017-02-26 Thread Jiri Pirko
Sun, Feb 26, 2017 at 01:10:12PM CET, colin.k...@canonical.com wrote: >From: Colin Ian King > >trivial fix to spelling mistake in pr_err message > >Signed-off-by: Colin Ian King Acked-by: Jiri Pirko >--- > lib/test_parman.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: lib: Introduce priority array area manager

2017-02-23 Thread Jiri Pirko
Thu, Feb 23, 2017 at 10:22:22AM CET, ge...@linux-m68k.org wrote: >Hi Jiri, > >On Thu, Feb 23, 2017 at 9:32 AM, Jiri Pirko <j...@resnulli.us> wrote: >> Thu, Feb 23, 2017 at 08:56:26AM CET, ge...@linux-m68k.org wrote: >>>On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel

Re: lib: Introduce priority array area manager

2017-02-23 Thread Jiri Pirko
Thu, Feb 23, 2017 at 10:22:22AM CET, ge...@linux-m68k.org wrote: >Hi Jiri, > >On Thu, Feb 23, 2017 at 9:32 AM, Jiri Pirko wrote: >> Thu, Feb 23, 2017 at 08:56:26AM CET, ge...@linux-m68k.org wrote: >>>On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing

Re: lib: Introduce priority array area manager

2017-02-23 Thread Jiri Pirko
47ef17e1e70db3d51190 >> Commit: 44091d29f2075972aede47ef17e1e70db3d51190 >> Parent: b862815c3ee7b49ec20a9ab25da55a5f0bcbb95e >> Refname:refs/heads/master >> Author: Jiri Pirko <j...@mellanox.com> >> AuthorDate: Fri Feb 3 10:29:06 2017 +0100 >> Committer: Davi

Re: lib: Introduce priority array area manager

2017-02-23 Thread Jiri Pirko
075972aede47ef17e1e70db3d51190 >> Parent: b862815c3ee7b49ec20a9ab25da55a5f0bcbb95e >> Refname:refs/heads/master >> Author: Jiri Pirko >> AuthorDate: Fri Feb 3 10:29:06 2017 +0100 >> Committer: David S. Miller >> CommitDate: Fri Feb 3 16:35:

Re: sched: check negative err value to safe one level of indent

2017-02-14 Thread Jiri Pirko
Tue, Feb 14, 2017 at 04:10:13PM CET, colin.k...@canonical.com wrote: >Jiro, > >A recent static analysis run with CoverityScan identified a potential >change in functionality with your recent commit "sched: check negative >err value to safe one level of indent" that landed in linux-next. > >The

Re: sched: check negative err value to safe one level of indent

2017-02-14 Thread Jiri Pirko
Tue, Feb 14, 2017 at 04:10:13PM CET, colin.k...@canonical.com wrote: >Jiro, > >A recent static analysis run with CoverityScan identified a potential >change in functionality with your recent commit "sched: check negative >err value to safe one level of indent" that landed in linux-next. > >The

Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-07 Thread Jiri Pirko
his adds a Kconfig dependency to enforce usable configurations. > >Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support") >Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

2017-02-07 Thread Jiri Pirko
his adds a Kconfig dependency to enforce usable configurations. > >Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support") >Signed-off-by: Arnd Bergmann Acked-by: Jiri Pirko

Re: [PATCH net-next] net/sched: cls_flower: reduce fl_change stack size

2017-01-19 Thread Jiri Pirko
ARM, while this version just does it for the 'tb' >array, bringing the stack size back down to 664 bytes. > >Fixes: 99d31326cbe6 ("net/sched: cls_flower: Support matching on ARP") >Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH net-next] net/sched: cls_flower: reduce fl_change stack size

2017-01-19 Thread Jiri Pirko
ARM, while this version just does it for the 'tb' >array, bringing the stack size back down to 664 bytes. > >Fixes: 99d31326cbe6 ("net/sched: cls_flower: Support matching on ARP") >Signed-off-by: Arnd Bergmann Acked-by: Jiri Pirko

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-10 Thread Jiri Pirko
Tue, Jan 10, 2017 at 06:58:18PM CET, f.faine...@gmail.com wrote: >On 01/10/2017 01:55 AM, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 07:06:39PM CET, f.faine...@gmail.com wrote: >>> On 01/09/2017 09:58 AM, Jiri Pirko wrote: >>>> Mon, Jan 09, 2017 at 06:42:07PM C

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-10 Thread Jiri Pirko
Tue, Jan 10, 2017 at 06:58:18PM CET, f.faine...@gmail.com wrote: >On 01/10/2017 01:55 AM, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 07:06:39PM CET, f.faine...@gmail.com wrote: >>> On 01/09/2017 09:58 AM, Jiri Pirko wrote: >>>> Mon, Jan 09, 2017 at 06:42:07PM C

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-10 Thread Jiri Pirko
Mon, Jan 09, 2017 at 07:06:39PM CET, f.faine...@gmail.com wrote: >On 01/09/2017 09:58 AM, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 06:42:07PM CET, f.faine...@gmail.com wrote: >>> On 01/09/2017 08:06 AM, Jiri Pirko wrote: >>>> Mon, Jan 09, 2017

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-10 Thread Jiri Pirko
Mon, Jan 09, 2017 at 07:06:39PM CET, f.faine...@gmail.com wrote: >On 01/09/2017 09:58 AM, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 06:42:07PM CET, f.faine...@gmail.com wrote: >>> On 01/09/2017 08:06 AM, Jiri Pirko wrote: >>>> Mon, Jan 09, 2017

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-09 Thread Jiri Pirko
Mon, Jan 09, 2017 at 06:42:07PM CET, f.faine...@gmail.com wrote: >On 01/09/2017 08:06 AM, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 04:45:33PM CET, vivien.dide...@savoirfairelinux.com >> wrote: >>> Hi Jiri, >>> >>> Jiri Pirko <j...@resnulli.us

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-09 Thread Jiri Pirko
Mon, Jan 09, 2017 at 06:42:07PM CET, f.faine...@gmail.com wrote: >On 01/09/2017 08:06 AM, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 04:45:33PM CET, vivien.dide...@savoirfairelinux.com >> wrote: >>> Hi Jiri, >>> >>> Jiri Pirko writes: >>>

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-09 Thread Jiri Pirko
Mon, Jan 09, 2017 at 04:45:33PM CET, vivien.dide...@savoirfairelinux.com wrote: >Hi Jiri, > >Jiri Pirko <j...@resnulli.us> writes: > >>>Extra question: shouldn't phys_port_{id,name} be switchdev attributes in >> >> Again, phys_port_id has nothing to do with

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-09 Thread Jiri Pirko
Mon, Jan 09, 2017 at 04:45:33PM CET, vivien.dide...@savoirfairelinux.com wrote: >Hi Jiri, > >Jiri Pirko writes: > >>>Extra question: shouldn't phys_port_{id,name} be switchdev attributes in >> >> Again, phys_port_id has nothing to do with switches. Should be re

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-09 Thread Jiri Pirko
Mon, Jan 09, 2017 at 05:00:19PM CET, and...@lunn.ch wrote: >> > No. That should be unique within one switch. In mlxsw we name it "p1", >> > "p2", ... >> > >> > The final netdev names are: >> > enp3s0np1, enp3s0np2, ... >> > >mlxsw are pci devices, so it follows this convention, i think: > > *

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-09 Thread Jiri Pirko
Mon, Jan 09, 2017 at 05:00:19PM CET, and...@lunn.ch wrote: >> > No. That should be unique within one switch. In mlxsw we name it "p1", >> > "p2", ... >> > >> > The final netdev names are: >> > enp3s0np1, enp3s0np2, ... >> > >mlxsw are pci devices, so it follows this convention, i think: > > *

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-09 Thread Jiri Pirko
Mon, Jan 09, 2017 at 04:04:50PM CET, vivien.dide...@savoirfairelinux.com wrote: >Hi Jiri, > >Jiri Pirko <j...@resnulli.us> writes: > >>># cat /etc/udev/rules.d/90-net-dsa.rules >>>SUBSYSTEM=="net", ACTION=="add", ENV{DEVTYPE}=="

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-09 Thread Jiri Pirko
Mon, Jan 09, 2017 at 04:04:50PM CET, vivien.dide...@savoirfairelinux.com wrote: >Hi Jiri, > >Jiri Pirko writes: > >>># cat /etc/udev/rules.d/90-net-dsa.rules >>>SUBSYSTEM=="net", ACTION=="add", ENV{DEVTYPE}=="dsa", &

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-08 Thread Jiri Pirko
Mon, Jan 09, 2017 at 12:15:52AM CET, vivien.dide...@savoirfairelinux.com wrote: >In the new DTS bindings for DSA (dsa2), the "ethernet" and "link" >phandles are respectively mandatory and exclusive to CPU port and DSA >link device tree nodes. > >Simplify dsa2.c a bit by checking the presence of

Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2

2017-01-08 Thread Jiri Pirko
Mon, Jan 09, 2017 at 12:15:52AM CET, vivien.dide...@savoirfairelinux.com wrote: >In the new DTS bindings for DSA (dsa2), the "ethernet" and "link" >phandles are respectively mandatory and exclusive to CPU port and DSA >link device tree nodes. > >Simplify dsa2.c a bit by checking the presence of

Re: [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust

2016-12-06 Thread Jiri Pirko
Tue, Dec 06, 2016 at 05:46:36AM CET, cxdx2...@gmail.com wrote: >From: Feng Deng > >1.add judgement to make sure switchdev_port_vlan_fill() could > return right, even when switchdev_port_vlan_dump_put() failed , > which will make switchdev_port_vlan_fill() more robust

Re: [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust

2016-12-06 Thread Jiri Pirko
Tue, Dec 06, 2016 at 05:46:36AM CET, cxdx2...@gmail.com wrote: >From: Feng Deng > >1.add judgement to make sure switchdev_port_vlan_fill() could > return right, even when switchdev_port_vlan_dump_put() failed , > which will make switchdev_port_vlan_fill() more robust >2.add proper return

Re: [PATCH] net:switchdev: fix to release the lock before function return to avoid deadlock

2016-12-06 Thread Jiri Pirko
Tue, Dec 06, 2016 at 11:09:24AM CET, feng.d...@cortina-access.com wrote: >before switchdev_deferred_dequeue() normal return,show release the lock, >if not,maybe there will be deadlock sometimes > >Signed-off-by: Feng Deng >--- > net/switchdev/switchdev.c | 1 + > 1

Re: [PATCH] net:switchdev: fix to release the lock before function return to avoid deadlock

2016-12-06 Thread Jiri Pirko
Tue, Dec 06, 2016 at 11:09:24AM CET, feng.d...@cortina-access.com wrote: >before switchdev_deferred_dequeue() normal return,show release the lock, >if not,maybe there will be deadlock sometimes > >Signed-off-by: Feng Deng >--- > net/switchdev/switchdev.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH]net:witchdev:release the lock before function return to avoid dead lock

2016-12-06 Thread Jiri Pirko
Tue, Dec 06, 2016 at 03:58:29AM CET, cxdx2...@gmail.com wrote: >From : Feng Deng > >In switchdev_deferred_dequeue(),only get the lock at the beginning, >but forgot to release before return, >we must release the lock to avoid dead lock Feng, your patches are corrupted. Please

Re: [PATCH]net:witchdev:release the lock before function return to avoid dead lock

2016-12-06 Thread Jiri Pirko
Tue, Dec 06, 2016 at 03:58:29AM CET, cxdx2...@gmail.com wrote: >From : Feng Deng > >In switchdev_deferred_dequeue(),only get the lock at the beginning, >but forgot to release before return, >we must release the lock to avoid dead lock Feng, your patches are corrupted. Please use "git

Re: linux-next: manual merge of the net-next tree with the net tree

2016-12-01 Thread Jiri Pirko
Thu, Dec 01, 2016 at 02:41:59AM CET, s...@canb.auug.org.au wrote: >Hi all, > >Today's linux-next merge of the net-next tree got a conflict in: > > net/sched/cls_flower.c > >between commit: > > 725cbb62e7ad ("sched: cls_flower: remove from hashtable only in case skip sw > flag is not set") >

Re: linux-next: manual merge of the net-next tree with the net tree

2016-12-01 Thread Jiri Pirko
Thu, Dec 01, 2016 at 02:41:59AM CET, s...@canb.auug.org.au wrote: >Hi all, > >Today's linux-next merge of the net-next tree got a conflict in: > > net/sched/cls_flower.c > >between commit: > > 725cbb62e7ad ("sched: cls_flower: remove from hashtable only in case skip sw > flag is not set") >

Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency

2016-11-21 Thread Jiri Pirko
this driver if MLXSW_PCI is disabled, >but it's probably not worth it. > >Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks. Reviewed-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH] mlxsw: switchib: add MLXSW_PCI dependency

2016-11-21 Thread Jiri Pirko
this driver if MLXSW_PCI is disabled, >but it's probably not worth it. > >Signed-off-by: Arnd Bergmann Thanks. Reviewed-by: Jiri Pirko

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

2016-11-16 Thread Jiri Pirko
Wed, Nov 16, 2016 at 01:08:57PM CET, green...@gmail.com wrote: >You are right. I didn't notice that. I should use ftmac100. Don't top-post please. > >On Wed, Nov 16, 2016 at 7:53 PM, Jiri Pirko <j...@resnulli.us> wrote: >> Wed, Nov 16, 2016 at 09:43:15AM CET, gre

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

2016-11-16 Thread Jiri Pirko
Wed, Nov 16, 2016 at 01:08:57PM CET, green...@gmail.com wrote: >You are right. I didn't notice that. I should use ftmac100. Don't top-post please. > >On Wed, Nov 16, 2016 at 7:53 PM, Jiri Pirko wrote: >> Wed, Nov 16, 2016 at 09:43:15AM CET, green...@gmail.com wrote: >>&g

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

2016-11-16 Thread Jiri Pirko
Wed, Nov 16, 2016 at 09:43:15AM CET, green...@gmail.com wrote: >To support device tree usage for ftmac100. > >Signed-off-by: Greentime Hu >--- > drivers/net/ethernet/faraday/ftmac100.c |7 +++ > 1 file changed, 7 insertions(+) > >diff --git

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

2016-11-16 Thread Jiri Pirko
Wed, Nov 16, 2016 at 09:43:15AM CET, green...@gmail.com wrote: >To support device tree usage for ftmac100. > >Signed-off-by: Greentime Hu >--- > drivers/net/ethernet/faraday/ftmac100.c |7 +++ > 1 file changed, 7 insertions(+) > >diff --git a/drivers/net/ethernet/faraday/ftmac100.c

Re: [PATCH v3 net] flow_dissector: fix vlan tag handling

2016-10-25 Thread Jiri Pirko
d uninitialized in >this function [-Werror=maybe-uninitialized] > >As pointed out by Jiri Pirko, the variable is never actually used >without being initialized first as the only way it end up uninitialized >is with skb_vlan_tag_present(skb)==true, and that means it does not >get accessed. >

Re: [PATCH v3 net] flow_dissector: fix vlan tag handling

2016-10-25 Thread Jiri Pirko
d uninitialized in >this function [-Werror=maybe-uninitialized] > >As pointed out by Jiri Pirko, the variable is never actually used >without being initialized first as the only way it end up uninitialized >is with skb_vlan_tag_present(skb)==true, and that means it does not >get accessed. >

Re: [PATCH net-next] flow_dissector: fix vlan tag handling

2016-10-24 Thread Jiri Pirko
d uninitialized in >this function [-Werror=maybe-uninitialized] > >As pointed out by Jiri Pirko, the variable is never actually used >without being initialized first as the only way it end up uninitialized >is with skb_vlan_tag_present(skb)==true, and that means it does not >get accessed. >

Re: [PATCH net-next] flow_dissector: fix vlan tag handling

2016-10-24 Thread Jiri Pirko
d uninitialized in >this function [-Werror=maybe-uninitialized] > >As pointed out by Jiri Pirko, the variable is never actually used >without being initialized first as the only way it end up uninitialized >is with skb_vlan_tag_present(skb)==true, and that means it does not >get accessed. >

Re: [patch v3] drivers/platform/x86: introduce support for Mellanox hotplug driver

2016-10-23 Thread Jiri Pirko
Sun, Oct 23, 2016 at 08:14:53AM CEST, vad...@mellanox.com wrote: > > >> -Original Message- >> From: Darren Hart [mailto:dvh...@infradead.org] >> Sent: Friday, October 21, 2016 9:42 PM >> To: Vadim Pasternak >> Cc: da...@davemloft.net; ge...@linux-m68k.org; akpm@linux-

Re: [patch v3] drivers/platform/x86: introduce support for Mellanox hotplug driver

2016-10-23 Thread Jiri Pirko
Sun, Oct 23, 2016 at 08:14:53AM CEST, vad...@mellanox.com wrote: > > >> -Original Message- >> From: Darren Hart [mailto:dvh...@infradead.org] >> Sent: Friday, October 21, 2016 9:42 PM >> To: Vadim Pasternak >> Cc: da...@davemloft.net; ge...@linux-m68k.org; akpm@linux- >> foundation.org;

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-22 Thread Jiri Pirko
Sat, Oct 22, 2016 at 03:48:48AM CEST, torva...@linux-foundation.org wrote: >On Fri, Oct 21, 2016 at 9:31 AM, Jiri Pirko <j...@resnulli.us> wrote: >> >> I don't see how vlan could be used uninitialized. But I understand that >> this is impossible for gcc t

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-22 Thread Jiri Pirko
Sat, Oct 22, 2016 at 03:48:48AM CEST, torva...@linux-foundation.org wrote: >On Fri, Oct 21, 2016 at 9:31 AM, Jiri Pirko wrote: >> >> I don't see how vlan could be used uninitialized. But I understand that >> this is impossible for gcc to track it. Please just use uninitiali

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-21 Thread Jiri Pirko
Fri, Oct 21, 2016 at 05:55:53PM CEST, a...@arndb.de wrote: >gcc warns about an uninitialized pointer dereference in the vlan >priority handling: > >net/core/flow_dissector.c: In function '__skb_flow_dissect': >net/core/flow_dissector.c:281:61: error: 'vlan' may be used uninitialized in >this

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-21 Thread Jiri Pirko
Fri, Oct 21, 2016 at 05:55:53PM CEST, a...@arndb.de wrote: >gcc warns about an uninitialized pointer dereference in the vlan >priority handling: > >net/core/flow_dissector.c: In function '__skb_flow_dissect': >net/core/flow_dissector.c:281:61: error: 'vlan' may be used uninitialized in >this

Re: [PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-23 Thread Jiri Pirko
check can be removed. > >Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-23 Thread Jiri Pirko
ned-off-by: Colin Ian King Acked-by: Jiri Pirko

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-09 Thread Jiri Pirko
Thu, Sep 08, 2016 at 06:32:02PM CEST, jasminder.k...@hpe.com wrote: >>The issue of interfaces being arbitrarily changed or deleted >> is not specific to bonding, and could affect any networking device (physical >> or virtual). Thus, if a facility such as this is to be provided,

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-09 Thread Jiri Pirko
Thu, Sep 08, 2016 at 06:32:02PM CEST, jasminder.k...@hpe.com wrote: >>The issue of interfaces being arbitrarily changed or deleted >> is not specific to bonding, and could affect any networking device (physical >> or virtual). Thus, if a facility such as this is to be provided,

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-08 Thread Jiri Pirko
Thu, Sep 08, 2016 at 05:05:05PM CEST, jasminder.k...@hpe.com wrote: >Hi Jay, Hi Jiri, > > > >Thank you for your inputs. > > > >Some of the requests we got for such preventive checks are from Admins working >on large scale up systems with multiple NICs, FlexNICs and IP addresses. > >§ One use

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-08 Thread Jiri Pirko
Thu, Sep 08, 2016 at 05:05:05PM CEST, jasminder.k...@hpe.com wrote: >Hi Jay, Hi Jiri, > > > >Thank you for your inputs. > > > >Some of the requests we got for such preventive checks are from Admins working >on large scale up systems with multiple NICs, FlexNICs and IP addresses. > >§ One use

Re: [patch] leds: add driver for Mellanox systems leds

2016-09-07 Thread Jiri Pirko
Wed, Sep 07, 2016 at 02:49:00PM CEST, j.anaszew...@samsung.com wrote: >Hi Vadim, > >On 09/07/2016 03:35 PM, vad...@mellanox.com wrote: >> From: Vadim Pasternak >> >> This makes it possible to create a set of LEDs for Mellanox systems: >> "msx6710", "msx6720", "msb7700",

Re: [patch] leds: add driver for Mellanox systems leds

2016-09-07 Thread Jiri Pirko
Wed, Sep 07, 2016 at 02:49:00PM CEST, j.anaszew...@samsung.com wrote: >Hi Vadim, > >On 09/07/2016 03:35 PM, vad...@mellanox.com wrote: >> From: Vadim Pasternak >> >> This makes it possible to create a set of LEDs for Mellanox systems: >> "msx6710", "msx6720", "msb7700", "msn2700", "msx1410",

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-06 Thread Jiri Pirko
Tue, Sep 06, 2016 at 11:34:30AM CEST, jasminder.k...@hpe.com wrote: >From: "Kaur, Jasminder" > >If a bond is in use such as with IP address configured, removing it >can result in application disruptions. If bond is used for cluster >communication or network file system

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-06 Thread Jiri Pirko
Tue, Sep 06, 2016 at 11:34:30AM CEST, jasminder.k...@hpe.com wrote: >From: "Kaur, Jasminder" > >If a bond is in use such as with IP address configured, removing it >can result in application disruptions. If bond is used for cluster >communication or network file system interfaces, removing it can

Re: [PATCH 3/3] perf tests: Add is_printable_array test

2016-07-18 Thread Jiri Pirko
Sat, Jul 16, 2016 at 06:11:20PM CEST, jo...@kernel.org wrote: >Add automated test for is_printable_array function. > >Link: http://lkml.kernel.org/n/tip-if70lj3zhdc3csdqm5web...@git.kernel.org >Signed-off-by: Jiri Olsa >--- > tools/perf/tests/Build| 1 + >

Re: [PATCH 3/3] perf tests: Add is_printable_array test

2016-07-18 Thread Jiri Pirko
Sat, Jul 16, 2016 at 06:11:20PM CEST, jo...@kernel.org wrote: >Add automated test for is_printable_array function. > >Link: http://lkml.kernel.org/n/tip-if70lj3zhdc3csdqm5web...@git.kernel.org >Signed-off-by: Jiri Olsa >--- > tools/perf/tests/Build| 1 + >

Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving

2016-07-18 Thread Jiri Pirko
y and returning >it as PyByteArray object in case non printable byte is found. > >Link: http://lkml.kernel.org/n/tip-22f4vhhz5uytegkggy1on...@git.kernel.org >Signed-off-by: Jiri Olsa <jo...@kernel.org> Tested-by: Jiri Pirko <j...@mellanox.com> >--- > .../util/s

Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving

2016-07-18 Thread Jiri Pirko
y and returning >it as PyByteArray object in case non printable byte is found. > >Link: http://lkml.kernel.org/n/tip-22f4vhhz5uytegkggy1on...@git.kernel.org >Signed-off-by: Jiri Olsa Tested-by: Jiri Pirko >--- > .../util/scripting-engines/trace-event-python.c| 39 ++

Re: [PATCH 2/3] perf tools: Make is_printable_array global

2016-07-18 Thread Jiri Pirko
Sat, Jul 16, 2016 at 06:11:19PM CEST, jo...@kernel.org wrote: >It's used from 2 objects in perf, so it's better >to keep just one copy. > >Link: http://lkml.kernel.org/n/tip-dss4lxnywysgpyjd8p7pa...@git.kernel.org >Signed-off-by: Jiri Olsa <jo...@kernel.org> Tes

Re: [PATCH 2/3] perf tools: Make is_printable_array global

2016-07-18 Thread Jiri Pirko
Sat, Jul 16, 2016 at 06:11:19PM CEST, jo...@kernel.org wrote: >It's used from 2 objects in perf, so it's better >to keep just one copy. > >Link: http://lkml.kernel.org/n/tip-dss4lxnywysgpyjd8p7pa...@git.kernel.org >Signed-off-by: Jiri Olsa Tested-by: Jiri Pirko

Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving

2016-07-15 Thread Jiri Pirko
y and returning >it as PyByteArray object in case non printable byte is found. > >Cc: Steven Rostedt (Red Hat) <rost...@goodmis.org> >Cc: Jiri Pirko <j...@mellanox.com> >Link: http://lkml.kernel.org/n/tip-22f4vhhz5uytegkggy1on...@git.kernel.org >Signed-off-by: Jiri Olsa

Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving

2016-07-15 Thread Jiri Pirko
y and returning >it as PyByteArray object in case non printable byte is found. > >Cc: Steven Rostedt (Red Hat) >Cc: Jiri Pirko >Link: http://lkml.kernel.org/n/tip-22f4vhhz5uytegkggy1on...@git.kernel.org >Signed-off-by: Jiri Olsa >--- > .../util/scripting-engines/trace-event-pyth

[patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

2016-07-14 Thread Jiri Pirko
From: Jiri Pirko <j...@mellanox.com> Turned on that driver->owner which is struct module is not available when modules are disabled. Better to depend on a driver name which is always available. Reported-by: Randy Dunlap <rdun...@infradead.org> Fixes: e5224f0fe2 ("devlink: a

[patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

2016-07-14 Thread Jiri Pirko
From: Jiri Pirko Turned on that driver->owner which is struct module is not available when modules are disabled. Better to depend on a driver name which is always available. Reported-by: Randy Dunlap Fixes: e5224f0fe2 ("devlink: add hardware messages tracing facility") Signed

[patch net-next 2/2] devlink: fix trace format string

2016-07-14 Thread Jiri Pirko
size_t' is %zu, not %lu, this works on all architectures. Signed-off-by: Arnd Bergmann <a...@arndb.de> Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility") Signed-off-by: Jiri Pirko <j...@mellanox.com> --- include/trace/events/devlink.h | 2 +- 1 fil

[patch net-next 2/2] devlink: fix trace format string

2016-07-14 Thread Jiri Pirko
, not %lu, this works on all architectures. Signed-off-by: Arnd Bergmann Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility") Signed-off-by: Jiri Pirko --- include/trace/events/devlink.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events

Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n

2016-07-14 Thread Jiri Pirko
Thu, Jul 14, 2016 at 10:12:43AM CEST, a...@arndb.de wrote: >On Thursday, July 14, 2016 8:21:11 AM CEST Jiri Pirko wrote: >> >diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h >> >index 333c32ac9bfa..26f92d3c7e9c 100644 >> >--- a/include/tr

Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n

2016-07-14 Thread Jiri Pirko
Thu, Jul 14, 2016 at 10:12:43AM CEST, a...@arndb.de wrote: >On Thursday, July 14, 2016 8:21:11 AM CEST Jiri Pirko wrote: >> >diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h >> >index 333c32ac9bfa..26f92d3c7e9c 100644 >> >--- a/include/tr

Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-14 Thread Jiri Pirko
t fib4 add/del switchdev obj ops") >Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Jiri Pirko <j...@mellanox.com> Thanks.

Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-14 Thread Jiri Pirko
t fib4 add/del switchdev obj ops") >Signed-off-by: Christophe JAILLET Acked-by: Jiri Pirko Thanks.

Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n

2016-07-14 Thread Jiri Pirko
Wed, Jul 13, 2016 at 11:03:37PM CEST, a...@arndb.de wrote: >A driver calling trace_devlink_hwmsg cannot be built when modules are disabled: > >include/trace/events/devlink.h: In function >'trace_event_get_offsets_devlink_hwmsg': >include/trace/events/devlink.h:25:51: error: dereferencing pointer

Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n

2016-07-14 Thread Jiri Pirko
Wed, Jul 13, 2016 at 11:03:37PM CEST, a...@arndb.de wrote: >A driver calling trace_devlink_hwmsg cannot be built when modules are disabled: > >include/trace/events/devlink.h: In function >'trace_event_get_offsets_devlink_hwmsg': >include/trace/events/devlink.h:25:51: error: dereferencing pointer

Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue

2016-06-08 Thread Jiri Pirko
mber of work items, explicit concurrency >limit is unnecessary here. > >Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue

2016-06-08 Thread Jiri Pirko
mber of work items, explicit concurrency >limit is unnecessary here. > >Signed-off-by: Bhaktipriya Shridhar Acked-by: Jiri Pirko

Re: [PATCH net-next] net: switchdev: Drop EXPERIMENTAL from description

2016-05-14 Thread Jiri Pirko
Sat, May 14, 2016 at 09:49:54PM CEST, f.faine...@gmail.com wrote: >Switchdev has been around for quite a while now, putting "EXPERIMENTAL" >in the description is no longer accurate, drop it. > >Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH net-next] net: switchdev: Drop EXPERIMENTAL from description

2016-05-14 Thread Jiri Pirko
Sat, May 14, 2016 at 09:49:54PM CEST, f.faine...@gmail.com wrote: >Switchdev has been around for quite a while now, putting "EXPERIMENTAL" >in the description is no longer accurate, drop it. > >Signed-off-by: Florian Fainelli Acked-by: Jiri Pirko

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread Jiri Pirko
Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: >On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: >> On 2016/4/24 15:54, Leon Romanovsky wrote: >> >> +int hns_roce_bitmap_alloc(struct hns_roce_bitmap *bitmap, u32 *obj) >> >> +{ >> >> + int ret = 0; >> >> + >> >> +

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread Jiri Pirko
Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: >On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: >> On 2016/4/24 15:54, Leon Romanovsky wrote: >> >> +int hns_roce_bitmap_alloc(struct hns_roce_bitmap *bitmap, u32 *obj) >> >> +{ >> >> + int ret = 0; >> >> + >> >> +

Re: [PATCH] devlink: fix devlink_sb_register prototype

2016-04-16 Thread Jiri Pirko
he same argument list. > >Signed-off-by: Arnd Bergmann <a...@arndb.de> >Fixes: bf7974710a40 ("devlink: add shared buffer configuration") Already fixed by: commit de33efd0fb7f923cd41671b1f743c3a0d44dd953 Author: Jiri Pirko <j...@mellanox.com> Date: Fri Apr 15 09:

Re: [PATCH] devlink: fix devlink_sb_register prototype

2016-04-16 Thread Jiri Pirko
he same argument list. > >Signed-off-by: Arnd Bergmann >Fixes: bf7974710a40 ("devlink: add shared buffer configuration") Already fixed by: commit de33efd0fb7f923cd41671b1f743c3a0d44dd953 Author: Jiri Pirko Date: Fri Apr 15 09:17:08 2016 +0200 devlink: fix sb register stub in case devlink is disabled

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread Jiri Pirko
Wed, Mar 16, 2016 at 11:23:10AM CET, ouli...@huawei.com wrote: >Hi Jiri Pirko, thanks your reviewing. >sorry, I will send a new patch according to your reviews. > >On 2016/3/11 18:42, Jiri Pirko wrote: >> Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >>&g

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-16 Thread Jiri Pirko
Wed, Mar 16, 2016 at 11:23:10AM CET, ouli...@huawei.com wrote: >Hi Jiri Pirko, thanks your reviewing. >sorry, I will send a new patch according to your reviews. > >On 2016/3/11 18:42, Jiri Pirko wrote: >> Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >>&g

Re: [PATCH net-next 2/3] net: dsa: make port_bridge_leave return void

2016-03-13 Thread Jiri Pirko
. > >Make this routine void for the DSA layer and its existing drivers. > >Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH net-next 2/3] net: dsa: make port_bridge_leave return void

2016-03-13 Thread Jiri Pirko
. > >Make this routine void for the DSA layer and its existing drivers. > >Signed-off-by: Vivien Didelot Acked-by: Jiri Pirko

Re: [PATCH net-next 3/3] net: dsa: refine netdev event notifier

2016-03-13 Thread Jiri Pirko
ridge_master). > >Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH net-next 3/3] net: dsa: refine netdev event notifier

2016-03-13 Thread Jiri Pirko
ridge_master). > >Signed-off-by: Vivien Didelot Acked-by: Jiri Pirko

Re: [PATCH net-next 1/3] net: dsa: rename port_*_bridge routines

2016-03-13 Thread Jiri Pirko
ot <vivien.dide...@savoirfairelinux.com> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH net-next 1/3] net: dsa: rename port_*_bridge routines

2016-03-13 Thread Jiri Pirko
Didelot Acked-by: Jiri Pirko

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-11 Thread Jiri Pirko
Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >The driver for Hisilicon RoCE is a platform driver. >The driver will support mulitple versions of hardware. Currently only "v1" >for hip06 SOC is supported. >The driver includes two parts: common driver and hardware-specific

<    1   2   3   4   5   6   7   8   9   >