Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 13:57, Jiri Pirko j...@resnulli.us wrote: Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 05:18, Roopa Prabhu ro...@cumulusnetworks.com wrote: On 12/18/14, 3:26 PM

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
Fri, Dec 19, 2014 at 10:22:24AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 14:31, B Viswanath marichi...@gmail.com wrote: On 19 December 2014 at 13:57, Jiri Pirko j...@resnulli.us wrote: Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 05:18

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Jiri Pirko
Fri, Dec 19, 2014 at 10:35:27AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 14:53, Jiri Pirko j...@resnulli.us wrote: Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 13:57, Jiri Pirko j...@resnulli.us wrote: Fri, Dec 19, 2014 at 06:14:57AM CET

Re: [RFC PATCH net-next v3 1/1] net: Support for switch port configuration

2014-12-18 Thread Jiri Pirko
Thu, Dec 18, 2014 at 04:30:00PM CET, marco.varl...@intel.com wrote: >From: Marco Varlese > >Switch hardware offers a list of attributes that are configurable on a per port >basis. >This patch provides a mechanism to configure switch ports by adding an NDO >for setting specific values to specific

Re: [RFC PATCH net-next v3 1/1] net: Support for switch port configuration

2014-12-18 Thread Jiri Pirko
Thu, Dec 18, 2014 at 04:30:00PM CET, marco.varl...@intel.com wrote: From: Marco Varlese marco.varl...@intel.com Switch hardware offers a list of attributes that are configurable on a per port basis. This patch provides a mechanism to configure switch ports by adding an NDO for setting specific

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
Thu, Dec 11, 2014 at 06:41:13PM CET, ro...@cumulusnetworks.com wrote: >On 12/11/14, 8:56 AM, Jiri Pirko wrote: >>Thu, Dec 11, 2014 at 05:37:46PM CET, ro...@cumulusnetworks.com wrote: >>>On 12/11/14, 3:01 AM, Jiri Pirko wrote: >>>>Thu, Dec 11, 2014 at 10:59:42AM CET,

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
Thu, Dec 11, 2014 at 05:37:46PM CET, ro...@cumulusnetworks.com wrote: >On 12/11/14, 3:01 AM, Jiri Pirko wrote: >>Thu, Dec 11, 2014 at 10:59:42AM CET, marco.varl...@intel.com wrote: >>>>-Original Message- >>>>From: John Fastabend [mailto:john.fastab.

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
Thu, Dec 11, 2014 at 01:02:36PM CET, marco.varl...@intel.com wrote: >> -Original Message- >> From: Jiri Pirko [mailto:j...@resnulli.us] >> Sent: Thursday, December 11, 2014 11:01 AM >> To: Varlese, Marco >> Cc: John Fastabend; net...@vger.kernel.org;

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
Thu, Dec 11, 2014 at 10:59:42AM CET, marco.varl...@intel.com wrote: >> -Original Message- >> From: John Fastabend [mailto:john.fastab...@gmail.com] >> Sent: Wednesday, December 10, 2014 5:04 PM >> To: Jiri Pirko >> Cc: Varlese, Marco; net...@vger.kernel.org;

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
Thu, Dec 11, 2014 at 10:59:42AM CET, marco.varl...@intel.com wrote: -Original Message- From: John Fastabend [mailto:john.fastab...@gmail.com] Sent: Wednesday, December 10, 2014 5:04 PM To: Jiri Pirko Cc: Varlese, Marco; net...@vger.kernel.org; step...@networkplumber.org; Fastabend

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
Thu, Dec 11, 2014 at 01:02:36PM CET, marco.varl...@intel.com wrote: -Original Message- From: Jiri Pirko [mailto:j...@resnulli.us] Sent: Thursday, December 11, 2014 11:01 AM To: Varlese, Marco Cc: John Fastabend; net...@vger.kernel.org; step...@networkplumber.org; Fastabend, John R

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
Thu, Dec 11, 2014 at 05:37:46PM CET, ro...@cumulusnetworks.com wrote: On 12/11/14, 3:01 AM, Jiri Pirko wrote: Thu, Dec 11, 2014 at 10:59:42AM CET, marco.varl...@intel.com wrote: -Original Message- From: John Fastabend [mailto:john.fastab...@gmail.com] Sent: Wednesday, December 10, 2014 5

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Jiri Pirko
Thu, Dec 11, 2014 at 06:41:13PM CET, ro...@cumulusnetworks.com wrote: On 12/11/14, 8:56 AM, Jiri Pirko wrote: Thu, Dec 11, 2014 at 05:37:46PM CET, ro...@cumulusnetworks.com wrote: On 12/11/14, 3:01 AM, Jiri Pirko wrote: Thu, Dec 11, 2014 at 10:59:42AM CET, marco.varl...@intel.com wrote

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-10 Thread Jiri Pirko
Wed, Dec 10, 2014 at 05:23:40PM CET, marco.varl...@intel.com wrote: >From: Marco Varlese > >Switch hardware offers a list of attributes that are configurable >on a per port basis. >This patch provides a mechanism to configure switch ports by adding >an NDO for setting specific values to specific

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-10 Thread Jiri Pirko
Wed, Dec 10, 2014 at 05:23:40PM CET, marco.varl...@intel.com wrote: From: Marco Varlese marco.varl...@intel.com Switch hardware offers a list of attributes that are configurable on a per port basis. This patch provides a mechanism to configure switch ports by adding an NDO for setting specific

Re: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig

2014-12-05 Thread Jiri Pirko
t; reference to `br_fdb_external_learn_del' >> /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3016: undefined >> reference to `br_fdb_external_learn_add' > >This patch fixes these by declaring CONFIG_ROCKER as being dependent >on CONFIG_BRIDGE. > >Reported-by: Jim Davis

Re: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig

2014-12-05 Thread Jiri Pirko
CONFIG_ROCKER as being dependent on CONFIG_BRIDGE. Reported-by: Jim Davis jim.ep...@gmail.com Signed-off-by: Andreas Ruprecht rup...@einserver.de Acked-by: Jiri Pirko j...@resnulli.us --- drivers/net/ethernet/rocker/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig

2014-12-04 Thread Jiri Pirko
o `br_fdb_external_learn_add' > >This patch fixes these by selecting CONFIG_BRIDGE from CONFIG_ROCKER. > >Reported-by: Jim Davis >Signed-off-by: Andreas Ruprecht Acked-by: Jiri Pirko this is ok for now. There is a plan to replace br_fdb_external_learn_add/del a by notifier which wi

Re: [PATCH] net: ethernet: rocker: Add select to CONFIG_BRIDGE in Kconfig

2014-12-04 Thread Jiri Pirko
rup...@einserver.de Acked-by: Jiri Pirko j...@resnulli.us this is ok for now. There is a plan to replace br_fdb_external_learn_add/del a by notifier which will fix this as well. Thanks. --- drivers/net/ethernet/rocker/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net

Re: [PATCH] checkpatch: Add --strict preference for #defines using BIT(foo)

2014-11-09 Thread Jiri Pirko
Fri, Nov 07, 2014 at 10:15:39PM CET, j...@perches.com wrote: >Using BIT(foo) and BIT_ULL(bar) is more common now. >Suggest using these macros over #defines with 1< >Add a --fix option too. > >Signed-off-by: Joe Perches >--- > scripts/checkpatch.pl | 11 +++ > 1 file changed, 11

Re: [PATCH] checkpatch: Add --strict preference for #defines using BIT(foo)

2014-11-09 Thread Jiri Pirko
Fri, Nov 07, 2014 at 10:15:39PM CET, j...@perches.com wrote: Using BIT(foo) and BIT_ULL(bar) is more common now. Suggest using these macros over #defines with 1value. Joe, regarding the other Dave's comment, the multiline one, that is also not covered by checkpatch. Would please you take care of

Re: [PATCH v2 1/2] workqueue: add quiescent state between work items

2014-10-08 Thread Jiri Pirko
Wed, Oct 08, 2014 at 05:24:11AM CEST, paul...@linux.vnet.ibm.com wrote: >On Tue, Oct 07, 2014 at 01:45:28PM -0400, Joe Lawrence wrote: >> On Tue, 7 Oct 2014 06:43:29 -0700 >> "Paul E. McKenney" wrote: >> >> > On Tue, Oct 07, 2014 at 09:29:42A

Re: [PATCH v2 1/2] workqueue: add quiescent state between work items

2014-10-08 Thread Jiri Pirko
Wed, Oct 08, 2014 at 05:24:11AM CEST, paul...@linux.vnet.ibm.com wrote: On Tue, Oct 07, 2014 at 01:45:28PM -0400, Joe Lawrence wrote: On Tue, 7 Oct 2014 06:43:29 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Tue, Oct 07, 2014 at 09:29:42AM +0200, Jiri Pirko wrote: [ ... snip

Re: [PATCH v2 1/2] workqueue: add quiescent state between work items

2014-10-07 Thread Jiri Pirko
Mon, Oct 06, 2014 at 06:21:58AM CEST, paul...@linux.vnet.ibm.com wrote: >On Sun, Oct 05, 2014 at 03:47:48PM -0400, Tejun Heo wrote: >> On Sun, Oct 05, 2014 at 03:21:19PM -0400, Tejun Heo wrote: >> > On Sun, Oct 05, 2014 at 01:24:21PM -0400, Joe Lawrence wrote: >> > > Similar to the stop_machine

Re: [PATCH v2 1/2] workqueue: add quiescent state between work items

2014-10-07 Thread Jiri Pirko
Mon, Oct 06, 2014 at 06:21:58AM CEST, paul...@linux.vnet.ibm.com wrote: On Sun, Oct 05, 2014 at 03:47:48PM -0400, Tejun Heo wrote: On Sun, Oct 05, 2014 at 03:21:19PM -0400, Tejun Heo wrote: On Sun, Oct 05, 2014 at 01:24:21PM -0400, Joe Lawrence wrote: Similar to the stop_machine deadlock

Re: [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param

2014-08-20 Thread Jiri Pirko
Wed, Aug 20, 2014 at 01:17:24PM CEST, m...@redhat.com wrote: >On Wed, Aug 20, 2014 at 12:58:17PM +0200, Jiri Pirko wrote: >> Mon, Aug 18, 2014 at 03:37:18PM CEST, pagu...@redhat.com wrote: >> > This patch publishes maximum number of tun/tap queues allocated as a >> >

Re: [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param

2014-08-20 Thread Jiri Pirko
Wed, Aug 20, 2014 at 01:49:07PM CEST, m...@redhat.com wrote: >On Wed, Aug 20, 2014 at 01:46:20PM +0200, Jiri Pirko wrote: >> Wed, Aug 20, 2014 at 01:17:24PM CEST, m...@redhat.com wrote: >> >On Wed, Aug 20, 2014 at 12:58:17PM +0200, Jiri Pirko wrote: >> >> Mon, Aug 18,

Re: [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param

2014-08-20 Thread Jiri Pirko
Mon, Aug 18, 2014 at 03:37:18PM CEST, pagu...@redhat.com wrote: > This patch publishes maximum number of tun/tap queues allocated as a > read_only module parameter which a user space application like libvirt > can make use of to limit maximum number of queues. Value of read_only > module parameter

Re: [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param

2014-08-20 Thread Jiri Pirko
Mon, Aug 18, 2014 at 03:37:18PM CEST, pagu...@redhat.com wrote: This patch publishes maximum number of tun/tap queues allocated as a read_only module parameter which a user space application like libvirt can make use of to limit maximum number of queues. Value of read_only module parameter can

Re: [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param

2014-08-20 Thread Jiri Pirko
Wed, Aug 20, 2014 at 01:49:07PM CEST, m...@redhat.com wrote: On Wed, Aug 20, 2014 at 01:46:20PM +0200, Jiri Pirko wrote: Wed, Aug 20, 2014 at 01:17:24PM CEST, m...@redhat.com wrote: On Wed, Aug 20, 2014 at 12:58:17PM +0200, Jiri Pirko wrote: Mon, Aug 18, 2014 at 03:37:18PM CEST, pagu

Re: [RFC 2/4] tuntap: Publish tuntap maximum number of queues as module_param

2014-08-20 Thread Jiri Pirko
Wed, Aug 20, 2014 at 01:17:24PM CEST, m...@redhat.com wrote: On Wed, Aug 20, 2014 at 12:58:17PM +0200, Jiri Pirko wrote: Mon, Aug 18, 2014 at 03:37:18PM CEST, pagu...@redhat.com wrote: This patch publishes maximum number of tun/tap queues allocated as a read_only module parameter which a user

Re: [PATCH V2] net: ethernet: myricom: myri10ge: myri10ge.c: Cleaning up missing null-terminate after strncpy call

2014-08-13 Thread Jiri Pirko
Mon, Aug 11, 2014 at 09:18:16PM CEST, rickard_strandqv...@spectrumdigital.se wrote: >Added a guaranteed null-terminate after call to strncpy. > >Signed-off-by: Rickard Strandqvist >--- > drivers/net/ethernet/myricom/myri10ge/myri10ge.c |1 + > 1 file changed, 1 insertion(+) > >diff --git

Re: [PATCH V2] net: ethernet: myricom: myri10ge: myri10ge.c: Cleaning up missing null-terminate after strncpy call

2014-08-13 Thread Jiri Pirko
Mon, Aug 11, 2014 at 09:18:16PM CEST, rickard_strandqv...@spectrumdigital.se wrote: Added a guaranteed null-terminate after call to strncpy. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/net/ethernet/myricom/myri10ge/myri10ge.c |1 + 1 file changed, 1

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Jiri Pirko
Mon, Jun 16, 2014 at 10:44:30AM CEST, da...@davemloft.net wrote: >From: Michal Privoznik >Date: Mon, 16 Jun 2014 10:30:27 +0200 > >> On 16.06.2014 10:11, David Miller wrote: >>> From: Michal Privoznik >>> Date: Mon, 16 Jun 2014 09:32:35 +0200 >>> On 13.06.2014 22:03, David Miller wrote:

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Jiri Pirko
Mon, Jun 16, 2014 at 10:44:30AM CEST, da...@davemloft.net wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 10:30:27 +0200 On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03,

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-06 Thread Jiri Pirko
Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: >The link speed is available at /sys/class/net/$nic/speed. >However, in some cases, depending on the driver, if the link is >not plugged, -1 is reported (this is the case of e1000e for >instance). To make things worse, the value is

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-06 Thread Jiri Pirko
Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: The link speed is available at /sys/class/net/$nic/speed. However, in some cases, depending on the driver, if the link is not plugged, -1 is reported (this is the case of e1000e for instance). To make things worse, the value is

Re: [PATCH] net-sysfs: Report link speed as signed integer

2014-06-02 Thread Jiri Pirko
Mon, Jun 02, 2014 at 04:25:15PM CEST, mpriv...@redhat.com wrote: >The link speed is available at /sys/class/net/$nic/speed. >However, the speed is printed in unsigned integer format. This >makes userspace applications read an incorrect value (which >moreover changes through several architectures)

Re: [PATCH] net-sysfs: Report link speed as signed integer

2014-06-02 Thread Jiri Pirko
Mon, Jun 02, 2014 at 04:25:15PM CEST, mpriv...@redhat.com wrote: The link speed is available at /sys/class/net/$nic/speed. However, the speed is printed in unsigned integer format. This makes userspace applications read an incorrect value (which moreover changes through several architectures)

Re: [PATCH net] bridge: notify user space after fdb update

2014-05-29 Thread Jiri Pirko
result the ARP reply was directed >back onto the external network and VM never updated it's ARP cache. This patch >will notify the bridge command, after a fdb has been updated to identify such >port toggling. > >Signed-off-by: Jon Maxwell Reviewed-by: Jiri Pirko -- To unsub

Re: [PATCH net] bridge: notify user space after fdb update

2014-05-29 Thread Jiri Pirko
was directed back onto the external network and VM never updated it's ARP cache. This patch will notify the bridge command, after a fdb has been updated to identify such port toggling. Signed-off-by: Jon Maxwell jmaxwel...@gmail.com Reviewed-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-13 Thread Jiri Pirko
EWNEIGH); > fdb->dst = source; > fdb->updated = jiffies; > if (unlikely(added_by_user)) >-- >1.8.3.1 Reviewed-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-13 Thread Jiri Pirko
; if (unlikely(added_by_user)) -- 1.8.3.1 Reviewed-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-05 Thread Jiri Pirko
Fri, May 02, 2014 at 09:18:12AM CEST, zhouzho...@gmail.com wrote: >As http://www.spinics.net/lists/netdev/msg165015.html >pktgen generates shared packet through vlan interface will cause >oops because of duplicate entering tc queue. > >Try to solve this problem by means of packet clone instead of

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-05 Thread Jiri Pirko
Fri, May 02, 2014 at 09:18:12AM CEST, zhouzho...@gmail.com wrote: As http://www.spinics.net/lists/netdev/msg165015.html pktgen generates shared packet through vlan interface will cause oops because of duplicate entering tc queue. Try to solve this problem by means of packet clone instead of

Re: [PATCH v1] net-sysfs: expose number of link up/down transitions

2014-03-28 Thread Jiri Pirko
Fri, Mar 28, 2014 at 05:35:00AM CET, de...@googlers.com wrote: >Tested: > grep . /sys/class/net/*/count_link_* > + ip link set dev X down/up > >Signed-off-by: David Decotigny >--- > include/linux/netdevice.h | 4 > net/core/net-sysfs.c | 18 ++ > net/sched/sch_generic.c

Re: [PATCH v1] net-sysfs: expose number of link up/down transitions

2014-03-28 Thread Jiri Pirko
Fri, Mar 28, 2014 at 05:35:00AM CET, de...@googlers.com wrote: Tested: grep . /sys/class/net/*/count_link_* + ip link set dev X down/up Signed-off-by: David Decotigny de...@googlers.com --- include/linux/netdevice.h | 4 net/core/net-sysfs.c | 18 ++

Re: [PATCH net-next 4/4] bonding: Convert memcpy(foo, bar, ETH_ALEN) to ether_addr_copy(foo, bar)

2014-03-10 Thread Jiri Pirko
Many times, the original len ETH_ALEN was wrong. Bonding should work with other types than Ethernet as well. Sun, Feb 16, 2014 at 01:02:17AM CET, j...@perches.com wrote: >ether_addr_copy is smaller and faster for some architectures. > >This relies on a stack frame being at least __aligned(2)

Re: [PATCH net-next 4/4] bonding: Convert memcpy(foo, bar, ETH_ALEN) to ether_addr_copy(foo, bar)

2014-03-10 Thread Jiri Pirko
Many times, the original len ETH_ALEN was wrong. Bonding should work with other types than Ethernet as well. Sun, Feb 16, 2014 at 01:02:17AM CET, j...@perches.com wrote: ether_addr_copy is smaller and faster for some architectures. This relies on a stack frame being at least __aligned(2) for

Re: [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline)

2013-03-30 Thread Jiri Pirko
Fri, Mar 29, 2013 at 07:36:24PM CET, rost...@goodmis.org wrote: >On Fri, 2013-03-29 at 10:48 +0100, Jiri Pirko wrote: > >> Because, if rcu_dereference(dev->rx_handler) is null, >> rcu_dereference(dev->rx_handler_data) is never done. Therefore I believe >> we

Re: [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline)

2013-03-30 Thread Jiri Pirko
Fri, Mar 29, 2013 at 07:36:24PM CET, rost...@goodmis.org wrote: On Fri, 2013-03-29 at 10:48 +0100, Jiri Pirko wrote: Because, if rcu_dereference(dev-rx_handler) is null, rcu_dereference(dev-rx_handler_data) is never done. Therefore I believe we are hitting following scenario: CPU0

Re: [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()

2013-03-29 Thread Jiri Pirko
Fri, Mar 29, 2013 at 04:38:15PM CET, eric.duma...@gmail.com wrote: >On Fri, 2013-03-29 at 16:11 +0100, Ivan Vecera wrote: > >> Erik, why doesn't help the write barrier between the assignments. It >> should guarantee their orders... or not? >> > >Its not enough, I wont explain here why as RCU is

Re: [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline)

2013-03-29 Thread Jiri Pirko
Thu, Mar 28, 2013 at 06:29:52PM CET, eric.duma...@gmail.com wrote: >On Thu, 2013-03-28 at 13:16 -0400, Steven Rostedt wrote: >> Hi, >> >> I'm currently debugging a crash in an old 3.0-rt kernel that one of our >> customers is seeing. The bug happens with a stress test that loads and >> unloads

Re: [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline)

2013-03-29 Thread Jiri Pirko
Thu, Mar 28, 2013 at 06:29:52PM CET, eric.duma...@gmail.com wrote: On Thu, 2013-03-28 at 13:16 -0400, Steven Rostedt wrote: Hi, I'm currently debugging a crash in an old 3.0-rt kernel that one of our customers is seeing. The bug happens with a stress test that loads and unloads the bonding

Re: [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()

2013-03-29 Thread Jiri Pirko
Fri, Mar 29, 2013 at 04:38:15PM CET, eric.duma...@gmail.com wrote: On Fri, 2013-03-29 at 16:11 +0100, Ivan Vecera wrote: Erik, why doesn't help the write barrier between the assignments. It should guarantee their orders... or not? Its not enough, I wont explain here why as RCU is quite well

Re: linux-next: manual merge of the net-next tree with the net tree

2013-02-02 Thread Jiri Pirko
Sat, Feb 02, 2013 at 04:22:53AM CET, s...@canb.auug.org.au wrote: >Hi all, > >Today's linux-next merge of the net-next tree got a conflict in >net/ipv6/route.c between commit bd30e947207e ("ipv6: do not create >neighbor entries for local delivery") from the net tree and commit >c440f1609b65

Re: linux-next: manual merge of the net-next tree with the net tree

2013-02-02 Thread Jiri Pirko
Sat, Feb 02, 2013 at 04:22:53AM CET, s...@canb.auug.org.au wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in net/ipv6/route.c between commit bd30e947207e (ipv6: do not create neighbor entries for local delivery) from the net tree and commit c440f1609b65 (ipv6: Do not

[patch net-next V6 06/15] bridge: remove usage of netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 1edd71d..2148d47 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -148,7 +148,7 @@ static void del_nbp(struct

[patch net-next V6 03/15] vlan: add link to upper device

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/8021q/vlan.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index a292e80..babfde9 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -105,6 +105,8 @@ void unregister_vlan_dev(struct

[patch net-next V6 01/15] net: introduce upper device lists

2013-01-04 Thread Jiri Pirko
dev->master, it is marked with "master" flag. New upper device list resolves this limitation. Also, the information stored in lists is used for preventing looping setups like "bond->somethingelse->samebond" Signed-off-by: Jiri Pirko --- include/linux/netde

[patch net-next V6 02/15] macvlan: add link to upper device

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/macvlan.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 68a43fe..b7b614f 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -765,16 +765,22 @@ int

[patch net-next V6 07/15] netpoll: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/netpoll.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 3151acf..d2bda8e 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -210,9 +210,12 @@ static void netpoll_poll_dev

[patch net-next V6 08/15] cxgb3: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c index 942dace..3f1f501 100644

[patch net-next V6 11/15] vlan: remove usage of dev->master in __vlan_find_dev_deep()

2013-01-04 Thread Jiri Pirko
Also, since all users call __vlan_find_dev_deep() with rcu_read_lock, make no possibility to call this with rtnl mutex held only. Signed-off-by: Jiri Pirko --- net/8021q/vlan_core.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/8021q/vlan_core.c b

[patch net-next V6 12/15] nes: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/infiniband/hw/nes/nes.c| 8 +--- drivers/infiniband/hw/nes/nes_cm.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 748db2d..d129c36 100644 --- a/drivers

[patch net-next V6 14/15] net: remove no longer used netdev_set_bond_master() and netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 6 + net/core/dev.c| 63 --- 2 files changed, 1 insertion(+), 68 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 52d1146..c3723ef 100644

[patch net-next V6 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock

2013-01-04 Thread Jiri Pirko
Also benefit from rcu_read_lock held and use __in_dev_get_rcu() in ipv4 case. Signed-off-by: Jiri Pirko --- drivers/s390/net/qeth_l3_main.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net

[patch net-next V6 15/15] net: kill dev->master

2013-01-04 Thread Jiri Pirko
Nobody uses this now. Remove it. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 4 1 file changed, 4 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c3723ef..009bad3 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h

[patch net-next V6 13/15] bonding: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Benefit from new upper dev list and free bonding from dev->master usage. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_3ad.c | 30 ++--- drivers/net/bonding/bond_alb.c | 6 +-- drivers/net/bonding/bond_main.c | 94 - drivers/

[patch net-next V6 04/15] rtnetlink: remove usage of dev->master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/rtnetlink.c | 69 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 2ef7a56..ae612f4 100644 --- a/net/core/rtnetlink.c +++ b/net/core

[patch net-next V6 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock

2013-01-04 Thread Jiri Pirko
rcu_read_lock was missing here Signed-off-by: Jiri Pirko Acked-by: Sony Chacko --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index

[patch net-next V6 05/15] team: remove usage of netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 78c7d87..5f35d6b 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1055,10 +1055,11

[patch net-next V6 00/15] net: introduce upper device lists and remove dev->master

2013-01-04 Thread Jiri Pirko
rent net-next v1->v2: - s/unique/master/ better naming + stays closer to the past - fixed vlan err goto - original patch 15 (WARN_ON change) is squashed into the first patch Jiri Pirko (15): net: introduce upper device lists macvlan: add link to upper device vlan: add link to upper device

[patch net-next V6 00/15] net: introduce upper device lists and remove dev-master

2013-01-04 Thread Jiri Pirko
(WARN_ON change) is squashed into the first patch Jiri Pirko (15): net: introduce upper device lists macvlan: add link to upper device vlan: add link to upper device rtnetlink: remove usage of dev-master team: remove usage of netdev_set_master() bridge: remove usage of netdev_set_master

[patch net-next V6 05/15] team: remove usage of netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/net/team/team.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 78c7d87..5f35d6b 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c

[patch net-next V6 04/15] rtnetlink: remove usage of dev-master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/core/rtnetlink.c | 69 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 2ef7a56..ae612f4 100644 --- a/net/core/rtnetlink.c +++ b

[patch net-next V6 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock

2013-01-04 Thread Jiri Pirko
rcu_read_lock was missing here Signed-off-by: Jiri Pirko j...@resnulli.us Acked-by: Sony Chacko sony.cha...@qlogic.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net

[patch net-next V6 13/15] bonding: remove usage of dev-master

2013-01-04 Thread Jiri Pirko
Benefit from new upper dev list and free bonding from dev-master usage. Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/net/bonding/bond_3ad.c | 30 ++--- drivers/net/bonding/bond_alb.c | 6 +-- drivers/net/bonding/bond_main.c | 94

[patch net-next V6 15/15] net: kill dev-master

2013-01-04 Thread Jiri Pirko
Nobody uses this now. Remove it. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 4 1 file changed, 4 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c3723ef..009bad3 100644 --- a/include/linux/netdevice.h +++ b/include/linux

[patch net-next V6 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock

2013-01-04 Thread Jiri Pirko
Also benefit from rcu_read_lock held and use __in_dev_get_rcu() in ipv4 case. Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/s390/net/qeth_l3_main.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390

[patch net-next V6 14/15] net: remove no longer used netdev_set_bond_master() and netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 6 + net/core/dev.c| 63 --- 2 files changed, 1 insertion(+), 68 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 52d1146

[patch net-next V6 12/15] nes: remove usage of dev-master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/infiniband/hw/nes/nes.c| 8 +--- drivers/infiniband/hw/nes/nes_cm.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 748db2d..d129c36 100644

[patch net-next V6 11/15] vlan: remove usage of dev-master in __vlan_find_dev_deep()

2013-01-04 Thread Jiri Pirko
Also, since all users call __vlan_find_dev_deep() with rcu_read_lock, make no possibility to call this with rtnl mutex held only. Signed-off-by: Jiri Pirko j...@resnulli.us --- net/8021q/vlan_core.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/8021q

[patch net-next V6 08/15] cxgb3: remove usage of dev-master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c index 942dace

[patch net-next V6 07/15] netpoll: remove usage of dev-master

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/core/netpoll.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 3151acf..d2bda8e 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -210,9 +210,12 @@ static void

[patch net-next V6 02/15] macvlan: add link to upper device

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/net/macvlan.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 68a43fe..b7b614f 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -765,16 +765,22

[patch net-next V6 01/15] net: introduce upper device lists

2013-01-04 Thread Jiri Pirko
-master, it is marked with master flag. New upper device list resolves this limitation. Also, the information stored in lists is used for preventing looping setups like bond-somethingelse-samebond Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 14 +++ net/core/dev.c

[patch net-next V6 06/15] bridge: remove usage of netdev_set_master()

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 1edd71d..2148d47 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -148,7 +148,7 @@ static void

[patch net-next V6 03/15] vlan: add link to upper device

2013-01-04 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/8021q/vlan.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index a292e80..babfde9 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -105,6 +105,8 @@ void

[patch net-next V5 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock

2013-01-02 Thread Jiri Pirko
Also benefit from rcu_read_lock held and use __in_dev_get_rcu() in ipv4 case. Signed-off-by: Jiri Pirko --- drivers/s390/net/qeth_l3_main.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net

[patch net-next V5 13/15] bonding: remove usage of dev->master

2013-01-02 Thread Jiri Pirko
Benefit from new upper dev list and free bonding from dev->master usage. Signed-off-by: Jiri Pirko --- drivers/net/bonding/bond_3ad.c | 30 ++--- drivers/net/bonding/bond_alb.c | 6 +-- drivers/net/bonding/bond_main.c | 94 - drivers/

[patch net-next V5 11/15] vlan: remove usage of dev->master in __vlan_find_dev_deep()

2013-01-02 Thread Jiri Pirko
Also, since all users call __vlan_find_dev_deep() with rcu_read_lock, make no possibility to call this with rtnl mutex held only. Signed-off-by: Jiri Pirko --- net/8021q/vlan_core.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/8021q/vlan_core.c b

[patch net-next V5 03/15] vlan: add link to upper device

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/8021q/vlan.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index a292e80..babfde9 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -105,6 +105,8 @@ void unregister_vlan_dev(struct

[patch net-next V5 04/15] rtnetlink: remove usage of dev->master

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- net/core/rtnetlink.c | 69 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 2ef7a56..ae612f4 100644 --- a/net/core/rtnetlink.c +++ b/net/core

[patch net-next V5 15/15] net: kill dev->master

2013-01-02 Thread Jiri Pirko
Nobody uses this now. Remove it. Signed-off-by: Jiri Pirko --- include/linux/netdevice.h | 4 1 file changed, 4 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c3723ef..009bad3 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h

[patch net-next V5 02/15] macvlan: add link to upper device

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/macvlan.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 68a43fe..b7b614f 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -765,16 +765,22 @@ int

[patch net-next V5 08/15] cxgb3: remove usage of dev->master

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c index 942dace..3f1f501 100644

[patch net-next V5 00/15] net: introduce upper device lists and remove dev->master

2013-01-02 Thread Jiri Pirko
- s/unique/master/ better naming + stays closer to the past - fixed vlan err goto - original patch 15 (WARN_ON change) is squashed into the first patch Jiri Pirko (15): net: introduce upper device lists macvlan: add link to upper device vlan: add link to upper device rtnetlink: remove usage

[patch net-next V5 05/15] team: remove usage of netdev_set_master()

2013-01-02 Thread Jiri Pirko
Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 918a901..3df5cc1 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1055,10 +1055,11

[patch net-next V5 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock

2013-01-02 Thread Jiri Pirko
rcu_read_lock was missing here Signed-off-by: Jiri Pirko Acked-by: Sony Chacko --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index

<    2   3   4   5   6   7   8   9   >