RE: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-11-05 Thread Jitendra Bhivare
de5 100644 > --- a/drivers/scsi/be2iscsi/be_main.h > +++ b/drivers/scsi/be2iscsi/be_main.h > @@ -155,8 +155,6 @@ > #define PAGES_REQUIRED(x) \ > ((x < PAGE_SIZE) ? 1 : ((x + PAGE_SIZE - 1) / PAGE_SIZE)) > > -#define BEISCSI_MSI_NAME 20 /* size of msi_name string */ > - > #define MEM_DESCR_OFFSET 8 > #define BEISCSI_DEFQ_HDR 1 > #define BEISCSI_DEFQ_DATA 0 > -- > 2.7.4 Looks good. - Thanks. Reviewed-by: Jitendra Bhivare

RE: [PATCH 2/2] scsi: be2iscsi: set errno on error path

2016-12-04 Thread Jitendra Bhivare
> -Original Message- > From: Pan Bian [mailto:bianpan201...@163.com] > Sent: Sunday, December 04, 2016 10:53 AM > To: Subbu Seetharaman; Ketan Mukadam; Jitendra Bhivare; James E.J. > Bottomley; Martin K. Petersen; linux-s...@vger.kernel.org > Cc: linux-kernel@vger.ke

RE: [PATCH 1/2] scsi: be2iscsi: set errno on error path

2016-12-04 Thread Jitendra Bhivare
> -Original Message- > From: Pan Bian [mailto:bianpan201...@163.com] > Sent: Sunday, December 04, 2016 10:52 AM > To: Subbu Seetharaman; Ketan Mukadam; Jitendra Bhivare; James E.J. > Bottomley; Martin K. Petersen; linux-s...@vger.kernel.org > Cc: linux-kernel@vger.ke

RE: [PATCH] scsi: be2iscsi: mark symbols static where possible

2016-09-26 Thread Jitendra Bhivare
are only used in the file in which they are declared and > don't need a declaration, but can be made static. > > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- [JB] Looks good. Reviewed by: Jitendra Bhivare

RE: [PATCH] be2iscsi: Use a more current logging style

2016-08-16 Thread Jitendra Bhivare
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Tuesday, August 16, 2016 3:57 PM > To: Jitendra Bhivare; Christophe JAILLET; Jayamohan Kallickal; Ketan Mukadam > Cc: Bart Van Assche; James E.J. Bottomley; Martin K. Petersen; linux- > s...@vger

RE: [PATCH 1/2] be2iscsi: Fix error return code

2016-08-15 Thread Jitendra Bhivare
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christophe JAILLET > Sent: Friday, August 12, 2016 3:33 PM > To: jayamohan.kallic...@avagotech.com; j...@linux.vnet.ibm.com; > ketan.muka...@avagotech.com; sony.j...@avago

RE: [PATCH] be2iscsi: Use a more current logging style

2016-08-15 Thread Jitendra Bhivare
Thanks Joe for taking this up. It has been pending for long time from our side. > -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Joe Perches > Sent: Monday, August 15, 2016 12:26 AM > To: Christophe JAILLET; Jayamohan K