On Wed, May 29, 2019 at 1:55 AM Hans de Goede wrote:
>
> Hi João,
>
> On 5/28/19 11:22 PM, João Paulo Rechi Vita wrote:
> > On Mon, May 20, 2019 at 11:28 PM Hans de Goede wrote:
> >>
> >> Commit 78f3ac76d9e5 ("platform/x86: asus-wmi: Tell the EC the O
C
> 1015BX, Asus EeePC 1025C).
>
> The asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL) call added
> by that commit is made conditional in this commit and only enabled in
> the quirk_entry structs in the asus-nb-wmi driver fixing the broken
> display / backlight on various
#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I: If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Signed-off-by: João Paulo Rechi Vita
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth
#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I: If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Signed-off-by: João Paulo Rechi Vita
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth
Address type: 0x06
LE Public
LE Random
Discovery: Enabled (0x01)
@ MGMT Event: Discovering (0x0013) plen 2 {0x0001} [hci0] 27.422067
Address type: 0x06
LE Public
LE Random
Discovery: Enabled (0x01)
Signed-off-by:
sage, and the extra
command complete event can be seen at timestamp 27.420131.
Best regards,
João Paulo Rechi Vita (2):
Bluetooth: Create new HCI_QUIRK_WAIT_FOR_MATCHING_CC
Bluetooth: Set HCI_QUIRK_WAIT_FOR_MATCHING_CC for QCA9377
drivers/bluetooth/btusb.c| 9 +
include/net/bl
On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza
wrote:
>
> Hello João,
>
> On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote:
> > Hello Marcos,
> >
> > On Sun, Feb 10, 2019 at 5:05 PM Marcos Paulo de Souza
> > wrote:
> >>
> >>
> >&g
ut I'm not responsible if a
BIOS update breaks your machine in any way, so just do it if you this
is something you are comfortable with and understand and assume all
the risks yourself. We have been reporting machines with the old
behavior back to Asus, but I don't know what they are doing with that
information, if anything. I'm adding your machine with the old BIOS
version to the list, so if you test the new BIOS let me know so I can
add that as well. But please don't feel any pressure to update the
BIOS if this is something you would not do otherwise.
Best regards,
--
João Paulo Rechi Vita
: hci0: Found Intel DDC
parameters: intel/ibt-11-5.ddc
Jan 09 16:54:34 endless kernel: Bluetooth: hci0: Applying Intel DDC
parameters completed
Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM TTY layer initialized
Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM socket layer initialized
Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM ver 1.11
--
João Paulo Rechi Vita
http://about.me/jprvita
Hello Sasha,
On Tue, Jan 8, 2019 at 11:26 AM Sasha Levin wrote:
>
> From: João Paulo Rechi Vita
>
> [ Upstream commit 78f3ac76d9e5219589718b9e4733bee21627b3f5 ]
>
> In the past, Asus firmwares would change the panel backlight directly
> through the EC when the display o
Hello Marcel,
On Wed, Dec 5, 2018 at 11:27 AM João Paulo Rechi Vita wrote:
>
> Hello Marcel,
>
> On Fri, Nov 9, 2018 at 4:36 PM João Paulo Rechi Vita
> wrote:
> >
> > Hello Marcel,
> >
> > On Thu, Nov 8, 2018 at 11:49 PM Marcel Holtmann wrote:
> >
land ABI and I don't think it has good enough reasons
to do that.
>
This only changes which state will be reported when the battery is
100% charged and not discharging, it does not introduce / remove any
values. I don't think that is considered ABI change, and on other
hardware like the Dell Latitude 5480,
/sys/class/power_supply//status already reports "Full"
under these conditions. I still believe it is a bug that makes the ABI
inconsistent across different hardware.
--
João Paulo Rechi Vita
http://about.me/jprvita
On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote:
>
> On Fri 2018-11-02 23:57:32, João Paulo Rechi Vita wrote:
> > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting
> > "Discharging" on some machines when AC was connected but the battery was
> &
Hello Hans, thanks for your quick response,
On Sat, Nov 3, 2018 at 4:28 AM Hans de Goede wrote:
>
> Hi,
>
> On 03-11-18 07:57, João Paulo Rechi Vita wrote:
> > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting
> > "Discharging" on some machines whe
it takes the battery capacity into consideration when checking
if "Not charging" should be returned and "Full" is returned when the
capacity is 100%.
Signed-off-by: João Paulo Rechi Vita
---
drivers/acpi/battery.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index db2af09067db..5a00a7665f9b 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform
-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index 5a00a7665f9b..b6f2ff95c3ed 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86
with Wayland, so any clarifications in that regard
would be greatly appreciated.
João Paulo Rechi Vita (3):
asus-wmi: Tell the EC the OS will handle the display off hotkey
asus-nb-wmi: Map 0x35 to KEY_SCREENLOCK
asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan codes
drivers/platform/x86/asus-nb-wm
IANE (Local0)
}
}
ElseIf ((BLCT == One))
{
If (ATKP)
{
ATKD.IANE (0x35)
}
}
}
(...)
}
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wmi.c | 3 ++-
1
Creates a new trigger rfkill-none, as a complement to rfkill-any, which
drives LEDs when any radio is enabled. The new trigger is meant to turn
a LED ON whenever all radios are OFF, and turn it OFF otherwise.
Signed-off-by: João Paulo Rechi Vita
---
net/rfkill/core.c | 27
fa7cb512 ]---
note: modprobe[3275] exited with preempt_count 2
https://bugzilla.kernel.org/show_bug.cgi?id=196467
Reported-by: red.f0...@gmail.com
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wmi.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
From: João Paulo Rechi Vita
u64 should be printed with %llx instead of %x and cast to uint.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wireless.c
b/drivers
Rename these functions to rfkill_global_led_trigger*, as they are going
to be extended to handle another global rfkill led trigger.
This commit does not change any functionality.
Signed-off-by: João Paulo Rechi Vita
---
net/rfkill/core.c | 47 ---
1
On Tue, May 8, 2018 at 1:37 AM, Pkshih wrote:
> On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote:
>> On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote:
>> > On Wed, 2018-05-02 at 05:44 +, Pkshih wrote:
>> >>
>> >> > -Original Mes
On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote:
> On Wed, 2018-05-02 at 05:44 +, Pkshih wrote:
>>
>> > -Original Message-----
>> > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com]
>> > Sent: Wednesday, May 02, 2018 6:41 AM
>> > To: Larr
MBytes 38.5 Mbits/sec0 sender
[ 4] 0.00-10.00 sec 45.0 MBytes 37.7 Mbits/sec receiver
iperf Done.
Signed-off-by: João Paulo Rechi Vita
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c | 2 --
drivers/net/wireless/realtek/rtlwifi/rtl8723com
MBytes 37.7 Mbits/sec receiver
iperf Done.
Signed-off-by: João Paulo Rechi Vita
---
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
b/drivers/net
] Interval Transfer Bandwidth Retr
[ 4] 0.00-10.00 sec 45.9 MBytes 38.5 Mbits/sec0 sender
[ 4] 0.00-10.00 sec 45.0 MBytes 37.7 Mbits/sec receiver
iperf Done.
Signed-off-by: João Paulo Rechi Vita
---
.../realtek/rtlwifi/btcoexist
On Tue, Apr 3, 2018 at 7:51 PM, Larry Finger wrote:
> On 04/03/2018 09:37 PM, João Paulo Rechi Vita wrote:
>>
>> On Tue, Apr 3, 2018 at 7:28 PM, Larry Finger
>> wrote:
>>
>> (...)
>>
>>> As the antenna selection code changes affected your firs
s=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
Signed-off
ported-by: Dun Hum
Cc: sta...@vger.kernel.org
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wireless.c
b/drivers/platform/x86/asus-wireless.c
index 343e12547660..b8e35a
On Sat, Apr 7, 2018 at 8:50 AM, Darren Hart wrote:
> On Fri, Apr 06, 2018 at 10:37:29PM -0700, João Paulo Rechi Vita wrote:
>> When the module is removed the led workqueue is destroyed in the remove
>> callback, before the led device is unregistered from the led subsystem.
>&g
ported-by: Dun Hum
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/asus-wireless.c
b/drivers/platform/x86/asus-wireless.c
index 343e12547660..ecd715c82de5 100644
--- a/drivers/platform/x8
gnal
> strength for good and bad cases. I have tried to keep the driver and the
> btcoex code in sync, but there may be some combinations of antenna
> configuration and FUSE contents that cause the code to fail.
>
What is the recommended way to monitor the signal strength?
Thanks for s
0.00
v4.13569dbb8261 8.41 0.00
v4.15+revert d8a5b801923.861.41
v4.15+revert d8a5b80189 18.69 1.39
Best regards,
--
João Paulo Rechi Vita
http://about.me/jprvita
k into one day ... but we shouldn't let this block any further
> development.
>
> I have applied the series now to for-4.14/multitouch (fixing up the
> 0xff310076 -> HID_VD_ASUS_CUSTOM_MEDIA_KEYS constant in the condition as a
> followup).
>
Thanks!
--
João Paulo Rechi Vita
http://about.me/jprvita
o the warn level helps having a clean boot process.
Signed-off-by: João Paulo Rechi Vita
---
v2 changes:
- Set to warn level instead of info
v3 changes:
- Fix commit message typo
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
o the warn level helps having a clean boot process.
Signed-off-by: João Paulo Rechi Vita
---
v2 changes:
- Set to warn level instead of info
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/int
Hello Luca,
On Mon, Jul 24, 2017 at 4:01 AM, Coelho, Luciano
wrote:
> On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote:
(...)
>> Currently these messages are presented to the user during boot if there
>> is no bootsplash covering the console, sometimes even if
Some keyboard + touchpad devices have the Microsoft Win8 Wireless Radio
Controls extensions Usage Page define in the touchpad report descriptor,
so we need to support them in this driver.
Signed-off-by: João Paulo Rechi Vita
---
drivers/hid/hid-multitouch.c | 6 +-
1 file changed, 5
: João Paulo Rechi Vita
---
drivers/hid/hid-ids.h| 1 +
drivers/hid/hid-multitouch.c | 44 +++-
include/linux/hid.h | 2 ++
3 files changed, 46 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index
Sub=01 Prot=01 Driver=usbhid
I: If#= 1 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=01 Prot=02 Driver=usbhid
João Paulo Rechi Vita (2):
HID: multitouch: Support HID_GD_WIRELESS_RADIO_CTLS
HID: multitouch: Support Asus T304UA media keys
drivers/hid/hid-ids.h| 1 +
drivers/hid/hid-multitouch.c |
yet by the time this message is shown.
Demoting it to the info level helps having a clean boot process.
Signed-off-by: João Paulo Rechi Vita
---
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/intel
the kernel
log: "Get Current Device Status failed: 0xe2 - 0x0".
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/acer-wmi.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 79fa5ab3fd00..
tream, and we expect this
list to continue growing.
This series makes use of ASUS_WMI_DSTS_USER_BIT plus the status of the ASHS
device to skip asus_wmi_rfkill_init(), instead of static DMI-based quirks.
João Paulo Rechi Vita (2):
platform/x86: asus-wmi: Detect quirk_no_rfkill from the DSDT
platfor
X456UF"
6b7ff2af5286 "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA"
02db9ff7af18 "asus-wmi: Add quirk_no_rfkill for the Asus U303LB"
2d735244b798 "asus-wmi: Add quirk_no_rfkill for the Asus N552VW"
a977e59c0c67 "asus-wmi: Create quirk for airplane_m
ASUS_WMI_DSTS_USER_BIT avoids adding DMI-based quirks for at least
21 different laptops.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wmi.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus
On 7 February 2017 at 18:37, Andy Shevchenko wrote:
> On Tue, Feb 7, 2017 at 11:44 PM, João Paulo Rechi Vita
> wrote:
>> On 4 February 2017 at 10:02, Andy Shevchenko
>> wrote:
>>> On Wed, Feb 1, 2017 at 2:20 PM, João Paulo Rechi Vita
>>> wrote:
&g
|
Return (Zero) |
} |
} |
} |
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 57 ++--
1 file changed, 42 insertions(+), 15 deletions(-)
diff --git a/driv
On 4 February 2017 at 10:02, Andy Shevchenko wrote:
> On Wed, Feb 1, 2017 at 2:20 PM, João Paulo Rechi Vita
> wrote:
>> On 27 January 2017 at 10:26, Andy Shevchenko
>> wrote:
>>> On Thu, Jan 26, 2017 at 5:00 PM, João Paulo Rechi Vita
>>> wrote:
>
&
On 4 February 2017 at 10:35, Andy Shevchenko wrote:
> On Wed, Feb 1, 2017 at 2:23 PM, João Paulo Rechi Vita
> wrote:
>> On 27 January 2017 at 10:36, Andy Shevchenko
>> wrote:
>>> On Thu, Jan 26, 2017 at 5:30 PM, João Paulo Rechi Vita
>>> wrote:
>
> F
Fix identation problem introduced when this driver was first merged into
the kernel.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wireless.c
b/drivers/platform/x86
free.
This problem was seen on a Acer TravelMate P449-G2-MG.
Thanks to Daniel Drake for helping investigating this problem.
Signed-off-by: João Paulo Rechi Vita
---
drivers/acpi/acpica/nsrepair2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wireless.c
b/drivers/platform/x86/asus-wireless.c
index 9f31bc1a47d0..a7ee18383146 100644
--- a/drivers/platform/x86/asus
On 27 January 2017 at 10:28, Andy Shevchenko wrote:
> On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita
> wrote:
>> Signed-off-by: João Paulo Rechi Vita
>> ---
>> drivers/platform/x86/asus-wireless.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion
On 27 January 2017 at 10:36, Andy Shevchenko wrote:
> On Thu, Jan 26, 2017 at 5:30 PM, João Paulo Rechi Vita
> wrote:
>> Signed-off-by: João Paulo Rechi Vita
>> ---
>> drivers/platform/x86/asus-wireless.c | 15 ++-
>> drivers/platform/x86/asus-wireless
On 27 January 2017 at 10:37, Andy Shevchenko wrote:
> On Thu, Jan 26, 2017 at 5:30 PM, João Paulo Rechi Vita
> wrote:
>> This quirk avoids the conflicting usage of ASUS_WMI_DEVID_WLAN_LED
>> (0x00010002)
>> by both asus-wireless and asus-wmi on machines where the BIOS
On 27 January 2017 at 10:26, Andy Shevchenko wrote:
> On Thu, Jan 26, 2017 at 5:00 PM, João Paulo Rechi Vita
> wrote:
>> Some Asus machines use 0x4/0x5 as their LED on/off values, while others use
>> 0x0/0x1, as shown in the DSDT exerpts below (note "Arg0 == 0x02&quo
On 26 January 2017 at 17:45, Joe Perches wrote:
> On Thu, 2017-01-26 at 10:30 -0500, João Paulo Rechi Vita wrote:
>> Some Asus laptops that have an airplane-mode indicator LED, also have
>> the WMI WLAN user bit set, and the following bits in their DSDT:
>
> style triv
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 15 ++-
drivers/platform/x86/asus-wireless.h | 10 ++
2 files changed, 16 insertions(+), 9 deletions(-)
create mode 100644 drivers/platform/x86/asus-wireless.h
diff --git a/drivers/platform/x86
This reverts commit 2d735244b798f0c8bf93ace1facfafdc1f7a4e6e.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index 5e088fbef5ad
dependency between the modules.
Any advice on alternatives here are welcome.
PS: I don't think asus-wireless.h needs to also be listed in MAINTAINERS,
please correct me if I'm wrong.
João Paulo Rechi Vita (8):
Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA
This reverts commit 02db9ff7af18f7ace60f430cbbaa1d846b350916.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index 9d686d642934
This reverts commit a977e59c0c67c9d492bb16677ce66d67cae0ebd8.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 13 -
drivers/platform/x86/asus-wmi.c| 8 +++-
drivers/platform/x86/asus-wmi.h| 1 -
3 files changed, 3 insertions(+), 19
This reverts commit 6b7ff2af5286a8c6bec7ff5f4df62e3506c1674e.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index 5bf1dd225788
This reverts commit 56a37a72002b1eb01a1de391cf66383652784e78.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index
This reverts commit a961a285b479977fa21f12f71cd62f28adaba17c.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index
avoids adding DMI-based quirks for at least 21
different laptops.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wmi.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus
that would avoid looping through
device_ids[] in asus_wireless_add(). I'm happy to try suggestions to improve
that.
João Paulo Rechi Vita (1):
asus-wireless: Use the correct HSWC parameter for each HID
drivers/platform/x86/asus-wireless.c | 46 ++--
1 file c
|
Return (Zero) |
} |
} |
} |
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 46 ++--
1 fi
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-wireless.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wireless.c
b/drivers/platform/x86/asus-wireless.c
index 9f31bc1a47d0..c9b5ac152cf1 100644
--- a/drivers/platform/x86/asus
ext4_readdir+0x5e1/0x8b0
[] iterate_dir+0x92/0x120
[] SyS_getdents+0x98/0x110
[] ? iterate_dir+0x120/0x120
[] entry_SYSCALL_64_fastpath+0x16/0x71
FIX kmalloc-64: Restoring 0x880264083273-0x88026408329e=0x6b
FIX kmalloc-64: Marking all objects used
Signed-off-by: João Paulo Rechi Vita
On 13 June 2016 at 17:01, Pavel Machek wrote:
> On Mon 2016-06-13 15:59:35, João Paulo Rechi Vita wrote:
>> On 13 June 2016 at 15:00, Pavel Machek wrote:
>> > Hi!
>> >
>> >> > João, that means you should send a patch to add the ::rfkill suffix.
&g
oing to be
merged. So the new plan is now to simply expose the LED to userspace
under a meaningful name ("asus-wireless::airplane") and have the
userspace people look for LEDs with this suffix and drive then
accordingly.
I have just sent an updated patchset.
--
João Paulo Rechi Vita
http://about.me/jprvita
ven according to
userspace's policy.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/Kconfig | 2 +
drivers/platform/x86/asus-wireless.c | 91 +++-
2 files changed, 92 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconf
registering RFKill switches at all for this laptop and allows
asus-wireless to drive the LED through the ASHS ACPI device.
Signed-off-by: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b
registering RFKill switches at
all for this laptop and allows asus-wireless to drive the LED through
the ASHS ACPI device. This laptop already has a quirk for setting
WAPF=4, so this commit creates a new quirk, quirk_no_rfkill_wapf4, which
both disables rfkill and sets WAPF=4.
Signed-off-by: João Paulo
registering RFKill switches at all for this laptop and allows
asus-wireless to drive the LED through the ASHS ACPI device.
Signed-off-by: João Paulo Rechi Vita
Reported-by: Ming Shuo Chiu
---
drivers/platform/x86/asus-nb-wmi.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers
k for airplane_mode
LED" for more details).
João Paulo Rechi Vita (7):
asus-wireless: Toggle airplane mode LED
asus-wmi: Create quirk for airplane_mode LED
asus-wmi: Add quirk_no_rfkill for the Asus N552VW
asus-wmi: Add quirk_no_rfkill for the Asus U303LB
asus-wmi: Add quirk_no_rfki
: João Paulo Rechi Vita
---
drivers/platform/x86/asus-nb-wmi.c | 13 +
drivers/platform/x86/asus-wmi.c| 8 +---
drivers/platform/x86/asus-wmi.h| 1 +
3 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86
registering RFKill switches at
all for this laptop and allows asus-wireless to drive the LED through
the ASHS ACPI device. This laptop already has a quirk for setting
WAPF=4, so this commit creates a new quirk, quirk_no_rfkill_wapf4, which
both disables rfkill and sets WAPF=4.
Signed-off-by: João Paulo
registering RFKill switches at all for this laptop and allows
asus-wireless to drive the LED through the ASHS ACPI device.
Signed-off-by: João Paulo Rechi Vita
Reported-by: Mousou Yuu
---
drivers/platform/x86/asus-nb-wmi.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/platform
s/class/rfkill
> /sys/module/rfkill
>
If we use "rfkill" as a suffix, how do you expect userspace to be able
to differentiate between a LED that indicates airplane-mode (LED ON
when all radios are OFF) and a LED that indicates the state of a
specific radio like WiFi or Bluetooth (LED ON when that specific radio
is ON)? If we're going this route we should provide meaningful
information here.
--
João Paulo Rechi Vita
http://about.me/jprvita
his is now contained in the platform-drivers-x86 subsystem. Thanks
Johannes for your patience and help designing and reviewing the rfkill
changes, even if not all of them made it through in the end. And
thanks everyone else involved for the feedback.
Best regards,
--
João Paulo Rechi Vita
http://about.me/jprvita
On 25 May 2016 at 03:13, Corentin Chary wrote:
> On Mon, Feb 8, 2016 at 6:05 PM, João Paulo Rechi Vita
> wrote:
>> Some Asus laptops that have an "airplane mode" indicator LED, also have
>> the WMI WLAN user bit set, and the following bits in
From: João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita
---
Documentation/rfkill.txt| 3 +++
include/uapi/linux/rfkill.h | 4 ++--
net/rfkill/core.c | 13 +
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/Documentation/rfkill.txt b
From: João Paulo Rechi Vita
Provide an interface for the airplane-mode indicator be controlled from
userspace. User has to first acquire the control through
RFKILL_OP_AIRPLANE_MODE_INDICATOR_ACQUIRE and keep the fd open for the
whole time it wants to be in control of the indicator. Closing the
From: João Paulo Rechi Vita
This creates a new LED trigger to be used by platform drivers as a
default trigger for airplane-mode indicator LEDs.
By default this trigger will fire when RFKILL_OP_CHANGE_ALL is called
for all types (RFKILL_TYPE_ALL), setting the LED brightness to LED_FULL
when the
k 577/1880
PASS rfkill_wpa2_psk 0.330014 2016-04-29 12:48:59.016711
João Paulo Rechi Vita (3):
rfkill: Create "rfkill-airplane-mode" LED trigger
rfkill: Userspace control for airplane mode
rfkill: Notify userspace of airplane-mode state changes
Documentation/rfkill.txt| 15 +++
in
Hello Johannes,
On 1 March 2016 at 11:15, João Paulo Rechi Vita wrote:
> On 1 March 2016 at 08:43, Johannes Berg wrote:
>>
>> I'm fine with Jouni's change, preserving the original behaviour of
>> requiring TYPE_ALL or the correct type, but I'm tempted to simp
ANGE)
> continue;
>
> to ignore the type entirely.
>
> I'm fine with Jouni's change, preserving the original behaviour of
> requiring TYPE_ALL or the correct type, but I'm tempted to simply
> remove the type check entirely.
>
> Thoughts?
>
I think this patch should keep the original logic, as this is supposed
to be a refactor only. If we decide to remove the check, we should to
it in a separate patch, to make it clear for someone looking at the
history later.
I'm fine with removing the type check (in a separate patch), but I
don't see much gain in doing so.
--
João Paulo Rechi Vita
http://about.me/jprvita
Hello Jouni,
On 26 February 2016 at 12:59, Jouni Malinen wrote:
> On Mon, Feb 22, 2016 at 11:36:39AM -0500, João Paulo Rechi Vita wrote:
>> Using a switch to handle different ev.op values in rfkill_fop_write()
>> makes the code easier to extend, as out-of-range values can always b
On 22 February 2016 at 12:00, Dan Williams wrote:
> On Mon, 2016-02-22 at 11:36 -0500, João Paulo Rechi Vita wrote:
>> This series implements an airplane-mode indicator LED trigger, which
>> can be
>> used by platform drivers. The default policy have have airplane-mode
&
.
To change state of the indicator, the
RFKILL_OP_AIRPLANE_MODE_INDICATOR_CHANGE operation is used, passing the
value on "struct rfkill_event.soft". If the caller has not acquired the
airplane-mode control beforehand, the operation fails.
Signed-off-by: João Paulo Rechi Vita
---
Doc
Factor all assignments to rfkill_global_states[].cur into a single
function rfkill_update_global_state().
Signed-off-by: João Paulo Rechi Vita
---
net/rfkill/core.c | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/net/rfkill/core.c b
There is still quite a bit of code using this interface, so we can't
just remove it. Hopefully it will be possible in the future, but since
its scheduled removal date is past 2 years already, we are better having
the documentation reflecting the current state of things.
Signed-off-by: João
Using a switch to handle different ev.op values in rfkill_fop_write()
makes the code easier to extend, as out-of-range values can always be
handled by the default case.
Signed-off-by: João Paulo Rechi Vita
---
net/rfkill/core.c | 32 ++--
1 file changed, 18
RFKILL_OP_AIRPLANE_MODE_RELEASE restores the default policy.
To change state of the indicator, the RFKILL_OP_AIRPLANE_MODE_CHANGE
operation is used, passing the value on "struct rfkill_event.soft". If
the caller has not acquired the airplane-mode control beforehand, the
operation fails.
Signed-off-by: João Paulo
Signed-off-by: João Paulo Rechi Vita
---
Documentation/rfkill.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/rfkill.txt b/Documentation/rfkill.txt
index 2ee6ef9..1f0c270 100644
--- a/Documentation/rfkill.txt
+++ b/Documentation/rfkill.txt
@@ -83,6 +83,8 @@ rfkill drivers
Signed-off-by: João Paulo Rechi Vita
---
net/rfkill/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index a805831..ffbc375 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -282,8 +282,8 @@ static void rfkill_set_block
1 - 100 of 149 matches
Mail list logo
