[PATCH 2/2] IB/ehca: Add PMA support

2008-01-25 Thread Joachim Fenkes
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]> This patch enables ehca to redirect any PMA queries to the actual PMA QP. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> Reviewed-by: Joachim Fenkes <[EMAIL PROTECTED]> Reviewed-by: Christoph Raisch <[EMAIL PROTECTED]> --

[PATCH 1/2] IB/ehca: Update sma_attr also in case of disruptive config change

2008-01-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_irq.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c index 863b34f..b5ca94c 100644 --- a/d

[PATCH 0/2] IB/ehca: PMA support and a minor fix

2008-01-25 Thread Joachim Fenkes
and apply for 2.6.25 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany eMail: [EMAIL

[PATCH 2/2] IB/ehca: Add PMA support

2008-01-25 Thread Joachim Fenkes
From: Hoang-Nam Nguyen [EMAIL PROTECTED] This patch enables ehca to redirect any PMA queries to the actual PMA QP. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] Reviewed-by: Joachim Fenkes [EMAIL PROTECTED] Reviewed-by: Christoph Raisch [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca

[PATCH 1/2] IB/ehca: Update sma_attr also in case of disruptive config change

2008-01-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_irq.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c index 863b34f..b5ca94c 100644 --- a/drivers/infiniband

[PATCH 0/2] IB/ehca: PMA support and a minor fix

2008-01-25 Thread Joachim Fenkes
and apply for 2.6.25 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany eMail: [EMAIL

[PATCH] IB/ehca: Prevent sending UD packets to QP0

2008-01-24 Thread Joachim Fenkes
-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_reqs.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c b/drivers/infiniband/hw/ehca/ehca_reqs.c index 3aacc8c..2ce8cff 100644 --- a/drivers/infiniband/h

[PATCH] IB/ehca: Prevent sending UD packets to QP0

2008-01-24 Thread Joachim Fenkes
-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_reqs.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c b/drivers/infiniband/hw/ehca/ehca_reqs.c index 3aacc8c..2ce8cff 100644 --- a/drivers/infiniband/hw/ehca

[PATCH 4/4] IB/ehca: Prevent RDMA-related connection failures

2008-01-17 Thread Joachim Fenkes
an empty (size 0) RDMA Read into the message stream every now and then if the consumer doesn't post them frequently enough. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_classes.h |5 ++ drivers/infiniband/hw/ehca/ehca_qp.c | 14 +++- d

[PATCH 3/4] IB/ehca: Add "port connection autodetect mode"

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]> This patch enhances ehca with a capability to "autodetect" the ports being connected physically. In order to utilize that function the module option nr_ports must be set to -1 (default is 2 - two ports). This feature is experimental and will made the

[PATCH 2/4] IB/ehca: Define array to store SMI/GSI QPs

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- drivers/infiniband/hw/ehca/ehca_main.c|6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_classes.h

[PATCH 1/4] IB/ehca: Remove CQ-QP-link before destroying QP in error path of create_qp()

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_qp.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c b/drivers/infiniband/hw/ehca/ehca_qp.c index f116eb7..26c6a94

[PATCH 0/4] IB/ehca: fixes, port connectivity autodetection, problem workaround

2008-01-17 Thread Joachim Fenkes
workaround The patches will apply, in order, on top of Roland's for-2.6.25 branch. Please review them and apply for 2.6.25 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH -- Dept. 3627

[PATCH 3/4] IB/ehca: Add port connection autodetect mode

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen [EMAIL PROTECTED] This patch enhances ehca with a capability to autodetect the ports being connected physically. In order to utilize that function the module option nr_ports must be set to -1 (default is 2 - two ports). This feature is experimental and will made the default

[PATCH 2/4] IB/ehca: Define array to store SMI/GSI QPs

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen hnguyen at de.ibm.com Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- drivers/infiniband/hw/ehca/ehca_main.c|6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 0/4] IB/ehca: fixes, port connectivity autodetection, problem workaround

2008-01-17 Thread Joachim Fenkes
workaround The patches will apply, in order, on top of Roland's for-2.6.25 branch. Please review them and apply for 2.6.25 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH -- Dept. 3627

[PATCH 1/4] IB/ehca: Remove CQ-QP-link before destroying QP in error path of create_qp()

2008-01-17 Thread Joachim Fenkes
From: Hoang-Nam Nguyen hnguyen at de.ibm.com Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_qp.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c b/drivers/infiniband/hw/ehca/ehca_qp.c index

[PATCH 4/4] IB/ehca: Prevent RDMA-related connection failures

2008-01-17 Thread Joachim Fenkes
an empty (size 0) RDMA Read into the message stream every now and then if the consumer doesn't post them frequently enough. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |5 ++ drivers/infiniband/hw/ehca/ehca_qp.c | 14 +++- drivers/infiniband

RE: [ofa-general] Re: [ewg] Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-13 Thread Joachim Fenkes
"Caitlin Bestler" <[EMAIL PROTECTED]> wrote on 13.12.2007 22:08:34: > To clarify, an FMR Work Request is simply posted to the SendQ like > any other Work Request (of course the QP has to be privileged, or > it will complete in error). An SQ Post should never block. This would require hardware

Re: [ofa-general] Re: [ewg] Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-13 Thread Joachim Fenkes
[EMAIL PROTECTED] wrote on 13.12.2007 20:22:49: > On Dec 13, 2007 12:30 AM, Or Gerlitz <[EMAIL PROTECTED]> wrote: > > The current implementation of the open iscsi initiator makes sure to > > issue commands in thread (sleepable) context, see iscsi_xmitworker and > > references to it in

[PATCH] IB/ehca: Fix lock flag location, bump version number

2007-12-13 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- This addresses a comment of Roland and bumps the version number. If it's not too late, please apply for 2.6.24. Thanks! drivers/infiniband/hw/ehca/ehca_classes.h |1 + drivers/infiniband/hw/ehca/ehca_main.c|2 +- d

[PATCH] IB/ehca: Fix lock flag location, bump version number

2007-12-13 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This addresses a comment of Roland and bumps the version number. If it's not too late, please apply for 2.6.24. Thanks! drivers/infiniband/hw/ehca/ehca_classes.h |1 + drivers/infiniband/hw/ehca/ehca_main.c|2 +- drivers/infiniband

Re: [ofa-general] Re: [ewg] Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-13 Thread Joachim Fenkes
[EMAIL PROTECTED] wrote on 13.12.2007 20:22:49: On Dec 13, 2007 12:30 AM, Or Gerlitz [EMAIL PROTECTED] wrote: The current implementation of the open iscsi initiator makes sure to issue commands in thread (sleepable) context, see iscsi_xmitworker and references to it in

RE: [ofa-general] Re: [ewg] Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-13 Thread Joachim Fenkes
Caitlin Bestler [EMAIL PROTECTED] wrote on 13.12.2007 22:08:34: To clarify, an FMR Work Request is simply posted to the SendQ like any other Work Request (of course the QP has to be privileged, or it will complete in error). An SQ Post should never block. This would require hardware support,

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-11 Thread Joachim Fenkes
Roland Dreier <[EMAIL PROTECTED]> wrote on 10.12.2007 22:47:37: > It's a big problem. If you cannot implement FMRs in such a way that > you can handling having map_phys_fmr being called in a context that > can't sleep, then I think the only option is to remove your FMR > support. That's kind of

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-11 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 10.12.2007 22:47:37: It's a big problem. If you cannot implement FMRs in such a way that you can handling having map_phys_fmr being called in a context that can't sleep, then I think the only option is to remove your FMR support. That's kind of what

[PATCH] IB/ehca: Serialize HCA-related hCalls if necessary

2007-12-10 Thread Joachim Fenkes
Several pSeries firmware versions share a rare locking issue in the HCA-related hCalls. Check for a feature flag that indicates the issue being fixed and serialize all HCA hCalls if not. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- This is the revised version of my previous patch,

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-10 Thread Joachim Fenkes
Hi, guys, > We're taking this to the firmware architects at the moment, but they're not > very fond of the idea of reporting the absence of bugs through capability > flags, as this could quickly lead to the exhaustion of flag bits. We'll let > the discussion stew for a bit, but if we don't

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-10 Thread Joachim Fenkes
On Monday 10 December 2007 00:22, Roland Dreier wrote: > Fair enough... according to Documentation/infiniband/core_locking.txt, > the only driver methods that cannot sleep are: > > [...] > map_phys_fmr In fact, we do use hCalls there. Our hardware doesn't actually support FMRs, so we

[PATCH] IB/ehca: Return correct #SGEs for SRQ

2007-12-10 Thread Joachim Fenkes
Firmware would round up the number of SGEs to four, because the WQE structure holds four SGEs. For SRQ, only three are supported, so return a fixed value instead. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- The patch will apply cleanly on top of Roland's git. Please review and

[PATCH] IB/ehca: Return correct #SGEs for SRQ

2007-12-10 Thread Joachim Fenkes
Firmware would round up the number of SGEs to four, because the WQE structure holds four SGEs. For SRQ, only three are supported, so return a fixed value instead. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- The patch will apply cleanly on top of Roland's git. Please review and apply

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-10 Thread Joachim Fenkes
On Monday 10 December 2007 00:22, Roland Dreier wrote: Fair enough... according to Documentation/infiniband/core_locking.txt, the only driver methods that cannot sleep are: [...] map_phys_fmr In fact, we do use hCalls there. Our hardware doesn't actually support FMRs, so we

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-10 Thread Joachim Fenkes
Hi, guys, We're taking this to the firmware architects at the moment, but they're not very fond of the idea of reporting the absence of bugs through capability flags, as this could quickly lead to the exhaustion of flag bits. We'll let the discussion stew for a bit, but if we don't get

[PATCH] IB/ehca: Serialize HCA-related hCalls if necessary

2007-12-10 Thread Joachim Fenkes
Several pSeries firmware versions share a rare locking issue in the HCA-related hCalls. Check for a feature flag that indicates the issue being fixed and serialize all HCA hCalls if not. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This is the revised version of my previous patch, which

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-07 Thread Joachim Fenkes
Roland Dreier <[EMAIL PROTECTED]> wrote on 06.12.2007 19:27:09: > > > + ehca_lock_hcalls = !(cur_cpu_spec->cpu_user_features > > > +& PPC_FEATURE_ARCH_2_05); > > > We already talked about this yesterday, but I still feel that checking the >

Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-07 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 06.12.2007 19:27:09: + ehca_lock_hcalls = !(cur_cpu_spec-cpu_user_features + PPC_FEATURE_ARCH_2_05); We already talked about this yesterday, but I still feel that checking the instruction

[PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-06 Thread Joachim Fenkes
-related hCalls on POWER5. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- We tested this patch, especially the autodetection, and it works okay. Please review and apply for 2.6.24-rc5 - thanks! drivers/infiniband/hw/ehca/ehca_main.c | 16 drivers/infiniband/h

[PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5

2007-12-06 Thread Joachim Fenkes
-related hCalls on POWER5. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- We tested this patch, especially the autodetection, and it works okay. Please review and apply for 2.6.24-rc5 - thanks! drivers/infiniband/hw/ehca/ehca_main.c | 16 drivers/infiniband/hw/ehca

[PATCH] IB/ehca: Fix static rate if path faster than link

2007-11-28 Thread Joachim Fenkes
The formula would yield -1 for this, which is wrong in a bad way (max throttling). Clamp to 0, which is the correct value. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- This fixes another regression introduced in rc3. Please review and apply for 2.6.24-rc4. Thanks! drivers/infi

[PATCH] IB/ehca: Fix static rate if path faster than link

2007-11-28 Thread Joachim Fenkes
The formula would yield -1 for this, which is wrong in a bad way (max throttling). Clamp to 0, which is the correct value. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- This fixes another regression introduced in rc3. Please review and apply for 2.6.24-rc4. Thanks! drivers/infiniband/hw

[PATCH] IB/ehca: Fix static rate regression

2007-11-22 Thread Joachim Fenkes
Wrong choice of port number caused modify_qp() to fail -- fixed. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- Please apply this for 2.6.24-rc4 as it fixes a regression introduced in rc3. Thanks! drivers/infiniband/hw/ehca/ehca_qp.c |4 ++-- 1 files changed, 2 insertions

[PATCH] IB/ehca: Fix static rate regression

2007-11-22 Thread Joachim Fenkes
Wrong choice of port number caused modify_qp() to fail -- fixed. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- Please apply this for 2.6.24-rc4 as it fixes a regression introduced in rc3. Thanks! drivers/infiniband/hw/ehca/ehca_qp.c |4 ++-- 1 files changed, 2 insertions(+), 2

[PATCH 2/2] IB/ehca: Fix static rate calculation

2007-11-02 Thread Joachim Fenkes
The IPD formula was a little off and assumed a fixed physical link rate; fix the formula and query the actual physical link rate, now that we can get it. Also, refactor the calculation into a common function ehca_calc_ipd() and use that instead of duplicating code. Signed-off-by: Joachim Fenkes

[PATCH 1/2] IB/ehca: Return physical link information in query_port()

2007-11-02 Thread Joachim Fenkes
Newer firmware versions return physical port information to the partition, so hand that information to the consumer if it's present. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_hca.c | 20 ++-- drivers/infiniband/hw/ehca/hip

[PATCH 0/2] IB/ehca: Return physical link information, fix static rate calculation

2007-11-02 Thread Joachim Fenkes
supported [2/2] fixes static rate calculation based on that info The patches will apply, in order, on top of Roland's for-2.6.24 branch. Please review them and apply for 2.6.24-rc2 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware

[PATCH 2/2] IB/ehca: Fix static rate calculation

2007-11-02 Thread Joachim Fenkes
The IPD formula was a little off and assumed a fixed physical link rate; fix the formula and query the actual physical link rate, now that we can get it. Also, refactor the calculation into a common function ehca_calc_ipd() and use that instead of duplicating code. Signed-off-by: Joachim Fenkes

[PATCH 0/2] IB/ehca: Return physical link information, fix static rate calculation

2007-11-02 Thread Joachim Fenkes
supported [2/2] fixes static rate calculation based on that info The patches will apply, in order, on top of Roland's for-2.6.24 branch. Please review them and apply for 2.6.24-rc2 if you think they're okay. Thanks and regards, Joachim -- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware

[PATCH 1/2] IB/ehca: Return physical link information in query_port()

2007-11-02 Thread Joachim Fenkes
Newer firmware versions return physical port information to the partition, so hand that information to the consumer if it's present. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_hca.c | 20 ++-- drivers/infiniband/hw/ehca/hipz_hw.h |6

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-17 Thread Joachim Fenkes
On Tuesday 16 October 2007 17:27, Stephen Rothwell wrote: > One small change - I intend to remove the name and owner fields from > struct of_platform_driver, so you should not bother initialising the name > field and just initialise the name field of the embedded struct > device_driver instead.

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-17 Thread Joachim Fenkes
On Tuesday 16 October 2007 17:27, Stephen Rothwell wrote: One small change - I intend to remove the name and owner fields from struct of_platform_driver, so you should not bother initialising the name field and just initialise the name field of the embedded struct device_driver instead.

[PATCH 5/5] IB/ehca: Enable large page MRs by default

2007-10-16 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_main.c b/drivers/infiniband/hw/ehca/ehca_main.c index d477dc3..2f51c13 100644 --- a/d

[PATCH 4/5] IB/ehca: Change meaning of hca_cap_mr_pgsize

2007-10-16 Thread Joachim Fenkes
ehca_shca.hca_cap_mr_pgsize now contains all supported page sizes ORed together. This makes some checks easier to code and understand, plus we can return this value verbatim in query_hca(), fixing a problem with SRP (reported by Anton Blanchard -- thanks!). Signed-off-by: Joachim Fenkes <[EM

[PATCH 3/5] IB/ehca: Fix ehca_encode_hwpage_size() and alloc_fmr()

2007-10-16 Thread Joachim Fenkes
Simplify ehca_encode_hwpage_size(), fixing an infinite loop for pgsize == 0 in the process. Fix the bug in alloc_fmr() that triggered the loop. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_mrmw.c | 15 --- 1 files changed, 4 inse

[PATCH 2/5] IB/ehca: Fix masking error in {,re}reg_phys_mr()

2007-10-16 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_mrmw.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c b/drivers/infiniband/hw/ehca/ehca_mrmw.c index da88738..16c9efd 100644 --- a/d

[PATCH 1/5] IB/ehca: Supply QP token for SRQ base QPs

2007-10-16 Thread Joachim Fenkes
Because hardware reports the SRQ token in RWQEs of SRQ base QPs, supply the base QP token as SRQ token, so we can properly find the SRQ base QP. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_qp.c |4 +++- 1 files changed, 3 insertions(+), 1 del

[PATCH 0/5] IB/ehca: SRQ and MR/MW fixes

2007-10-16 Thread Joachim Fenkes
hca_cap_mr_pgsize and fixes a problem with ib_srp [5/5] enables large page MRs by default I built the patches on top of Roland's for-2.6.24 git branch. Please review and queue them for 2.6.24-rc1 if you're okay with them. Thanks! Cheers, Joachim -- Joachim Fenkes  --  eHCA Linux Driver Developer

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-16 Thread Joachim Fenkes
vely. Match the external ibmebus > > > > interface and drivers using it. > > > > > > > > Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> > > > > > > This is somewhat difficult as this patch touches files that are the > > > re

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-16 Thread Joachim Fenkes
and drivers using it. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] This is somewhat difficult as this patch touches files that are the responsibility of three different maintainers. �Is it possible to split the patch into three, one for each maintainer (possibly

[PATCH 0/5] IB/ehca: SRQ and MR/MW fixes

2007-10-16 Thread Joachim Fenkes
hca_cap_mr_pgsize and fixes a problem with ib_srp [5/5] enables large page MRs by default I built the patches on top of Roland's for-2.6.24 git branch. Please review and queue them for 2.6.24-rc1 if you're okay with them. Thanks! Cheers, Joachim -- Joachim Fenkes  --  eHCA Linux Driver Developer

[PATCH 1/5] IB/ehca: Supply QP token for SRQ base QPs

2007-10-16 Thread Joachim Fenkes
Because hardware reports the SRQ token in RWQEs of SRQ base QPs, supply the base QP token as SRQ token, so we can properly find the SRQ base QP. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_qp.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions

[PATCH 2/5] IB/ehca: Fix masking error in {,re}reg_phys_mr()

2007-10-16 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_mrmw.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c b/drivers/infiniband/hw/ehca/ehca_mrmw.c index da88738..16c9efd 100644 --- a/drivers

[PATCH 3/5] IB/ehca: Fix ehca_encode_hwpage_size() and alloc_fmr()

2007-10-16 Thread Joachim Fenkes
Simplify ehca_encode_hwpage_size(), fixing an infinite loop for pgsize == 0 in the process. Fix the bug in alloc_fmr() that triggered the loop. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_mrmw.c | 15 --- 1 files changed, 4 insertions(+), 11

[PATCH 4/5] IB/ehca: Change meaning of hca_cap_mr_pgsize

2007-10-16 Thread Joachim Fenkes
ehca_shca.hca_cap_mr_pgsize now contains all supported page sizes ORed together. This makes some checks easier to code and understand, plus we can return this value verbatim in query_hca(), fixing a problem with SRP (reported by Anton Blanchard -- thanks!). Signed-off-by: Joachim Fenkes [EMAIL

[PATCH 5/5] IB/ehca: Enable large page MRs by default

2007-10-16 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_main.c b/drivers/infiniband/hw/ehca/ehca_main.c index d477dc3..2f51c13 100644 --- a/drivers

[PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-26 Thread Joachim Fenkes
Replace struct ibmebus_dev and struct ibmebus_driver with struct of_device and struct of_platform_driver, respectively. Match the external ibmebus interface and drivers using it. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- d

[PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-26 Thread Joachim Fenkes
, the devtree is matched against its matchlist. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c | 100 +--- 1 files changed, 82 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/

[PATCH 5/5] ibmebus: More speaking error return code in ibmebus_store_probe()

2007-09-26 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index c1e2963..0bd186c 100644 --- a/arch/powerpc/kernel/ibmebus.c

[PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-26 Thread Joachim Fenkes
will be happy. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c | 199 ++--- 1 files changed, 6 insertions(+), 193 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index d

[PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-26 Thread Joachim Fenkes
of reinventing the wheel. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- include/asm-powerpc/of_device.h |4 ++ include/linux/of_device.h |5 ++ arch/powerpc/kernel/of_device.c | 80 + arch/powerpc/kernel/of_platform.c

[PATCH 0/5] [REPOST] PowerPC: ibmebus refactoring and fixes

2007-09-26 Thread Joachim Fenkes
|5 + 11 files changed, 228 insertions(+), 350 deletions(-) -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany eMail: [EMAIL PROTECTED

Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:27:57: > The patch looks good to me, especially since you did exactly what I > suggested ;-) Yes, our discussions were very productive. Thanks and sorry I forgot to mention your input. > Maybe the description should have another

Re: [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:29:51: > The description makes it sound like a git-bisect would get broken > by this patch, which should never happen. If the patch indeed > ends up with a broken kernel, it would be better to merge it with > the later patch that fixes the

Re: [PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-26 Thread Joachim Fenkes
> > +/* These devices will automatically be added to the bus during init */ > > +static struct of_device_id builtin_matches[] = { > > + { .name = "lhca" }, > > + { .compatible = "IBM,lhca" }, > > + { .name = "lhea" }, > > + { .compatible = "IBM,lhea" }, > > + {}, > > +}; > > + > > Hmm,

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:42:40: > This is missing a description, The description is "ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers" -- I thought that should be enough since the patch is rather straightforward. I can add a more

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann [EMAIL PROTECTED] wrote on 25.09.2007 16:42:40: This is missing a description, The description is ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers -- I thought that should be enough since the patch is rather straightforward. I can add a more

Re: [PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-26 Thread Joachim Fenkes
+/* These devices will automatically be added to the bus during init */ +static struct of_device_id builtin_matches[] = { + { .name = lhca }, + { .compatible = IBM,lhca }, + { .name = lhea }, + { .compatible = IBM,lhea }, + {}, +}; + Hmm, do you have devices that

Re: [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann [EMAIL PROTECTED] wrote on 25.09.2007 16:29:51: The description makes it sound like a git-bisect would get broken by this patch, which should never happen. If the patch indeed ends up with a broken kernel, it would be better to merge it with the later patch that fixes the code

Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann [EMAIL PROTECTED] wrote on 25.09.2007 16:27:57: The patch looks good to me, especially since you did exactly what I suggested ;-) Yes, our discussions were very productive. Thanks and sorry I forgot to mention your input. Maybe the description should have another sentence in

[PATCH 0/5] [REPOST] PowerPC: ibmebus refactoring and fixes

2007-09-26 Thread Joachim Fenkes
|5 + 11 files changed, 228 insertions(+), 350 deletions(-) -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany eMail: [EMAIL PROTECTED

[PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-26 Thread Joachim Fenkes
of reinventing the wheel. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- include/asm-powerpc/of_device.h |4 ++ include/linux/of_device.h |5 ++ arch/powerpc/kernel/of_device.c | 80 + arch/powerpc/kernel/of_platform.c | 70

[PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-26 Thread Joachim Fenkes
will be happy. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 199 ++--- 1 files changed, 6 insertions(+), 193 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index d6a38cd..cc80f84

[PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-26 Thread Joachim Fenkes
, the devtree is matched against its matchlist. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 100 +--- 1 files changed, 82 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel

[PATCH 5/5] ibmebus: More speaking error return code in ibmebus_store_probe()

2007-09-26 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index c1e2963..0bd186c 100644 --- a/arch/powerpc/kernel/ibmebus.c +++ b/arch

[PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-26 Thread Joachim Fenkes
Replace struct ibmebus_dev and struct ibmebus_driver with struct of_device and struct of_platform_driver, respectively. Match the external ibmebus interface and drivers using it. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- drivers/net

[PATCH 5/5] ibmebus: More speaking error return code in ibmebus_store_probe()

2007-09-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index 379472f..8c08a98 100644 --- a/arch/powerpc/kernel/ibmebus.c

[PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- drivers/net/ehea/ehea.h |2 +- include/asm-powerpc/ibmebus.h | 38 +++ arch/powerpc/kernel/ibmebus.c | 28 ++- d

[PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-25 Thread Joachim Fenkes
, the devtree is matched against its matchlist. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c | 97 ++--- 1 files changed, 81 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/

[PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-25 Thread Joachim Fenkes
ibmebus_{,un}register_driver() are replaced by dummy functions because ibmebus is temporarily unusable in this transitional state. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c | 199 ++--- 1 files changed, 6 inse

[PATCH 0/5] PowerPC: ibmebus refactoring and fixes

2007-09-25 Thread Joachim Fenkes
(-) -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany eMail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-k

[PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-25 Thread Joachim Fenkes
Extract generic of_device allocation code from of_platform_device_create() and move it into of_device.[ch], called of_device_alloc(). Also, there's now of_device_free() which puts the device node. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- include/asm-powerpc/of_device.h

[PATCH 0/5] PowerPC: ibmebus refactoring and fixes

2007-09-25 Thread Joachim Fenkes
(-) -- Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany eMail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-25 Thread Joachim Fenkes
Extract generic of_device allocation code from of_platform_device_create() and move it into of_device.[ch], called of_device_alloc(). Also, there's now of_device_free() which puts the device node. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- include/asm-powerpc/of_device.h |4

[PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-25 Thread Joachim Fenkes
, the devtree is matched against its matchlist. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 97 ++--- 1 files changed, 81 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel

[PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h |2 +- drivers/net/ehea/ehea.h |2 +- include/asm-powerpc/ibmebus.h | 38 +++ arch/powerpc/kernel/ibmebus.c | 28 ++- drivers

[PATCH 5/5] ibmebus: More speaking error return code in ibmebus_store_probe()

2007-09-25 Thread Joachim Fenkes
Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index 379472f..8c08a98 100644 --- a/arch/powerpc/kernel/ibmebus.c +++ b/arch

[PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-25 Thread Joachim Fenkes
ibmebus_{,un}register_driver() are replaced by dummy functions because ibmebus is temporarily unusable in this transitional state. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 199 ++--- 1 files changed, 6 insertions

Re: [PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change

2007-09-14 Thread Joachim Fenkes
Roland Dreier <[EMAIL PROTECTED]> wrote on 12.09.2007 22:21:54: > What happens if someone runs the new driver with older firmware? Or > what if someone upgrades the firmware without updating the driver? Thanks for pointing our noses to this. Your comment triggered some further internal

Re: [PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change

2007-09-14 Thread Joachim Fenkes
Roland Dreier [EMAIL PROTECTED] wrote on 12.09.2007 22:21:54: What happens if someone runs the new driver with older firmware? Or what if someone upgrades the firmware without updating the driver? Thanks for pointing our noses to this. Your comment triggered some further internal discussions

[PATCH 2/3] IB/umem: Add hugetlb flag to struct ib_umem

2007-09-13 Thread Joachim Fenkes
During ib_umem_get(), determine whether all pages from the memory region are hugetlb pages and report this in the "hugetlb" field. Low-level driver can use this information if they need it. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/co

[PATCH 3/3] IB/ehca: Make sure user pages are from hugetlb before using MR large pages

2007-09-13 Thread Joachim Fenkes
...because, on virtualized hardware like System p, we can't be sure that the physical pages behind them are contiguous. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_mrmw.c | 25 +++-- 1 files changed, 15 insertions(+), 10 del

  1   2   3   >