From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
This patch enables ehca to redirect any PMA queries to the
actual PMA QP.
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Reviewed-by: Joachim Fenkes <[EMAIL PROTECTED]>
Reviewed-by: Christoph Raisch <[EMAIL PROTECTED]>
--
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_irq.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c
b/drivers/infiniband/hw/ehca/ehca_irq.c
index 863b34f..b5ca94c 100644
--- a/d
them and apply for 2.6.25 if you think they're okay.
Thanks and regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMa
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_reqs.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c
b/drivers/infiniband/hw/ehca/ehca_reqs.c
index 3aacc8c..2ce8cff 100644
--- a/drive
empty (size 0) RDMA Read into
the message stream every now and then if the consumer doesn't post them
frequently enough.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |5 ++
drivers/infiniband/hw/ehca/ehca_qp.c | 14 ++
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
This patch enhances ehca with a capability to "autodetect" the ports being
connected physically. In order to utilize that function the module option
nr_ports must be set to -1 (default is 2 - two ports). This feature is
experimental and will made the defa
From: Hoang-Nam Nguyen
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |2 +-
drivers/infiniband/hw/ehca/ehca_main.c|6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_classes.h
b
From: Hoang-Nam Nguyen
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c
b/drivers/infiniband/hw/ehca/ehca_qp.c
index f116eb7..26c6a94 100
workaround
The patches will apply, in order, on top of Roland's for-2.6.25 branch.
Please review them and apply for 2.6.25 if you think they're okay.
Thanks and regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH --
"Caitlin Bestler" <[EMAIL PROTECTED]> wrote on 13.12.2007
22:08:34:
> To clarify, an FMR Work Request is simply posted to the SendQ like
> any other Work Request (of course the QP has to be privileged, or
> it will complete in error). An SQ Post should never block.
This would require hardware su
[EMAIL PROTECTED] wrote on 13.12.2007 20:22:49:
> On Dec 13, 2007 12:30 AM, Or Gerlitz <[EMAIL PROTECTED]> wrote:
> > The current implementation of the open iscsi initiator makes sure to
> > issue commands in thread (sleepable) context, see iscsi_xmitworker and
> > references to it in drivers/scsi
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This addresses a comment of Roland and bumps the version number. If it's not
too late, please apply for 2.6.24. Thanks!
drivers/infiniband/hw/ehca/ehca_classes.h |1 +
drivers/infiniband/hw/ehca/ehca_main.c|2
Roland Dreier <[EMAIL PROTECTED]> wrote on 10.12.2007 22:47:37:
> It's a big problem. If you cannot implement FMRs in such a way that
> you can handling having map_phys_fmr being called in a context that
> can't sleep, then I think the only option is to remove your FMR
> support.
That's kind of
Several pSeries firmware versions share a rare locking issue in the
HCA-related hCalls. Check for a feature flag that indicates the issue being
fixed and serialize all HCA hCalls if not.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This is the revised version of my previous patch,
Hi, guys,
> We're taking this to the firmware architects at the moment, but they're
not
> very fond of the idea of reporting the absence of bugs through
capability
> flags, as this could quickly lead to the exhaustion of flag bits. We'll
let
> the discussion stew for a bit, but if we don't g
On Monday 10 December 2007 00:22, Roland Dreier wrote:
> Fair enough... according to Documentation/infiniband/core_locking.txt,
> the only driver methods that cannot sleep are:
>
> [...]
> map_phys_fmr
In fact, we do use hCalls there. Our hardware doesn't actually support FMRs,
so we tran
Firmware would round up the number of SGEs to four, because the WQE
structure holds four SGEs. For SRQ, only three are supported, so return a
fixed value instead.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
The patch will apply cleanly on top of Roland's git. Please revie
Roland Dreier <[EMAIL PROTECTED]> wrote on 06.12.2007 19:27:09:
> > > + ehca_lock_hcalls =
!(cur_cpu_spec->cpu_user_features
> > > +& PPC_FEATURE_ARCH_2_05);
>
> > We already talked about this yesterday, but I still feel that
checking the
>
-related hCalls on POWER5.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
We tested this patch, especially the autodetection, and it works okay.
Please review and apply for 2.6.24-rc5 - thanks!
drivers/infiniband/hw/ehca/ehca_main.c | 16
drivers/infiniband/h
The formula would yield -1 for this, which is wrong in a bad way (max
throttling). Clamp to 0, which is the correct value.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This fixes another regression introduced in rc3.
Please review and apply for 2.6.24-rc4. Thanks!
drivers/infi
Wrong choice of port number caused modify_qp() to fail -- fixed.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
Please apply this for 2.6.24-rc4 as it fixes a regression introduced in rc3.
Thanks!
drivers/infiniband/hw/ehca/ehca_qp.c |4 ++--
1 files changed, 2 insertions
The IPD formula was a little off and assumed a fixed physical link rate; fix
the formula and query the actual physical link rate, now that we can get it.
Also, refactor the calculation into a common function ehca_calc_ipd() and
use that instead of duplicating code.
Signed-off-by: Joachim Fenkes
Newer firmware versions return physical port information to the partition,
so hand that information to the consumer if it's present.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_hca.c | 20 ++--
drivers/infiniband/hw/ehc
supported
[2/2] fixes static rate calculation based on that info
The patches will apply, in order, on top of Roland's for-2.6.24 branch.
Please review them and apply for 2.6.24-rc2 if you think they're okay.
Thanks and regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer an
On Tuesday 16 October 2007 17:27, Stephen Rothwell wrote:
> One small change - I intend to remove the name and owner fields from
> struct of_platform_driver, so you should not bother initialising the name
> field and just initialise the name field of the embedded struct
> device_driver instead. T
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_main.c
b/drivers/infiniband/hw/ehca/ehca_main.c
index d477dc3..2f51c13 100644
--- a/d
ehca_shca.hca_cap_mr_pgsize now contains all supported page sizes ORed
together. This makes some checks easier to code and understand, plus we can
return this value verbatim in query_hca(), fixing a problem with SRP
(reported by Anton Blanchard -- thanks!).
Signed-off-by: Joachim Fenkes <[EM
Simplify ehca_encode_hwpage_size(), fixing an infinite loop for pgsize == 0
in the process. Fix the bug in alloc_fmr() that triggered the loop.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 15 ---
1 files changed, 4 inse
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c
b/drivers/infiniband/hw/ehca/ehca_mrmw.c
index da88738..16c9efd 100644
--- a/d
Because hardware reports the SRQ token in RWQEs of SRQ base QPs, supply the
base QP token as SRQ token, so we can properly find the SRQ base QP.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c |4 +++-
1 files changed, 3 insertions(+), 1 del
hca_cap_mr_pgsize and fixes a problem with ib_srp
[5/5] enables large page MRs by default
I built the patches on top of Roland's for-2.6.24 git branch. Please review
and queue them for 2.6.24-rc1 if you're okay with them. Thanks!
Cheers,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Dev
vely. Match the external
ibmebus
> > > > interface and drivers using it.
> > > >
> > > > Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
> > >
> > > This is somewhat difficult as this patch touches files that are the
> > > respon
Replace struct ibmebus_dev and struct ibmebus_driver with struct of_device
and struct of_platform_driver, respectively. Match the external ibmebus
interface and drivers using it.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |2 +-
d
,
the devtree is matched against its matchlist.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c | 100 +---
1 files changed, 82 insertions(+), 18 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index c1e2963..0bd186c 100644
--- a/arch/powerpc/kernel/ibmebus.c
will
be happy.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c | 199 ++---
1 files changed, 6 insertions(+), 193 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index d
stead of reinventing the wheel.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
include/asm-powerpc/of_device.h |4 ++
include/linux/of_device.h |5 ++
arch/powerpc/kernel/of_device.c | 80 +
arch/powerpc/kernel/of_platfo
nux/of_device.h |5 +
11 files changed, 228 insertions(+), 350 deletions(-)
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: [
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:27:57:
> The patch looks good to me, especially since you did exactly what I
> suggested ;-)
Yes, our discussions were very productive. Thanks and sorry I forgot to
mention your input.
> Maybe the description should have another sentence
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:29:51:
> The description makes it sound like a git-bisect would get broken
> by this patch, which should never happen. If the patch indeed
> ends up with a broken kernel, it would be better to merge it with
> the later patch that fixes the c
> > +/* These devices will automatically be added to the bus during init
*/
> > +static struct of_device_id builtin_matches[] = {
> > + { .name = "lhca" },
> > + { .compatible = "IBM,lhca" },
> > + { .name = "lhea" },
> > + { .compatible = "IBM,lhea" },
> > + {},
> > +};
> > +
>
> Hmm,
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:42:40:
> This is missing a description,
The description is "ibmebus: Move to of_device and of_platform_driver,
match eHCA and eHEA drivers" -- I thought that should be enough since the
patch is rather straightforward. I can add a more det
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index 379472f..8c08a98 100644
--- a/arch/powerpc/kernel/ibmebus.c
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |2 +-
drivers/net/ehea/ehea.h |2 +-
include/asm-powerpc/ibmebus.h | 38 +++
arch/powerpc/kernel/ibmebus.c | 28 ++-
d
,
the devtree is matched against its matchlist.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c | 97 ++---
1 files changed, 81 insertions(+), 16 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/
ibmebus_{,un}register_driver() are replaced by dummy functions because
ibmebus is temporarily unusable in this transitional state.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c | 199 ++---
1 files changed, 6 inse
deletions(-)
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscri
Extract generic of_device allocation code from of_platform_device_create()
and move it into of_device.[ch], called of_device_alloc(). Also, there's now
of_device_free() which puts the device node.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
include/asm-powerpc/of_device
Roland Dreier <[EMAIL PROTECTED]> wrote on 12.09.2007 22:21:54:
> What happens if someone runs the new driver with older firmware? Or
> what if someone upgrades the firmware without updating the driver?
Thanks for pointing our noses to this. Your comment triggered some further
internal discussi
During ib_umem_get(), determine whether all pages from the memory region are
hugetlb pages and report this in the "hugetlb" field. Low-level driver can
use this information if they need it.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/co
...because, on virtualized hardware like System p, we can't be sure that the
physical pages behind them are contiguous.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 25 +++--
1 files changed, 15 insertions(+), 1
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_classes.h
b/drivers/infini
inally uses the hugetlb flag in ehca_reg_user_mr()
The patches should apply cleanly, in order, on top of my previous 12-patch
set. Please review the changes and apply the patches for 2.6.24 if they are
okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
Roland Dreier <[EMAIL PROTECTED]> wrote on 13.09.2007 06:33:45:
> > -#define HCA_CAP_MR_PGSIZE_4K 1
> > -#define HCA_CAP_MR_PGSIZE_64K 2
> > -#define HCA_CAP_MR_PGSIZE_1M 4
> > -#define HCA_CAP_MR_PGSIZE_16M 8
> > +#define HCA_CAP_MR_PGSIZE_4K 0x8000
> > +#define HCA_CAP_MR_PGSIZE_64K
size for modular
> build of this module, however, because these are no longer dropped
> unconditionally now.)
>
> Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Looks okay to me.
Acked-by: Joachim Fenkes <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send t
We can use raw_smp_processor_id() here because the processor ID is only used
for debug output and may therefore be preemption-unsafe.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This is the same patch, but with smp_processor_id() replaced by
raw_smp_processor_id(), as kindly p
On Tuesday 11 September 2007 16:51, Nathan Lynch wrote:
> > - get_paca()->paca_index, __FUNCTION__, \
> > + smp_processor_id(), __FUNCTION__, \
>
> I think I see these macros used in preemptible code (e.g. ehca_probe),
> where smp_processo
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
...because, on virtualized hardware like System p, we can't be sure that the
physical pages behind them are contiguous.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
Another patch for 2.6.24 that will apply cleanly on t
Nobody needed the SVNEHCA_ prefix anyway.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_main.c
b/drivers/infiniband/hw/ehca/ehca_
Some firmware levels exhibit a race condition between H_ALLOC_RESOURCE(MR)
and H_FREE_RESOURCE(MR). Work around this problem by locking these hvCalls
against each other.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/hcp_if.c
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_tools.h | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h
b/drivers/infiniband/hw/ehca/ehca_tools.h
index f9b264b..863f972
Rectify some modify_qp() issues related to path migration.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_irq.c |4 +-
drivers/infiniband/hw/ehca/ehca_qp.c | 90 -
2 files changed, 68 insertions(+), 26 del
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_tools.h |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h
b/drivers/infiniband/hw/ehca/ehca_tools.h
index 57c77a7..f9b264b 100644
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c | 14 +-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c
b/drivers/infiniband/hw/ehca/ehca_qp.c
index d2ab84a..7154f62 100644
...because -12 is easier to read than FFF4.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_cq.c | 14 +++---
drivers/infiniband/hw/ehca/ehca_hca.c|2 +-
drivers/infiniband/hw/ehca/ehca_main.c | 24 +-
drivers/infiniband/h
Change hvcall trace output towards better readability: reg numbers instead
of argument numbers, return code as signed decimal instead of unsigned hex.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/hcp_if.c | 57 ++
1
From: Stefan Roscher <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_cq.c |7 ++-
drivers/infiniband/hw/ehca/ehca_main.c |2 +-
drivers/infiniband/hw/ehca/ehca_qp.c |9 +++--
drivers/infini
e proper virtual address.
For details about remap_4k_pfn(), see commit 721151d0 or
http://patchwork.ozlabs.org/linuxppc/patch?id=10281
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |4 +++-
drivers/infiniband/hw/ehca/ehca_cq.c
From: Stefan Roscher <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/hcp_if.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/hcp_if.c
b/drivers/infiniband/hw/ehca/hcp_if.c
i
From: Stefan Roscher <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c |7 +++
drivers/infiniband/hw/ehca/ipz_pt_fn.c |1 +
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infini
in order, against Roland's git. Please
review the changes and apply the patches for 2.6.24 if they are okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 2
> > The plaintiff makes a valid point. How about a staging approach: We
put
> > the patch as it is now into 2.6.23 so the problem is fixed, and I'll
post
> > a "nice" version with autoloading support and a generic of_make_bus_id
> > function for 2.6.24. Agree?
>
> Ok, sounds fair. Can you ma
Hi, Arnd,
> The whole logic of dynamically adding and removing device is rather
bogus,
> and it prevents autoloading of device drivers. of_platform_make_bus_id
> is the function that is responsible for creating unique names over
there.
The plaintiff makes a valid point. How about a staging appr
a) Report max_srq > 0 if SRQ is supported
b) Report "last wqe reached" event when base QP dies
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_hca.c | 10 +--
drivers/infiniband/hw/ehca/ehca_irq.c | 48 +-
From: Stefan Roscher <[EMAIL PROTECTED]>
The new Small QP code had a few bugs that would also trigger for non-Small
QPs. Fix them.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c | 10 ++
drivers/infiniband/hw/ehca/ipz_pt_fn.c
eview the changes and apply the patches for 2.6.23-rc5 if they are okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
[EMAIL PROTECTED] (Linas Vepstas) wrote on 30.08.2007 23:28:16:
> On Thu, Aug 30, 2007 at 04:00:56PM +0200, Joachim Fenkes wrote:
> >
> > Plus, I rather like using
> > the full_name since it also contains a descriptive name as opposed to
> > being just nondescript
Nathan Lynch <[EMAIL PROTECTED]> wrote on 29.08.2007 20:12:32:
> > Previously, ibmebus derived a device's bus_id from its location code.
The
> > location code is not guaranteed to be unique, so we might get bus_id
> > collisions if two devices share the same location code. The OFDT
full_name,
>
Previously, ibmebus derived a device's bus_id from its location code. The
location code is not guaranteed to be unique, so we might get bus_id
collisions if two devices share the same location code. The OFDT full_name,
however, is unique, so we use that instead.
Signed-off-by: Joachim F
> kmalloc() returns a void pointer so there is absolutely no need to
> cast it in ibmebus_chomp().
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Acked-By: Joachim Fenkes <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-ker
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This patch should apply cleanly on top of Stefan's recent patchset. Please
review and apply for 2.6.23. Thanks.
drivers/infiniband/hw/ehca/ehca_hca.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --gi
Roland Dreier <[EMAIL PROTECTED]> wrote on 17.07.2007 05:50:13:
> > > Why the module parameter? Is there any reason a user would want to
> > > turn this off? Or conversely, why is it off by default?
> >
> > We're pretty confident this new feature works, but as with all new
and
> > possib
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 19:37:09:
> > If enabled via the mr_largepage module parameter,
>
> Why the module parameter? Is there any reason a user would want to
> turn this off? Or conversely, why is it off by default?
We're pretty confident this new feature works
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 18:04:26:
> It seems not quite right to me for the driver to advertise nr_eqs
> completion vectors, but then if round-robin is turned on to ignore the
> consumer's decision about which vector to use.
The round-robin feature was primarily meant
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 19:14:03:
> applied, but as a further cleanup it seems that ehca2ib_return_code()
> should be moved into a .c file and moved out of line -- I think it
> would probably shrink the compiled code quite a bit, and as far as I
> can see it is never
> > [09/10] fixes a lot of checkpatch.pl warnings
>
> Are these warnings from earlier patches in the series, or problems
> that already existed in the code? If they are coming from other
> patches in the series, please just fix the earlier patches before I
> merge them.
Nam did a diff -Nurp emp
>= 16M, 16M pages are used, for example.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h | 10 +
drivers/infiniband/hw/ehca/ehca_main.c| 17 ++-
drivers/infiniband/hw/ehca/ehca_mrmw.c| 371 -
driver
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_av.c |2 +-
drivers/infiniband/hw/ehca/ehca_classes.h |4 +-
drivers/infiniband/hw/ehca/ehca_classes_pSer
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
- Rename struct ehca_mr fields to clearly distinguish between kernel and HW
page size
- Sort struct ehca_mr_pginfo into a common part and a union containing
specific fields for physical, user and fast MR
Signed-off-by: Joachim Fenkes &
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Split ehca_set_pagebuf() into three functions depending on MR type
(phys/user/fast) and remove superfluous ehca_set_pagebuf_1().
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_m
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c
b/drivers/infini
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 47 ---
1 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Instead of one error mapping function for each potential error source in
ehca_mrmw.c, use a centralized function that handles all cases, saving a
three-figure line count.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infini
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c
b/drivers/infiniband/hw/ehca/ehca_
Autodetection was missing a few HW revisions, causing certain eHCA1
revisions to be treated like eHCA2. Fixed.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c | 29 +
1 files changed, 17 insertions(+), 12 del
st_eqs module parameter is supplied, using a round-robin scheme.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h | 13 +++-
drivers/infiniband/hw/ehca/ehca_cq.c | 16 +++-
drivers/infiniband/hw/ehca/ehca_eq.c
y are okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: [EMAIL PROTECTED]
-
To unsubscribe from this list: sen
Hi all,
while the idr discussion is still hot, there's another thing that caught my
eye recently:
As to my reading of idr.h, I have two choices of initializing a global idr:
a) static struct idr foo; /* ... */ idr_init(&foo);
b) static DEFINE_IDR(foo);
idr_init(), when called for the first tim
Roland Dreier <[EMAIL PROTECTED]> wrote on 10.07.2007 00:11:42:
> thanks, I applied these for 2.6.23 and fixed a bunch of minor things
> that scripts/checkpatch.pl complained about (since I was in a mood to
> do mindless things).
Thanks! Both for the quick merge and for the fixes!
> In the futur
Roland Dreier <[EMAIL PROTECTED]> wrote on 09.07.2007 23:35:31:
> Out of curiousity, does this mean that a GRH will be sent on all UD
> messages (for non-LL QPs)?
No - the bit instructs the hardware to fetch the GRH parts of the QP
context.
The GRH will only be used if the WQE says so.
Joachim
1 - 100 of 144 matches
Mail list logo
