Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect

2021-03-25 Thread Joakim Tjernlund
On Wed, 2021-03-24 at 13:49 +0100, Takashi Iwai wrote: > On Wed, 24 Mar 2021 13:03:14 +0100, > Ikjoon Jang wrote: > > > > On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund > > > > wrote: > > > > The Logitech devices with 046d:* should be covered generall

Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect

2021-03-24 Thread Joakim Tjernlund
On Wed, 2021-03-24 at 18:51 +0800, Ikjoon Jang wrote: > Logitech ConferenceCam Connect is a compound USB device with UVC and > UAC. Not 100% reproducible but sometimes it keeps responding STALL to > every control transfer once it receives get_freq request. > > This patch adds 046d:0x084c to a

Re: [PATCH] jffs2: fix kasan slab-out-of-bounds problem

2021-03-22 Thread Joakim Tjernlund
Reviewe-by: Joakim Tjernlund It would be interesting to known how you managed to create such a dir entry as that is a bug too. From: linux-mtd on behalf of Zhe Li Sent: 18 March 2021 04:06 To: rich...@nod.at; dw...@infradead.org; linux

Re: [PATCH] ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()

2021-03-04 Thread Joakim Tjernlund
On Thu, 2021-03-04 at 12:34 +0800, Kai-Heng Feng wrote: > Rear audio on Lenovo ThinkStation P620 stops working after commit > 1965c4364bdd ("ALSA: usb-audio: Disable autosuspend for Lenovo > ThinkStation P620"): > [6.013526] usbcore: registered new interface driver snd-usb-audio > [

Re: [PATCH] jffs2: check the validity of dstlen in jffs2_zlib_compress()

2021-01-28 Thread Joakim Tjernlund
On Thu, 2021-01-28 at 02:55 -0800, menglong8.d...@gmail.com wrote: > From: Yang Yang > > KASAN reports a BUG when download file in jffs2 filesystem.It is > because when dstlen == 1, cpage_out will write array out of bounds. > Actually, data will not be compressed in jffs2_zlib_compress() if >

Re: loadkeys --mktable fi > /usr/src/linux/drivers/tty/vt/defkeymap.c_shipped OOPSes the kernel 5.4.89

2021-01-16 Thread Joakim Tjernlund
On Sat, 2021-01-16 at 16:23 +0100, Joakim Tjernlund wrote: > Building a kernel and having the default keymap replaced with >   loadkeys --mktable fi > /usr/src/linux/drivers/tty/vt/defkeymap.c_shipped > makes the kernel OOPS during startup. > The OOPS scrolls away and I can

loadkeys --mktable fi > /usr/src/linux/drivers/tty/vt/defkeymap.c_shipped OOPSes the kernel 5.4.89

2021-01-16 Thread Joakim Tjernlund
Building a kernel and having the default keymap replaced with loadkeys --mktable fi > /usr/src/linux/drivers/tty/vt/defkeymap.c_shipped makes the kernel OOPS during startup. The OOPS scrolls away and I can only see a few registers. The OOPS seems to happen when running the loadkeys command.

Re: [PATCH 01/20] ethernet: ucc_geth: set dev->max_mtu to 1518

2021-01-05 Thread Joakim Tjernlund
On Tue, 2021-01-05 at 15:33 +0100, Andrew Lunn wrote: > On Tue, Jan 05, 2021 at 02:17:42PM +0000, Joakim Tjernlund wrote: > > On Thu, 2020-12-10 at 02:25 +0100, Andrew Lunn wrote: > > > On Sat, Dec 05, 2020 at 08:17:24PM +0100, Rasmus Villemoes wrote: > > > >

Re: [PATCH 01/20] ethernet: ucc_geth: set dev->max_mtu to 1518

2021-01-05 Thread Joakim Tjernlund
On Thu, 2020-12-10 at 02:25 +0100, Andrew Lunn wrote: > On Sat, Dec 05, 2020 at 08:17:24PM +0100, Rasmus Villemoes wrote: > > All the buffers and registers are already set up appropriately for an > > MTU slightly above 1500, so we just need to expose this to the > > networking stack. AFAICT,

Re: [PATCH] spi: fsl-espi: Only process interrupts for expected events

2020-09-14 Thread Joakim Tjernlund
On Mon, 2020-09-14 at 12:28 +1000, Nicholas Piggin wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Excerpts from Chris Packham's message of September 14,

Re: fsl_espi errors on v5.7.15

2020-09-07 Thread Joakim Tjernlund
[SNIP] > > > > > Would you be able to ftrace the interrupt handler function and see if you > > > can see a difference in number or timing of interrupts? I'm at a bit of > > > a loss. > > > > I tried ftrace but I really wasn't sure what I was looking for. > > Capturing a "bad" case was pretty

Re: fsl_espi errors on v5.7.15

2020-09-07 Thread Joakim Tjernlund
On Thu, 2020-09-03 at 23:58 +, Chris Packham wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On 1/09/20 6:14 pm, Nicholas Piggin wrote: > > Excerpts from

Re: [PATCH] jffs2: fix UAF problem

2020-07-13 Thread Joakim Tjernlund
On Tue, 2020-07-07 at 18:30 +0200, Richard Weinberger wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > > On Tue, Jul 7, 2020 at 4:08 PM Joakim

Re: printk of non NULL terminated strings ?

2020-07-09 Thread Joakim Tjernlund
On Thu, 2020-07-09 at 15:30 +0200, Rasmus Villemoes wrote: > On 09/07/2020 15.26, Joakim Tjernlund wrote: > > On Thu, 2020-07-09 at 14:56 +0200, Andreas Schwab wrote: > > > CAUTION: This email originated from outside of the organization. Do not > > > click links or

Re: printk of non NULL terminated strings ?

2020-07-09 Thread Joakim Tjernlund
On Thu, 2020-07-09 at 14:56 +0200, Andreas Schwab wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Jul 09 2020, Joak

printk of non NULL terminated strings ?

2020-07-09 Thread Joakim Tjernlund
Is there a format (or other function) that lets me print strings without an \0 terminator using an explicit length arg instead? Something like: printk("%s...", str, str_len); /* replace ... */ or some other funktion perhaps ? Jocke

Re: [PATCH] jffs2: fix UAF problem

2020-07-07 Thread Joakim Tjernlund
Maintainer ping ? Jocke On Wed, 2020-06-24 at 18:59 +, Joakim Tjernlund wrote: > > Nice find, I just came across a deadlock wrt GC and rmdir, > hopefully this is he fix. > > This needs to go to stable too, sooner rather than later. > >  Jocke > > On Fri, 202

Re: [PATCH] jffs2: fix UAF problem

2020-06-24 Thread Joakim Tjernlund
Nice find, I just came across a deadlock wrt GC and rmdir, hopefully this is he fix. This needs to go to stable too, sooner rather than later. Jocke On Fri, 2020-06-19 at 17:06 +0800, Zhe Li wrote: > > The log of UAF problem is listed below. > BUG: KASAN: use-after-free in

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

2020-06-16 Thread Joakim Tjernlund
On Tue, 2020-06-16 at 18:12 +0300, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 18:08, Vladimir Oltean wrote: > > On Tue, 16 Jun 2020 at 18:04, Joakim Tjernlund > > wrote: > > > On Tue, 2020-06-16 at 17:56 +0300, Vladimir Oltean wrote: > > > > CAUTION

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

2020-06-16 Thread Joakim Tjernlund
On Tue, 2020-06-16 at 17:56 +0300, Vladimir Oltean wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Hi Joakim, > > On Tue, 16 J

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

2020-06-16 Thread Joakim Tjernlund
On Tue, 2020-06-16 at 17:41 +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The dpaa-eth driver probes on compatible string for the MAC node, and > the fman/mac.c driver allocates a dpaa-ethernet platform device that > triggers the probing of the dpaa-eth net device driver. > > All of

Re: [PATCH] powerpc/8xx: drop unused self-modifying code alternative to FixupDAR.

2019-08-22 Thread Joakim Tjernlund
o go. Reviewed-by: Joakim Tjernlund Jocke > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/head_8xx.S | 24 > 1 file changed, 24 deletions(-) > > diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/head_8xx.S > index b8ca5b4

Re: [PATCH] mtd: cfi_cmdset_0002: dynamically determine the max sectors

2019-06-14 Thread Joakim Tjernlund
On Fri, 2019-06-14 at 03:23 +, Chris Packham wrote: > > > Hi All, > > I think this may have got lost in the change of maintainer for mtd. We need this too, ATM we have a local hack that just changes MAX_SECTORS to 1024 > > On 22/05/19 12:06 PM, Chris Packham wrote: > > Because PPB

Re: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device tree properties

2019-05-13 Thread Joakim Tjernlund
On Mon, 2019-05-13 at 17:40 +, Roy Pledge wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On 5/13/2019 12:40 PM, Joakim Tjernlund wrote

Re: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device tree properties

2019-05-13 Thread Joakim Tjernlund
On Mon, 2019-05-13 at 16:09 +, Roy Pledge wrote: > > The index value should be passed to the of_parse_phandle() > function to ensure the correct property is read. Is this a bug fix? Maybe for stable too? Jocke > > Signed-off-by: Roy Pledge > --- > drivers/soc/fsl/qbman/dpaa_sys.c | 2

Re: [PATCH v3 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding

2019-05-13 Thread Joakim Tjernlund
On Mon, 2019-05-13 at 11:14 +, Rasmus Villemoes wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Reading table 4-30, and its footnotes, of the QUICC

Re: [RFC PATCH v2 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-03-25 Thread Joakim Tjernlund
On Mon, 2019-03-25 at 22:36 +0530, Vignesh Raghavendra wrote: > > On 25/03/19 7:21 PM, Joakim Tjernlund wrote: > > On Mon, 2019-03-25 at 18:27 +0530, Vignesh Raghavendra wrote: > > > CAUTION: This email originated from outside of the organization. Do not > > > c

Re: [RFC PATCH v2 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-03-25 Thread Joakim Tjernlund
On Mon, 2019-03-25 at 18:27 +0530, Vignesh Raghavendra wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Hi, > > On 21/03/19 11:41 PM

Re: [RFC PATCH v2 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-03-21 Thread Joakim Tjernlund
On Thu, 2019-03-21 at 23:15 +0530, Vignesh Raghavendra wrote: > > HyperFlash devices are compliant with CFI AMD/Fujitsu Extended Command > Set(0x0002) for flash operations, therefore > drivers/mtd/chips/cfi_cmdset_0002.c > can be use as is. But these devices do not support DQ polling method of >

Re: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-08 Thread Joakim Tjernlund
On Thu, 2019-02-07 at 23:50 +, Sobon, Przemyslaw wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Hi Ikegami, > > I have seen a case myself where a value

Re: [PATCH] jffs2: implement mount option to configure endianness

2018-11-08 Thread Joakim Tjernlund
On Thu, 2018-11-08 at 18:01 +, Nikunj Kela (nkela) wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On 11/8/18, 12:12 AM, "David Woodhouse" wrote: > >

Re: [PATCH] jffs2: implement mount option to configure endianness

2018-11-08 Thread Joakim Tjernlund
On Thu, 2018-11-08 at 18:01 +, Nikunj Kela (nkela) wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On 11/8/18, 12:12 AM, "David Woodhouse" wrote: > >

Re: [PATCH] jffs2: implement mount option to configure endianness

2018-11-07 Thread Joakim Tjernlund
On Wed, 2018-11-07 at 17:58 +, David Woodhouse wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > > On Wed, Nov 07, 2018 at 04:12:14PM -, David

Re: [PATCH] jffs2: implement mount option to configure endianness

2018-11-07 Thread Joakim Tjernlund
On Wed, 2018-11-07 at 17:58 +, David Woodhouse wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > > On Wed, Nov 07, 2018 at 04:12:14PM -, David

Re: [PATCH] jffs2: implement mount option to configure endianness

2018-11-07 Thread Joakim Tjernlund
On Wed, 2018-11-07 at 10:05 +0100, David Woodhouse wrote: > > On Tue, 2018-11-06 at 13:49 -0800, Nikunj Kela wrote: > > This patch allows the endianness of the JFSS2 filesystem to be > > specified by mount option 'force_endian=big|little|native'. If > > endianness is not specified, it defaults to

Re: [PATCH] jffs2: implement mount option to configure endianness

2018-11-07 Thread Joakim Tjernlund
On Wed, 2018-11-07 at 10:05 +0100, David Woodhouse wrote: > > On Tue, 2018-11-06 at 13:49 -0800, Nikunj Kela wrote: > > This patch allows the endianness of the JFSS2 filesystem to be > > specified by mount option 'force_endian=big|little|native'. If > > endianness is not specified, it defaults to

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Joakim Tjernlund
On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > This patch allows the endianness of the JFSS2 filesystem to be

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Joakim Tjernlund
On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > This patch allows the endianness of the JFSS2 filesystem to be

[Fwd: 11 minute NTP hw clock update racy?]

2018-08-28 Thread Joakim Tjernlund
No luck on linuxppc-dev, trying LKML ... Forwarded Message From: Joakim Tjernlund To: linuxppc-dev linuxppc-dev Subject: 11 minute NTP hw clock update racy? Date: Mon, 27 Aug 2018 10:01:12 +0200 We see corrupt HW clock time every now and then(really hard to reproduce) Our RTC

[Fwd: 11 minute NTP hw clock update racy?]

2018-08-28 Thread Joakim Tjernlund
No luck on linuxppc-dev, trying LKML ... Forwarded Message From: Joakim Tjernlund To: linuxppc-dev linuxppc-dev Subject: 11 minute NTP hw clock update racy? Date: Mon, 27 Aug 2018 10:01:12 +0200 We see corrupt HW clock time every now and then(really hard to reproduce) Our RTC

Re: [PATCH 12/17] powerpc/8xx: Remove PTE_ATOMIC_UPDATES

2018-05-04 Thread Joakim Tjernlund
On Fri, 2018-05-04 at 14:34 +0200, Christophe Leroy wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > commit 1bc54c03117b9 ("powerpc: rework 4xx PTE access and

Re: [PATCH 12/17] powerpc/8xx: Remove PTE_ATOMIC_UPDATES

2018-05-04 Thread Joakim Tjernlund
On Fri, 2018-05-04 at 14:34 +0200, Christophe Leroy wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > commit 1bc54c03117b9 ("powerpc: rework 4xx PTE access and

Re: [PATCH] jffs2: remove fd from the f->dents list immediately.

2018-03-16 Thread Joakim Tjernlund
On Fri, 2018-03-16 at 19:05 +0800, Yufen Yu wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > commit 15953580e79b ("[JFFS2] Improve getdents vs. f_pos handling

Re: [PATCH] jffs2: remove fd from the f->dents list immediately.

2018-03-16 Thread Joakim Tjernlund
On Fri, 2018-03-16 at 19:05 +0800, Yufen Yu wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > commit 15953580e79b ("[JFFS2] Improve getdents vs. f_pos handling

Re: [PATCH 0/5] DPAA Ethernet fixes

2018-03-14 Thread Joakim Tjernlund
On Wed, 2018-03-14 at 08:37 -0500, Madalin Bucur wrote: > Hi, > > This patch set is addressing several issues in the DPAA Ethernet > driver suite: > > - module unload crash caused by wrong reference to device being left >in the cleanup code after the DSA related changes > - scheduling wile

Re: [PATCH 0/5] DPAA Ethernet fixes

2018-03-14 Thread Joakim Tjernlund
On Wed, 2018-03-14 at 08:37 -0500, Madalin Bucur wrote: > Hi, > > This patch set is addressing several issues in the DPAA Ethernet > driver suite: > > - module unload crash caused by wrong reference to device being left >in the cleanup code after the DSA related changes > - scheduling wile

Re: [PATCH] mfd: lpc_ich: Avoton/Rangeley uses SPI_BYT method

2017-10-24 Thread Joakim Tjernlund
On Mon, 2017-10-23 at 14:36 +0100, Lee Jones wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Wed, 11 Oct 2017, Joakim Tjernlund wr

Re: [PATCH] mfd: lpc_ich: Avoton/Rangeley uses SPI_BYT method

2017-10-24 Thread Joakim Tjernlund
On Mon, 2017-10-23 at 14:36 +0100, Lee Jones wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Wed, 11 Oct 2017, Joakim Tjernlund wr

[PATCH] mfd: lpc_ich: Avoton/Rangeley uses SPI_BYT method

2017-10-11 Thread Joakim Tjernlund
Avoton/Rangeley are based on Silvermount micro-architecture, like Bay Trail, and uses the INTEL_SPI_BYT method to drive SPI. Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- drivers/mfd/lpc_ich.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/lpc_i

[PATCH] mfd: lpc_ich: Avoton/Rangeley uses SPI_BYT method

2017-10-11 Thread Joakim Tjernlund
Avoton/Rangeley are based on Silvermount micro-architecture, like Bay Trail, and uses the INTEL_SPI_BYT method to drive SPI. Signed-off-by: Joakim Tjernlund --- drivers/mfd/lpc_ich.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c index

Re: uio_dmem_genirq.c and DMA mapping to user space ?

2017-09-12 Thread Joakim Tjernlund
On Tue, 2017-09-12 at 05:37 -0700, gre...@linuxfoundation.org wrote: > On Tue, Sep 12, 2017 at 12:18:27PM +0000, Joakim Tjernlund wrote: > > Hi > > > > I am trying to use the uio_dmem_genirq.c driver for allocating DMA memory > > to a PCI device > > using the uio

Re: uio_dmem_genirq.c and DMA mapping to user space ?

2017-09-12 Thread Joakim Tjernlund
On Tue, 2017-09-12 at 05:37 -0700, gre...@linuxfoundation.org wrote: > On Tue, Sep 12, 2017 at 12:18:27PM +0000, Joakim Tjernlund wrote: > > Hi > > > > I am trying to use the uio_dmem_genirq.c driver for allocating DMA memory > > to a PCI device > > using the uio

uio_dmem_genirq.c and DMA mapping to user space ?

2017-09-12 Thread Joakim Tjernlund
Hi I am trying to use the uio_dmem_genirq.c driver for allocating DMA memory to a PCI device using the uio_pci_generic.c driver. I got as far as defining an UIO dev containing only Dynamic DMA memory and now I am stuck. I can see how DMA memory is allocated when opening the /dev/uio device but

uio_dmem_genirq.c and DMA mapping to user space ?

2017-09-12 Thread Joakim Tjernlund
Hi I am trying to use the uio_dmem_genirq.c driver for allocating DMA memory to a PCI device using the uio_pci_generic.c driver. I got as far as defining an UIO dev containing only Dynamic DMA memory and now I am stuck. I can see how DMA memory is allocated when opening the /dev/uio device but

Re: [PATCH v2 00/10] spi-nor: intel-spi: Various fixes and enhancements

2017-09-11 Thread Joakim Tjernlund
On Mon, 2017-09-11 at 02:41 -0700, Bin Meng wrote: > This series does several bug fixes and clean ups against the intel-spi > spi-nor driver, as well as enhancements to make the driver independent > on the underlying BIOS/bootloader. > > At present the driver uses the HW sequencer for the

Re: [PATCH v2 00/10] spi-nor: intel-spi: Various fixes and enhancements

2017-09-11 Thread Joakim Tjernlund
On Mon, 2017-09-11 at 02:41 -0700, Bin Meng wrote: > This series does several bug fixes and clean ups against the intel-spi > spi-nor driver, as well as enhancements to make the driver independent > on the underlying BIOS/bootloader. > > At present the driver uses the HW sequencer for the

[PATCH] lpc_ich: Avoton/Rangeley uses SPI_BYT method.

2017-09-05 Thread Joakim Tjernlund
Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- drivers/mfd/lpc_ich.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c index 985135828cfc..023d88dfad0e 100644 --- a/drivers/mfd/lpc_ich.c +++ b/drivers/mfd/lpc_ich.c @@

[PATCH] lpc_ich: Avoton/Rangeley uses SPI_BYT method.

2017-09-05 Thread Joakim Tjernlund
Signed-off-by: Joakim Tjernlund --- drivers/mfd/lpc_ich.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c index 985135828cfc..023d88dfad0e 100644 --- a/drivers/mfd/lpc_ich.c +++ b/drivers/mfd/lpc_ich.c @@ -532,6 +532,7 @@ static struct

[PATCH] spi-fsl-spi: Align CS behaviour for last SPI msg

2017-08-16 Thread Joakim Tjernlund
According to spi.h cs_change can be used to leave the CS active until next SPI transfer(paragraph ii). Adjust driver to comply with (ii). Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- drivers/spi/spi-fsl-spi.c | 14 ++ 1 file changed, 10 insertions

[PATCH] spi-fsl-spi: Align CS behaviour for last SPI msg

2017-08-16 Thread Joakim Tjernlund
According to spi.h cs_change can be used to leave the CS active until next SPI transfer(paragraph ii). Adjust driver to comply with (ii). Signed-off-by: Joakim Tjernlund --- drivers/spi/spi-fsl-spi.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/spi

[PATCHv2 1/2] x86: asm/bitops.h

2017-03-17 Thread Joakim Tjernlund
VirtualBox modules complains when doing pointer arithmetic's, replace void * cast with uintptr_t to do pointer arithmetic's in integer space instead. Cc: <sta...@vger.kernel.org> # v4.9+ Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- v2 - Improve wording arch

[PATCHv2 1/2] x86: asm/bitops.h

2017-03-17 Thread Joakim Tjernlund
VirtualBox modules complains when doing pointer arithmetic's, replace void * cast with uintptr_t to do pointer arithmetic's in integer space instead. Cc: # v4.9+ Signed-off-by: Joakim Tjernlund --- v2 - Improve wording arch/x86/include/asm/bitops.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCHv2 2/2] x86: Match bitops prototypes

2017-03-17 Thread Joakim Tjernlund
# v4.9+ Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- v2 - Improve wording include/asm-generic/bitops/le.h | 42 ++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/include/asm-generic/bitops/le.h b/include/asm-ge

[PATCHv2 2/2] x86: Match bitops prototypes

2017-03-17 Thread Joakim Tjernlund
Building VirtualBox modules causes type mismatch complaints when mixing void * and unsigned long *. Adjust bitops function prototypes in asm-generic/bitops/le.h to match the generic ones in arch/x86/include/asm/le.h That is, replace void* with unsigned long * Cc: # v4.9+ Signed-off-by: Joakim

[PATCH 2/2] x86: Match bitops prototypes

2017-03-16 Thread Joakim Tjernlund
Adjust bitops function prototypes in asm-generic/bitops/le.h to match the generic ones in arch/x86/include/asm/le.h That is, replace void* with unsigned long* Cc: <sta...@vger.kernel.org> # v4.9+ Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- include/asm-generic

[PATCH 2/2] x86: Match bitops prototypes

2017-03-16 Thread Joakim Tjernlund
Adjust bitops function prototypes in asm-generic/bitops/le.h to match the generic ones in arch/x86/include/asm/le.h That is, replace void* with unsigned long* Cc: # v4.9+ Signed-off-by: Joakim Tjernlund --- include/asm-generic/bitops/le.h | 42 ++--- 1 file

[PATCH 1/2] x86: asm/bitops.h

2017-03-16 Thread Joakim Tjernlund
Replace void * cast with uintptr_t to do pointer arithmetic's Cc: <sta...@vger.kernel.org> # v4.9+ Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- arch/x86/include/asm/bitops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/as

[PATCH 1/2] x86: asm/bitops.h

2017-03-16 Thread Joakim Tjernlund
Replace void * cast with uintptr_t to do pointer arithmetic's Cc: # v4.9+ Signed-off-by: Joakim Tjernlund --- arch/x86/include/asm/bitops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h index 8540227..b561304

different xxx_bit() function prototypes in bitops for x86 vs generic

2017-03-09 Thread Joakim Tjernlund
Building virtualbox external kernel modules warns about different types, example: include/asm-generic/bitops/le.h; set_bit_le(int nr, const void *addr) vs arch/x86/include/asm/bitops.h: set_bit(long nr, volatile unsigned long *addr) This difference is causes complaints, changing

different xxx_bit() function prototypes in bitops for x86 vs generic

2017-03-09 Thread Joakim Tjernlund
Building virtualbox external kernel modules warns about different types, example: include/asm-generic/bitops/le.h; set_bit_le(int nr, const void *addr) vs arch/x86/include/asm/bitops.h: set_bit(long nr, volatile unsigned long *addr) This difference is causes complaints, changing

Re: [PATCH 1/2] Correct function definition for C++

2017-02-22 Thread Joakim Tjernlund
On Wed, 2017-02-22 at 15:22 +0100, g...@kroah.com wrote: > On Wed, Feb 22, 2017 at 02:00:53PM +0000, Joakim Tjernlund wrote: > > On Wed, 2017-02-22 at 14:03 +0100, g...@kroah.com wrote: > > > On Wed, Feb 22, 2017 at 07:50:46AM +, Joakim Tjernlund wrote: > > > &g

Re: [PATCH 1/2] Correct function definition for C++

2017-02-22 Thread Joakim Tjernlund
On Wed, 2017-02-22 at 15:22 +0100, g...@kroah.com wrote: > On Wed, Feb 22, 2017 at 02:00:53PM +0000, Joakim Tjernlund wrote: > > On Wed, 2017-02-22 at 14:03 +0100, g...@kroah.com wrote: > > > On Wed, Feb 22, 2017 at 07:50:46AM +, Joakim Tjernlund wrote: > > > &g

Re: [PATCH 1/2] Correct function definition for C++

2017-02-22 Thread Joakim Tjernlund
On Wed, 2017-02-22 at 14:03 +0100, g...@kroah.com wrote: > On Wed, Feb 22, 2017 at 07:50:46AM +0000, Joakim Tjernlund wrote: > > On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: > > > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > > > > C++ does

Re: [PATCH 1/2] Correct function definition for C++

2017-02-22 Thread Joakim Tjernlund
On Wed, 2017-02-22 at 14:03 +0100, g...@kroah.com wrote: > On Wed, Feb 22, 2017 at 07:50:46AM +0000, Joakim Tjernlund wrote: > > On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: > > > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > > > > C++ does

Re: [PATCH 1/2] Correct function definition for C++

2017-02-21 Thread Joakim Tjernlund
On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > > C++ does does not like the extra extern before asmlinkage, remove it. > > > > Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com>

Re: [PATCH 1/2] Correct function definition for C++

2017-02-21 Thread Joakim Tjernlund
On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > > C++ does does not like the extra extern before asmlinkage, remove it. > > > > Signed-off-by: Joakim Tjernlund > > --- > > include/linux/prin

[PATCH 2/2] compiler.h: fix C++ uninitialized const issue

2017-02-21 Thread Joakim Tjernlund
__c[1]; } __u={0} To please gcc 6.3.0 also add in a _u(){} as default ctor. This makes C++ happy enough to build. Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- include/linux/compiler.h | 12 1 file changed, 12 insertions(+) diff --git a/include

[PATCH 2/2] compiler.h: fix C++ uninitialized const issue

2017-02-21 Thread Joakim Tjernlund
__c[1]; } __u={0} To please gcc 6.3.0 also add in a _u(){} as default ctor. This makes C++ happy enough to build. Signed-off-by: Joakim Tjernlund --- include/linux/compiler.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/compiler.h b/include/linux/compiler.h

[PATCH 1/2] Correct function definition for C++

2017-02-21 Thread Joakim Tjernlund
C++ does does not like the extra extern before asmlinkage, remove it. Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> --- include/linux/printk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index 3

[PATCH 1/2] Correct function definition for C++

2017-02-21 Thread Joakim Tjernlund
C++ does does not like the extra extern before asmlinkage, remove it. Signed-off-by: Joakim Tjernlund --- include/linux/printk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index 3472cc6..be823f5 100644 --- a/include

Re: [PATCH] x86/fpu/xstate: Fix xcomp_bv in XSAVES header

2017-02-02 Thread Joakim Tjernlund
y_init_fpstate_to_fpregs() in fpu__clear(), > > as in commit: b22cbe404a9cc3c7949e380fa1861e31934c8978, and when > > __fpu_restore_sig() does fpu__restore() for a COMPAT-mode app, > > a #GP occurs. This can be easily triggered by doing valgrind on > > a COMPAT-mode "Hello World," as reporte

Re: [PATCH] x86/fpu/xstate: Fix xcomp_bv in XSAVES header

2017-02-02 Thread Joakim Tjernlund
n commit: b22cbe404a9cc3c7949e380fa1861e31934c8978, and when > > __fpu_restore_sig() does fpu__restore() for a COMPAT-mode app, > > a #GP occurs. This can be easily triggered by doing valgrind on > > a COMPAT-mode "Hello World," as reported by Joakim Tjernlund and

Re: fs/jffs2/readinode.c:189: faulty logic ?

2017-01-24 Thread Joakim Tjernlund
On Tue, 2017-01-24 at 15:52 +0100, Marek Vasut wrote: > On 01/24/2017 09:15 AM, David Binderman wrote: > > Hello there, > > > > fs/jffs2/readinode.c:189]: (style) Condition 'tn.fn.ofs>=offset' is always > > true > > > > Source code is > > > > if (tn->fn->ofs < offset) > >

Re: fs/jffs2/readinode.c:189: faulty logic ?

2017-01-24 Thread Joakim Tjernlund
On Tue, 2017-01-24 at 15:52 +0100, Marek Vasut wrote: > On 01/24/2017 09:15 AM, David Binderman wrote: > > Hello there, > > > > fs/jffs2/readinode.c:189]: (style) Condition 'tn.fn.ofs>=offset' is always > > true > > > > Source code is > > > > if (tn->fn->ofs < offset) > >

Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-07 Thread Joakim Tjernlund
IQ platforms. Nice to see DPAA support soon entering the kernel(not a day too early:) I would like to see BQL supported from day one though, if possible.  Regards           Joakim Tjernlund

Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-07 Thread Joakim Tjernlund
IQ platforms. Nice to see DPAA support soon entering the kernel(not a day too early:) I would like to see BQL supported from day one though, if possible.  Regards           Joakim Tjernlund

Re: [Patch v2 5/5] drivers/net: support hdlc function for QE-UCC

2016-06-02 Thread Joakim Tjernlund
On Thu, 2016-06-02 at 09:45 +0800, Zhao Qiang wrote: > The driver add hdlc support for Freescale QUICC Engine. > It support NMSI and TSA mode. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - remove useless code. > - remove Unnecessary casts > -

Re: [Patch v2 5/5] drivers/net: support hdlc function for QE-UCC

2016-06-02 Thread Joakim Tjernlund
On Thu, 2016-06-02 at 09:45 +0800, Zhao Qiang wrote: > The driver add hdlc support for Freescale QUICC Engine. > It support NMSI and TSA mode. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - remove useless code. > - remove Unnecessary casts > - return IRQ_NONE when

Re: [PATCH 4/5] fsl/qe: Add QE TDM lib

2016-03-30 Thread Joakim Tjernlund
On Wed, 2016-03-30 at 16:50 +0800, Zhao Qiang wrote: > QE has module to support TDM, some other protocols > supported by QE are based on TDM. > add a qe-tdm lib, this lib provides functions to the protocols > using TDM to configurate QE-TDM. > > Signed-off-by: Zhao Qiang >

Re: [PATCH 4/5] fsl/qe: Add QE TDM lib

2016-03-30 Thread Joakim Tjernlund
On Wed, 2016-03-30 at 16:50 +0800, Zhao Qiang wrote: > QE has module to support TDM, some other protocols > supported by QE are based on TDM. > add a qe-tdm lib, this lib provides functions to the protocols > using TDM to configurate QE-TDM. > > Signed-off-by: Zhao Qiang > --- >  

Re: JFFS2 deadlock

2016-02-24 Thread Joakim Tjernlund
On Thu, 2016-02-18 at 10:57 +0100, thomas.bet...@rohde-schwarz.com wrote: > Hello David: > > > > > > > > > Please could you try what's in the tree at > > > http://git.infradead.org/users/dwmw2/jffs2-fixes.git > > > > Your patch looks much simpler, and I will definitely test it. It may > > take

Re: JFFS2 deadlock

2016-02-24 Thread Joakim Tjernlund
On Thu, 2016-02-18 at 10:57 +0100, thomas.bet...@rohde-schwarz.com wrote: > Hello David: > > > > > > > > > Please could you try what's in the tree at > > > http://git.infradead.org/users/dwmw2/jffs2-fixes.git > > > > Your patch looks much simpler, and I will definitely test it. It may > > take

Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

2015-11-03 Thread Joakim Tjernlund
On Tue, 2015-11-03 at 09:37 +, Madalin-Cristian Bucur wrote: > > -Original Message- > > From: Joakim Tjernlund [mailto:joakim.tjernl...@transmode.se] > > > > On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > > > + if (unlikely(fd_st

Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

2015-11-03 Thread Joakim Tjernlund
On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > + if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) { > + if (net_ratelimit()) > + netif_warn(priv, hw, net_dev, "FD status = 0x%08x\n", > + fd_status &

Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

2015-11-03 Thread Joakim Tjernlund
On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > + if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) { > + if (net_ratelimit()) > + netif_warn(priv, hw, net_dev, "FD status = 0x%08x\n", > + fd_status &

Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

2015-11-03 Thread Joakim Tjernlund
On Tue, 2015-11-03 at 09:37 +, Madalin-Cristian Bucur wrote: > > -Original Message- > > From: Joakim Tjernlund [mailto:joakim.tjernl...@transmode.se] > > > > On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > > > + if (unlikely(fd_st

Re: [PATCH v2 22/25] powerpc32: move xxxxx_dcache_range() functions inline

2015-09-22 Thread Joakim Tjernlund
On Tue, 2015-09-22 at 15:35 -0500, Scott Wood wrote: > On Tue, 2015-09-22 at 20:32 +0000, Joakim Tjernlund wrote: > > On Tue, 2015-09-22 at 15:14 -0500, Scott Wood wrote: > > > On Tue, 2015-09-22 at 19:55 +, Joakim Tjernlund wrote: > > > > On Tue, 2015-09-22 at

Re: [PATCH v2 22/25] powerpc32: move xxxxx_dcache_range() functions inline

2015-09-22 Thread Joakim Tjernlund
On Tue, 2015-09-22 at 15:14 -0500, Scott Wood wrote: > On Tue, 2015-09-22 at 19:55 +0000, Joakim Tjernlund wrote: > > On Tue, 2015-09-22 at 14:42 -0500, Scott Wood wrote: > > > On Tue, 2015-09-22 at 19:34 +, Joakim Tjernlund wrote: > > > > On Tue, 2015-09-22 at

Re: [PATCH v2 22/25] powerpc32: move xxxxx_dcache_range() functions inline

2015-09-22 Thread Joakim Tjernlund
> > And generally the one proposing uglification-for-optimization should > > provide > > the evidence. :-) > > When it comes to gcc, past history is my evidence until proven otherwise :) > Maybe I will check again ... OK then: static inline void mb(void) { __asm__ __volatile__ ("sync"

Re: [PATCH v2 22/25] powerpc32: move xxxxx_dcache_range() functions inline

2015-09-22 Thread Joakim Tjernlund
On Tue, 2015-09-22 at 14:42 -0500, Scott Wood wrote: > On Tue, 2015-09-22 at 19:34 +0000, Joakim Tjernlund wrote: > > On Tue, 2015-09-22 at 13:58 -0500, Scott Wood wrote: > > > On Tue, 2015-09-22 at 18:12 +, Joakim Tjernlund wrote: > > > > On Tue, 2015-09-22 at

  1   2   3   >