-by: Johannes Thumshirn
---
drivers/nvme/host/fabrics.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index febf82639b40..757a49b9c5a8 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host
+0xbd/0x1c0
[9.779644] ksys_write+0x40/0xa0
[9.780184] ? do_syscall_64+0xd/0x190
[9.780736] do_syscall_64+0x51/0x190
[9.781281] entry_SYSCALL_64_after_hwframe+0x49/0xbe
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvme/target/fcloop.c | 2 +-
1 file c
+0xbd/0x1c0
[9.779644] ksys_write+0x40/0xa0
[9.780184] ? do_syscall_64+0xd/0x190
[9.780736] do_syscall_64+0x51/0x190
[9.781281] entry_SYSCALL_64_after_hwframe+0x49/0xbe
Signed-off-by: Johannes Thumshirn
---
drivers/nvme/target/fcloop.c | 2 +-
1 file changed, 1 insertion(+), 1
I've "accidently" activated lockdep and ran some tests on nvme, here's
the post-fallout patch series.
Johannes Thumshirn (5):
nvme: fix lockdep warning in nvme_mpath_clear_current_path
nvme: don't hold nvmf_transports_rwsem for more than transport lookups
nvme: call nvmf_create_c
I've "accidently" activated lockdep and ran some tests on nvme, here's
the post-fallout patch series.
Johannes Thumshirn (5):
nvme: fix lockdep warning in nvme_mpath_clear_current_path
nvme: don't hold nvmf_transports_rwsem for more than transport lookups
nvme: call nvmf_create_c
On Mon, May 14, 2018 at 06:38:49AM -0700, Paul E. McKenney wrote:
> On Mon, May 14, 2018 at 02:57:25PM +0200, Johannes Thumshirn wrote:
> > On Mon, May 14, 2018 at 05:42:30AM -0700, Christoph Hellwig wrote:
> > > > extern unsigned int nvme_io_timeout;
> > &
On Mon, May 14, 2018 at 06:38:49AM -0700, Paul E. McKenney wrote:
> On Mon, May 14, 2018 at 02:57:25PM +0200, Johannes Thumshirn wrote:
> > On Mon, May 14, 2018 at 05:42:30AM -0700, Christoph Hellwig wrote:
> > > > extern unsigned int nvme_io_timeout;
> > &
ter() and later dereference the value without
> protection, you will of course get what you deserve, good and hard. ;-)
Thanks Paul.
Christoph, I'll be sending the v2 probably tomorrow as I have more
lockdep fixes for nvme in the pipe and I'll send them out as a
complete series.
--
ter() and later dereference the value without
> protection, you will of course get what you deserve, good and hard. ;-)
Thanks Paul.
Christoph, I'll be sending the v2 probably tomorrow as I have more
lockdep fixes for nvme in the pipe and I'll send them out as a
complete series.
--
sure a comparison of two pointer is always
atomic (on all architectures)?
Paul, can you shed some light on us mere mortal, whether the above
rcu_dereference_protected() is needed or if a simple ns ==
head->current_path is sufficient.
Thanks,
Johannes
--
Johannes Thumshirn
sure a comparison of two pointer is always
atomic (on all architectures)?
Paul, can you shed some light on us mere mortal, whether the above
rcu_dereference_protected() is needed or if a simple ns ==
head->current_path is sufficient.
Thanks,
Johannes
--
Johannes Thumshirn
ss to nvme subsystems")
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvme/host/nvme.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 17d2f7cf3fed..ca034434ebb9 100644
--- a/drivers/nvme/hos
ss to nvme subsystems")
Signed-off-by: Johannes Thumshirn
---
drivers/nvme/host/nvme.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 17d2f7cf3fed..ca034434ebb9 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/
On Tue, May 08, 2018 at 09:33:49PM -0400, Kent Overstreet wrote:
> +/**
> + * mempool_destroy - exit a mempool initialized with mempool_init()
^ mempool_exit()
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911
On Tue, May 08, 2018 at 09:33:49PM -0400, Kent Overstreet wrote:
> +/**
> + * mempool_destroy - exit a mempool initialized with mempool_init()
^ mempool_exit()
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911
Looks good,
Reviewed-by: Johannes Thumshirn <j...@kernel.org>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
ct_io case and thus we couldn't sent out an identify
controller command to reconnect.
Change the controller state to NVME_CTRL_CONNECTING after tearing down
the old connection and before re-establishing the connection.
Fixes: bb06ec31452f ("nvme: expand nvmf_check_if_ready checks")
Sig
ct_io case and thus we couldn't sent out an identify
controller command to reconnect.
Change the controller state to NVME_CTRL_CONNECTING after tearing down
the old connection and before re-establishing the connection.
Fixes: bb06ec31452f ("nvme: expand nvmf_check_if_ready checks")
Sig
tracepoint to have the fields aligned.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reported-by: Keith Busch <keith.bu...@intel.com>
Reviewed-by: Jens Axboe <ax...@kernel.dk>
---
* Changes to v1:
- Changed two typos Jens spotted
- Add Jens' R-b
---
drivers/nvme/host/trace.
tracepoint to have the fields aligned.
Signed-off-by: Johannes Thumshirn
Reported-by: Keith Busch
Reviewed-by: Jens Axboe
---
* Changes to v1:
- Changed two typos Jens spotted
- Add Jens' R-b
---
drivers/nvme/host/trace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
On Thu, Apr 26, 2018 at 02:01:59PM -0600, Jens Axboe wrote:
> On 4/26/18 1:49 PM, Johannes Thumshirn wrote:
> > Keith reported that command submission and command completion
> > tracepoints have the order of the cmdid and qid fileds swapped.
> >
> > While it isn'
On Thu, Apr 26, 2018 at 02:01:59PM -0600, Jens Axboe wrote:
> On 4/26/18 1:49 PM, Johannes Thumshirn wrote:
> > Keith reported that command submission and command completion
> > tracepoints have the order of the cmdid and qid fileds swapped.
> >
> > While it isn'
tracepoint to have the fileds aligned.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reported-by: Keith Busch <keith.bu...@intel.com>
---
drivers/nvme/host/trace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/t
tracepoint to have the fileds aligned.
Signed-off-by: Johannes Thumshirn
Reported-by: Keith Busch
---
drivers/nvme/host/trace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h
index ea91fccd1bc0..01390f0e1671 100644
Provide a descriptive error in case an lport to rport association
isn't found when creating the FC-NVME controller.
Currently it's very hard to debug the reason for a failed connect
attempt without a look at the source.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
This ac
Provide a descriptive error in case an lport to rport association
isn't found when creating the FC-NVME controller.
Currently it's very hard to debug the reason for a failed connect
attempt without a look at the source.
Signed-off-by: Johannes Thumshirn
---
This actually happened to Hannes
o add a regression test to blktests[1] for this?
[1] https://github.com/osandov/blktests
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnber
o add a regression test to blktests[1] for this?
[1] https://github.com/osandov/blktests
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnber
Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're
wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of
directly ORing it onto the SCSI command's result.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reported-by: Bart Van Assche <bart.vanass...@wd
Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're
wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of
directly ORing it onto the SCSI command's result.
Signed-off-by: Johannes Thumshirn
Reported-by: Bart Van Assche
Cc: Himanshu Madhani
---
drivers/scsi/qla2xxx
The SCSI host byte has to be shifted by 16 not 6.
As Bart pointed out this patch does not change any functionality
because DID_OK == 0, but a wrong shift is irritating for the reviewer.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Bart Van Assche <bart.vanass..
The SCSI host byte has to be shifted by 16 not 6.
As Bart pointed out this patch does not change any functionality
because DID_OK == 0, but a wrong shift is irritating for the reviewer.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Bart Van Assche
---
Changes to v1:
* Add Bart's review remark
On Fri, Apr 06, 2018 at 03:33:30PM +, Bart Van Assche wrote:
> On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote:
> > The host byte has to be shifted by 16 not 6.
> >
> > Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
> > ---
> > drive
On Fri, Apr 06, 2018 at 03:33:30PM +, Bart Van Assche wrote:
> On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote:
> > The host byte has to be shifted by 16 not 6.
> >
> > Signed-off-by: Johannes Thumshirn
> > ---
> > drivers/scsi/qla2xxx/qla_is
nks for the review.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C
On Fri, Apr 06, 2018 at 03:01:20PM +, Bart Van Assche wrote:
> Please mention in the description of this patch that this patch does not
> change any functionality because DID_OK == 0. Anyway:
>
> Reviewed-by: Bart Van Assche
I'll do. Thanks for the review.
--
Johann
The host byte has to be shifted by 16 not 6.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/qla2xxx/qla_isr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 89f93e
The host byte has to be shifted by 16 not 6.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/qla2xxx/qla_isr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 89f93ebd819d..49d67e1d571f 100644
On Mon, 2018-04-02 at 13:53 +, Bart Van Assche wrote:
> A similar patch has already been queued by Martin. See also
> https://patchwork.kernel.org/patch/10313569/.
Ah OK, fine then :-)
--
Johannes Thumshirn Storage
jthumsh...@s
On Mon, 2018-04-02 at 13:53 +, Bart Van Assche wrote:
> A similar patch has already been queued by Martin. See also
> https://patchwork.kernel.org/patch/10313569/.
Ah OK, fine then :-)
--
Johannes Thumshirn Storage
jthumsh...@s
Coverity reports that we're assigning shost->use_blk_mq twice. This
looks like the result of a bad merge of commit 2f31115e940c ("scsi:
core: introduce force_blk_mq")
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/hosts.c | 1 -
1 file changed, 1 dele
Coverity reports that we're assigning shost->use_blk_mq twice. This
looks like the result of a bad merge of commit 2f31115e940c ("scsi:
core: introduce force_blk_mq")
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/hosts.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
; from the nvme host and "nvmet:
unsupported cmd 24" from the nvme target. If the patch is applied
dmesg is quiet.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
tests/nvme/003 | 61 ++
tests/nvme/003.out |
; from the nvme host and "nvmet:
unsupported cmd 24" from the nvme target. If the patch is applied
dmesg is quiet.
Signed-off-by: Johannes Thumshirn
---
tests/nvme/003 | 61 ++
tests/nvme/003.out | 2 ++
2 files changed, 63 ins
EFAULT_KATO for the discovery controller.
This can be easily remproduced when issuing a direct connect to the
discovery susbsystem using:
'nvme connect [...] --nqn=nqn.2014-08.org.nvmexpress.discovery'
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Fixes: 07bfcd09a288 ("nvme-fabrics:
EFAULT_KATO for the discovery controller.
This can be easily remproduced when issuing a direct connect to the
discovery susbsystem using:
'nvme connect [...] --nqn=nqn.2014-08.org.nvmexpress.discovery'
Signed-off-by: Johannes Thumshirn
Fixes: 07bfcd09a288 ("nvme-fabrics: add a generic NVMe over
nvme_start_keep_alive() isn't used outside core.c so unexport it and
make it static.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvme/host/core.c | 3 +--
drivers/nvme/host/nvme.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/host/
nvme_start_keep_alive() isn't used outside core.c so unexport it and
make it static.
Signed-off-by: Johannes Thumshirn
---
drivers/nvme/host/core.c | 3 +--
drivers/nvme/host/nvme.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host
on NULL names.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/scsi_dh.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index b88b5dbbc444..188f30572aa1 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scs
on NULL names.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/scsi_dh.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index b88b5dbbc444..188f30572aa1 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scsi_dh.c
@@ -112,6 +112,9
nting down a bug in this subsystem.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (
nting down a bug in this subsystem.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (
Provide a module_nd_driver() wrapper and move over the appliccable
drivers nd_pmem.ko and dax_pmem.ko.
Johannes Thumshirn (3):
libnvdimm: provide module_nd_driver wrapper
libnvdimm, pmem: use module_nd_driver
device-dax: use module_nd_driver
drivers/dax/pmem.c| 12
Provide a module_nd_driver() wrapper and move over the appliccable
drivers nd_pmem.ko and dax_pmem.ko.
Johannes Thumshirn (3):
libnvdimm: provide module_nd_driver wrapper
libnvdimm, pmem: use module_nd_driver
device-dax: use module_nd_driver
drivers/dax/pmem.c| 12
()
function.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
include/linux/nd.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/nd.h b/include/linux/nd.h
index 5dc6b695437d..43c181a6add5 100644
--- a/include/linux/nd.h
+++ b/include/linux/nd.h
@@ -180,6 +
()
function.
Signed-off-by: Johannes Thumshirn
---
include/linux/nd.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/nd.h b/include/linux/nd.h
index 5dc6b695437d..43c181a6add5 100644
--- a/include/linux/nd.h
+++ b/include/linux/nd.h
@@ -180,6 +180,12 @@ struct nd_region;
void
Use module_nd_driver() instead of having module_init() and
module_exit() callbacks which just call nd_driver_register() and
nd_driver_unregister().
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/dax/pmem.c | 12 +---
1 file changed, 1 insertion(+), 11 del
Use module_nd_driver() instead of having module_init() and
module_exit() callbacks which just call nd_driver_register() and
nd_driver_unregister().
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvdimm/pmem.c | 12 +---
1 file changed, 1 insertion(+), 11 del
Use module_nd_driver() instead of having module_init() and
module_exit() callbacks which just call nd_driver_register() and
nd_driver_unregister().
Signed-off-by: Johannes Thumshirn
---
drivers/dax/pmem.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers
Use module_nd_driver() instead of having module_init() and
module_exit() callbacks which just call nd_driver_register() and
nd_driver_unregister().
Signed-off-by: Johannes Thumshirn
---
drivers/nvdimm/pmem.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git
Subject of 1/2 according to Bjorn
Changes to v1:
* Removed redundant pci_ids.h include
Johannes Thumshirn (2):
PCI: Add Altera vendor ID
mcb: add Altera PCI ID to mcb-pci
drivers/char/xillybus/xillybus_pcie.c | 1 -
drivers/fpga/altera-cvp.c | 2 --
drivers/mcb/mcb-pci.c
Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
of the MEN one. Add it to the PCI ID table so the driver automatically
attaches to it.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reported-by: Ben Turner <ben.tur...@21net.com>
Tested-by: Ben Tur
Add the Altera PCI Vendor id to pci_ids.h and remove the private
definitions from xillybus_pcie.c and altera-cvp.c.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Cc: Bjorn Helgaas <bhelg...@google.com>
Cc: Eli Billauer <eli.billa...@gmail.com>
Cc: Anatolij Gustschin <
Subject of 1/2 according to Bjorn
Changes to v1:
* Removed redundant pci_ids.h include
Johannes Thumshirn (2):
PCI: Add Altera vendor ID
mcb: add Altera PCI ID to mcb-pci
drivers/char/xillybus/xillybus_pcie.c | 1 -
drivers/fpga/altera-cvp.c | 2 --
drivers/mcb/mcb-pci.c
Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
of the MEN one. Add it to the PCI ID table so the driver automatically
attaches to it.
Signed-off-by: Johannes Thumshirn
Reported-by: Ben Turner
Tested-by: Ben Turner
Cc: Andreas Geißler
Reviewed-by: Andy Shevchenko
Add the Altera PCI Vendor id to pci_ids.h and remove the private
definitions from xillybus_pcie.c and altera-cvp.c.
Signed-off-by: Johannes Thumshirn
Cc: Bjorn Helgaas
Cc: Eli Billauer
Cc: Anatolij Gustschin
Acked-by: Eli Billauer
Acked-by: Bjorn Helgaas
Reviewed-by: Andy Shevchenko
(u64) s);
> >
> > I don't think you should remove this one. dev_info_once() is just a
> > printk(),
> > and doesn't inherit the +f flag from the dynamic debugging code. The
> > __func__
> > here does add value.
> >
> > The rest of these look correct, th
(u64) s);
> >
> > I don't think you should remove this one. dev_info_once() is just a
> > printk(),
> > and doesn't inherit the +f flag from the dynamic debugging code. The
> > __func__
> > here does add value.
> >
> > The rest of th
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
lly.
Sorry for the late response, I was some days off.
Thanks Dan,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smi
lly.
Sorry for the late response, I was some days off.
Thanks Dan,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smi
On Fri, Mar 02, 2018 at 02:11:02PM +, Jeremy Cline wrote:
> Sure, I'll take care of it.
Thanks a lot.
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr
On Fri, Mar 02, 2018 at 02:11:02PM +, Jeremy Cline wrote:
> Sure, I'll take care of it.
Thanks a lot.
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr
:
[ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10:
func: 1 input length: 0
Thus remove the stray __func__ printing.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/acpi/nfit/core.c | 75 +++-
1 file chang
:
[ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10:
func: 1 input length: 0
Thus remove the stray __func__ printing.
Signed-off-by: Johannes Thumshirn
---
drivers/acpi/nfit/core.c | 75 +++-
1 file changed, 36 insertions(+), 39
dev/sda
> 3. blockdev --getro /dev/sda
hi Jeremy,
Do you mind wiring up a testcase in blktest [1] for this? Given that
you already have a rather trivial reproducer.
[1] https://github.com/osandov/
Thanks,
Johannes
--
Johannes Thumshirn St
dev/sda
> 3. blockdev --getro /dev/sda
hi Jeremy,
Do you mind wiring up a testcase in blktest [1] for this? Given that
you already have a rather trivial reproducer.
[1] https://github.com/osandov/
Thanks,
Johannes
--
Johannes Thumshirn St
Add the Altera PCI Vendor id to pci_ids.h and remove the private
definitions from xillybus_pcie.c and altera-cvp.c.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Cc: Bjorn Helgaas <bhelg...@google.com>
Cc: Eli Billauer <eli.billa...@gmail.com>
Cc: Anatolij Gustsc
Add the Altera PCI Vendor id to pci_ids.h and remove the private
definitions from xillybus_pcie.c and altera-cvp.c.
Signed-off-by: Johannes Thumshirn
Cc: Bjorn Helgaas
Cc: Eli Billauer
Cc: Anatolij Gustschin
---
Changes to v1:
- Remove redundant pci_ids.h include (Andy)
---
drivers/char
include
Johannes Thumshirn (2):
PCI: add vendor id for Altera
mcb: add Altera PCI ID to mcb-pci
drivers/char/xillybus/xillybus_pcie.c | 1 -
drivers/fpga/altera-cvp.c | 2 --
drivers/mcb/mcb-pci.c | 1 +
include/linux/pci_ids.h | 2 ++
4 files changed, 3
include
Johannes Thumshirn (2):
PCI: add vendor id for Altera
mcb: add Altera PCI ID to mcb-pci
drivers/char/xillybus/xillybus_pcie.c | 1 -
drivers/fpga/altera-cvp.c | 2 --
drivers/mcb/mcb-pci.c | 1 +
include/linux/pci_ids.h | 2 ++
4 files changed, 3
Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
of the MEN one. Add it to the PCI ID table so the driver automatically
attaches to it.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reported-by: Ben Turner <ben.tur...@21net.com>
Tested-by: Ben Tur
Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
of the MEN one. Add it to the PCI ID table so the driver automatically
attaches to it.
Signed-off-by: Johannes Thumshirn
Reported-by: Ben Turner
Tested-by: Ben Turner
Cc: Andreas Geißler
---
Changes to v1:
- Removed
On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
> On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn <jthumsh...@suse.de>
> wrote:
> >
> > Add the Altera PCI Vendor id to pci_ids.h and remove the private
> > definitions from xillybus_pcie.c and alter
On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
> On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn
> wrote:
> >
> > Add the Altera PCI Vendor id to pci_ids.h and remove the private
> > definitions from xillybus_pcie.c and altera-cvp.c.
>
> &
Add the Altera PCI Vendor id to pci_ids.h and remove the private
definitions from xillybus_pcie.c and altera-cvp.c.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Cc: Bjorn Helgaas <bhelg...@google.com>
Cc: Eli Billauer <eli.billa...@gmail.com>
Cc: Anatolij Gustsc
Add the Altera PCI Vendor id to pci_ids.h and remove the private
definitions from xillybus_pcie.c and altera-cvp.c.
Signed-off-by: Johannes Thumshirn
Cc: Bjorn Helgaas
Cc: Eli Billauer
Cc: Anatolij Gustschin
---
drivers/char/xillybus/xillybus_pcie.c | 2 +-
drivers/fpga/altera-cvp.c
Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
of the MEN one. Add it to the PCI ID table so the driver automatically
attaches to it.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reported-by: Ben Turner <ben.tur...@21net.com>
Tested-by: Ben Tur
Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
of the MEN one. Add it to the PCI ID table so the driver automatically
attaches to it.
Signed-off-by: Johannes Thumshirn
Reported-by: Ben Turner
Tested-by: Ben Turner
Cc: Andreas Geißler
Cc: Michael Moese
---
drivers/mcb
which enables at least one carrier board. This was reported and tested
by Ben Turner.
Johannes Thumshirn (2):
PCI: add vendor id for Altera
mcb: add Altera PCI ID to mcb-pci
drivers/char/xillybus/xillybus_pcie.c | 2 +-
drivers/fpga/altera-cvp.c | 3 +--
drivers/mcb/mcb-pci.c
which enables at least one carrier board. This was reported and tested
by Ben Turner.
Johannes Thumshirn (2):
PCI: add vendor id for Altera
mcb: add Altera PCI ID to mcb-pci
drivers/char/xillybus/xillybus_pcie.c | 2 +-
drivers/fpga/altera-cvp.c | 3 +--
drivers/mcb/mcb-pci.c
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
301 - 400 of 2637 matches
Mail list logo
