[PATCH] nvme: initialize hostid uuid in nvmf_host_default to not leak kernel memory

G. this assumption is correct so initialize the host->id using uuid_gen() as it was done before commit 6bfe04255d5e ("nvme: add hostid token to fabric options"). Fixes: 6bfe04255d5e ("nvme: add hostid token to fabric options") Reported-by: Alexander Potapenko Signed-off-by:

Re: [PATCH] scsi: lpfc: don't dereference localport before it has been null checked

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] scsi: lpfc: don't dereference localport before it has been null checked

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

nce in this case. To me it looks like the plymouth folks have a slight disconnect from the server, or non-desktop world. We've already experienced this pattern in the world of init systems. Byte, Johannes -- Johannes Thumshirn St

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

nce in this case. To me it looks like the plymouth folks have a slight disconnect from the server, or non-desktop world. We've already experienced this pattern in the world of init systems. Byte, Johannes -- Johannes Thumshirn St

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

e shipping a general purpose distro and don't know on what hardware it will be installed. This is only my peronal view on this situation. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LI

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

e shipping a general purpose distro and don't know on what hardware it will be installed. This is only my peronal view on this situation. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LI

[PATCH] MAINTIANERS: change FCoE list to linux-scsi

fcoe-de...@open-fcoe.org is defunct and all patches are routed via the SCSI tree anyways. So update MAINTAINERS accordingly. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH] MAINTIANERS: change FCoE list to linux-scsi

fcoe-de...@open-fcoe.org is defunct and all patches are routed via the SCSI tree anyways. So update MAINTAINERS accordingly. Signed-off-by: Johannes Thumshirn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9e0045e3ee0c

Re: [PATCH] scsi: bfa: convert to strlcpy/strlcat

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] scsi: bfa: convert to strlcpy/strlcat

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: bfa: fix type conversion warning

Thanks Arnd, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] scsi: bfa: fix type conversion warning

Thanks Arnd, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284

Re: [PATCH] bfa: fix access to bfad_im_port_s

James Bottomley <james.bottom...@hansenpartnership.com> writes: > On Tue, 2017-11-28 at 16:26 +0100, Johannes Thumshirn wrote: >> Commit 'cd21c605b2cf ("scsi: fc: provide fc_bsg_to_shost() helper")' >> changed access to bfa's 'struct bfad_im_port_s' by using s

Re: [PATCH] bfa: fix access to bfad_im_port_s

James Bottomley writes: > On Tue, 2017-11-28 at 16:26 +0100, Johannes Thumshirn wrote: >> Commit 'cd21c605b2cf ("scsi: fc: provide fc_bsg_to_shost() helper")' >> changed access to bfa's 'struct bfad_im_port_s' by using shost_priv() >> instead of shost->hostda

Re: [PATCH] SCSI: run queue if SCSI device queue isn't ready and queue is idle

> echo "0" >/sys/bus/pseudo/drivers/scsi_debug/opts > wait > echo "SUCCESS" SO I turned the above into a blktest but have found some shortcommings of my bash skills. Maybe you or Omar has a soution for it: --- 8< --- >From 80e5810011d52bc188cd858962ce202bfd4dbee

Re: [PATCH] SCSI: run queue if SCSI device queue isn't ready and queue is idle

;/sys/bus/pseudo/drivers/scsi_debug/opts > wait > echo "SUCCESS" SO I turned the above into a blktest but have found some shortcommings of my bash skills. Maybe you or Omar has a soution for it: --- 8< --- >From 80e5810011d52bc188cd858962ce202bfd4dbee5 Mon Sep 17 00:00:00 20

Re: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready()

all, > so that means anyone can make a patch for blktest to test block/SCSI > timeout if he/she is interested in doing that. OK, let me see if I can spent some time on this the next days. Byte, Johannes -- Johannes Thumshirn

Re: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready()

ns anyone can make a patch for blktest to test block/SCSI > timeout if he/she is interested in doing that. OK, let me see if I can spent some time on this the next days. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready()

eep 5 > echo "0" >/sys/bus/pseudo/drivers/scsi_debug/opts > wait > echo "SUCCESS" Can you please submit a test-case for blktest as well, given you have a nice reproducer? Thanks, Johannes -- Johannes Thumshirn

Re: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready()

quot; >/sys/bus/pseudo/drivers/scsi_debug/opts > wait > echo "SUCCESS" Can you please submit a test-case for blktest as well, given you have a nice reproducer? Thanks, Johannes -- Johannes Thumshirn Storage jth

Re: [PATCH v2] nvme-fc: don't require user to enter host_traddr

James Smart <james.sm...@broadcom.com> writes: > On 11/30/2017 7:12 AM, Johannes Thumshirn wrote: >> One major usability difference between NVMf RDMA and FC is resolving >> the default host transport address in RDMA. This is perfectly doable >> in FC as well, as we alre

Re: [PATCH v2] nvme-fc: don't require user to enter host_traddr

James Smart writes: > On 11/30/2017 7:12 AM, Johannes Thumshirn wrote: >> One major usability difference between NVMf RDMA and FC is resolving >> the default host transport address in RDMA. This is perfectly doable >> in FC as well, as we already have all possible lport <

[PATCH v2] nvme-fc: don't require user to enter host_traddr

esired rport per default or optionally use the user supplied lport if we have one. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Cc: James Smart <james.sm...@broadcom.com> -- Changes to v1: - Both laddr.pn and laddr.nn must be present _if_ we take the laddr into account (Hannes)

[PATCH v2] nvme-fc: don't require user to enter host_traddr

esired rport per default or optionally use the user supplied lport if we have one. Signed-off-by: Johannes Thumshirn Cc: James Smart -- Changes to v1: - Both laddr.pn and laddr.nn must be present _if_ we take the laddr into account (Hannes) --- drivers/nvme/host/fc.c | 19 ---

[PATCH] nvme-fc: don't require user to enter host_traddr

esired rport per default or optionally use the user supplied lport if we have one. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Cc: James Smart <james.sm...@broadcom.com> --- drivers/nvme/host/fc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) di

[PATCH] nvme-fc: don't require user to enter host_traddr

esired rport per default or optionally use the user supplied lport if we have one. Signed-off-by: Johannes Thumshirn Cc: James Smart --- drivers/nvme/host/fc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c

[PATCH] bfa: fix access to bfad_im_port_s

2/0x6d Fixes: cd21c605b2cf ("scsi: fc: provide fc_bsg_to_shost() helper") Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Cc: Michal Koutný <mkou...@suse.com> --- drivers/scsi/bfa/bfad_bsg.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scs

[PATCH] bfa: fix access to bfad_im_port_s

2/0x6d Fixes: cd21c605b2cf ("scsi: fc: provide fc_bsg_to_shost() helper") Signed-off-by: Johannes Thumshirn Cc: Michal Koutný --- drivers/scsi/bfa/bfad_bsg.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c index 72c

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

re > i2c_algo_bit i2c_core crc32c_intel isci libsas scsi_transport_sas dca ipv6 > CPU: 0 PID: 705 Comm: kworker/u240:0 Not tainted 4.1.35.el7.x86_64 #1 This should by now be fixed with commit fbce4d97fd43 ("scsi: fixup kernel warning during rmmod()" which w

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

re > i2c_algo_bit i2c_core crc32c_intel isci libsas scsi_transport_sas dca ipv6 > CPU: 0 PID: 705 Comm: kworker/u240:0 Not tainted 4.1.35.el7.x86_64 #1 This should by now be fixed with commit fbce4d97fd43 ("scsi: fixup kernel warning during rmmod()" which w

Re: [PATCH] scsi: debug: remove jiffies_to_timespec

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] scsi: debug: remove jiffies_to_timespec

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: libfc: fix ELS request handling

Thanks Martin, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Sm

Re: [PATCH] scsi: libfc: fix ELS request handling

Thanks Martin, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284

Re: [PATCH 0/6] v4 block refcount conversion patches

ions compare in performance (throughput and latency) vs atomics? It should be quite easy to measure against a null_blk device. Thanks a lot, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUS

Re: [PATCH 0/6] v4 block refcount conversion patches

ghput and latency) vs atomics? It should be quite easy to measure against a null_blk device. Thanks a lot, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 904

Re: [PATCH] scsi: libfc: Convert timers to use timer_setup()

Looks good, Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH] scsi: libfc: Convert timers to use timer_setup()

Looks good, Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: use set_host_byte instead of open-coding it

0 files changed, 589 insertions(+), 540 deletions(-) Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham No

Re: [PATCH] scsi: use set_host_byte instead of open-coding it

0 files changed, 589 insertions(+), 540 deletions(-) Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham No

[PATCH v3] scsi: fc: check for rport presence in fc_block_scsi_eh

of the API gracefully. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Bart Van Assche <bart.vanass...@wdc.com> Reviewed-by: Hannes Reinecke <h...@suse.de> --- Martin, I'm not sure if I have already sent it out or not if I already did send this v3 please ignore

[PATCH v3] scsi: fc: check for rport presence in fc_block_scsi_eh

of the API gracefully. Signed-off-by: Johannes Thumshirn Reviewed-by: Bart Van Assche Reviewed-by: Hannes Reinecke --- Martin, I'm not sure if I have already sent it out or not if I already did send this v3 please ignore it. Changes since v2: - return FAST_IO_FAIL instead of 0 (Steffen) Changes

[PATCH] scsi: use set_host_byte instead of open-coding it

Call set_host_byte() instead of open-coding it. Converted using this simple Coccinelle spatch @@ local idexpression struct scsi_cmnd *c; expression E1; @@ - c->result = E1 << 16; + set_host_byte(c, E1); Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Cc: St

[PATCH] scsi: use set_host_byte instead of open-coding it

Call set_host_byte() instead of open-coding it. Converted using this simple Coccinelle spatch @@ local idexpression struct scsi_cmnd *c; expression E1; @@ - c->result = E1 << 16; + set_host_byte(c, E1); Signed-off-by: Johannes Thumshirn Cc: Steffen Maier Cc: Tejun Heo Cc: Bart V

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

@(none)$ pwd > /sys/devices/platform/HISI0162:01/host0/port-0:0/expander-0:0/port-0:0:7/end_device-0:0:7 > root@(none)$ more ./target0:0:3/0:0:3:0/block/sdd/queue/scheduler > noop [cfq] Maybe missing CONFIG_IOSCHED_DEADLINE? Thanks, Johannes -- Joh

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

@(none)$ pwd > /sys/devices/platform/HISI0162:01/host0/port-0:0/expander-0:0/port-0:0:7/end_device-0:0:7 > root@(none)$ more ./target0:0:3/0:0:3:0/block/sdd/queue/scheduler > noop [cfq] Maybe missing CONFIG_IOSCHED_DEADLINE? Thanks, Johannes -- Joh

Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

), msg and driver byte will follow as well. But all this is on top of this patch, which IMHO is stable material (we had an actual customer bug with this). Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911

Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

), msg and driver byte will follow as well. But all this is on top of this patch, which IMHO is stable material (we had an actual customer bug with this). Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911

Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

sult = DID_" drivers/scsi/ | wc -l 419 -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (

Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

sult = DID_" drivers/scsi/ | wc -l 419 -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (

[PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

The SCSI host byte should be shifted left by 16 in order to have scsi_decide_disposition() do the right thing (.i.e. requeue the command). Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Fixes: 661134ad3765 ("[SCSI] libiscsi, bnx2i: make bound ep check common") Cc:

[PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

The SCSI host byte should be shifted left by 16 in order to have scsi_decide_disposition() do the right thing (.i.e. requeue the command). Signed-off-by: Johannes Thumshirn Fixes: 661134ad3765 ("[SCSI] libiscsi, bnx2i: make bound ep check common") Cc: Lee Duncan Cc: Hannes Reinecke

Re: [PATCH] Fix mpage_writepage() for pages with buffers

Acked-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH] Fix mpage_writepage() for pages with buffers

Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH] libnvdimm, namespace: make a couple of functions static

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] libnvdimm, namespace: make a couple of functions static

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: aic7xxx: make a couple of functions static

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] scsi: aic7xxx: make a couple of functions static

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: fcoe: Convert timers to use timer_setup()

Looks good, Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH] scsi: fcoe: Convert timers to use timer_setup()

Looks good, Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [BUG] scsi/fcoe: Sleep-in-atomic bugs in fcoe driver

or the report, coincidentally I have a bug report for this as well (in a real setup not just static analysis) and gave the reporter a patch to test. Once it's verified I'll post it here. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.d

Re: [BUG] scsi/fcoe: Sleep-in-atomic bugs in fcoe driver

or the report, coincidentally I have a bug report for this as well (in a real setup not just static analysis) and gave the reporter a patch to test. Once it's verified I'll post it here. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.d

[PATCH 2/6] block: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 2/6] block: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk

[PATCH 0/6] Add kmalloc_array_node() and kcalloc_node()

overflows. Johannes Thumshirn (6): mm: add kmalloc_array_node and kcalloc_node block: use kmalloc_array_node IB/qib: use kmalloc_array_node IB/rdmavt: use kmalloc_array_node mm, mempool: use kmalloc_array_node rds: ib: use kmalloc_array_node block/blk-mq.c | 2

[PATCH 0/6] Add kmalloc_array_node() and kcalloc_node()

overflows. Johannes Thumshirn (6): mm: add kmalloc_array_node and kcalloc_node block: use kmalloc_array_node IB/qib: use kmalloc_array_node IB/rdmavt: use kmalloc_array_node mm, mempool: use kmalloc_array_node rds: ib: use kmalloc_array_node block/blk-mq.c | 2

[PATCH 3/6] IB/qib: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/infiniband/hw/qib/qib_init.c | 5 +++-- 1 file changed, 3 insertions

[PATCH 4/6] IB/rdmavt: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/infiniband/sw/rdmavt/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 3/6] IB/qib: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn --- drivers/infiniband/hw/qib/qib_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 4/6] IB/rdmavt: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn --- drivers/infiniband/sw/rdmavt/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 6/6] rds: ib: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- net/rds/ib_fmr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 6/6] rds: ib: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn --- net/rds/ib_fmr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rds/ib_fmr.c b

[PATCH 1/6] mm: add kmalloc_array_node and kcalloc_node

is not aware of any possible overflows in eventual size calculations. Introduce a combination of the two above cases to have a NUMA-node aware version of kmalloc_array() and kcalloc(). Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- include/linux/slab.h | 16 1 file c

[PATCH 5/6] mm, mempool: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- mm/mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 1/6] mm: add kmalloc_array_node and kcalloc_node

is not aware of any possible overflows in eventual size calculations. Introduce a combination of the two above cases to have a NUMA-node aware version of kmalloc_array() and kcalloc(). Signed-off-by: Johannes Thumshirn --- include/linux/slab.h | 16 1 file changed, 16 insertions

[PATCH 5/6] mm, mempool: use kmalloc_array_node

Now that we have a NUMA-aware version of kmalloc_array() we can use it instead of kmalloc_node() without an overflow check in the size calculation. Signed-off-by: Johannes Thumshirn --- mm/mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mempool.c b/mm/mempool.c

[PATCH v2 1/1] scsi: fc: check for rport presence in fc_block_scsi_eh

of the API gracefully. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Bart Van Assche <bart.vanass...@wdc.com> --- Changes since v1: - s/WARN_ON/WARN_ON_ONCE/ (Bart) --- drivers/scsi/scsi_transport_fc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/

[PATCH v2 1/1] scsi: fc: check for rport presence in fc_block_scsi_eh

of the API gracefully. Signed-off-by: Johannes Thumshirn Reviewed-by: Bart Van Assche --- Changes since v1: - s/WARN_ON/WARN_ON_ONCE/ (Bart) --- drivers/scsi/scsi_transport_fc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi

Re: [PATCH] scsi: fc: check for rport presence in fc_block_scsi_eh

On Mon, Sep 25, 2017 at 11:29:07PM +, Bart Van Assche wrote: > Did you perhaps intend to use WARN_ON_ONCE() instead of WARN_ON()? Now that you're saying it. I'll send a v2. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse

Re: [PATCH] scsi: fc: check for rport presence in fc_block_scsi_eh

On Mon, Sep 25, 2017 at 11:29:07PM +, Bart Van Assche wrote: > Did you perhaps intend to use WARN_ON_ONCE() instead of WARN_ON()? Now that you're saying it. I'll send a v2. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse

[PATCH] scsi: fc: check for rport presence in fc_block_scsi_eh

of the API gracefully. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/scsi_transport_fc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index ba9d70f8a6a1..830ce53f30fb 100644 --- a/driver

[PATCH] scsi: fc: check for rport presence in fc_block_scsi_eh

of the API gracefully. Signed-off-by: Johannes Thumshirn --- drivers/scsi/scsi_transport_fc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index ba9d70f8a6a1..830ce53f30fb 100644 --- a/drivers/scsi/scsi_transport_fc.c

Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable

On Wed, Sep 20, 2017 at 04:59:31PM +0200, Christoph Hellwig wrote: > On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote: > > Notify sysfs about changes of a nvme controller so user-space can watch the > > file via poll() or select() in order to react to

Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable

On Wed, Sep 20, 2017 at 04:59:31PM +0200, Christoph Hellwig wrote: > On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote: > > Notify sysfs about changes of a nvme controller so user-space can watch the > > file via poll() or select() in order to react to

[PATCH] nvme: make controller 'state' sysfs attribute pollable

Notify sysfs about changes of a nvme controller so user-space can watch the file via poll() or select() in order to react to a state change. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/host/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH] nvme: make controller 'state' sysfs attribute pollable

Notify sysfs about changes of a nvme controller so user-space can watch the file via poll() or select() in order to react to a state change. Signed-off-by: Johannes Thumshirn --- drivers/nvme/host/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host

Re: [PATCH 3/3] memremap: add scheduling point to devm_memremap_pages

Tested-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 3/3] memremap: add scheduling point to devm_memremap_pages

Tested-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH 2/3] mm, page_alloc: add scheduling point to memmap_init_zone

Tested-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 2/3] mm, page_alloc: add scheduling point to memmap_init_zone

Tested-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH 1/3] mm, memory_hotplug: add scheduling point to __add_pages

Tested-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 1/3] mm, memory_hotplug: add scheduling point to __add_pages

Tested-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

[PATCH] samples/kprobes: Add s390 case in kprobe example module

Add info prints in sample kprobe handlers for S/390 Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- samples/kprobes/kprobe_example.c | 8 1 file changed, 8 insertions(+) diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c index 88b3e2

[PATCH] samples/kprobes: Add s390 case in kprobe example module

Add info prints in sample kprobe handlers for S/390 Signed-off-by: Johannes Thumshirn --- samples/kprobes/kprobe_example.c | 8 1 file changed, 8 insertions(+) diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c index 88b3e2d227ae..67de3b774bc9 100644

Re: [PATCH] Support for secure erase functionality

rwards? I'm sorry, but while I get that this sounds like a nice feature for a paper or reasearch project, I don't see why it should be used on production systems at all. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH] Support for secure erase functionality

rwards? I'm sorry, but while I get that this sounds like a nice feature for a paper or reasearch project, I don't see why it should be used on production systems at all. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

; Signed-off-by: Khazhismel Kumykov <kha...@google.com> > > Why is this needed? I dislike changes that don't fix anything. The function has no more users left after patch 1, so why keep it bitrotting? -- Johannes Thumshirn Storage jthumsh...@sus

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

; Signed-off-by: Khazhismel Kumykov > > Why is this needed? I dislike changes that don't fix anything. The function has no more users left after patch 1, so why keep it bitrotting? -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH] scsi: acornscsi: fix build error

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

<    1   2   3   4   5   6   7   8   9   10   >