On 06/15/2017 06:31 PM, Christoph Hellwig wrote:
> On Wed, Jun 07, 2017 at 11:45:27AM +0200, Johannes Thumshirn wrote:
>> A patch for nvmetcli and nvme-cli will follow shortly.
>
> Can you send them out? Especially as I want to debug why I don't seem
> to get a uuid attrib
On 06/14/2017 02:57 PM, John Garry wrote:
> On 14/06/2017 12:52, Johannes Thumshirn wrote:
>> libsas uses scsi_queue_work() to queue it's internal event
>> notifications. scsi_queue_work() can return -EINVAL if the work queue
>> doesn't exist and it does call queue_work() w
On 06/14/2017 02:57 PM, John Garry wrote:
> On 14/06/2017 12:52, Johannes Thumshirn wrote:
>> libsas uses scsi_queue_work() to queue it's internal event
>> notifications. scsi_queue_work() can return -EINVAL if the work queue
>> doesn't exist and it does call queue_work() w
,
which is handy when changing to dynamically allocated work in libsas
as well, as discussed here: https://lkml.org/lkml/2017/6/14/121.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/libsas/sas_event.c| 36 ++--
drivers/scsi/
,
which is handy when changing to dynamically allocated work in libsas
as well, as discussed here: https://lkml.org/lkml/2017/6/14/121.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/libsas/sas_event.c| 36 ++--
drivers/scsi/libsas/sas_internal.h | 4
* their siblings when forming wide ports */
/* LLDD calls these to notify the class of an event. */
- void (*notify_ha_event)(struct sas_ha_struct *, enum ha_event);
+ int (*notify_ha_event)(struct sas_ha_struct *, enum ha_event);
void (*notify_port_event)(struct asd_sas
* their siblings when forming wide ports */
/* LLDD calls these to notify the class of an event. */
- void (*notify_ha_event)(struct sas_ha_struct *, enum ha_event);
+ int (*notify_ha_event)(struct sas_ha_struct *, enum ha_event);
void (*notify_port_event)(struct asd_sas
e
>we use former wait-complete to achieve a sas event atomic process and use
> latter to
>make a sas discovery sync.
> 4. remove disco_mutex in sas_revalidate_domain, since now
> sas_revalidate_domain sync
>the destruct discovery event execution, it's no need t
e
>we use former wait-complete to achieve a sas event atomic process and use
> latter to
>make a sas discovery sync.
> 4. remove disco_mutex in sas_revalidate_domain, since now
> sas_revalidate_domain sync
>the destruct discovery event execution, it's no need t
d sas_hash_addr(u8 *hashed, const u8 *sas_addr)
>
> void sas_hae_reset(struct work_struct *work)
> {
> - struct sas_ha_event *ev = to_sas_ha_event(work);
> - struct sas_ha_struct *ha = ev->ha;
> -
> - clear_bit(HAE_RESET, >pending);
> }
I don't r
t work_struct *work)
> {
> - struct sas_ha_event *ev = to_sas_ha_event(work);
> - struct sas_ha_struct *ha = ev->ha;
> -
> - clear_bit(HAE_RESET, >pending);
> }
I don't really get why you need a stubbed out sas_hae_reset(). Can't we
just kill it if it doesn't h
f (scmnd->device->host->transportt == fc_transport_template)
> + return fc_eh_timed_out(scmnd);
> +#endif
Can you please change the #if IS_ENABLED() to
if(IS_ENABLED(CONFIG_SCSI_FC_ATTRS)
&& scmnd->device->ho
turn fc_eh_timed_out(scmnd);
> +#endif
Can you please change the #if IS_ENABLED() to
if(IS_ENABLED(CONFIG_SCSI_FC_ATTRS)
&& scmnd->device->host->transportt == fc_transport_template)
That way we have better compiler coverage.
Thanks,
Johannes
--
Johannes Thumshi
over.
>
> Signed-off-by: Long Li <lon...@microsoft.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX Gmb
Long Li
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norto
ing organization. Bytes
111:104 contain the vendor specific extension identifier assigned by the
corresponding organization. See the IEEE EUI-64 guidelines for more
information."
But maybe Christoph can clarify it.
Byte,
Johannes
--
Johannes Thumshirn
ing organization. Bytes
111:104 contain the vendor specific extension identifier assigned by the
corresponding organization. See the IEEE EUI-64 guidelines for more
information."
But maybe Christoph can clarify it.
Byte,
Johannes
--
Johannes Thumshirn
struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t and
use the UUID API.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvme/host/core.c | 8
drivers/nvme/host/nvme.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/driver
struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t and
use the UUID API.
Signed-off-by: Johannes Thumshirn
---
drivers/nvme/host/core.c | 8
drivers/nvme/host/nvme.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/nvme/host/core.c b
struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvme/host/core.c | 8
drivers/nvme/host/nvme.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/nvme/host/core.c b/d
struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t.
Signed-off-by: Johannes Thumshirn
---
drivers/nvme/host/core.c | 8
drivers/nvme/host/nvme.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
, but clearly has media
centric semantics and doesn't fool someone into thinking specific
parts are defined for a specific kernel version only like in out of
tree drivers.
Johannes Thumshirn (7):
[media] media: introduce MEDIA_REVISION macro
video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION
, but clearly has media
centric semantics and doesn't fool someone into thinking specific
parts are defined for a specific kernel version only like in out of
tree drivers.
Johannes Thumshirn (7):
[media] media: introduce MEDIA_REVISION macro
video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION
Don't use the KERNEL_VERSION() macro for the v4l2 capabilities, use
MEDIA_REVISION instead.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/video/fbdev/matrox/matroxfb_base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/
Use MEDIA_REVISON instead of KERNEL_VERSION to encode the driver
version.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/media/platform/s3c-camif/camif-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s3c-camif/camif-cor
Don't use the KERNEL_VERSION() macro for the v4l2 capabilities, use
MEDIA_REVISION instead.
Signed-off-by: Johannes Thumshirn
---
drivers/video/fbdev/matrox/matroxfb_base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c
b
Use MEDIA_REVISON instead of KERNEL_VERSION to encode the driver
version.
Signed-off-by: Johannes Thumshirn
---
drivers/media/platform/s3c-camif/camif-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s3c-camif/camif-core.c
b/drivers/media
Use MEDIA_VERSION instead of KERNEL_VERSION to encode the driver
version of the Atom ISP driver.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/staging/media/atomisp/include/linux/atomisp.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
Use MEDIA_REVISION isntead of KERNEL_VERSION to encode the bcm2048
driver version.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048
Use MEDIA_VERSION instead of KERNEL_VERSION to encode the driver
version of the Atom ISP driver.
Signed-off-by: Johannes Thumshirn
---
drivers/staging/media/atomisp/include/linux/atomisp.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp
Use MEDIA_REVISION isntead of KERNEL_VERSION to encode the bcm2048
driver version.
Signed-off-by: Johannes Thumshirn
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers
Use MEDIA_REVISION instead of KERNEL_VERSION to encode the
CX25821_VERSION_CODE.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/media/pci/cx25821/cx25821.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx25821/cx25821.h
b/drivers
Use MEDIA_REVISION instead of KERNEL_VERSION to encode the
CX25821_VERSION_CODE.
Signed-off-by: Johannes Thumshirn
---
drivers/media/pci/cx25821/cx25821.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx25821/cx25821.h
b/drivers/media/pci/cx25821/cx25821
Update the documentation to introduce the use of MEDIA_REVISON instead
of KERNEL_VERSION for the verison triplets of a media drivers hardware
revision or driver version.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst
Update the documentation to introduce the use of MEDIA_REVISON instead
of KERNEL_VERSION for the verison triplets of a media drivers hardware
revision or driver version.
Signed-off-by: Johannes Thumshirn
---
Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst| 2 +-
Documentation/media
Currently the media code abuses the KERNEL_VERSION macro to encode a
version triplet.
Introduce a MEDIA_REVISION macro to get rid of the confusing and
creative KERNEL_VERSION usage in the media subsystem.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
include/uapi/linux/media
Currently the media code abuses the KERNEL_VERSION macro to encode a
version triplet.
Introduce a MEDIA_REVISION macro to get rid of the confusing and
creative KERNEL_VERSION usage in the media subsystem.
Signed-off-by: Johannes Thumshirn
---
include/uapi/linux/media.h | 4 +++-
1 file changed
Change the few left over users of ctrl->dev over to using ctrl->device
for logging purposes, so we consistently use the same device.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Sagi Grimberg <s...@grimberg.me>
---
Changes to v1:
* Fix build
driver
Change the few left over users of ctrl->dev over to using ctrl->device
for logging purposes, so we consistently use the same device.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Sagi Grimberg
---
Changes to v1:
* Fix build
drivers/nvme/host/core.c | 10 +-
1 file chan
t; };
Can you please add the new values to the enum in uapi/ndctl.h? I don't
really like the magic numbers here.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409
t; };
Can you please add the new values to the enum in uapi/ndctl.h? I don't
really like the magic numbers here.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409
On 06/08/2017 09:52 AM, Christoph Hellwig wrote:
> On Thu, Jun 08, 2017 at 09:49:35AM +0200, Johannes Thumshirn wrote:
>> On 06/08/2017 09:44 AM, Christoph Hellwig wrote:
>>>> + if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off)
>>&
On 06/08/2017 09:52 AM, Christoph Hellwig wrote:
> On Thu, Jun 08, 2017 at 09:49:35AM +0200, Johannes Thumshirn wrote:
>> On 06/08/2017 09:44 AM, Christoph Hellwig wrote:
>>>> + if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off)
>>&
in `ls /dev/loop[0-9]*|sort`; do \
> echo $f; dd if=$f of=/dev/null bs=512 count=1; \
> done
I think Christoph already asked this, but can you send a patch for
blktests [1] as well?
Thanks,
Johannes
[1] https://github.com/osandov
in `ls /dev/loop[0-9]*|sort`; do \
> echo $f; dd if=$f of=/dev/null bs=512 count=1; \
> done
I think Christoph already asked this, but can you send a patch for
blktests [1] as well?
Thanks,
Johannes
[1] https://github.com/osandov
t; gracefully, but still..
Ahm yes. *doh*
Can you fix it up when applying?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
t; gracefully, but still..
Ahm yes. *doh*
Can you fix it up when applying?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
gt; + size_t buflen, off_t skip);
>
> Maybe sg_zero_buffer to fit with the other functions in the family?
>
> (I'd be happy to fix this up if you're ok and we don't need another
> respin otherwise).
Sounds good.
--
Johannes Thumshirn
gt; + size_t buflen, off_t skip);
>
> Maybe sg_zero_buffer to fit with the other functions in the family?
>
> (I'd be happy to fix this up if you're ok and we don't need another
> respin otherwise).
Sounds good.
--
Johannes Thumshirn
On 06/07/2017 03:47 PM, Andy Shevchenko wrote:
> I suppose it should go through UUID tree?
Yup.
The whole series is based on the UUID tree, so I though Christoph will
pick it up after uuid/for-next is merged.
--
Johannes Thumshirn Storage
jthu
On 06/07/2017 03:47 PM, Andy Shevchenko wrote:
> I suppose it should go through UUID tree?
Yup.
The whole series is based on the UUID tree, so I though Christoph will
pick it up after uuid/for-next is merged.
--
Johannes Thumshirn Storage
jthu
Change the few left over users of ctrl->dev over to using ctrl->device
for logging purposes, so we consistently use the same device.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/nvme/host/core.c | 10 +-
drivers/nvme/host/fc.c | 12 ++--
2 f
Change the few left over users of ctrl->dev over to using ctrl->device
for logging purposes, so we consistently use the same device.
Signed-off-by: Johannes Thumshirn
---
drivers/nvme/host/core.c | 10 +-
drivers/nvme/host/fc.c | 12 ++--
2 files changed, 11 insertions(
The sg_zeroout_area() helper is used to zero fill an area in a SG
list.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
include/linux/scatterlist.h | 3 +++
lib/scatterlist.c | 37 +
2 files changed, 40 insertions(+)
diff --git a/i
The sg_zeroout_area() helper is used to zero fill an area in a SG
list.
Signed-off-by: Johannes Thumshirn
---
include/linux/scatterlist.h | 3 +++
lib/scatterlist.c | 37 +
2 files changed, 40 insertions(+)
diff --git a/include/linux/scatterlist.h
o maintain backward compatibiliy with older implementations
without Namespace Identify Descriptor list support.
Also as the Namespace Identify Descriptor list is the only mandatory
feature change between 1.2.1 and 1.3 we can bump the advertised
version as well.
Signed-off-by: Johannes Thumshir
o maintain backward compatibiliy with older implementations
without Namespace Identify Descriptor list support.
Also as the Namespace Identify Descriptor list is the only mandatory
feature change between 1.2.1 and 1.3 we can bump the advertised
version as well.
Signed-off-by: Johannes Thumshirn
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Max Gurtovoy <m...@mellanox.com>
Reviewed-by: Sagi Grimberg <s...@grimberg.me>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
include/linux/nvme.h | 17 +
1 file changed, 17 insertions(
Signed-off-by: Johannes Thumshirn
Reviewed-by: Max Gurtovoy
Reviewed-by: Sagi Grimberg
Reviewed-by: Hannes Reinecke
---
include/linux/nvme.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index c004af5faa48..01d75c2b32a6
Allow overriding the announced NVMe Version of a via configfs.
This is particularly helpful when debugging new features for the host
or target side without bumping the hard coded version (as the target
might not be fully compliant to the announced version yet).
Signed-off-by: Johannes Thumshirn
for the
NGUID. For the UUID attribute add a check wheter the namespace has a
UUID assigned to it and return this or return the NGUID to maintain
backwards compatibility. This should give userspace a chance to catch
up.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Christoph Hell
Allow overriding the announced NVMe Version of a via configfs.
This is particularly helpful when debugging new features for the host
or target side without bumping the hard coded version (as the target
might not be fully compliant to the announced version yet).
Signed-off-by: Johannes Thumshirn
for the
NGUID. For the UUID attribute add a check wheter the namespace has a
UUID assigned to it and return this or return the NGUID to maintain
backwards compatibility. This should give userspace a chance to catch
up.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Christoph Hellwig
Reviewed-by: Hannes
Add the UUID field from the NVMe Namespace Identification Descriptor
to the nvmet_ns structure and allow it's population via configfs.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Max Gurtovoy <m...@mellanox.com>
Reviewed-by: Sagi Grimberg <s...@grimbe
Add the UUID field from the NVMe Namespace Identification Descriptor
to the nvmet_ns structure and allow it's population via configfs.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Max Gurtovoy
Reviewed-by: Sagi Grimberg
Reviewed-by: Hannes Reinecke
---
drivers/nvme/target/configfs.c | 31
uid_be instead of u8[] (Christoph)
* Add ability to override target's version (Hannes)
* Change hard coded magic 4096 and 0x1000 to SZ_4k in drivers/nvme/*
Johannes Thumshirn (10):
scatterlist: add sg_zeroout_area() helper
nvmet: use NVME_IDENTIFY_DATA_SIZE
nvme: introduce NVMe Namespace Identifi
Use NVME_IDENTIFY_DATA_SIZE define instead of hard coding the magic
4096 value.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Max Gurtovoy <m...@mellanox.com>
Reviewed-by: Sagi Grimberg <s...@grimberg.me>
Reviewed-by: Hannes Reinecke <h...@suse.com>
uid_be instead of u8[] (Christoph)
* Add ability to override target's version (Hannes)
* Change hard coded magic 4096 and 0x1000 to SZ_4k in drivers/nvme/*
Johannes Thumshirn (10):
scatterlist: add sg_zeroout_area() helper
nvmet: use NVME_IDENTIFY_DATA_SIZE
nvme: introduce NVMe Namespace Identifi
Use NVME_IDENTIFY_DATA_SIZE define instead of hard coding the magic
4096 value.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Max Gurtovoy
Reviewed-by: Sagi Grimberg
Reviewed-by: Hannes Reinecke
---
drivers/nvme/target/admin-cmd.c | 4 ++--
drivers/nvme/target/discovery.c | 2 +-
include
the nguid to sysfs in the uuid
sysfs attribute, but this can't be changed anymore without possibly
breaking existing userspace.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Reviewed-by
the nguid to sysfs in the uuid
sysfs attribute, but this can't be changed anymore without possibly
breaking existing userspace.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Reviewed-by: Sagi Grimberg
---
drivers/nvme/host/core.c | 10
If a target identifies itself as NVMe 1.3 compliant, try to get the
list of Namespace Identification Descriptors and populate the UUID,
NGUID and EUI64 fileds in the NVMe namespace structure with these
values.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Hannes Reine
If a target identifies itself as NVMe 1.3 compliant, try to get the
list of Namespace Identification Descriptors and populate the UUID,
NGUID and EUI64 fileds in the NVMe namespace structure with these
values.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/nvme/host
'\0' and not 0?
Shouldn't be a difference, should it? ascii(7) says
'000 0 00NUL '\0' (null character)'
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nür
'\0' and not 0?
Shouldn't be a difference, should it? ascii(7) says
'000 0 00NUL '\0' (null character)'
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nür
On 06/06/2017 08:27 PM, Sagi Grimberg wrote:
>
>> * I'm not sure if I shall use nvme_ns_identifier_hdr or nvme_ns_id_desc
>
> I was kinda hoping you will :(
>
> I won't insist if people are fine with that as is...
OK, I'll change it for ya :-)
-
On 06/06/2017 08:27 PM, Sagi Grimberg wrote:
>
>> * I'm not sure if I shall use nvme_ns_identifier_hdr or nvme_ns_id_desc
>
> I was kinda hoping you will :(
>
> I won't insist if people are fine with that as is...
OK, I'll change it for ya :-)
-
s(ns, ns->ns_id))
>> +dev_warn(ns->ctrl->dev,
>
> ctrl->device
Gah I though I have all of 'em in my series.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LIN
s(ns, ns->ns_id))
>> +dev_warn(ns->ctrl->dev,
>
> ctrl->device
Gah I though I have all of 'em in my series.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LIN
Use NVME_IDENTIFY_DATA_SIZE define instead of hard coding the magic
4096 value.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Max Gurtovoy <m...@mellanox.com>
Reviewed-by: Sagi Grimberg <s...@grimberg.me>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Use NVME_IDENTIFY_DATA_SIZE define instead of hard coding the magic
4096 value.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Max Gurtovoy
Reviewed-by: Sagi Grimberg
Reviewed-by: Hannes Reinecke
---
drivers/nvme/target/admin-cmd.c | 4 ++--
drivers/nvme/target/discovery.c | 2 +-
include
Allow overriding the announced NVMe Version of a via configfs.
This is particularly helpful when debugging new features for the host
or target side without bumping the hard coded version (as the target
might not be fully compliant to the announced version yet).
Signed-off-by: Johannes Thumshirn
Allow overriding the announced NVMe Version of a via configfs.
This is particularly helpful when debugging new features for the host
or target side without bumping the hard coded version (as the target
might not be fully compliant to the announced version yet).
Signed-off-by: Johannes Thumshirn
for the
NGUID. For the UUID attribute add a check wheter the namespace has a
UUID assigned to it and return this or return the NGUID to maintain
backwards compatibility. This should give userspace a chance to catch
up.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Christoph Hell
for the
NGUID. For the UUID attribute add a check wheter the namespace has a
UUID assigned to it and return this or return the NGUID to maintain
backwards compatibility. This should give userspace a chance to catch
up.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Christoph Hellwig
Reviewed-by: Hannes
Add the UUID field from the NVMe Namespace Identification Descriptor
to the nvmet_ns structure and allow it's population via configfs.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Max Gurtovoy <m...@mellanox.com>
Reviewed-by: Sagi Grimberg <s...@grimbe
o maintain backward compatibiliy with older implementations
without Namespace Identify Descriptor list support.
Also as the Namespace Identify Descriptor list is the only mandatory
feature change between 1.2.1 and 1.3.0 we can bump the advertised
version as well.
Signed-off-by: Johannes Thumshir
Add the UUID field from the NVMe Namespace Identification Descriptor
to the nvmet_ns structure and allow it's population via configfs.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Max Gurtovoy
Reviewed-by: Sagi Grimberg
Reviewed-by: Hannes Reinecke
---
drivers/nvme/target/configfs.c | 31
o maintain backward compatibiliy with older implementations
without Namespace Identify Descriptor list support.
Also as the Namespace Identify Descriptor list is the only mandatory
feature change between 1.2.1 and 1.3.0 we can bump the advertised
version as well.
Signed-off-by: Johannes Thumshirn
(Christoph)
* Use uuid_be instead of u8[] (Christoph)
* Add ability to override target's version (Hannes)
* Change hard coded magic 4096 and 0x1000 to SZ_4k in drivers/nvme/*
Johannes Thumshirn (9):
scatterlist: add sg_zeroout_area() helper
nvmet: use NVME_IDENTIFY_DATA_SIZE
nvme: introduce NVMe
(Christoph)
* Use uuid_be instead of u8[] (Christoph)
* Add ability to override target's version (Hannes)
* Change hard coded magic 4096 and 0x1000 to SZ_4k in drivers/nvme/*
Johannes Thumshirn (9):
scatterlist: add sg_zeroout_area() helper
nvmet: use NVME_IDENTIFY_DATA_SIZE
nvme: introduce NVMe
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Max Gurtovoy <m...@mellanox.com>
Reviewed-by: Sagi Grimberg <s...@grimberg.me>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
include/linux/nvme.h | 17 +
1 file changed, 17 insertions(
Signed-off-by: Johannes Thumshirn
Reviewed-by: Max Gurtovoy
Reviewed-by: Sagi Grimberg
Reviewed-by: Hannes Reinecke
---
include/linux/nvme.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index c004af5faa48..22da030a28c6
If a target identifies itself as NVMe 1.3 compliant, try to get the
list of Namespace Identification Descriptors and populate the UUID,
NGUID and EUI64 fileds in the NVMe namespace structure with these
values.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Hannes Reine
If a target identifies itself as NVMe 1.3 compliant, try to get the
list of Namespace Identification Descriptors and populate the UUID,
NGUID and EUI64 fileds in the NVMe namespace structure with these
values.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/nvme/host
the nguid to sysfs in the uuid
sysfs attribute, but this can't be changed anymore without possibly
breaking existing userspace.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Reviewed-by
the nguid to sysfs in the uuid
sysfs attribute, but this can't be changed anymore without possibly
breaking existing userspace.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Reviewed-by: Sagi Grimberg
---
drivers/nvme/host/core.c | 10
The sg_zeroout_area() helper is used to zero fill an area in a SG
list.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
include/linux/scatterlist.h | 3 +++
lib/scatterlist.c | 37 +
2 files changed, 40 insertions(+)
diff --git a/i
The sg_zeroout_area() helper is used to zero fill an area in a SG
list.
Signed-off-by: Johannes Thumshirn
---
include/linux/scatterlist.h | 3 +++
lib/scatterlist.c | 37 +
2 files changed, 40 insertions(+)
diff --git a/include/linux/scatterlist.h
want to add a helper to zero parts of a sglist to
> lib/scatterlist.c, but I don't want to burden that on you.
I'll have a look.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5,
801 - 900 of 2637 matches
Mail list logo
