Re: [PATCH] net: ethernet: bgmac: Allow MAC address to be specified in DTB

2017-03-16 Thread Jon Mason
TCH > net-next] or [PATCH net] in the subject, see the netdev-FAQ.txt for > details: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt I believe he wants this in net-next Acked-by: Jon Mason <jo

Re: [PATCH] net: ethernet: bgmac: Allow MAC address to be specified in DTB

2017-03-16 Thread Jon Mason
gt; https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt I believe he wants this in net-next Acked-by: Jon Mason >> --- >> drivers/net/ethernet/broadcom/bgmac-bcma.c | 39 >> ++ >> 1 fil

Re: [PATCH] ARM: dts: BCM953012HR: Add ethernet aliases

2017-03-16 Thread Jon Mason
On Wed, Mar 15, 2017 at 4:59 PM, Steve Lin <steven.l...@broadcom.com> wrote: > Adding ethernet aliases. These are used, for example, by bootloaders, > to modify the MAC addresses in the device tree. > > Signed-off-by: Steve Lin <steven.l...@broadcom.com> LGTM Ack

Re: [PATCH] ARM: dts: BCM953012HR: Add ethernet aliases

2017-03-16 Thread Jon Mason
On Wed, Mar 15, 2017 at 4:59 PM, Steve Lin wrote: > Adding ethernet aliases. These are used, for example, by bootloaders, > to modify the MAC addresses in the device tree. > > Signed-off-by: Steve Lin LGTM Acked-by: Jon Mason > --- > arch/arm/boot/dts/bcm953012hr.dts

Re: [PATCH v5] NTB: Add IDT 89HPESxNTx PCIe-switches support

2017-03-08 Thread Jon Mason
On Tue, Mar 07, 2017 at 05:02:38AM +0300, Serge Semin wrote: > IDT 89HPESxNTx device series is PCIe-switches, which support > Non-Transparent bridging between domains connected to the device ports. > Since new NTB API exposes multi-port interface and messaging API, the > IDT NT-functions can be

Re: [PATCH v5] NTB: Add IDT 89HPESxNTx PCIe-switches support

2017-03-08 Thread Jon Mason
On Tue, Mar 07, 2017 at 05:02:38AM +0300, Serge Semin wrote: > IDT 89HPESxNTx device series is PCIe-switches, which support > Non-Transparent bridging between domains connected to the device ports. > Since new NTB API exposes multi-port interface and messaging API, the > IDT NT-functions can be

Re: [PATCH v2 3/4] ntb_hw_amd: Print kernel messages with the ntb device not the pci one

2017-03-08 Thread Jon Mason
On Tue, Jan 10, 2017 at 05:33:38PM -0700, Logan Gunthorpe wrote: > Now that macros are open it's pretty clear that these should print > using the NTB struct device not the PCI one. > > Signed-off-by: Logan Gunthorpe I believe that using the PCI dev here makes it more

Re: [PATCH v2 3/4] ntb_hw_amd: Print kernel messages with the ntb device not the pci one

2017-03-08 Thread Jon Mason
On Tue, Jan 10, 2017 at 05:33:38PM -0700, Logan Gunthorpe wrote: > Now that macros are open it's pretty clear that these should print > using the NTB struct device not the PCI one. > > Signed-off-by: Logan Gunthorpe I believe that using the PCI dev here makes it more debugable, as this is more

Re: [PATCH v2 1/4] ntb_hw_amd: Style fixes: open code macros that just obfuscate code

2017-03-08 Thread Jon Mason
On Tue, Jan 10, 2017 at 05:33:36PM -0700, Logan Gunthorpe wrote: > As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should > be cleaned up. This makes it more clear what's actually going on when > reading the code. > > [1] http://www.spinics.net/lists/linux-pci/msg56904.html > >

Re: [PATCH v2 2/4] ntb_hw_intel: Style fixes: open code macros that just obfuscate code

2017-03-08 Thread Jon Mason
On Tue, Jan 10, 2017 at 05:33:37PM -0700, Logan Gunthorpe wrote: > As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should > be cleaned up. This makes it more clear what's actually going on when > reading the code. > > [1] http://www.spinics.net/lists/linux-pci/msg56904.html > >

Re: [PATCH v2 1/4] ntb_hw_amd: Style fixes: open code macros that just obfuscate code

2017-03-08 Thread Jon Mason
On Tue, Jan 10, 2017 at 05:33:36PM -0700, Logan Gunthorpe wrote: > As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should > be cleaned up. This makes it more clear what's actually going on when > reading the code. > > [1] http://www.spinics.net/lists/linux-pci/msg56904.html > >

Re: [PATCH v2 2/4] ntb_hw_intel: Style fixes: open code macros that just obfuscate code

2017-03-08 Thread Jon Mason
On Tue, Jan 10, 2017 at 05:33:37PM -0700, Logan Gunthorpe wrote: > As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should > be cleaned up. This makes it more clear what's actually going on when > reading the code. > > [1] http://www.spinics.net/lists/linux-pci/msg56904.html > >

[PATCH] ARM: dts: NSP: Add EHCI/OHCI USB nodes to device tree

2017-03-07 Thread Jon Mason
Add the EHCI and OHCI entries to the Northstar Plus device tree files. Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.re...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 14 ++ arch/arm/boot/dts/bcm

[PATCH] ARM: dts: NSP: Add EHCI/OHCI USB nodes to device tree

2017-03-07 Thread Jon Mason
Add the EHCI and OHCI entries to the Northstar Plus device tree files. Signed-off-by: Yendapally Reddy Dhananjaya Reddy Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 14 ++ arch/arm/boot/dts/bcm958522er.dts | 10 +- arch/arm/boot/dts/bcm958525er.dts

[PATCH] ARM: dts: NSP: disable i2c DT entry by default

2017-03-07 Thread Jon Mason
The i2c device tree entry should be disabled by default to match the current convention in other device tree files. Similarily, enable it on the XMC board, where it is being used. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 1 + arch/arm/bo

[PATCH] ARM: dts: NSP: disable i2c DT entry by default

2017-03-07 Thread Jon Mason
The i2c device tree entry should be disabled by default to match the current convention in other device tree files. Similarily, enable it on the XMC board, where it is being used. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 1 + arch/arm/boot/dts/bcm958525xmc.dts | 2

[PATCH] arm64: dts: NS2: convert "ok" to "okay"

2017-03-06 Thread Jon Mason
Per e-mail from Sergei Shtylyov, the DT spec dictates it should be "okay" (although "ok" is also recognized). Thus, changing all "ok" to "okay" in NS2 device tree files Suggested-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by

[PATCH] arm64: dts: NS2: convert "ok" to "okay"

2017-03-06 Thread Jon Mason
Per e-mail from Sergei Shtylyov, the DT spec dictates it should be "okay" (although "ok" is also recognized). Thus, changing all "ok" to "okay" in NS2 device tree files Suggested-by: Sergei Shtylyov Signed-off-by: Jon Mason --- arch/

[PATCH v3 2/2] ARM: dts: bcm5301x: Add I2C support to the DT

2017-03-06 Thread Jon Mason
From: Jon Mason <jonma...@broadcom.com> Add I2C support to the bcm5301x Device Tree. Since no driver changes are needed to enable this hardware, only the device tree changes are required to make this functional. Signed-off-by: Jon Mason <jonma...@broadcom.com> --- arch/

[PATCH v3 2/2] ARM: dts: bcm5301x: Add I2C support to the DT

2017-03-06 Thread Jon Mason
From: Jon Mason Add I2C support to the bcm5301x Device Tree. Since no driver changes are needed to enable this hardware, only the device tree changes are required to make this functional. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm5301x.dtsi | 10 ++ 1 file changed, 10

[PATCH v3 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

2017-03-06 Thread Jon Mason
From: Jon Mason <jonma...@broadcom.com> Add support for the ARM TWD Watchdog to the bcm5301x device tree. The ARM TWD timer allocated the register space for the WDT, so this patch necessitated shrinking that. Also, the GIC masks were added for these. Signed-off-by: Jon Mason

[PATCH v3 0/2] ARM: dts: BCM5301X: TWD WD and i2c Support

2017-03-06 Thread Jon Mason
I believe that was the sticking point, and resending the TWD and i2c patches. Jon Mason (2): ARM: dts: bcm5301x: Add TWD WD Support to DT ARM: dts: bcm5301x: Add I2C support to the DT arch/arm/boot/dts/bcm5301x.dtsi | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) -- 2.7.4

[PATCH v3 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

2017-03-06 Thread Jon Mason
From: Jon Mason Add support for the ARM TWD Watchdog to the bcm5301x device tree. The ARM TWD timer allocated the register space for the WDT, so this patch necessitated shrinking that. Also, the GIC masks were added for these. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm5301x.dtsi

[PATCH v3 0/2] ARM: dts: BCM5301X: TWD WD and i2c Support

2017-03-06 Thread Jon Mason
I believe that was the sticking point, and resending the TWD and i2c patches. Jon Mason (2): ARM: dts: bcm5301x: Add TWD WD Support to DT ARM: dts: bcm5301x: Add I2C support to the DT arch/arm/boot/dts/bcm5301x.dtsi | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) -- 2.7.4

Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT

2017-03-06 Thread Jon Mason
On Sun, Mar 5, 2017 at 8:13 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > > > On 03/02/2017 04:21 PM, Jon Mason wrote: >> From: Jon Mason <jonma...@broadcom.com> >> >> Add I2C support to the bcm5301x Device Tree. Since no driver changes >

Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT

2017-03-06 Thread Jon Mason
On Sun, Mar 5, 2017 at 8:13 PM, Florian Fainelli wrote: > > > On 03/02/2017 04:21 PM, Jon Mason wrote: >> From: Jon Mason >> >> Add I2C support to the bcm5301x Device Tree. Since no driver changes >> are needed to enable this hardware, only the device tre

[PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT

2017-03-03 Thread Jon Mason
From: Jon Mason <jonma...@broadcom.com> Add I2C support to the bcm5301x Device Tree. Since no driver changes are needed to enable this hardware, only the device tree changes are required to make this functional. Signed-off-by: Jon Mason <jonma...@broadcom.com> --- arch/

[PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT

2017-03-03 Thread Jon Mason
From: Jon Mason Add I2C support to the bcm5301x Device Tree. Since no driver changes are needed to enable this hardware, only the device tree changes are required to make this functional. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm5301x.dtsi | 9 + 1 file changed, 9 insertions

Re: [PATCH net v4 0/2] net: ethernet: bgmac: bug fixes

2017-03-02 Thread Jon Mason
On Thu, Mar 02, 2017 at 12:56:05PM -0800, David Miller wrote: > From: David Miller <da...@davemloft.net> > Date: Thu, 02 Mar 2017 12:50:15 -0800 (PST) > > > From: Jon Mason <jon.ma...@broadcom.com> > > Date: Tue, 28 Feb 2017 13:41:49 -0500 > > > >&

Re: [PATCH net v4 0/2] net: ethernet: bgmac: bug fixes

2017-03-02 Thread Jon Mason
On Thu, Mar 02, 2017 at 12:56:05PM -0800, David Miller wrote: > From: David Miller > Date: Thu, 02 Mar 2017 12:50:15 -0800 (PST) > > > From: Jon Mason > > Date: Tue, 28 Feb 2017 13:41:49 -0500 > > > >> Changes in v4: > >> * Added the ude

[PATCH v2 2/3] ARM: dts: bcm5301x: Add TWD WD Support to DT

2017-03-02 Thread Jon Mason
From: Jon Mason <jonma...@broadcom.com> Add support for the ARM TWD Watchdog to the bcm5301x device tree. The ARM TWD timer allocated the register space for the WDT, so this patch necessitated shrinking that. Also, the GIC masks were added for these. Signed-off-by: Jon Mason

[PATCH v2 2/3] ARM: dts: bcm5301x: Add TWD WD Support to DT

2017-03-02 Thread Jon Mason
From: Jon Mason Add support for the ARM TWD Watchdog to the bcm5301x device tree. The ARM TWD timer allocated the register space for the WDT, so this patch necessitated shrinking that. Also, the GIC masks were added for these. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm5301x.dtsi

[PATCH v2 0/3] ARM: dts: BCM5301X: GIC_PPI bug, TWD WD and i2c Support

2017-03-02 Thread Jon Mason
://lkml.org/lkml/2016/5/11/953 I am dropping the syscon reboot from the series, as I believe that was the sticking point, and resending the TWD and i2c patches. Jon Mason (3): ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags ARM: dts: bcm5301x: Add TWD WD Support to DT ARM: dts: bcm5301x

[PATCH v2 1/3] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags

2017-03-02 Thread Jon Mason
GIC_PPI flags were misconfigured for the timers, resulting in errors like: [0.00] GIC: PPI11 is secure or misconfigured Changing them to being edge triggered corrects the issue Suggested-by: Rafał Miłecki <ra...@milecki.pl> Signed-off-by: Jon Mason <jon.ma...@broadcom.c

[PATCH v2 0/3] ARM: dts: BCM5301X: GIC_PPI bug, TWD WD and i2c Support

2017-03-02 Thread Jon Mason
://lkml.org/lkml/2016/5/11/953 I am dropping the syscon reboot from the series, as I believe that was the sticking point, and resending the TWD and i2c patches. Jon Mason (3): ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags ARM: dts: bcm5301x: Add TWD WD Support to DT ARM: dts: bcm5301x

[PATCH v2 1/3] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags

2017-03-02 Thread Jon Mason
GIC_PPI flags were misconfigured for the timers, resulting in errors like: [0.00] GIC: PPI11 is secure or misconfigured Changing them to being edge triggered corrects the issue Suggested-by: Rafał Miłecki Signed-off-by: Jon Mason Fixes: d27509f1 ("ARM: BCM5301X: add dts

[PATCH net v5 1/2] net: ethernet: bgmac: init sequence bug

2017-03-02 Thread Jon Mason
it out of reset regardless of whether it was in reset or not). Also, removed unnecessary usleeps (as there is already a read present to flush the IDM writes). Signed-off-by: Zac Schroff <zschr...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: f6a95a24957 (&q

[PATCH net v5 1/2] net: ethernet: bgmac: init sequence bug

2017-03-02 Thread Jon Mason
it out of reset regardless of whether it was in reset or not). Also, removed unnecessary usleeps (as there is already a read present to flush the IDM writes). Signed-off-by: Zac Schroff Signed-off-by: Jon Mason Fixes: f6a95a24957 ("net: ethernet: bgmac: Add platform device support") --

[PATCH net v5 2/2] net: ethernet: bgmac: mac address change bug

2017-03-02 Thread Jon Mason
From: Hari Vyas <ha...@broadcom.com> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas <ha...@broadcom.com> Signed-off-b

[PATCH net v5 2/2] net: ethernet: bgmac: mac address change bug

2017-03-02 Thread Jon Mason
From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason Fixes: 4e209001b86 ("bgmac: writ

[PATCH net v5 0/2] net: ethernet: bgmac: bug fixes

2017-03-02 Thread Jon Mason
preserved (Per Rafal Mileki) * Style change to reorder the function variables in patch 2 (per Sergei Shtylyov) Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1): net: ethernet: bgmac: init sequence bug drivers/net/ethernet/broadcom/bgmac

[PATCH net v5 0/2] net: ethernet: bgmac: bug fixes

2017-03-02 Thread Jon Mason
preserved (Per Rafal Mileki) * Style change to reorder the function variables in patch 2 (per Sergei Shtylyov) Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1): net: ethernet: bgmac: init sequence bug drivers/net/ethernet/broadcom/bgmac

[PATCH] ARM: dts: NSP: GPIO reboot open-source

2017-03-01 Thread Jon Mason
The libgpio code pre-sets the GPIO values for the gpio-reset in the device tree. This results in the device being reset during bringup. To prevent this pre-setting, use the "open-source" flag in the device tree. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: b1aaf88

[PATCH] ARM: dts: NSP: GPIO reboot open-source

2017-03-01 Thread Jon Mason
The libgpio code pre-sets the GPIO values for the gpio-reset in the device tree. This results in the device being reset during bringup. To prevent this pre-setting, use the "open-source" flag in the device tree. Signed-off-by: Jon Mason Fixes: b1aaf88 ("ARM: dts: NSP: Add GPI

[PATCH] PCI: iproc: Add PCI_DOMAIN dependency to PCI Kconfig

2017-03-01 Thread Jon Mason
From: Jon Mason <jonma...@broadcom.com> 2+ PCI devices fail to be discovered due to each bus having the same PCI domain. This is because the domain defined in the device tree file is not being added due to PCI_DOMAIN not being enabled. So, every PCI bus has a domain of zero. When PCI_

[PATCH] PCI: iproc: Add PCI_DOMAIN dependency to PCI Kconfig

2017-03-01 Thread Jon Mason
From: Jon Mason 2+ PCI devices fail to be discovered due to each bus having the same PCI domain. This is because the domain defined in the device tree file is not being added due to PCI_DOMAIN not being enabled. So, every PCI bus has a domain of zero. When PCI_DOMAIN is selected

[PATCH net-next v3 0/3] net: ethernet: bgmac: PM support and clean-ups

2017-02-28 Thread Jon Mason
Jon Mason (2): net: ethernet: bgmac: use #defines for MAX size net: ethernet: bgmac: unify code of the same family drivers/net/ethernet/broadcom/bgmac-bcma.c | 64 +++--- drivers/net/ethernet/broadcom/bgmac-platform.c | 34 ++ drivers/net/ethernet/broadcom

[PATCH net-next v3 0/3] net: ethernet: bgmac: PM support and clean-ups

2017-02-28 Thread Jon Mason
Jon Mason (2): net: ethernet: bgmac: use #defines for MAX size net: ethernet: bgmac: unify code of the same family drivers/net/ethernet/broadcom/bgmac-bcma.c | 64 +++--- drivers/net/ethernet/broadcom/bgmac-platform.c | 34 ++ drivers/net/ethernet/broadcom

[PATCH 0/2] ARM: dts: bcm5301x: Add TWD and I2C

2017-02-28 Thread Jon Mason
These seemed to have been lost sometime last year. See https://lkml.org/lkml/2016/5/11/953 I am dropping the syscon reboot from the series, as I believe that was the sticking point, and resending the TWD and i2c patches. Jon Mason (2): ARM: dts: bcm5301x: Add TWD WD Support to DT ARM: dts

[PATCH 0/2] ARM: dts: bcm5301x: Add TWD and I2C

2017-02-28 Thread Jon Mason
These seemed to have been lost sometime last year. See https://lkml.org/lkml/2016/5/11/953 I am dropping the syscon reboot from the series, as I believe that was the sticking point, and resending the TWD and i2c patches. Jon Mason (2): ARM: dts: bcm5301x: Add TWD WD Support to DT ARM: dts

[PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

2017-02-28 Thread Jon Mason
From: Jon Mason <jonma...@broadcom.com> Add support for the ARM TWD Watchdog to the bcm5301x device tree. The ARM TWD timer allocated the register space for the WDT, so this patch necessitated shrinking that. Also, the GIC masks were added for these. Signed-off-by: Jon Mason

[PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

2017-02-28 Thread Jon Mason
From: Jon Mason Add support for the ARM TWD Watchdog to the bcm5301x device tree. The ARM TWD timer allocated the register space for the WDT, so this patch necessitated shrinking that. Also, the GIC masks were added for these. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm5301x.dtsi

[PATCH 2/2] ARM: dts: bcm5301x: Add I2C support to the DT

2017-02-28 Thread Jon Mason
From: Jon Mason <jonma...@broadcom.com> Add I2C support to the bcm5301x Device Tree. Since no driver changes are needed to enable this hardware, only the device tree changes are required to make this functional. Signed-off-by: Jon Mason <jonma...@broadcom.com> --- arch/

[PATCH 2/2] ARM: dts: bcm5301x: Add I2C support to the DT

2017-02-28 Thread Jon Mason
From: Jon Mason Add I2C support to the bcm5301x Device Tree. Since no driver changes are needed to enable this hardware, only the device tree changes are required to make this functional. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm5301x.dtsi | 9 + 1 file changed, 9 insertions

Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

2017-02-28 Thread Jon Mason
On Tue, Feb 28, 2017 at 3:43 PM, Rafał Miłecki <zaj...@gmail.com> wrote: > On 28 February 2017 at 21:31, Jon Mason <jon.ma...@broadcom.com> wrote: >> @@ -70,10 +70,19 @@ >> clocks = <_clk>; >> };

Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

2017-02-28 Thread Jon Mason
On Tue, Feb 28, 2017 at 3:43 PM, Rafał Miłecki wrote: > On 28 February 2017 at 21:31, Jon Mason wrote: >> @@ -70,10 +70,19 @@ >> clocks = <_clk>; >> }; >> >> - local-timer@20600 { >> +

[PATCH net-next v3 1/3] net: ethernet: bgmac: use #defines for MAX size

2017-02-28 Thread Jon Mason
The maximum frame size is really just the standard ethernet frame size and FCS. So use those existing defines to make the code a little more beautiful. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.h | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH net-next v3 1/3] net: ethernet: bgmac: use #defines for MAX size

2017-02-28 Thread Jon Mason
The maximum frame size is really just the standard ethernet frame size and FCS. So use those existing defines to make the code a little more beautiful. Signed-off-by: Jon Mason --- drivers/net/ethernet/broadcom/bgmac.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH net-next v3 2/3] net: ethernet: bgmac: unify code of the same family

2017-02-28 Thread Jon Mason
BCM471X and BCM535X are of the same family (from what I can derive from internal documents). Group them into the case statement together, which results in more code reuse. Also, use existing helper variables to make the code a little more readable too. Signed-off-by: Jon Mason <jon

[PATCH net-next v3 2/3] net: ethernet: bgmac: unify code of the same family

2017-02-28 Thread Jon Mason
BCM471X and BCM535X are of the same family (from what I can derive from internal documents). Group them into the case statement together, which results in more code reuse. Also, use existing helper variables to make the code a little more readable too. Signed-off-by: Jon Mason --- drivers/net

[PATCH net-next v3 3/3] net: ethernet: bgmac: driver power manangement

2017-02-28 Thread Jon Mason
From: Joey Zhong <zho...@broadcom.com> Implement suspend/resume callbacks in the bgmac driver. This makes sure that we de-initialize and re-initialize the hardware correctly before entering suspend and when resuming. Signed-off-by: Joey Zhong <zho...@broadcom.com> Signed-off-b

[PATCH net-next v3 3/3] net: ethernet: bgmac: driver power manangement

2017-02-28 Thread Jon Mason
From: Joey Zhong Implement suspend/resume callbacks in the bgmac driver. This makes sure that we de-initialize and re-initialize the hardware correctly before entering suspend and when resuming. Signed-off-by: Joey Zhong Signed-off-by: Jon Mason Reviewed-by: Florian Fainelli --- drivers/net

[PATCH net v4 0/2] net: ethernet: bgmac: bug fixes

2017-02-28 Thread Jon Mason
Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1): net: ethernet: bgmac: init sequence bug drivers/net/ethernet/broadcom/bgmac-platform.c | 27 +- drivers/net/ethernet/broadcom/bgmac.c | 6 +- drivers/net/ethernet/broadcom/bgmac.h

[PATCH net v4 0/2] net: ethernet: bgmac: bug fixes

2017-02-28 Thread Jon Mason
Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1): net: ethernet: bgmac: init sequence bug drivers/net/ethernet/broadcom/bgmac-platform.c | 27 +- drivers/net/ethernet/broadcom/bgmac.c | 6 +- drivers/net/ethernet/broadcom/bgmac.h

[PATCH net v4 1/2] net: ethernet: bgmac: init sequence bug

2017-02-28 Thread Jon Mason
it out of reset regardless of whether it was in reset or not). Also, removed unnecessary usleeps (as there is already a read present to flush the IDM writes). Signed-off-by: Zac Schroff <zschr...@broadcom.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Fixes: f6a95a24957 (&q

[PATCH net v4 1/2] net: ethernet: bgmac: init sequence bug

2017-02-28 Thread Jon Mason
it out of reset regardless of whether it was in reset or not). Also, removed unnecessary usleeps (as there is already a read present to flush the IDM writes). Signed-off-by: Zac Schroff Signed-off-by: Jon Mason Fixes: f6a95a24957 ("net: ethernet: bgmac: Add platform device support") --

[PATCH net v4 2/2] net: ethernet: bgmac: mac address change bug

2017-02-28 Thread Jon Mason
From: Hari Vyas <ha...@broadcom.com> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas <ha...@broadcom.com> Signed-off-b

[PATCH net v4 2/2] net: ethernet: bgmac: mac address change bug

2017-02-28 Thread Jon Mason
From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason Fixes: 4e209001b86 ("bgmac: writ

Re: [PATCH v2 0/3] Add Northstar Plus support to PDC mailbox driver

2017-02-23 Thread Jon Mason
t; v2 addresses Jon Mason's suggestion about making the bindings doc change > a separate patch. FWIW, looks good to me. Feel free to add my Acked-by: Jon Mason <jon.ma...@broadcom.com> to the relevant pieces > Steve Lin (3): > mailbox: bcm-pdc: Add Northstar Plus support to PDC

Re: [PATCH v2 0/3] Add Northstar Plus support to PDC mailbox driver

2017-02-23 Thread Jon Mason
ggestion about making the bindings doc change > a separate patch. FWIW, looks good to me. Feel free to add my Acked-by: Jon Mason to the relevant pieces > Steve Lin (3): > mailbox: bcm-pdc: Add Northstar Plus support to PDC driver > ARM: dts: NSP: Add mailbox (PDC) to NSP >

Re: [PATCH 2/2] ARM: dts: NSP: Add mailbox (PDC) to NSP

2017-02-22 Thread Jon Mason
On Wed, Feb 22, 2017 at 3:42 PM, Steve Lin wrote: > Adds mailbox / PDC to NSP device tree. Needs new compatibility string > to differentiate from NS2 version. > > Signed-off-by: Steve Lin > --- >

Re: [PATCH 2/2] ARM: dts: NSP: Add mailbox (PDC) to NSP

2017-02-22 Thread Jon Mason
On Wed, Feb 22, 2017 at 3:42 PM, Steve Lin wrote: > Adds mailbox / PDC to NSP device tree. Needs new compatibility string > to differentiate from NS2 version. > > Signed-off-by: Steve Lin > --- > .../devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt | 6 -- >

Re: [PATCH 1/1] ARM: dts: NSP: Add crypto (SPU) to dtsi

2017-02-22 Thread Jon Mason
On Wed, Feb 22, 2017 at 4:22 PM, Steve Lin <steven.l...@broadcom.com> wrote: > Adds crypto hardware (SPU) to Northstar Plus device tree file. > > Signed-off-by: Steve Lin <steven.l...@broadcom.com> Looks good to me! Acked-by: Jon Mason <jon.ma...@broadcom.com&

Re: [PATCH 1/1] ARM: dts: NSP: Add crypto (SPU) to dtsi

2017-02-22 Thread Jon Mason
On Wed, Feb 22, 2017 at 4:22 PM, Steve Lin wrote: > Adds crypto hardware (SPU) to Northstar Plus device tree file. > > Signed-off-by: Steve Lin Looks good to me! Acked-by: Jon Mason > > --- > Code changes for this addition were submitted previously by Rob > Rice: >

Re: [PATCH 1/1] ARM: dts: BCM953012HR: Initial Checkin

2017-02-22 Thread Jon Mason
On Wed, Feb 22, 2017 at 4:14 PM, Steve Lin <steven.l...@broadcom.com> wrote: > Initial version of DTS to support Broadcom BCM953012HR Northstar > HR platform, similar to, but not the same as existing 953012K. > > Signed-off-by: Steve Lin <steven.l...@broadcom.com> Looks go

Re: [PATCH 1/1] ARM: dts: BCM953012HR: Initial Checkin

2017-02-22 Thread Jon Mason
On Wed, Feb 22, 2017 at 4:14 PM, Steve Lin wrote: > Initial version of DTS to support Broadcom BCM953012HR Northstar > HR platform, similar to, but not the same as existing 953012K. > > Signed-off-by: Steve Lin Looks good to me! Acked-by: Jon Mason > --- > arch/arm

[GIT PULL] NTB bug fixes for vv4.10

2017-02-16 Thread Jon Mason
Hello Linus, Here are a few last minute NTB bug fixes for v4.10. They are fairly critical, and would appreicate them getting pulled in (though I understand this is extremely late in the cycle). Thanks, Jon The following changes since commit 7089db84e356562f8ba737c29e472cc42d530dbc: Linux

[GIT PULL] NTB bug fixes for vv4.10

2017-02-16 Thread Jon Mason
Hello Linus, Here are a few last minute NTB bug fixes for v4.10. They are fairly critical, and would appreicate them getting pulled in (though I understand this is extremely late in the cycle). Thanks, Jon The following changes since commit 7089db84e356562f8ba737c29e472cc42d530dbc: Linux

Re: [PATCH v4 0/3] Add Broadcom SPU Crypto Driver

2017-02-13 Thread Jon Mason
On Sat, Feb 11, 2017 at 5:54 AM, Herbert Xu wrote: > On Fri, Feb 03, 2017 at 12:55:31PM -0500, Rob Rice wrote: >> Changes in v4: >> - Added Rob Herring's Acked-by to patch 1/3 for bindings doc >> - In response to Herbert's comment, in ahash_export() and >>

Re: [PATCH v4 0/3] Add Broadcom SPU Crypto Driver

2017-02-13 Thread Jon Mason
On Sat, Feb 11, 2017 at 5:54 AM, Herbert Xu wrote: > On Fri, Feb 03, 2017 at 12:55:31PM -0500, Rob Rice wrote: >> Changes in v4: >> - Added Rob Herring's Acked-by to patch 1/3 for bindings doc >> - In response to Herbert's comment, in ahash_export() and >> ahash_import(), only copy the hash

[PATCH v2] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-08 Thread Jon Mason
Adding myself as a maintainer for Broadcom Northstar SoCs. Also, adding a regex entry to discover the SVK DTs already present. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2abda6c..7

[PATCH v2] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-08 Thread Jon Mason
Adding myself as a maintainer for Broadcom Northstar SoCs. Also, adding a regex entry to discover the SVK DTs already present. Signed-off-by: Jon Mason --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2abda6c..70f4b62 100644

Re: [PATCH] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-08 Thread Jon Mason
On Wed, Feb 8, 2017 at 6:29 PM, Rafał Miłecki <ra...@milecki.pl> wrote: > On 02/09/2017 12:22 AM, Jon Mason wrote: >> >> Adding myself as a maintainer for Broadcom Northstar SoCs. Also, adding >> a regex entry to discover the SVK DTs already present. >> &g

Re: [PATCH] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-08 Thread Jon Mason
On Wed, Feb 8, 2017 at 6:29 PM, Rafał Miłecki wrote: > On 02/09/2017 12:22 AM, Jon Mason wrote: >> >> Adding myself as a maintainer for Broadcom Northstar SoCs. Also, adding >> a regex entry to discover the SVK DTs already present. >> >> Signed-off-by: Jon Mas

Re: [PATCH] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-08 Thread Jon Mason
On Wed, Feb 8, 2017 at 6:35 PM, Rafał Miłecki <ra...@milecki.pl> wrote: > On 2017-02-09 00:34, Jon Mason wrote: >> >> On Wed, Feb 8, 2017 at 6:29 PM, Rafał Miłecki <ra...@milecki.pl> wrote: >>> >>> On 02/09/2017 12:22 AM, Jon Mason wrote: >>>

Re: [PATCH] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-08 Thread Jon Mason
On Wed, Feb 8, 2017 at 6:35 PM, Rafał Miłecki wrote: > On 2017-02-09 00:34, Jon Mason wrote: >> >> On Wed, Feb 8, 2017 at 6:29 PM, Rafał Miłecki wrote: >>> >>> On 02/09/2017 12:22 AM, Jon Mason wrote: >>>> >>>> >>>> Add

[PATCH 2/2] ARM: dts: BCM5301X: Fix memory start address

2017-02-08 Thread Jon Mason
Memory starts at 0x8000, not 0. 0 "works" due to mirrior of the first 128M of RAM to that address. Anything greater than 128M will quickly find nothing there. Correcting the starting address has everything working again. Signed-off-by: Jon Mason <jon.ma...@broadcom.com>

[PATCH 2/2] ARM: dts: BCM5301X: Fix memory start address

2017-02-08 Thread Jon Mason
Memory starts at 0x8000, not 0. 0 "works" due to mirrior of the first 128M of RAM to that address. Anything greater than 128M will quickly find nothing there. Correcting the starting address has everything working again. Signed-off-by: Jon Mason Fixes: 7eb05f6d ("ARM: dts

[PATCH] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-08 Thread Jon Mason
Adding myself as a maintainer for Broadcom Northstar SoCs. Also, adding a regex entry to discover the SVK DTs already present. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2abda6c..0

[PATCH] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-08 Thread Jon Mason
Adding myself as a maintainer for Broadcom Northstar SoCs. Also, adding a regex entry to discover the SVK DTs already present. Signed-off-by: Jon Mason --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2abda6c..03c1760 100644

Re: [PATCH 0/2] PCI: iproc: MPS fix and quirks

2017-02-08 Thread Jon Mason
On Wed, Feb 8, 2017 at 4:55 PM, Bjorn Helgaas <helg...@kernel.org> wrote: > On Fri, Jan 27, 2017 at 04:44:07PM -0500, Jon Mason wrote: >> A patch that corrects an issue where the MPS could not be set, and >> another that fixes some quirks in the PAXC >> >> Jon

Re: [PATCH 0/2] PCI: iproc: MPS fix and quirks

2017-02-08 Thread Jon Mason
On Wed, Feb 8, 2017 at 4:55 PM, Bjorn Helgaas wrote: > On Fri, Jan 27, 2017 at 04:44:07PM -0500, Jon Mason wrote: >> A patch that corrects an issue where the MPS could not be set, and >> another that fixes some quirks in the PAXC >> >> Jon Mason (2): >> PC

Re: [PATCH V2] usb: xhci: add support for performing fake doorbell

2017-02-08 Thread Jon Mason
On Mon, Jan 16, 2017 at 2:32 AM, Rafał Miłecki wrote: > On 21 November 2016 at 16:31, Mathias Nyman > wrote: >> On 21.11.2016 09:57, Rafał Miłecki wrote: >>> >>> Hi Mathias, >>> >>> On 17 October 2016 at 22:30, Rafał Miłecki

Re: [PATCH V2] usb: xhci: add support for performing fake doorbell

2017-02-08 Thread Jon Mason
On Mon, Jan 16, 2017 at 2:32 AM, Rafał Miłecki wrote: > On 21 November 2016 at 16:31, Mathias Nyman > wrote: >> On 21.11.2016 09:57, Rafał Miłecki wrote: >>> >>> Hi Mathias, >>> >>> On 17 October 2016 at 22:30, Rafał Miłecki wrote: From: Rafał Miłecki Broadcom's Northstar

[PATCH net] net: phy: Initialize mdio clock at probe function

2017-02-08 Thread Jon Mason
ed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.re...@broadcom.com> Fixes: ddc24ae1 ("net: phy: Broadcom iProc MDIO bus driver") Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/phy/mdio-bcm-ipr

[PATCH net] net: phy: Initialize mdio clock at probe function

2017-02-08 Thread Jon Mason
Reddy Fixes: ddc24ae1 ("net: phy: Broadcom iProc MDIO bus driver") Reviewed-by: Florian Fainelli Signed-off-by: Jon Mason --- drivers/net/phy/mdio-bcm-iproc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-b

[PATCH 2/2] ARM: dts: BCM5301X: convert to iProc QSPI

2017-02-08 Thread Jon Mason
The iproc-qspi driver is the SPI driver that should be used going forward. Modify the SPI DT entry to use this driver, and add an entry in the bcm953012k DTS file to enable the SPI. Tested on the bcm953012k board. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm/bo

[PATCH 2/2] ARM: dts: BCM5301X: convert to iProc QSPI

2017-02-08 Thread Jon Mason
The iproc-qspi driver is the SPI driver that should be used going forward. Modify the SPI DT entry to use this driver, and add an entry in the bcm953012k DTS file to enable the SPI. Tested on the bcm953012k board. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm5301x.dtsi | 50

[PATCH net v3 0/2] net: ethernet: bgmac: bug fixes

2017-02-08 Thread Jon Mason
the first match to make it more obvious what portions of the register were being preserved (Per Rafal Mileki) * Style change to reorder the function variables in patch 2 (per Sergei Shtylyov) Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1

[PATCH net v3 0/2] net: ethernet: bgmac: bug fixes

2017-02-08 Thread Jon Mason
the first match to make it more obvious what portions of the register were being preserved (Per Rafal Mileki) * Style change to reorder the function variables in patch 2 (per Sergei Shtylyov) Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac address change bug Jon Mason (1

<    1   2   3   4   5   6   7   8   9   10   >