Re: [PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-30 Thread Jonas Malaco
On Tue, Mar 30, 2021 at 03:51:21AM -0700, Guenter Roeck wrote: > [ ... ] > > Then please explain why _this_ use of time_after() is wrong but all > others in the kernel are not. Also, please note that we are not > concerned with code generation by the compiler as long as the > generated code is

Re: [PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-30 Thread Jonas Malaco
On Mon, Mar 29, 2021 at 10:43:55PM -0700, Guenter Roeck wrote: > On 3/29/21 8:16 PM, Jonas Malaco wrote: > > On Mon, Mar 29, 2021 at 06:01:00PM -0700, Guenter Roeck wrote: > >> On 3/29/21 5:21 PM, Jonas Malaco wrote: > >>> On Mon, Mar 29, 2021 at 02:53:3

Re: [PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-29 Thread Jonas Malaco
On Mon, Mar 29, 2021 at 06:01:00PM -0700, Guenter Roeck wrote: > On 3/29/21 5:21 PM, Jonas Malaco wrote: > > On Mon, Mar 29, 2021 at 02:53:39PM -0700, Guenter Roeck wrote: > >> On Mon, Mar 29, 2021 at 05:22:01AM -0300, Jonas Malaco wrote: > >>> To avoid a spinlock,

Re: [PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-29 Thread Jonas Malaco
On Mon, Mar 29, 2021 at 02:53:39PM -0700, Guenter Roeck wrote: > On Mon, Mar 29, 2021 at 05:22:01AM -0300, Jonas Malaco wrote: > > To avoid a spinlock, the driver explores concurrent memory accesses > > between _raw_event and _read, having the former updating fields on a > >

[PATCH] hwmon: (nzxt-kraken2) mark and order concurrent accesses

2021-03-29 Thread Jonas Malaco
les/793253/ Signed-off-by: Jonas Malaco --- drivers/hwmon/nzxt-kraken2.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/hwmon/nzxt-kraken2.c b/drivers/hwmon/nzxt-kraken2.c index 89f7ea4f42d4..f4fbc8771930 100644 --- a/drivers/hwmon/nzxt-kraken2.c +

Re: [PATCH v2] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-20 Thread Jonas Malaco
On Fri, Mar 19, 2021 at 02:26:40PM -0700, Guenter Roeck wrote: > On Fri, Mar 19, 2021 at 01:55:44AM -0300, Jonas Malaco wrote: > > These are "all-in-one" CPU liquid coolers that can be monitored and > > controlled through a proprietary USB HID protocol. > > > &

[PATCH v2] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-18 Thread Jonas Malaco
can still be used alongside the driver, thanks to hidraw. A link to one, which I also maintain, is provided in the documentation. The implementation is based on USB traffic analysis. It has been runtime tested on x86_64, both as a built-in driver and as a module. Signed-off-by: Jonas Malaco --- Cha

Re: [PATCH] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-18 Thread Jonas Malaco
On Thu, Mar 18, 2021 at 04:36:08PM -0700, Guenter Roeck wrote: > On Thu, Mar 18, 2021 at 08:15:06PM -0300, Jonas Malaco wrote: > > [ ... ] > > > > Either case, the spinlocks are overkill. It would be much easier to > > > convert raw readings here into tempe

Re: [PATCH] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-18 Thread Jonas Malaco
On Thu, Mar 18, 2021 at 11:55:39AM -0700, Guenter Roeck wrote: > On 3/18/21 9:48 AM, Jonas Malaco wrote: > > These are "all-in-one" CPU liquid coolers that can be monitored and > > controlled through a proprietary USB HID protocol. > > > > While the mo

[PATCH] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-18 Thread Jonas Malaco
can still be used alongside the driver, thanks to hidraw. A link to one, which I also maintain, is provided in the documentation. The implementation is based on USB traffic analysis. It has been runtime tested on x86_64, both as a built-in driver and as a module. Signed-off-by: Jonas Mala

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-30 Thread Jonas Malaco
: > > > > > > > On Sun, Nov 29, 2020 at 07:36:18AM +0100, Wilken Gottwalt wrote: > > > > > On Sat, 28 Nov 2020 17:21:40 -0300 > > > > > Jonas Malaco wrote: > > > > > > > > > > > On Sat, Nov 28, 2020 at 7:35 AM Wilke

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-28 Thread Jonas Malaco
On Thu, Nov 26, 2020 at 8:43 AM Wilken Gottwalt wrote: > > Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, > AX1500i and AX1600i. The first 3 power supplies are supported through > the Corsair Link USB Dongle which is some kind of USB/Serial/TTL > converter especially made

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-28 Thread Jonas Malaco
On Sat, Nov 28, 2020 at 7:35 AM Wilken Gottwalt wrote: > > On Sat, 28 Nov 2020 02:37:38 -0300 > Jonas Malaco wrote: > > > On Thu, Nov 26, 2020 at 8:43 AM Wilken Gottwalt > > wrote: > > > > > > Adds support for another Corsair PSUs series: AX760i,