AW: [PATCH v6 1/1] mfd: da9063: Support SMBus and I2C mode

Hi, > > From: Hubert Streidl > > > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > > means the PMIC will automatically reset the interface when the clock > > signal ceases for more than the SMBus timeout of 35 ms. > > > > If the I2C driver / device is not capable of creat

[PATCH v5] mfd: da9063: Support SMBus and I2C mode

Hi Lee, > Code looks good to me now, thanks. > > However, this doesn't look like it would pass checkpatch. > > Have you tried to build with W=1 and checkpatch? Yes, we used checkpatch.pl. $ ./scripts/checkpatch.pl 0001-mfd-da9063-Support-SMBus-and-I2C-mode.v5 total: 0 errors, 0 warning

AW: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

Hi, > > From: Hubert Streidl > > > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > > means the PMIC will automatically reset the interface when the clock > > signal ceases for more than the SMBus timeout of 35 ms. > > > > If the I2C driver / device is not capable of creat

AW: [PATCH v2] mfd: da9063: Support SMBus and I2C mode

Hi Adam, > > + if (i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) { > > + dev_info(da9063->dev, "I2C mode"); > > + busmode = 0; > > + } else { > > + dev_info(da9063->dev, "SMBus mode"); > > + busmode = 1; > > I think this should be 'DA9063_TWOWIRE

AW: [PATCH 1/1] mfd: da9063: Support SMBus and I2C mode

Hi Adam, > > From: Hubert Streidl > > > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > > means the PMIC will automatically reset the interface when the clock > > signal ceases for more than the SMBus timeout of 35 ms. > > > > If the I2C driver / device is not capable of

[PATCH 1/1] mfd: da9063: Support SMBus and I2C mode

An: Support Opensource ; Lee Jones > ; Rob Herring > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > adam.thomson.opensou...@diasemi.com; stwiss.opensou...@diasemi.com; > marek.va...@gmail.com; RUAN Tingquan (BT-FIR/ENG1-Zhu) > ; Streidl Hubert (BT-FIR/ENG1-Grb) >

AW: [PATCH] drm: imx: Move fbdev setup to before output polling

Hi Daniel, > > Thank you very much for your feedback. We appreciate it. > > > > > >>> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > > > >>> b/drivers/gpu/drm/imx/imx-drm-core.c > > > >>> index 9bf5ad6d18a2..2665040e11c7 100644 > > > >>> --- a/drivers/gpu/drm/imx/imx-drm-core.c > > > >>> +++ b/

AW: [PATCH] drm: imx: Move fbdev setup to before output polling

Hi Thomas and Daniel, Thank you very much for your feedback. We appreciate it. > >>> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > >>> b/drivers/gpu/drm/imx/imx-drm-core.c > >>> index 9bf5ad6d18a2..2665040e11c7 100644 > >>> --- a/drivers/gpu/drm/imx/imx-drm-core.c > >>> +++ b/drivers/gpu/drm/