Re: [PATCH 17/17] mm: make range-to-target_node lookup facility a part of numa_memblks

2024-07-19 Thread Jonathan Cameron
lks are now part of the generic code, move these > functions from x86 to mm/numa_memblks.c and select > CONFIG_NUMA_KEEP_MEMINFO when CONFIG_NUMA_MEMBLKS=y for dax and cxl. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron Thanks. I'll poke around more next week. Have a good weekend. Jonathan

Re: [PATCH 12/17] mm: introduce numa_memblks

2024-07-19 Thread Jonathan Cameron
. > > No functional changes. > > Signed-off-by: Mike Rapoport (Microsoft) Hi Mike, My only real concern in here is there are a few places where the lifted code makes changes to memblocks that are x86 only today. I need to do some more digging to work out i

Re: [PATCH 16/17] arch_numa: switch over to numa_memblks

2024-07-19 Thread Jonathan Cameron
and add > functions required by numa_emulation. > > Signed-off-by: Mike Rapoport (Microsoft) One trivial comment inline, Jonathan > /* > * Initialize NODE_DATA for a node on the local memory > */ > @@ -226,116 +204,9 @@ static void __init setup_node_data(int nid, u64 &

Re: [PATCH 15/17] mm: make numa_memblks more self-contained

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:44 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Introduce numa_memblks_init() and move some code around to avoid several > global variables in numa_memblks. Hi Mike, Adding the effectively always on memblock_force_top_down deserves a comment on

Re: [PATCH 13/17] mm: move numa_distance and related code from x86 to numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:42 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move code dealing with numa_distance array from arch/x86 to > mm/numa_memblks.c It's not really numa memblock related. Is this the best place to put it? > > This code will be later reused by

Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned

2024-07-19 Thread Jonathan Cameron
haring > numa emulation code with these architectures. > > Signed-off-by: Mike Rapoport (Microsoft) Makes sense for both reasons. FWIW given how simple it is. Maybe worth bringing a few more functions inline with this? Probably something for another day given we don't care about the inconsistency for this series. Reviewed-by: Jonathan Cameron

Re: [PATCH 10/17] x86/numa_emu: use a helper function to get MAX_DMA32_PFN

2024-07-19 Thread Jonathan Cameron
poport (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 09/17] x86/numa_emu: split __apicid_to_node update to a helper function

2024-07-19 Thread Jonathan Cameron
t (Microsoft) Not the most intuitive of function names but I can't immediately think of a better one. Reviewed-by: Jonathan Cameron

Re: [PATCH 08/17] x86/numa_emu: simplify allocation of phys_dist

2024-07-19 Thread Jonathan Cameron
allocation. > > Replace memblock_phys_alloc_range() with memblock_alloc(). > > Signed-off-by: Mike Rapoport (Microsoft) Indeed seems to be after mapping physical memory, so this looks fine. Reviewed-by: Jonathan Cameron

Re: [PATCH 07/17] x86/numa: move FAKE_NODE_* defines to numa_emu

2024-07-19 Thread Jonathan Cameron
t; Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 06/17] x86/numa: simplify numa_distance allocation

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:35 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Allocation of numa_distance uses memblock_phys_alloc_range() to limit > allocation to be below the last mapped page. > > But NUMA initializaition runs after the direct map is populated and

Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code

2024-07-19 Thread Jonathan Cameron
iven that file already has mix and match of those and normal prints in single functions I assume this change is fine and we'll just see the prints a bit later. Reviewed-by: Jonathan Cameron

Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code

2024-07-19 Thread Jonathan Cameron
gt; > And I think, some architectures only set nodes online conditionally > (see most other node_set_online() calls). > > Sorry if I'm confused here, but with now unconditional node_set_online(), > won't > we change the behavior of other architectures? This is moving x86 code to x86 code, not a generic location so how would that affect anyone else? Their onlining should be same as before. The node onlining difference are a pain (I recall that fun from adding generic initiators) as different ordering on x86 and arm64 at least. Jonathan >

Re: [PATCH 04/17] arch, mm: move definition of node_data to generic code

2024-07-19 Thread Jonathan Cameron
; Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 03/17] MIPS: loongson64: rename __node_data to node_data

2024-07-19 Thread Jonathan Cameron
t; Signed-off-by: Mike Rapoport (Microsoft) FWIW rename looks fine Reviewed-by: Jonathan Cameron

Re: [PATCH 02/17] MIPS: sgi-ip27: make NODE_DATA() the same as on all other architectures

2024-07-19 Thread Jonathan Cameron
i-ip27/ip27-memory.c#L432 Now that pg_data_t is allocated by arch_alloc_nodedata() which might be fine (though types could be handled in a more readable fashion via some container_of() magic. https://elixir.bootlin.com/linux/v6.10/source/arch/mips/sgi-ip27/ip27-memory.c#L427 However that call is: pg_data_t * __init arch_alloc_nodedata(int nid) { return memblock_alloc(sizeof(pg_data_t), SMP_CACHE_BYTES); } So doesn't seem to allocate enough space to me as should be sizeof(struct node_data) Worth cleaning up whilst here? Proper handling of types would definitely help. Jonathan > > Anyhow > > Reviewed-by: David Hildenbrand >

Re: [PATCH 01/17] mm: move kernel/numa.c to mm/

2024-07-19 Thread Jonathan Cameron
are in arch/*/mm not arch/*/kernel so this makes it more consistent with that. Reviewed-by: Jonathan Cameron

Re: [PATCH 00/17] mm: introduce numa_memblks

2024-07-19 Thread Jonathan Cameron
istent before your rework so I can send that patch separately. Thanks for getting this sorted! I should get time to do more extensive testing and review in next week or so. Jonathan > > [1] > https://lore.kernel.org/all/20240529171236.32002-1-jonathan.came...@huawei.com/ > &g

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Tue, 23 Apr 2024 18:33:05 -0400 Aren Moynihan wrote: > From: Ondrej Jirman > > VDD power input can be used to completely power off the chip during > system suspend. Do so if available. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Aren Moynihan Suggestions inline. Key thing is take

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
ush an event. Such a register read doesn't require the IIO device registration to be complete. There are corner cases where that isn't true that need to manually mask at the host but they are rare. There is also a basic level of defense in iio_push_event() against that being called when the event interface is not registered. Jonathan >

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
struct device *dev) > > { > > struct stk3310_data *data; > > > data = iio_priv(i2c_get_clientdata(to_i2c_client(dev))); > > Side note: This may be updated (in a separate change) to use > dev_get_drvdata() directly. > > Jonath

[PATCH v2] uprobes: reduce contention on uprobes_tree access

2024-04-22 Thread Jonathan Haslam
l [1] https://github.com/torvalds/linux/blob/master/tools/testing/selftests/bpf/benchs/bench_trigger.c Signed-off-by: Jonathan Haslam --- kernel/events/uprobes.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/upr

Re: [PATCH 3/4] iio: light: stk3310: log error if reading the chip id fails

2024-04-20 Thread Jonathan Cameron
y add another patch to clean up all of them: > _probe(), _init(), _regmap_init() to use the same pattern everywhere. > Yes, a precursor patch to use dev_err_probe() throughout the probe only functions in this driver would be excellent. Jonathan

Re: [PATCH 1/4] dt-bindings: iio: light: stk33xx: add regulator for vdd supply

2024-04-20 Thread Jonathan Cameron
On Sun, 14 Apr 2024 13:57:13 -0400 Aren Moynihan wrote: > Signed-off-by: Aren Moynihan > --- > Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml >

Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-20 Thread Jonathan Cameron
etc) and pay the minor cost of potentially restoring registers when it was never powered down. Simpler code and likely anyone who is doing suspend / resume will have power control anyway. Jonathan > > Signed-off-by: Ondrej Jirman > Signed-off-by: Aren Moynihan > --- > drive

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-19 Thread Jonathan Cameron
ry type is created for storing all memory types that are > not initialized by device drivers and as a fallback. > > Signed-off-by: Ho-Ren (Jack) Chuang > Signed-off-by: Hao Xiang > Reviewed-by: "Huang, Ying" Reviewed-by: Jonathan Cameron

Re: [PATCH] dt-bindings: iio: imu: mpu6050: Improve i2c-gate disallow list

2024-04-13 Thread Jonathan Cameron
On Tue, 9 Apr 2024 08:36:08 +0200 Krzysztof Kozlowski wrote: > On 08/04/2024 18:34, Luca Weiss wrote: > > Before all supported sensors except for MPU{9150,9250,9255} were not > > allowed to use i2c-gate in the bindings which excluded quite a few > > supported sensors where this functionality is

Re: [External] Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-10 Thread Jonathan Cameron
On Tue, 9 Apr 2024 12:02:31 -0700 "Ho-Ren (Jack) Chuang" wrote: > Hi Jonathan, > > On Tue, Apr 9, 2024 at 9:12 AM Jonathan Cameron > wrote: > > > > On Fri, 5 Apr 2024 15:43:47 -0700 > > "Ho-Ren (Jack) Chuang" wrote: > > > >

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-09 Thread Jonathan Cameron
On Fri, 5 Apr 2024 15:43:47 -0700 "Ho-Ren (Jack) Chuang" wrote: > On Fri, Apr 5, 2024 at 7:03 AM Jonathan Cameron > wrote: > > > > On Fri, 5 Apr 2024 00:07:06 + > > "Ho-Ren (Jack) Chuang" wrote: > > > > > The current implemen

Re: [PATCH] Documentation: ABI: document in_temp_input file

2024-04-06 Thread Jonathan Cameron
the line above to not reuse X. A good additional thing but needs mentioning in the commit message. Thanks, Jonathan > --- > Documentation/ABI/testing/sysfs-bus-iio | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio >

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-05 Thread Jonathan Cameron
ry type is created for storing all memory types that are > not initialized by device drivers and as a fallback. > > Signed-off-by: Ho-Ren (Jack) Chuang > Signed-off-by: Hao Xiang > Reviewed-by: "Huang, Ying" Hi - one remaining question. Why can't we delay init for all

Re: [PATCH v11 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-04-05 Thread Jonathan Cameron
gned-off-by: Ho-Ren (Jack) Chuang > Reviewed-by: "Huang, Ying" Reviewed-by: Jonathan Cameron

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-04 Thread Jonathan Cameron
configuration or? 3 tabs + 1 space + the text from * (58) = 24 + 1 + 58 = 83 Advantage of using claws email for kernel stuff is it has a nice per character ruler at the top of the window. I wonder if you have a different tab indent size? The kernel uses 8 characters. It migh

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-03 Thread Jonathan Cameron
A few minor comments inline. > diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h > index a44c03c2ba3a..16769552a338 100644 > --- a/include/linux/memory-tiers.h > +++ b/include/linux/memory-tiers.h > @@ -140,12 +140,13 @@ static inline int mt_perf_to_adistance(struct >

Re: [PATCH v10 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-04-03 Thread Jonathan Cameron
gned-off-by: Ho-Ren (Jack) Chuang > Reviewed-by: "Huang, Ying" Hi, I know this is a late entry to the discussion but a few comments inline. (sorry I didn't look earlier!) All opportunities to improve code complexity and readability as a result of your factoring out. Jonathan >

[PATCH] uprobes: reduce contention on uprobes_tree access

2024-03-21 Thread Jonathan Haslam
reduction for mean uprobe execution time is observed (28 -> 3.5 microsecs). [0] https://docs.kernel.org/locking/spinlocks.html Signed-off-by: Jonathan Haslam --- kernel/events/uprobes.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/kernel/eve

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-15 Thread Jonathan Cameron
On Wed, 14 Feb 2024 17:33:18 -0500 Steven Rostedt wrote: > On Wed, 14 Feb 2024 14:19:19 -0800 > Ira Weiny wrote: > > > > > Jonathan Cameron wrote: > > > > > > > > > So I'm thinking this is a won't fix - wait for the print

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-14 Thread Jonathan Cameron
On Wed, 14 Feb 2024 10:23:10 -0500 Steven Rostedt wrote: > On Wed, 14 Feb 2024 12:11:53 + > Jonathan Cameron wrote: > > > So I'm thinking this is a won't fix - wait for the printk rework to land and > > assume this will be resolved as well? > > That pretty mu

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-14 Thread Jonathan Cameron
/ Note I also tried the hacks Peter links to from there. They trip issues in the initial CPER print - so I assume not appropriate here. So I'm thinking this is a won't fix - wait for the printk rework to land and assume this will be resolved as well? Jonathan > --- > Changes in v2: > -

Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-19 Thread Jonathan Cameron
benefit from a cleanup using these, so change these > where applicable. > > Cc: Joao Martins > Cc: Dan Williams > Signed-off-by: Vishal Verma Hi Vishal, A few really minor suggestions inline if you happen to be doing a v7. Either way Reviewed-by: Jonathan Cameron > >

Re: [PATCH v4 1/3] Documentatiion/ABI: Add ABI documentation for sys-bus-dax

2023-12-13 Thread Jonathan Cameron
On Tue, 12 Dec 2023 12:08:30 -0700 Vishal Verma wrote: > Add the missing sysfs ABI documentation for the device DAX subsystem. > Various ABI attributes under this have been present since v5.1, and more > have been added over time. In preparation for adding a new attribute, > add this file with

Re: [PATCH v4 2/3] dax/bus: Introduce guard(device) for device_{lock,unlock} flows

2023-12-13 Thread Jonathan Cameron
cleanup that result. Note that almost every time I see people using this stuff they don't look again at the code post the change so miss the wider cleanup that it enables. So you are in good company ;) Jonathan > --- > include/linux/device.h | 2

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-25 Thread Jonathan Cameron
On Fri, 24 Nov 2023 10:21:21 +0100 Krzysztof Kozlowski wrote: > Use only one and exactly one space around '=' in DTS example. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Jonathan Cameron #for-iio > --- > > Merging idea: Rob's DT. > Should apply c

Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings

2023-10-14 Thread Jonathan Cameron
On Fri, 13 Oct 2023 10:09:53 +0200 Luca Weiss wrote: > Add the defines for the ADC channels found on the PM7325. The list is > taken from downstream msm-5.4 and adjusted for mainline. > > Signed-off-by: Luca Weiss I assume this will go with the dts changes that use it. Acked-

Re: [PATCH RESEND 2/4] acpi, hmat: refactor hmat_register_target_initiators()

2023-08-07 Thread Jonathan Cameron
formance attributes separately. > > Signed-off-by: "Huang, Ying" > Cc: Aneesh Kumar K.V > Cc: Wei Xu > Cc: Alistair Popple > Cc: Dan Williams > Cc: Dave Hansen > Cc: Davidlohr Bueso > Cc: Johannes Weiner > Cc: Jonathan Cameron > Cc: Michal Hocko >

Re: [PATCH v3 2/2] dax/kmem: allow kmem to add memory with memmap_on_memory

2023-08-02 Thread Jonathan Cameron
-by: Vishal Verma Hi Vishal, In general looks fine to me. Just a question for potential discussion if didn't miss it in earlier versions. FWIW Reviewed-by: Jonathan Cameron Also, any docs need updating? Doesn't seem like the DAX ABI docs are present in Documentation/ABI so not sure where it

Re: [PATCH v3 1/2] mm/memory_hotplug: split memmap_on_memory requests across memblocks

2023-08-02 Thread Jonathan Cameron
On Tue, 01 Aug 2023 23:55:37 -0600 Vishal Verma wrote: > The MHP_MEMMAP_ON_MEMORY flag for hotplugged memory is restricted to > 'memblock_size' chunks of memory being added. Adding a larger span of > memory precludes memmap_on_memory semantics. > > For users of hotplug such as kmem, large

Re: [PATCH 1/3] mm/memory_hotplug: Allow an override for the memmap_on_memory param

2023-06-22 Thread Jonathan Cameron
tions for it are met. > > Just let the admin configure it. After all, an admin is involved in > configuring the dax/kmem device to begin with. If add_memory() fails you > could give a useful hint to the admin. > Agreed. If it were just the default then fine, but making it the only option limits admin choices. Jonathan

Re: [PATCH v2] docs: driver-model: Update the documentation for device class

2021-04-20 Thread Jonathan Corbet
Manivannan Sadhasivam writes: > The current documentation about the device class is out of date such > that it refers to non-existent APIs and structures. This commit updates > them to the current device class APIs and structures, removes wordings > that no longer valid while trying to keep the

[PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Jonathan Cameron
On Mon, 19 Apr 2021 20:45:08 +0100 Jonathan Cameron wrote: > On Mon, 19 Apr 2021 16:34:35 +0300 > Tomas Melin wrote: > > > Hi, > > > > On 4/18/21 1:03 PM, Jonathan Cameron wrote: > > > On Fri, 16 Apr 2021 15:21:14 +0300 > > > Tomas Melin

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Jonathan Cameron
On Mon, 19 Apr 2021 16:34:35 +0300 Tomas Melin wrote: > Hi, > > On 4/18/21 1:03 PM, Jonathan Cameron wrote: > > On Fri, 16 Apr 2021 15:21:14 +0300 > > Tomas Melin wrote: > > > >> Updated email-address for Alexandru. > >> > >> > >&g

Re: [PATCH v2 01/12] docs: path-lookup: update follow_managed() part

2021-04-19 Thread Jonathan Corbet
Fox Chen writes: > On Mon, Apr 19, 2021 at 11:25 AM Matthew Wilcox wrote: >> >> On Mon, Apr 19, 2021 at 10:33:00AM +0800, Fox Chen wrote: >> > On Mon, Apr 19, 2021 at 10:17 AM Matthew Wilcox >> > wrote: >> > > You can drop ``..`` from around function named which are followed with >> > > ().

Re: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support

2021-04-18 Thread Jonathan Cameron
On Sun, 18 Apr 2021 16:59:02 +0300 Andy Shevchenko wrote: > On Sun, Apr 18, 2021 at 4:49 PM Andy Shevchenko > wrote: > > > > On Sun, Apr 18, 2021 at 2:07 PM Jonathan Cameron wrote: > > > > Thanks for review, my answers below. > > > > > On Wed, 14

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
und at: > https://www.murata.com/en-global/products/sensor/accel/sca3300 > > Signed-off-by: Tomas Melin A few things inline. Mostly looks pretty good Jonathan > --- > drivers/iio/accel/Kconfig | 13 + > drivers/iio/accel/Makefile | 1 + > drivers/iio/accel/sca3300.c | 468 +

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
That part drove a lot of the weirder corners of IIO in the early days and had features that didn't show up anywhere else for quite a few years. The sca3100 onwards were much simpler (from software point of view) - I guess Murata have a different focus than VTI did. Jonathan

Re: [PATCH 1/2] HID: hid-sensor-hub: Return error for hid_set_field() failure

2021-04-18 Thread Jonathan
On Sun, 18 Apr 2021 12:12:44 +0100 Jonathan Cameron wrote: > On Thu, 15 Apr 2021 11:52:31 -0700 > Srinivas Pandruvada wrote: > > > In the function sensor_hub_set_feature(), return error when hid_set_field() > > fails. > > > > Signed-off-by: Sriniv

Re: [PATCH 1/2] HID: hid-sensor-hub: Return error for hid_set_field() failure

2021-04-18 Thread Jonathan Cameron
e window, so will turn up in next sometime after rc1. thanks, Jonathan > --- > drivers/hid/hid-sensor-hub.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c > index 3dd7d3246737..f9983

Re: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support

2021-04-18 Thread Jonathan Cameron
On Wed, 14 Apr 2021 22:54:53 +0300 Andy Shevchenko wrote: > We can utilize separate drivers for accelerometer and magnetometer, > so here is the glue driver to enable LSM9DS0 IMU support. > > The idea was suggested by Crestez Dan Leonard in [1]. The proposed change > was sent as RFC due to race

Re: [PATCH v1 4/7] iio: st_sensors: Call st_sensors_power_enable() from bus drivers

2021-04-18 Thread Jonathan Cameron
ces would double up and both get + enable + disable the regulators. However, that shouldn't matter as they are reference counted anyway. Perhaps an example? Even in patch 6 I can only see that it is wasteful to do it twice, rather than wrong as such. Jonathan > > Signed-off-by:

Re: [PATCH] iio: hid-sensors: select IIO_TRIGGERED_BUFFER under HID_SENSOR_IIO_TRIGGER

2021-04-18 Thread Jonathan Cameron
sors: move triggered buffer setup > > into hid_sensor_setup_trigger") > > Reported-by: Thomas Deutschmann > > Cc: Srinivas Pandruvada > > Signed-off-by: Alexandru Ardelean > Acked-by: Srinivas Pandruvada Applied to the fixes-togreg branch of iio.git. Always good to see t

Re: [PATCH v2 1/1] iio: adc: ad7298: Enable on Intel Galileo Gen 1

2021-04-18 Thread Jonathan Cameron
On Mon, 12 Apr 2021 16:18:35 +0300 Andy Shevchenko wrote: > Enable ADC on Intel Galileo Gen 1 board. > > Signed-off-by: Andy Shevchenko Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to hopefully not notice we did anything ;) Jonathan > ---

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
: > > > > commit f73f7f4da581875f9b1f2fb8ebd1ab15ed634488 > > Author: Alexandru Ardelean > > Date:   Mon Feb 15 12:40:39 2021 +0200 > > > >     iio: buffer: add ioctl() to support opening extra buffers for IIO > > device > > > > > > Any th

Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

2021-04-18 Thread Jonathan Cameron
On Sun, 11 Apr 2021 21:08:29 +0300 Andy Shevchenko wrote: > On Sun, Apr 11, 2021 at 9:07 PM Andy Shevchenko > wrote: > > On Sun, Apr 11, 2021 at 5:53 PM Jonathan Cameron wrote: > > > On Wed, 7 Apr 2021 23:51:47 +0530 > > > Puranjay Mohan wrote: > >

Re: [PATCH] [v2] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error

2021-04-18 Thread Jonathan Cameron
ct given tags. > > > Fixes: 4ac4e086fd8c5 ("iio: pulsedlight-lidar-lite: add runtime PM") > > Signed-off-by: Dinghao Liu I gathered up the tags by hand and applied to the fixes-togreg branch of iio.git Thanks, Jonathan > > --- > > > > Changelog: > > >

Re: [PATCH] iio: light: gp2ap002: Fix rumtime PM imbalance on error

2021-04-18 Thread Jonathan Cameron
On Mon, 12 Apr 2021 13:47:58 +0200 Linus Walleij wrote: > On Mon, Apr 12, 2021 at 12:16 PM Jonathan Cameron > wrote: > > > An example would be the bmc150_magn driver which does exactly the > > same call sequence as this one, but without the reference count increm

Re: [PATCH v8 1/2] Added AMS tsl2591 driver implementation

2021-04-18 Thread Jonathan Cameron
lean up those last few corners! Thanks, Jonathan > --- > Changes in v8; > - tsl2591_write_raw() - goto after tsl2591_set_als_gain_int_time() not > necessary > - tsl2591_read_event_value() and tsl2591_write_event_value() - break instead > of goto in default case > - Introduc

Re: [PATCH 21/57] staging: iio: frequency: ad9834: Provide missing description for 'devid'

2021-04-16 Thread Jonathan Cameron
ernel-doc.rst > > Cc: Lars-Peter Clausen > Cc: Michael Hennerich > Cc: Jonathan Cameron > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: linux-stag...@lists.linux.dev > Signed-off-by: Lee Jones I was leaving the staging stuff in IIO related to W=1 as good mate

Re: [PATCH] drm/rockchip: Cope with endpoints that haven't been registered yet

2021-04-16 Thread Jonathan McDowell
On Sun, Mar 21, 2021 at 07:58:13PM +0100, Heiko Stuebner wrote: > Am Dienstag, 16. März 2021, 19:27:53 CET schrieb Jonathan McDowell: > > The Rockchip RGB CRTC output driver attempts to avoid probing Rockchip > > subdrivers to see if they're a connected panel or bridge. However

Re: [RFC] scripts: kernel-doc: improve parsing for kernel-doc comments syntax

2021-04-15 Thread Jonathan Corbet
e > content inside does not adheres to the expected format. > > Improve parsing by adding support for these probable attempts to write > kernel-doc comment. > > Suggested-by: Jonathan Corbet > Link: https://lore.kernel.org/lkml/87mtujktl2@meer.lwn.net > Signed-off-by: Adi

Re: [RFC 0/2] Add a new translation tool scripts/trslt.py

2021-04-15 Thread Jonathan Corbet
Wu XiangCheng writes: > Hi all, > > This set of patches aim to add a new translation tool - trslt.py, which > can control the transltions version corresponding to source files. > > For a long time, kernel documentation translations lacks a way to control the > version corresponding to the source

Re: [PATCH v3] Documentation: dev-tools: Add Testing Overview

2021-04-15 Thread Jonathan Corbet
David Gow writes: > The kernel now has a number of testing and debugging tools, and we've > seen a bit of confusion about what the differences between them are. > > Add a basic documentation outlining the testing tools, when to use each, > and how they interact. > > This is a pretty quick

Re: [PATCH v6] docs/zh_CN: add translations in zh_CN/dev-tools/gcov

2021-04-15 Thread Jonathan Corbet
Wu XiangCheng writes: > From: Bernard Zhao > > Add new zh translations > * zh_CN/dev-tools/gcov.rst > * zh_CN/dev-tools/index.rst > and link them to zh_CN/index.rst > > Signed-off-by: Bernard Zhao > Reviewed-by: Wu XiangCheng > Reviewed-by: Alex Shi > Reviewed-by: Fangrui Song >

Re: [”PATCH” 2/5] PCI: armada8k: Add link-down handle

2021-04-14 Thread Jonathan Cameron
On Mon, 12 Apr 2021 18:30:53 +0300 wrote: > From: Ben Peled > > In PCIE ISR routine caused by RST_LINK_DOWN > we schedule work to handle the link-down procedure. > Link-down procedure will: > 1. Remove PCIe bus > 2. Reset the MAC > 3. Reconfigure link back up > 4. Rescan PCIe bus > >

Re: [PATCH] cxl/mem: Add media provisioning required commands

2021-04-14 Thread Jonathan Cameron
> Signed-off-by: Ben Widawsky Checked all the numbers (not much else in this one ;) Reviewed-by: Jonathan Cameron You could give more info on why this particular list, but to my mind it's all fairly obvious so perhaps not worth bothering. > --- > drivers/cxl/mem.c| 19 ++

Re: [PATCH] cxl/mem: Clarify UAPI documentation

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 07:32:47 -0700 Ben Widawsky wrote: > Signed-off-by: Ben Widawsky Sensible update. Acked-by: Jonathan Cameron > --- > include/uapi/linux/cxl_mem.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/uapi/linux/cxl_mem.h b/include/ua

Re: [PATCH 4/7] cxl/mem: Get rid of @cxlm.base

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 09:17:26 -0700 Ben Widawsky wrote: > On 21-04-08 18:26:35, Jonathan Cameron wrote: > > On Wed, 7 Apr 2021 15:26:22 -0700 > > Ben Widawsky wrote: > > > > > @cxlm.base only existed to support holding the base found in the > > > registe

Re: [PATCH v2 1/8] cxl/mem: Move some definitions to mem.h

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 17:42:37 -0700 Dan Williams wrote: > On Tue, Apr 13, 2021 at 5:18 PM Dan Williams wrote: > > > > On Tue, Apr 6, 2021 at 10:47 AM Jonathan Cameron > > wrote: > > > > > > On Thu, 1 Apr 2021 07:30:47 -0700 > > > Dan Williams w

Re: [RFC PATCH v1 00/11] Manage the top tier memory in a tiered memory

2021-04-14 Thread Jonathan Cameron
ode_3 > might be third tier and similarly for jobs running on node_1, node_2 > might be third tier. > > The reason I am asking these questions is that the statically > partitioning memory nodes into tiers will inherently add platform > specific assumptions in the user API. Absolutely agree. > > Assumptions like: > 1) Access within tier is always cheaper than across tier. > 2) Access from tier_i to tier_i+1 has uniform cost. > > The reason I am more inclined towards having numa centric control is > that we don't have to make these assumptions. Though the usability > will be more difficult. Greg (CCed) has some ideas on making it better > and we will share our proposal after polishing it a bit more. > Sounds good, will look out for that. Jonathan

Re: [PATCH] doc/virt/kvm: move KVM_X86_SET_MSR_FILTER in section 8

2021-04-13 Thread Jonathan Corbet
Emanuele Giuseppe Esposito writes: > KVM_X86_SET_MSR_FILTER is a capability, not an ioctl. > Therefore move it from section 4.97 to the new 8.31 (other capabilities). > > To fill the gap, move KVM_X86_SET_MSR_FILTER (was 4.126) to > 4.97, and shifted Xen-related ioctl (were 4.127 - 4.130) by >

Re: [PATCH v2 00/12] docs: path-lookup: Update pathlookup docs

2021-04-13 Thread Jonathan Corbet
Fox Chen writes: > The Path lookup is a very complex subject in VFS. The path-lookup > document provides a very detailed guidance to help people understand > how path lookup works in the kernel. This document was originally > written based on three lwn articles five years ago. As times goes by,

Re: [PATCH v2 0/2] Mention regression mailing list in reporting-bugs and MAINTAINERS

2021-04-13 Thread Jonathan Corbet
bit unsure how to actually do that, see the note in the > first patch of the series for details. > > The second patch makes reporting-issues.rst mention the new list, so people CC > it. > > @Jonathan: this hopefully is the last round of patches for > reporting-issues.rst > for this

Re: [PATCH] doc:it_IT: align Italian documentation

2021-04-13 Thread Jonathan Corbet
Federico Vaga writes: > Translation for the following patches > > commit 7dfbea4c468c ("scripts: remove namespace.pl") > commit 1a63f9cce7b7 ("docs: Remove make headers_check from checklist") > commit 1e013ff7cb54 ("docs: Document cross-referencing using relative path") > commit 0be1511f516e

Re: [PATCH] Documentation/submitting-patches: Document RESEND tag on patches

2021-04-13 Thread Jonathan Corbet
Borislav Petkov writes: > Hi Jon, > > here's the next piece of documentation which should be generic enough. > > Thx. > > --- > From: Borislav Petkov > Date: Tue, 13 Apr 2021 13:26:29 +0200 > > Explain when a submitter should tag a patch or a patch series with the > "RESEND" tag. > > This has

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-12 Thread Jonathan Cameron
und at: > https://www.murata.com/en-global/products/sensor/accel/sca3300 > > Signed-off-by: Tomas Melin Hi Tomas, Comments below. Thanks, Jonathan > --- > drivers/iio/accel/Kconfig | 13 ++ > drivers/iio/accel/Makefile | 1 + > drivers/iio/accel/sca3300.c | 434 +++

Re: [PATCH 1/2] dt-bindings: iio: accel: Add SCA3300 documentation

2021-04-12 Thread Jonathan Cameron
On Mon, 12 Apr 2021 10:50:55 +0300 Tomas Melin wrote: > initial DT bindings for Murata SCA3300 Accelerometer. > > Signed-off-by: Tomas Melin Hi Tomas. > --- > .../bindings/iio/accel/sca3300.yaml | 51 +++ > 1 file changed, 51 insertions(+) > create mode 100644

Re: [PATCH] HID: hid-sensor-custom: remove useless variable

2021-04-12 Thread Jonathan Cameron
On Sun, 11 Apr 2021 09:06:35 -0700 Srinivas Pandruvada wrote: > On Sun, 2021-04-11 at 14:56 +0100, Jonathan Cameron wrote: > > On Fri, 09 Apr 2021 11:19:12 -0700 > > Srinivas Pandruvada wrote: > > > > > On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote:

Re: [PATCH] iio: light: gp2ap002: Fix rumtime PM imbalance on error

2021-04-12 Thread Jonathan Cameron
On Mon, 12 Apr 2021 00:38:41 +0200 Linus Walleij wrote: > On Sun, Apr 11, 2021 at 5:07 PM Jonathan Cameron wrote: > > On Wed, 7 Apr 2021 11:49:27 +0800 > > Dinghao Liu wrote: > > > > > When devm_request_threaded_irq() fails, we should decrease the &g

Re: [PATCH v10 1/3] PCI: portdrv: Add pcie_port_service_get_irq() function

2021-04-12 Thread Jonathan Cameron
On Sat, 10 Apr 2021 01:22:16 +0900 Kunihiko Hayashi wrote: > Add pcie_port_service_get_irq() that returns the virtual IRQ number > for specified portdrv service. Trivial comment inline. > > Cc: Lorenzo Pieralisi > Signed-off-by: Kunihiko Hayashi > Reviewed-by: Rob Herring > Acked-by: Bjorn

Re: [PATCH] Documentation: dev-tools: Add Testing Overview

2021-04-11 Thread Jonathan Corbet
A nit but > +The bulk of kernel tests are written using either the :doc:`kselftest > +` or :doc:`KUnit ` frameworks. These both provide > +infrastructure to help make running tests and groups of tests easier, as well > +as providing helpers to aid in writing new tests. If you just mention the

Re: [PATCH] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error

2021-04-11 Thread Jonathan Cameron
to backport it. Please add for v2. Thanks, Jonathan > --- > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c > b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c > index

Re: [PATCH] iio: light: gp2ap002: Fix rumtime PM imbalance on error

2021-04-11 Thread Jonathan Cameron
ore. Whilst agree with your assessment that the code is wrong, I'm not totally sure why we need to do the pm_runtime_get_noresume() in the first place. Why do we need to hold the reference for the operations going on here? What can race against this that might care about that reference coun

Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

2021-04-11 Thread Jonathan Cameron
eeks time. Thanks, Jonathan > +static int tmp117_read_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *channel, int *val, > + int *val2, long mask) > +{ > + struct tmp117_data *data = iio_priv(indio_dev); > + s32 ret; >

Re: [PATCH] iio: adc: exynos: drop unneeded variable assignment

2021-04-11 Thread Jonathan Cameron
for this cycle, but I've queued it up for the next one. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if we missed anything. Thanks, Jonathan > --- > drivers/iio/adc/exynos_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] HID: hid-sensor-custom: remove useless variable

2021-04-11 Thread Jonathan Cameron
On Fri, 09 Apr 2021 11:19:12 -0700 Srinivas Pandruvada wrote: > On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote: > > Fix the following gcc warning: > > > > drivers/hid/hid-sensor-custom.c:400:7: warning: variable ‘ret’ set > > but > > not used [-Wunused-but-set-variable]. > > > >

Re: [PATCH 2/3] staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output

2021-04-11 Thread Jonathan Cameron
XCLVL(3); > > > > This logic is problematic now. > > Because no matter what you're setting in the DT, it always gets > > overridden here because there is no platform data. > > > > Maybe a better idea is to do something like: > > if (!pdata) > >

Re: [PATCH 2/3] staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output

2021-04-11 Thread Jonathan Cameron
On Sat, 10 Apr 2021 13:05:14 +0300 Andy Shevchenko wrote: > On Saturday, April 10, 2021, Andy Shevchenko > wrote: > > > > > > > On Friday, April 9, 2021, Lucas Stankus wrote: > > > >> Ditch platform_data fields in favor of device tree properties for > >> configuring EXCA and EXCB output. >

Re: [PATCH 1/3] dt-bindings: staging: iio: cdc: ad7746: add binding documentation for AD7746

2021-04-11 Thread Jonathan Cameron
ttributes easy to comprehend without needing to refer to the documentation. Always good to avoid magic numbers if we can. Suggestions inline. Jonathan > --- > .../bindings/iio/cdc/adi,ad7746.yaml | 79 +++ > 1 file changed, 79 insertions(+) > create mode

[tip: timers/core] clocksource/drivers/npcm: Add support for WPCM450

2021-04-09 Thread tip-bot2 for Jonathan Neuschäfer
The following commit has been merged into the timers/core branch of tip: Commit-ID: 690daddcb60246d8a510aaad7b954bcc53eba17e Gitweb: https://git.kernel.org/tip/690daddcb60246d8a510aaad7b954bcc53eba17e Author:Jonathan Neuschäfer AuthorDate:Sat, 20 Mar 2021 19:16:06 +01:00

[tip: timers/core] dt-bindings: timer: nuvoton,npcm7xx: Add wpcm450-timer

2021-04-09 Thread tip-bot2 for Jonathan Neuschäfer
The following commit has been merged into the timers/core branch of tip: Commit-ID: 8120891105ba32b45bc35f7dc07e6d87a8314556 Gitweb: https://git.kernel.org/tip/8120891105ba32b45bc35f7dc07e6d87a8314556 Author:Jonathan Neuschäfer AuthorDate:Sat, 20 Mar 2021 19:16:01 +01:00

Re: [RFC PATCH 01/10] genirq: Add chip flag to denote automatic IRQ (un)masking

2021-04-09 Thread Jonathan Cameron
On Thu, 8 Apr 2021 16:43:17 +0100 Valentin Schneider wrote: > Some IRQ chips such as the Arm GICs automagically mask / unmask an > IRQ during the handling of said IRQ. This renders further mask / unmask > operations within the flow handlers redundant, which we do want to leverage > as masking by

  1   2   3   4   5   6   7   8   9   10   >