Re: [PATCH v4 2/7] cxl/core: Remove CONFIG_CXL_SUSPEND and always build suspend.o

2025-06-10 Thread Jonathan Cameron
On Mon, 9 Jun 2025 16:25:49 -0700 "Koralahalli Channabasappa, Smita" wrote: > On 6/9/2025 4:02 AM, Jonathan Cameron wrote: > > On Tue, 3 Jun 2025 22:19:44 + > > Smita Koralahalli wrote: > > > >> In preparation for soft-reserved resource handli

Re: [PATCH v4 5/7] cxl/region: Introduce SOFT RESERVED resource removal on region teardown

2025-06-10 Thread Jonathan Cameron
Hi Smita, > >> +/* > >> + * normalize_resource > >> + * > >> + * The walk_iomem_res_desc() returns a copy of a resource, not a reference > >> + * to the actual resource in the iomem_resource tree. As a result, > >> + * __release_resource() which relies on pointer equality will fail. > > > > Pro

Re: [PATCH v4 7/7] cxl/dax: Defer DAX consumption of SOFT RESERVED resources until after CXL region creation

2025-06-09 Thread Jonathan Cameron
On Tue, 3 Jun 2025 22:19:49 + Smita Koralahalli wrote: > From: Nathan Fontenot > > The DAX HMEM driver currently consumes all SOFT RESERVED iomem resources > during initialization. This interferes with the CXL driver’s ability to > create regions and trim overlapping SOFT RESERVED ranges be

Re: [PATCH v4 5/7] cxl/region: Introduce SOFT RESERVED resource removal on region teardown

2025-06-09 Thread Jonathan Cameron
On Tue, 3 Jun 2025 22:19:47 + Smita Koralahalli wrote: > Reworked from a patch by Alison Schofield > > Previously, when CXL regions were created through autodiscovery and their > resources overlapped with SOFT RESERVED ranges, the soft reserved resource > remained in place after region tear

Re: [PATCH v4 2/7] cxl/core: Remove CONFIG_CXL_SUSPEND and always build suspend.o

2025-06-09 Thread Jonathan Cameron
On Tue, 3 Jun 2025 22:19:44 + Smita Koralahalli wrote: > In preparation for soft-reserved resource handling, make the suspend > infrastructure always available by removing the CONFIG_CXL_SUSPEND > Kconfig option. > > This ensures cxl_mem_active_inc()/dec() and cxl_mem_active() are > uncondit

Re: [PATCH v9 01/19] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD)

2025-04-15 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:09 -0500 Ira Weiny wrote: > Per the CXL 3.1 specification software must check the Command Effects > Log (CEL) for dynamic capacity command support. > > Detect support for the DCD commands while reading the CEL, including: > > Get DC Config > Get DC Extent L

Re: [PATCH v9 00/19] DCD: Add support for Dynamic Capacity Devices (DCD)

2025-04-15 Thread Jonathan Cameron
On Mon, 14 Apr 2025 21:50:31 -0700 Dan Williams wrote: > Jonathan Cameron wrote: > [..] > > To me we don't need to answer the question of whether we fully understand > > requirements, or whether this support covers them, but rather to ask > > if anyone has requirem

Re: [PATCH v9 03/19] cxl/cdat: Gather DSMAS data for DCD partitions

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:11 -0500 Ira Weiny wrote: > Additional DCD partition (AKA region) information is contained in the > DSMAS CDAT tables, including performance, read only, and shareable > attributes. > > Match DCD partitions with DSMAS tables and store the meta data. > > Signed-off-by: I

Re: [PATCH v9 00/19] DCD: Add support for Dynamic Capacity Devices (DCD)

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:08 -0500 Ira Weiny wrote: > A git tree of this series can be found here: > > https://github.com/weiny2/linux-kernel/tree/dcd-v6-2025-04-13 > > This is now based on 6.15-rc2. Hi Ira, Firstly thanks for the update and your hard work driving this forwards. > > D

Re: [PATCH v9 16/19] cxl/region: Read existing extents on region creation

2025-04-14 Thread Jonathan Cameron
after the driver has loaded will surface through the normal notification > path while extents seen prior to the driver are read during driver load. > > Based on an original patch by Navneet Singh. > > Reviewed-by: Jonathan Cameron > Reviewed-by: Fan Ni > Signed-off-by: Ira

Re: [PATCH v9 12/19] cxl/extent: Process dynamic partition events and realize region extents

2025-04-14 Thread Jonathan Cameron
> of 0 are allowed. This defines existing DAX devices as having a 0 tag > which makes the most logical sense as a default. > > Process DCD events and create region devices. > > Based on an original patch by Navneet Singh. > > Reviewed-by: Dave Jiang > Reviewed-

Re: [PATCH v9 07/19] cxl/region: Add sparse DAX region support

2025-04-14 Thread Jonathan Cameron
ned-off-by: Ira Weiny > I'm not that familiar with the DAX parts but looks fine to me. Reviewed-by: Jonathan Cameron

Re: [PATCH v9 06/19] cxl/port: Add 'dynamic_ram_a' to endpoint decoder mode

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:14 -0500 Ira Weiny wrote: > Endpoints can now support a single dynamic ram partition following the > persistent memory partition. > > Expand the mode to allow a decoder to point to the first dynamic ram > partition. > > Signed-off-by: Ira Weiny

Re: [PATCH v9 05/19] cxl/mem: Expose dynamic ram A partition in sysfs

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:13 -0500 Ira Weiny wrote: > To properly configure CXL regions user space will need to know the > details of the dynamic ram partition. > > Expose the first dynamic ram partition through sysfs. > > Signed-off-by: Ira Weiny > LGTM Reviewed-by: Jonathan Cameron

Re: [PATCH v9 04/19] cxl/core: Enforce partition order/simplify partition calls

2025-04-14 Thread Jonathan Cameron
he preservation of the implied > partition order. > > Signed-off-by: Ira Weiny One trivial thing inline. To me this patch stands on it's own irrespective of the rest of the series. Maybe one to queue up early as a cleanup? Reviewed-by: Jonathan Cameron Jonathan > --- &

Re: [PATCH v9 02/19] cxl/mem: Read dynamic capacity configuration from the device

2025-04-14 Thread Jonathan Cameron
On Sun, 13 Apr 2025 17:52:10 -0500 Ira Weiny wrote: > Devices which optionally support Dynamic Capacity (DC) are configured > via mailbox commands. CXL 3.2 section 9.13.3 requires the host to issue > the Get DC Configuration command in order to properly configure DCDs. > Without the Get DC Confi

Re: [PATCH v3 1/4] kernel/resource: Provide mem region release for SOFT RESERVES

2025-04-04 Thread Jonathan Cameron
On Thu, 3 Apr 2025 13:33:12 -0500 Terry Bowman wrote: > From: Nathan Fontenot > > Add a release_Sam_region_adjustable() interface to allow for Who is Sam? (typo) > removing SOFT RESERVE memory resources. This extracts out the code > to remove a mem region into a common __release_mem_region_a

Re: [PATCH v2] DAX: warn when kmem regions are truncated for memory block alignment.

2025-04-04 Thread Jonathan Cameron
c-aligned but block-misaligned chunks. > > Suggested-by: David Hildenbrand > Suggested-by: Dan Williams > Signed-off-by: Gregory Price One trivial comment inline otherwise seems reasonable to me. Reviewed-by: Jonathan Cameron > --- > drivers/dax/kmem.c | 10 +

Re: [PATCH v3 4/4] cxl/dax: Delay consumption of SOFT RESERVE resources

2025-04-04 Thread Jonathan Cameron
On Thu, 3 Apr 2025 13:33:15 -0500 Terry Bowman wrote: > From: Nathan Fontenot > > The dax hmem device initialization will consume any iomem > SOFT RESERVE resources prior to CXL region creation. To allow > for the CXL driver to complete region creation and trim any > SOFT RESERVE resources befo

Re: [PATCH v3 3/4] dax/mum: Save the dax mum platform device pointer

2025-04-04 Thread Jonathan Cameron
On Thu, 3 Apr 2025 13:33:14 -0500 Terry Bowman wrote: > From: Nathan Fontenot mum? > > In order to handle registering hmem devices for SOFT RESERVE > resources after the dax hmem device initialization occurs > we need to save a reference to the dax hmem platform device > that will be used in

Re: [PATCH v3 2/4] cxl: Update Soft Reserved resources upon region creation

2025-04-04 Thread Jonathan Cameron
On Thu, 3 Apr 2025 13:33:13 -0500 Terry Bowman wrote: > From: Nathan Fontenot > > Update handling of SOFT RESERVE iomem resources that intersect with > CXL region resources to remove intersections from the SOFT RESERVE > resources. The current approach of leaving SOFT RESERVE resources as > is

Re: [PATCH 1/3] of: reserved_mem: Add functions to parse "memory-region"

2025-03-18 Thread Jonathan Cameron
On Mon, 17 Mar 2025 18:24:21 -0500 "Rob Herring (Arm)" wrote: > Drivers with "memory-region" properties currently have to do their own > parsing of "memory-region" properties. The result is all the drivers > have similar patterns of a call to parse "memory-region" and then get > the region's addr

Re: [PATCH v5 6/8] iio: light: stk3310: use dev_err_probe where possible

2025-02-11 Thread Jonathan Cameron
On Sun, 9 Feb 2025 16:47:44 +0200 Andy Shevchenko wrote: > On Sat, Feb 08, 2025 at 04:13:24PM -0500, Aren Moynihan wrote: > > Using dev_err_probe instead of dev_err and return makes the errors > > Use dev_err_probe() > dev_err() > > > easier to understand by including the error name, and save

Re: [PATCH v4 4/6] iio: light: stk3310: use dev_err_probe where possible

2024-11-23 Thread Jonathan Cameron
On Tue, 12 Nov 2024 18:11:37 -0500 Aren wrote: > On Tue, Nov 12, 2024 at 11:15:54AM +0100, Uwe Kleine-König wrote: > > Hello Andy, hello Aren, > > > > On Mon, Nov 11, 2024 at 11:44:51AM +0200, Andy Shevchenko wrote: > > > On Sun, Nov 10, 2024 at 04:34:30PM -0500, Aren wrote: > > > > On Sun,

Re: [PATCH v4 3/6] iio: light: stk3310: Implement vdd and leda supplies

2024-11-03 Thread Jonathan Cameron
On Sat, 2 Nov 2024 15:50:39 -0400 Aren Moynihan wrote: > The vdd and leda supplies must be powered on for the chip to function > and can be powered off during system suspend. > > This was originally based on a patch by Ondrej Jirman[1], but has been > rewritten since. > > 1: > https://codeber

Re: [PATCH v4 2/6] iio: light: stk3310: handle all remove logic with devm callbacks

2024-11-03 Thread Jonathan Cameron
Hi Aren, > @@ -624,7 +640,7 @@ static int stk3310_probe(struct i2c_client *client) > device_property_read_u32(&client->dev, "proximity-near-level", >&data->ps_near_level); > > - mutex_init(&data->lock); > + devm_mutex_init(&client->dev, &data->lock);

Re: [PATCH v3 3/6] iio: light: stk3310: Implement vdd and leda supplies

2024-10-28 Thread Jonathan Cameron
On Mon, 28 Oct 2024 12:37:14 -0400 Aren Moynihan wrote: > On Mon, Oct 28, 2024 at 04:38:37PM +0200, Andy Shevchenko wrote: > > On Mon, Oct 28, 2024 at 10:19:57AM -0400, Aren Moynihan wrote: > > > The vdd and leda supplies must be powered on for the chip to function > > > and can be powered off

Re: [PATCH v3 0/6] iio: light: stk3310: support powering off during suspend

2024-10-28 Thread Jonathan Cameron
On Mon, 28 Oct 2024 10:19:54 -0400 Aren Moynihan wrote: > In the Pine64 PinePhone, the stk3310 chip is powered by a regulator that is > disabled at system boot and can be shut off during suspend. To ensure that > the chip properly initializes, both after boot and suspend, we need to > manage this

Re: [PATCH v8 8/8] selftests/pcie_bwctrl: Create selftests

2024-10-17 Thread Jonathan Cameron
gt; PCIe Port. > > Signed-off-by: Ilpo Järvinen My bash is terrible, but as far as I can tell this looks reasonable. So with that in mind take this with a pinch of salt. Reviewed-by: Jonathan Cameron

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-26 Thread Jonathan Cameron
On Thu, 25 Jul 2024 14:50:50 +0100 David Woodhouse wrote: > On Thu, 2024-07-25 at 08:33 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 01:31:19PM +0100, David Woodhouse wrote: > > > On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > > > > On Thu, Jul 25, 2024 at 01:2

Re: [PATCH 17/17] mm: make range-to-target_node lookup facility a part of numa_memblks

2024-07-19 Thread Jonathan Cameron
lks are now part of the generic code, move these > functions from x86 to mm/numa_memblks.c and select > CONFIG_NUMA_KEEP_MEMINFO when CONFIG_NUMA_MEMBLKS=y for dax and cxl. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron Thanks. I'll poke around more next week. Have a good weekend. Jonathan

Re: [PATCH 12/17] mm: introduce numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:41 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move code dealing with numa_memblks from arch/x86 to mm/ and add Kconfig > options to let x86 select it in its Kconfig. > > This code will be later reused by arch_numa. > > No functional changes. >

Re: [PATCH 16/17] arch_numa: switch over to numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:45 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Until now arch_numa was directly translating firmware NUMA information > to memblock. > > Using numa_memblks as an intermediate step has a few advantages: > * alignment with more battle tested x86 i

Re: [PATCH 15/17] mm: make numa_memblks more self-contained

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:44 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Introduce numa_memblks_init() and move some code around to avoid several > global variables in numa_memblks. Hi Mike, Adding the effectively always on memblock_force_top_down deserves a comment on

Re: [PATCH 13/17] mm: move numa_distance and related code from x86 to numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:42 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move code dealing with numa_distance array from arch/x86 to > mm/numa_memblks.c It's not really numa memblock related. Is this the best place to put it? > > This code will be later reused by arch_

Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned

2024-07-19 Thread Jonathan Cameron
numa emulation code with these architectures. > > Signed-off-by: Mike Rapoport (Microsoft) Makes sense for both reasons. FWIW given how simple it is. Maybe worth bringing a few more functions inline with this? Probably something for another day given we don't care about the inconsistency for this series. Reviewed-by: Jonathan Cameron

Re: [PATCH 10/17] x86/numa_emu: use a helper function to get MAX_DMA32_PFN

2024-07-19 Thread Jonathan Cameron
ort (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 09/17] x86/numa_emu: split __apicid_to_node update to a helper function

2024-07-19 Thread Jonathan Cameron
t (Microsoft) Not the most intuitive of function names but I can't immediately think of a better one. Reviewed-by: Jonathan Cameron

Re: [PATCH 08/17] x86/numa_emu: simplify allocation of phys_dist

2024-07-19 Thread Jonathan Cameron
allocation. > > Replace memblock_phys_alloc_range() with memblock_alloc(). > > Signed-off-by: Mike Rapoport (Microsoft) Indeed seems to be after mapping physical memory, so this looks fine. Reviewed-by: Jonathan Cameron

Re: [PATCH 07/17] x86/numa: move FAKE_NODE_* defines to numa_emu

2024-07-19 Thread Jonathan Cameron
t; Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 06/17] x86/numa: simplify numa_distance allocation

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:35 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Allocation of numa_distance uses memblock_phys_alloc_range() to limit > allocation to be below the last mapped page. > > But NUMA initializaition runs after the direct map is populated and initiali

Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code

2024-07-19 Thread Jonathan Cameron
given that file already has mix and match of those and normal prints in single functions I assume this change is fine and we'll just see the prints a bit later. Reviewed-by: Jonathan Cameron

Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code

2024-07-19 Thread Jonathan Cameron
On Fri, 19 Jul 2024 17:07:35 +0200 David Hildenbrand wrote: > >>> - * Allocate node data. Try node-local memory and then any node. > >>> - * Never allocate in DMA zone. > >>> - */ > >>> - nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); > >>> - if (!nd_pa) { > >>> -

Re: [PATCH 04/17] arch, mm: move definition of node_data to generic code

2024-07-19 Thread Jonathan Cameron
igned-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron

Re: [PATCH 03/17] MIPS: loongson64: rename __node_data to node_data

2024-07-19 Thread Jonathan Cameron
t; Signed-off-by: Mike Rapoport (Microsoft) FWIW rename looks fine Reviewed-by: Jonathan Cameron

Re: [PATCH 02/17] MIPS: sgi-ip27: make NODE_DATA() the same as on all other architectures

2024-07-19 Thread Jonathan Cameron
On Wed, 17 Jul 2024 16:32:59 +0200 David Hildenbrand wrote: > On 16.07.24 13:13, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > sgi-ip27 is the only system that defines NODE_DATA() differently than > > the rest of NUMA machines. > > > > Add node_data array of struct pglist

Re: [PATCH 01/17] mm: move kernel/numa.c to mm/

2024-07-19 Thread Jonathan Cameron
are in arch/*/mm not arch/*/kernel so this makes it more consistent with that. Reviewed-by: Jonathan Cameron

Re: [PATCH 00/17] mm: introduce numa_memblks

2024-07-19 Thread Jonathan Cameron
On Tue, 16 Jul 2024 14:13:29 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Hi, > > Following the discussion about handling of CXL fixed memory windows on > arm64 [1] I decided to bite the bullet and move numa_memblks from x86 to > the generic code so they will be available

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Tue, 23 Apr 2024 18:33:05 -0400 Aren Moynihan wrote: > From: Ondrej Jirman > > VDD power input can be used to completely power off the chip during > system suspend. Do so if available. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Aren Moynihan Suggestions inline. Key thing is take

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Wed, 24 Apr 2024 18:20:41 +0300 Andy Shevchenko wrote: > On Wed, Apr 24, 2024 at 3:59 PM Ondřej Jirman wrote: > > On Wed, Apr 24, 2024 at 02:16:06AM GMT, Andy Shevchenko wrote: > > > On Wed, Apr 24, 2024 at 1:41 AM Aren Moynihan > > > wrote: > > ... > > > > > ret = stk3310_ini

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Wed, 24 Apr 2024 02:16:06 +0300 Andy Shevchenko wrote: > On Wed, Apr 24, 2024 at 1:41 AM Aren Moynihan wrote: > > > > From: Ondrej Jirman > > > > VDD power input can be used to completely power off the chip during > > system suspend. Do so if available. > > ... > > > ret = stk331

Re: [PATCH 3/4] iio: light: stk3310: log error if reading the chip id fails

2024-04-20 Thread Jonathan Cameron
On Mon, 15 Apr 2024 18:05:54 +0300 Andy Shevchenko wrote: > On Sun, Apr 14, 2024 at 8:57 PM Aren Moynihan wrote: > > > > If the chip isn't powered, this call is likely to return an error. > > Without a log here the driver will silently fail to probe. Common errors > > are ENXIO (when the chip is

Re: [PATCH 1/4] dt-bindings: iio: light: stk33xx: add regulator for vdd supply

2024-04-20 Thread Jonathan Cameron
On Sun, 14 Apr 2024 13:57:13 -0400 Aren Moynihan wrote: > Signed-off-by: Aren Moynihan > --- > Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml > b/Documentation/devicetre

Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-20 Thread Jonathan Cameron
On Sun, 14 Apr 2024 13:57:14 -0400 Aren Moynihan wrote: > From: Ondrej Jirman > > VDD power input can be used to completely power off the chip during > system suspend. Do so if available. I'd make this non optional (relying on regulator framework providing us a stub for old DT etc) and pay the

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-19 Thread Jonathan Cameron
type is created for storing all memory types that are > not initialized by device drivers and as a fallback. > > Signed-off-by: Ho-Ren (Jack) Chuang > Signed-off-by: Hao Xiang > Reviewed-by: "Huang, Ying" Reviewed-by: Jonathan Cameron

Re: [PATCH] dt-bindings: iio: imu: mpu6050: Improve i2c-gate disallow list

2024-04-13 Thread Jonathan Cameron
On Tue, 9 Apr 2024 08:36:08 +0200 Krzysztof Kozlowski wrote: > On 08/04/2024 18:34, Luca Weiss wrote: > > Before all supported sensors except for MPU{9150,9250,9255} were not > > allowed to use i2c-gate in the bindings which excluded quite a few > > supported sensors where this functionality is s

Re: [External] Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-10 Thread Jonathan Cameron
On Tue, 9 Apr 2024 12:02:31 -0700 "Ho-Ren (Jack) Chuang" wrote: > Hi Jonathan, > > On Tue, Apr 9, 2024 at 9:12 AM Jonathan Cameron > wrote: > > > > On Fri, 5 Apr 2024 15:43:47 -0700 > > "Ho-Ren (Jack) Chuang" wrote: > > > >

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-09 Thread Jonathan Cameron
On Fri, 5 Apr 2024 15:43:47 -0700 "Ho-Ren (Jack) Chuang" wrote: > On Fri, Apr 5, 2024 at 7:03 AM Jonathan Cameron > wrote: > > > > On Fri, 5 Apr 2024 00:07:06 + > > "Ho-Ren (Jack) Chuang" wrote: > > > > > The current implemen

Re: [PATCH] Documentation: ABI: document in_temp_input file

2024-04-06 Thread Jonathan Cameron
On Sat, 06 Apr 2024 17:31:04 +0200 Luca Weiss wrote: > For example the BMP280 barometric pressure sensor on Qualcomm > MSM8974-based Nexus 5 smartphone exposes such file in sysfs. > Document it. > > Signed-off-by: Luca Weiss Hi Luca, Applied with a note added on fixing the line above to not r

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-05 Thread Jonathan Cameron
On Fri, 5 Apr 2024 00:07:06 + "Ho-Ren (Jack) Chuang" wrote: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics t

Re: [PATCH v11 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-04-05 Thread Jonathan Cameron
gned-off-by: Ho-Ren (Jack) Chuang > Reviewed-by: "Huang, Ying" Reviewed-by: Jonathan Cameron

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-04 Thread Jonathan Cameron
> > > @@ -858,7 +910,8 @@ static int __init memory_tier_init(void) > > >* For now we can have 4 faster memory tiers with smaller adistance > > >* than default DRAM tier. > > >*/ > > > - default_dram_type = alloc_memory_type(MEMTIER_ADISTANCE_DRAM); > > > + default_

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-03 Thread Jonathan Cameron
A few minor comments inline. > diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h > index a44c03c2ba3a..16769552a338 100644 > --- a/include/linux/memory-tiers.h > +++ b/include/linux/memory-tiers.h > @@ -140,12 +140,13 @@ static inline int mt_perf_to_adistance(struct > acces

Re: [PATCH v10 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-04-03 Thread Jonathan Cameron
On Tue, 2 Apr 2024 00:17:37 + "Ho-Ren (Jack) Chuang" wrote: > Since different memory devices require finding, allocating, and putting > memory types, these common steps are abstracted in this patch, > enhancing the scalability and conciseness of the code. > > Signed-off-by: Ho-Ren (Jack) Ch

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-15 Thread Jonathan Cameron
On Wed, 14 Feb 2024 17:33:18 -0500 Steven Rostedt wrote: > On Wed, 14 Feb 2024 14:19:19 -0800 > Ira Weiny wrote: > > > > > Jonathan Cameron wrote: > > > > > > > > > So I'm thinking this is a won't fix - wait for the printk r

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-14 Thread Jonathan Cameron
On Wed, 14 Feb 2024 10:23:10 -0500 Steven Rostedt wrote: > On Wed, 14 Feb 2024 12:11:53 + > Jonathan Cameron wrote: > > > So I'm thinking this is a won't fix - wait for the printk rework to land and > > assume this will be resolved as well? > > That

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-14 Thread Jonathan Cameron
On Tue, 06 Feb 2024 14:15:32 -0800 Ira Weiny wrote: > Smatch caught that cxl_cper_post_event() is called with a spinlock held > or preemption disabled.[1] The callback takes the device lock to > perform address translation and therefore might sleep. The record data > is released back to BIOS in

Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-19 Thread Jonathan Cameron
x/bus.c benefit from a cleanup using these, so change these > where applicable. > > Cc: Joao Martins > Cc: Dan Williams > Signed-off-by: Vishal Verma Hi Vishal, A few really minor suggestions inline if you happen to be doing a v7. Either way Reviewed-by: Jonathan Cameron

Re: [PATCH v4 1/3] Documentatiion/ABI: Add ABI documentation for sys-bus-dax

2023-12-13 Thread Jonathan Cameron
On Tue, 12 Dec 2023 12:08:30 -0700 Vishal Verma wrote: > Add the missing sysfs ABI documentation for the device DAX subsystem. > Various ABI attributes under this have been present since v5.1, and more > have been added over time. In preparation for adding a new attribute, > add this file with th

Re: [PATCH v4 2/3] dax/bus: Introduce guard(device) for device_{lock,unlock} flows

2023-12-13 Thread Jonathan Cameron
On Tue, 12 Dec 2023 12:08:31 -0700 Vishal Verma wrote: > Introduce a guard(device) macro to lock a 'struct device', and unlock it > automatically when going out of scope using Scope Based Resource > Management semantics. A lot of the sysfs attribute writes in > drivers/dax/bus.c benefit from a cl

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-25 Thread Jonathan Cameron
On Fri, 24 Nov 2023 10:21:21 +0100 Krzysztof Kozlowski wrote: > Use only one and exactly one space around '=' in DTS example. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Jonathan Cameron #for-iio > --- > > Merging idea: Rob's DT. >

Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings

2023-10-14 Thread Jonathan Cameron
On Fri, 13 Oct 2023 10:09:53 +0200 Luca Weiss wrote: > Add the defines for the ADC channels found on the PM7325. The list is > taken from downstream msm-5.4 and adjusted for mainline. > > Signed-off-by: Luca Weiss I assume this will go with the dts changes that use it. Acked-

Re: [PATCH RESEND 2/4] acpi, hmat: refactor hmat_register_target_initiators()

2023-08-07 Thread Jonathan Cameron
formance attributes separately. > > Signed-off-by: "Huang, Ying" > Cc: Aneesh Kumar K.V > Cc: Wei Xu > Cc: Alistair Popple > Cc: Dan Williams > Cc: Dave Hansen > Cc: Davidlohr Bueso > Cc: Johannes Weiner > Cc: Jonathan Cameron > Cc: Michal Hocko >

Re: [PATCH v3 2/2] dax/kmem: allow kmem to add memory with memmap_on_memory

2023-08-02 Thread Jonathan Cameron
-by: Vishal Verma Hi Vishal, In general looks fine to me. Just a question for potential discussion if didn't miss it in earlier versions. FWIW Reviewed-by: Jonathan Cameron Also, any docs need updating? Doesn't seem like the DAX ABI docs are present in Documentation/ABI so not sur

Re: [PATCH v3 1/2] mm/memory_hotplug: split memmap_on_memory requests across memblocks

2023-08-02 Thread Jonathan Cameron
On Tue, 01 Aug 2023 23:55:37 -0600 Vishal Verma wrote: > The MHP_MEMMAP_ON_MEMORY flag for hotplugged memory is restricted to > 'memblock_size' chunks of memory being added. Adding a larger span of > memory precludes memmap_on_memory semantics. > > For users of hotplug such as kmem, large amount

Re: [PATCH 1/3] mm/memory_hotplug: Allow an override for the memmap_on_memory param

2023-06-22 Thread Jonathan Cameron
On Fri, 16 Jun 2023 09:46:59 +0200 David Hildenbrand wrote: > On 16.06.23 00:00, Vishal Verma wrote: > > For memory hotplug to consider MHP_MEMMAP_ON_MEMORY behavior, the > > 'memmap_on_memory' module parameter was a hard requirement. > > > > In preparation for the dax/kmem driver to use memmap_

[PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Jonathan Cameron
On Mon, 19 Apr 2021 20:45:08 +0100 Jonathan Cameron wrote: > On Mon, 19 Apr 2021 16:34:35 +0300 > Tomas Melin wrote: > > > Hi, > > > > On 4/18/21 1:03 PM, Jonathan Cameron wrote: > > > On Fri, 16 Apr 2021 15:21:14 +0300 > > > Tomas Melin wrot

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Jonathan Cameron
On Mon, 19 Apr 2021 16:34:35 +0300 Tomas Melin wrote: > Hi, > > On 4/18/21 1:03 PM, Jonathan Cameron wrote: > > On Fri, 16 Apr 2021 15:21:14 +0300 > > Tomas Melin wrote: > > > >> Updated email-address for Alexandru. > >> > >> > >&g

Re: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support

2021-04-18 Thread Jonathan Cameron
On Sun, 18 Apr 2021 16:59:02 +0300 Andy Shevchenko wrote: > On Sun, Apr 18, 2021 at 4:49 PM Andy Shevchenko > wrote: > > > > On Sun, Apr 18, 2021 at 2:07 PM Jonathan Cameron wrote: > > > > Thanks for review, my answers below. > > > > > On Wed, 14

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
On Fri, 16 Apr 2021 16:45:46 +0300 Tomas Melin wrote: > Add initial support for Murata SCA3300 3-axis industrial > accelerometer with digital SPI interface. This device also > provides a temperature measurement. > > Device product page including datasheet can be found at: > https://www.murata.co

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
On Sat, 17 Apr 2021 15:39:12 +0300 Andy Shevchenko wrote: > On Fri, Apr 16, 2021 at 5:21 PM Tomas Melin wrote: > > > > Add initial support for Murata SCA3300 3-axis industrial > > accelerometer with digital SPI interface. This device also > > provides a temperature measurement. > > > > Device pr

Re: [PATCH 1/2] HID: hid-sensor-hub: Return error for hid_set_field() failure

2021-04-18 Thread Jonathan Cameron
On Thu, 15 Apr 2021 11:52:31 -0700 Srinivas Pandruvada wrote: > In the function sensor_hub_set_feature(), return error when hid_set_field() > fails. > > Signed-off-by: Srinivas Pandruvada Series applied to the to greg branch of iio.git. Note these won't make the coming merge window, so will tu

Re: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support

2021-04-18 Thread Jonathan Cameron
On Wed, 14 Apr 2021 22:54:53 +0300 Andy Shevchenko wrote: > We can utilize separate drivers for accelerometer and magnetometer, > so here is the glue driver to enable LSM9DS0 IMU support. > > The idea was suggested by Crestez Dan Leonard in [1]. The proposed change > was sent as RFC due to race

Re: [PATCH v1 4/7] iio: st_sensors: Call st_sensors_power_enable() from bus drivers

2021-04-18 Thread Jonathan Cameron
On Wed, 14 Apr 2021 22:54:51 +0300 Andy Shevchenko wrote: > In case we would initialize two IIO devices from one physical device, > we shouldn't have a clash on regulators. That's why move > st_sensors_power_enable() call from core to bus drivers. Why is this a problem? The two instances would

Re: [PATCH] iio: hid-sensors: select IIO_TRIGGERED_BUFFER under HID_SENSOR_IIO_TRIGGER

2021-04-18 Thread Jonathan Cameron
On Thu, 15 Apr 2021 09:58:33 -0700 Srinivas Pandruvada wrote: > On Wed, 2021-04-14 at 11:49 +0300, Alexandru Ardelean wrote: > > During commit 067fda1c065ff ("iio: hid-sensors: move triggered buffer > > setup into hid_sensor_setup_trigger"), the > > iio_triggered_buffer_{setup,cleanup}() function

Re: [PATCH v2 1/1] iio: adc: ad7298: Enable on Intel Galileo Gen 1

2021-04-18 Thread Jonathan Cameron
On Mon, 12 Apr 2021 16:18:35 +0300 Andy Shevchenko wrote: > Enable ADC on Intel Galileo Gen 1 board. > > Signed-off-by: Andy Shevchenko Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to hopefully not notice we did anything ;) Jonathan > --- > v2: fixed

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
On Fri, 16 Apr 2021 15:21:14 +0300 Tomas Melin wrote: > Updated email-address for Alexandru. > > > On 4/16/21 3:17 PM, Tomas Melin wrote: > > On 4/15/21 11:41 AM, Tomas Melin wrote: > > > >> > >> While working on updates I did notice something new which I cannot > >> > >> reproduce on older (

Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

2021-04-18 Thread Jonathan Cameron
On Sun, 11 Apr 2021 21:08:29 +0300 Andy Shevchenko wrote: > On Sun, Apr 11, 2021 at 9:07 PM Andy Shevchenko > wrote: > > On Sun, Apr 11, 2021 at 5:53 PM Jonathan Cameron wrote: > > > On Wed, 7 Apr 2021 23:51:47 +0530 > > > Puranjay Mohan wrote: > >

Re: [PATCH] [v2] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error

2021-04-18 Thread Jonathan Cameron
On Mon, 12 Apr 2021 12:23:43 +0300 Andy Shevchenko wrote: > On Mon, Apr 12, 2021 at 8:32 AM Dinghao Liu wrote: > > > > When lidar_write_control() fails, a pairing PM usage counter > > decrement is needed to keep the counter balanced. > > You forgot to collect given tags. > > > Fixes: 4ac4e08

Re: [PATCH] iio: light: gp2ap002: Fix rumtime PM imbalance on error

2021-04-18 Thread Jonathan Cameron
On Mon, 12 Apr 2021 13:47:58 +0200 Linus Walleij wrote: > On Mon, Apr 12, 2021 at 12:16 PM Jonathan Cameron > wrote: > > > An example would be the bmc150_magn driver which does exactly the > > same call sequence as this one, but without the reference count increm

Re: [PATCH v8 1/2] Added AMS tsl2591 driver implementation

2021-04-18 Thread Jonathan Cameron
On Fri, 16 Apr 2021 18:49:01 +0100 Joe Sandom wrote: > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > This driver supports configuration via device tree and sysfs. > Supported channels for raw infrared light intensity, > raw combined light intensity and illuminance in lux.

Re: [PATCH 21/57] staging: iio: frequency: ad9834: Provide missing description for 'devid'

2021-04-16 Thread Jonathan Cameron
omment. Refer > Documentation/doc-guide/kernel-doc.rst > > Cc: Lars-Peter Clausen > Cc: Michael Hennerich > Cc: Jonathan Cameron > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: linux-stag...@lists.linux.dev > Signed-off-by: Lee Jones I was leaving the sta

Re: [”PATCH” 2/5] PCI: armada8k: Add link-down handle

2021-04-14 Thread Jonathan Cameron
On Mon, 12 Apr 2021 18:30:53 +0300 wrote: > From: Ben Peled > > In PCIE ISR routine caused by RST_LINK_DOWN > we schedule work to handle the link-down procedure. > Link-down procedure will: > 1. Remove PCIe bus > 2. Reset the MAC > 3. Reconfigure link back up > 4. Rescan PCIe bus > > Signed-of

Re: [PATCH] cxl/mem: Add media provisioning required commands

2021-04-14 Thread Jonathan Cameron
> Signed-off-by: Ben Widawsky Checked all the numbers (not much else in this one ;) Reviewed-by: Jonathan Cameron You could give more info on why this particular list, but to my mind it's all fairly obvious so perhaps not worth bothering. > --- > drivers/cxl/mem.c|

Re: [PATCH] cxl/mem: Clarify UAPI documentation

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 07:32:47 -0700 Ben Widawsky wrote: > Signed-off-by: Ben Widawsky Sensible update. Acked-by: Jonathan Cameron > --- > include/uapi/linux/cxl_mem.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/uapi/linux/cxl_mem.h b/include/ua

Re: [PATCH 4/7] cxl/mem: Get rid of @cxlm.base

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 09:17:26 -0700 Ben Widawsky wrote: > On 21-04-08 18:26:35, Jonathan Cameron wrote: > > On Wed, 7 Apr 2021 15:26:22 -0700 > > Ben Widawsky wrote: > > > > > @cxlm.base only existed to support holding the base found in the > > > registe

Re: [PATCH v2 1/8] cxl/mem: Move some definitions to mem.h

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 17:42:37 -0700 Dan Williams wrote: > On Tue, Apr 13, 2021 at 5:18 PM Dan Williams wrote: > > > > On Tue, Apr 6, 2021 at 10:47 AM Jonathan Cameron > > wrote: > > > > > > On Thu, 1 Apr 2021 07:30:47 -0700 > > > Dan Williams w

Re: [RFC PATCH v1 00/11] Manage the top tier memory in a tiered memory

2021-04-14 Thread Jonathan Cameron
On Mon, 12 Apr 2021 12:20:22 -0700 Shakeel Butt wrote: > On Fri, Apr 9, 2021 at 4:26 PM Tim Chen wrote: > > > > > > On 4/8/21 4:52 AM, Michal Hocko wrote: > > > > >> The top tier memory used is reported in > > >> > > >> memory.toptier_usage_in_bytes > > >> > > >> The amount of top tier memory

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-12 Thread Jonathan Cameron
On Mon, 12 Apr 2021 10:50:56 +0300 Tomas Melin wrote: > Add initial support for Murata SCA3300 3-axis industrial > accelerometer with digital SPI interface. This device also > provides a temperature measurement. > > Device product page including datasheet can be found at: > https://www.murata.co

Re: [PATCH 1/2] dt-bindings: iio: accel: Add SCA3300 documentation

2021-04-12 Thread Jonathan Cameron
On Mon, 12 Apr 2021 10:50:55 +0300 Tomas Melin wrote: > initial DT bindings for Murata SCA3300 Accelerometer. > > Signed-off-by: Tomas Melin Hi Tomas. > --- > .../bindings/iio/accel/sca3300.yaml | 51 +++ > 1 file changed, 51 insertions(+) > create mode 100644 Docume

  1   2   3   4   5   6   7   8   9   10   >