Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Tue, 23 Apr 2024 18:33:05 -0400 Aren Moynihan wrote: > From: Ondrej Jirman > > VDD power input can be used to completely power off the chip during > system suspend. Do so if available. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Aren Moynihan Suggestions inline. Key thing is take

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Wed, 24 Apr 2024 18:20:41 +0300 Andy Shevchenko wrote: > On Wed, Apr 24, 2024 at 3:59 PM Ondřej Jirman wrote: > > On Wed, Apr 24, 2024 at 02:16:06AM GMT, Andy Shevchenko wrote: > > > On Wed, Apr 24, 2024 at 1:41 AM Aren Moynihan > > > wrote: > > ... > > > > > ret =

Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-28 Thread Jonathan Cameron
On Wed, 24 Apr 2024 02:16:06 +0300 Andy Shevchenko wrote: > On Wed, Apr 24, 2024 at 1:41 AM Aren Moynihan wrote: > > > > From: Ondrej Jirman > > > > VDD power input can be used to completely power off the chip during > > system suspend. Do so if available. > > ... > > > ret =

Re: [PATCH 3/4] iio: light: stk3310: log error if reading the chip id fails

2024-04-20 Thread Jonathan Cameron
On Mon, 15 Apr 2024 18:05:54 +0300 Andy Shevchenko wrote: > On Sun, Apr 14, 2024 at 8:57 PM Aren Moynihan wrote: > > > > If the chip isn't powered, this call is likely to return an error. > > Without a log here the driver will silently fail to probe. Common errors > > are ENXIO (when the chip

Re: [PATCH 1/4] dt-bindings: iio: light: stk33xx: add regulator for vdd supply

2024-04-20 Thread Jonathan Cameron
On Sun, 14 Apr 2024 13:57:13 -0400 Aren Moynihan wrote: > Signed-off-by: Aren Moynihan > --- > Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml >

Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend

2024-04-20 Thread Jonathan Cameron
On Sun, 14 Apr 2024 13:57:14 -0400 Aren Moynihan wrote: > From: Ondrej Jirman > > VDD power input can be used to completely power off the chip during > system suspend. Do so if available. I'd make this non optional (relying on regulator framework providing us a stub for old DT etc) and pay the

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-19 Thread Jonathan Cameron
ry type is created for storing all memory types that are > not initialized by device drivers and as a fallback. > > Signed-off-by: Ho-Ren (Jack) Chuang > Signed-off-by: Hao Xiang > Reviewed-by: "Huang, Ying" Reviewed-by: Jonathan Cameron

Re: [PATCH] dt-bindings: iio: imu: mpu6050: Improve i2c-gate disallow list

2024-04-13 Thread Jonathan Cameron
On Tue, 9 Apr 2024 08:36:08 +0200 Krzysztof Kozlowski wrote: > On 08/04/2024 18:34, Luca Weiss wrote: > > Before all supported sensors except for MPU{9150,9250,9255} were not > > allowed to use i2c-gate in the bindings which excluded quite a few > > supported sensors where this functionality is

Re: [External] Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-10 Thread Jonathan Cameron
On Tue, 9 Apr 2024 12:02:31 -0700 "Ho-Ren (Jack) Chuang" wrote: > Hi Jonathan, > > On Tue, Apr 9, 2024 at 9:12 AM Jonathan Cameron > wrote: > > > > On Fri, 5 Apr 2024 15:43:47 -0700 > > "Ho-Ren (Jack) Chuang" wrote: > > > >

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-09 Thread Jonathan Cameron
On Fri, 5 Apr 2024 15:43:47 -0700 "Ho-Ren (Jack) Chuang" wrote: > On Fri, Apr 5, 2024 at 7:03 AM Jonathan Cameron > wrote: > > > > On Fri, 5 Apr 2024 00:07:06 + > > "Ho-Ren (Jack) Chuang" wrote: > > > > > The current implemen

Re: [PATCH] Documentation: ABI: document in_temp_input file

2024-04-06 Thread Jonathan Cameron
On Sat, 06 Apr 2024 17:31:04 +0200 Luca Weiss wrote: > For example the BMP280 barometric pressure sensor on Qualcomm > MSM8974-based Nexus 5 smartphone exposes such file in sysfs. > Document it. > > Signed-off-by: Luca Weiss Hi Luca, Applied with a note added on fixing the line above to not

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-05 Thread Jonathan Cameron
On Fri, 5 Apr 2024 00:07:06 + "Ho-Ren (Jack) Chuang" wrote: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics

Re: [PATCH v11 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-04-05 Thread Jonathan Cameron
gned-off-by: Ho-Ren (Jack) Chuang > Reviewed-by: "Huang, Ying" Reviewed-by: Jonathan Cameron

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-04 Thread Jonathan Cameron
> > > @@ -858,7 +910,8 @@ static int __init memory_tier_init(void) > > >* For now we can have 4 faster memory tiers with smaller adistance > > >* than default DRAM tier. > > >*/ > > > - default_dram_type = alloc_memory_type(MEMTIER_ADISTANCE_DRAM); > > > +

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-03 Thread Jonathan Cameron
A few minor comments inline. > diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h > index a44c03c2ba3a..16769552a338 100644 > --- a/include/linux/memory-tiers.h > +++ b/include/linux/memory-tiers.h > @@ -140,12 +140,13 @@ static inline int mt_perf_to_adistance(struct >

Re: [PATCH v10 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-04-03 Thread Jonathan Cameron
On Tue, 2 Apr 2024 00:17:37 + "Ho-Ren (Jack) Chuang" wrote: > Since different memory devices require finding, allocating, and putting > memory types, these common steps are abstracted in this patch, > enhancing the scalability and conciseness of the code. > > Signed-off-by: Ho-Ren (Jack)

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-15 Thread Jonathan Cameron
On Wed, 14 Feb 2024 17:33:18 -0500 Steven Rostedt wrote: > On Wed, 14 Feb 2024 14:19:19 -0800 > Ira Weiny wrote: > > > > > Jonathan Cameron wrote: > > > > > > > > > So I'm thinking this is a won't fix - wait for the print

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-14 Thread Jonathan Cameron
On Wed, 14 Feb 2024 10:23:10 -0500 Steven Rostedt wrote: > On Wed, 14 Feb 2024 12:11:53 + > Jonathan Cameron wrote: > > > So I'm thinking this is a won't fix - wait for the printk rework to land and > > assume this will be resolved as well? > > That pretty mu

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-14 Thread Jonathan Cameron
On Tue, 06 Feb 2024 14:15:32 -0800 Ira Weiny wrote: > Smatch caught that cxl_cper_post_event() is called with a spinlock held > or preemption disabled.[1] The callback takes the device lock to > perform address translation and therefore might sleep. The record data > is released back to BIOS

Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-19 Thread Jonathan Cameron
benefit from a cleanup using these, so change these > where applicable. > > Cc: Joao Martins > Cc: Dan Williams > Signed-off-by: Vishal Verma Hi Vishal, A few really minor suggestions inline if you happen to be doing a v7. Either way Reviewed-by: Jonathan Cameron > >

Re: [PATCH v4 1/3] Documentatiion/ABI: Add ABI documentation for sys-bus-dax

2023-12-13 Thread Jonathan Cameron
On Tue, 12 Dec 2023 12:08:30 -0700 Vishal Verma wrote: > Add the missing sysfs ABI documentation for the device DAX subsystem. > Various ABI attributes under this have been present since v5.1, and more > have been added over time. In preparation for adding a new attribute, > add this file with

Re: [PATCH v4 2/3] dax/bus: Introduce guard(device) for device_{lock,unlock} flows

2023-12-13 Thread Jonathan Cameron
On Tue, 12 Dec 2023 12:08:31 -0700 Vishal Verma wrote: > Introduce a guard(device) macro to lock a 'struct device', and unlock it > automatically when going out of scope using Scope Based Resource > Management semantics. A lot of the sysfs attribute writes in > drivers/dax/bus.c benefit from a

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-25 Thread Jonathan Cameron
On Fri, 24 Nov 2023 10:21:21 +0100 Krzysztof Kozlowski wrote: > Use only one and exactly one space around '=' in DTS example. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Jonathan Cameron #for-iio > --- > > Merging idea: Rob's DT. > Should apply c

Re: [PATCH 1/4] iio: adc: Add PM7325 PMIC7 ADC bindings

2023-10-14 Thread Jonathan Cameron
On Fri, 13 Oct 2023 10:09:53 +0200 Luca Weiss wrote: > Add the defines for the ADC channels found on the PM7325. The list is > taken from downstream msm-5.4 and adjusted for mainline. > > Signed-off-by: Luca Weiss I assume this will go with the dts changes that use it. Acked-

Re: [PATCH RESEND 2/4] acpi, hmat: refactor hmat_register_target_initiators()

2023-08-07 Thread Jonathan Cameron
formance attributes separately. > > Signed-off-by: "Huang, Ying" > Cc: Aneesh Kumar K.V > Cc: Wei Xu > Cc: Alistair Popple > Cc: Dan Williams > Cc: Dave Hansen > Cc: Davidlohr Bueso > Cc: Johannes Weiner > Cc: Jonathan Cameron > Cc: Michal Hocko >

Re: [PATCH v3 2/2] dax/kmem: allow kmem to add memory with memmap_on_memory

2023-08-02 Thread Jonathan Cameron
-by: Vishal Verma Hi Vishal, In general looks fine to me. Just a question for potential discussion if didn't miss it in earlier versions. FWIW Reviewed-by: Jonathan Cameron Also, any docs need updating? Doesn't seem like the DAX ABI docs are present in Documentation/ABI so not sure where it

Re: [PATCH v3 1/2] mm/memory_hotplug: split memmap_on_memory requests across memblocks

2023-08-02 Thread Jonathan Cameron
On Tue, 01 Aug 2023 23:55:37 -0600 Vishal Verma wrote: > The MHP_MEMMAP_ON_MEMORY flag for hotplugged memory is restricted to > 'memblock_size' chunks of memory being added. Adding a larger span of > memory precludes memmap_on_memory semantics. > > For users of hotplug such as kmem, large

Re: [PATCH 1/3] mm/memory_hotplug: Allow an override for the memmap_on_memory param

2023-06-22 Thread Jonathan Cameron
On Fri, 16 Jun 2023 09:46:59 +0200 David Hildenbrand wrote: > On 16.06.23 00:00, Vishal Verma wrote: > > For memory hotplug to consider MHP_MEMMAP_ON_MEMORY behavior, the > > 'memmap_on_memory' module parameter was a hard requirement. > > > > In preparation for the dax/kmem driver to use

[PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Jonathan Cameron
On Mon, 19 Apr 2021 20:45:08 +0100 Jonathan Cameron wrote: > On Mon, 19 Apr 2021 16:34:35 +0300 > Tomas Melin wrote: > > > Hi, > > > > On 4/18/21 1:03 PM, Jonathan Cameron wrote: > > > On Fri, 16 Apr 2021 15:21:14 +0300 > > > Tomas Melin

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Jonathan Cameron
On Mon, 19 Apr 2021 16:34:35 +0300 Tomas Melin wrote: > Hi, > > On 4/18/21 1:03 PM, Jonathan Cameron wrote: > > On Fri, 16 Apr 2021 15:21:14 +0300 > > Tomas Melin wrote: > > > >> Updated email-address for Alexandru. > >> > >> > >&g

Re: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support

2021-04-18 Thread Jonathan Cameron
On Sun, 18 Apr 2021 16:59:02 +0300 Andy Shevchenko wrote: > On Sun, Apr 18, 2021 at 4:49 PM Andy Shevchenko > wrote: > > > > On Sun, Apr 18, 2021 at 2:07 PM Jonathan Cameron wrote: > > > > Thanks for review, my answers below. > > > > > On Wed, 14

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
On Fri, 16 Apr 2021 16:45:46 +0300 Tomas Melin wrote: > Add initial support for Murata SCA3300 3-axis industrial > accelerometer with digital SPI interface. This device also > provides a temperature measurement. > > Device product page including datasheet can be found at: >

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
On Sat, 17 Apr 2021 15:39:12 +0300 Andy Shevchenko wrote: > On Fri, Apr 16, 2021 at 5:21 PM Tomas Melin wrote: > > > > Add initial support for Murata SCA3300 3-axis industrial > > accelerometer with digital SPI interface. This device also > > provides a temperature measurement. > > > > Device

Re: [PATCH 1/2] HID: hid-sensor-hub: Return error for hid_set_field() failure

2021-04-18 Thread Jonathan Cameron
On Thu, 15 Apr 2021 11:52:31 -0700 Srinivas Pandruvada wrote: > In the function sensor_hub_set_feature(), return error when hid_set_field() > fails. > > Signed-off-by: Srinivas Pandruvada Series applied to the to greg branch of iio.git. Note these won't make the coming merge window, so will

Re: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support

2021-04-18 Thread Jonathan Cameron
On Wed, 14 Apr 2021 22:54:53 +0300 Andy Shevchenko wrote: > We can utilize separate drivers for accelerometer and magnetometer, > so here is the glue driver to enable LSM9DS0 IMU support. > > The idea was suggested by Crestez Dan Leonard in [1]. The proposed change > was sent as RFC due to race

Re: [PATCH v1 4/7] iio: st_sensors: Call st_sensors_power_enable() from bus drivers

2021-04-18 Thread Jonathan Cameron
On Wed, 14 Apr 2021 22:54:51 +0300 Andy Shevchenko wrote: > In case we would initialize two IIO devices from one physical device, > we shouldn't have a clash on regulators. That's why move > st_sensors_power_enable() call from core to bus drivers. Why is this a problem? The two instances would

Re: [PATCH] iio: hid-sensors: select IIO_TRIGGERED_BUFFER under HID_SENSOR_IIO_TRIGGER

2021-04-18 Thread Jonathan Cameron
On Thu, 15 Apr 2021 09:58:33 -0700 Srinivas Pandruvada wrote: > On Wed, 2021-04-14 at 11:49 +0300, Alexandru Ardelean wrote: > > During commit 067fda1c065ff ("iio: hid-sensors: move triggered buffer > > setup into hid_sensor_setup_trigger"), the > > iio_triggered_buffer_{setup,cleanup}()

Re: [PATCH v2 1/1] iio: adc: ad7298: Enable on Intel Galileo Gen 1

2021-04-18 Thread Jonathan Cameron
On Mon, 12 Apr 2021 16:18:35 +0300 Andy Shevchenko wrote: > Enable ADC on Intel Galileo Gen 1 board. > > Signed-off-by: Andy Shevchenko Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to hopefully not notice we did anything ;) Jonathan > --- > v2: fixed

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-18 Thread Jonathan Cameron
On Fri, 16 Apr 2021 15:21:14 +0300 Tomas Melin wrote: > Updated email-address for Alexandru. > > > On 4/16/21 3:17 PM, Tomas Melin wrote: > > On 4/15/21 11:41 AM, Tomas Melin wrote: > > > >> > >> While working on updates I did notice something new which I cannot > >> > >> reproduce on older

Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

2021-04-18 Thread Jonathan Cameron
On Sun, 11 Apr 2021 21:08:29 +0300 Andy Shevchenko wrote: > On Sun, Apr 11, 2021 at 9:07 PM Andy Shevchenko > wrote: > > On Sun, Apr 11, 2021 at 5:53 PM Jonathan Cameron wrote: > > > On Wed, 7 Apr 2021 23:51:47 +0530 > > > Puranjay Mohan wrote: > >

Re: [PATCH] [v2] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error

2021-04-18 Thread Jonathan Cameron
On Mon, 12 Apr 2021 12:23:43 +0300 Andy Shevchenko wrote: > On Mon, Apr 12, 2021 at 8:32 AM Dinghao Liu wrote: > > > > When lidar_write_control() fails, a pairing PM usage counter > > decrement is needed to keep the counter balanced. > > You forgot to collect given tags. > > > Fixes:

Re: [PATCH] iio: light: gp2ap002: Fix rumtime PM imbalance on error

2021-04-18 Thread Jonathan Cameron
On Mon, 12 Apr 2021 13:47:58 +0200 Linus Walleij wrote: > On Mon, Apr 12, 2021 at 12:16 PM Jonathan Cameron > wrote: > > > An example would be the bmc150_magn driver which does exactly the > > same call sequence as this one, but without the reference count increm

Re: [PATCH v8 1/2] Added AMS tsl2591 driver implementation

2021-04-18 Thread Jonathan Cameron
On Fri, 16 Apr 2021 18:49:01 +0100 Joe Sandom wrote: > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > This driver supports configuration via device tree and sysfs. > Supported channels for raw infrared light intensity, > raw combined light intensity and illuminance in lux.

Re: [PATCH 21/57] staging: iio: frequency: ad9834: Provide missing description for 'devid'

2021-04-16 Thread Jonathan Cameron
ernel-doc.rst > > Cc: Lars-Peter Clausen > Cc: Michael Hennerich > Cc: Jonathan Cameron > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: linux-stag...@lists.linux.dev > Signed-off-by: Lee Jones I was leaving the staging stuff in IIO related to W=1 as good mate

Re: [”PATCH” 2/5] PCI: armada8k: Add link-down handle

2021-04-14 Thread Jonathan Cameron
On Mon, 12 Apr 2021 18:30:53 +0300 wrote: > From: Ben Peled > > In PCIE ISR routine caused by RST_LINK_DOWN > we schedule work to handle the link-down procedure. > Link-down procedure will: > 1. Remove PCIe bus > 2. Reset the MAC > 3. Reconfigure link back up > 4. Rescan PCIe bus > >

Re: [PATCH] cxl/mem: Add media provisioning required commands

2021-04-14 Thread Jonathan Cameron
> Signed-off-by: Ben Widawsky Checked all the numbers (not much else in this one ;) Reviewed-by: Jonathan Cameron You could give more info on why this particular list, but to my mind it's all fairly obvious so perhaps not worth bothering. > --- > drivers/cxl/mem.c| 19 ++

Re: [PATCH] cxl/mem: Clarify UAPI documentation

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 07:32:47 -0700 Ben Widawsky wrote: > Signed-off-by: Ben Widawsky Sensible update. Acked-by: Jonathan Cameron > --- > include/uapi/linux/cxl_mem.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/uapi/linux/cxl_mem.h b/include/ua

Re: [PATCH 4/7] cxl/mem: Get rid of @cxlm.base

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 09:17:26 -0700 Ben Widawsky wrote: > On 21-04-08 18:26:35, Jonathan Cameron wrote: > > On Wed, 7 Apr 2021 15:26:22 -0700 > > Ben Widawsky wrote: > > > > > @cxlm.base only existed to support holding the base found in the > > > registe

Re: [PATCH v2 1/8] cxl/mem: Move some definitions to mem.h

2021-04-14 Thread Jonathan Cameron
On Tue, 13 Apr 2021 17:42:37 -0700 Dan Williams wrote: > On Tue, Apr 13, 2021 at 5:18 PM Dan Williams wrote: > > > > On Tue, Apr 6, 2021 at 10:47 AM Jonathan Cameron > > wrote: > > > > > > On Thu, 1 Apr 2021 07:30:47 -0700 > > > Dan Williams w

Re: [RFC PATCH v1 00/11] Manage the top tier memory in a tiered memory

2021-04-14 Thread Jonathan Cameron
On Mon, 12 Apr 2021 12:20:22 -0700 Shakeel Butt wrote: > On Fri, Apr 9, 2021 at 4:26 PM Tim Chen wrote: > > > > > > On 4/8/21 4:52 AM, Michal Hocko wrote: > > > > >> The top tier memory used is reported in > > >> > > >> memory.toptier_usage_in_bytes > > >> > > >> The amount of top tier memory

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-12 Thread Jonathan Cameron
On Mon, 12 Apr 2021 10:50:56 +0300 Tomas Melin wrote: > Add initial support for Murata SCA3300 3-axis industrial > accelerometer with digital SPI interface. This device also > provides a temperature measurement. > > Device product page including datasheet can be found at: >

Re: [PATCH 1/2] dt-bindings: iio: accel: Add SCA3300 documentation

2021-04-12 Thread Jonathan Cameron
On Mon, 12 Apr 2021 10:50:55 +0300 Tomas Melin wrote: > initial DT bindings for Murata SCA3300 Accelerometer. > > Signed-off-by: Tomas Melin Hi Tomas. > --- > .../bindings/iio/accel/sca3300.yaml | 51 +++ > 1 file changed, 51 insertions(+) > create mode 100644

Re: [PATCH] HID: hid-sensor-custom: remove useless variable

2021-04-12 Thread Jonathan Cameron
On Sun, 11 Apr 2021 09:06:35 -0700 Srinivas Pandruvada wrote: > On Sun, 2021-04-11 at 14:56 +0100, Jonathan Cameron wrote: > > On Fri, 09 Apr 2021 11:19:12 -0700 > > Srinivas Pandruvada wrote: > > > > > On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote:

Re: [PATCH] iio: light: gp2ap002: Fix rumtime PM imbalance on error

2021-04-12 Thread Jonathan Cameron
On Mon, 12 Apr 2021 00:38:41 +0200 Linus Walleij wrote: > On Sun, Apr 11, 2021 at 5:07 PM Jonathan Cameron wrote: > > On Wed, 7 Apr 2021 11:49:27 +0800 > > Dinghao Liu wrote: > > > > > When devm_request_threaded_irq() fails, we should decrease the &g

Re: [PATCH v10 1/3] PCI: portdrv: Add pcie_port_service_get_irq() function

2021-04-12 Thread Jonathan Cameron
On Sat, 10 Apr 2021 01:22:16 +0900 Kunihiko Hayashi wrote: > Add pcie_port_service_get_irq() that returns the virtual IRQ number > for specified portdrv service. Trivial comment inline. > > Cc: Lorenzo Pieralisi > Signed-off-by: Kunihiko Hayashi > Reviewed-by: Rob Herring > Acked-by: Bjorn

Re: [PATCH] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error

2021-04-11 Thread Jonathan Cameron
On Wed, 7 Apr 2021 12:59:35 +0800 Dinghao Liu wrote: > When lidar_write_control() fails, a pairing PM usage counter > decrement is needed to keep the counter balanced. > > Signed-off-by: Dinghao Liu Hi, patch content looks good but it needs a fixes tag so we know how far to backport it.

Re: [PATCH] iio: light: gp2ap002: Fix rumtime PM imbalance on error

2021-04-11 Thread Jonathan Cameron
On Wed, 7 Apr 2021 11:49:27 +0800 Dinghao Liu wrote: > When devm_request_threaded_irq() fails, we should decrease the > runtime PM counter to keep the counter balanced. But when > iio_device_register() fails, we need not to decrease it because > we have already decreased it before. Whilst

Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

2021-04-11 Thread Jonathan Cameron
On Wed, 7 Apr 2021 23:51:47 +0530 Puranjay Mohan wrote: > TMP117 is a Digital temperature sensor with integrated Non-Volatile memory. > Add support for tmp117 driver in iio subsystem. > > Datasheet: https://www.ti.com/lit/gpn/tmp117 > Signed-off-by: Puranjay Mohan > Reviewed-by: Andy

Re: [PATCH] iio: adc: exynos: drop unneeded variable assignment

2021-04-11 Thread Jonathan Cameron
On Sat, 10 Apr 2021 18:47:28 +0200 Krzysztof Kozlowski wrote: > The initialization of 'ret' variable in probe function is shortly after > overwritten. This initialization is simply not used. > > Addresses-Coverity: Unused value > Signed-off-by: Krzysztof Kozlowski Too late for this cycle,

Re: [PATCH] HID: hid-sensor-custom: remove useless variable

2021-04-11 Thread Jonathan Cameron
On Fri, 09 Apr 2021 11:19:12 -0700 Srinivas Pandruvada wrote: > On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote: > > Fix the following gcc warning: > > > > drivers/hid/hid-sensor-custom.c:400:7: warning: variable ‘ret’ set > > but > > not used [-Wunused-but-set-variable]. > > > >

Re: [PATCH 2/3] staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output

2021-04-11 Thread Jonathan Cameron
On Sat, 10 Apr 2021 19:15:39 +0300 Alexandru Ardelean wrote: > On Sat, Apr 10, 2021 at 7:12 PM Alexandru Ardelean > wrote: > > > > On Fri, Apr 9, 2021 at 9:51 PM Lucas Stankus > > wrote: > > > > > > Ditch platform_data fields in favor of device tree properties for > > > configuring EXCA and

Re: [PATCH 2/3] staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output

2021-04-11 Thread Jonathan Cameron
On Sat, 10 Apr 2021 13:05:14 +0300 Andy Shevchenko wrote: > On Saturday, April 10, 2021, Andy Shevchenko > wrote: > > > > > > > On Friday, April 9, 2021, Lucas Stankus wrote: > > > >> Ditch platform_data fields in favor of device tree properties for > >> configuring EXCA and EXCB output. >

Re: [PATCH 1/3] dt-bindings: staging: iio: cdc: ad7746: add binding documentation for AD7746

2021-04-11 Thread Jonathan Cameron
On Fri, 9 Apr 2021 15:50:10 -0300 Lucas Stankus wrote: > Add device tree binding documentation for AD7746 cdc in YAML format. > > Signed-off-by: Lucas Stankus Hi Lucas, Good to see progress on this one after all these years :) I think we can do a bit better though by making the attributes

Re: [RFC PATCH 01/10] genirq: Add chip flag to denote automatic IRQ (un)masking

2021-04-09 Thread Jonathan Cameron
On Thu, 8 Apr 2021 16:43:17 +0100 Valentin Schneider wrote: > Some IRQ chips such as the Arm GICs automagically mask / unmask an > IRQ during the handling of said IRQ. This renders further mask / unmask > operations within the flow handlers redundant, which we do want to leverage > as masking by

Re: [PATCH 7/7] cxl: Add HDM decoder capbilities

2021-04-08 Thread Jonathan Cameron
On Wed, 7 Apr 2021 15:26:25 -0700 Ben Widawsky wrote: > An HDM decoder is defined in the CXL 2.0 specification as a mechanism > that allow devices and upstream ports to claim memory address ranges and > participate in interleave sets. HDM decoder registers are within the > component register

Re: [PATCH 6/7] cxl/mem: Create a helper to setup device regs

2021-04-08 Thread Jonathan Cameron
On Wed, 7 Apr 2021 15:26:24 -0700 Ben Widawsky wrote: > Memory devices have a list of required register regions within the > register block, but this isn't required of all CXL components or > devices. To make things more tidy, and allow for easily setting up other > block types in this loop, the

Re: [PATCH 5/7] cxl/mem: Move device register setup

2021-04-08 Thread Jonathan Cameron
; > Signed-off-by: Ben Widawsky Acked-by: Jonathan Cameron > > --- > drivers/cxl/mem.c | 19 +-- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c > index 60b95c524c3e..49f651694cb0 100644 > --- a/d

Re: [PATCH 3/7] cxl/mem: Move register locator logic into reg setup

2021-04-08 Thread Jonathan Cameron
t; > Signed-off-by: Ben Widawsky Seems like a noop refactor to me as you say. Reviewed-by: Jonathan Cameron > --- > drivers/cxl/mem.c | 135 +++--- > 1 file changed, 68 insertions(+), 67 deletions(-) > > diff --git a/drivers/cxl/mem.c b/d

Re: [PATCH 2/7] cxl/mem: Split creation from mapping in probe

2021-04-08 Thread Jonathan Cameron
d in this patch with the > exception of a dev_err printed when the device register block isn't > found. > > Signed-off-by: Ben Widawsky Agreed, this seems to be a noop refactor to me. Reviewed-by: Jonathan Cameron > --- > drivers/cxl/mem.c | 64 +---

Re: [PATCH 4/7] cxl/mem: Get rid of @cxlm.base

2021-04-08 Thread Jonathan Cameron
ng in and out of __iomem in the error paths. It's a common enough idiom though so I'm not htat fussed. Acked-by: Jonathan Cameron > --- > drivers/cxl/mem.c | 24 +++- > drivers/cxl/mem.h | 2 -- > 2 files changed, 11 insertions(+), 15 deletions(-) > > di

Re: [PATCH 1/7] cxl/mem: Use dev instead of pdev->dev

2021-04-08 Thread Jonathan Cameron
On Wed, 7 Apr 2021 15:26:19 -0700 Ben Widawsky wrote: > Trivial cleanup. Obviously correct :) > > Signed-off-by: Ben Widawsky FWIW Acked-by: Jonathan Cameron > --- > drivers/cxl/mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers

Re: [PATCH 1/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU

2021-04-08 Thread Jonathan Cameron
ent statistics. > > trigger_mode - set trigger mode. 0 means starting to statistic when > >bigger than trigger condition, and 1 means smaller. > > thr_len - set threshold for statistics. > > thr_mode - set threshold mode. 0 means count when bigger than >

Re: [PATCH v2 11/19] dt-bindings:iio:adc: update dlg,da9150-gpadc.yaml reference

2021-04-07 Thread Jonathan Cameron
/dlg,da9150-gpadc.yaml. > > Update its cross-reference accordingly. > > Fixes: e13b686b18e3 ("dt-bindings:iio:adc:dlg,da9150-gpadc yaml conversion") > Signed-off-by: Mauro Carvalho Chehab Acked-by: Jonathan Cameron > --- > Documentation/devicetree/bindings/mfd/da9150.txt

Re: [PATCH v2 10/19] dt-bindings:iio:adc: update motorola,cpcap-adc.yaml reference

2021-04-07 Thread Jonathan Cameron
otorola,cpcap-adc.yaml. > > Update its cross-reference accordingly. > > Fixes: 1ca9d1b1342d ("dt-bindings:iio:adc:motorola,cpcap-adc yaml conversion") > Signed-off-by: Mauro Carvalho Chehab Acked-by: Jonathan Cameron > --- > Documentation/devicetree/bindings/mfd/mot

Re: [PATCH v2 07/19] dt-bindings: fix references for iio-bindings.txt

2021-04-07 Thread Jonathan Cameron
their > references, in order to point to the right URL. > > Fixes: dba91f82d580 ("dt-bindings:iio:iio-binding.txt Drop file as content > now in dt-schema") > Signed-off-by: Mauro Carvalho Chehab Given the spread of this one across various other binding docs, perhaps this is

Re: [PATCH v2 5/8] cxl/acpi: Introduce ACPI0017 driver and cxl_root

2021-04-06 Thread Jonathan Cameron
On Thu, 1 Apr 2021 07:31:09 -0700 Dan Williams wrote: > While CXL builds upon the PCI software model for dynamic enumeration and > control, a static platform component is required to bootstrap the CXL > memory layout. In addition to identifying the host bridges ACPI is > responsible for

Re: [PATCH v2 7/8] cxl/port: Introduce cxl_port objects

2021-04-06 Thread Jonathan Cameron
On Thu, 1 Apr 2021 07:31:20 -0700 Dan Williams wrote: > Once the cxl_root is established then other ports in the hierarchy can > be attached. The cxl_port object, unlike cxl_root that is associated > with host bridges, is associated with PCIE Root Ports or PCIE Switch > Ports. Add cxl_port

Re: [PATCH v2 2/8] cxl/mem: Introduce 'struct cxl_regs' for "composable" CXL devices

2021-04-06 Thread Jonathan Cameron
On Thu, 1 Apr 2021 07:30:53 -0700 Dan Williams wrote: > CXL MMIO register blocks are organized by device type and capabilities. > There are Component registers, Device registers (yes, an ambiguous > name), and Memory Device registers (a specific extension of Device > registers). > > It is

Re: [PATCH v2 4/8] cxl/core: Refactor CXL register lookup for bridge reuse

2021-04-06 Thread Jonathan Cameron
or endpoints and bridges to share. > > Reviewed-by: Ben Widawsky > Signed-off-by: Dan Williams Nice to make the docs kernel-doc, but otherwise this is simple and makes sense Reviewed-by: Jonathan Cameron > --- > drivers/cxl/core.c | 57 > +

Re: [PATCH v2 1/8] cxl/mem: Move some definitions to mem.h

2021-04-06 Thread Jonathan Cameron
On Thu, 1 Apr 2021 07:30:47 -0700 Dan Williams wrote: > In preparation for sharing cxl.h with other generic CXL consumers, > move / consolidate some of the memory device specifics to mem.h. > > Reviewed-by: Ben Widawsky > Signed-off-by: Dan Williams Hi Dan, Would be good to see something in

Re: [PATCH][next] iio: hrtimer-trigger: Fix potential integer overflow in iio_hrtimer_store_sampling_frequency

2021-04-05 Thread Jonathan Cameron
On Mon, 29 Mar 2021 15:58:17 -0500 "Gustavo A. R. Silva" wrote: > Add suffix ULL to constant 1000 in order to avoid a potential integer > overflow and give the compiler complete information about the proper > arithmetic to use. Notice that this constant is being used in a context > that expects

Re: [PATCH v7 1/2] Added AMS tsl2591 driver implementation

2021-04-04 Thread Jonathan Cameron
On Fri, 2 Apr 2021 01:45:46 +0100 Joe Sandom wrote: > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > This driver supports configuration via device tree and sysfs. > Supported channels for raw infrared light intensity, > raw combined light intensity and illuminance in lux.

Re: [PATCH] iio: buffer: use sysfs_attr_init() on allocated attrs

2021-04-04 Thread Jonathan Cameron
On Fri, 2 Apr 2021 20:42:26 +0300 Alexandru Ardelean wrote: > When dynamically allocating sysfs attributes, it's a good idea to call > sysfs_attr_init() on them to initialize lock_class_keys. > This change does that. > > The lock_class_keys are set when the CONFIG_DEBUG_LOCK_ALLOC symbol is >

Re: [PATCH v2 1/2] iio: trigger: Replace explicit casting and wrong specifier with proper one

2021-04-04 Thread Jonathan Cameron
On Fri, 2 Apr 2021 20:49:10 +0300 Andy Shevchenko wrote: > By unknown reason device name is set with an index casted from int > to unsigned long while at the same time with "%ld" specifier. Both parts > seems wrong to me, thus replace replace explicit casting and wrong specifier > with proper

Re: [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 21:05:58 +0300 Andy Shevchenko wrote: > On Thu, Apr 1, 2021 at 8:48 PM Mugilraj Dhavachelvan > wrote: > > > > dropped __func__ while using dev_dbg() and pr_debug() > > The commit message may be amended, from code perspective LGTM! > Reviewed-by: Andy Shevchenko I added a

Re: [PATCH v1 1/2] iio: trigger: Replace explicit casting and wrong specifier with proper one

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 17:54:56 +0300 Andy Shevchenko wrote: > By unknown reason device name is set with an index casted from int > to unsigned long while at the same time with "%ld" specifier. Both parts > seems wrong to me, thus replace replace explicit casting and wrong specifier > with proper

Re: [PATCH 25/32] dt-bindings:iio:dac: update microchip,mcp4725.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:45 +0200 Mauro Carvalho Chehab wrote: > Changeset 6ced946a4bba ("dt-bindings:iio:dac:microchip,mcp4725 yaml > conversion") > renamed: Documentation/devicetree/bindings/iio/dac/mcp4725.txt > to: Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml. > >

Re: [PATCH 21/32] MAINTAINERS: update ti,dac7612.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:41 +0200 Mauro Carvalho Chehab wrote: > Changeset 8b74e06b0f4d ("dt-bindings:iio:dac:ti,dac7612 yaml conversion") > renamed: Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt > to: Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml. > > Update its

Re: [PATCH 19/32] MAINTAINERS: update st,vl53l0x.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:39 +0200 Mauro Carvalho Chehab wrote: > Changeset b4be8bd1c6a2 ("dt-bindings:iio:proximity:st,vl53l0x yaml > conversion") > renamed: Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt > to: Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml. > >

Re: [PATCH 18/32] MAINTAINERS: update st,lsm6dsx.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:38 +0200 Mauro Carvalho Chehab wrote: > Changeset 7a2cf8e91390 ("dt-bindings:iio:imu:st,lsm6dsx: txt to yaml > conversion") > renamed: Documentation/devicetree/bindings/iio/imu/st_lsm6dsx.txt > to: Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml. > > Update

Re: [PATCH 17/32] MAINTAINERS: update renesas,rcar-gyroadc.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:37 +0200 Mauro Carvalho Chehab wrote: > Changeset 8c41245872e2 ("dt-bindings:iio:adc:renesas,rcar-gyroadc: txt to > yaml conversion.") > renamed: Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt > to:

Re: [PATCH 16/32] MAINTAINERS: update pni,rm3100.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:36 +0200 Mauro Carvalho Chehab wrote: > Changeset f383069be33e ("dt-bindings:iio:magnetometer:pni,rm3100: txt to yaml > conversion.") > renamed: Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt > to:

Re: [PATCH 15/32] MAINTAINERS: update atmel,sama5d2-adc.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:35 +0200 Mauro Carvalho Chehab wrote: > Changeset 58ff1b519753 ("dt-bindings:iio:adc:atmel,sama5d2-adc: txt to yaml > conversion") > renamed: Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt > to:

Re: [PATCH 11/32] MAINTAINERS: update invensense,mpu3050.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:31 +0200 Mauro Carvalho Chehab wrote: > Changeset 749787477ae4 ("dt-bindings:iio:gyro:invensense,mpu3050: txt to yaml > format conversion.") > renamed: > Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.txt > to:

Re: [PATCH 10/32] MAINTAINERS: update voltage-divider.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:30 +0200 Mauro Carvalho Chehab wrote: > Changeset 6f633bc91ac1 ("dt-bindings:iio:afe:voltage-divider: txt to yaml > conversion") > renamed: Documentation/devicetree/bindings/iio/afe/voltage-divider.txt > to:

Re: [PATCH 09/32] MAINTAINERS: update current-sense-shunt.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:29 +0200 Mauro Carvalho Chehab wrote: > Changeset ce66e52b6c16 ("dt-bindings:iio:afe:current-sense-shunt: txt to yaml > conversion.") > renamed: Documentation/devicetree/bindings/iio/afe/current-sense-shunt.txt > to:

Re: [PATCH 08/32] MAINTAINERS: update current-sense-amplifier.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:28 +0200 Mauro Carvalho Chehab wrote: > Changeset fbac26b9ad21 ("dt-bindings:iio:afe:current-sense-amplifier: txt to > yaml conversion.") > renamed: Documentation/devicetree/bindings/iio/afe/current-sense-amplifier.txt > to:

Re: [PATCH 07/32] MAINTAINERS: update envelope-detector.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:27 +0200 Mauro Carvalho Chehab wrote: > Changeset 66a6dcc20e63 ("dt-bindings:iio:adc:envelope-detector: txt to yaml > conversion.") > renamed: Documentation/devicetree/bindings/iio/adc/envelope-detector.txt > to:

Re: [PATCH 06/32] MAINTAINERS: update dpot-dac.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:26 +0200 Mauro Carvalho Chehab wrote: > Changeset 06d2ff6fe11e ("dt-bindings:iio:dac:dpot-dac: yaml conversion.") > renamed: Documentation/devicetree/bindings/iio/dac/dpot-dac.txt > to: Documentation/devicetree/bindings/iio/dac/dpot-dac.yaml. > > Update its

Re: [PATCH 05/32] MAINTAINERS: update st,hts221.yaml reference

2021-04-02 Thread Jonathan Cameron
On Thu, 1 Apr 2021 14:17:25 +0200 Mauro Carvalho Chehab wrote: > Changeset 9a6ac3138258 ("dt-bindings:iio:humidity:st,hts221 yaml conversion.") > renamed: Documentation/devicetree/bindings/iio/humidity/hts221.txt > to: Documentation/devicetree/bindings/iio/humidity/st,hts221.yaml. > > Update

  1   2   3   4   5   6   7   8   9   10   >