[PATCH v6 7/7] PCI: dwc: Add validation that PCIe core is set to correct mode

Some PCIe controllers can be set to either Host or EP according to some early boot FW. To make sure there is no discrepancy (e.g. FW configured the port to EP mode while the DT specifies it as a host bridge or vice versa), a check has been added for each mode. Signed-off-by: Jonathan Chocron

[PATCH v6 6/7] PCI: dwc: al: Add Amazon Annapurna Labs PCIe controller driver

W. Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel Reviewed-by: Andrew Murray --- drivers/pci/controller/dwc/Kconfig | 12 + drivers/pci/controller/dwc/pcie-al.c | 365 +++ 2 files changed, 377 insertions(+) diff --git a/drivers/pci/controller/dwc/

[PATCH v6 5/7] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding

Document Amazon's Annapurna Labs PCIe host bridge. Signed-off-by: Jonathan Chocron Reviewed-by: Andrew Murray Reviewed-by: Rob Herring --- .../devicetree/bindings/pci/pcie-al.txt | 46 +++ MAINTAINERS | 3 +- 2 files change

[PATCH v6 4/7] PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port

ork, but hasn't been tested nor has a current use case), since currently there is no standard way to disable only MSI-X. Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel Reviewed-by: Andrew Murray --- drivers/pci/quirks.c | 18 ++ 1 file changed, 18 insertions(+)

[PATCH v6 1/7] PCI: Add Amazon's Annapurna Labs vendor ID

Add Amazon's Annapurna Labs vendor ID to pci_ids.h. Signed-off-by: Jonathan Chocron Acked-by: Bjorn Helgaas Reviewed-by: Andrew Murray --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index f59a6f9

[PATCH v6 2/7] PCI: Add ACS quirk for Amazon Annapurna Labs root ports

li Saidi Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel Reviewed-by: Andrew Murray Acked-by: Bjorn Helgaas --- drivers/pci/quirks.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index ded60757a573..2e983

[PATCH v6 3/7] PCI/VPD: Prevent VPD access for Amazon's Annapurna Labs Root Port

is likely a firmware bug on this device. Contact the card vendor for a firmware update Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel Reviewed-by: Andrew Murray Acked-by: Bjorn Helgaas --- drivers/pci/vpd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci

[PATCH v6 0/7] Amazon's Annapurna Labs DT-based PCIe host controller driver

%px in dbg prints in rd/wr_conf() functions - Removed validation that the port is configured to RC mode (as this is added generically in PATCH 7/8) - Removed unnecessary variable initializations - Switched to %pR for printing resources Ali Saidi (1): PCI: Add ACS quirk for Amazon Annapurna L

[PATCH v5 7/7] PCI: dwc: Add validation that PCIe core is set to correct mode

Some PCIe controllers can be set to either Host or EP according to some early boot FW. To make sure there is no discrepancy (e.g. FW configured the port to EP mode while the DT specifies it as a host bridge or vice versa), a check has been added for each mode. Signed-off-by: Jonathan Chocron

[PATCH v5 6/7] PCI: dwc: al: Add support for DW based driver type

W. Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel Reviewed-by: Andrew Murray --- drivers/pci/controller/dwc/Kconfig | 12 + drivers/pci/controller/dwc/pcie-al.c | 365 +++ 2 files changed, 377 insertions(+) diff --git a/drivers/pci/controller/dwc/

[PATCH v5 5/7] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding

Document Amazon's Annapurna Labs PCIe host bridge. Signed-off-by: Jonathan Chocron Reviewed-by: Andrew Murray Reviewed-by: Rob Herring --- .../devicetree/bindings/pci/pcie-al.txt | 46 +++ MAINTAINERS | 3 +- 2 files change

[PATCH v5 4/7] PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port

o disable only MSI-X. Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel Reviewed-by: Andrew Murray --- drivers/pci/quirks.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 8fe765592943..5a8ea5fdeae7 100644 --- a/

[PATCH v5 1/7] PCI: Add Amazon's Annapurna Labs vendor ID

Add Amazon's Annapurna Labs vendor ID to pci_ids.h. Signed-off-by: Jonathan Chocron Acked-by: Bjorn Helgaas Reviewed-by: Andrew Murray --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index f59a6f9

[PATCH v5 3/7] PCI/VPD: Prevent VPD access for Amazon's Annapurna Labs Root Port

likely a firmware bug on this device. Contact the card vendor for a firmware update Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel --- drivers/pci/vpd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c index 4963c2e2bd4c

[PATCH v5 2/7] PCI: Add ACS quirk for Amazon Annapurna Labs root ports

li Saidi Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel Reviewed-by: Andrew Murray --- drivers/pci/quirks.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index ded60757a573..8fe765592943 100644 --- a/driver

[PATCH v5 0/7] Amazon's Annapurna Labs DT-based PCIe host controller driver

emoved unnecessary variable initializations - Swtiched to %pR for printing resources Ali Saidi (1): PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron (6): PCI: Add Amazon's Annapurna Labs vendor ID PCI/VPD: Prevent VPD access for Amazon's Annapurna Labs Root Port PCI: A

[PATCH v4 7/7] PCI: dwc: Add validation that PCIe core is set to correct mode

Some PCIe controllers can be set to either Host or EP according to some early boot FW. To make sure there is no discrepancy (e.g. FW configured the port to EP mode while the DT specifies it as a host bridge or vice versa), a check has been added for each mode. Signed-off-by: Jonathan Chocron

[PATCH v4 6/7] PCI: dwc: al: Add support for DW based driver type

W. Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel --- drivers/pci/controller/dwc/Kconfig | 12 + drivers/pci/controller/dwc/pcie-al.c | 365 +++ 2 files changed, 377 insertions(+) diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/cont

[PATCH v4 5/7] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding

Document Amazon's Annapurna Labs PCIe host bridge. Signed-off-by: Jonathan Chocron --- .../devicetree/bindings/pci/pcie-al.txt | 46 +++ MAINTAINERS | 3 +- 2 files changed, 48 insertions(+), 1 deletion(-) create mode 1

[PATCH v4 3/7] PCI/VPD: Add VPD release quirk for Amazon's Annapurna Labs Root Port

or example, this results in the following error: pcilib: sysfs_read_vpd: read failed: Input/output error This quirk removes the sysfs entry, which avoids the error print. Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel --- drivers/pci/vpd.c | 16 1 file c

[PATCH v4 4/7] PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port

o disable only MSI-X. Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel --- drivers/pci/quirks.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 23672680dba7..b6e6e7df3f7b 100644 --- a/drivers/pci/quirks.c +++ b/

[PATCH v4 2/7] PCI: Add ACS quirk for Amazon Annapurna Labs root ports

li Saidi Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel --- drivers/pci/quirks.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 208aacf39329..23672680dba7 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci

[PATCH v4 1/7] PCI: Add Amazon's Annapurna Labs vendor ID

Add Amazon's Annapurna Labs vendor ID to pci_ids.h. Signed-off-by: Jonathan Chocron Acked-by: Bjorn Helgaas Reviewed-by: Andrew Murray --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index f59a6f9

[PATCH v4 0/7] Amazon's Annapurna Labs DT-based PCIe host controller driver

s - Swtiched to %pR for printing resources Ali Saidi (1): PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron (6): PCI: Add Amazon's Annapurna Labs vendor ID PCI/VPD: Add VPD release quirk for Amazon's Annapurna Labs Root Port PCI: Add quirk to disable M

[PATCH v3 7/8] PCI: dw: Add validation that PCIe core is set to correct mode

Some PCIe controllers can be set to either Host or EP according to some early boot FW. To make sure there is no discrepancy (e.g. FW configured the port to EP mode while the DT specifies it as a host bridge or vice versa), a check has been added for each mode. Signed-off-by: Jonathan Chocron

[PATCH v3 6/8] PCI: al: Add support for DW based driver type

: Jonathan Chocron --- drivers/pci/controller/dwc/Kconfig | 12 + drivers/pci/controller/dwc/pcie-al.c | 367 +++ 2 files changed, 379 insertions(+) diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index 6ea778ae4877..3c6094cbcc3b 100644

[PATCH v3 5/8] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding

Document Amazon's Annapurna Labs PCIe host bridge. Signed-off-by: Jonathan Chocron --- .../devicetree/bindings/pci/pcie-al.txt | 45 +++ MAINTAINERS | 3 +- 2 files changed, 47 insertions(+), 1 deletion(-) create mode 1

[PATCH v3 8/8] PCI: dw: Add support for PCI_PROBE_ONLY/PCI_REASSIGN_ALL_BUS flags

. Signed-off-by: Jonathan Chocron --- .../pci/controller/dwc/pcie-designware-host.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index d2ca748e4c85

[PATCH v3 4/8] PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port

8 [1.632400] pci_alloc_irq_vectors_affinity+0xdc/0x150 [1.632401] pcie_port_device_register+0x2b8/0x4e0 [1.632402] pcie_portdrv_probe+0x34/0xf0 Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel --- drivers/pci/quirks.c | 15 +++ 1 file changed, 15 insertions(+) diff --gi

[PATCH v3 3/8] PCI/VPD: Add VPD release quirk for Amazon's Annapurna Labs Root Port

or example, this results in the following error: pcilib: sysfs_read_vpd: read failed: Input/output error This quirk removes the sysfs entry, which avoids the error print. Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel --- drivers/pci/vpd.c | 16 1 file c

[PATCH v3 2/8] PCI: Add ACS quirk for Amazon Annapurna Labs root ports

li Saidi Signed-off-by: Jonathan Chocron Reviewed-by: Gustavo Pimentel --- drivers/pci/quirks.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 208aacf39329..23672680dba7 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci

[PATCH v3 1/8] PCI: Add Amazon's Annapurna Labs vendor ID

Add Amazon's Annapurna Labs vendor ID to pci_ids.h. Signed-off-by: Jonathan Chocron Acked-by: Bjorn Helgaas --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 40015609c4b5..63dfa4bace57 100644 --- a/in

[PATCH v3 0/8] Amazon's Annapurna Labs DT-based PCIe host controller driver

urces Ali Saidi (1): PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron (7): PCI: Add Amazon's Annapurna Labs vendor ID PCI/VPD: Add VPD release quirk for Amazon's Annapurna Labs Root Port PCI: Add quirk to disable MSI-X support for Amazon's Annapurn

[PATCH v2 7/8] PCI: dw: Add validation that PCIe core is set to correct mode

Some PCIe controllers can be set to either Host or EP according to some early boot FW. To make sure there is no discrepancy (e.g. FW configured the port to EP mode while the DT specifies it as a host bridge or vice versa), a check has been added for each mode. Signed-off-by: Jonathan Chocron

[PATCH v2 5/8] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding

Document Amazon's Annapurna Labs PCIe host bridge. Signed-off-by: Jonathan Chocron --- .../devicetree/bindings/pci/pcie-al.txt | 45 +++ MAINTAINERS | 3 +- 2 files changed, 47 insertions(+), 1 deletion(-) create mode 1

[PATCH v2 6/8] PCI: al: Add support for DW based driver type

: Jonathan Chocron --- drivers/pci/controller/dwc/Kconfig | 12 + drivers/pci/controller/dwc/pcie-al.c | 373 +++ 2 files changed, 385 insertions(+) diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index 6ea778ae4877..3c6094cbcc3b 100644

[PATCH v2 8/8] PCI: dw: Add support for PCI_PROBE_ONLY/PCI_REASSIGN_ALL_BUS flags

. Signed-off-by: Jonathan Chocron --- .../pci/controller/dwc/pcie-designware-host.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index d2ca748e4c85

[PATCH v2 4/8] PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port

8 [1.632400] pci_alloc_irq_vectors_affinity+0xdc/0x150 [1.632401] pcie_port_device_register+0x2b8/0x4e0 [1.632402] pcie_portdrv_probe+0x34/0xf0 Signed-off-by: Jonathan Chocron --- drivers/pci/quirks.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci

[PATCH v2 3/8] PCI/VPD: Add VPD release quirk for Amazon's Annapurna Labs Root Port

or example, this results in the following error: pcilib: sysfs_read_vpd: read failed: Input/output error This quirk removes the sysfs entry, which avoids the error print. Signed-off-by: Jonathan Chocron --- drivers/pci/vpd.c | 16 1 file changed, 16 insertions(+) diff --git a/d

[PATCH v2 2/8] PCI: Add ACS quirk for Amazon Annapurna Labs root ports

li Saidi Signed-off-by: Jonathan Chocron --- drivers/pci/quirks.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 208aacf39329..23672680dba7 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4366,6 +4

[PATCH v2 0/8] Amazon's Annapurna Labs DT-based PCIe host controller driver

mazon Annapurna Labs root ports Jonathan Chocron (7): PCI: Add Amazon's Annapurna Labs vendor ID PCI/VPD: Add VPD release quirk for Amazon's Annapurna Labs Root Port PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port dt-bindings: PCI: Add Ama

[PATCH v2 1/8] PCI: Add Amazon's Annapurna Labs vendor ID

Add Amazon's Annapurna Labs vendor ID to pci_ids.h. Signed-off-by: Jonathan Chocron Acked-by: Bjorn Helgaas --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 40015609c4b5..63dfa4bace57 100644 --- a/in

[PATCH 8/8] PCI: dw: Add support for PCI_PROBE_ONLY/PCI_REASSIGN_ALL_BUS flags

. Signed-off-by: Jonathan Chocron --- .../pci/controller/dwc/pcie-designware-host.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index d2ca748e4c85

[PATCH 7/8] PCI: dw: Add validation that PCIe core is set to correct mode

Some PCIe controllers can be set to either Host or EP according to some early boot FW. To make sure there is no discrepancy (e.g. FW configured the port to EP mode while the DT specifies it as a host bridge or vice versa), a check has been added for each mode. Signed-off-by: Jonathan Chocron

[PATCH 6/8] PCI: al: Add support for DW based driver type

: Jonathan Chocron --- drivers/pci/controller/dwc/Kconfig | 11 + drivers/pci/controller/dwc/pcie-al.c | 397 +++ 2 files changed, 408 insertions(+) diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index a6ce1ee51b4c..51da9cb219aa 100644

[PATCH 4/8] PCI: Add quirk to disable MSI support for Amazon's Annapurna Labs host bridge

On some platforms, the host bridge exposes an MSI-X capability but doesn't actually support it. This causes a crash during initialization by the pcieport driver, since it tries to configure the MSI-X capability. Signed-off-by: Jonathan Chocron --- drivers/pci/quirks.c | 8 1

[PATCH 3/8] PCI/VPD: Add VPD release quirk for Amazon Annapurna Labs host bridge

i -vv, for example, this results in the following error: pcilib: sysfs_read_vpd: read failed: Input/output error This quirk removes the sysfs entry, which avoids the error print. Signed-off-by: Jonathan Chocron --- drivers/pci/vpd.c | 12 1 file changed, 12 insertions(+) diff --git a/d

[PATCH 2/8] PCI: Add ACS quirk for Amazon Annapurna Labs root ports

li Saidi Signed-off-by: Jonathan Chocron --- drivers/pci/quirks.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index c66c0ca446c4..11850b030637 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4366,6 +4

[PATCH 1/8] PCI: Add Amazon's Annapurna Labs vendor ID

Add Amazon's Annapurna Labs vendor ID to pci_ids.h. Signed-off-by: Jonathan Chocron --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 0dd239f11e91..ed350fd522c6 100644 --- a/include/linux/pci_ids.h

[PATCH 0/8] Amazon's Annapurna Labs DT-based PCIe host controller driver

t all (as opposed to PCI system-wide code)? Ali Saidi (1): PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron (7): PCI: Add Amazon's Annapurna Labs vendor ID PCI/VPD: Add VPD release quirk for Amazon Annapurna Labs host bridge PCI: Add quirk to disable MSI s

[PATCH 5/8] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding

Document Amazon's Annapurna Labs PCIe host bridge. Signed-off-by: Jonathan Chocron --- .../devicetree/bindings/pci/pcie-al.txt | 45 +++ MAINTAINERS | 1 + 2 files changed, 46 insertions(+) create mode 100644 Documentation/devic

[PATCH v3] PCI: al: Add Amazon Annapurna Labs PCIe host controller driver

n AMZN0001 device. - Adding a new entry in the MCFG quirk array Co-developed-by: Vladimir Aerov Signed-off-by: Jonathan Chocron Signed-off-by: Vladimir Aerov Reviewed-by: David Woodhouse --- --v2: - Fix commit message comments (incl. using AMZN0001 instead of PNP0C02) - Use the usual

Re: [PATCH v2] PCI: al: Add Amazon Annapurna Labs PCIe host controller driver

On 3/26/19 14:55, Bjorn Helgaas wrote: Nits, probably Lorenzo will fix them up unless he sees more substantive things. On Tue, Mar 26, 2019 at 12:00:55PM +0200, Jonathan Chocron wrote: Adding support for Amazon's Annapurna Labs PCIe driver. Ideally, use "imperative mood", i.e.

[PATCH v2] PCI: al: Add Amazon Annapurna Labs PCIe host controller driver

an AMZN0001 device. - Adding a new entry in the mcfg quirk array Co-developed-by: Vladimir Aerov Signed-off-by: Jonathan Chocron Signed-off-by: Vladimir Aerov Reviewed-by: Benjamin Herrenschmidt Reviewed-by: David Woodhouse --- Changes from v1: - Fix commit message comments (incl. using A

Re: [PATCH] PCI: al: add pcie-al.c

ional comments. The subject should be something like: PCI: al: Add Amazon Annapurna Labs PCIe host controller driver Done. On Mon, Mar 25, 2019 at 01:07:20PM +0200, jon...@amazon.com wrote: From: Jonathan Chocron Adding support for Amazon's Annapurna Labs pcie driver. s/pcie/PCIe/ Don