Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

2020-11-11 Thread Jonathan Liu
t; > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > > > It has been observed that resetting force in the detect function can > > > > result in the PHY being powered down in response to hot-plug detect > > > > being asserted, even when the HDMI

[PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

2020-10-31 Thread Jonathan Liu
drm_helper_hpd_irq_event dw_hdmi_irq irq_thread_fn irq_thread kthread ret_from_fork Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/d

[PATCH] drm/rockchip: dw_hdmi: fix incorrect clock in vpll clock error message

2020-10-23 Thread Jonathan Liu
Error message incorrectly refers to grf clock instead of vpll clock. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi

Re: [PATCH 3/3] serial: 8250_dw: Fix clk-notifier/port suspend deadlock

2020-10-17 Thread Jonathan Liu
https://lore.kernel.org/linux-serial/f1cd5c75-9cda-6896-a4e2-42c5bfc3f...@redhat.com > > Fixes: cc816969d7b5 ("serial: 8250_dw: Fix common clocks usage race > condition") > Reported-by: Hans de Goede > Signed-off-by: Serge Semin Tested-by: Jonathan Liu Fixes hang while closin

[PATCH] spi: sun4i: update max transfer size reported

2020-07-27 Thread Jonathan Liu
The spi-sun4i driver already has the ability to do large transfers. However, the max transfer size reported is still fifo depth - 1. Update the max transfer size reported to the max value possible. Fixes: 196737912da5 ("spi: sun4i: Allow transfers larger than FIFO size") Signed-off-by

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-12 Thread Jonathan Liu
Hi Giulio, On Wed, 12 Dec 2018 at 04:20, Giulio Benetti wrote: > > Hi Jonathan, > > Il 11/12/2018 11:49, Jonathan Liu ha scritto: > > Hi Giulio, > > > > On Thu, 6 Dec 2018 at 22:00, Giulio Benetti > > wrote: > >> > >> Hi Jonathan, > >&

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-12 Thread Jonathan Liu
Hi Giulio, On Wed, 12 Dec 2018 at 04:39, Giulio Benetti wrote: > > Forgot to ask you, > > Il 11/12/2018 18:20, Giulio Benetti ha scritto: > > Hi Jonathan, > > > > Il 11/12/2018 11:49, Jonathan Liu ha scritto: > >> Hi Giulio, > >> > >>

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-11 Thread Jonathan Liu
Hi Giulio, On Thu, 6 Dec 2018 at 22:00, Giulio Benetti wrote: > > Hi Jonathan, > > Il 06/12/2018 08:29, Jonathan Liu ha scritto: > > Hi Giulio, > > > > On Thu, 15 Feb 2018 at 17:54, Giulio Benetti > > wrote: > >> > >> Differently from

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2018-03-25 Thread Jonathan Liu
Hi, On 25 March 2018 at 12:21, Jonathan Liu wrote: > On 8 February 2018 at 14:55, Jeffy Chen wrote: >> From: AMAN DEEP >> >> There is a race condition between finish_unlinks->finish_urb() function >> and usb_kill_urb() in ohci controller case. The finish_urb ca

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2018-03-24 Thread Jonathan Liu
Hi, On 25 March 2018 at 12:21, Jonathan Liu wrote: > Hi, > > On 8 February 2018 at 14:55, Jeffy Chen wrote: >> From: AMAN DEEP >> >> There is a race condition between finish_unlinks->finish_urb() function >> and usb_kill_urb() in ohci controller case. The f

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2018-03-24 Thread Jonathan Liu
Hi, On 8 February 2018 at 14:55, Jeffy Chen wrote: > From: AMAN DEEP > > There is a race condition between finish_unlinks->finish_urb() function > and usb_kill_urb() in ohci controller case. The finish_urb calls > spin_unlock(&ohci->lock) before usb_hcd_giveback_urb() function call, > then if du

[PATCH v3 3/3] drm/sun4i: hdmi: Add missing rate halving check in sun4i_tmds_determine_rate

2018-01-08 Thread Jonathan Liu
sun4i: Add HDMI support") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index 88eeeaf34638..3ecff

[PATCH v3 0/3] drm/sun4i: hdmi: Fix sun4i_tmds_determine_rate

2018-01-08 Thread Jonathan Liu
commit message for unset best_parent Changes for v2: - Split into separate patches for each issue - Add details to commit message for reproducing issue Jonathan Liu (3): drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate drm/sun4i: hdmi: Fix incorrect assignment in

[PATCH v3 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

2018-01-08 Thread Jonathan Liu
er set. This results in req->rate and req->best_parent_rate being assigned 0. To avoid this, we set best_parent to the first calculated rate if it is unset. The sun4i_tmds_calc_divider function already has a similar check. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed

[PATCH v3 2/3] drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate

2018-01-08 Thread Jonathan Liu
best_div is set to i which corresponds to rate halving when it should be set to j which corresponds to the divider. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v2 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

2018-01-05 Thread Jonathan Liu
Hi Maxime, On 5 January 2018 at 21:03, Maxime Ripard wrote: > On Fri, Jan 05, 2018 at 09:44:39AM +1100, Jonathan Liu wrote: >> On 5 January 2018 at 06:56, Maxime Ripard >> wrote: >> > On Tue, Dec 26, 2017 at 10:12:25PM +1100, Jonathan Liu wrote: >> >> We sho

Re: [PATCH v2 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

2018-01-04 Thread Jonathan Liu
Hi Maxime, On 5 January 2018 at 06:56, Maxime Ripard wrote: > On Tue, Dec 26, 2017 at 10:12:25PM +1100, Jonathan Liu wrote: >> We should check if the best match has been set before comparing it. >> >> Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support")

[PATCH v2 3/3] drm/sun4i: hdmi: Add missing rate halving check in sun4i_tmds_determine_rate

2017-12-26 Thread Jonathan Liu
sun4i: Add HDMI support") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index 88eeeaf34638..3ecff

[PATCH v2 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

2017-12-26 Thread Jonathan Liu
We should check if the best match has been set before comparing it. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH v2 0/3] drm/sun4i: hdmi: Fix sun4i_tmds_determine_rate

2017-12-26 Thread Jonathan Liu
separate patches for each issue - Add details to commit message for reproducing issue Jonathan Liu (3): drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate drm/sun4i: hdmi: Add missing rate

[PATCH v2 2/3] drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate

2017-12-26 Thread Jonathan Liu
best_div is set to i which corresponds to rate halving when it should be set to j which corresponds to the divider. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] drm/sun4i: hdmi: Fix sun4i_tmds_determine_rate

2017-12-21 Thread Jonathan Liu
x27;t match the requested rate exactly - sets best_div to i which corresponds to rate halving when it should be set to j which corresponds to the divider Fix these issues. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_hdmi_tm

Re: Support TrackStick of Thinkpad L570

2017-12-01 Thread Jonathan Liu
++--- > 1 file changed, 21 insertions(+), 3 deletions(-) Tested-by: Jonathan Liu This fixes trackstick and physical left/middle/right mouse buttons above touchpad on Lenovo ThinkPad E570p laptop for me. Regards, Jonathan

Re: Support TrackStick of Thinkpad L570

2017-11-23 Thread Jonathan Liu
--- > 1 file changed, 18 insertions(+), 3 deletions(-) Tested-by: Jonathan Liu This fixes trackstick and physical left/middle/right mouse buttons above touchpad on Lenovo ThinkPad E570p laptop for me. Regards, Jonathan

Re: [14/23] drm/sun4i: Create minimal multipliers and dividers

2017-10-23 Thread Jonathan Liu
Hi Maxime, On 17 October 2017 at 20:06, Maxime Ripard wrote: > The various outputs the TCON can provide have different constraints on the > dotclock divider. Let's make them configurable by the various mode_set > functions. > > Signed-off-by: Maxime Ripard > Reviewed-by: Chen-Yu Tsai > --- > d

Re: [15/23] drm/sun4i: Add LVDS support

2017-10-22 Thread Jonathan Liu
Hi Maxime, On 17 October 2017 at 20:06, Maxime Ripard wrote: > The TCON supports the LVDS interface to output to a panel or a bridge. > Let's add support for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/sun4i/Makefile | 1 +- > drivers/gpu/drm/sun4i/sun4i_lvds.c | 183

[PATCH] drm/sun4i: tcon: Add dithering support for RGB565/RGB666 LCD panels

2017-10-17 Thread Jonathan Liu
Dithering is supported on TCON channel 0 which is used for LCD panels. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 37 + drivers/gpu/drm/sun4i/sun4i_tcon.h | 18 +- 2 files changed, 54 insertions(+), 1 deletion

Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-16 Thread Jonathan Liu
On 16 October 2017 at 23:49, Bin Liu wrote: > On Mon, Oct 16, 2017 at 04:13:51PM +1100, Jonathan Liu wrote: >> On 10 October 2017 at 14:22, Bin Liu wrote: >> > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: >> >> This fixes a kernel oops wh

Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-15 Thread Jonathan Liu
On 10 October 2017 at 14:22, Bin Liu wrote: > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: >> This fixes a kernel oops when unloading the driver due to usb_put_phy >> being called after usb_phy_generic_unregister when the device is >> detached. Calling usb_p

[PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Jonathan Liu
el.org # v4.3+ Signed-off-by: Jonathan Liu --- Changes for v2: - Use devm_usb_put_phy instead of usb_put_phy drivers/usb/musb/sunxi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c index c9a09b5bb6e5..dc353e24d53c 100644 --- a/drivers/us

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Jonathan Liu
Hi, On 10 October 2017 at 13:14, Bin Liu wrote: > On Tue, Oct 10, 2017 at 08:17:34AM +1100, Jonathan Liu wrote: >> Hi, >> >> On 10 October 2017 at 01:23, Bin Liu wrote: >> > Hi, >> > >> > On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrot

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Jonathan Liu
Hi, On 10 October 2017 at 01:23, Bin Liu wrote: > Hi, > > On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrote: >> This fixes a kernel oops when unloading the driver due to usb_put_phy >> being called after usb_phy_generic_unregister when the device is

[PATCH] usb: musb: Check for host-mode using is_host_active() on reset interrupt

2017-09-27 Thread Jonathan Liu
the driver logic and does not rely on register contents. Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Jonathan Liu --- drivers/usb/musb/musb_core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 02969205

Re: [linux-sunxi] Re: [PATCH v2 1/2] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for LAN8710

2017-09-26 Thread Jonathan Liu
Hi Stefan, On 31 August 2017 at 15:20, Stefan Mavrodiev wrote: > On 08/30/2017 05:37 PM, Maxime Ripard wrote: >> >> Hi, >> >> On Mon, Aug 28, 2017 at 09:32:42AM +0300, Stefan Mavrodiev wrote: >>> >>> From revision J the board uses new phy chip LAN8710. Compared >>> with RTL8201, RA17 pin is TXER

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-09-26 Thread Jonathan Liu
Hi, On 26 September 2017 at 21:39, Jonathan Liu wrote: > This fixes a kernel oops when unloading the driver due to usb_put_phy > being called after usb_phy_generic_unregister when the device is > detached. Calling usb_phy_generic_unregister causes x->dev->driver to > be NULL

[PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-09-26 Thread Jonathan Liu
icitly managing the lifetime of usb_phy, devm_usb_get_phy is changed to usb_get_phy and we call usb_put_phy in the probe error path. Cc: sta...@vger.kernel.org # v4.3+ Signed-off-by: Jonathan Liu --- drivers/usb/musb/sunxi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag

2017-09-20 Thread Jonathan Liu
Hi Thomas, On 21 September 2017 at 02:31, Thomas Garnier wrote: > On Tue, Sep 19, 2017 at 2:35 PM, Jonathan Liu wrote: >> >> Hi Thomas, >> >> The top of the C source file I am compiling has: >> #include >> #include >> >> Tracing through the

Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag

2017-09-19 Thread Jonathan Liu
ns.com/linux/v4.14-rc1/ident/set_thread_flag). Regards, Jonathan On 20 September 2017 at 00:32, Thomas Garnier wrote: > On Tue, Sep 19, 2017 at 4:50 AM, Jonathan Liu wrote: >> Fixes "implicit declaration of function" compile error for out-of-tree >> kernel modules including

[PATCH] ARM: uaccess: Add missing include for set_thread_flag

2017-09-19 Thread Jonathan Liu
Fixes "implicit declaration of function" compile error for out-of-tree kernel modules including asm/uaccess.h. Fixes: 73ac5d6a2b6a ("arm/syscalls: Check address limit on user-mode return") Signed-off-by: Jonathan Liu --- arch/arm/include/asm/uaccess.h | 1 + 1 file changed,

[PATCH] dt-bindings: clock: sunxi-ccu: Add compatibles for sun5i CCU driver

2017-08-07 Thread Jonathan Liu
The bindings were not updated when the sun5i CCU driver was added in commit 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver"). Signed-off-by: Jonathan Liu --- Documentation/devicetree/bindings/clock/sunxi-ccu.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/

[PATCH] drm/panel: simple: Add missing panel_simple_unprepare calls

2017-08-07 Thread Jonathan Liu
16+ Signed-off-by: Jonathan Liu --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 474fa759e06e..234af81fb3d0 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drive

Re: [PATCH v6 2/6] clk: sunxi-ng: Add sun4i/sun7i CCU driver

2017-08-02 Thread Jonathan Liu
Hi Priit, On 15 July 2017 at 00:49, Priit Laes wrote: > Introduce a clock controller driver for sun4i A10 and sun7i A20 > series SoCs. > > Signed-off-by: Priit Laes > --- > drivers/clk/sunxi-ng/Kconfig | 13 +- > drivers/clk/sunxi-ng/Makefile |1 +- > drivers/clk/

[PATCH] drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS

2017-07-20 Thread Jonathan Liu
The physical size of the panel is 105.5 (W) x 67.2 (H) x 4.05 (D) mm but the active display area is 95.04 (W) x 53.856 (H) mm. The width and height should be set to the active display area. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/panel/panel-simple.c | 4 ++-- 1 file changed, 2

[PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

2017-07-09 Thread Jonathan Liu
kernel.org Signed-off-by: Jonathan Liu Reviewed-by: Chen-Yu Tsai --- Changes for v3: - Add 'Fixes:' tag - Add CC to stable - Add 'Reviewed-by: Chen-Yu Tsai ' Changes for v2: - Rename sun4i_drm_lastclose to sun4i_drv_lastclose drivers/gpu/drm/sun4i/sun4i_drv.c | 8

Re: [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

2017-07-09 Thread Jonathan Liu
Hi Maxime, On 10 July 2017 at 16:44, Maxime Ripard wrote: > On Sun, Jul 09, 2017 at 11:11:07PM +0800, Chen-Yu Tsai wrote: >> On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu wrote: >> > The drm_driver lastclose callback is called when the last userspace >> >

Re: [PATCH v5 2/6] clk: sunxi-ng: Add sun4i/sun7i CCU driver

2017-07-09 Thread Jonathan Liu
Hi Priit, On 5 July 2017 at 06:04, Priit Laes wrote: > Introduce a clock controller driver for sun4i A10 and sun7i A20 > series SoCs. > > Signed-off-by: Priit Laes > --- > drivers/clk/sunxi-ng/Kconfig | 14 +- > drivers/clk/sunxi-ng/Makefile |1 +- > drivers/clk/s

[PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

2017-07-09 Thread Jonathan Liu
The drm_driver lastclose callback is called when the last userspace DRM client has closed. Call drm_fbdev_cma_restore_mode to restore the fbdev console otherwise the fbdev console will stop working. Signed-off-by: Jonathan Liu --- Changes for v2: - Rename sun4i_drm_lastclose to

[PATCH] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

2017-07-09 Thread Jonathan Liu
The drm_driver lastclose callback is called when the last userspace DRM client has closed. Call drm_fbdev_cma_restore_mode to restore the fbdev console otherwise the fbdev console will stop working. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_drv.c | 8 1 file changed

[PATCH v8] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-07-02 Thread Jonathan Liu
Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jo

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-30 Thread Jonathan Liu
Hi Maxime, On 30 June 2017 at 19:58, Jonathan Liu wrote: > Hi Maxime, > > On 30 June 2017 at 19:34, Maxime Ripard > wrote: >> Hi, >> >> On Fri, Jun 30, 2017 at 08:22:13AM +1000, Jonathan Liu wrote: >>> Hi Maxime, >>> >>> On 30 June 2017

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-30 Thread Jonathan Liu
Hi Chen-Yu and Maxime, On 30 June 2017 at 13:16, Chen-Yu Tsai wrote: > On Fri, Jun 30, 2017 at 6:22 AM, Jonathan Liu wrote: >> Hi Maxime, >> >> On 30 June 2017 at 01:56, Maxime Ripard >> wrote: >>> On Wed, Jun 28, 2017 at 08:39:33PM +1000, Jonathan Liu

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-30 Thread Jonathan Liu
Hi Maxime, On 30 June 2017 at 19:34, Maxime Ripard wrote: > Hi, > > On Fri, Jun 30, 2017 at 08:22:13AM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On 30 June 2017 at 01:56, Maxime Ripard >> wrote: >> > On Wed, Jun 28, 2017 at 08:39:33PM +10

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-29 Thread Jonathan Liu
Hi Maxime, On 30 June 2017 at 01:56, Maxime Ripard wrote: > On Wed, Jun 28, 2017 at 08:39:33PM +1000, Jonathan Liu wrote: >> >> + u32 int_status; >> >> + u32 fifo_status; >> >> + /* Read needs empty flag unset, write needs full fl

Re: [PATCH v7] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
Hi Chen-Yu, On 29 June 2017 at 12:47, Chen-Yu Tsai wrote: > Hi, > > On Wed, Jun 28, 2017 at 6:52 PM, Jonathan Liu wrote: >> The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: >> "As in the general case the DDC bus is accessible by the kernel at

[PATCH v7] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jo

[PATCH v6] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jo

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
Hi Maxime, On 28 June 2017 at 19:20, Maxime Ripard wrote: > On Wed, Jun 28, 2017 at 12:36:52AM +1000, Jonathan Liu wrote: >> +#define SUN4I_HDMI_DDC_INT_STATUS_ERROR_MASK ( \ >> + SUN4I_HDMI_DDC_INT_STATUS_ILLEGAL_FIFO_OPERATION | \ >> + SUN4I_HDMI_DDC_INT_STATUS_

[PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-27 Thread Jonathan Liu
Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jo

Re: [PATCH v4] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-27 Thread Jonathan Liu
Hi Maxime, On 27 June 2017 at 05:05, Maxime Ripard wrote: > On Sat, Jun 24, 2017 at 04:10:54PM +1000, Jonathan Liu wrote: >> The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: >> "As in the general case the DDC bus is accessible by the kernel at the I

[PATCH] ARM: dts: sun4i: Add A10 LCD0 RGB888 pins

2017-06-26 Thread Jonathan Liu
The LCD0 controller on the A10 can do RGB output up to 8 bits per channel. Add the pins for RGB888 output. Signed-off-by: Jonathan Liu --- arch/arm/boot/dts/sun4i-a10.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i

[PATCH v2] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins

2017-06-26 Thread Jonathan Liu
The LCD0 controller on the A20 can do RGB output up to 8 bits per channel. Add the pins for RGB888 output. Signed-off-by: Jonathan Liu --- Changes for v2: - Remove "allwinner," prefix from pins and function arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++ 1 file changed, 11

Re: [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins

2017-06-26 Thread Jonathan Liu
Hi Emmanuel, On 26 June 2017 at 22:45, Emmanuel Vadot wrote: > On Mon, 26 Jun 2017 22:42:49 +1000 > Jonathan Liu wrote: > >> The LCD0 controller on the A20 can do RGB output up to 8 bits per >> channel. Add the pins for RGB888 output. >> >> Signed-off-by: Jonat

[PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins

2017-06-26 Thread Jonathan Liu
The LCD0 controller on the A20 can do RGB output up to 8 bits per channel. Add the pins for RGB888 output. Signed-off-by: Jonathan Liu --- arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i

Re: [linux-sunxi] [PATCH v4 1/6] clk: sunxi-ng: div: Add support for fixed post-divider

2017-06-26 Thread Jonathan Liu
Hi Priit, On 26 June 2017 at 15:53, Priit Laes wrote: > On Mon, Jun 26, 2017 at 08:05:16AM +1000, Jonathan Liu wrote: >> Hi Priit, >> >> This is showing from clock rate of 171428572 in the output of "cat >> /sys/kernel/debug/clk/clk_summary" for pll-per

Re: [linux-sunxi] [PATCH v4 1/6] clk: sunxi-ng: div: Add support for fixed post-divider

2017-06-25 Thread Jonathan Liu
Hi Priit, This is showing from clock rate of 171428572 in the output of "cat /sys/kernel/debug/clk/clk_summary" for pll-periph-sata. The clock rate should be 1 (100 MHz) when read from the hardware. On 26 June 2017 at 06:45, Priit Laes wrote: > SATA clock on sun4i/sun7i is of type (paren

[PATCH v4] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-23 Thread Jonathan Liu
Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jo

Re: [PATCH v3] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-23 Thread Jonathan Liu
Hi Maxime, On 22 June 2017 at 07:26, Maxime Ripard wrote: > On Wed, Jun 21, 2017 at 07:42:47PM +1000, Jonathan Liu wrote: >> >> +static int wait_fifo_flag_unset(struct sun4i_hdmi *hdmi, u32 flag) >> >> +{ >> >> + /* 1 byte takes 9 clock cycles (8 bit

Re: [PATCH v3] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-21 Thread Jonathan Liu
Hi Maxime, On 21 June 2017 at 18:51, Maxime Ripard wrote: > On Thu, Jun 15, 2017 at 01:29:33AM +1000, Jonathan Liu wrote: >> The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: >> "As in the general case the DDC bus is accessible by the kernel at the I

Re: [PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-21 Thread Jonathan Liu
Hi Maxime, On 21 June 2017 at 18:41, Maxime Ripard wrote: > On Tue, Jun 13, 2017 at 09:53:31PM +1000, Jonathan Liu wrote: >> >> --- /dev/null >> >> +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c >> >> @@ -0,0 +1,163 @@ >> >

[PATCH v3] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-14 Thread Jonathan Liu
Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jo

[PATCH] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-14 Thread Jonathan Liu
Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jo

Re: [PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-13 Thread Jonathan Liu
Hi Maxime, On 13 June 2017 at 21:15, Maxime Ripard wrote: > On Mon, Jun 12, 2017 at 03:52:35PM +1000, Jonathan Liu wrote: >> The drm_get_edid function should be used instead of drm_do_get_edid by >> exposing the DDC bus as an I2C adapter. Implement this for A10s. >> >&

[PATCH] scripts/mkcompile_h: Remove trailing spaces from compiler version

2017-06-12 Thread Jonathan Liu
Improves the output of "cat /proc/version" by getting rid of the trailing space at the end of the compiler version when the kernel is compiled using GCC. Signed-off-by: Jonathan Liu --- scripts/mkcompile_h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkc

[PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-11 Thread Jonathan Liu
The drm_get_edid function should be used instead of drm_do_get_edid by exposing the DDC bus as an I2C adapter. Implement this for A10s. Signed-off-by: Jonathan Liu --- Changes for v2: - Rebased against Maxime's sunxi-drm/for-next branch - Fix up error paths in sun4i_hdmi_bind so that th

Re: [PATCH] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-11 Thread Jonathan Liu
Hi Chen-Yu, On 12 June 2017 at 13:28, Chen-Yu Tsai wrote: > On Mon, Jun 12, 2017 at 10:12 AM, Jonathan Liu wrote: >> The drm_get_edid function should be used instead of drm_do_get_edid by >> exposing the DDC bus as an I2C adapter. Implement this for A10s. > > Nice! It is

[PATCH] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-11 Thread Jonathan Liu
The drm_get_edid function should be used instead of drm_do_get_edid by exposing the DDC bus as an I2C adapter. Implement this for A10s. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/Makefile | 1 + drivers/gpu/drm/sun4i/sun4i_hdmi.h | 11 ++- drivers/gpu/drm/sun4i

Re: [1/2] pwm: sunxi: allow the pwm to finish its pulse before disable

2017-05-04 Thread Jonathan Liu
On 24 September 2016 at 00:03, Olliver Schinagl wrote: > You are welcome, but there's some work still being done in this regard, or > rather, i have to find time to grab a scope and properly check the output. > So expect the proper fix to be coming to a kernel near you soon :) > > Meanwhile, it se

Re: [linux-sunxi] [PATCH v2 1/6] clk: sunxi-ng: Add sun4i/sun7i CCU driver

2017-04-22 Thread Jonathan Liu
Hi Priit, On 27 March 2017 at 04:20, Priit Laes wrote: > +static struct ccu_nkmp pll_ve_clk = { > + .enable = BIT(31), > + .n = _SUNXI_CCU_MULT_OFFSET(8, 5, 0), > + .k = _SUNXI_CCU_MULT(4, 2), > + .m = _SUNXI_CCU_DIV(0, 2), >

Re: [linux-sunxi] [PATCH v2 1/6] clk: sunxi-ng: Add sun4i/sun7i CCU driver

2017-04-22 Thread Jonathan Liu
Hi Priit, On 27 March 2017 at 04:20, Priit Laes wrote: > Introduce a clock controller driver for sun4i A10 and sun7i A20 > series SoCs. > > Signed-off-by: Priit Laes > --- > drivers/clk/sunxi-ng/Kconfig | 13 +- > drivers/clk/sunxi-ng/Makefile |1 +- > dri

Re: [PATCH V5 2/3] ACPI: pci_link: penalize SCI correctly

2016-10-23 Thread Jonathan Liu
_irq(int irq, int trigger, int polarity); > void acpi_pci_irq_disable (struct pci_dev *dev); > > extern int ec_read(u8 addr, u8 *val); > -- > 1.9.1 > This series fixes one or more network adapters not working in Linux 32-bit x86 guest running inside VirtualBox if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

Re: [PATCH V5 3/3] ACPI: pci_link: Include PIRQ_PENALTY_PCI_USING for ISA IRQs

2016-10-23 Thread Jonathan Liu
ng inside VirtualBox if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

Re: [PATCH V5 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages

2016-10-23 Thread Jonathan Liu
rk adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

Re: [V4, 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages

2016-10-23 Thread Jonathan Liu
On 24 October 2016 at 15:17, Sinan Kaya wrote: > Thanks, > > On 10/22/2016 11:48 PM, Jonathan Liu wrote: >> This series fixes one or more network adapters not working in Linux >> 32-bit x86 guest running inside VirtualBox if I have 4 network >> adapters enabled. The

Re: [V4,2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-22 Thread Jonathan Liu
> +++ b/include/linux/acpi.h > @@ -318,6 +318,7 @@ struct pci_dev; > int acpi_pci_irq_enable (struct pci_dev *dev); > void acpi_penalize_isa_irq(int irq, int active); > bool acpi_isa_irq_available(int irq); > +void acpi_penalize_sci_irq(int irq, int trigger, int polarity); > void acpi_pci_irq_disable (struct pci_dev *dev); > > extern int ec_read(u8 addr, u8 *val); This series fixes one or more network adapters not working in Linux 32-bit x86 guest running inside VirtualBox if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

Re: [V4,3/3] Revert "ACPI,PCI,IRQ: separate ISA penalty calculation"

2016-10-22 Thread Jonathan Liu
index, int > *triggering, >int *polarity, char **name); > int acpi_pci_link_free_irq(acpi_handle handle); This series fixes one or more network adapters not working in Linux 32-bit x86 guest running inside VirtualBox if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

Re: [V4, 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages

2016-10-22 Thread Jonathan Liu
] + > (active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING); > } > This series fixes one or more network adapters not working in Linux 32-bit x86 guest running inside VirtualBox if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

Re: [linux-sunxi] [PATCH v5 3/4] Documentation: devicetree: add vendor prefix for Pine64

2016-10-20 Thread Jonathan Liu
On 21 October 2016 at 05:00, Maxime Ripard wrote: > From: Andre Przywara > > Signed-off-by: Andre Przywara > Acked-by: Rob Herring > Acked-by: Chen-Yu Tsai > [Maxime: Change title prefix to match the usual style] > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/vendor

Re: [1/3] Revert "ACPI,PCI,IRQ: reduce static IRQ array size to 16"

2016-10-03 Thread Jonathan Liu
On 3 October 2016 at 12:07, Sinan Kaya wrote: > On 10/2/2016 7:40 AM, Jonathan Liu wrote: >> This series fixes one or more network adapters in VirtualBox not >> working with Linux 32-bit x86 guest if I have 4 network adapters >> enabled. The following message no longer appe

Re: [3/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-02 Thread Jonathan Liu
irq); > +void acpi_penalize_sci_irq(int irq, int trigger, int polarity); > void acpi_pci_irq_disable (struct pci_dev *dev); > > extern int ec_read(u8 addr, u8 *val); This series fixes one or more network adapters in VirtualBox not working with Linux 32-bit x86 guest if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

Re: [2/3] ACPI, PCI IRQ: add PCI_USING penalty for ISA interrupts

2016-10-02 Thread Jonathan Liu
86 guest if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

Re: [1/3] Revert "ACPI,PCI,IRQ: reduce static IRQ array size to 16"

2016-10-02 Thread Jonathan Liu
TY_PCI_USING); > } > > bool acpi_isa_irq_available(int irq) > { > - return irq >= 0 && (irq >= ARRAY_SIZE(acpi_isa_irq_penalty) || > + return irq >= 0 && (irq >= ARRAY_SIZE(acpi_irq_penalty) || > acpi_irq_get_penalty(irq) < PIRQ_PENALTY_ISA_ALWAYS); > } > This series fixes one or more network adapters in VirtualBox not working with Linux 32-bit x86 guest if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu

[PATCH][v2] drm/sun4i: rgb: Enable panel after controller

2016-09-26 Thread Jonathan Liu
The panel should be enabled after the controller so that we do not have visual glitches on the panel while the controller is setup. Similarly, the panel should be disabled before the controller. Signed-off-by: Jonathan Liu --- Changes in v2: - Changed the commit message to be clearer drivers

Re: [1/2] pwm: sunxi: allow the pwm to finish its pulse before disable

2016-09-23 Thread Jonathan Liu
wm->ctrl_lock); > + val = sun4i_pwm_readl(sun4i_pwm, PWM_CTRL_REG); > val &= ~BIT_CH(PWM_CLK_GATING, pwm->hwpwm); > sun4i_pwm_writel(sun4i_pwm, val, PWM_CTRL_REG); > spin_unlock(&sun4i_pwm->ctrl_lock); I had some issues where setting the brightness for pwm-backlight to 0 was not turning off the backlight sometimes. This patch fixes the issue for me. Thanks. Tested-by: Jonathan Liu

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-23 Thread Jonathan Liu
Hi Maxime, On 23 September 2016 at 23:16, Maxime Ripard wrote: > On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On Thursday, 22 September 2016, Maxime Ripard > com> wrote: >> >> > On Wed, Sep 21, 2016 at 11:03:04PM +

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-21 Thread Jonathan Liu
Hi Maxime, On 22 September 2016 at 07:03, Maxime Ripard wrote: > On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: >> The panel should be enabled after the controller so that the panel >> prepare/enable delays are properly taken into account. Similarly, the >

[PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-21 Thread Jonathan Liu
glitches. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_rgb.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c index c3ff10f..4e4bea6 100644 --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c

[PATCH] drm/panel: simple: Fix bus_format for the Olimex LCD-OLinuXino-4.3TS

2016-09-11 Thread Jonathan Liu
The format is RGB888 not RGB666. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..d4aa68e 100644 --- a/drivers/gpu

[PATCH] drm/sun4i: rgb: add missing calls to drm_panel_{prepare,unprepare}

2016-08-29 Thread Jonathan Liu
If the enable-gpios property of a simple panel in device tree is set, the GPIO is not toggled on/off because of missing calls to drm_panel_prepare and drm_panel_unprepare. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

Re: [linux-sunxi] [PATCH 11/19] drm: sun4i: Add composite output

2015-11-01 Thread Jonathan Liu
On 31 October 2015 at 01:20, Maxime Ripard wrote: > Some Allwinner SoCs have an IP called the TV encoder that is used to output > composite and VGA signals. In such a case, we need to use the second TCON > channel. > > Add support for that TV encoder. > > Signed-off-by: Maxime Ripard > --- > dri