[PATCH net-next] bnxt: remove printing of hwrm message

to not confuse users as this message is really not very informative. Signed-off-by: Jonathan Toppins --- Notes: v2: include changes recommended by Michael Chan drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net

Re: [PATCH net] tg3: prevent scheduling while atomic splat

On 03/14/2018 01:22 PM, Michael Chan wrote: > On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins <jtopp...@redhat.com> wrote: >> The problem was introduced in commit >> 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs >> because tp->

Re: [PATCH net] tg3: prevent scheduling while atomic splat

On 03/14/2018 01:22 PM, Michael Chan wrote: > On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: >> The problem was introduced in commit >> 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs >> because tp->lock spinlock is held which

[PATCH net] tg3: prevent scheduling while atomic splat

e used inside a spinlock. Fixes: 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes") Signed-off-by: Jonathan Toppins <jtopp...@redhat.com> --- Notes: The thing I need reviewed from Broadcom is if the udelay should be 20 instead of 10, due to any timing changes introduced by the o

[PATCH net] tg3: prevent scheduling while atomic splat

e used inside a spinlock. Fixes: 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes") Signed-off-by: Jonathan Toppins --- Notes: The thing I need reviewed from Broadcom is if the udelay should be 20 instead of 10, due to any timing changes introduced by the offending patch.

Re: [PATCH] arm64/acpi: make ACPI boot preference configurable

On 02/27/2018 07:40 AM, Bhupesh Sharma wrote: > Hi, > > On Tue, Feb 27, 2018 at 11:35 AM, Jonathan Toppins <jtopp...@redhat.com> > wrote: >> This patch allows a user to configure ACPI to be preferred over >> device-tree. >> >> Currently for ACP

Re: [PATCH] arm64/acpi: make ACPI boot preference configurable

On 02/27/2018 07:40 AM, Bhupesh Sharma wrote: > Hi, > > On Tue, Feb 27, 2018 at 11:35 AM, Jonathan Toppins > wrote: >> This patch allows a user to configure ACPI to be preferred over >> device-tree. >> >> Currently for ACPI to be used a user either has to

Re: [PATCH] arm64/acpi: make ACPI boot preference configurable

On 02/27/2018 02:22 AM, Ard Biesheuvel wrote: > Hi Jonathan, > > On 27 February 2018 at 06:05, Jonathan Toppins <jtopp...@redhat.com> wrote: >> This patch allows a user to configure ACPI to be preferred over >> device-tree. >> > > This comes up once a ye

Re: [PATCH] arm64/acpi: make ACPI boot preference configurable

On 02/27/2018 02:22 AM, Ard Biesheuvel wrote: > Hi Jonathan, > > On 27 February 2018 at 06:05, Jonathan Toppins wrote: >> This patch allows a user to configure ACPI to be preferred over >> device-tree. >> > > This comes up once a year or so, and the consensus ha

[PATCH] arm64/acpi: make ACPI boot preference configurable

will be chosen as the boot method of choice even if it is not correct. To prevent this situation where a system is only intended to be booted via ACPI a user can set this kernel configuration so it ignores device-tree settings unless ACPI table checks fail. Signed-off-by: Jonathan Toppins <jt

[PATCH] arm64/acpi: make ACPI boot preference configurable

will be chosen as the boot method of choice even if it is not correct. To prevent this situation where a system is only intended to be booted via ACPI a user can set this kernel configuration so it ignores device-tree settings unless ACPI table checks fail. Signed-off-by: Jonathan Toppins --- arch/arm64

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

t; Delete two error messages for a failed memory allocation > Use common error handling code > > drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > I like it. Acked-by: Jonathan Toppins <jtopp...@redhat.com>

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

emory allocation > Use common error handling code > > drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > I like it. Acked-by: Jonathan Toppins

[rdma for-next] bnxt_re: report RoCE device support at info level

Reporting that a device doesn't support RoCE seems like a valuable piece of information to have when trying to determine why a driver is not binding to a device. Better to report this at info log level instead of requiring a user to enable all debug messages in the driver. Signed-off-by: Jonathan

[rdma for-next] bnxt_re: report RoCE device support at info level

Reporting that a device doesn't support RoCE seems like a valuable piece of information to have when trying to determine why a driver is not binding to a device. Better to report this at info log level instead of requiring a user to enable all debug messages in the driver. Signed-off-by: Jonathan

[PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

Instead of zeroing out bnxt_tc.c with a #ifdef foo, instead don't compile the file when the option is not enabled. Now make and the preprocessor do not have to waste time compiling a no-op. Signed-off-by: Jonathan Toppins <jtopp...@redhat.com> --- drivers/net/ethernet/broadcom/bnxt/Makefil

[PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

Instead of zeroing out bnxt_tc.c with a #ifdef foo, instead don't compile the file when the option is not enabled. Now make and the preprocessor do not have to waste time compiling a no-op. Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/broadcom/bnxt/Makefile | 3 ++- drivers/net

[PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

There is no reason to wrap the data structures inside the ifdef. Signed-off-by: Jonathan Toppins <jtopp...@redhat.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h b/d

[PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

There is no reason to wrap the data structures inside the ifdef. Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h b/drivers/net/ethernet/broadcom

[PATCH] mm: ratelimit PFNs busy info message

The RDMA subsystem can generate several thousand of these messages per second eventually leading to a kernel crash. Ratelimit these messages to prevent this crash. Signed-off-by: Jonathan Toppins <jtopp...@redhat.com> Reviewed-by: Doug Ledford <dledf...@redhat.com> Tested-by: Doug Le

[PATCH] mm: ratelimit PFNs busy info message

The RDMA subsystem can generate several thousand of these messages per second eventually leading to a kernel crash. Ratelimit these messages to prevent this crash. Signed-off-by: Jonathan Toppins Reviewed-by: Doug Ledford Tested-by: Doug Ledford --- mm/page_alloc.c | 2 +- 1 file changed, 1

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

On 06/13/2017 12:21 PM, Joe Perches wrote: > On Tue, 2017-06-13 at 11:34 -0400, David Miller wrote: >> From: Michael Dilmore >> Date: Tue, 13 Jun 2017 14:42:46 +0100 >> >>> The packets per slave parameter used by round robin mode does not have a >>> printk debug >>>

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

On 06/13/2017 12:21 PM, Joe Perches wrote: > On Tue, 2017-06-13 at 11:34 -0400, David Miller wrote: >> From: Michael Dilmore >> Date: Tue, 13 Jun 2017 14:42:46 +0100 >> >>> The packets per slave parameter used by round robin mode does not have a >>> printk debug >>> message in its set function

Re: [PATCH v2 pci] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1

On 04/27/2017 08:54 PM, Khuong Dinh wrote: > From: Khuong Dinh > > This patch makes pci-xgene-msi driver ACPI-aware and provides > MSI capability for X-Gene v1 PCIe controllers in ACPI boot mode. > > Signed-off-by: Khuong Dinh > Signed-off-by: Duc Dang

Re: [PATCH v2 pci] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1

On 04/27/2017 08:54 PM, Khuong Dinh wrote: > From: Khuong Dinh > > This patch makes pci-xgene-msi driver ACPI-aware and provides > MSI capability for X-Gene v1 PCIe controllers in ACPI boot mode. > > Signed-off-by: Khuong Dinh > Signed-off-by: Duc Dang > Acked-by: Marc Zyngier > --- > v2: >

[RFC] arm64/acpi: make ACPI boot preference configurable

will be chosen as the boot method of choice even if it is not correct. To prevent this situation where a system is only intended to be booted via ACPI a user can set this kernel configuration so it ignores device-tree settings unless ACPI table checks fail. Signed-off-by: Jonathan Toppins <jt

[RFC] arm64/acpi: make ACPI boot preference configurable

will be chosen as the boot method of choice even if it is not correct. To prevent this situation where a system is only intended to be booted via ACPI a user can set this kernel configuration so it ignores device-tree settings unless ACPI table checks fail. Signed-off-by: Jonathan Toppins --- arch/arm64

Re: [PATCH 3.2 000/110] 3.2.71-rc1 review

On 08/10/2015 06:12 AM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.71 release. There are 110 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 3.2 000/110] 3.2.71-rc1 review

On 08/10/2015 06:12 AM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.71 release. There are 110 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made