Re: [PATCH] z3fold: fix wrong handling of headless pages

Yes, you are right. I think that's the best way to deal it. Thank you. Best regards, Jongseok > Den tors 8 nov. 2018 kl 13:34 skrev �� : > > > > Hi Vitaly, > > thank you for the reply. > > > > I agree your a new solution is more comprehensive and drop my patch is > > simple way. > > But, I

Re: [PATCH] z3fold: fix wrong handling of headless pages

Yes, you are right. I think that's the best way to deal it. Thank you. Best regards, Jongseok > Den tors 8 nov. 2018 kl 13:34 skrev �� : > > > > Hi Vitaly, > > thank you for the reply. > > > > I agree your a new solution is more comprehensive and drop my patch is > > simple way. > > But, I

[PATCH] z3fold: fix wrong handling of headless pages

these problems. Signed-off-by: Jongseok Kim --- mm/z3fold.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 4b366d1..201a8ac 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -746,6 +746,9 @@ static void z3fold_free(struct z3fold_pool *pool

[PATCH] z3fold: fix wrong handling of headless pages

these problems. Signed-off-by: Jongseok Kim --- mm/z3fold.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 4b366d1..201a8ac 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -746,6 +746,9 @@ static void z3fold_free(struct z3fold_pool *pool

RE: [PATCH v2] z3fold: fix reclaim lock-ups

A headless page also need to be set UNDER_RECLAIM in previous reply, but I missed it. --- mm/z3fold.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 5f659ab..8536a47 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -849,10 +849,10 @@ static int

RE: [PATCH v2] z3fold: fix reclaim lock-ups

A headless page also need to be set UNDER_RECLAIM in previous reply, but I missed it. --- mm/z3fold.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 5f659ab..8536a47 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -849,10 +849,10 @@ static int

Re: [PATCH v2] z3fold: fix reclaim lock-ups

> Hi Jongseok, > I don't see how that is relevant, we don't use zhdr variable if the page is headless anyway. > Thanks, that is indeed a valid fix, but given the operation of eviction in > zswap case, I'd prefer to release the page here and not in _free(). > Basically we should bail very early

Re: [PATCH v2] z3fold: fix reclaim lock-ups

> Hi Jongseok, > I don't see how that is relevant, we don't use zhdr variable if the page is headless anyway. > Thanks, that is indeed a valid fix, but given the operation of eviction in > zswap case, I'd prefer to release the page here and not in _free(). > Basically we should bail very early

[PATCH v2] z3fold: fix reclaim lock-ups

-by: Jongseok Kim <ks7...@gmail.com> --- mm/z3fold.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index d5b3f49..a36ffa5ab 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -819,6 +819,7 @@ static void z3fold_free(struct z3fold_pool *pool, un

[PATCH v2] z3fold: fix reclaim lock-ups

-by: Jongseok Kim --- mm/z3fold.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index d5b3f49..a36ffa5ab 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -819,6 +819,7 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle