Re: [PATCH] software node: recursively unregister child swnodes

2020-06-05 Thread Jordan Hand
On 6/5/20 12:54 AM, Greg Kroah-Hartman wrote: Right now, the way the driver model and sysfs/kobjects work is that all objects must be removed in child-first order. The problem of your change where you want to try to remove the devices in parent-first order is that you do not really know if yo

Re: [PATCH] software node: recursively unregister child swnodes

2020-06-04 Thread Jordan Hand
On 6/4/20 1:57 PM, Jordan Hand wrote: On 6/4/20 1:15 PM, Greg Kroah-Hartman wrote: On Thu, Jun 04, 2020 at 12:36:23PM -0700, jorh...@linux.microsoft.com That said, I suppose just ordering the nodes so that children come before parents would also be fine. My thinking was just that accepting

Re: [PATCH] software node: recursively unregister child swnodes

2020-06-04 Thread Jordan Hand
On 6/4/20 1:15 PM, Greg Kroah-Hartman wrote: On Thu, Jun 04, 2020 at 12:36:23PM -0700, jorh...@linux.microsoft.com wrote: From: Jordan Hand If a child swnode is unregistered after it's parent, it can lead to undefined behavior. Crashing the system is not really "undefined"

Re: [PATCH v29 00/20] Intel SGX foundations

2020-05-08 Thread Jordan Hand
On 5/7/20 11:06 AM, Dr. Greg wrote: On Wed, May 06, 2020 at 09:39:55AM -0700, Jordan Hand wrote: Good afternoon, I hope the week is going well for everyone. On 4/21/20 2:52 PM, Jarkko Sakkinen wrote: Make the vDSO callable directly from C by preserving RBX and taking leaf from RCX

Re: [PATCH v29 00/20] Intel SGX foundations

2020-05-06 Thread Jordan Hand
serving RBX and taking leaf from RCX. Tested with the Open Enclave SDK on top of Intel PSW. Specifically built the Intel PSW with changes to support /dev/sgx mapping[1] new in v29. Tested-by: Jordan Hand [1] https://github.com/intel/linux-sgx/pull/530

Re: [PATCH v4] tpm: Parse event log from TPM2 ACPI table

2019-09-03 Thread Jordan Hand
On 9/3/19 11:27 AM, Jerry Snitselaar wrote: >> +    len = tpm2_trailer.minimum_log_length; >> +    start = tpm2_trailer.log_address; > > Are your builds not failing here? Both v3 and v4 have this. > Ya, I saw the kbuild bot failure and fixed in v5. I'm not entirely sure why I didn't catc

[PATCH v5] tpm: Parse event log from TPM2 ACPI table

2019-09-03 Thread Jordan Hand
PM is version 2.0 to denote (among other metadata) the location of the crypto-agile log. Link: https://trustedcomputinggroup.org/resource/tcg-acpi-specification/ Signed-off-by: Jordan Hand --- Notes: Changelog v2: - Fix compile error Changelog v3: - Fix commit message to be

[PATCH v4] tpm: Parse event log from TPM2 ACPI table

2019-08-30 Thread Jordan Hand
PM is version 2.0 to denote (among other metadata) the location of the crypto-agile log. Link: https://trustedcomputinggroup.org/resource/tcg-acpi-specification/ Signed-off-by: Jordan Hand --- drivers/char/tpm/eventlog/acpi.c | 60 ++-- 1 file changed, 41 insertions(+

Re: [PATCH] sefltest/ima: support appended signatures (modsig)

2019-08-29 Thread Jordan Hand
On 8/28/19 5:39 AM, Mimi Zohar wrote: > Detect and allow appended signatures. Ran the tests successfully on x86_64 QEMU Reviewed-by: Jordan Hand Tested-by: Jordan Hand

[PATCH v3] tpm: Get TCG log from TPM2 ACPI table for tpm2 systems

2019-06-24 Thread Jordan Hand
From: Jordan Hand For TPM2-based systems, retrieve the TCG log from the TPM2 ACPI table. The TPM2 ACPI table is defined in section 7.3 of the TCG ACPI Specification (see link). The TPM2 table is used primarily by legacy BIOS in place of the TCPA table when the system's TPM is version 2

[PATCH v2] tpm: Get TCG log from TPM2 ACPI table for tpm2 systems

2019-06-23 Thread Jordan Hand
For TPM2-based systems, retrieve the TCG log from the TPM2 ACPI table. Signed-off-by: Jordan Hand --- v2: - Apologies, v1 had a silly compile error drivers/char/tpm/eventlog/acpi.c | 67 +++- 1 file changed, 48 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH] tpm: Get TCG log from TPM2 ACPI table for tpm2 systems

2019-06-23 Thread Jordan Hand
For TPM2-based systems, retrieve the TCG log from the TPM2 ACPI table. Signed-off-by: Jordan Hand --- drivers/char/tpm/eventlog/acpi.c | 67 +++- 1 file changed, 48 insertions(+), 19 deletions(-) diff --git a/drivers/char/tpm/eventlog/acpi.c b/drivers/char/tpm