RE: linux-next: Tree for Oct 15 (drivers/net/pcs/pcs-xpcs.o)

2020-10-15 Thread Jose Abreu
From: Randy Dunlap Date: Oct/15/2020, 15:45:57 (UTC+00:00) > On 10/15/20 12:28 AM, Stephen Rothwell wrote: > > Hi all, > > > > Since the merge window is open, please do not add any v5.11 material to > > your linux-next included branches until after v5.10-rc1 has been released. > > > > News:

RE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version

2020-06-12 Thread Jose Abreu
From: Alim Akhtar Date: Jun/10/2020, 04:39:48 (UTC+00:00) > Are you still on this? Yes, apologies but I was caught on some other things. I'll try to re-submit once possible. --- Thanks, Jose Miguel Abreu

RE: [PATCH net-next 7/8] net: phy: Add Synopsys DesignWare XPCS MDIO module

2020-06-09 Thread Jose Abreu
From: Russell King - ARM Linux admin Date: Jun/05/2020, 18:10:34 (UTC+00:00) > This is incorrect - you should not mask the link partner's advertisement > with our advertisement like this; consider the table in 802.3 for > resolving the pause modes, where simply doing a bitwise-and operation >

RE: [PATCH] net: stmmac: Fix RX Coalesce IOC always true issue

2020-06-09 Thread Jose Abreu
From: Biao Huang Date: Jun/09/2020, 10:41:33 (UTC+00:00) > - rx_q->rx_count_frames += priv->rx_coal_frames; > - if (rx_q->rx_count_frames > priv->rx_coal_frames) > + if (rx_q->rx_count_frames >= priv->rx_coal_frames) This is no right. If you want to RX IC bit

RE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version

2020-04-30 Thread Jose Abreu
From: Bean Huo (beanhuo) Date: Apr/29/2020, 13:59:08 (UTC+00:00) > > > > @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void > > > > __iomem *mmio_base, unsigned int irq) > > > > if ((hba->ufs_version != UFSHCI_VERSION_10) && > > > > (hba->ufs_version !=

RE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version

2020-04-29 Thread Jose Abreu
From: Bean Huo (beanhuo) Date: Apr/24/2020, 16:57:07 (UTC+00:00) > Hi, Jose > > > @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem > > *mmio_base, unsigned int irq) > > if ((hba->ufs_version != UFSHCI_VERSION_10) && > > (hba->ufs_version != UFSHCI_VERSION_11)

RE: [PATCH] ARC: guard dsp early init against non ARCv2

2020-04-29 Thread Jose Abreu
From: Eugeniy Paltsev Date: Apr/28/2020, 19:50:24 (UTC+00:00) > As of today we guard early DSP init code with > ARC_AUX_DSP_BUILD (0x7A) BCR check to verify that we have > CPU with DSP configured. However that's not enough as in > ARCv1 CPU the same BCR (0x7A) is used for checking MUL/MAC >

RE: [PATCH net-next 2/2] net: phy: Add ability to debug RGMII connections

2019-10-16 Thread Jose Abreu
From: Florian Fainelli Date: Oct/15/2019, 23:49:53 (UTC+00:00) > The function phy_rgmii_debug_probe() could also be used by an Ethernet > controller during its selftests routines instead of open-coding that > part. I can add it to stmmac selftests then :) > +int phy_rgmii_debug_probe(struct

[RFT] stmmac Selftests

2019-10-07 Thread Jose Abreu
Hi stmmac users, Since 091810dbded9 ("net: stmmac: Introduce selftests support"), the stmmac driver supports ethtool selftests that can help diagnose HW mis-configurations and SW programming issues. I would like to request all stmmac users to try running these tests and send the output to

RE: [PATCH net-next] net: stmmac: Fix sparse warning

2019-10-07 Thread Jose Abreu
From: David Miller Date: Oct/07/2019, 15:14:26 (UTC+00:00) > From: Jose Abreu > Date: Mon, 7 Oct 2019 15:16:08 +0200 > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > index 8b7674

[PATCH net-next] net: stmmac: Fix sparse warning

2019-10-07 Thread Jose Abreu
The VID is converted to le16 so the variable must be __le16 type. Reported-by: kbuild test robot Fixes: c7ab0b8088d7 ("net: stmmac: Fallback to VLAN Perfect filtering if HASH is not available") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose

[PATCH net-next 2/3] net: stmmac: selftests: Add tests for VLAN Perfect Filtering

2019-10-06 Thread Jose Abreu
From: Jose Abreu Add two new tests for VLAN Perfect Filtering. While at it, increase a little bit the tests strings lenght so that we can have more descriptive test names. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller

[PATCH net-next 1/3] net: stmmac: Fallback to VLAN Perfect filtering if HASH is not available

2019-10-06 Thread Jose Abreu
From: Jose Abreu If VLAN Hash Filtering is not available we can fallback to perfect filtering instead. Let's implement this in XGMAC and GMAC cores and let the user use this filter. VLAN VID=0 always passes filter so we check if more than 2 VLANs are created and return proper error code if so

[PATCH net-next 3/3] net: stmmac: Implement L3/L4 Filters in GMAC4+

2019-10-06 Thread Jose Abreu
From: Jose Abreu GMAC4+ cores support Layer 3 and Layer 4 filtering. Add the corresponding callbacks in these cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc

[PATCH net-next 0/3] net: stmmac: Improvements for -next

2019-10-06 Thread Jose Abreu
Improvements for -next. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: li

[PATCH net 2/3] net: stmmac: gmac4+: Not all Unicast addresses may be available

2019-10-06 Thread Jose Abreu
Some setups may not have all Unicast addresses filters available. Check the number of available filters before trying to setup it. Fixes: 477286b53f55 ("stmmac: add GMAC4 core support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc

[PATCH net 1/3] net: stmmac: selftests: Check if filtering is available before running

2019-10-06 Thread Jose Abreu
We need to check if the number of available Hash Filters is enough to run the test, otherwise we will get false failures. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc

[PATCH net 3/3] net: stmmac: selftests: Fix L2 Hash Filter test

2019-10-06 Thread Jose Abreu
With the current MAC addresses hard-coded in the test we can get some false positives as we use the Hash Filtering method. Let's change the MAC addresses in the tests to be unique when hashed. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abre

[PATCH net 0/3] net: stmmac: Fixes for -net

2019-10-06 Thread Jose Abreu
Fixes for -net. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.

RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

2019-10-02 Thread Jose Abreu
From: Hans Andersson Date: Oct/02/2019, 09:02:02 (UTC+00:00) > We assert / de-assert the reset line, but the CPU is too fast and the IP is > still > in reset when we later try to read user ID / Synopsys ID. Another option would > be to add a delay after we reset. Then I think you should fix

RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

2019-10-02 Thread Jose Abreu
From: Hans Andersson Date: Oct/02/2019, 08:07:21 (UTC+00:00) > When we read user ID / Synopsys ID we might still be in reset, > so read muliple times if needed. We shouldn't even try to read it if IP is in reset ... --- Thanks, Jose Miguel Abreu

[PATCH v2 net 5/9] net: stmmac: Correctly take timestamp for PTPv2

2019-09-30 Thread Jose Abreu
The case for PTPV2_EVENT requires event packets to be captured so add this setting to the list of enabled captures. Fixes: 891434b18ec0 ("stmmac: add IEEE PTPv1 and PTPv2 support.") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "

[PATCH v2 net 7/9] net: stmmac: xgmac: Disable the Timestamp interrupt by default

2019-09-30 Thread Jose Abreu
We don't use it anyway as XGMAC only supports polling for timestamp (in current SW implementation). This greatly reduces the system load by reducing the number of interrupts. Fixes: 2142754f8b9c ("net: stmmac: Add MAC related callbacks for XGMAC2") Signed-off-by: Jose Abreu --- Cc

[PATCH v2 net 6/9] net: stmmac: Do not stop PHY if WoL is enabled

2019-09-30 Thread Jose Abreu
f-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/eth

[PATCH v2 net 1/9] net: stmmac: xgmac: Not all Unicast addresses may be available

2019-09-30 Thread Jose Abreu
Some setups may not have all Unicast addresses filters available. Let's check this before trying to setup filters. Fixes: 0efedbf11f07 ("net: stmmac: xgmac: Fix XGMAC selftests") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "

[PATCH v2 net 9/9] net: stmmac: xgmac: Fix RSS writing wrong keys

2019-09-30 Thread Jose Abreu
try to write past the keys size. Fixes: b6b6cc9acd7b ("net: stmmac: selftest: avoid large stack usage") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.or

[PATCH v2 net 0/9] net: stmmac: Fixes for -net

2019-09-30 Thread Jose Abreu
Misc fixes for -net tree. More info in commit logs. v2 is just a rebase of v1 against -net and we added a new patch (09/09) to fix RSS feature. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc

[PATCH v2 net 2/9] net: stmmac: xgmac: Detect Hash Table size dinamically

2019-09-30 Thread Jose Abreu
Since commit b8ef7020d6e5 ("net: stmmac: add support for hash table size 128/256 in dwmac4"), we can detect the Hash Table dinamically. Let's implement this feature in XGMAC cores and fix possible setups that don't support the maximum size for Hash Table. Signed-off-by: Jose Abre

[PATCH v2 net 3/9] net: stmmac: selftests: Always use max DMA size in Jumbo Test

2019-09-30 Thread Jose Abreu
tmmac: selftests: Add Jumbo Frame tests") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.

[PATCH v2 net 4/9] net: stmmac: dwmac4: Always update the MAC Hash Filter

2019-09-30 Thread Jose Abreu
We need to always update the MAC Hash Filter so that previous entries are invalidated. Found out while running stmmac selftests. Fixes: b8ef7020d6e5 ("net: stmmac: add support for hash table size 128/256 in dwmac4") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexan

[PATCH v2 net 8/9] net: stmmac: xgmac: Fix RSS not writing all Keys to HW

2019-09-30 Thread Jose Abreu
it in XGMAC core") Reviewed-by: Nick Desaulniers Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lis

RE: [PATCH net 0/8] net: stmmac: Fixes for -net

2019-09-28 Thread Jose Abreu
From: Jose Abreu Date: Sep/27/2019, 08:48:48 (UTC+00:00) > Misc fixes for -net tree. More info in commit logs. David, please do not apply these. I forgot to rebase my tree against -net and this was based on -next. I'll resend. Sorry for the mess :( --- Thanks, Jose Miguel Abreu

[PATCH net 6/8] net: stmmac: Do not stop PHY if WoL is enabled

2019-09-27 Thread Jose Abreu
f-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/eth

[PATCH net 7/8] net: stmmac: xgmac: Disable the Timestamp interrupt by default

2019-09-27 Thread Jose Abreu
We don't use it anyway as XGMAC only supports polling for timestamp (in current SW implementation). This greatly reduces the system load by reducing the number of interrupts. Fixes: 2142754f8b9c ("net: stmmac: Add MAC related callbacks for XGMAC2") Signed-off-by: Jose Abreu --- Cc

[PATCH net 0/8] net: stmmac: Fixes for -net

2019-09-27 Thread Jose Abreu
Misc fixes for -net tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: li

[PATCH net 4/8] net: stmmac: dwmac4: Always update the MAC Hash Filter

2019-09-27 Thread Jose Abreu
We need to always update the MAC Hash Filter so that previous entries are invalidated. Found out while running stmmac selftests. Fixes: b8ef7020d6e5 ("net: stmmac: add support for hash table size 128/256 in dwmac4") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexan

[PATCH net 1/8] net: stmmac: xgmac: Not all Unicast addresses may be available

2019-09-27 Thread Jose Abreu
Some setups may not have all Unicast addresses filters available. Let's check this before trying to setup filters. Fixes: 0efedbf11f07 ("net: stmmac: xgmac: Fix XGMAC selftests") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "

[PATCH net 2/8] net: stmmac: xgmac: Detect Hash Table size dinamically

2019-09-27 Thread Jose Abreu
Since commit b8ef7020d6e5 ("net: stmmac: add support for hash table size 128/256 in dwmac4"), we can detect the Hash Table dinamically. Let's implement this feature in XGMAC cores and fix possible setups that don't support the maximum size for Hash Table. Signed-off-by: Jose Abre

[PATCH net 5/8] net: stmmac: Correctly take timestamp for PTPv2

2019-09-27 Thread Jose Abreu
The case for PTPV2_EVENT requires event packets to be captured so add this setting to the list of enabled captures. Fixes: 891434b18ec0 ("stmmac: add IEEE PTPv1 and PTPv2 support.") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "

[PATCH net 8/8] net: stmmac: xgmac: Fix RSS not writing all Keys to HW

2019-09-27 Thread Jose Abreu
The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it. Reported-by: kbuild test robot Reported-by: Nick Desaulniers Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC core") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc

[PATCH net 3/8] net: stmmac: selftests: Always use max DMA size in Jumbo Test

2019-09-27 Thread Jose Abreu
tmmac: selftests: Add Jumbo Frame tests") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.

[PATCH net v2] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-23 Thread Jose Abreu
The Flow Control selftest is also available with ASYM Pause. Lets add this check to the test and fix eventual false positive failures. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose

RE: [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-23 Thread Jose Abreu
From: Jose Abreu Date: Sep/23/2019, 08:30:43 (UTC+00:00) > From: Jose Abreu > > The Flow Control selftest is also available with ASYM Pause. Lets add > this check to the test and fix eventual false positive failures. > > Fixes: 091810dbded9 ("net: stmmac: Intr

RE: [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-23 Thread Jose Abreu
From: Jakub Kicinski Date: Sep/22/2019, 22:56:42 (UTC+00:00) > On Thu, 19 Sep 2019 12:09:49 +0200, Jose Abreu wrote: > > The Flow Control selftest is also available with ASYM Pause. Lets add > > this check to the test and fix eventual false positive failures. > > > >

[PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-23 Thread Jose Abreu
From: Jose Abreu The Flow Control selftest is also available with ASYM Pause. Lets add this check to the test and fix eventual false positive failures. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexan

RE: [PATCH] [v2] net: stmmac: selftest: avoid large stack usage

2019-09-19 Thread Jose Abreu
rnd Bergmann > --- > v2: simply configure function, based on feedback from Jose Looks good to me. Thanks for the fix :) Acked-by: Jose Abreu --- Thanks, Jose Miguel Abreu

[PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-19 Thread Jose Abreu
The Flow Control selftest is also available with ASYM Pause. Lets add this check to the test and fix eventual false positive failures. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose

RE: [PATCH] stmmac: selftest: avoid large stack usage

2019-09-19 Thread Jose Abreu
From: Arnd Bergmann Date: Sep/18/2019, 20:54:34 (UTC+00:00) > + if (!cfg || !cfg->enable) { > value &= ~XGMAC_RSSE; > writel(value, ioaddr + XGMAC_RSS_CTRL); > return 0; > } > > for (i = 0; i < (sizeof(cfg->key) / sizeof(u32)); i++) { >

RE: [PATCH] net: stmmac: Fix ASSERT_RTNL() warning on suspend/resume

2019-09-17 Thread Jose Abreu
From: Loys Ollivier Date: Sep/17/2019, 11:02:36 (UTC+00:00) > rtnl_lock needs to be taken before calling phylink_start/stop to lock the > network stack. > Fix ASSERT_RTNL() warnings by protecting such calls with lock/unlock. > > Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove

[PATCH net] net: stmmac: Hold rtnl lock in suspend/resume callbacks

2019-09-13 Thread Jose Abreu
tmmac: Convert to phylink and remove phylib logic") Reported-by: Christophe ROULLIER Tested-by: Christophe ROULLIER Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org C

RE: [PATCH net-next 0/6] net: stmmac: Improvements for -next

2019-09-11 Thread Jose Abreu
From: David Miller Date: Sep/11/2019, 09:21:55 (UTC+00:00) > From: Jose Abreu > Date: Tue, 10 Sep 2019 16:41:21 +0200 > > > Misc patches for -next. It includes: > > - Two fixes for features in -next only > > - New features support for GMAC cores (which includes G

RE: [PATCH net-next 0/6] net: stmmac: Improvements for -next

2019-09-10 Thread Jose Abreu
From: Jose Abreu Date: Sep/10/2019, 15:41:21 (UTC+00:00) > Misc patches for -next. It includes: > - Two fixes for features in -next only > - New features support for GMAC cores (which includes GMAC4 and GMAC5) BTW, just for reference (and because I forgot to attach i

[PATCH net-next 2/6] net: stmmac: Add VLAN HASH filtering support in GMAC4+

2019-09-10 Thread Jose Abreu
Adds the support for VLAN HASH Filtering in GMAC4/5 cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

[PATCH net-next 1/6] net: stmmac: Prevent divide-by-zero

2019-09-10 Thread Jose Abreu
When RX Coalesce settings are set to all zero (which is a valid setting) we will currently get a divide-by-zero error. Fix it. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.ker

[PATCH net-next 4/6] net: stmmac: Add support for SA Insertion/Replacement in GMAC4+

2019-09-10 Thread Jose Abreu
Add the support for Source Address Insertion and Replacement in GMAC4 and GMAC5 cores. Two methods are supported: Descriptor based and register based. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coqueli

[PATCH net-next 5/6] net: stmmac: Add support for VLAN Insertion Offload in GMAC4+

2019-09-10 Thread Jose Abreu
Adds support for TX VLAN Offload using descriptors based features available in GMAC4/5. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stor

[PATCH net-next 0/6] net: stmmac: Improvements for -next

2019-09-10 Thread Jose Abreu
Misc patches for -next. It includes: - Two fixes for features in -next only - New features support for GMAC cores (which includes GMAC4 and GMAC5) --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org

[PATCH net-next 6/6] net: stmmac: ARP Offload for GMAC4+ Cores

2019-09-10 Thread Jose Abreu
Implement the ARP Offload feature in GMAC4 and GMAC5 cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

[PATCH net-next 3/6] net: stmmac: xgmac: Reinitialize correctly a variable

2019-09-10 Thread Jose Abreu
'value' was being or'ed with a value from another register. This is a typo and could cause new written value to be wrong. Fix it. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.ker

[PATCH net-next] net: stmmac: pci: Add HAPS support using GMAC5

2019-09-09 Thread Jose Abreu
Add the support for Synopsys HAPS board that uses GMAC5. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

RE: [PATCH v3 net-next] net: stmmac: Add support for MDIO interrupts

2019-09-06 Thread Jose Abreu
From: Andrew Lunn Date: Sep/06/2019, 15:24:46 (UTC+00:00) > On Fri, Sep 06, 2019 at 01:31:14PM +0000, Jose Abreu wrote: > > From: Voon Weifeng > > Date: Sep/05/2019, 13:05:30 (UTC+00:00) > > > > > DW EQoS v5.xx controllers added capability for interrupt genera

RE: [PATCH v3 net-next] net: stmmac: Add support for MDIO interrupts

2019-09-06 Thread Jose Abreu
From: Voon Weifeng Date: Sep/05/2019, 13:05:30 (UTC+00:00) > DW EQoS v5.xx controllers added capability for interrupt generation > when MDIO interface is done (GMII Busy bit is cleared). > This patch adds support for this interrupt on supported HW to avoid > polling on GMII Busy bit. Better

RE: [RFC net-next v2 4/5] net: phy: introducing support for DWC xPCS logics for EHL & TGL

2019-09-06 Thread Jose Abreu
From: Ong Boon Leong Date: Aug/28/2019, 18:47:21 (UTC+00:00) > xPCS is DWC Ethernet Physical Coding Sublayer that can be integrated with > Ethernet MAC controller and acts as converter between GMII and SGMII. You have to be careful here because xPCS supports much more than these interfaces

[PATCH net-next 5/5] net: stmmac: Limit max speeds of XGMAC if asked to

2019-09-06 Thread Jose Abreu
We may have some SoCs that can't achieve XGMAC max speed. Limit it if asked to. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org

[PATCH net-next 2/5] net: stmmac: selftests: Set RX tail pointer in Flow Control test

2019-09-06 Thread Jose Abreu
We need to set the RX tail pointer so that RX engine starts working again after finishing the Flow Control test. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: lin

[PATCH net-next 0/5] net: stmmac: Improvements and fixes for -next

2019-09-06 Thread Jose Abreu
Improvements and fixes for recently introduced features. All for -next tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: li

[PATCH net-next 1/5] net: stmmac: selftests: Add missing checks for support of SA

2019-09-06 Thread Jose Abreu
Add checks for support of Source Address Insertion/Replacement before running the test. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-arm-ker...@lists.infrad

[PATCH net-next 3/5] net: stmmac: dwmac4: Enable RX Jumbo frame support

2019-09-06 Thread Jose Abreu
We are already doing it by default in the TX path so we can also enable Jumbo Frame support in the RX path independently of MTU value. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coqueli

[PATCH net-next 4/5] net: stmmac: selftests: Add Split Header test

2019-09-06 Thread Jose Abreu
Add a test to validate that Split Header feature is working correctly. It works by using the rececently introduced counter that increments each time a packet with split header is received. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "Da

[PATCH net-next] net: phy: Do not check Link status when loopback is enabled

2019-09-05 Thread Jose Abreu
we can bypass the logic of checking if Link is valid thus saving unecessary reads. Signed-off-by: Jose Abreu --- Cc: Andrew Lunn Cc: Florian Fainelli Cc: Heiner Kallweit Cc: "David S. Miller" Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/phy/phy.c | 6

[PATCH v2 net-next 12/13] net: stmmac: xgmac: Enable RX Jumbo frame support

2019-09-04 Thread Jose Abreu
We are already doing it by default in the TX path so we can also enable Jumbo Frame support in the RX path independently of MTU value. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coqueli

[PATCH v2 net-next 08/13] net: stmmac: Only consider RX error when HW Timestamping is not enabled

2019-09-04 Thread Jose Abreu
Only consider that we have an error when HW Timestamping is not enabled as this can give false positives due to the fact the RX Timestamping in XGMAC and GMAC cores comes from context descriptors. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc

[PATCH v2 net-next 09/13] net: stmmac: ethtool: Let user configure TX coalesce without RIWT

2019-09-04 Thread Jose Abreu
When RX Watchdog is disabled its currently not possible to configure TX coalesce settings. Let user configure it anyway. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org

[PATCH v2 net-next 04/13] net: stmmac: Implement L3/L4 Filters using TC Flower

2019-09-04 Thread Jose Abreu
Implement filters for Layer 3 and Layer 4 using TC Flower API. Add the corresponding callbacks in XGMAC core. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH v2 net-next 13/13] net: stmmac: selftests: Add Jumbo Frame tests

2019-09-04 Thread Jose Abreu
Add a test to validate the Jumbo Frame support in stmmac in single channel and multichannel mode. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH v2 net-next 01/13] net: stmmac: selftests: Return proper error code to userspace

2019-09-04 Thread Jose Abreu
We can do better than just return 1 to userspace. Lets return a proper Linux error code. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH v2 net-next 05/13] net: stmmac: selftests: Add selftest for L3/L4 Filters

2019-09-04 Thread Jose Abreu
Adds the selftests for L3 and L4 filters with DA/SA/DP/SP support. Changes from v1: - Reduce stack usage (kbuild test robot) Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coqueli

[PATCH v2 net-next 10/13] net: stmmac: xgmac: Correct RAVSEL field interpretation

2019-09-04 Thread Jose Abreu
RAVSEL means that only RX side is available for AVB features. As we use both TX and RX features we need to check if RAVSEL is selected and disable AVB if only RX side is available. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. M

[PATCH v2 net-next 03/13] net: stmmac: Do not return error code in TC Initialization

2019-09-04 Thread Jose Abreu
As we can still use the remaining TC callbacks, e.g. CBS. We should not fail in the initialization only because RX Parser is not available. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coqueli

[PATCH v2 net-next 06/13] net: stmmac: xgmac: Implement ARP Offload

2019-09-04 Thread Jose Abreu
Implement the ARP Offload feature in XGMAC cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

[PATCH v2 net-next 00/13] net: stmmac: Improvements for -next

2019-09-04 Thread Jose Abreu
Couple of improvements for -next tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org

[PATCH v2 net-next 07/13] net: stmmac: selftests: Implement the ARP Offload test

2019-09-04 Thread Jose Abreu
Implement a test for ARP Offload feature. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infrad

[PATCH v2 net-next 11/13] net: stmmac: Correctly assing MAX MTU in XGMAC cores case

2019-09-04 Thread Jose Abreu
Maximum MTU for XGMAC cores is 16k thus the check for presence of XGMAC shall be done first in order to assign correct value. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.ker

[PATCH v2 net-next 02/13] net: stmmac: xgmac: Add RBU handling in DMA interrupt

2019-09-04 Thread Jose Abreu
Add the handling of Receive Buffer Unavailable interrupt in the DMA handler of XGMAC cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH net-next 05/13] net: stmmac: selftests: Add selftest for L3/L4 Filters

2019-09-02 Thread Jose Abreu
Adds the selftests for L3 and L4 filters with DA/SA/DP/SP support. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

[PATCH net-next 07/13] net: stmmac: selftests: Implement the ARP Offload test

2019-09-02 Thread Jose Abreu
Implement a test for ARP Offload feature. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infrad

[PATCH net-next 12/13] net: stmmac: xgmac: Enable RX Jumbo frame support

2019-09-02 Thread Jose Abreu
We are already doing it by default in the TX path so we can also enable Jumbo Frame support in the RX path independently of MTU value. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coqueli

[PATCH net-next 13/13] net: stmmac: selftests: Add Jumbo Frame tests

2019-09-02 Thread Jose Abreu
Add a test to validate the Jumbo Frame support in stmmac in single channel and multichannel mode. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH net-next 04/13] net: stmmac: Implement L3/L4 Filters using TC Flower

2019-09-02 Thread Jose Abreu
Implement filters for Layer 3 and Layer 4 using TC Flower API. Add the corresponding callbacks in XGMAC core. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH net-next 01/13] net: stmmac: selftests: Return proper error code to userspace

2019-09-02 Thread Jose Abreu
We can do better than just return 1 to userspace. Lets return a proper Linux error code. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH net-next 06/13] net: stmmac: xgmac: Implement ARP Offload

2019-09-02 Thread Jose Abreu
Implement the ARP Offload feature in XGMAC cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

[PATCH net-next 02/13] net: stmmac: xgmac: Add RBU handling in DMA interrupt

2019-09-02 Thread Jose Abreu
Add the handling of Receive Buffer Unavailable interrupt in the DMA handler of XGMAC cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH net-next 09/13] net: stmmac: ethtool: Let user configure TX coalesce without RIWT

2019-09-02 Thread Jose Abreu
When RX Watchdog is disabled its currently not possible to configure TX coalesce settings. Let user configure it anyway. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org

[PATCH net-next 03/13] net: stmmac: Do not return error code in TC Initialization

2019-09-02 Thread Jose Abreu
As we can still use the remaining TC callbacks, e.g. CBS. We should not fail in the initialization only because RX Parser is not available. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coqueli

[PATCH net-next 10/13] net: stmmac: xgmac: Correct RAVSEL field interpretation

2019-09-02 Thread Jose Abreu
RAVSEL means that only RX side is available for AVB features. As we use both TX and RX features we need to check if RAVSEL is selected and disable AVB if only RX side is available. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. M

[PATCH net-next 08/13] net: stmmac: Only consider RX error when HW Timestamping is not enabled

2019-09-02 Thread Jose Abreu
Only consider that we have an error when HW Timestamping is not enabled as this can give false positives due to the fact the RX Timestamping in XGMAC and GMAC cores comes from context descriptors. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc

[PATCH net-next 11/13] net: stmmac: Correctly assing MAX MTU in XGMAC cores case

2019-09-02 Thread Jose Abreu
Maximum MTU for XGMAC cores is 16k thus the check for presence of XGMAC shall be done first in order to assign correct value. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.ker

[PATCH net-next 00/13] net: stmmac: Improvements for -next

2019-09-02 Thread Jose Abreu
Couple of improvements for -next tree. More info in commit logs. Some of them includes fixes for features that are only in -next tree. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-s

[PATCH net-next v3 02/12] net: stmmac: Prepare to add Split Header support

2019-08-17 Thread Jose Abreu
with unfinished packet (Jakub) - Use napi_alloc_skb() (Jakub) Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: lin

[PATCH net-next v3 09/12] net: stmmac: selftests: Add tests for SA Insertion/Replacement

2019-08-17 Thread Jose Abreu
Add 4 new tests: - SA Insertion (register based) - SA Insertion (descriptor based) - SA Replacament (register based) - SA Replacement (descriptor based) Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "Da

  1   2   3   4   5   6   7   8   9   10   >