[ANNOUNCE] Guilt v0.21

2007-03-04 Thread Josef Sipek
Guilt v0.21 is available for download (once it mirrors out on kernel.org). Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

[ANNOUNCE] Guilt v0.21

2007-03-04 Thread Josef Sipek
Guilt v0.21 is available for download (once it mirrors out on kernel.org). Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

Re: [PATCH] shmem and simple const super_operations

2007-03-01 Thread Josef Sipek
On Thu, Mar 01, 2007 at 07:22:32PM +, Hugh Dickins wrote: > shmem's super_operations were missed from the recent const-ification; > and simple_fill_super()'s, which can share with get_sb_pseudo()'s. > > Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> Acked-by: Josef 'Jeff' Sipek <[EMAIL

Re: [PATCH] shmem and simple const super_operations

2007-03-01 Thread Josef Sipek
On Thu, Mar 01, 2007 at 07:22:32PM +, Hugh Dickins wrote: shmem's super_operations were missed from the recent const-ification; and simple_fill_super()'s, which can share with get_sb_pseudo()'s. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] Acked-by: Josef 'Jeff' Sipek [EMAIL PROTECTED]

Re: [PATCH 2/2] unionfs: fix slab abuses with krealloc

2007-02-22 Thread Josef Sipek
On Thu, Feb 22, 2007 at 02:41:16PM +0200, Pekka J Enberg wrote: > From: Pekka Enberg <[EMAIL PROTECTED]> > > This changes unionfs to use krealloc() for reallocating memory so that > we don't need to play tricks with slab internals. > > Cc: Josef Sipek <[EMAIL PROTECT

Re: [PATCH 1/2] slab: introduce krealloc

2007-02-22 Thread Josef Sipek
On Thu, Feb 22, 2007 at 02:40:22PM +0200, Pekka J Enberg wrote: > From: Pekka Enberg <[EMAIL PROTECTED]> > > This introduce krealloc() that reallocates memory while keeping the > contents unchanged. The allocator avoids reallocation if the new size > fits the currently used cache. I also added a

Re: [PATCH 1/2] slab: introduce krealloc

2007-02-22 Thread Josef Sipek
On Thu, Feb 22, 2007 at 02:40:22PM +0200, Pekka J Enberg wrote: From: Pekka Enberg [EMAIL PROTECTED] This introduce krealloc() that reallocates memory while keeping the contents unchanged. The allocator avoids reallocation if the new size fits the currently used cache. I also added a simple

Re: [PATCH 2/2] unionfs: fix slab abuses with krealloc

2007-02-22 Thread Josef Sipek
On Thu, Feb 22, 2007 at 02:41:16PM +0200, Pekka J Enberg wrote: From: Pekka Enberg [EMAIL PROTECTED] This changes unionfs to use krealloc() for reallocating memory so that we don't need to play tricks with slab internals. Cc: Josef Sipek [EMAIL PROTECTED] Signed-off-by: Pekka Enberg

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-21 Thread Josef Sipek
On Thu, Feb 22, 2007 at 08:18:39AM +0200, Pekka Enberg wrote: > Pekka Enberg wrote: > >The ksize exports we can add later if unionfs is to be merged. > > Actually, we probably don't need it after the krealloc optimizations. I > think we need a new unionfs patch too... :) I'm for it! Josef

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-21 Thread Josef Sipek
On Wed, Feb 21, 2007 at 06:26:57PM -0800, Andrew Morton wrote: > On Wed, 21 Feb 2007 21:00:39 -0500 Josef Sipek <[EMAIL PROTECTED]> wrote: > > > > I can't say more until I've managed to understand your description, which > > > might take a while. > >

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-21 Thread Josef Sipek
On Wed, Feb 21, 2007 at 02:19:44PM -0800, Andrew Morton wrote: > On Tue, 20 Feb 2007 10:13:56 -0500 > Josef Sipek <[EMAIL PROTECTED]> wrote: > > > On Tue, Feb 20, 2007 at 08:37:34AM +0200, Pekka Enberg wrote: > > > On 2/20/07, Adrian Bunk <[EMAIL PROTECTED]>

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-21 Thread Josef Sipek
On Wed, Feb 21, 2007 at 02:19:44PM -0800, Andrew Morton wrote: On Tue, 20 Feb 2007 10:13:56 -0500 Josef Sipek [EMAIL PROTECTED] wrote: On Tue, Feb 20, 2007 at 08:37:34AM +0200, Pekka Enberg wrote: On 2/20/07, Adrian Bunk [EMAIL PROTECTED] wrote: CC fs/unionfs/copyup.o /home

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-21 Thread Josef Sipek
On Wed, Feb 21, 2007 at 06:26:57PM -0800, Andrew Morton wrote: On Wed, 21 Feb 2007 21:00:39 -0500 Josef Sipek [EMAIL PROTECTED] wrote: I can't say more until I've managed to understand your description, which might take a while. It is intended for reallocation of a buffer. The code

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-21 Thread Josef Sipek
On Thu, Feb 22, 2007 at 08:18:39AM +0200, Pekka Enberg wrote: Pekka Enberg wrote: The ksize exports we can add later if unionfs is to be merged. Actually, we probably don't need it after the krealloc optimizations. I think we need a new unionfs patch too... :) I'm for it! Josef Jeff

[ANNOUNCE] Guilt v0.20

2007-02-20 Thread Josef Sipek
Guilt v0.20 is available for download (once it mirrors out on kernel.org). Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-20 Thread Josef Sipek
For the time being, I included it in unionfs.git. I wouldn't mind having this dependency disappear. Thanks, Josef "Jeff" Sipek. -- Once you have their hardware. Never give it back. (The First Rule of Hardware Acquisition) - To unsubscribe from this list: send the line "unsubscribe

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Josef Sipek
On Tue, Feb 20, 2007 at 07:41:25PM +0300, Evgeniy Polyakov wrote: > On Tue, Feb 20, 2007 at 05:27:14PM +0100, bert hubert ([EMAIL PROTECTED]) > wrote: > > I've done so, with some interesting results. Source on > > http://ds9a.nl/tmp/recvtimings.c - be careful to adjust the '3000' divider > > to

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-20 Thread Josef Sipek
On Tue, Feb 20, 2007 at 08:37:34AM +0200, Pekka Enberg wrote: > On 2/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > CC fs/unionfs/copyup.o > >/home/bunk/linux/kernel-2.6/linux-2.6.20-mm2/fs/unionfs/copyup.c: In > >function 'create_parents_named': >

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-20 Thread Josef Sipek
On Tue, Feb 20, 2007 at 08:37:34AM +0200, Pekka Enberg wrote: On 2/20/07, Adrian Bunk [EMAIL PROTECTED] wrote: CC fs/unionfs/copyup.o /home/bunk/linux/kernel-2.6/linux-2.6.20-mm2/fs/unionfs/copyup.c: In function 'create_parents_named':

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Josef Sipek
On Tue, Feb 20, 2007 at 07:41:25PM +0300, Evgeniy Polyakov wrote: On Tue, Feb 20, 2007 at 05:27:14PM +0100, bert hubert ([EMAIL PROTECTED]) wrote: I've done so, with some interesting results. Source on http://ds9a.nl/tmp/recvtimings.c - be careful to adjust the '3000' divider to your CPU

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-20 Thread Josef Sipek
For the time being, I included it in unionfs.git. I wouldn't mind having this dependency disappear. Thanks, Josef Jeff Sipek. -- Once you have their hardware. Never give it back. (The First Rule of Hardware Acquisition) - To unsubscribe from this list: send the line unsubscribe linux-kernel in

[ANNOUNCE] Guilt v0.20

2007-02-20 Thread Josef Sipek
Guilt v0.20 is available for download (once it mirrors out on kernel.org). Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

Re: [PATCH] 9p: add write-cache support to loose cache mode (take 2)

2007-02-15 Thread Josef Sipek
On Thu, Feb 15, 2007 at 08:44:19AM -0600, Eric Van Hensbergen wrote: ... > diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c > index bed48fa..d43d6fb 100644 > --- a/fs/9p/vfs_addr.c > +++ b/fs/9p/vfs_addr.c > @@ -6,6 +6,9 @@ > * Copyright (C) 2005 by Eric Van Hensbergen <[EMAIL PROTECTED]> > *

Re: [PATCH] 9p: add write-cache support to loose cache mode (take 2)

2007-02-15 Thread Josef Sipek
On Thu, Feb 15, 2007 at 08:44:19AM -0600, Eric Van Hensbergen wrote: ... diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c index bed48fa..d43d6fb 100644 --- a/fs/9p/vfs_addr.c +++ b/fs/9p/vfs_addr.c @@ -6,6 +6,9 @@ * Copyright (C) 2005 by Eric Van Hensbergen [EMAIL PROTECTED] *

[ANNOUNCE] Guilt v0.19

2007-02-12 Thread Josef Sipek
Guilt v0.19 is available for download (once it mirrors out on kernel.org). Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

[ANNOUNCE] Guilt v0.19

2007-02-12 Thread Josef Sipek
Guilt v0.19 is available for download (once it mirrors out on kernel.org). Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

Re: [PATCH 013 of 14] knfsd: SUNRPC: support IPv6 addresses in RPC server's UDP receive path.

2007-02-04 Thread Josef Sipek
On Fri, Feb 02, 2007 at 03:40:44PM +1100, NeilBrown wrote: ... > diff .prev/net/sunrpc/svcsock.c ./net/sunrpc/svcsock.c > --- .prev/net/sunrpc/svcsock.c2007-02-02 15:22:40.0 +1100 > +++ ./net/sunrpc/svcsock.c2007-02-02 15:22:58.0 +1100 > @@ -715,13 +715,55 @@

Re: [PATCH 013 of 14] knfsd: SUNRPC: support IPv6 addresses in RPC server's UDP receive path.

2007-02-04 Thread Josef Sipek
On Fri, Feb 02, 2007 at 03:40:44PM +1100, NeilBrown wrote: ... diff .prev/net/sunrpc/svcsock.c ./net/sunrpc/svcsock.c --- .prev/net/sunrpc/svcsock.c2007-02-02 15:22:40.0 +1100 +++ ./net/sunrpc/svcsock.c2007-02-02 15:22:58.0 +1100 @@ -715,13 +715,55 @@

Re: [PATCH] x86_64: Fix preprocessor condition

2007-01-31 Thread Josef Sipek
On Wed, Jan 31, 2007 at 06:16:02PM +0100, Andi Kleen wrote: > > > -#if defined(__KERNEL__) && __x86_64__ > > +#if defined(__KERNEL__) && defined(__x86_64__) > > Undefined symbols are replaced with 0, so the old line was already ok. Fair enough, however sparse is not very happy about underfined

Re: [PATCH] x86_64: Fix preprocessor condition

2007-01-31 Thread Josef Sipek
On Wed, Jan 31, 2007 at 06:16:02PM +0100, Andi Kleen wrote: -#if defined(__KERNEL__) __x86_64__ +#if defined(__KERNEL__) defined(__x86_64__) Undefined symbols are replaced with 0, so the old line was already ok. Fair enough, however sparse is not very happy about underfined symbols.

Re: [PATCH 4/4] fs/unionfs/: Don't duplicate the struct nameidata

2007-01-30 Thread Josef Sipek
On Tue, Jan 30, 2007 at 09:42:33AM +, Christoph Hellwig wrote: > On Mon, Jan 29, 2007 at 03:37:42PM -0500, Josef 'Jeff' Sipek wrote: > > The only fields that we have to watch out for are the dentry and vfsmount. > > Additionally, this makes Unionfs gentler on the stack as nameidata is rather >

Re: [PATCH 4/4] fs/unionfs/: Don't duplicate the struct nameidata

2007-01-30 Thread Josef Sipek
On Tue, Jan 30, 2007 at 09:42:33AM +, Christoph Hellwig wrote: On Mon, Jan 29, 2007 at 03:37:42PM -0500, Josef 'Jeff' Sipek wrote: The only fields that we have to watch out for are the dentry and vfsmount. Additionally, this makes Unionfs gentler on the stack as nameidata is rather

Re: [PATCH 4/4] fs/unionfs/: Don't duplicate the struct nameidata

2007-01-29 Thread Josef Sipek
On Mon, Jan 29, 2007 at 03:37:43PM -0500, Josef 'Jeff' Sipek wrote: > Josef 'Jeff' Sipek (3): > fs/unionfs/: Remove stale_inode.c > fs/unionfs/: Andrew Morton's comments > fs/unionfs/: Don't duplicate the struct nameidata > > fs/unionfs/branchman.c |4 +- >

Re: [PATCH 4/4] fs/unionfs/: Don't duplicate the struct nameidata

2007-01-29 Thread Josef Sipek
On Mon, Jan 29, 2007 at 03:37:43PM -0500, Josef 'Jeff' Sipek wrote: Josef 'Jeff' Sipek (3): fs/unionfs/: Remove stale_inode.c fs/unionfs/: Andrew Morton's comments fs/unionfs/: Don't duplicate the struct nameidata fs/unionfs/branchman.c |4 +-

Re: [-mm patch] fs/unionfs/: possible cleanups

2007-01-20 Thread Josef Sipek
On Thu, Jan 18, 2007 at 10:55:54PM +0100, Adrian Bunk wrote: > Let's start with a small exercise: > > Consider sparse tells you about a global function: > warning: symbol 'unionfs_d_revalidate_wrap' was not declared. Should > it be static? I ran sparse last week, and cleaned up a few

Re: [-mm patch] fs/unionfs/: possible cleanups

2007-01-20 Thread Josef Sipek
On Thu, Jan 18, 2007 at 10:55:54PM +0100, Adrian Bunk wrote: Let's start with a small exercise: Consider sparse tells you about a global function: warning: symbol 'unionfs_d_revalidate_wrap' was not declared. Should it be static? I ran sparse last week, and cleaned up a few things

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Josef Sipek
On Wed, Jan 17, 2007 at 04:55:49PM -0600, Dave Kleikamp wrote: ... > diff -Nurp linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h linux/fs/jfs/jfs_lock.h > --- linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h2006-11-29 15:57:37.0 > -0600 > +++ linux/fs/jfs/jfs_lock.h 2007-01-17 15:30:19.0 -0600

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Josef Sipek
On Wed, Jan 17, 2007 at 04:55:49PM -0600, Dave Kleikamp wrote: ... diff -Nurp linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h linux/fs/jfs/jfs_lock.h --- linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h2006-11-29 15:57:37.0 -0600 +++ linux/fs/jfs/jfs_lock.h 2007-01-17 15:30:19.0 -0600 @@

Re: [PATCH] Mark struct super_operations const

2007-01-16 Thread Josef Sipek
... > -static struct super_operations openprom_sops = { > +const static struct super_operations openprom_sops = { About to send a new patch to make that 'static const' instead :) Jeff. -- Intellectuals solve problems; geniuses prevent them - Albert Einstein - To unsubscribe

Re: [PATCH] Mark struct super_operations const

2007-01-16 Thread Josef Sipek
... -static struct super_operations openprom_sops = { +const static struct super_operations openprom_sops = { About to send a new patch to make that 'static const' instead :) Jeff. -- Intellectuals solve problems; geniuses prevent them - Albert Einstein - To unsubscribe

[ANNOUNCE] Guilt v0.18

2007-01-14 Thread Josef Sipek
Guilt v0.18 is available for download. Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

[ANNOUNCE] Guilt v0.18

2007-01-14 Thread Josef Sipek
Guilt v0.18 is available for download. Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-10 Thread Josef Sipek
On Wed, Jan 10, 2007 at 05:12:15PM +0100, Jan Kara wrote: > I see :). To me it just sounds as if you want to do remount-read-only > for source filesystems, which is operation we support perfectly fine, > and after that create union mount. But I agree you cannot do quite that > since you need to

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-10 Thread Josef Sipek
On Wed, Jan 10, 2007 at 05:12:15PM +0100, Jan Kara wrote: I see :). To me it just sounds as if you want to do remount-read-only for source filesystems, which is operation we support perfectly fine, and after that create union mount. But I agree you cannot do quite that since you need to have

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 09:53:45AM +, Christoph Hellwig wrote: > On Mon, Jan 08, 2007 at 07:03:35PM -0500, Erez Zadok wrote: > > However, I must caution that a file system like ecryptfs is very different > > from Unionfs, the latter being a fan-out file system---and both have very > >

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 09:49:35AM +, Christoph Hellwig wrote: > On Mon, Jan 08, 2007 at 06:25:16PM -0500, Josef Sipek wrote: > > > There's no such problem with bind mounts. It's surprising to see such a > > > restriction with union mounts. > > > > B

Re: [git patches, updated] net driver fixes

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 04:50:59AM -0500, Jeff Garzik wrote: ... > diff --git a/drivers/net/chelsio/my3126.c b/drivers/net/chelsio/my3126.c > index c7731b6..82fed1d 100644 > --- a/drivers/net/chelsio/my3126.c > +++ b/drivers/net/chelsio/my3126.c > @@ -170,9 +170,10 @@ static struct cphy

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 09:49:35AM +, Christoph Hellwig wrote: On Mon, Jan 08, 2007 at 06:25:16PM -0500, Josef Sipek wrote: There's no such problem with bind mounts. It's surprising to see such a restriction with union mounts. Bind mounts are a purely VFS level construct. Unionfs

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 09:53:45AM +, Christoph Hellwig wrote: On Mon, Jan 08, 2007 at 07:03:35PM -0500, Erez Zadok wrote: However, I must caution that a file system like ecryptfs is very different from Unionfs, the latter being a fan-out file system---and both have very different

Re: [git patches, updated] net driver fixes

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 04:50:59AM -0500, Jeff Garzik wrote: ... diff --git a/drivers/net/chelsio/my3126.c b/drivers/net/chelsio/my3126.c index c7731b6..82fed1d 100644 --- a/drivers/net/chelsio/my3126.c +++ b/drivers/net/chelsio/my3126.c @@ -170,9 +170,10 @@ static struct cphy

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Tue, Jan 09, 2007 at 01:19:48AM +0100, Giuseppe Bilotta wrote: > As a simple user without much knowledge of kernel internals, much less > so filesystems, couldn't something based on the same principle of > lsof+fam be used to handle these situations? Using inotify has been suggested before.

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 05:00:18PM -0600, Michael Halcrow wrote: > On Mon, Jan 08, 2007 at 03:51:31PM -0500, Erez Zadok wrote: > > BTW, this is a problem with all stackable file systems, including > > ecryptfs. To be fair, our Unionfs users have come up against this > > problem, usually for the

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 02:02:24PM -0800, Andrew Morton wrote: > On Mon, 08 Jan 2007 16:30:48 -0500 > Shaya Potter <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-01-08 at 13:19 -0800, Andrew Morton wrote: > > > On Mon, 8 Jan 2007 14:43:39 -0500 (EST) Shaya Potter <[EMAIL PROTECTED]> > > > wrote:

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 01:19:57PM -0800, Andrew Morton wrote: ... > If it's not in the changelog or the documentation, it doesn't exist. Good point. I'll add it for next time. > > It's the same thing as modifying a block > > device while a file system is using it. Now, when unionfs gets

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 11:18:52AM -0800, Andrew Morton wrote: > On Sun, 7 Jan 2007 23:12:53 -0500 > "Josef 'Jeff' Sipek" <[EMAIL PROTECTED]> wrote: > > > +Modifying a Unionfs branch directly, while the union is mounted, is > > +currently unsupported. > > Does this mean that if I have /a/b/ and

[ANNOUNCE] Guilt 0.17

2007-01-08 Thread Josef Sipek
Guilt v0.17 is available for download. Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

[ANNOUNCE] Guilt 0.17

2007-01-08 Thread Josef Sipek
Guilt v0.17 is available for download. Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like functionality and interface to git. Tarballs: http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/ Git repo:

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 11:18:52AM -0800, Andrew Morton wrote: On Sun, 7 Jan 2007 23:12:53 -0500 Josef 'Jeff' Sipek [EMAIL PROTECTED] wrote: +Modifying a Unionfs branch directly, while the union is mounted, is +currently unsupported. Does this mean that if I have /a/b/ and /c/d/

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 01:19:57PM -0800, Andrew Morton wrote: ... If it's not in the changelog or the documentation, it doesn't exist. Good point. I'll add it for next time. It's the same thing as modifying a block device while a file system is using it. Now, when unionfs gets

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 02:02:24PM -0800, Andrew Morton wrote: On Mon, 08 Jan 2007 16:30:48 -0500 Shaya Potter [EMAIL PROTECTED] wrote: On Mon, 2007-01-08 at 13:19 -0800, Andrew Morton wrote: On Mon, 8 Jan 2007 14:43:39 -0500 (EST) Shaya Potter [EMAIL PROTECTED] wrote: It's the

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Mon, Jan 08, 2007 at 05:00:18PM -0600, Michael Halcrow wrote: On Mon, Jan 08, 2007 at 03:51:31PM -0500, Erez Zadok wrote: BTW, this is a problem with all stackable file systems, including ecryptfs. To be fair, our Unionfs users have come up against this problem, usually for the first

Re: [PATCH 01/24] Unionfs: Documentation

2007-01-08 Thread Josef Sipek
On Tue, Jan 09, 2007 at 01:19:48AM +0100, Giuseppe Bilotta wrote: As a simple user without much knowledge of kernel internals, much less so filesystems, couldn't something based on the same principle of lsof+fam be used to handle these situations? Using inotify has been suggested before. That

Re: [ANNOUNCE] Guilt 0.16

2007-01-06 Thread Josef Sipek
On Sat, Jan 06, 2007 at 04:57:31PM -0300, Horst H. von Brand wrote: > Josef Sipek <[EMAIL PROTECTED]> wrote: > > Guilt (Git Quilt) is a series of bash scripts which add a Mercurial > > queues-like [1] functionality and interface to git. The one distinguishing > > fe

[ANNOUNCE] Guilt 0.16

2007-01-06 Thread Josef Sipek
Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like [1] functionality and interface to git. The one distinguishing feature from other quilt-like porcelains, is the format of the patches directory. _All_ the information is stored as plain text - a series file and the

[ANNOUNCE] Guilt 0.16

2007-01-06 Thread Josef Sipek
Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like [1] functionality and interface to git. The one distinguishing feature from other quilt-like porcelains, is the format of the patches directory. _All_ the information is stored as plain text - a series file and the

Re: [ANNOUNCE] Guilt 0.16

2007-01-06 Thread Josef Sipek
On Sat, Jan 06, 2007 at 04:57:31PM -0300, Horst H. von Brand wrote: Josef Sipek [EMAIL PROTECTED] wrote: Guilt (Git Quilt) is a series of bash scripts which add a Mercurial queues-like [1] functionality and interface to git. The one distinguishing feature from other quilt-like porcelains

Re: [PATCH] fsstack: Remove inode copy

2006-12-15 Thread Josef Sipek
On Fri, Dec 15, 2006 at 10:24:28AM -0600, Michael Halcrow wrote: > The addition of copy_inode_size breaks eCryptfs, since eCryptfs needs > to interpolate the file sizes (eCryptfs has extra space in the lower > file for the header). The setting of the upper inode size occurs > elsewhere in

Re: [PATCH] fsstack: Remove inode copy

2006-12-15 Thread Josef Sipek
On Fri, Dec 15, 2006 at 10:24:28AM -0600, Michael Halcrow wrote: The addition of copy_inode_size breaks eCryptfs, since eCryptfs needs to interpolate the file sizes (eCryptfs has extra space in the lower file for the header). The setting of the upper inode size occurs elsewhere in eCryptfs,

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 07:03:00PM +0100, Jan Engelhardt wrote: > On Dec 8 2006 12:43, Josef Sipek wrote: ... > >args->err is modified. If args is declared const, gcc complains. > > I never said making "args" const, but > rather [-> http://lkml.org/lkml/20

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 06:02:28PM +0100, Jan Engelhardt wrote: > > On Dec 8 2006 11:00, Josef Sipek wrote: > > +void __unionfs_mkdir(void *data) > +{ > + struct sioq_args *args = data; > + struct mkdir_args *m = >mkdir; > + > + args->err = vfs_mk

Re: [PATCH 2/3] ensure unique i_ino in filesystems without permanent inode numbers (libfs superblock cleanup)

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 08:08:03AM -0500, Jeff Layton wrote: > Josef Sipek wrote: > >> - ret = simple_fill_super(sb, IPATHFS_MAGIC, files); > >> + ret = simple_fill_super(sb, IPATHFS_MAGIC, files, 1); > > > > I don't know...the magic looking 1 and 0 (later in th

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 11:38:13AM +0100, Jan Engelhardt wrote: > > On Dec 7 2006 21:17, Josef Sipek wrote: > >> >> > >+void __unionfs_mknod(void *data) > >> >> > >+{ > >> >> > >+struct sioq_args *args = data; > >>

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 11:38:13AM +0100, Jan Engelhardt wrote: On Dec 7 2006 21:17, Josef Sipek wrote: +void __unionfs_mknod(void *data) +{ +struct sioq_args *args = data; +struct mknod_args *m = args-mknod; ... | vfs_mknod(m-parent, m-dentry, m-mode, m-dev

Re: [PATCH 2/3] ensure unique i_ino in filesystems without permanent inode numbers (libfs superblock cleanup)

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 08:08:03AM -0500, Jeff Layton wrote: Josef Sipek wrote: - ret = simple_fill_super(sb, IPATHFS_MAGIC, files); + ret = simple_fill_super(sb, IPATHFS_MAGIC, files, 1); I don't know...the magic looking 1 and 0 (later in the patch) seem a bit arbitrary. Maybe

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 06:02:28PM +0100, Jan Engelhardt wrote: On Dec 8 2006 11:00, Josef Sipek wrote: +void __unionfs_mkdir(void *data) +{ + struct sioq_args *args = data; + struct mkdir_args *m = args-mkdir; + + args-err = vfs_mkdir(m-parent, m-dentry, m-mode

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 07:03:00PM +0100, Jan Engelhardt wrote: On Dec 8 2006 12:43, Josef Sipek wrote: ... args-err is modified. If args is declared const, gcc complains. I never said making args const, but rather [- http://lkml.org/lkml/2006/12/5/210 ] I said: Care to make that: const

Re: [PATCH 2/3] ensure unique i_ino in filesystems without permanent inode numbers (libfs superblock cleanup)

2006-12-07 Thread Josef Sipek
On Thu, Dec 07, 2006 at 05:13:08PM -0500, Jeff Layton wrote: > This patch ensures that the inodes allocated by the functions get_sb_pseudo > and simple_fill_super are unique, provided of course, that the filesystems > calling them play by the rules. Currently that isn't the case, but will be > as

Re: [PATCH 35/35] Unionfs: Extended Attributes support

2006-12-07 Thread Josef Sipek
On Thu, Dec 07, 2006 at 12:04:43PM +0100, Jan Engelhardt wrote: > > On Dec 4 2006 07:31, Josef 'Jeff' Sipek wrote: > > If the makefile contains > > >--- a/fs/unionfs/Makefile > >+++ b/fs/unionfs/Makefile > >@@ -3,3 +3,5 @@ obj-$(CONFIG_UNION_FS) += unionfs.o > > unionfs-y := subr.o dentry.o

Re: [PATCH 16/35] Unionfs: Copyup Functionality

2006-12-07 Thread Josef Sipek
On Tue, Dec 05, 2006 at 10:09:19PM +0100, Jan Engelhardt wrote: > > On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: > >+/* Determine the mode based on the copyup flags, and the existing dentry. */ > >+static int copyup_permissions(struct super_block *sb, > >+ struct dentry

Re: [PATCH 15/35] Unionfs: Common file operations

2006-12-07 Thread Josef Sipek
On Tue, Dec 05, 2006 at 10:02:10PM +0100, Jan Engelhardt wrote: > On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: > >+long unionfs_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > >+{ > >+long err; > >+ > >+if ((err = unionfs_file_revalidate(file, 1))) > >+goto

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-07 Thread Josef Sipek
On Wed, Dec 06, 2006 at 07:46:50PM +0100, Jan Engelhardt wrote: > I smell a big conspiracy! So yet again it's mixed mixed > > fs$ grep __init */*.c | grep -v ' init_' > sysfs/mount.c:int __init sysfs_init(void) > sysv/inode.c:int __init sysv_init_icache(void) > proc/vmcore.c:static int __init

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-07 Thread Josef Sipek
On Wed, Dec 06, 2006 at 07:46:50PM +0100, Jan Engelhardt wrote: I smell a big conspiracy! So yet again it's mixed mixed fs$ grep __init */*.c | grep -v ' init_' sysfs/mount.c:int __init sysfs_init(void) sysv/inode.c:int __init sysv_init_icache(void) proc/vmcore.c:static int __init

Re: [PATCH 15/35] Unionfs: Common file operations

2006-12-07 Thread Josef Sipek
On Tue, Dec 05, 2006 at 10:02:10PM +0100, Jan Engelhardt wrote: On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: +long unionfs_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +{ +long err; + +if ((err = unionfs_file_revalidate(file, 1))) +goto out; + +

Re: [PATCH 16/35] Unionfs: Copyup Functionality

2006-12-07 Thread Josef Sipek
On Tue, Dec 05, 2006 at 10:09:19PM +0100, Jan Engelhardt wrote: On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: +/* Determine the mode based on the copyup flags, and the existing dentry. */ +static int copyup_permissions(struct super_block *sb, + struct dentry

Re: [PATCH 35/35] Unionfs: Extended Attributes support

2006-12-07 Thread Josef Sipek
On Thu, Dec 07, 2006 at 12:04:43PM +0100, Jan Engelhardt wrote: On Dec 4 2006 07:31, Josef 'Jeff' Sipek wrote: If the makefile contains --- a/fs/unionfs/Makefile +++ b/fs/unionfs/Makefile @@ -3,3 +3,5 @@ obj-$(CONFIG_UNION_FS) += unionfs.o unionfs-y := subr.o dentry.o file.o inode.o

Re: [PATCH 2/3] ensure unique i_ino in filesystems without permanent inode numbers (libfs superblock cleanup)

2006-12-07 Thread Josef Sipek
On Thu, Dec 07, 2006 at 05:13:08PM -0500, Jeff Layton wrote: This patch ensures that the inodes allocated by the functions get_sb_pseudo and simple_fill_super are unique, provided of course, that the filesystems calling them play by the rules. Currently that isn't the case, but will be as I

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-06 Thread Josef Sipek
On Tue, Dec 05, 2006 at 02:50:13PM -0500, Josef Sipek wrote: > On Tue, Dec 05, 2006 at 08:27:51PM +0100, Jan Engelhardt wrote: > > > > On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: > > >+#include "union.h" > > >+ > > >+struct workqueue_

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-06 Thread Josef Sipek
On Tue, Dec 05, 2006 at 02:50:13PM -0500, Josef Sipek wrote: On Tue, Dec 05, 2006 at 08:27:51PM +0100, Jan Engelhardt wrote: On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: +#include union.h + +struct workqueue_struct *sioq; + +int __init init_sioq(void) Although it's just me

Re: [PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage

2006-12-05 Thread Josef Sipek
On Tue, Dec 05, 2006 at 02:49:13PM -0800, Andrew Morton wrote: > On Tue, 5 Dec 2006 17:38:07 -0500 > Josef Sipek <[EMAIL PROTECTED]> wrote: > > > > When your patches are queued in -mm please do test them there, and review > > > others' changes to them, and rai

Re: [PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage

2006-12-05 Thread Josef Sipek
On Tue, Dec 05, 2006 at 02:28:31PM -0800, Andrew Morton wrote: > On Tue, 5 Dec 2006 14:22:32 -0500 > Josef Sipek <[EMAIL PROTECTED]> wrote: > > > Fix up a stray ecryptfs_copy_attr_all call and remove prototypes for > > ecryptfs_copy_* as they no longer exist. > >

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-05 Thread Josef Sipek
On Tue, Dec 05, 2006 at 08:27:51PM +0100, Jan Engelhardt wrote: > > On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: > >+#include "union.h" > >+ > >+struct workqueue_struct *sioq; > >+ > >+int __init init_sioq(void) > > Although it's just me, I'd prefer sioq_init(), sioq_exit(), > sioq_run(), etc.

[PATCH 1/2] fsstack: Make fsstack_copy_attr_all copy inode size

2006-12-05 Thread Josef Sipek
fsstack_copy_attr_all should copy the inode size in addition to all the other attributes. Signed-off-by: Josef "Jeff" Sipek <[EMAIL PROTECTED]> --- fs/stack.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/stack.c b/fs/stack.c index 8ffb880..5ddbc34 100644 ---

[PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage

2006-12-05 Thread Josef Sipek
Fix up a stray ecryptfs_copy_attr_all call and remove prototypes for ecryptfs_copy_* as they no longer exist. Signed-off-by: Josef "Jeff" Sipek <[EMAIL PROTECTED]> --- fs/ecryptfs/dentry.c |2 +- fs/ecryptfs/ecryptfs_kernel.h |4 +--- 2 files changed, 2 insertions(+), 4

Re: -mm merge plans for 2.6.20

2006-12-05 Thread Josef Sipek
On Mon, Dec 04, 2006 at 08:40:24PM -0800, Andrew Morton wrote: ... > fsstack-introduce-fsstack_copy_attrinode_.patch > fsstack-introduce-fsstack_copy_attrinode_-tidy.patch > fsstack-introduce-fsstack_copy_attrinode_-fs-stackc-should-include-linux-fs_stackh.patch >

Re: Unionfs: Stackable namespace unification filesystem

2006-12-05 Thread Josef Sipek
On Mon, Dec 04, 2006 at 07:30:33AM -0500, Josef 'Jeff' Sipek wrote: > The following patches are in a git repo at: > > git://git.kernel.org/pub/scm/linux/kernel/git/jsipek/unionfs.git > > (master.kernel.org:/pub/scm/linux/kernel/git/jsipek/unionfs.git) > > The repository contains the following

Re: [PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage

2006-12-05 Thread Josef Sipek
On Tue, Dec 05, 2006 at 02:49:13PM -0800, Andrew Morton wrote: On Tue, 5 Dec 2006 17:38:07 -0500 Josef Sipek [EMAIL PROTECTED] wrote: When your patches are queued in -mm please do test them there, and review others' changes to them, and raise patches against them. Raising patches

Re: Unionfs: Stackable namespace unification filesystem

2006-12-05 Thread Josef Sipek
On Mon, Dec 04, 2006 at 07:30:33AM -0500, Josef 'Jeff' Sipek wrote: The following patches are in a git repo at: git://git.kernel.org/pub/scm/linux/kernel/git/jsipek/unionfs.git (master.kernel.org:/pub/scm/linux/kernel/git/jsipek/unionfs.git) The repository contains the following 35

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-05 Thread Josef Sipek
On Tue, Dec 05, 2006 at 08:27:51PM +0100, Jan Engelhardt wrote: On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: +#include union.h + +struct workqueue_struct *sioq; + +int __init init_sioq(void) Although it's just me, I'd prefer sioq_init(), sioq_exit(), sioq_run(), etc. to go in hand

Re: -mm merge plans for 2.6.20

2006-12-05 Thread Josef Sipek
On Mon, Dec 04, 2006 at 08:40:24PM -0800, Andrew Morton wrote: ... fsstack-introduce-fsstack_copy_attrinode_.patch fsstack-introduce-fsstack_copy_attrinode_-tidy.patch fsstack-introduce-fsstack_copy_attrinode_-fs-stackc-should-include-linux-fs_stackh.patch

[PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage

2006-12-05 Thread Josef Sipek
Fix up a stray ecryptfs_copy_attr_all call and remove prototypes for ecryptfs_copy_* as they no longer exist. Signed-off-by: Josef Jeff Sipek [EMAIL PROTECTED] --- fs/ecryptfs/dentry.c |2 +- fs/ecryptfs/ecryptfs_kernel.h |4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)

<    1   2   3   >