This makes it more likely that patch submitters will CC API/ABI changes
to the linux-api list, and tools like get_maintainer.pl will do so
automatically.
Signed-off-by: Josh Triplett j...@joshtriplett.org
Acked-by: Steven Rostedt rost...@goodmis.org
---
MAINTAINERS | 7 +++
1 file changed, 7
th Kumar.
>
> 18. Replace deprecated __this_cpu_ptr() uses with raw_cpu_ptr(),
> courtesy of Christoph Lameter.
>
> 19. Make softirq processing provide a quiescent state only once
> per full pass over all softirqs rather than once per action,
> cour
umenting the proper care
> and feeding of rcu_dereference() return values.
>
> 3.Update the list of RCU API members in whatisRCU.txt.
For all three:
Reviewed-by: Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
and feeding of rcu_dereference() return values.
3.Update the list of RCU API members in whatisRCU.txt.
For all three:
Reviewed-by: Josh Triplett j...@joshtriplett.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
than once per action,
courtesy of Eric Dumazet.
For all 19:
Reviewed-by: Josh Triplett j...@joshtriplett.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
This option can be useful on very small systems where every
byte counts. However, the resulting kernel will be slower to
execute, and overall system performance will be degraded.
Also, when you collected your performance benchmarks, did you collect
any profiling information on what pa
> Starting init 4.213 s 5.549 s -44 ms
> Login prompt 21.085 s22.900 s+1.815 s
Did you get the times in the upper two rows transposed row/column? Based
on the diffs, I'd guess 4.213s goes in Os "Starting kernel", and 5.593s
goes in O2 &q
prompt 21.085 s22.900 s+1.815 s
Did you get the times in the upper two rows transposed row/column? Based
on the diffs, I'd guess 4.213s goes in Os Starting kernel, and 5.593s
goes in O2 Starting init.
- Josh Triplett
--
To unsubscribe from this list: send the line
to
execute, and overall system performance will be degraded.
Also, when you collected your performance benchmarks, did you collect
any profiling information on what part of the kernel got slower?
Compiling a couple of kernel hotspots with -O2 (or -O3) might eliminate
the performance delta.
- Josh
On Thu, Apr 17, 2014 at 05:18:35PM +0900, Masami Hiramatsu wrote:
> Use NOKPROBE_SYMBOL macro to protect functions from
> kprobes instead of __kprobes annotation in notifier.
>
> Signed-off-by: Masami Hiramatsu
> Reviewed-by: Steven Rostedt
> Cc: Josh Triplett
>
Triplett j...@joshtriplett.org
Cc: Paul E. McKenney paul...@linux.vnet.ibm.com
Reviewed-by: Josh Triplett j...@joshtriplett.org
kernel/notifier.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/kernel/notifier.c b/kernel/notifier.c
index
cilities in that .config
> - true optimizations
>
> it would be important to know the proportion of true optimizations,
> because those are that matter most. Unused facilities will take up a
> bit of RAM, and perhaps fragment the CPU cache a tiny bit, but aren't
> near
kernel builds
slower if and only if LTO is turned on, which most kernel developers
won't need to do. On the other hand, distro and embedded kernels can do
so for final builds, and developers pushing to minimize the kernel can
turn it on for their own work as needed.
- Josh Triplett
coherent internal header file.
>
> Signed-off-by: Neil 'Superna' Armstrong
Reviewed-by: Josh Triplett
> drivers/staging/wlan-ng/prism2mgmt.h |5 +
> drivers/staging/wlan-ng/prism2sta.c |4
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git
-by: Neil 'Superna' Armstrong superna9...@gmail.com
Reviewed-by: Josh Triplett j...@joshtriplett.org
drivers/staging/wlan-ng/prism2mgmt.h |5 +
drivers/staging/wlan-ng/prism2sta.c |4
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng
On Wed, Apr 09, 2014 at 09:25:55AM +0200, Martin Kepplinger wrote:
> Use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger
Reviewed-by: Josh Triplett
>
> drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |6 +++---
> 1 file changed, 3 insertio
On Wed, Apr 09, 2014 at 09:25:55AM +0200, Martin Kepplinger wrote:
Use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
Reviewed-by: Josh Triplett j...@joshtriplett.org
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |6 +++---
1 file changed, 3
On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> This patch solves some sparse warnings about "symbol [...] was not
> declared. Should it be static?" by including the correct header files.
>
> Signed-off-by: Jonas Hahnfeld
Reviewed-by: Josh Triplett
&g
On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
This patch solves some sparse warnings about symbol [...] was not
declared. Should it be static? by including the correct header files.
Signed-off-by: Jonas Hahnfeld hah...@hahnjo.de
Reviewed-by: Josh Triplett j
; \
> sizeof(t) < (1 << _IOC_SIZEBITS)) ? \
> sizeof(t) : __invalid_size_argument_for_IOC)
>
> If it is defined as this (as is already done if __KERNEL__ is not defined):
>
> #define _IOC_TYPECHECK(t) (sizeof(t))
>
> then all is well with the world.
>
> This pa
) : __invalid_size_argument_for_IOC)
If it is defined as this (as is already done if __KERNEL__ is not defined):
#define _IOC_TYPECHECK(t) (sizeof(t))
then all is well with the world.
This patch allows sparse to work correctly.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Josh Triplett j
ning in isci/phy.c:
> > drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for
> > ‘scu_link_layer_set_txcomsas_timeout’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
>
> Acked-by: Lukasz Dorau
Since
:
drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for
‘scu_link_layer_set_txcomsas_timeout’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria rashika.khe...@gmail.com
Reviewed-by: Josh Triplett j...@joshtriplett.org
Acked-by: Lukasz Dorau lukasz.do...@intel.com
Since you're
On Sun, Mar 23, 2014 at 03:09:27PM -, Thomas Gleixner wrote:
> Otherwise we leak a tracking object if DEBUG_OBJECTS is enabled.
>
> Signed-off-by: Thomas Gleixner
> Cc: Josh Triplett
> Cc: "Paul E. McKenney"
Reviewed-by: Josh Triplett
> kernel/rcu/tor
On Sun, Mar 23, 2014 at 03:09:27PM -, Thomas Gleixner wrote:
Otherwise we leak a tracking object if DEBUG_OBJECTS is enabled.
Signed-off-by: Thomas Gleixner t...@linutronix.de
Cc: Josh Triplett j...@freedesktop.org
Cc: Paul E. McKenney paul...@linux.vnet.ibm.com
Reviewed-by: Josh
129 --129
copy_thread 598 455-143
sys_ioperm 442 --442
init_tss8896 640 -8256
Signed-off-by: Josh Triplett
---
v2: Rebased. Updated bloat-o-meter
the
array.
That then removes the last use of IO_BITMAP_OFFSET, so delete it.
Signed-off-by: Josh Triplett
Acked-by: Alexander van Heukelum
---
v2: Rebased. Added a comment explaining the -1 in the calculation.
arch/x86/include/asm/desc.h | 11 +--
arch/x86/include/asm/processor.h | 4 +++
; move the resulting identical code to a
static inline in a common header.
Signed-off-by: Josh Triplett
Acked-by: Kees Cook
---
v2: Rebased and updated for changes to copy_thread; no other changes in
patch 1/3.
arch/x86/kernel/process-io.h | 22 ++
arch/x86/kernel/process_32
On Tue, Mar 11, 2014 at 12:31:33PM -0700, Andrew Morton wrote:
> On Tue, 11 Mar 2014 12:20:46 -0700 Josh Triplett
> wrote:
>
> > > > ERROR: "balloon_devinfo_alloc" [drivers/virtio/virtio_balloon.ko]
> > > > undefined!
> > > > ERROR: &
+0x1fb87): undefined reference to
> > `balloon_page_dequeue'
> > virtio_balloon.c:(.text+0x1fdf1): undefined reference to
> > `balloon_devinfo_alloc'
> >
> > when builtin.
>
> OK, thanks, I'll drop
> http://ozlabs.org/~akpm/mmots/broken-out/mm-disa
On Tue, Mar 11, 2014 at 05:40:25PM +0100, Arnd Bergmann wrote:
> On Monday 10 March 2014, Josh Triplett wrote:
> >
> > When !CONFIG_BUG, WARN_ON and family become simple passthroughs of their
> > condition argument; however, WARN_ON_ONCE and family still have
> &g
On Tue, Mar 11, 2014 at 05:40:25PM +0100, Arnd Bergmann wrote:
On Monday 10 March 2014, Josh Triplett wrote:
When !CONFIG_BUG, WARN_ON and family become simple passthroughs of their
condition argument; however, WARN_ON_ONCE and family still have
conditions and a boolean to detect one
user of this API, would it be
reasonable to just only compile in balloon_compaction.o when
CONFIG_VIRTIO_BALLOON?
- Josh Triplett
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Tue, Mar 11, 2014 at 12:31:33PM -0700, Andrew Morton wrote:
On Tue, 11 Mar 2014 12:20:46 -0700 Josh Triplett j...@joshtriplett.org
wrote:
ERROR: balloon_devinfo_alloc [drivers/virtio/virtio_balloon.ko]
undefined!
ERROR: balloon_page_enqueue [drivers/virtio/virtio_balloon.ko
; move the resulting identical code to a
static inline in a common header.
Signed-off-by: Josh Triplett j...@joshtriplett.org
Acked-by: Kees Cook keesc...@chromium.org
---
v2: Rebased and updated for changes to copy_thread; no other changes in
patch 1/3.
arch/x86/kernel/process-io.h | 22
.
That then removes the last use of IO_BITMAP_OFFSET, so delete it.
Signed-off-by: Josh Triplett j...@joshtriplett.org
Acked-by: Alexander van Heukelum heuke...@fastmail.fm
---
v2: Rebased. Added a comment explaining the -1 in the calculation.
arch/x86/include/asm/desc.h | 11 +--
arch/x86/include
129 --129
copy_thread 598 455-143
sys_ioperm 442 --442
init_tss8896 640 -8256
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
v2: Rebased. Updated
All the code in early_serial_console.c gets compiled out if
!CONFIG_EARLY_PRINTK, but early_serial_console.o itself still gets
compiled in. Eliminate it from the compile entirely in that case.
This does not change the generated code at all, in either case.
Signed-off-by: Josh Triplett
All the code in aslr.c gets compiled out if !CONFIG_RANDOMIZE_BASE, but
aslr.o itself still gets compiled in. Eliminate it from the compile
entirely in that case.
This does not change the generated code at all, in either case.
Signed-off-by: Josh Triplett
---
arch/x86/boot/compressed/Makefile
Switch VMLINUX_OBJS to vmlinux-objs-y, to eliminate Makefile
conditionals in favor of vmlinux-objs-$(CONFIG_*) constructs.
This does not change the generated code at all.
Signed-off-by: Josh Triplett
---
arch/x86/boot/compressed/Makefile | 10 --
1 file changed, 4 insertions(+), 6
- -84
balloon_page_dequeue 134 --134
Signed-off-by: Josh Triplett
---
mm/Makefile | 4 ++--
mm/balloon_compaction.c | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/Makefile b/mm/Makefile
index 310c90a..1e6ab7d 100644
- -84
balloon_page_dequeue 134 --134
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
mm/Makefile | 4 ++--
mm/balloon_compaction.c | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/Makefile b/mm/Makefile
index 310c90a
Switch VMLINUX_OBJS to vmlinux-objs-y, to eliminate Makefile
conditionals in favor of vmlinux-objs-$(CONFIG_*) constructs.
This does not change the generated code at all.
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
arch/x86/boot/compressed/Makefile | 10 --
1 file changed, 4
All the code in aslr.c gets compiled out if !CONFIG_RANDOMIZE_BASE, but
aslr.o itself still gets compiled in. Eliminate it from the compile
entirely in that case.
This does not change the generated code at all, in either case.
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
arch/x86
All the code in early_serial_console.c gets compiled out if
!CONFIG_EARLY_PRINTK, but early_serial_console.o itself still gets
compiled in. Eliminate it from the compile entirely in that case.
This does not change the generated code at all, in either case.
Signed-off-by: Josh Triplett j
()).
In addition to saving a few bytes over the generic infinite-loop
implementation, this implementation traps rather than looping, which
potentially allows for better error-recovery behavior (such as by
rebooting).
Reported-by: Arnd Bergmann
Signed-off-by: Josh Triplett
---
v3: New patch for x86
-by: Arnd Bergmann
Signed-off-by: Josh Triplett
---
v3: New patch in this series, incorporating Arnd's suggestion to make BUG()
always stop execution. This eliminates the new warnings currently appearing in
allnoconfig due to !CONFIG_BUG; unlike v2, this avoids using unreachable(), and
thus avoids
The stub version of WARN for !CONFIG_BUG completely ignored its format
string and subsequent arguments; make it check them instead, using
no_printk.
Reported-by: Arnd Bergmann
Signed-off-by: Josh Triplett
---
v3: Patch unchanged from v2.
include/asm-generic/bug.h | 1 +
1 file changed, 1
Reported-by: Randy Dunlap
Signed-off-by: Josh Triplett
---
v3: Patch unchanged from v2.
include/asm-generic/bug.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 7ecd398..2d54d8d 100644
--- a/include/asm
on CONFIG_BUG, and add definitions for !CONFIG_BUG that map
to the passthrough versions of WARN and WARN_ON.
This saves 4.4k on a minimized configuration (smaller than
allnoconfig), and 20.6k with defconfig plus CONFIG_BUG=n.
Signed-off-by: Josh Triplett
---
v3: Patch unchanged from v2.
Andrew, can you
on CONFIG_BUG, and add definitions for !CONFIG_BUG that map
to the passthrough versions of WARN and WARN_ON.
This saves 4.4k on a minimized configuration (smaller than
allnoconfig), and 20.6k with defconfig plus CONFIG_BUG=n.
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
v3: Patch unchanged from v2
Reported-by: Randy Dunlap rdun...@infradead.org
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
v3: Patch unchanged from v2.
include/asm-generic/bug.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index
The stub version of WARN for !CONFIG_BUG completely ignored its format
string and subsequent arguments; make it check them instead, using
no_printk.
Reported-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
v3: Patch unchanged from v2.
include/asm-generic
-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
v3: New patch in this series, incorporating Arnd's suggestion to make BUG()
always stop execution. This eliminates the new warnings currently appearing in
allnoconfig due to !CONFIG_BUG; unlike v2, this avoids using
()).
In addition to saving a few bytes over the generic infinite-loop
implementation, this implementation traps rather than looping, which
potentially allows for better error-recovery behavior (such as by
rebooting).
Reported-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Josh Triplett j
o:(.rodata+0xc): undefined reference to
> > `show_cpuinfo'
> > make: *** [vmlinux] Error 1
> >
> > Signed-off-by: Geert Uytterhoeven
>
> Added as a merge fix to (for the akpm-current tree) linux-next from today.
>
> [rest left here for Andrew and Josh ...]
Reviewed
to
`show_cpuinfo'
make: *** [vmlinux] Error 1
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
Added as a merge fix to (for the akpm-current tree) linux-next from today.
[rest left here for Andrew and Josh ...]
Reviewed-by: Josh Triplett j...@joshtriplett.org
http
On Thu, Feb 27, 2014 at 01:40:57PM +1100, Stephen Rothwell wrote:
> Hi Josh,
>
> On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett
> wrote:
> >
> > On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
> > > Please check the build results ove
arch/cris/arch-v10/kernel/debugport.c, compiled in unconditionally with
ETRAX_ARCH_V10, requires TTY, so select TTY to avoid a build failure.
Signed-off-by: Josh Triplett
---
arch/cris/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/cris/Kconfig b/arch/cris/Kconfig
index
On Thu, Feb 27, 2014 at 08:19:47PM +0100, Arnd Bergmann wrote:
> On Wednesday 26 February 2014, Josh Triplett wrote:
> > This doesn't seem any different than compiling out assert() at runtime
> > in a userspace program, given how the kernel uses BUG() and BUG_ON().
> >
iminates the following warning in kernel/panic.c:
> > kernel/panic.c:55:13: warning: no previous prototype for
> > ‘panic_smp_self_stop’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
> > ---
> > arch/tile/kernel/
ing warning in kernel/cpu.c:
> > kernel/cpu.c:512:13: warning: no previous prototype for
> > ‘arch_enable_nonboot_cpus_begin’ [-Wmissing-prototypes]
> > kernel/cpu.c:516:13: warning: no previous prototype for
> > ‘arch_enable_nonboot_cpus_end’ [-Wmissing-prototypes]
> >
warning in kernel/trace/ftrace.c:
> kernel/trace/ftrace.c:4268:6: warning: no previous prototype for
> ‘ftrace_release_mod’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/linux/ftrace.h |1 -
> kernel/trace/ftrace.c |2 +-
&
1284ea9235b29bd2d9b7493b4b4cf3da09c
Author: Peter Zijlstra
Date: Wed Jun 13 15:24:45 2012 +0200
sched/x86: Remove broken power estimation
The x86 sched power implementation has been broken forever and gets in
the way of other stuff, remove it.
When I reviewed Rashika's patch an
one weak, and one usage site.
>
> What gives?
There's no prototype for the function anywhere, so -Wmissing-prototypes
rightfully complains. Adding the prototype to a header included in both
source files ensures that the function signatures must match, and
eliminates the warning.
- Josh Triplet
-Wmissing-prototypes
rightfully complains. Adding the prototype to a header included in both
source files ensures that the function signatures must match, and
eliminates the warning.
- Josh Triplett
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
15:24:45 2012 +0200
sched/x86: Remove broken power estimation
The x86 sched power implementation has been broken forever and gets in
the way of other stuff, remove it.
When I reviewed Rashika's patch and provided a Reviewed-by, I provided
the following feedback:
Josh Triplett wrote
/ftrace.c:
kernel/trace/ftrace.c:4268:6: warning: no previous prototype for
‘ftrace_release_mod’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria rashika.khe...@gmail.com
Reviewed-by: Josh Triplett j...@joshtriplett.org
include/linux/ftrace.h |1 -
kernel/trace/ftrace.c |2 +-
2
-by: Josh Triplett j...@joshtriplett.org
---
arch/x86/kernel/smpboot.c |1 +
include/linux/cpu.h |2 ++
2 files changed, 3 insertions(+)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index a32da80..e428764 100644
--- a/arch/x86/kernel/smpboot.c
+++ b
warning in kernel/panic.c:
kernel/panic.c:55:13: warning: no previous prototype for
‘panic_smp_self_stop’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria rashika.khe...@gmail.com
Reviewed-by: Josh Triplett j...@joshtriplett.org
---
arch/tile/kernel/smp.c |1 +
include
On Thu, Feb 27, 2014 at 08:19:47PM +0100, Arnd Bergmann wrote:
On Wednesday 26 February 2014, Josh Triplett wrote:
This doesn't seem any different than compiling out assert() at runtime
in a userspace program, given how the kernel uses BUG() and BUG_ON().
I'd argue that adding unreachable
arch/cris/arch-v10/kernel/debugport.c, compiled in unconditionally with
ETRAX_ARCH_V10, requires TTY, so select TTY to avoid a build failure.
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
arch/cris/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/cris/Kconfig b/arch/cris
On Thu, Feb 27, 2014 at 01:40:57PM +1100, Stephen Rothwell wrote:
Hi Josh,
On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett j...@joshtriplett.org
wrote:
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
Please check the build results overnight tonight (for next
On Wed, Feb 26, 2014 at 06:53:14PM -0800, Joe Perches wrote:
> Allow an override to emit or not the sizeof(bool) warning
> Add a description to the manpage.
>
> Signed-off-by: Joe Perches
Reviewed-by: Josh Triplett
> evaluate.c | 3 ++-
> lib.c | 2 ++
> lib.h
On Wed, Feb 26, 2014 at 06:03:39PM -0800, Joe Perches wrote:
> Allow an override to emit or not the sizeof(bool) warning
>
> Signed-off-by: Joe Perches
Seems reasonable. However, please document the new flag in the manpage.
> evaluate.c | 3 ++-
> lib.c | 2 ++
> lib.h | 1 +
> 3
instances of failures caused
by allnoconfig. If I'm missing some, could you please point me to the
page on that site I'm missing?
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
The unconditionally built keyboard driver, drivers/s390/char/keyboard.c,
requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build
error.
Signed-off-by: Josh Triplett
---
arch/s390/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
> Hi Josh,
>
> On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett
> wrote:
> >
> > On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> > >
> > > After merging the final
On Wed, Feb 26, 2014 at 10:15:57PM +0530, Rashika Kheria wrote:
> On Wed, Feb 26, 2014 at 10:11 PM, Josh Triplett wrote:
> > On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote:
> >> Mark function as static in cpufreq.c because it is not
> >
On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote:
> Mark function as static in cpufreq.c because it is not
> used outside this file.
>
> This eliminates the following warning in cpufreq.c:
> drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for
> ‘show_boost’
gt; ‘show_boost’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/cpufreq/cpufreq.c |6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 08ca8c9..6dce474 1006
On Wed, Feb 26, 2014 at 02:29:06PM +0100, Arnd Bergmann wrote:
> On Wednesday 26 February 2014, Josh Triplett wrote:
> > @@ -134,7 +134,7 @@ extern void warn_slowpath_null(const char *file, const
> > int line);
> >
> > #else /* !CONFIG_BUG */
> > #ifndef HA
arch/ia64/kernel/unaligned.c uses tty_write_message to print an
unaligned access exception to the TTY of the current user process.
Enable TTY to prevent a build error.
Signed-off-by: Josh Triplett
---
Not tested, but this *should* fix the build error with CONFIG_TTY=n.
Minimal fix, on the basis
t;make allnoconfig" rather
than manually turning off other options (like PRINTK) that select
IRQ_WORK. (One of the goals of that commit: get those options more
widely used and build-tested.)
The following (untested) patch *should* fix this:
- 8< -
>From 36a5b6c87292b6c5eeb390ed6d
(like PRINTK) that select
IRQ_WORK. (One of the goals of that commit: get those options more
widely used and build-tested.)
The following (untested) patch *should* fix this:
- 8 -
From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
From: Josh Triplett j
arch/ia64/kernel/unaligned.c uses tty_write_message to print an
unaligned access exception to the TTY of the current user process.
Enable TTY to prevent a build error.
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
Not tested, but this *should* fix the build error with CONFIG_TTY=n
On Wed, Feb 26, 2014 at 02:29:06PM +0100, Arnd Bergmann wrote:
On Wednesday 26 February 2014, Josh Triplett wrote:
@@ -134,7 +134,7 @@ extern void warn_slowpath_null(const char *file, const
int line);
#else /* !CONFIG_BUG */
#ifndef HAVE_ARCH_BUG
-#define BUG() do {} while (0
-prototypes]
Signed-off-by: Rashika Kheria rashika.khe...@gmail.com
Reviewed-by: Josh Triplett j...@joshtriplett.org
drivers/cpufreq/cpufreq.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 08ca8c9..6dce474 100644
On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote:
Mark function as static in cpufreq.c because it is not
used outside this file.
This eliminates the following warning in cpufreq.c:
drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for
‘show_boost’
On Wed, Feb 26, 2014 at 10:15:57PM +0530, Rashika Kheria wrote:
On Wed, Feb 26, 2014 at 10:11 PM, Josh Triplett j...@joshtriplett.org wrote:
On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote:
Mark function as static in cpufreq.c because it is not
used outside this file
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
Hi Josh,
On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett j...@joshtriplett.org
wrote:
On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
After merging the final tree, today's linux-next build
The unconditionally built keyboard driver, drivers/s390/char/keyboard.c,
requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build
error.
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
arch/s390/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/s390/Kconfig b
of failures caused
by allnoconfig. If I'm missing some, could you please point me to the
page on that site I'm missing?
- Josh Triplett
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Wed, Feb 26, 2014 at 06:03:39PM -0800, Joe Perches wrote:
Allow an override to emit or not the sizeof(bool) warning
Signed-off-by: Joe Perches j...@perches.com
Seems reasonable. However, please document the new flag in the manpage.
evaluate.c | 3 ++-
lib.c | 2 ++
lib.h |
On Wed, Feb 26, 2014 at 06:53:14PM -0800, Joe Perches wrote:
Allow an override to emit or not the sizeof(bool) warning
Add a description to the manpage.
Signed-off-by: Joe Perches j...@perches.com
Reviewed-by: Josh Triplett j...@joshtriplett.org
evaluate.c | 3 ++-
lib.c | 2
The stub version of WARN for !CONFIG_BUG completely ignored its format
string and subsequent arguments; make it check them instead, using
no_printk.
Reported-by: Arnd Bergmann
Signed-off-by: Josh Triplett
---
include/asm-generic/bug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include
include/asm-generic/bug.h defines BUG_ON to call BUG() if CONFIG_BUG=y,
or as a no-op if !CONFIG_BUG. However, BUG() is already a no-op if
!CONFIG_BUG, making this pointless. Use a common definition that always
calls BUG().
This does not change the compiled code at all.
Signed-off-by: Josh
Reported-by: Randy Dunlap
Signed-off-by: Josh Triplett
---
include/asm-generic/bug.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 7ecd398..2d54d8d 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm
summary:
add/remove: 2/7 grow/shrink: 34/57 up/down: 475/-1233 (-758)
Signed-off-by: Josh Triplett
---
include/asm-generic/bug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 653c44a..5f69248 100644
--- a/include
on CONFIG_BUG, and add definitions for !CONFIG_BUG that map
to the passthrough versions of WARN and WARN_ON.
This saves 4.4k on a minimized configuration (smaller than
allnoconfig), and 20.6k with defconfig plus CONFIG_BUG=n.
Signed-off-by: Josh Triplett
---
v2: Incorporate feedback from Arnd Bergmann: make
1201 - 1300 of 2693 matches
Mail list logo
