[PATCH v2] watchdog: don't run proc_watchdog_update if new value is same as old

2016-03-14 Thread Joshua Hunt
While working on a script to restore all sysctl params before a series of tests I found that writing any value into the /proc/sys/kernel/{nmi_watchdog,soft_watchdog,watchdog,watchdog_thresh} causes them to call proc_watchdog_update(). [ 955.756196] NMI watchdog: enabled on all CPUs, permanently

[PATCH] watchdog: don't run proc_watchdog_update if new value is same as old

2016-03-12 Thread Joshua Hunt
While working on a script to restore all sysctl params before a series of tests I found that writing any value into the /proc/sys/kernel/{nmi_watchdog,soft_watchdog,watchdog,watchdog_thresh} causes them to call proc_watchdog_update(). Not only that, but when I wrote to these proc files in a loop I

[PATCH v2 2/2] ACPI, APEI, ERST: Fixed leaked resources in erst_init

2016-03-08 Thread Joshua Hunt
erst_init currently leaks resources allocated from its call to apei_resources_init(). The data allocated there gets copied into apei_resources_all and can be freed when we're done with it. Signed-off-by: Josh Hunt --- drivers/acpi/apei/erst.c |3 +++ 1 file changed, 3 insertions(+) diff --g

[PATCH v2 0/2] ACPI, APEI: Memory leaks

2016-03-08 Thread Joshua Hunt
resources_fini calls to do the cleanup * Update changelog in erst_init patch Joshua Hunt (2): ACPI, APEI: Fix leaked resources ACPI, APEI, ERST: Fixed leaked resources in erst_init drivers/acpi/apei/apei-base.c |6 -- drivers/acpi/apei/erst.c |3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) -- 1.7.9.5

[PATCH v2 1/2] ACPI, APEI: Fix leaked resources

2016-03-08 Thread Joshua Hunt
We leak the NVS and arch resources (if used), in apei_resources_request. They are allocated to make sure we exclude them from the APEI resources, but they are never freed at the end of the function. Free them now. Signed-off-by: Josh Hunt --- drivers/acpi/apei/apei-base.c |6 -- 1 file c

[PATCH 1/2] ACPI, APEI: Fix leaked resources

2016-02-01 Thread Joshua Hunt
We leak the NVS and arch resources (if used), in apei_resources_request. They are allocated to make sure we exclude them from the APEI resources, but they are never freed at the end of the function. Free them now. Signed-off-by: Josh Hunt diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi

[PATCH 2/2] ACPI, APEI, ERST: Fixed leaked resources in erst_init

2016-02-01 Thread Joshua Hunt
erst_init currently leaks resources allocated from its call to apei_resources_request(). The data allocated there gets copied into apei_resources_all and can be freed when we're done with it. Signed-off-by: Josh Hunt diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c index 6e6bc10.

[PATCH 0/2] ACPI, APEI: Memory leaks

2016-02-01 Thread Joshua Hunt
ff The issue has been reported a handful of times upstream. Here is one of the previous reports: https://lkml.org/lkml/2013/8/11/149 This series resolves the reported leaks and kmemleak is clean with these patches applied. Joshua Hunt (2): ACPI, APEI: Fix leaked resources ACPI, APEI, ERST: Fixed