Re: [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-20 Thread Jouni Malinen
which does not really tell much to user space other than potentially requiring full disable + re-enable for the related interfaces. And that is something that should not actually be done in all cases of firmware crashes since there are drivers that handle recovery in a manner that is

Re: [PREEMPT-RT] [patch 4 14/22] timer: Switch to a non cascading wheel

2016-08-17 Thread Jouni Malinen
now different after this kernel commit and that is hit for the case where the server process does not have enough time to accept() the incoming connections and listen() backlog ends up dropping it instead. > On Sat, Aug 13, 2016 at 12:12:26PM +0300, Jouni Malinen wrote: > > Yes, it looks like a TCP conn

Re: [PREEMPT-RT] [patch 4 14/22] timer: Switch to a non cascading wheel

2016-08-17 Thread Jouni Malinen
now different after this kernel commit and that is hit for the case where the server process does not have enough time to accept() the incoming connections and listen() backlog ends up dropping it instead. > On Sat, Aug 13, 2016 at 12:12:26PM +0300, Jouni Malinen wrote: > > Yes, it looks like a TCP conn

Re: [PREEMPT-RT] [patch 4 14/22] timer: Switch to a non cascading wheel

2016-08-13 Thread Jouni Malinen
On Thu, Aug 11, 2016 at 11:25 PM, <rcoch...@linutronix.de> wrote: > On Thu, Aug 11, 2016 at 06:21:26PM +0300, Jouni Malinen wrote: >> The test code looked like this in python: >> >> addr = (url.hostname, url.port) >> socks = {} >>

Re: [PREEMPT-RT] [patch 4 14/22] timer: Switch to a non cascading wheel

2016-08-13 Thread Jouni Malinen
On Thu, Aug 11, 2016 at 11:25 PM, wrote: > On Thu, Aug 11, 2016 at 06:21:26PM +0300, Jouni Malinen wrote: >> The test code looked like this in python: >> >> addr = (url.hostname, url.port) >> socks = {} >> for i in range(20): >>

Re: [patch 4 14/22] timer: Switch to a non cascading wheel

2016-08-11 Thread Jouni Malinen
On Mon, Jul 4, 2016 at 12:50 PM, Thomas Gleixner wrote: > The current timer wheel has some drawbacks: ... It looks like this change (commit 500462a9de657f86edaa102f8ab6bff7f7e43fc2 in linux.git) breaks one of the automated test cases I'm using to test hostapd and

Re: [patch 4 14/22] timer: Switch to a non cascading wheel

2016-08-11 Thread Jouni Malinen
On Mon, Jul 4, 2016 at 12:50 PM, Thomas Gleixner wrote: > The current timer wheel has some drawbacks: ... It looks like this change (commit 500462a9de657f86edaa102f8ab6bff7f7e43fc2 in linux.git) breaks one of the automated test cases I'm using to test hostapd and wpa_supplicant with

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-29 Thread Jouni Malinen
meone needs python code to do rfkill operations..). -- Jouni MalinenPGP id EFC895FA

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-29 Thread Jouni Malinen
meone needs python code to do rfkill operations..). -- Jouni MalinenPGP id EFC895FA

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-26 Thread Jouni Malinen
rfkill->idx == ev.idx && rfkill->type == ev.type) + if (rfkill->idx == ev.idx && + (rfkill->type == ev.type || +ev.type == RFKILL_TYPE_ALL)) rfkill_set_block(rfkill, ev.soft); ret = 0; break; -- Jouni MalinenPGP id EFC895FA

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-26 Thread Jouni Malinen
rfkill->idx == ev.idx && rfkill->type == ev.type) + if (rfkill->idx == ev.idx && + (rfkill->type == ev.type || +ev.type == RFKILL_TYPE_ALL)) rfkill_set_block(rfkill, ev.soft); ret = 0; break; -- Jouni MalinenPGP id EFC895FA

Re: [PATCH] ieee80211: Print human-readable disassoc/deauth reason codes

2014-02-10 Thread Jouni Malinen
nticated from %pM (reason: %s)\n", > +bssid, ieee80211_get_reason_code_string(reason_code)); Please don't do this unless ieee80211_get_reason_code_string() includes the actual reason code number for every possible case, i.e., just leave %u print of reason_code here even if t

Re: [PATCH] ieee80211: Print human-readable disassoc/deauth reason codes

2014-02-10 Thread Jouni Malinen
print of reason_code here even if the string is added. -- Jouni MalinenPGP id EFC895FA -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: multiple xor_block() functions

2007-06-02 Thread Jouni Malinen
rypt_ccmp.c should not include linux/raid/xor.h and the xor_block() in CCMP code is a static inline function that should not show up outside the scope of this file. Do we have some magic that makes exported symbols pollute name space for inlined helper functions? -- Jouni Malinen

Re: multiple xor_block() functions

2007-06-02 Thread Jouni Malinen
and the xor_block() in CCMP code is a static inline function that should not show up outside the scope of this file. Do we have some magic that makes exported symbols pollute name space for inlined helper functions? -- Jouni MalinenPGP id EFC895FA

Re: [PATCH 1/2] use list_for_each_entry() for iteration in hostap_ap.c

2007-05-27 Thread Jouni Malinen
f patches for the driver. Could you please send a Signed-off-by line for this later version of the patch? You did it for the first version, but just to be sure, it would be prefered to see this explicitly for each version. -- Jouni MalinenPGP id

Re: [PATCH 1/2] use list_for_each_entry() for iteration in hostap_ap.c

2007-05-27 Thread Jouni Malinen
for the driver. Could you please send a Signed-off-by line for this later version of the patch? You did it for the first version, but just to be sure, it would be prefered to see this explicitly for each version. -- Jouni MalinenPGP id EFC895FA - To unsubscribe

Re: [PATCH 15/16] use-regular-eth-suffix.diff

2007-04-01 Thread Jouni Malinen
"eth%d"; NAK. Host AP driver has been using wlan%d for close to seven years and I see no reason to change it now. This will just cause problems for users. If someone wants to rename the interface to something else, they can do it with number of different ways from

Re: [PATCH 15/16] use-regular-eth-suffix.diff

2007-04-01 Thread Jouni Malinen
to change it now. This will just cause problems for users. If someone wants to rename the interface to something else, they can do it with number of different ways from user space. The kernel default should not be changed at this point. -- Jouni MalinenPGP

Re: Hidden SSID's

2007-02-01 Thread Jouni Malinen
he BSS list based on information from Probe Responses and user space programs will get proper information in the scan results regardless of how the real SSID was learned. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "un

Re: Hidden SSID's

2007-02-01 Thread Jouni Malinen
and user space programs will get proper information in the scan results regardless of how the real SSID was learned. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: Hidden SSID's

2007-01-30 Thread Jouni Malinen
nal SSID when "hiding" the SSID while others just use 0-length SSID. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordom

Re: Hidden SSID's

2007-01-30 Thread Jouni Malinen
rocessed would be likely to leave windows open for reporting incorrect SSID. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More major

Re: Hidden SSID's

2007-01-30 Thread Jouni Malinen
for reporting incorrect SSID. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: Hidden SSID's

2007-01-30 Thread Jouni Malinen
hiding the SSID while others just use 0-length SSID. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: Hidden SSID's

2007-01-29 Thread Jouni Malinen
ill in the missing pieces for the pair. Generating false scan results by locally guessing what the SSID could be is just plain wrong. The scan results need to be based on real frames from the APs. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from

Re: Hidden SSID's

2007-01-29 Thread Jouni Malinen
t in d80211, but I don't think we can remove it > from ieee80211 either. Use of '' is just not acceptable. IMHO, it should be removed from everywhere, including net/ieee80211. The sooner this is done, the better. -- Jouni MalinenPGP id EFC895FA - To u

Re: Hidden SSID's

2007-01-29 Thread Jouni Malinen
in d80211, but I don't think we can remove it from ieee80211 either. Use of 'hidden' is just not acceptable. IMHO, it should be removed from everywhere, including net/ieee80211. The sooner this is done, the better. -- Jouni MalinenPGP id EFC895FA

Re: Hidden SSID's

2007-01-29 Thread Jouni Malinen
for the BSSID,SSID pair. Generating false scan results by locally guessing what the SSID could be is just plain wrong. The scan results need to be based on real frames from the APs. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line

Re: [PATCH 2/2] [NETFILTER] remove bogus hand-coded htonll()

2005-09-03 Thread Jouni Malinen
. In addition, this looks more like swap-8-bytes-unconditionally than doing this based on host byte order.. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH 2/2] [NETFILTER] remove bogus hand-coded htonll()

2005-09-03 Thread Jouni Malinen
like swap-8-bytes-unconditionally than doing this based on host byte order.. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [-mm patch] include/net/ieee80211.h must #include

2005-07-30 Thread Jouni Malinen
LESS_EXT is actually 18 in this tree anyway.. Is there valid need to keep this header file compatible with older kernel versions? -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [git patches] new wireless stuffs

2005-07-30 Thread Jouni Malinen
nd ieee80211 code merge. I would expect the client side functionality to be relatively easy merge, but the AP side functionality may require considerable amount of work due to the current ieee80211 code being more focused on the client side. -- Jouni Malinen

Re: [git patches] new wireless stuffs

2005-07-30 Thread Jouni Malinen
merge. I would expect the client side functionality to be relatively easy merge, but the AP side functionality may require considerable amount of work due to the current ieee80211 code being more focused on the client side. -- Jouni MalinenPGP id

Re: [-mm patch] include/net/ieee80211.h must #include linux/wireless.h

2005-07-30 Thread Jouni Malinen
.. Is there valid need to keep this header file compatible with older kernel versions? -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: 2.6.12-rc2-mm3: hostap: do not #include .c files

2005-04-18 Thread Jouni Malinen
> solution. Agreed and this is on my to-do list, but not very high on it. Some of these would be relatively easy to fix, but the hardware specific ones (different register offsets for PC Card/PLX/PCI) would require quite a bit of changes to get rid of th

Re: 2.6.12-rc2-mm3: hostap: do not #include .c files

2005-04-18 Thread Jouni Malinen
and this is on my to-do list, but not very high on it. Some of these would be relatively easy to fix, but the hardware specific ones (different register offsets for PC Card/PLX/PCI) would require quite a bit of changes to get rid of this. -- Jouni MalinenPGP id

Re: 2.6.x wireless update and status

2005-03-22 Thread Jouni Malinen
e available through wireless-2.6 tree (and -mm for that matter). -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: 2.6.12-rc1-mm1: hostap stack usage

2005-03-22 Thread Jouni Malinen
y common for PC Card drivers in the current kernel tree.. I'll change Host AP to kmalloc this, but someone might consider going through all *_cs.c drivers.. > drivers/net/wireless/hostap/hostap_plx.c: > > prism2_plx_check_cis: > #define CIS_MAX_LEN 256 > u8 cis[CIS_MAX_LEN]; OK. -- J

Re: 2.6.12-rc1-mm1: hostap stack usage

2005-03-22 Thread Jouni Malinen
through all *_cs.c drivers.. drivers/net/wireless/hostap/hostap_plx.c: prism2_plx_check_cis: #define CIS_MAX_LEN 256 u8 cis[CIS_MAX_LEN]; OK. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line unsubscribe linux

Re: 2.6.x wireless update and status

2005-03-22 Thread Jouni Malinen
). -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org