Re: [PATCH v2] thinkad_acpi: Support the battery wear control

2017-12-05 Thread Julian Andres Klode
On Tue, Dec 05, 2017 at 03:22:28PM +0100, Christoph Böhmwalder wrote: > On Sun, Dec 03, 2017 at 11:56:40PM +0100, Ognjen Galic wrote: > > Add support for the ACPI batteries on newer thinkpad models > > (>Sandy Bridge) that support the setting of start and stop > > thresholds. > > > > The actual in

Re: [PATCH] MAINTAINERS: Remove myself as nvec co-maintainer

2015-09-22 Thread Julian Andres Klode
On Sun, Sep 13, 2015 at 05:23:27PM +0200, Julian Andres Klode wrote: > My device broke a long time ago, so I do not have any > chance of testing things or any reason to continue > maintaining it. > > Signed-off-by: Julian Andres Klode > Cc: Marc Dietrich > --- > MAI

[PATCH] MAINTAINERS: Remove myself as nvec co-maintainer

2015-09-13 Thread Julian Andres Klode
My device broke a long time ago, so I do not have any chance of testing things or any reason to continue maintaining it. Signed-off-by: Julian Andres Klode Cc: Marc Dietrich --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b60e2b2..1b2bbc3

Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed

2015-01-31 Thread Julian Andres Klode
gpio line. >> + The gpio line is a generic pin on integrated circuit whose input or >> output pin can be controlled by the user at run time. > > > There's no way this is correct, look at how long your line is. > I'm not even sure if this level of detail is ne

Re: [PATCH] staging: nvec: remove unneccessary 'else' after 'return' statement

2014-07-04 Thread Julian Andres Klode
d line. Use git format-patch to format patches and you can send them using git-send-email. See Documentation/SubmittingPatches for more details Thanks, -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. Be friendly,

Re: [patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Julian Andres Klode
seless cat as well. No point in running two processes when the same can be done in a simpler way in one process, IMO. -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. Please do not top-post if possible. -- To unsub

Re: [ibm-acpi-devel] [PATCH 1/4] thinkpad_acpi: Add support for controlling charge thresholds

2014-04-06 Thread Julian Andres Klode
On Tue, Dec 31, 2013 at 11:46:05PM +0100, Julian Andres Klode wrote: > On Tue, Dec 31, 2013 at 10:12:31AM -0200, Henrique de Moraes Holschuh wrote: > > On Tue, 31 Dec 2013, Julian Andres Klode wrote: > > > We might be able to work around this by simple setting stop = start &g

Re: [ibm-acpi-devel] [PATCH 1/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-12-31 Thread Julian Andres Klode
On Tue, Dec 31, 2013 at 10:12:31AM -0200, Henrique de Moraes Holschuh wrote: > On Tue, 31 Dec 2013, Julian Andres Klode wrote: > > We might be able to work around this by simple setting stop = start > > if a new write causes the stop threshold to be below the start > > thr

Re: [PATCH 1/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-12-30 Thread Julian Andres Klode
On Mon, Dec 30, 2013 at 08:40:45PM -0200, Henrique de Moraes Holschuh wrote: > On Mon, 30 Dec 2013, Henrique de Moraes Holschuh wrote: > > On Mon, 30 Dec 2013, Julian Andres Klode wrote: > > > On Mon, Nov 11, 2013 at 02:56:30PM +0100, Julian Andres Klode wrote: > > >

Re: [PATCH 1/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-12-30 Thread Julian Andres Klode
On Mon, Nov 11, 2013 at 02:56:30PM +0100, Julian Andres Klode wrote: > Add support for battery charge thresholds in new Sandy Bridge and Ivy Bridge > ThinkPads. Based on the unofficial documentation in tpacpi-bat. > > The threshold files support the values '0' for the contr

Re: [PATCH 0/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-12-30 Thread Julian Andres Klode
On Sat, Dec 28, 2013 at 08:10:03PM -0200, Henrique de Moraes Holschuh wrote: > On Sat, 28 Dec 2013, Julian Andres Klode wrote: > > On Mon, Nov 11, 2013 at 02:56:29PM +0100, Julian Andres Klode wrote: > > > This patch series adds support for specifying charging thresholds, >

Re: [PATCH 0/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-12-28 Thread Julian Andres Klode
On Mon, Nov 11, 2013 at 02:56:29PM +0100, Julian Andres Klode wrote: > This patch series adds support for specifying charging thresholds, > forcing a battery to discharge, and inhibiting charging, on ThinkPad > Laptops using Sandy Bridge or newer processors. Hello again, it's

Re: [PATCH 0/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-11-25 Thread Julian Andres Klode
On Mon, Nov 11, 2013 at 02:56:29PM +0100, Julian Andres Klode wrote: > This patch series adds support for specifying charging thresholds, > forcing a battery to discharge, and inhibiting charging, on ThinkPad > Laptops using Sandy Bridge or newer processors. > > The first two pa

Re: [PATCH 1/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-11-13 Thread Julian Andres Klode
On Mon, Nov 11, 2013 at 02:56:30PM +0100, Julian Andres Klode wrote: > +static int __init battery_init(struct ibm_init_struct *iibm) > + for (i = 0; i < BATTERY_MAX_COUNT; i++) { > + int j = 0; > + if (!acpi_evalf(hkey_handle, &state, &

[PATCH 3/4] thinkpad_acpi: battery: Add force_discharge_ac_break attribute

2013-11-11 Thread Julian Andres Klode
Tells the EC to stop a forceful discharging if the AC is disconnected. First needs force_discharge set to 1 to be able to work. Actual functionality is untested, as that attribute is not supported on an X230. Signed-off-by: Julian Andres Klode --- Documentation/laptops/thinkpad-acpi.txt | 4

[PATCH 4/4] thinkpad_acpi: battery: Add inhibit_charge_minutes attribute

2013-11-11 Thread Julian Andres Klode
supported because the ACPI call needed to read the value is not documented/reverse-engineered yet. Signed-off-by: Julian Andres Klode --- Documentation/laptops/thinkpad-acpi.txt | 12 drivers/platform/x86/thinkpad_acpi.c| 34 - 2 files changed, 45

[PATCH 2/4] thinkpad_acpi: battery: Add force_discharge attribute

2013-11-11 Thread Julian Andres Klode
This makes it possible to forcefully discharge a battery. Signed-off-by: Julian Andres Klode --- Documentation/laptops/thinkpad-acpi.txt | 4 +++ drivers/platform/x86/thinkpad_acpi.c| 49 - 2 files changed, 52 insertions(+), 1 deletion(-) diff --git a

[PATCH 1/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-11-11 Thread Julian Andres Klode
. The behaviour of '0' might be confusing, especially for the stop case where it basically seems to mean '100'. Signed-off-by: Julian Andres Klode --- Documentation/laptops/thinkpad-acpi.txt | 17 drivers/platform/x86/thinkpad_acpi.c| 173 ++

[PATCH 0/4] thinkpad_acpi: Add support for controlling charge thresholds

2013-11-11 Thread Julian Andres Klode
ynamically instead of statically using large macros. Added support for up to 3 batteries, unsupported ones will not be exported. - Added 3 more new patches with more features Julian Andres Klode (4): thinkpad_acpi: Add support for controlling charge thresholds thinkpad_acpi: ba

Re: [RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds

2013-11-05 Thread Julian Andres Klode
On Tue, Nov 05, 2013 at 11:18:02AM +0100, Bjørn Mork wrote: > Julian Andres Klode writes: > > > > > +TPACPI_HANDLE(battery, root, "\\_SB.PCI0.LPC.EC.HKEY", > > + "\\_SB.PCI0.LPCB.EC.HKEY", /* X121e, T430u */ > > +

[RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds

2013-11-04 Thread Julian Andres Klode
. The behaviour of '0' might be confusing, especially for the stop case where it basically seems to mean '100'. Signed-off-by: Julian Andres Klode --- Does this look OK so far? There are some other things I want to add (force_discharge and others), but I thought I'd gathe

Re: Why exported const value modified by another driver not updated in original driver

2012-09-04 Thread Julian Andres Klode
compiler optimized the value = 123 away, and replaced value with 123 in the first module everywhere, as it is declared const and thus cannot be changed, so there's no reason to read it from memory. -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAn