Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:48 PM, Julien Gomes wrote: > > > On 2/6/19 1:39 PM, Neil Horman wrote: >> On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: >>> >>> >>> On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: >>>> On Wed

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:39 PM, Neil Horman wrote: > On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: >> >> >> On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: >>> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: >>>> >>>>

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:23 PM, Neil Horman wrote: > On Wed, Feb 06, 2019 at 07:07:23PM -0200, Marcelo Ricardo Leitner wrote: >> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: >>> >>> >>> On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: >>>>

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: >> >> >> On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: >>> On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: >>>> Ma

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe >> structures longer than the current definitions. >> >> This should prevent unjust

[PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
with later kernel uapi headers. Signed-off-by: Julien Gomes --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 9644bdc8e85c..f9717e2789da 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -2311,7 +2311,7

Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-23 Thread Julien Gomes
On 06/23/2017 11:47 AM, David Miller wrote: > From: Julien Gomes <jul...@arista.com> > Date: Fri, 23 Jun 2017 10:52:26 -0700 > >> On 06/23/2017 10:39 AM, David Miller wrote: >> >>> From: Julien Gomes <jul...@arista.com> >>> Date: Wed, 21 Ju

Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-23 Thread Julien Gomes
On 06/23/2017 11:47 AM, David Miller wrote: > From: Julien Gomes > Date: Fri, 23 Jun 2017 10:52:26 -0700 > >> On 06/23/2017 10:39 AM, David Miller wrote: >> >>> From: Julien Gomes >>> Date: Wed, 21 Jun 2017 10:58:10 -0700 >>> >>>>

Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-23 Thread Julien Gomes
On 06/23/2017 10:39 AM, David Miller wrote: > From: Julien Gomes <jul...@arista.com> > Date: Wed, 21 Jun 2017 10:58:10 -0700 > >> When sending a cache report on mroute_sk, mroute will emit a >> "pending queue full" warning for every error value returned by >

Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-23 Thread Julien Gomes
On 06/23/2017 10:39 AM, David Miller wrote: > From: Julien Gomes > Date: Wed, 21 Jun 2017 10:58:10 -0700 > >> When sending a cache report on mroute_sk, mroute will emit a >> "pending queue full" warning for every error value returned by >> sock_queue_rcv_skb

[PATCH net-next 2/2] ip6mr: restrict mroute6 "queue full" warning to related error values

2017-06-21 Thread Julien Gomes
or ENOBUFS seems more appropriate. Signed-off-by: Julien Gomes <jul...@arista.com> --- net/ipv6/ip6mr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index 7454850f2098..62fe5fd64f22 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip

[PATCH net-next 2/2] ip6mr: restrict mroute6 "queue full" warning to related error values

2017-06-21 Thread Julien Gomes
or ENOBUFS seems more appropriate. Signed-off-by: Julien Gomes --- net/ipv6/ip6mr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index 7454850f2098..62fe5fd64f22 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -1215,7 +1215,8 @@

[PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-21 Thread Julien Gomes
or ENOBUFS seems more appropriate. Signed-off-by: Julien Gomes <jul...@arista.com> --- net/ipv4/ipmr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index a1d521be612b..ace12cddb9de 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@

[PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-21 Thread Julien Gomes
or ENOBUFS seems more appropriate. Signed-off-by: Julien Gomes --- net/ipv4/ipmr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index a1d521be612b..ace12cddb9de 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -1068,7 +1068,8 @@

[PATCH net-next v3 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-20 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> Reviewed-by: Nikolay Aleks

[PATCH net-next v3 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-20 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes Reviewed-by: Nikolay Aleksandrov --- include/uapi/linux/rtnetlink.h | 3

[PATCH net-next v3 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-20 Thread Julien Gomes
ed-off-by: Julien Gomes <jul...@arista.com> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/uapi/linux/rtnetlink.h | 4 net/core/rtnetlink.c | 13 + 2 files changed, 17 insertions(+) diff --git a/include/uapi/linux/rtnetlink.h b/

[PATCH net-next v3 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-20 Thread Julien Gomes
Add RTNLGRP_{IPV4,IPV6}_MROUTE_R as two new restricted groups for the NETLINK_ROUTE family. Binding to these groups specifically requires CAP_NET_ADMIN to allow multicast of sensitive messages (e.g. mroute cache reports). Suggested-by: Nikolay Aleksandrov Signed-off-by: Julien Gomes Signed-off

[PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute6_sk, without the added mrt6msg header. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi/linux/mroute6.h | 12 net/ipv6/ip6mr.c

[PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute6_sk, without the added mrt6msg header. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/mroute6.h | 12 net/ipv6/ip6mr.c | 71 ++-- 2 files changed, 81

[PATCH net-next v3 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-20 Thread Julien Gomes
calculation for {igmp,mrt6}msg_netlink_event in separate functions - Increased vif id attributes size from u8 to u32 Julien Gomes (4): rtnetlink: add NEWCACHEREPORT message type rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute ipmr: add netlink notifications on igmpmsg cache

[PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute_sk, without the added igmpmsg header. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi/linux/mroute.h | 12 net/ipv4/ipmr.c

[PATCH net-next v3 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-20 Thread Julien Gomes
calculation for {igmp,mrt6}msg_netlink_event in separate functions - Increased vif id attributes size from u8 to u32 Julien Gomes (4): rtnetlink: add NEWCACHEREPORT message type rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute ipmr: add netlink notifications on igmpmsg cache

[PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute_sk, without the added igmpmsg header. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/mroute.h | 12 net/ipv4/ipmr.c | 69 +++-- 2 files changed, 79

[PATCH net-next v2 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-19 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi/linux/rtn

[PATCH net-next v2 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-19 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/rtnetlink.h | 3 +++ security/selinux/nlmsgtab.c| 3

[PATCH net-next v2 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-19 Thread Julien Gomes
data copy to handle non-linear packets in ipmr/ip6mr cache report Netlink notification creation - Added two rtnetlink groups with restricted-binding - Changed cache report notified groups from RTNL_{IPV4,IPV6}_MROUTE to the new restricted groups in ipmr/ip6mr Julien Gomes (4): rtnetlink: add

[PATCH net-next v2 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-19 Thread Julien Gomes
data copy to handle non-linear packets in ipmr/ip6mr cache report Netlink notification creation - Added two rtnetlink groups with restricted-binding - Changed cache report notified groups from RTNL_{IPV4,IPV6}_MROUTE to the new restricted groups in ipmr/ip6mr Julien Gomes (4): rtnetlink: add

[PATCH net-next v2 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-19 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute_sk, without the added igmpmsg header. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi/linux/mroute.h | 12 net/ipv4/ipmr.c

[PATCH net-next v2 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-19 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute_sk, without the added igmpmsg header. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/mroute.h | 12 net/ipv4/ipmr.c | 67 +++-- 2 files changed, 77

[PATCH net-next v2 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-19 Thread Julien Gomes
Add RTNLGRP_{IPV4,IPV6}_MROUTE_R as two new restricted groups for the NETLINK_ROUTE family. Binding to these groups specifically requires CAP_NET_ADMIN to allow multicast of sensitive messages (e.g. mroute cache reports). Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi

[PATCH net-next v2 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-19 Thread Julien Gomes
Add RTNLGRP_{IPV4,IPV6}_MROUTE_R as two new restricted groups for the NETLINK_ROUTE family. Binding to these groups specifically requires CAP_NET_ADMIN to allow multicast of sensitive messages (e.g. mroute cache reports). Signed-off-by: Julien Gomes --- include/uapi/linux/rtnetlink.h | 4

[PATCH net-next v2 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-19 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute6_sk, without the added mrt6msg header. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi/linux/mroute6.h | 12 net/ipv6/ip6mr.c

[PATCH net-next v2 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-19 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute6_sk, without the added mrt6msg header. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/mroute6.h | 12 net/ipv6/ip6mr.c | 67 ++-- 2 files changed, 77

Re: [PATCH net-next 2/3] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-14 Thread Julien Gomes
On 06/14/2017 12:56 AM, Nicolas Dichtel wrote: > Le 13/06/2017 à 19:08, Julien Gomes a écrit : >> Add Netlink notifications on cache reports in ipmr, in addition to the >> existing igmpmsg sent to mroute_sk. >> Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE.

Re: [PATCH net-next 2/3] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-14 Thread Julien Gomes
On 06/14/2017 12:56 AM, Nicolas Dichtel wrote: > Le 13/06/2017 à 19:08, Julien Gomes a écrit : >> Add Netlink notifications on cache reports in ipmr, in addition to the >> existing igmpmsg sent to mroute_sk. >> Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE.

[PATCH net-next 1/3] rtnetlink: add NEWCACHEREPORT message type

2017-06-13 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi/linux/rtn

[PATCH net-next 1/3] rtnetlink: add NEWCACHEREPORT message type

2017-06-13 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/rtnetlink.h | 3 +++ security/selinux/nlmsgtab.c| 3

[PATCH net-next 0/3] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-13 Thread Julien Gomes
notifications in addition to the existing igmpmsg/mrt6msg to give user programs a way to handle cache reports in parallel with multiple sockets other than the mroute/mroute6 socket. Julien Gomes (3): rtnetlink: add NEWCACHEREPORT message type ipmr: add netlink notifications on igmpmsg cache reports

[PATCH net-next 0/3] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-13 Thread Julien Gomes
notifications in addition to the existing igmpmsg/mrt6msg to give user programs a way to handle cache reports in parallel with multiple sockets other than the mroute/mroute6 socket. Julien Gomes (3): rtnetlink: add NEWCACHEREPORT message type ipmr: add netlink notifications on igmpmsg cache reports

[PATCH net-next 2/3] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-13 Thread Julien Gomes
. PKT attribute is the packet sent to mroute_sk, without the added igmpmsg header. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi/linux/mroute.h | 11 net/ipv4/ipmr.c

[PATCH net-next 3/3] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-13 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute6_sk, without the added mrt6msg header. Suggested-by: Ryan Halbrook <halbr...@arista.com> Signed-off-by: Julien Gomes <jul...@arista.com> --- include/uapi/linux/mroute6.h | 11 net/ipv6/ip6mr.c

[PATCH net-next 3/3] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-13 Thread Julien Gomes
header. PKT attribute is the packet sent to mroute6_sk, without the added mrt6msg header. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/mroute6.h | 11 net/ipv6/ip6mr.c | 63 ++-- 2 files changed, 72

[PATCH net-next 2/3] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-13 Thread Julien Gomes
. PKT attribute is the packet sent to mroute_sk, without the added igmpmsg header. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/mroute.h | 11 net/ipv4/ipmr.c | 63 +++-- 2 files changed, 72 insertions